[INFO] cloning repository https://github.com/joshatdia/ggml-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/joshatdia/ggml-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoshatdia%2Fggml-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoshatdia%2Fggml-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c209f94d143704fd1ae8f126321a56146f1843ef [INFO] linting joshatdia/ggml-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoshatdia%2Fggml-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/joshatdia/ggml-rs [INFO] finished tweaking git repo https://github.com/joshatdia/ggml-rs [INFO] tweaked toml for git repo https://github.com/joshatdia/ggml-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/joshatdia/ggml-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/joshatdia/ggml-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca36056f5c0a5d58eefeb3ed7f25b12b12017705888140ccb28a891a040f843d [INFO] running `Command { std: "docker" "start" "-a" "ca36056f5c0a5d58eefeb3ed7f25b12b12017705888140ccb28a891a040f843d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca36056f5c0a5d58eefeb3ed7f25b12b12017705888140ccb28a891a040f843d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca36056f5c0a5d58eefeb3ed7f25b12b12017705888140ccb28a891a040f843d", kill_on_drop: false }` [INFO] [stdout] ca36056f5c0a5d58eefeb3ed7f25b12b12017705888140ccb28a891a040f843d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1fc0338a2b393ddf770830242c9afdc10f0799510ddbf135a0458ad722e90372 [INFO] running `Command { std: "docker" "start" "-a" "1fc0338a2b393ddf770830242c9afdc10f0799510ddbf135a0458ad722e90372", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling bindgen v0.71.1 [INFO] [stderr] Compiling libloading v0.8.9 [INFO] [stderr] Compiling rustc-hash v2.1.1 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling cc v1.2.45 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling ggml-rs v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable `current_target` is assigned to, but never used [INFO] [stdout] --> build.rs:633:13 [INFO] [stdout] | [INFO] [stdout] 633 | let mut current_target: Option = None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_current_target` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `current_target` is assigned to, but never used [INFO] [stdout] --> build.rs:711:13 [INFO] [stdout] | [INFO] [stdout] 711 | let mut current_target: Option = None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_current_target` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_target` is never read [INFO] [stdout] --> build.rs:657:21 [INFO] [stdout] | [INFO] [stdout] 657 | current_target = Some(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_target` is never read [INFO] [stdout] --> build.rs:651:21 [INFO] [stdout] | [INFO] [stdout] 651 | current_target = Some(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_target` is never read [INFO] [stdout] --> build.rs:684:21 [INFO] [stdout] | [INFO] [stdout] 684 | current_target = None; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_target` is never read [INFO] [stdout] --> build.rs:671:21 [INFO] [stdout] | [INFO] [stdout] 671 | current_target = None; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_target` is never read [INFO] [stdout] --> build.rs:738:17 [INFO] [stdout] | [INFO] [stdout] 738 | current_target = Some(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_target` is never read [INFO] [stdout] --> build.rs:758:21 [INFO] [stdout] | [INFO] [stdout] 758 | current_target = None; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> build.rs:240:34 [INFO] [stdout] | [INFO] [stdout] 240 | let mut config = Config::new(&ggml_root); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `ggml_root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> build.rs:457:45 [INFO] [stdout] | [INFO] [stdout] 457 | fn patch_ggml_config_cmake(cmake_build_dir: &PathBuf, install_prefix: &PathBuf, namespace: &str) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 457 - fn patch_ggml_config_cmake(cmake_build_dir: &PathBuf, install_prefix: &PathBuf, namespace: &str) { [INFO] [stdout] 457 + fn patch_ggml_config_cmake(cmake_build_dir: &Path, install_prefix: &PathBuf, namespace: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> build.rs:457:71 [INFO] [stdout] | [INFO] [stdout] 457 | fn patch_ggml_config_cmake(cmake_build_dir: &PathBuf, install_prefix: &PathBuf, namespace: &str) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 457 - fn patch_ggml_config_cmake(cmake_build_dir: &PathBuf, install_prefix: &PathBuf, namespace: &str) { [INFO] [stdout] 457 + fn patch_ggml_config_cmake(cmake_build_dir: &PathBuf, install_prefix: &Path, namespace: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> build.rs:543:14 [INFO] [stdout] | [INFO] [stdout] 543 | &format!("find_library(GGML_LIBRARY ggml\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"find_library(GGML_LIBRARY ggml\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> build.rs:547:14 [INFO] [stdout] | [INFO] [stdout] 547 | &format!("find_library(GGML_LIBRARY ggml "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"find_library(GGML_LIBRARY ggml ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> build.rs:553:14 [INFO] [stdout] | [INFO] [stdout] 553 | &format!("find_library(GGML_BASE_LIBRARY ggml-base\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"find_library(GGML_BASE_LIBRARY ggml-base\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> build.rs:557:14 [INFO] [stdout] | [INFO] [stdout] 557 | &format!("find_library(GGML_BASE_LIBRARY ggml-base "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"find_library(GGML_BASE_LIBRARY ggml-base ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> build.rs:591:14 [INFO] [stdout] | [INFO] [stdout] 591 | &format!(" ggml\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" ggml\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> build.rs:595:14 [INFO] [stdout] | [INFO] [stdout] 595 | &format!(" ggml "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" ggml ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> build.rs:599:14 [INFO] [stdout] | [INFO] [stdout] 599 | &format!(" ggml)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" ggml)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> build.rs:608:39 [INFO] [stdout] | [INFO] [stdout] 608 | patched = patched.replace(&wrong_namespace, namespace); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `wrong_namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> build.rs:786:16 [INFO] [stdout] | [INFO] [stdout] 786 | } else if namespace == "ggml_llama" { [INFO] [stdout] | ________________^ [INFO] [stdout] 787 | | if patched.contains("ggml_whisper-") || patched.contains(" ggml_whisper") { [INFO] [stdout] 788 | | eprintln!("cargo:warning=[PATCH] ⚠ Enforcing llama namespace: replacing ggml_whisper* → ggml_llama*"); [INFO] [stdout] 789 | | patched = patched.replace("ggml_whisper-", "ggml_llama-"); [INFO] [stdout] ... | [INFO] [stdout] 792 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 786 ~ } else if namespace == "ggml_llama" [INFO] [stdout] 787 ~ && (patched.contains("ggml_whisper-") || patched.contains(" ggml_whisper")) { [INFO] [stdout] 788 | eprintln!("cargo:warning=[PATCH] ⚠ Enforcing llama namespace: replacing ggml_whisper* → ggml_llama*"); [INFO] [stdout] 789 | patched = patched.replace("ggml_whisper-", "ggml_llama-"); [INFO] [stdout] 790 | patched = patched.replace(" ggml_whisper", " ggml_llama"); [INFO] [stdout] 791 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> build.rs:827:40 [INFO] [stdout] | [INFO] [stdout] 827 | fn copy_runtime_libraries(destination: &PathBuf, lib_dir: &PathBuf, namespace: &str) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 827 - fn copy_runtime_libraries(destination: &PathBuf, lib_dir: &PathBuf, namespace: &str) { [INFO] [stdout] 827 + fn copy_runtime_libraries(destination: &Path, lib_dir: &PathBuf, namespace: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> build.rs:827:59 [INFO] [stdout] | [INFO] [stdout] 827 | fn copy_runtime_libraries(destination: &PathBuf, lib_dir: &PathBuf, namespace: &str) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 827 - fn copy_runtime_libraries(destination: &PathBuf, lib_dir: &PathBuf, namespace: &str) { [INFO] [stdout] 827 + fn copy_runtime_libraries(destination: &PathBuf, lib_dir: &Path, namespace: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> build.rs:902:45 [INFO] [stdout] | [INFO] [stdout] 902 | } else if cfg!(target_os = "macos") { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 903 | | lib_dir.join(format!("lib{}.{}", lib_name, lib_ext)) [INFO] [stdout] 904 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> build.rs:904:16 [INFO] [stdout] | [INFO] [stdout] 904 | } else { [INFO] [stdout] | ________________^ [INFO] [stdout] 905 | | lib_dir.join(format!("lib{}.{}", lib_name, lib_ext)) [INFO] [stdout] 906 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> build.rs:921:49 [INFO] [stdout] | [INFO] [stdout] 921 | } else if cfg!(target_os = "macos") { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 922 | | destination.join("build").join("src").join(format!("lib{}.{}", lib_name, lib_ext)) [INFO] [stdout] 923 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> build.rs:923:20 [INFO] [stdout] | [INFO] [stdout] 923 | } else { [INFO] [stdout] | ____________________^ [INFO] [stdout] 924 | | destination.join("build").join("src").join(format!("lib{}.{}", lib_name, lib_ext)) [INFO] [stdout] 925 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 25s [INFO] running `Command { std: "docker" "inspect" "1fc0338a2b393ddf770830242c9afdc10f0799510ddbf135a0458ad722e90372", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fc0338a2b393ddf770830242c9afdc10f0799510ddbf135a0458ad722e90372", kill_on_drop: false }` [INFO] [stdout] 1fc0338a2b393ddf770830242c9afdc10f0799510ddbf135a0458ad722e90372