[INFO] cloning repository https://github.com/jonmast/quarto [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jonmast/quarto" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonmast%2Fquarto", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonmast%2Fquarto'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 64ba28124aac11419baae090f63c6605b96b3474 [INFO] linting jonmast/quarto against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonmast%2Fquarto" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jonmast/quarto [INFO] finished tweaking git repo https://github.com/jonmast/quarto [INFO] tweaked toml for git repo https://github.com/jonmast/quarto written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jonmast/quarto on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jonmast/quarto already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memoffset v0.5.3 [INFO] [stderr] Downloaded hermit-abi v0.1.6 [INFO] [stderr] Downloaded crossbeam-queue v0.2.1 [INFO] [stderr] Downloaded crossbeam-epoch v0.8.0 [INFO] [stderr] Downloaded crossbeam-utils v0.7.0 [INFO] [stderr] Downloaded rayon-core v1.7.0 [INFO] [stderr] Downloaded crossbeam-deque v0.7.2 [INFO] [stderr] Downloaded rayon v1.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e72cf824b9585d587d0fd20cb1c5ed557ec5574de627edb3851ab7e5eefad906 [INFO] running `Command { std: "docker" "start" "-a" "e72cf824b9585d587d0fd20cb1c5ed557ec5574de627edb3851ab7e5eefad906", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e72cf824b9585d587d0fd20cb1c5ed557ec5574de627edb3851ab7e5eefad906", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e72cf824b9585d587d0fd20cb1c5ed557ec5574de627edb3851ab7e5eefad906", kill_on_drop: false }` [INFO] [stdout] e72cf824b9585d587d0fd20cb1c5ed557ec5574de627edb3851ab7e5eefad906 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a5cea59bb7a7fe1930caa39605320f1516a9d758c88f190d53350e29778d99a [INFO] running `Command { std: "docker" "start" "-a" "5a5cea59bb7a7fe1930caa39605320f1516a9d758c88f190d53350e29778d99a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking quarto v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:33:31 [INFO] [stdout] | [INFO] [stdout] 33 | fn play(board: Board, pieces: &Vec, current_player: &Player, level: usize) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 33 ~ fn play(board: Board, pieces: &[Piece], current_player: &Player, level: usize) -> i64 { [INFO] [stdout] 34 | if pieces.len() == 0 || level >= MAX_DEPTH { [INFO] [stdout] ... [INFO] [stdout] 61 | .map(|(row_idx, square_idx, piece)| { [INFO] [stdout] 62 ~ let remaining = pieces.to_owned().into_iter().filter(|p| p != piece).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if pieces.len() == 0 || level >= MAX_DEPTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pieces.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:51:41 [INFO] [stdout] | [INFO] [stdout] 51 | .filter(|(row_idx, square_idx)| !board[*row_idx][*square_idx].is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board[*row_idx][*square_idx].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/main.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | (&mut moves).shuffle(&mut rng); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `moves` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return true; [INFO] [stdout] 224 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:226:17 [INFO] [stdout] | [INFO] [stdout] 226 | None => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 226 - None => return false, [INFO] [stdout] 226 + None => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:33:31 [INFO] [stdout] | [INFO] [stdout] 33 | fn play(board: Board, pieces: &Vec, current_player: &Player, level: usize) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 33 ~ fn play(board: Board, pieces: &[Piece], current_player: &Player, level: usize) -> i64 { [INFO] [stdout] 34 | if pieces.len() == 0 || level >= MAX_DEPTH { [INFO] [stdout] ... [INFO] [stdout] 61 | .map(|(row_idx, square_idx, piece)| { [INFO] [stdout] 62 ~ let remaining = pieces.to_owned().into_iter().filter(|p| p != piece).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if pieces.len() == 0 || level >= MAX_DEPTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pieces.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:51:41 [INFO] [stdout] | [INFO] [stdout] 51 | .filter(|(row_idx, square_idx)| !board[*row_idx][*square_idx].is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board[*row_idx][*square_idx].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/main.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | (&mut moves).shuffle(&mut rng); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `moves` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return true; [INFO] [stdout] 224 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:226:17 [INFO] [stdout] | [INFO] [stdout] 226 | None => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 226 - None => return false, [INFO] [stdout] 226 + None => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/main.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | assert_eq!(is_win(&board), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 262 - assert_eq!(is_win(&board), true); [INFO] [stdout] 262 + assert!(is_win(&board)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/main.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | assert_eq!(is_win(&board), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 293 - assert_eq!(is_win(&board), true); [INFO] [stdout] 293 + assert!(is_win(&board)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/main.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | assert_eq!(is_win(&board), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 324 - assert_eq!(is_win(&board), true); [INFO] [stdout] 324 + assert!(is_win(&board)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/main.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 331 | assert_eq!(is_win(&board), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 331 - assert_eq!(is_win(&board), false); [INFO] [stdout] 331 + assert!(!is_win(&board)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.35s [INFO] running `Command { std: "docker" "inspect" "5a5cea59bb7a7fe1930caa39605320f1516a9d758c88f190d53350e29778d99a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a5cea59bb7a7fe1930caa39605320f1516a9d758c88f190d53350e29778d99a", kill_on_drop: false }` [INFO] [stdout] 5a5cea59bb7a7fe1930caa39605320f1516a9d758c88f190d53350e29778d99a