[INFO] cloning repository https://github.com/jonay2000/d-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jonay2000/d-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonay2000%2Fd-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonay2000%2Fd-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 985767bb220fa3a321c7e0be5897d0904ae8a951 [INFO] linting jonay2000/d-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonay2000%2Fd-rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jonay2000/d-rs [INFO] finished tweaking git repo https://github.com/jonay2000/d-rs [INFO] tweaked toml for git repo https://github.com/jonay2000/d-rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jonay2000/d-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jonay2000/d-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded temp-file v0.1.7 [INFO] [stderr] Downloaded os_str_bytes v6.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bfefa05632832c5a60a2a84df63bd66c43ba4aaad018b6da576e73999fd502fb [INFO] running `Command { std: "docker" "start" "-a" "bfefa05632832c5a60a2a84df63bd66c43ba4aaad018b6da576e73999fd502fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bfefa05632832c5a60a2a84df63bd66c43ba4aaad018b6da576e73999fd502fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bfefa05632832c5a60a2a84df63bd66c43ba4aaad018b6da576e73999fd502fb", kill_on_drop: false }` [INFO] [stdout] bfefa05632832c5a60a2a84df63bd66c43ba4aaad018b6da576e73999fd502fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ab4fab3ba28799382fcf54dc15b707b5dc74ce65157148404bb5cc403f23ea55 [INFO] running `Command { std: "docker" "start" "-a" "ab4fab3ba28799382fcf54dc15b707b5dc74ce65157148404bb5cc403f23ea55", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling libc v0.2.144 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking os_str_bytes v6.5.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Checking temp-file v0.1.7 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking fancy-regex v0.11.0 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking d-rs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/splitter/str_sep.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn split_on_str<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, sep: &str) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/splitter/ws.rs:12:24 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn split_on_ws<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/mapper/python.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn map_to_python<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, program: &str) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/mapper/regex.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn map_regex<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, regex: Regex, replace: &str, single: bool, find: bool) -... [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mapper/regex.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 81 | if !find || (find && regex.find(&s)?.is_some()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 81 - if !find || (find && regex.find(&s)?.is_some()) { [INFO] [stdout] 81 + if !(find && regex.find(&s)?.is_none()) { [INFO] [stdout] | [INFO] [stdout] 81 - if !find || (find && regex.find(&s)?.is_some()) { [INFO] [stdout] 81 + if !find || regex.find(&s)?.is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/mapper/regex.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn map<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, regex: &str, replace: &str, single: bool, find: bool) -> DResu... [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/filterer/regex.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn map_regex<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, regex: Regex, single: bool) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/filterer/regex.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn map<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, regex: &str, single: bool) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/reducer/sum.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn sum<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/reducer/prod.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn product<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/main.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 17 | fn subcommands(arena: &Arena) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 17 | fn subcommands(arena: &Arena) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/splitter/str_sep.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn split_on_str<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, sep: &str) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/splitter/ws.rs:12:24 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn split_on_ws<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/mapper/python.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn map_to_python<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, program: &str) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/mapper/regex.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn map_regex<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, regex: Regex, replace: &str, single: bool, find: bool) -... [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mapper/regex.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 81 | if !find || (find && regex.find(&s)?.is_some()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 81 - if !find || (find && regex.find(&s)?.is_some()) { [INFO] [stdout] 81 + if !(find && regex.find(&s)?.is_none()) { [INFO] [stdout] | [INFO] [stdout] 81 - if !find || (find && regex.find(&s)?.is_some()) { [INFO] [stdout] 81 + if !find || regex.find(&s)?.is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/mapper/regex.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn map<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, regex: &str, replace: &str, single: bool, find: bool) -> DResu... [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/filterer/regex.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn map_regex<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, regex: Regex, single: bool) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/filterer/regex.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn map<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write, regex: &str, single: bool) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/reducer/sum.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn sum<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/reducer/prod.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn product<'a>(&self, inp: &mut dyn BufRead, out: &mut dyn Write) -> DResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/main.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 17 | fn subcommands(arena: &Arena) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 17 | fn subcommands(arena: &Arena) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.08s [INFO] running `Command { std: "docker" "inspect" "ab4fab3ba28799382fcf54dc15b707b5dc74ce65157148404bb5cc403f23ea55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab4fab3ba28799382fcf54dc15b707b5dc74ce65157148404bb5cc403f23ea55", kill_on_drop: false }` [INFO] [stdout] ab4fab3ba28799382fcf54dc15b707b5dc74ce65157148404bb5cc403f23ea55