[INFO] cloning repository https://github.com/johnstanforth/dotfig [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/johnstanforth/dotfig" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjohnstanforth%2Fdotfig", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjohnstanforth%2Fdotfig'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4928f05fcf913fe44806570d7969efe967c3849e [INFO] linting johnstanforth/dotfig against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjohnstanforth%2Fdotfig" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/johnstanforth/dotfig [INFO] finished tweaking git repo https://github.com/johnstanforth/dotfig [INFO] tweaked toml for git repo https://github.com/johnstanforth/dotfig written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/johnstanforth/dotfig on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/johnstanforth/dotfig already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded git2 v0.19.0 [INFO] [stderr] Downloaded libgit2-sys v0.17.0+1.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc2a30a295df915a4b904ef6b68202a72fccfa2d810d6a1ed32386c1e1763cc8 [INFO] running `Command { std: "docker" "start" "-a" "fc2a30a295df915a4b904ef6b68202a72fccfa2d810d6a1ed32386c1e1763cc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc2a30a295df915a4b904ef6b68202a72fccfa2d810d6a1ed32386c1e1763cc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc2a30a295df915a4b904ef6b68202a72fccfa2d810d6a1ed32386c1e1763cc8", kill_on_drop: false }` [INFO] [stdout] fc2a30a295df915a4b904ef6b68202a72fccfa2d810d6a1ed32386c1e1763cc8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d97af6a6d17f1ed7b3b613ce561db227cb7f50b9c8317800916ead802b97f5e1 [INFO] running `Command { std: "docker" "start" "-a" "d97af6a6d17f1ed7b3b613ce561db227cb7f50b9c8317800916ead802b97f5e1", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling find-msvc-tools v0.1.4 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking clap_builder v4.5.49 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling cc v1.2.41 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking clap v4.5.49 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking dotfig v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/host_detection.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | use anyhow::{Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/host_detection.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | use anyhow::{Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/host_detection.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | / if let Some(name) = os_name { [INFO] [stdout] 126 | | Some(( [INFO] [stdout] 127 | | name, [INFO] [stdout] 128 | | os_version.unwrap_or_else(|| "unknown".to_string()), [INFO] [stdout] ... | [INFO] [stdout] 132 | | None [INFO] [stdout] 133 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 125 ~ os_name.map(|name| ( [INFO] [stdout] 126 + name, [INFO] [stdout] 127 + os_version.unwrap_or_else(|| "unknown".to_string()), [INFO] [stdout] 128 + os_full.unwrap_or_else(|| "unknown".to_string()), [INFO] [stdout] 129 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/host_detection.rs:203:18 [INFO] [stdout] | [INFO] [stdout] 203 | .or_else(|| detect_os_uname()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `detect_os_uname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validation.rs:132:34 [INFO] [stdout] | [INFO] [stdout] 132 | if !symlink_path.exists() && !symlink_path.symlink_metadata().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `symlink_path.symlink_metadata().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validation.rs:173:34 [INFO] [stdout] | [INFO] [stdout] 173 | if !symlink_path.exists() && !symlink_path.symlink_metadata().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `symlink_path.symlink_metadata().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/validation.rs:199:37 [INFO] [stdout] | [INFO] [stdout] 199 | Ok(PathBuf::from(home).join(&path[2..])) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/validation.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | if path.starts_with("~/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 196 ~ if let Some() = path.strip_prefix("~/") { [INFO] [stdout] 197 | let home = env::var("HOME") [INFO] [stdout] 198 | .context("HOME environment variable not set")?; [INFO] [stdout] 199 ~ Ok(PathBuf::from(home).join()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/host_detection.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | / if let Some(name) = os_name { [INFO] [stdout] 126 | | Some(( [INFO] [stdout] 127 | | name, [INFO] [stdout] 128 | | os_version.unwrap_or_else(|| "unknown".to_string()), [INFO] [stdout] ... | [INFO] [stdout] 132 | | None [INFO] [stdout] 133 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 125 ~ os_name.map(|name| ( [INFO] [stdout] 126 + name, [INFO] [stdout] 127 + os_version.unwrap_or_else(|| "unknown".to_string()), [INFO] [stdout] 128 + os_full.unwrap_or_else(|| "unknown".to_string()), [INFO] [stdout] 129 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/host_detection.rs:203:18 [INFO] [stdout] | [INFO] [stdout] 203 | .or_else(|| detect_os_uname()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `detect_os_uname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validation.rs:132:34 [INFO] [stdout] | [INFO] [stdout] 132 | if !symlink_path.exists() && !symlink_path.symlink_metadata().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `symlink_path.symlink_metadata().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validation.rs:173:34 [INFO] [stdout] | [INFO] [stdout] 173 | if !symlink_path.exists() && !symlink_path.symlink_metadata().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `symlink_path.symlink_metadata().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/validation.rs:199:37 [INFO] [stdout] | [INFO] [stdout] 199 | Ok(PathBuf::from(home).join(&path[2..])) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/validation.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | if path.starts_with("~/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 196 ~ if let Some() = path.strip_prefix("~/") { [INFO] [stdout] 197 | let home = env::var("HOME") [INFO] [stdout] 198 | .context("HOME environment variable not set")?; [INFO] [stdout] 199 ~ Ok(PathBuf::from(home).join()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Input` [INFO] [stdout] --> src/main.rs:4:39 [INFO] [stdout] | [INFO] [stdout] 4 | use dialoguer::{MultiSelect, Confirm, Input}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FetchOptions` and `build::RepoBuilder` [INFO] [stdout] --> src/main.rs:5:36 [INFO] [stdout] | [INFO] [stdout] 5 | use git2::{Repository, BranchType, build::RepoBuilder, Cred, RemoteCallbacks, FetchOptions, PushOptions}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `generate_profile_name` [INFO] [stdout] --> src/main.rs:16:48 [INFO] [stdout] | [INFO] [stdout] 16 | use dotfig::host_detection::{detect_host_info, generate_profile_name}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Input` [INFO] [stdout] --> src/main.rs:4:39 [INFO] [stdout] | [INFO] [stdout] 4 | use dialoguer::{MultiSelect, Confirm, Input}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FetchOptions` and `build::RepoBuilder` [INFO] [stdout] --> src/main.rs:5:36 [INFO] [stdout] | [INFO] [stdout] 5 | use git2::{Repository, BranchType, build::RepoBuilder, Cred, RemoteCallbacks, FetchOptions, PushOptions}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `generate_profile_name` [INFO] [stdout] --> src/main.rs:16:48 [INFO] [stdout] | [INFO] [stdout] 16 | use dotfig::host_detection::{detect_host_info, generate_profile_name}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DOT8_PROFILES_DIR` is never used [INFO] [stdout] --> src/main.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const DOT8_PROFILES_DIR: &str = "dot8_profiles"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generate_destination_path_temp` is never used [INFO] [stdout] --> src/main.rs:2539:4 [INFO] [stdout] | [INFO] [stdout] 2539 | fn generate_destination_path_temp(source: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initialize_dot8_global` is never used [INFO] [stdout] --> src/main.rs:3246:4 [INFO] [stdout] | [INFO] [stdout] 3246 | fn initialize_dot8_global(config: &ResolvedConfig) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:253:25 [INFO] [stdout] | [INFO] [stdout] 253 | Cli::parse_from(&["dotfig", "--help"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["dotfig", "--help"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:272:59 [INFO] [stdout] | [INFO] [stdout] 272 | handle_profiles_create(&cli, &config, &name, clone_from.as_deref())?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:275:59 [INFO] [stdout] | [INFO] [stdout] 275 | handle_profiles_delete(&cli, &config, &name, *force)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:278:66 [INFO] [stdout] | [INFO] [stdout] 278 | handle_profiles_delete_remote(&cli, &config, &name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:281:59 [INFO] [stdout] | [INFO] [stdout] 281 | handle_profiles_switch(&cli, &config, &name, *dry_run)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:284:57 [INFO] [stdout] | [INFO] [stdout] 284 | handle_profiles_pull(&cli, &config, &name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:287:56 [INFO] [stdout] | [INFO] [stdout] 287 | handle_profiles_set(&cli, &config, &name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:321:33 [INFO] [stdout] | [INFO] [stdout] 321 | handle_remote(&cli, &target)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:325:43 [INFO] [stdout] | [INFO] [stdout] 325 | handle_migrate(&cli, &config, &old_path)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `old_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:329:40 [INFO] [stdout] | [INFO] [stdout] 329 | handle_copy(&cli, &config, &source, dest.as_deref())?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:333:40 [INFO] [stdout] | [INFO] [stdout] 333 | handle_diff(&cli, &config, &source, target.as_deref())?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:420:34 [INFO] [stdout] | [INFO] [stdout] 420 | remove_local_profile(&config, &local_dot8_repo_path, profile, &config.dot8_profiles_path, cli.quiet, false)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:429:23 [INFO] [stdout] | [INFO] [stdout] 429 | pull_profiles(&config, &local_dot8_repo_path, &to_pull, &config.dot8_profiles_path, cli.quiet, cli.debug)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `info.worktree_path` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:593:85 [INFO] [stdout] | [INFO] [stdout] 592 | if cli.verbose && info.worktree_path.is_some() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] 593 | println!(" Path: {}/{}", config.local_dotfig_root.display(), info.worktree_path.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:1115:37 [INFO] [stdout] | [INFO] [stdout] 1115 | .unwrap_or_else(|| Utc::now()), [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Utc::now` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:1765:27 [INFO] [stdout] | [INFO] [stdout] 1765 | .args(&["-C", local_dot8_repo_path.to_str().unwrap(), "branch", "-a"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C", local_dot8_repo_path.to_str().unwrap(), "branch", "-a"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:1777:27 [INFO] [stdout] | [INFO] [stdout] 1777 | .args(&["-C", local_dot8_repo_path.to_str().unwrap(), "worktree", "list"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C", local_dot8_repo_path.to_str().unwrap(), "worktree", "list"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/main.rs:1822:24 [INFO] [stdout] | [INFO] [stdout] 1822 | if let Err(_) = local_branch.delete() { [INFO] [stdout] | -------^^^^^^------------------------ help: try: `if local_branch.delete().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:1925:35 [INFO] [stdout] | [INFO] [stdout] 1925 | ... .args(&["-C", local_dot8_repo_path.to_str().unwrap(), "worktree", "list", "--verbose"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C", local_dot8_repo_path.to_str().unwrap(), "worktree", "list", "--verbose"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:1931:35 [INFO] [stdout] | [INFO] [stdout] 1931 | ... .args(&["-C", local_dot8_repo_path.to_str().unwrap(), "branch", "-v"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C", local_dot8_repo_path.to_str().unwrap(), "branch", "-v"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DOT8_PROFILES_DIR` is never used [INFO] [stdout] --> src/main.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const DOT8_PROFILES_DIR: &str = "dot8_profiles"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generate_destination_path_temp` is never used [INFO] [stdout] --> src/main.rs:2539:4 [INFO] [stdout] | [INFO] [stdout] 2539 | fn generate_destination_path_temp(source: &Path) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initialize_dot8_global` is never used [INFO] [stdout] --> src/main.rs:3246:4 [INFO] [stdout] | [INFO] [stdout] 3246 | fn initialize_dot8_global(config: &ResolvedConfig) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:253:25 [INFO] [stdout] | [INFO] [stdout] 253 | Cli::parse_from(&["dotfig", "--help"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["dotfig", "--help"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:272:59 [INFO] [stdout] | [INFO] [stdout] 272 | handle_profiles_create(&cli, &config, &name, clone_from.as_deref())?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:275:59 [INFO] [stdout] | [INFO] [stdout] 275 | handle_profiles_delete(&cli, &config, &name, *force)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:278:66 [INFO] [stdout] | [INFO] [stdout] 278 | handle_profiles_delete_remote(&cli, &config, &name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:281:59 [INFO] [stdout] | [INFO] [stdout] 281 | handle_profiles_switch(&cli, &config, &name, *dry_run)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:284:57 [INFO] [stdout] | [INFO] [stdout] 284 | handle_profiles_pull(&cli, &config, &name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:287:56 [INFO] [stdout] | [INFO] [stdout] 287 | handle_profiles_set(&cli, &config, &name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:321:33 [INFO] [stdout] | [INFO] [stdout] 321 | handle_remote(&cli, &target)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:325:43 [INFO] [stdout] | [INFO] [stdout] 325 | handle_migrate(&cli, &config, &old_path)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `old_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:329:40 [INFO] [stdout] | [INFO] [stdout] 329 | handle_copy(&cli, &config, &source, dest.as_deref())?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:333:40 [INFO] [stdout] | [INFO] [stdout] 333 | handle_diff(&cli, &config, &source, target.as_deref())?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:420:34 [INFO] [stdout] | [INFO] [stdout] 420 | remove_local_profile(&config, &local_dot8_repo_path, profile, &config.dot8_profiles_path, cli.quiet, false)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:429:23 [INFO] [stdout] | [INFO] [stdout] 429 | pull_profiles(&config, &local_dot8_repo_path, &to_pull, &config.dot8_profiles_path, cli.quiet, cli.debug)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `info.worktree_path` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:593:85 [INFO] [stdout] | [INFO] [stdout] 592 | if cli.verbose && info.worktree_path.is_some() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] 593 | println!(" Path: {}/{}", config.local_dotfig_root.display(), info.worktree_path.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:1115:37 [INFO] [stdout] | [INFO] [stdout] 1115 | .unwrap_or_else(|| Utc::now()), [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Utc::now` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:1765:27 [INFO] [stdout] | [INFO] [stdout] 1765 | .args(&["-C", local_dot8_repo_path.to_str().unwrap(), "branch", "-a"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C", local_dot8_repo_path.to_str().unwrap(), "branch", "-a"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:1777:27 [INFO] [stdout] | [INFO] [stdout] 1777 | .args(&["-C", local_dot8_repo_path.to_str().unwrap(), "worktree", "list"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C", local_dot8_repo_path.to_str().unwrap(), "worktree", "list"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/main.rs:1822:24 [INFO] [stdout] | [INFO] [stdout] 1822 | if let Err(_) = local_branch.delete() { [INFO] [stdout] | -------^^^^^^------------------------ help: try: `if local_branch.delete().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:1925:35 [INFO] [stdout] | [INFO] [stdout] 1925 | ... .args(&["-C", local_dot8_repo_path.to_str().unwrap(), "worktree", "list", "--verbose"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C", local_dot8_repo_path.to_str().unwrap(), "worktree", "list", "--verbose"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:1931:35 [INFO] [stdout] | [INFO] [stdout] 1931 | ... .args(&["-C", local_dot8_repo_path.to_str().unwrap(), "branch", "-v"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-C", local_dot8_repo_path.to_str().unwrap(), "branch", "-v"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `Command { std: "docker" "inspect" "d97af6a6d17f1ed7b3b613ce561db227cb7f50b9c8317800916ead802b97f5e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d97af6a6d17f1ed7b3b613ce561db227cb7f50b9c8317800916ead802b97f5e1", kill_on_drop: false }` [INFO] [stdout] d97af6a6d17f1ed7b3b613ce561db227cb7f50b9c8317800916ead802b97f5e1