[INFO] cloning repository https://github.com/joha7809/ISA-utils [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/joha7809/ISA-utils" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoha7809%2FISA-utils", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoha7809%2FISA-utils'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d85e6e3a7fdb5850ba84023646a1d33915f7bd23 [INFO] linting joha7809/ISA-utils against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoha7809%2FISA-utils" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/joha7809/ISA-utils [INFO] finished tweaking git repo https://github.com/joha7809/ISA-utils [INFO] tweaked toml for git repo https://github.com/joha7809/ISA-utils written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/joha7809/ISA-utils on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/joha7809/ISA-utils already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.50 [INFO] [stderr] Downloaded clap_builder v4.5.50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f17af33f30ca8496a9bd9b1bec46c9b290b428f6eedec9ae2a6f896fed618538 [INFO] running `Command { std: "docker" "start" "-a" "f17af33f30ca8496a9bd9b1bec46c9b290b428f6eedec9ae2a6f896fed618538", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f17af33f30ca8496a9bd9b1bec46c9b290b428f6eedec9ae2a6f896fed618538", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f17af33f30ca8496a9bd9b1bec46c9b290b428f6eedec9ae2a6f896fed618538", kill_on_drop: false }` [INFO] [stdout] f17af33f30ca8496a9bd9b1bec46c9b290b428f6eedec9ae2a6f896fed618538 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c23fe5d1de64c7e13c5a7c1fb7416ac6ab2ccf15d28489e1447866d3798149b0 [INFO] running `Command { std: "docker" "start" "-a" "c23fe5d1de64c7e13c5a7c1fb7416ac6ab2ccf15d28489e1447866d3798149b0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling unicode-ident v1.0.20 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking clap_builder v4.5.50 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking clap v4.5.50 [INFO] [stderr] Checking isa-core v0.1.0 (/opt/rustwide/workdir/isa-core) [INFO] [stderr] Checking isa-encoder v0.1.0 (/opt/rustwide/workdir/isa-encoder) [INFO] [stderr] Checking isa-vm v0.1.0 (/opt/rustwide/workdir/isa-vm) [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> isa-core/src/codec.rs:214:21 [INFO] [stdout] | [INFO] [stdout] 214 | let input = 0b10011010000000000000001000111101 as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `0b10011010000000000000001000111101_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `isa_core::traits::Decodable` [INFO] [stdout] --> isa-vm/src/vm.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use isa_core::traits::Decodable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `WHITE_IMAGE` is never used [INFO] [stdout] --> isa-vm/src/image.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 18 | pub const WHITE_IMAGE: [i32; 400] = [255; 400]; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FixedMemory` is never constructed [INFO] [stdout] --> isa-vm/src/memory.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct FixedMemory { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> isa-vm/src/memory.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl FixedMemory { [INFO] [stdout] | ----------------------------------- associated function in this implementation [INFO] [stdout] 16 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new` and `new_with_default` are never used [INFO] [stdout] --> isa-vm/src/memory.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | impl DynamicMemory { [INFO] [stdout] | ------------------ associated functions in this implementation [INFO] [stdout] 36 | pub fn new(size: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn new_with_default(size: usize, default: i32) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `isa_core::traits::Decodable` [INFO] [stdout] --> isa-vm/src/vm.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use isa_core::traits::Decodable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `WHITE_IMAGE` is never used [INFO] [stdout] --> isa-vm/src/image.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 18 | pub const WHITE_IMAGE: [i32; 400] = [255; 400]; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FixedMemory` is never constructed [INFO] [stdout] --> isa-vm/src/memory.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct FixedMemory { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> isa-vm/src/memory.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl FixedMemory { [INFO] [stdout] | ----------------------------------- associated function in this implementation [INFO] [stdout] 16 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new` and `new_with_default` are never used [INFO] [stdout] --> isa-vm/src/memory.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | impl DynamicMemory { [INFO] [stdout] | ------------------ associated functions in this implementation [INFO] [stdout] 36 | pub fn new(size: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn new_with_default(size: usize, default: i32) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_ref` can be confused for the standard trait method `std::convert::AsRef::as_ref` [INFO] [stdout] --> isa-encoder/src/assembler_types.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn as_ref(&self) -> &T { [INFO] [stdout] 24 | | &self.item [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::convert::AsRef` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_mut` can be confused for the standard trait method `std::convert::AsMut::as_mut` [INFO] [stdout] --> isa-encoder/src/assembler_types.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn as_mut(&mut self) -> &mut T { [INFO] [stdout] 27 | | &mut self.item [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::convert::AsMut` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_ref` can be confused for the standard trait method `std::convert::AsRef::as_ref` [INFO] [stdout] --> isa-encoder/src/assembler_types.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn as_ref(&self) -> &T { [INFO] [stdout] 24 | | &self.item [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::convert::AsRef` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_mut` can be confused for the standard trait method `std::convert::AsMut::as_mut` [INFO] [stdout] --> isa-encoder/src/assembler_types.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn as_mut(&mut self) -> &mut T { [INFO] [stdout] 27 | | &mut self.item [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::convert::AsMut` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `isa_encoder::encoder::encode_program` [INFO] [stdout] --> isa-encoder/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use isa_encoder::encoder::encode_program; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clap` [INFO] [stdout] --> isa-encoder/src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use clap::*; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `isa_encoder::encoder::encode_program` [INFO] [stdout] --> isa-encoder/src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use isa_encoder::encoder::encode_program; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> isa-encoder/tests/integration_tests.rs:291:8 [INFO] [stdout] | [INFO] [stdout] 291 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clap` [INFO] [stdout] --> isa-encoder/src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use clap::*; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.51s [INFO] running `Command { std: "docker" "inspect" "c23fe5d1de64c7e13c5a7c1fb7416ac6ab2ccf15d28489e1447866d3798149b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c23fe5d1de64c7e13c5a7c1fb7416ac6ab2ccf15d28489e1447866d3798149b0", kill_on_drop: false }` [INFO] [stdout] c23fe5d1de64c7e13c5a7c1fb7416ac6ab2ccf15d28489e1447866d3798149b0