[INFO] cloning repository https://github.com/joernnilsson/perceptron [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/joernnilsson/perceptron" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoernnilsson%2Fperceptron", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoernnilsson%2Fperceptron'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 555ca1b53c7d44fce156b9884c00fc13db2d38fd [INFO] linting joernnilsson/perceptron against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoernnilsson%2Fperceptron" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/joernnilsson/perceptron [INFO] finished tweaking git repo https://github.com/joernnilsson/perceptron [INFO] tweaked toml for git repo https://github.com/joernnilsson/perceptron written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/joernnilsson/perceptron on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/joernnilsson/perceptron already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded simba v0.7.3 [INFO] [stderr] Downloaded num v0.4.1 [INFO] [stderr] Downloaded rusttype v0.9.3 [INFO] [stderr] Downloaded owned_ttf_parser v0.15.2 [INFO] [stderr] Downloaded ttf-parser v0.15.2 [INFO] [stderr] Downloaded nalgebra v0.30.1 [INFO] [stderr] Downloaded imageproc v0.23.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 92125fbc3f79942ec42677b56daeb19d0d33cd1c8d405e6c192e2a47a084e4e8 [INFO] running `Command { std: "docker" "start" "-a" "92125fbc3f79942ec42677b56daeb19d0d33cd1c8d405e6c192e2a47a084e4e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "92125fbc3f79942ec42677b56daeb19d0d33cd1c8d405e6c192e2a47a084e4e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92125fbc3f79942ec42677b56daeb19d0d33cd1c8d405e6c192e2a47a084e4e8", kill_on_drop: false }` [INFO] [stdout] 92125fbc3f79942ec42677b56daeb19d0d33cd1c8d405e6c192e2a47a084e4e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18b8fb64a12420634bd25d551ca1f7e307d7a13c2bdb57aea289ca4507be262e [INFO] running `Command { std: "docker" "start" "-a" "18b8fb64a12420634bd25d551ca1f7e307d7a13c2bdb57aea289ca4507be262e", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking wide v0.7.13 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking fdeflate v0.3.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking exr v1.71.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking owned_ttf_parser v0.15.2 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking tiff v0.9.0 [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Compiling nalgebra-macros v0.2.1 [INFO] [stderr] Checking nalgebra v0.30.1 [INFO] [stderr] Checking nalgebra v0.32.3 [INFO] [stderr] Checking imageproc v0.23.0 [INFO] [stderr] Checking perceptron v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:66:24 [INFO] [stdout] | [INFO] [stdout] 66 | let dist = ((x as f64 - center_x as f64).powf(2.0) + (y as f64 - center_y as f64).powf(2.0)) as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((x as f64 - center_x as f64).powf(2.0) + (y as f64 - center_y as f64).powf(2.0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | weights = weights + image.image; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weights += image.image` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | weights = weights - image.image; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weights -= image.image` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:116:50 [INFO] [stdout] | [INFO] [stdout] 116 | let validation_result = validate_dataset(&dataset, weights); [INFO] [stdout] | ^^^^^^^^ help: change this to: `dataset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | / match output { [INFO] [stdout] 181 | | Some(filename) => { [INFO] [stdout] 182 | | image_handling::save_weights(&weights, &filename); [INFO] [stdout] 183 | | }, [INFO] [stdout] 184 | | None => {}, [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 180 ~ if let Some(filename) = output { [INFO] [stdout] 181 + image_handling::save_weights(&weights, &filename); [INFO] [stdout] 182 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:188:30 [INFO] [stdout] | [INFO] [stdout] 188 | fn argument_if_set(argument: &String) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 188 ~ fn argument_if_set(argument: &str) -> Option { [INFO] [stdout] 189 | if argument.len() > 0 { [INFO] [stdout] 190 ~ Some(argument.to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:189:8 [INFO] [stdout] | [INFO] [stdout] 189 | if argument.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!argument.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:239:16 [INFO] [stdout] | [INFO] [stdout] 239 | if !input_image.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `input_image.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:243:16 [INFO] [stdout] | [INFO] [stdout] 243 | if !input_weights.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input_weights.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `output_processed` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:264:53 [INFO] [stdout] | [INFO] [stdout] 263 | if output_processed.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = output_processed` [INFO] [stdout] 264 | image_handling::save_image(&image, &output_processed.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | / match command.as_str() { [INFO] [stdout] 238 | | "test_image" => { [INFO] [stdout] 239 | | if !input_image.is_some() { [INFO] [stdout] 240 | | println!("Missing argument: --input-image"); [INFO] [stdout] ... | [INFO] [stdout] 248 | | _ => {}, [INFO] [stdout] 249 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 ~ if command.as_str() == "test_image" { [INFO] [stdout] 238 + if !input_image.is_some() { [INFO] [stdout] 239 + println!("Missing argument: --input-image"); [INFO] [stdout] 240 + return; [INFO] [stdout] 241 + } [INFO] [stdout] 242 + if !input_weights.is_some() { [INFO] [stdout] 243 + println!("Missing argument: --input-weights"); [INFO] [stdout] 244 + return; [INFO] [stdout] 245 + } [INFO] [stdout] 246 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:66:24 [INFO] [stdout] | [INFO] [stdout] 66 | let dist = ((x as f64 - center_x as f64).powf(2.0) + (y as f64 - center_y as f64).powf(2.0)) as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((x as f64 - center_x as f64).powf(2.0) + (y as f64 - center_y as f64).powf(2.0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | weights = weights + image.image; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weights += image.image` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | weights = weights - image.image; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weights -= image.image` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:116:50 [INFO] [stdout] | [INFO] [stdout] 116 | let validation_result = validate_dataset(&dataset, weights); [INFO] [stdout] | ^^^^^^^^ help: change this to: `dataset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | / match output { [INFO] [stdout] 181 | | Some(filename) => { [INFO] [stdout] 182 | | image_handling::save_weights(&weights, &filename); [INFO] [stdout] 183 | | }, [INFO] [stdout] 184 | | None => {}, [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 180 ~ if let Some(filename) = output { [INFO] [stdout] 181 + image_handling::save_weights(&weights, &filename); [INFO] [stdout] 182 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:188:30 [INFO] [stdout] | [INFO] [stdout] 188 | fn argument_if_set(argument: &String) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 188 ~ fn argument_if_set(argument: &str) -> Option { [INFO] [stdout] 189 | if argument.len() > 0 { [INFO] [stdout] 190 ~ Some(argument.to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:189:8 [INFO] [stdout] | [INFO] [stdout] 189 | if argument.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!argument.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:239:16 [INFO] [stdout] | [INFO] [stdout] 239 | if !input_image.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `input_image.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:243:16 [INFO] [stdout] | [INFO] [stdout] 243 | if !input_weights.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input_weights.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `output_processed` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:264:53 [INFO] [stdout] | [INFO] [stdout] 263 | if output_processed.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = output_processed` [INFO] [stdout] 264 | image_handling::save_image(&image, &output_processed.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | / match command.as_str() { [INFO] [stdout] 238 | | "test_image" => { [INFO] [stdout] 239 | | if !input_image.is_some() { [INFO] [stdout] 240 | | println!("Missing argument: --input-image"); [INFO] [stdout] ... | [INFO] [stdout] 248 | | _ => {}, [INFO] [stdout] 249 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 ~ if command.as_str() == "test_image" { [INFO] [stdout] 238 + if !input_image.is_some() { [INFO] [stdout] 239 + println!("Missing argument: --input-image"); [INFO] [stdout] 240 + return; [INFO] [stdout] 241 + } [INFO] [stdout] 242 + if !input_weights.is_some() { [INFO] [stdout] 243 + println!("Missing argument: --input-weights"); [INFO] [stdout] 244 + return; [INFO] [stdout] 245 + } [INFO] [stdout] 246 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 51.39s [INFO] running `Command { std: "docker" "inspect" "18b8fb64a12420634bd25d551ca1f7e307d7a13c2bdb57aea289ca4507be262e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18b8fb64a12420634bd25d551ca1f7e307d7a13c2bdb57aea289ca4507be262e", kill_on_drop: false }` [INFO] [stdout] 18b8fb64a12420634bd25d551ca1f7e307d7a13c2bdb57aea289ca4507be262e