[INFO] cloning repository https://github.com/joelniinikoski/dirchop [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/joelniinikoski/dirchop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoelniinikoski%2Fdirchop", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoelniinikoski%2Fdirchop'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 47af7a0f011e63b15951931b9ed310a8a7d48b66 [INFO] linting joelniinikoski/dirchop against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoelniinikoski%2Fdirchop" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/joelniinikoski/dirchop [INFO] finished tweaking git repo https://github.com/joelniinikoski/dirchop [INFO] tweaked toml for git repo https://github.com/joelniinikoski/dirchop written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/joelniinikoski/dirchop on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/joelniinikoski/dirchop already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded xattr v1.3.1 [INFO] [stderr] Downloaded tar v0.4.40 [INFO] [stderr] Downloaded filetime v0.2.23 [INFO] [stderr] Downloaded clap v4.5.1 [INFO] [stderr] Downloaded anyhow v1.0.80 [INFO] [stderr] Downloaded anstream v0.6.12 [INFO] [stderr] Downloaded clap_builder v4.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49bdeb293270c7e595f95f9d083580652212e728c27ada06d1ee0ac34aa42be4 [INFO] running `Command { std: "docker" "start" "-a" "49bdeb293270c7e595f95f9d083580652212e728c27ada06d1ee0ac34aa42be4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49bdeb293270c7e595f95f9d083580652212e728c27ada06d1ee0ac34aa42be4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49bdeb293270c7e595f95f9d083580652212e728c27ada06d1ee0ac34aa42be4", kill_on_drop: false }` [INFO] [stdout] 49bdeb293270c7e595f95f9d083580652212e728c27ada06d1ee0ac34aa42be4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27e68d1798929b4d0759dd76cbbb860efbbf60b7475bbdcb4f53f8b973a8ebdc [INFO] running `Command { std: "docker" "start" "-a" "27e68d1798929b4d0759dd76cbbb860efbbf60b7475bbdcb4f53f8b973a8ebdc", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking dirchop v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chopglue.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | let end = if !(chunk == chunks) {chunksize} else {remainder}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(chunk != chunks)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/chopglue.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match writer.write_all(&buf[chunk*chunksize..(chunk*chunksize+end)]) { [INFO] [stdout] 48 | | Ok(_) => (), [INFO] [stdout] 49 | | Err(_) => (), [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(_) = writer.write_all(&buf[chunk*chunksize..(chunk*chunksize+end)]) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/chopglue.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / match result { [INFO] [stdout] 62 | | Ok(entry) => if entry.file_name().len() >= 14 [INFO] [stdout] 63 | | && &entry.file_name().to_str().unwrap()[0..13] == paths::CHUNK { [INFO] [stdout] ... | [INFO] [stdout] 67 | | Err(_) => (), [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 ~ if let Ok(entry) = result { if entry.file_name().len() >= 14 [INFO] [stdout] 62 + && &entry.file_name().to_str().unwrap()[0..13] == paths::CHUNK { [INFO] [stdout] 63 + // we don't process chunks here because we want to retain their order [INFO] [stdout] 64 + chunk_amount += 1; [INFO] [stdout] 65 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chopglue.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | let end = if !(chunk == chunks) {chunksize} else {remainder}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(chunk != chunks)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/chopglue.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match writer.write_all(&buf[chunk*chunksize..(chunk*chunksize+end)]) { [INFO] [stdout] 48 | | Ok(_) => (), [INFO] [stdout] 49 | | Err(_) => (), [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(_) = writer.write_all(&buf[chunk*chunksize..(chunk*chunksize+end)]) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/chopglue.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / match result { [INFO] [stdout] 62 | | Ok(entry) => if entry.file_name().len() >= 14 [INFO] [stdout] 63 | | && &entry.file_name().to_str().unwrap()[0..13] == paths::CHUNK { [INFO] [stdout] ... | [INFO] [stdout] 67 | | Err(_) => (), [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 ~ if let Ok(entry) = result { if entry.file_name().len() >= 14 [INFO] [stdout] 62 + && &entry.file_name().to_str().unwrap()[0..13] == paths::CHUNK { [INFO] [stdout] 63 + // we don't process chunks here because we want to retain their order [INFO] [stdout] 64 + chunk_amount += 1; [INFO] [stdout] 65 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.35s [INFO] running `Command { std: "docker" "inspect" "27e68d1798929b4d0759dd76cbbb860efbbf60b7475bbdcb4f53f8b973a8ebdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27e68d1798929b4d0759dd76cbbb860efbbf60b7475bbdcb4f53f8b973a8ebdc", kill_on_drop: false }` [INFO] [stdout] 27e68d1798929b4d0759dd76cbbb860efbbf60b7475bbdcb4f53f8b973a8ebdc