[INFO] cloning repository https://github.com/joaovictornsv/rust-user-creation [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/joaovictornsv/rust-user-creation" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoaovictornsv%2Frust-user-creation", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoaovictornsv%2Frust-user-creation'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 702ae80433870ef6d24aca48882ddcc8a6b8a892 [INFO] linting joaovictornsv/rust-user-creation against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoaovictornsv%2Frust-user-creation" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/joaovictornsv/rust-user-creation [INFO] finished tweaking git repo https://github.com/joaovictornsv/rust-user-creation [INFO] tweaked toml for git repo https://github.com/joaovictornsv/rust-user-creation written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/joaovictornsv/rust-user-creation on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/joaovictornsv/rust-user-creation already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08128c06c5b04e3050b5e7c32530a94b2d9c7378dac6b4047806874de61118c1 [INFO] running `Command { std: "docker" "start" "-a" "08128c06c5b04e3050b5e7c32530a94b2d9c7378dac6b4047806874de61118c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08128c06c5b04e3050b5e7c32530a94b2d9c7378dac6b4047806874de61118c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08128c06c5b04e3050b5e7c32530a94b2d9c7378dac6b4047806874de61118c1", kill_on_drop: false }` [INFO] [stdout] 08128c06c5b04e3050b5e7c32530a94b2d9c7378dac6b4047806874de61118c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96037349fcd0188c109e1542af4e386319a718aa5b6d03eab73aa0ddc106d7ad [INFO] running `Command { std: "docker" "start" "-a" "96037349fcd0188c109e1542af4e386319a718aa5b6d03eab73aa0ddc106d7ad", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking user_creation v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/repositories/user.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / for i in self.items.iter() { [INFO] [stdout] 30 | | if i.email == email { [INFO] [stdout] 31 | | return Some(i); [INFO] [stdout] ... | [INFO] [stdout] 35 | | None [INFO] [stdout] | |________^ help: replace with an iterator: `self.items.iter().find(|&i| i.email == email).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/business/user.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | if !user_exists.is_none() { return Err(UserErrors::UserAlreadyExists) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `user_exists.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.71s [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/repositories/user.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / for i in self.items.iter() { [INFO] [stdout] 30 | | if i.email == email { [INFO] [stdout] 31 | | return Some(i); [INFO] [stdout] ... | [INFO] [stdout] 35 | | None [INFO] [stdout] | |________^ help: replace with an iterator: `self.items.iter().find(|&i| i.email == email).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/business/user.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | if !user_exists.is_none() { return Err(UserErrors::UserAlreadyExists) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `user_exists.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "96037349fcd0188c109e1542af4e386319a718aa5b6d03eab73aa0ddc106d7ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96037349fcd0188c109e1542af4e386319a718aa5b6d03eab73aa0ddc106d7ad", kill_on_drop: false }` [INFO] [stdout] 96037349fcd0188c109e1542af4e386319a718aa5b6d03eab73aa0ddc106d7ad