[INFO] cloning repository https://github.com/jnalanko/bitvec_sds [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jnalanko/bitvec_sds" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjnalanko%2Fbitvec_sds", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjnalanko%2Fbitvec_sds'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 481dc5c4ffad94179dc6174864f36777dc9f6fe1 [INFO] linting jnalanko/bitvec_sds against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjnalanko%2Fbitvec_sds" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jnalanko/bitvec_sds [INFO] finished tweaking git repo https://github.com/jnalanko/bitvec_sds [INFO] tweaked toml for git repo https://github.com/jnalanko/bitvec_sds written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jnalanko/bitvec_sds on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jnalanko/bitvec_sds already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded simple-sds-sbwt v0.3.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5dbef785cbf415a79a38ae6bbaf85fa63a2cd9197e4b24d506f2a7306fbf241 [INFO] running `Command { std: "docker" "start" "-a" "b5dbef785cbf415a79a38ae6bbaf85fa63a2cd9197e4b24d506f2a7306fbf241", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5dbef785cbf415a79a38ae6bbaf85fa63a2cd9197e4b24d506f2a7306fbf241", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5dbef785cbf415a79a38ae6bbaf85fa63a2cd9197e4b24d506f2a7306fbf241", kill_on_drop: false }` [INFO] [stdout] b5dbef785cbf415a79a38ae6bbaf85fa63a2cd9197e4b24d506f2a7306fbf241 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d3912f076d749e8503f7207d47d77c137f0d888c37d59bc96f2e77a3a533023c [INFO] running `Command { std: "docker" "start" "-a" "d3912f076d749e8503f7207d47d77c137f0d888c37d59bc96f2e77a3a533023c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking simple-sds-sbwt v0.3.3 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking bitvec_sds v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `bitvec::prelude::*` [INFO] [stdout] --> src/select_support_mcl.rs:655:9 [INFO] [stdout] | [INFO] [stdout] 655 | use bitvec::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/select_support_mcl.rs:735:39 [INFO] [stdout] | [INFO] [stdout] 735 | let mut rng = XorShift64::new(0xC0FFEE_1234_5678); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x00C0_FFEE_1234_5678` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next_usize` is never used [INFO] [stdout] --> src/wavelet_tree.rs:756:12 [INFO] [stdout] | [INFO] [stdout] 744 | impl SplitMix64 { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 756 | fn next_usize(&mut self) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/rank_support_v.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | pub unsafe fn rank_unchecked(&self, idx: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rank_support_v.rs:143:32 [INFO] [stdout] | [INFO] [stdout] 143 | let basic_block_size = (((cap_bits >> 9) + 1) << 1) as usize; // ((cap/512)+1)*2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((cap_bits >> 9) + 1) << 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/select_support_mcl.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | //! answer within-block via word scans (constant-ish time) [INFO] [stdout] | ^^^^^^^^^^ help: try using ` ` (4 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/select_support_mcl.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / enum Block { [INFO] [stdout] 24 | | /// Explicit positions for all occurrences in this superblock (size <= 4096). [INFO] [stdout] 25 | | Long(Vec), [INFO] [stdout] | | ---------------- the second-largest variant contains at least 24 bytes [INFO] [stdout] 26 | | /// Miniblock relative offsets for every 64th occurrence (always 64 entries), [INFO] [stdout] 27 | | /// plus count of occurrences in this superblock (needed for last partial block). [INFO] [stdout] 28 | | Mini { mini: [u32; 64], cnt: usize }, [INFO] [stdout] | | ------------------------------------ the largest variant contains at least 264 bytes [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ the entire enum is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 28 - Mini { mini: [u32; 64], cnt: usize }, [INFO] [stdout] 28 + Mini { mini: Box<[u32; 64]>, cnt: usize }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/select_support_mcl.rs:312:18 [INFO] [stdout] | [INFO] [stdout] 312 | let sb = (self.arg_cnt + SUPER - 1) / SUPER; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.arg_cnt.div_ceil(SUPER)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/select_support_mcl.rs:403:22 [INFO] [stdout] | [INFO] [stdout] 403 | let sb_est = (self.arg_cnt + SUPER - 1) / SUPER; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.arg_cnt.div_ceil(SUPER)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/select_support_mcl.rs:700:23 [INFO] [stdout] | [INFO] [stdout] 700 | bv.extend(std::iter::repeat(bit).take(take)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(bit, take)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `WaveletTree` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/wavelet_tree.rs:352:5 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/wavelet_tree.rs:514:17 [INFO] [stdout] | [INFO] [stdout] 514 | pos = pos - r1; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pos -= r1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `a` [INFO] [stdout] --> src/wavelet_tree.rs:781:18 [INFO] [stdout] | [INFO] [stdout] 781 | for j in (i + 1)..a.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 781 - for j in (i + 1)..a.len() { [INFO] [stdout] 781 + for (j, ) in a.iter().enumerate().skip((i + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/wavelet_tree.rs:781:9 [INFO] [stdout] | [INFO] [stdout] 781 | / for j in (i + 1)..a.len() { [INFO] [stdout] 782 | | if a[j] < x { [INFO] [stdout] 783 | | return Some(j); [INFO] [stdout] ... | [INFO] [stdout] 786 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `((i + 1)..a.len()).find(|&j| a[j] < x)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/wavelet_tree.rs:793:9 [INFO] [stdout] | [INFO] [stdout] 793 | / for j in (0..i).rev() { [INFO] [stdout] 794 | | if a[j] < x { [INFO] [stdout] 795 | | return Some(j); [INFO] [stdout] ... | [INFO] [stdout] 798 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `(0..i).rev().find(|&j| a[j] < x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wavelet_tree.rs:967:25 [INFO] [stdout] | [INFO] [stdout] 967 | !(a[jj] < x), [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(a[jj] >= x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wavelet_tree.rs:980:25 [INFO] [stdout] | [INFO] [stdout] 980 | !(a[jj] < x), [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(a[jj] >= x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `jj` is used to index `a` [INFO] [stdout] --> src/wavelet_tree.rs:965:27 [INFO] [stdout] | [INFO] [stdout] 965 | for jj in (i + 1)..j { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 965 - for jj in (i + 1)..j { [INFO] [stdout] 965 + for (jj, ) in a.iter().enumerate().take(j).skip((i + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `jj` is used to index `a` [INFO] [stdout] --> src/wavelet_tree.rs:978:27 [INFO] [stdout] | [INFO] [stdout] 978 | for jj in (j + 1)..i { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 978 - for jj in (j + 1)..i { [INFO] [stdout] 978 + for (jj, ) in a.iter().enumerate().take(i).skip((j + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/wavelet_tree.rs:1019:49 [INFO] [stdout] | [INFO] [stdout] 1019 | let mut expected: Vec = a[l..r].iter().copied().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/wavelet_tree.rs:1057:45 [INFO] [stdout] | [INFO] [stdout] 1057 | let mut vals: Vec = a[l..r].iter().copied().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IntArray` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/traits.rs:192:1 [INFO] [stdout] | [INFO] [stdout] 192 | / pub trait IntArray { [INFO] [stdout] 193 | | fn with_values(values: impl RandomAccessU64) -> Self; [INFO] [stdout] 194 | | fn with_init_value(value: usize, len: usize) -> Self; [INFO] [stdout] 195 | | fn get(&self, index: usize) -> u64; [INFO] [stdout] ... | [INFO] [stdout] 198 | | fn max_supported_value(&self) -> usize; [INFO] [stdout] 199 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RandomAccessU32` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/traits.rs:307:1 [INFO] [stdout] | [INFO] [stdout] 307 | / pub trait RandomAccessU32 { [INFO] [stdout] 308 | | fn len(&self) -> usize; [INFO] [stdout] 309 | | fn get(&self, idx: usize) -> u32; [INFO] [stdout] 310 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RandomAccessU64` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/traits.rs:335:1 [INFO] [stdout] | [INFO] [stdout] 335 | / pub trait RandomAccessU64 { [INFO] [stdout] 336 | | fn len(&self) -> usize; [INFO] [stdout] 337 | | fn get(&self, idx: usize) -> u64; [INFO] [stdout] 338 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/rmq_tree.rs:388:9 [INFO] [stdout] | [INFO] [stdout] 388 | / for k in block_start..block_end { [INFO] [stdout] 389 | | if self.x.get(k) < ub { [INFO] [stdout] 390 | | return Some(k); [INFO] [stdout] ... | [INFO] [stdout] 393 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `(block_start..block_end).find(|&k| self.x.get(k) < ub)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `vals` [INFO] [stdout] --> src/rmq_tree.rs:599:18 [INFO] [stdout] | [INFO] [stdout] 599 | for i in 0..64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 599 - for i in 0..64 { [INFO] [stdout] 599 + for (i, ) in vals.iter().enumerate().take(64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `vals` [INFO] [stdout] --> src/rmq_tree.rs:603:18 [INFO] [stdout] | [INFO] [stdout] 603 | for i in 0..63 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 603 - for i in 0..63 { [INFO] [stdout] 603 + for (i, ) in vals.iter().enumerate().take(63) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `vals` [INFO] [stdout] --> src/rmq_tree.rs:616:18 [INFO] [stdout] | [INFO] [stdout] 616 | for i in 1..64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 616 - for i in 1..64 { [INFO] [stdout] 616 + for (i, ) in vals.iter().enumerate().take(64).skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `vals` [INFO] [stdout] --> src/rmq_tree.rs:620:18 [INFO] [stdout] | [INFO] [stdout] 620 | for i in 0..64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 620 - for i in 0..64 { [INFO] [stdout] 620 + for (i, ) in vals.iter().enumerate().take(64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `len` is never used [INFO] [stdout] --> src/rmq_tree.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 13 | impl PackedArray { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 47 | fn len(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/rank_support_v.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | pub unsafe fn rank_unchecked(&self, idx: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rank_support_v.rs:143:32 [INFO] [stdout] | [INFO] [stdout] 143 | let basic_block_size = (((cap_bits >> 9) + 1) << 1) as usize; // ((cap/512)+1)*2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((cap_bits >> 9) + 1) << 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/select_support_mcl.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | //! answer within-block via word scans (constant-ish time) [INFO] [stdout] | ^^^^^^^^^^ help: try using ` ` (4 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/select_support_mcl.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / enum Block { [INFO] [stdout] 24 | | /// Explicit positions for all occurrences in this superblock (size <= 4096). [INFO] [stdout] 25 | | Long(Vec), [INFO] [stdout] | | ---------------- the second-largest variant contains at least 24 bytes [INFO] [stdout] 26 | | /// Miniblock relative offsets for every 64th occurrence (always 64 entries), [INFO] [stdout] 27 | | /// plus count of occurrences in this superblock (needed for last partial block). [INFO] [stdout] 28 | | Mini { mini: [u32; 64], cnt: usize }, [INFO] [stdout] | | ------------------------------------ the largest variant contains at least 264 bytes [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ the entire enum is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 28 - Mini { mini: [u32; 64], cnt: usize }, [INFO] [stdout] 28 + Mini { mini: Box<[u32; 64]>, cnt: usize }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/select_support_mcl.rs:312:18 [INFO] [stdout] | [INFO] [stdout] 312 | let sb = (self.arg_cnt + SUPER - 1) / SUPER; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.arg_cnt.div_ceil(SUPER)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/select_support_mcl.rs:403:22 [INFO] [stdout] | [INFO] [stdout] 403 | let sb_est = (self.arg_cnt + SUPER - 1) / SUPER; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.arg_cnt.div_ceil(SUPER)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `WaveletTree` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/wavelet_tree.rs:352:5 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/wavelet_tree.rs:514:17 [INFO] [stdout] | [INFO] [stdout] 514 | pos = pos - r1; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pos -= r1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IntArray` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/traits.rs:192:1 [INFO] [stdout] | [INFO] [stdout] 192 | / pub trait IntArray { [INFO] [stdout] 193 | | fn with_values(values: impl RandomAccessU64) -> Self; [INFO] [stdout] 194 | | fn with_init_value(value: usize, len: usize) -> Self; [INFO] [stdout] 195 | | fn get(&self, index: usize) -> u64; [INFO] [stdout] ... | [INFO] [stdout] 198 | | fn max_supported_value(&self) -> usize; [INFO] [stdout] 199 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RandomAccessU32` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/traits.rs:307:1 [INFO] [stdout] | [INFO] [stdout] 307 | / pub trait RandomAccessU32 { [INFO] [stdout] 308 | | fn len(&self) -> usize; [INFO] [stdout] 309 | | fn get(&self, idx: usize) -> u32; [INFO] [stdout] 310 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `RandomAccessU64` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/traits.rs:335:1 [INFO] [stdout] | [INFO] [stdout] 335 | / pub trait RandomAccessU64 { [INFO] [stdout] 336 | | fn len(&self) -> usize; [INFO] [stdout] 337 | | fn get(&self, idx: usize) -> u64; [INFO] [stdout] 338 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/rmq_tree.rs:388:9 [INFO] [stdout] | [INFO] [stdout] 388 | / for k in block_start..block_end { [INFO] [stdout] 389 | | if self.x.get(k) < ub { [INFO] [stdout] 390 | | return Some(k); [INFO] [stdout] ... | [INFO] [stdout] 393 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `(block_start..block_end).find(|&k| self.x.get(k) < ub)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `query_idx` [INFO] [stdout] --> benches/benchmark.rs:147:10 [INFO] [stdout] | [INFO] [stdout] 147 | for (query_idx, query) in select_query_positions.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_query_idx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> benches/benchmark.rs:220:18 [INFO] [stdout] | [INFO] [stdout] 220 | let ub = (rng.next_u64() % 256) as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rng.next_u64() % 256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.62s [INFO] running `Command { std: "docker" "inspect" "d3912f076d749e8503f7207d47d77c137f0d888c37d59bc96f2e77a3a533023c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3912f076d749e8503f7207d47d77c137f0d888c37d59bc96f2e77a3a533023c", kill_on_drop: false }` [INFO] [stdout] d3912f076d749e8503f7207d47d77c137f0d888c37d59bc96f2e77a3a533023c