[INFO] cloning repository https://github.com/jin2461/heap-sort [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jin2461/heap-sort" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjin2461%2Fheap-sort", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjin2461%2Fheap-sort'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2af76893f173da87f8ca1b34397285fea4763337 [INFO] linting jin2461/heap-sort against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjin2461%2Fheap-sort" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jin2461/heap-sort [INFO] finished tweaking git repo https://github.com/jin2461/heap-sort [INFO] tweaked toml for git repo https://github.com/jin2461/heap-sort written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jin2461/heap-sort on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jin2461/heap-sort already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4bf1125c1ff3b09d7266a6c3257aadbe216bfd65c4fb04b6c7d0de84be6b173d [INFO] running `Command { std: "docker" "start" "-a" "4bf1125c1ff3b09d7266a6c3257aadbe216bfd65c4fb04b6c7d0de84be6b173d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bf1125c1ff3b09d7266a6c3257aadbe216bfd65c4fb04b6c7d0de84be6b173d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bf1125c1ff3b09d7266a6c3257aadbe216bfd65c4fb04b6c7d0de84be6b173d", kill_on_drop: false }` [INFO] [stdout] 4bf1125c1ff3b09d7266a6c3257aadbe216bfd65c4fb04b6c7d0de84be6b173d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ced94dc38deb8ff9f838af8e80d00691b0f708eea58e6b2050effde322d7a61 [INFO] running `Command { std: "docker" "start" "-a" "0ced94dc38deb8ff9f838af8e80d00691b0f708eea58e6b2050effde322d7a61", kill_on_drop: false }` [INFO] [stderr] Checking sort v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/main.rs:44:31 [INFO] [stdout] | [INFO] [stdout] 44 | nodes[i].parent = (i + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `i.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/main.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | nodes[i].parent = (i + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `i.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | && !(vec_of_nodes[i].child1 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vec_of_nodes[i].child1 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:76:24 [INFO] [stdout] | [INFO] [stdout] 76 | && !(vec_of_nodes[i].child2 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vec_of_nodes[i].child2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return vec_of_nodes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return vec_of_nodes; [INFO] [stdout] 88 + vec_of_nodes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | / if vec_of_nodes.len() > vec_of_nodes[i].child2 { [INFO] [stdout] 75 | | if vec_of_nodes[largest].value < vec_of_nodes[vec_of_nodes[i].child2].value [INFO] [stdout] 76 | | && !(vec_of_nodes[i].child2 == 0) [INFO] [stdout] ... | [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if vec_of_nodes.len() > vec_of_nodes[i].child2 [INFO] [stdout] 75 ~ && vec_of_nodes[largest].value < vec_of_nodes[vec_of_nodes[i].child2].value [INFO] [stdout] 76 | && !(vec_of_nodes[i].child2 == 0) [INFO] [stdout] 77 | { [INFO] [stdout] 78 | largest = vec_of_nodes[i].child2 [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return vec_of_nodes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return vec_of_nodes; [INFO] [stdout] 98 + vec_of_nodes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return sorted_nodes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return sorted_nodes; [INFO] [stdout] 116 + sorted_nodes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/main.rs:44:31 [INFO] [stdout] | [INFO] [stdout] 44 | nodes[i].parent = (i + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `i.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/main.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | nodes[i].parent = (i + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `i.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | && !(vec_of_nodes[i].child1 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vec_of_nodes[i].child1 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:76:24 [INFO] [stdout] | [INFO] [stdout] 76 | && !(vec_of_nodes[i].child2 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vec_of_nodes[i].child2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return vec_of_nodes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return vec_of_nodes; [INFO] [stdout] 88 + vec_of_nodes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | / if vec_of_nodes.len() > vec_of_nodes[i].child2 { [INFO] [stdout] 75 | | if vec_of_nodes[largest].value < vec_of_nodes[vec_of_nodes[i].child2].value [INFO] [stdout] 76 | | && !(vec_of_nodes[i].child2 == 0) [INFO] [stdout] ... | [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if vec_of_nodes.len() > vec_of_nodes[i].child2 [INFO] [stdout] 75 ~ && vec_of_nodes[largest].value < vec_of_nodes[vec_of_nodes[i].child2].value [INFO] [stdout] 76 | && !(vec_of_nodes[i].child2 == 0) [INFO] [stdout] 77 | { [INFO] [stdout] 78 | largest = vec_of_nodes[i].child2 [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return vec_of_nodes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return vec_of_nodes; [INFO] [stdout] 98 + vec_of_nodes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | return sorted_nodes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return sorted_nodes; [INFO] [stdout] 116 + sorted_nodes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s [INFO] running `Command { std: "docker" "inspect" "0ced94dc38deb8ff9f838af8e80d00691b0f708eea58e6b2050effde322d7a61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ced94dc38deb8ff9f838af8e80d00691b0f708eea58e6b2050effde322d7a61", kill_on_drop: false }` [INFO] [stdout] 0ced94dc38deb8ff9f838af8e80d00691b0f708eea58e6b2050effde322d7a61