[INFO] cloning repository https://github.com/jhwz/advent-of-code-2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jhwz/advent-of-code-2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjhwz%2Fadvent-of-code-2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjhwz%2Fadvent-of-code-2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4eba48916a88f19faa660912360f4d69067e57e2 [INFO] linting jhwz/advent-of-code-2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjhwz%2Fadvent-of-code-2024" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jhwz/advent-of-code-2024 [INFO] finished tweaking git repo https://github.com/jhwz/advent-of-code-2024 [INFO] tweaked toml for git repo https://github.com/jhwz/advent-of-code-2024 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jhwz/advent-of-code-2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jhwz/advent-of-code-2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 116f671f8ad7a6d1b5c9f5d7fd8ccabb541d6bc310d731e2dbb251f26a0385b7 [INFO] running `Command { std: "docker" "start" "-a" "116f671f8ad7a6d1b5c9f5d7fd8ccabb541d6bc310d731e2dbb251f26a0385b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "116f671f8ad7a6d1b5c9f5d7fd8ccabb541d6bc310d731e2dbb251f26a0385b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "116f671f8ad7a6d1b5c9f5d7fd8ccabb541d6bc310d731e2dbb251f26a0385b7", kill_on_drop: false }` [INFO] [stdout] 116f671f8ad7a6d1b5c9f5d7fd8ccabb541d6bc310d731e2dbb251f26a0385b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 707b69597b3ab3bf6f906a3b7a2f24f2bdbee5255c88f8cb368c385252438427 [INFO] running `Command { std: "docker" "start" "-a" "707b69597b3ab3bf6f906a3b7a2f24f2bdbee5255c88f8cb368c385252438427", kill_on_drop: false }` [INFO] [stderr] Checking advent-of-code-2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ops::Index` [INFO] [stdout] --> src/bin/day16/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | ops::Index, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/bin/day16/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | i64, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `i64::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/day16/main.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | let mut queue: VecDeque<(Reindeer, i64, Vec<(usize, usize)>)> = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day2/main.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return true; [INFO] [stdout] 27 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day2/main.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | if diff < 1 || diff > 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=3).contains(&diff)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::Index` [INFO] [stdout] --> src/bin/day14/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | ops::Index, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/bin/day10/main.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 17 | let mut grid = vec![0 as usize; (nrows * ncols) as usize]; [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/day10/main.rs:39:25 [INFO] [stdout] | [INFO] [stdout] 39 | let next = (pos.0 as i32 + offset.0, pos.1 as i32 + offset.1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/day10/main.rs:39:50 [INFO] [stdout] | [INFO] [stdout] 39 | let next = (pos.0 as i32 + offset.0, pos.1 as i32 + offset.1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/day10/main.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | let next = (pos.0 as i32 + offset.0, pos.1 as i32 + offset.1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/day10/main.rs:61:50 [INFO] [stdout] | [INFO] [stdout] 61 | let next = (pos.0 as i32 + offset.0, pos.1 as i32 + offset.1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/bin/day9/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | isize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `isize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day9/main.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return sum; [INFO] [stdout] 45 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `values` [INFO] [stdout] --> src/bin/day9/main.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 39 | for i in 0..values.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 39 - for i in 0..values.len() { [INFO] [stdout] 39 + for (i, ) in values.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/day6/main.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 21 | ) -> (HashSet<((i32, i32), (i32, i32))>, bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/bin/day6/main.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 35 | dir = (dir.1, dir.0 * -1); [INFO] [stdout] | ^^^^^^^^^^ help: consider using: `-dir.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `free` [INFO] [stdout] --> src/bin/day9/main.rs:108:18 [INFO] [stdout] | [INFO] [stdout] 108 | for i in 0..free.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 108 - for i in 0..free.len() { [INFO] [stdout] 108 + for in &mut free { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::Index` [INFO] [stdout] --> src/bin/day14/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | ops::Index, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::Index` [INFO] [stdout] --> src/bin/day16/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | ops::Index, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/bin/day14/main.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 70 | / loop { [INFO] [stdout] 71 | | seconds += 1; [INFO] [stdout] 72 | | if seconds % 1_000_000 == 0 { [INFO] [stdout] 73 | | println!("Seconds: {}", seconds); [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 83 | [INFO] [stdout] 84 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/day13/main.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / match machine.solve() { [INFO] [stdout] 76 | | Some(presses) => part1 += presses, [INFO] [stdout] 77 | | None => (), [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(presses) = machine.solve() { part1 += presses }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/day13/main.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / match machine.solve() { [INFO] [stdout] 86 | | Some(presses) => part2 += presses, [INFO] [stdout] 87 | | None => (), [INFO] [stdout] 88 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(presses) = machine.solve() { part2 += presses }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bin/day11/main.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `collections::HashMap` [INFO] [stdout] --> src/bin/day7/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | collections::HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day11/main.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 61 | _ if value.len() % 2 == 0 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `value.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/bin/day14/main.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 70 | / loop { [INFO] [stdout] 71 | | seconds += 1; [INFO] [stdout] 72 | | if seconds % 1_000_000 == 0 { [INFO] [stdout] 73 | | println!("Seconds: {}", seconds); [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 83 | [INFO] [stdout] 84 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/day5/main.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/bin/day5/main.rs:29:42 [INFO] [stdout] | [INFO] [stdout] 29 | let curr = orders.entry(min).or_insert(Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `grid` manually [INFO] [stdout] --> src/bin/day15/main.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | / ... let next_value = grid[next.0 * bounds.1 + next.1]; [INFO] [stdout] 159 | | ... grid[next.0 * bounds.1 + next.1] = grid[idx]; [INFO] [stdout] 160 | | ... grid[idx] = next_value; [INFO] [stdout] | |_____________________________________________^ help: try: `grid.swap(next.0 * bounds.1 + next.1, idx);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day14/main.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return v >= bounds.0 && v < bounds.1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return v >= bounds.0 && v < bounds.1; [INFO] [stdout] 25 + v >= bounds.0 && v < bounds.1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day14/main.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return v >= bounds.0 && v < bounds.1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return v >= bounds.0 && v < bounds.1; [INFO] [stdout] 25 + v >= bounds.0 && v < bounds.1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/day14/main.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | print!("\n") [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 104 - print!("\n") [INFO] [stdout] 104 + println!() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/day14/main.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | let quadrants = vec![ [INFO] [stdout] | _____________________^ [INFO] [stdout] 51 | | ((0, 50), (0, 51)), [INFO] [stdout] 52 | | ((0, 50), (52, 103)), [INFO] [stdout] 53 | | ((51, 101), (0, 51)), [INFO] [stdout] 54 | | ((51, 101), (52, 103)), [INFO] [stdout] 55 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 50 ~ let quadrants = [((0, 50), (0, 51)), [INFO] [stdout] 51 + ((0, 50), (52, 103)), [INFO] [stdout] 52 + ((51, 101), (0, 51)), [INFO] [stdout] 53 ~ ((51, 101), (52, 103))]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/day14/main.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 56 | let mut counts = vec![0; 4]; [INFO] [stdout] | ^^^^^^^^^^ help: you can use an array directly: `[0; 4]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day7/main.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day7/main.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | if rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/day14/main.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | print!("\n") [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 104 - print!("\n") [INFO] [stdout] 104 + println!() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/day14/main.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | let quadrants = vec![ [INFO] [stdout] | _____________________^ [INFO] [stdout] 51 | | ((0, 50), (0, 51)), [INFO] [stdout] 52 | | ((0, 50), (52, 103)), [INFO] [stdout] 53 | | ((51, 101), (0, 51)), [INFO] [stdout] 54 | | ((51, 101), (52, 103)), [INFO] [stdout] 55 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 50 ~ let quadrants = [((0, 50), (0, 51)), [INFO] [stdout] 51 + ((0, 50), (52, 103)), [INFO] [stdout] 52 + ((51, 101), (0, 51)), [INFO] [stdout] 53 ~ ((51, 101), (52, 103))]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/day14/main.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 56 | let mut counts = vec![0; 4]; [INFO] [stdout] | ^^^^^^^^^^ help: you can use an array directly: `[0; 4]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/bin/day16/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | i64, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `i64::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `collections::HashMap` [INFO] [stdout] --> src/bin/day7/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | collections::HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/day16/main.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | let mut queue: VecDeque<(Reindeer, i64, Vec<(usize, usize)>)> = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/day6/main.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 21 | ) -> (HashSet<((i32, i32), (i32, i32))>, bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/bin/day6/main.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 35 | dir = (dir.1, dir.0 * -1); [INFO] [stdout] | ^^^^^^^^^^ help: consider using: `-dir.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/day13/main.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / match machine.solve() { [INFO] [stdout] 76 | | Some(presses) => part1 += presses, [INFO] [stdout] 77 | | None => (), [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(presses) = machine.solve() { part1 += presses }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/day13/main.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / match machine.solve() { [INFO] [stdout] 86 | | Some(presses) => part2 += presses, [INFO] [stdout] 87 | | None => (), [INFO] [stdout] 88 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(presses) = machine.solve() { part2 += presses }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `grid` manually [INFO] [stdout] --> src/bin/day15/main.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | / ... let next_value = grid[next.0 * bounds.1 + next.1]; [INFO] [stdout] 159 | | ... grid[next.0 * bounds.1 + next.1] = grid[idx]; [INFO] [stdout] 160 | | ... grid[idx] = next_value; [INFO] [stdout] | |_____________________________________________^ help: try: `grid.swap(next.0 * bounds.1 + next.1, idx);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day2/main.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return true; [INFO] [stdout] 27 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day2/main.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | if diff < 1 || diff > 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=3).contains(&diff)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day12/main.rs:79:52 [INFO] [stdout] | [INFO] [stdout] 79 | fn out_of_region(pos: Pos, region: char, grid: &Vec, bounds: (i32, i32)) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 - fn out_of_region(pos: Pos, region: char, grid: &Vec, bounds: (i32, i32)) -> bool { [INFO] [stdout] 79 + fn out_of_region(pos: Pos, region: char, grid: &[char], bounds: (i32, i32)) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day12/main.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if !(out_of_region(pos.left(dir), region, grid, bounds) [INFO] [stdout] | ________________^ [INFO] [stdout] 95 | | && !out_of_region(pos.move_back(dir).left(dir), region, grid, bounds)) [INFO] [stdout] | |______________________________________________________________________________________^ help: try: `!out_of_region(pos.left(dir), region, grid, bounds) || out_of_region(pos.move_back(dir).left(dir), region, grid, bounds)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day12/main.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | &grid, [INFO] [stdout] | ^^^^^ help: change this to: `grid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day12/main.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 174 | &grid, [INFO] [stdout] | ^^^^^ help: change this to: `grid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day4/main.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return v1 == 'M' && v2 == 'S' || v1 == 'S' && v2 == 'M'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return v1 == 'M' && v2 == 'S' || v1 == 'S' && v2 == 'M'; [INFO] [stdout] 55 + v1 == 'M' && v2 == 'S' || v1 == 'S' && v2 == 'M' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day7/main.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day7/main.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | if rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day4/main.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return v1 == 'M' && v2 == 'S' || v1 == 'S' && v2 == 'M'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return v1 == 'M' && v2 == 'S' || v1 == 'S' && v2 == 'M'; [INFO] [stdout] 55 + v1 == 'M' && v2 == 'S' || v1 == 'S' && v2 == 'M' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/day5/main.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/bin/day5/main.rs:29:42 [INFO] [stdout] | [INFO] [stdout] 29 | let curr = orders.entry(min).or_insert(Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bin/day11/main.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day11/main.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 61 | _ if value.len() % 2 == 0 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `value.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/bin/day9/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | isize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `isize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day9/main.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return sum; [INFO] [stdout] 45 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `values` [INFO] [stdout] --> src/bin/day9/main.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 39 | for i in 0..values.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 39 - for i in 0..values.len() { [INFO] [stdout] 39 + for (i, ) in values.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `free` [INFO] [stdout] --> src/bin/day9/main.rs:108:18 [INFO] [stdout] | [INFO] [stdout] 108 | for i in 0..free.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 108 - for i in 0..free.len() { [INFO] [stdout] 108 + for in &mut free { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day12/main.rs:79:52 [INFO] [stdout] | [INFO] [stdout] 79 | fn out_of_region(pos: Pos, region: char, grid: &Vec, bounds: (i32, i32)) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 - fn out_of_region(pos: Pos, region: char, grid: &Vec, bounds: (i32, i32)) -> bool { [INFO] [stdout] 79 + fn out_of_region(pos: Pos, region: char, grid: &[char], bounds: (i32, i32)) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day12/main.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if !(out_of_region(pos.left(dir), region, grid, bounds) [INFO] [stdout] | ________________^ [INFO] [stdout] 95 | | && !out_of_region(pos.move_back(dir).left(dir), region, grid, bounds)) [INFO] [stdout] | |______________________________________________________________________________________^ help: try: `!out_of_region(pos.left(dir), region, grid, bounds) || out_of_region(pos.move_back(dir).left(dir), region, grid, bounds)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day12/main.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | &grid, [INFO] [stdout] | ^^^^^ help: change this to: `grid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day12/main.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 174 | &grid, [INFO] [stdout] | ^^^^^ help: change this to: `grid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/bin/day10/main.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 17 | let mut grid = vec![0 as usize; (nrows * ncols) as usize]; [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.16s [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/day10/main.rs:39:25 [INFO] [stdout] | [INFO] [stdout] 39 | let next = (pos.0 as i32 + offset.0, pos.1 as i32 + offset.1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/day10/main.rs:39:50 [INFO] [stdout] | [INFO] [stdout] 39 | let next = (pos.0 as i32 + offset.0, pos.1 as i32 + offset.1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/day10/main.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | let next = (pos.0 as i32 + offset.0, pos.1 as i32 + offset.1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/day10/main.rs:61:50 [INFO] [stdout] | [INFO] [stdout] 61 | let next = (pos.0 as i32 + offset.0, pos.1 as i32 + offset.1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "707b69597b3ab3bf6f906a3b7a2f24f2bdbee5255c88f8cb368c385252438427", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "707b69597b3ab3bf6f906a3b7a2f24f2bdbee5255c88f8cb368c385252438427", kill_on_drop: false }` [INFO] [stdout] 707b69597b3ab3bf6f906a3b7a2f24f2bdbee5255c88f8cb368c385252438427