[INFO] cloning repository https://github.com/jgao54/rrb-tree-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jgao54/rrb-tree-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjgao54%2Frrb-tree-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjgao54%2Frrb-tree-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ceab4b16a97df3f8b4b536d3c2704bd1a8ecb50e [INFO] linting jgao54/rrb-tree-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjgao54%2Frrb-tree-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jgao54/rrb-tree-rs [INFO] finished tweaking git repo https://github.com/jgao54/rrb-tree-rs [INFO] tweaked toml for git repo https://github.com/jgao54/rrb-tree-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jgao54/rrb-tree-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jgao54/rrb-tree-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quickcheck v1.0.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f558e02b398100c19da138018f33f0d0421ce49821c5d080b2821eb773e420ed [INFO] running `Command { std: "docker" "start" "-a" "f558e02b398100c19da138018f33f0d0421ce49821c5d080b2821eb773e420ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f558e02b398100c19da138018f33f0d0421ce49821c5d080b2821eb773e420ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f558e02b398100c19da138018f33f0d0421ce49821c5d080b2821eb773e420ed", kill_on_drop: false }` [INFO] [stdout] f558e02b398100c19da138018f33f0d0421ce49821c5d080b2821eb773e420ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70d1bd3cd3bbdba26e8f82662c14c194aa62d634d3d9f9760d3fbbfb47dbcc7b [INFO] running `Command { std: "docker" "start" "-a" "70d1bd3cd3bbdba26e8f82662c14c194aa62d634d3d9f9760d3fbbfb47dbcc7b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking rrb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rrb.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 159 | if !updated.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `updated.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `updated` after checking its variant with `is_none` [INFO] [stdout] --> src/rrb.rs:161:28 [INFO] [stdout] | [INFO] [stdout] 159 | if !updated.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 160 | let mut items = b.items[0..b.items.len()-1].to_vec(); [INFO] [stdout] 161 | items.push(updated.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rrb.rs:213:48 [INFO] [stdout] | [INFO] [stdout] 213 | fn find_slot(idx: usize, height: usize, sizes: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 213 - fn find_slot(idx: usize, height: usize, sizes: &Vec) -> usize { [INFO] [stdout] 213 + fn find_slot(idx: usize, height: usize, sizes: &[usize]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rrb.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | return Rrb { count: left.count + right.count, root: tree}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return Rrb { count: left.count + right.count, root: tree}; [INFO] [stdout] 231 + Rrb { count: left.count + right.count, root: tree} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/rrb.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | if let (&Node::Branch(ref l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 292 - if let (&Node::Branch(ref l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] 292 + if let (Node::Branch(l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/rrb.rs:292:39 [INFO] [stdout] | [INFO] [stdout] 292 | if let (&Node::Branch(ref l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 292 - if let (&Node::Branch(ref l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] 292 + if let (&Node::Branch(ref l), Node::Branch(r)) = (left, right) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rrb.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | / return if top == true { [INFO] [stdout] 317 | | balanced [INFO] [stdout] 318 | | } else { [INFO] [stdout] 319 | | branch(balanced.height+1, vec![Node::Branch(balanced)]) [INFO] [stdout] 320 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 316 ~ if top == true { [INFO] [stdout] 317 + balanced [INFO] [stdout] 318 + } else { [INFO] [stdout] 319 + branch(balanced.height+1, vec![Node::Branch(balanced)]) [INFO] [stdout] 320 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rrb.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | return branch(balanced.height+1, vec![Node::Branch(lbranch), Node::Branch(rbranch)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return branch(balanced.height+1, vec![Node::Branch(lbranch), Node::Branch(rbranch)]); [INFO] [stdout] 325 + branch(balanced.height+1, vec![Node::Branch(lbranch), Node::Branch(rbranch)]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/rrb.rs:308:60 [INFO] [stdout] | [INFO] [stdout] 308 | let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r.into_iter()).collect()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 308 - let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r.into_iter()).collect()); [INFO] [stdout] 308 + let merged = branch(middle.height, l.into_iter().chain(m).chain(r.into_iter()).collect()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/rrb.rs:308:81 [INFO] [stdout] | [INFO] [stdout] 308 | let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r.into_iter()).collect()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 308 - let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r.into_iter()).collect()); [INFO] [stdout] 308 + let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r).collect()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/rrb.rs:316:19 [INFO] [stdout] | [INFO] [stdout] 316 | return if top == true { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `top` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rrb.rs:433:5 [INFO] [stdout] | [INFO] [stdout] 433 | return branch(node.height, items); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - return branch(node.height, items); [INFO] [stdout] 433 + branch(node.height, items) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rrb.rs:376:63 [INFO] [stdout] | [INFO] [stdout] 376 | fn execute_concat_plan(node: &Branch, plan: &Vec) -> Branch { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 - fn execute_concat_plan(node: &Branch, plan: &Vec) -> Branch { [INFO] [stdout] 376 + fn execute_concat_plan(node: &Branch, plan: &[usize]) -> Branch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rrb.rs:426:16 [INFO] [stdout] | [INFO] [stdout] 426 | if current_nodes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current_nodes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rrb.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 159 | if !updated.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `updated.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `updated` after checking its variant with `is_none` [INFO] [stdout] --> src/rrb.rs:161:28 [INFO] [stdout] | [INFO] [stdout] 159 | if !updated.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 160 | let mut items = b.items[0..b.items.len()-1].to_vec(); [INFO] [stdout] 161 | items.push(updated.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/rrb.rs:491:13 [INFO] [stdout] | [INFO] [stdout] 490 | let res = assert_equal_elements(merged, arrs_flat); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 491 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 490 ~ [INFO] [stdout] 491 ~ assert_equal_elements(merged, arrs_flat) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rrb.rs:213:48 [INFO] [stdout] | [INFO] [stdout] 213 | fn find_slot(idx: usize, height: usize, sizes: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 213 - fn find_slot(idx: usize, height: usize, sizes: &Vec) -> usize { [INFO] [stdout] 213 + fn find_slot(idx: usize, height: usize, sizes: &[usize]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/rrb.rs:507:13 [INFO] [stdout] | [INFO] [stdout] 506 | let res = assert_search_step_invariant(&merged.root); [INFO] [stdout] | ----------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 507 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 506 ~ [INFO] [stdout] 507 ~ assert_search_step_invariant(&merged.root) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rrb.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | return Rrb { count: left.count + right.count, root: tree}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return Rrb { count: left.count + right.count, root: tree}; [INFO] [stdout] 231 + Rrb { count: left.count + right.count, root: tree} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/rrb.rs:536:13 [INFO] [stdout] | [INFO] [stdout] 535 | let res = merged.root.height() <= height_least_dense && merged.root.height() >= height_most_dense; [INFO] [stdout] | -------------------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 536 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 535 ~ [INFO] [stdout] 536 ~ merged.root.height() <= height_least_dense && merged.root.height() >= height_most_dense [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/rrb.rs:577:9 [INFO] [stdout] | [INFO] [stdout] 574 | / let output = rrbs.into_iter().skip(1).fold(first, |acc, rrb| { [INFO] [stdout] 575 | | concat(&acc,&rrb) [INFO] [stdout] 576 | | }); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 577 | output [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 574 ~ [INFO] [stdout] 575 ~ rrbs.into_iter().skip(1).fold(first, |acc, rrb| { [INFO] [stdout] 576 + concat(&acc,&rrb) [INFO] [stdout] 577 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rrb.rs:570:12 [INFO] [stdout] | [INFO] [stdout] 570 | if rrbs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rrbs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/rrb.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | if let (&Node::Branch(ref l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 292 - if let (&Node::Branch(ref l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] 292 + if let (Node::Branch(l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/rrb.rs:292:39 [INFO] [stdout] | [INFO] [stdout] 292 | if let (&Node::Branch(ref l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 292 - if let (&Node::Branch(ref l), &Node::Branch(ref r)) = (left, right) { [INFO] [stdout] 292 + if let (&Node::Branch(ref l), Node::Branch(r)) = (left, right) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rrb.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | / return if top == true { [INFO] [stdout] 317 | | balanced [INFO] [stdout] 318 | | } else { [INFO] [stdout] 319 | | branch(balanced.height+1, vec![Node::Branch(balanced)]) [INFO] [stdout] 320 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 316 ~ if top == true { [INFO] [stdout] 317 + balanced [INFO] [stdout] 318 + } else { [INFO] [stdout] 319 + branch(balanced.height+1, vec![Node::Branch(balanced)]) [INFO] [stdout] 320 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rrb.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | return branch(balanced.height+1, vec![Node::Branch(lbranch), Node::Branch(rbranch)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return branch(balanced.height+1, vec![Node::Branch(lbranch), Node::Branch(rbranch)]); [INFO] [stdout] 325 + branch(balanced.height+1, vec![Node::Branch(lbranch), Node::Branch(rbranch)]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/rrb.rs:308:60 [INFO] [stdout] | [INFO] [stdout] 308 | let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r.into_iter()).collect()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 308 - let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r.into_iter()).collect()); [INFO] [stdout] 308 + let merged = branch(middle.height, l.into_iter().chain(m).chain(r.into_iter()).collect()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/rrb.rs:308:81 [INFO] [stdout] | [INFO] [stdout] 308 | let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r.into_iter()).collect()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 308 - let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r.into_iter()).collect()); [INFO] [stdout] 308 + let merged = branch(middle.height, l.into_iter().chain(m.into_iter()).chain(r).collect()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/rrb.rs:316:19 [INFO] [stdout] | [INFO] [stdout] 316 | return if top == true { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `top` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rrb.rs:433:5 [INFO] [stdout] | [INFO] [stdout] 433 | return branch(node.height, items); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - return branch(node.height, items); [INFO] [stdout] 433 + branch(node.height, items) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rrb.rs:376:63 [INFO] [stdout] | [INFO] [stdout] 376 | fn execute_concat_plan(node: &Branch, plan: &Vec) -> Branch { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 - fn execute_concat_plan(node: &Branch, plan: &Vec) -> Branch { [INFO] [stdout] 376 + fn execute_concat_plan(node: &Branch, plan: &[usize]) -> Branch { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rrb.rs:426:16 [INFO] [stdout] | [INFO] [stdout] 426 | if current_nodes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current_nodes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.94s [INFO] running `Command { std: "docker" "inspect" "70d1bd3cd3bbdba26e8f82662c14c194aa62d634d3d9f9760d3fbbfb47dbcc7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70d1bd3cd3bbdba26e8f82662c14c194aa62d634d3d9f9760d3fbbfb47dbcc7b", kill_on_drop: false }` [INFO] [stdout] 70d1bd3cd3bbdba26e8f82662c14c194aa62d634d3d9f9760d3fbbfb47dbcc7b