[INFO] cloning repository https://github.com/jeremychone/rust-kdd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jeremychone/rust-kdd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjeremychone%2Frust-kdd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjeremychone%2Frust-kdd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 22ef41e0605518d2d6aff50d4ca51ee480e8e2ea [INFO] linting jeremychone/rust-kdd against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjeremychone%2Frust-kdd" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jeremychone/rust-kdd [INFO] finished tweaking git repo https://github.com/jeremychone/rust-kdd [INFO] tweaked toml for git repo https://github.com/jeremychone/rust-kdd written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jeremychone/rust-kdd on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jeremychone/rust-kdd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strum v0.24.1 [INFO] [stderr] Downloaded once_cell v1.13.0 [INFO] [stderr] Downloaded itoa v1.0.2 [INFO] [stderr] Downloaded serde v1.0.185 [INFO] [stderr] Downloaded maplit v1.0.2 [INFO] [stderr] Downloaded clap_lex v0.2.4 [INFO] [stderr] Downloaded pest_derive v2.1.0 [INFO] [stderr] Downloaded os_str_bytes v6.2.0 [INFO] [stderr] Downloaded generic-array v0.12.4 [INFO] [stderr] Downloaded smallvec v1.9.0 [INFO] [stderr] Downloaded textwrap v0.15.0 [INFO] [stderr] Downloaded pest v2.1.3 [INFO] [stderr] Downloaded handlebars v4.3.2 [INFO] [stderr] Downloaded indexmap v2.11.4 [INFO] [stderr] Downloaded ucd-trie v0.1.4 [INFO] [stderr] Downloaded serde_json v1.0.82 [INFO] [stderr] Downloaded ryu v1.0.10 [INFO] [stderr] Downloaded unicode-ident v1.0.2 [INFO] [stderr] Downloaded pest_meta v2.1.3 [INFO] [stderr] Downloaded clap v3.2.12 [INFO] [stderr] Downloaded rustversion v1.0.8 [INFO] [stderr] Downloaded strum_macros v0.24.2 [INFO] [stderr] Downloaded sha-1 v0.8.2 [INFO] [stderr] Downloaded pest_generator v2.1.3 [INFO] [stderr] Downloaded tokio v1.20.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 279ff5b669b20f7fef3dbb0242e10e08dbeb7eda8d3a1f56baf72c1115a9312c [INFO] running `Command { std: "docker" "start" "-a" "279ff5b669b20f7fef3dbb0242e10e08dbeb7eda8d3a1f56baf72c1115a9312c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "279ff5b669b20f7fef3dbb0242e10e08dbeb7eda8d3a1f56baf72c1115a9312c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "279ff5b669b20f7fef3dbb0242e10e08dbeb7eda8d3a1f56baf72c1115a9312c", kill_on_drop: false }` [INFO] [stdout] 279ff5b669b20f7fef3dbb0242e10e08dbeb7eda8d3a1f56baf72c1115a9312c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28170d372a68c811f2d9186eace9f45b5af23dec4508ce7b39a60f5fa9a066c0 [INFO] running `Command { std: "docker" "start" "-a" "28170d372a68c811f2d9186eace9f45b5af23dec4508ce7b39a60f5fa9a066c0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling serde v1.0.185 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling ucd-trie v0.1.4 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Compiling rustversion v1.0.8 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling tokio v1.20.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking clap v3.2.12 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling strum_macros v0.24.2 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking handlebars v4.3.2 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking kdd v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/kdd/klog.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | line: line, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/kdd/klog.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | line: line, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/kdd/realm.rs:181:4 [INFO] [stdout] | [INFO] [stdout] 181 | provider: provider, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/kdd/realm.rs:181:4 [INFO] [stdout] | [INFO] [stdout] 181 | provider: provider, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/app_error.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / pub enum AppError { [INFO] [stdout] 5 | | #[error(transparent)] [INFO] [stdout] 6 | | IOError(#[from] std::io::Error), [INFO] [stdout] ... | [INFO] [stdout] 12 | | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/cmd/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use self::argc::cmd_app; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] = note: `#[warn(clippy::four_forward_slashes)]` on by default [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/cmd/argc.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | .version(&crate_version!()[..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use the original value instead: `crate_version!()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn cmd_run() -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:53:73 [INFO] [stdout] | [INFO] [stdout] 53 | fn exec_build(root_dir: &str, argc: &ArgMatches, docker_build: bool) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/cmd/mod.rs:56:47 [INFO] [stdout] | [INFO] [stdout] 56 | let blocks = argc.value_of("blocks").map(|v| v.split(",").into_iter().collect::>()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.split(",")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:64:53 [INFO] [stdout] | [INFO] [stdout] 64 | fn exec_watch(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/cmd/mod.rs:66:47 [INFO] [stdout] | [INFO] [stdout] 66 | let blocks = argc.value_of("blocks").map(|v| v.split(",").into_iter().collect::>()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.split(",")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:74:53 [INFO] [stdout] | [INFO] [stdout] 74 | fn exec_dpush(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/cmd/mod.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 80 | let realm = kdd.current_realm()?.ok_or_else(|| KddError::DpushFailNoRealm)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 80 - let realm = kdd.current_realm()?.ok_or_else(|| KddError::DpushFailNoRealm)?; [INFO] [stdout] 80 + let realm = kdd.current_realm()?.ok_or(KddError::DpushFailNoRealm)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:87:53 [INFO] [stdout] | [INFO] [stdout] 87 | fn exec_realm(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:103:69 [INFO] [stdout] | [INFO] [stdout] 103 | fn exec_kaction(action: &str, root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|v| v.as_slice())` on an `Option` value [INFO] [stdout] --> src/cmd/mod.rs:112:32 [INFO] [stdout] | [INFO] [stdout] 112 | let names = names.or_else(|| config_names.as_ref().map(|v| v.as_slice())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `config_names.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:128:52 [INFO] [stdout] | [INFO] [stdout] 128 | fn exec_kctx(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:140:38 [INFO] [stdout] | [INFO] [stdout] 140 | fn exec_kctx_list(root_dir: &str) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:156:59 [INFO] [stdout] | [INFO] [stdout] 156 | fn exec_kctx_create(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:165:59 [INFO] [stdout] | [INFO] [stdout] 165 | fn exec_kctx_delete(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:174:52 [INFO] [stdout] | [INFO] [stdout] 174 | fn exec_klog(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:190:53 [INFO] [stdout] | [INFO] [stdout] 190 | fn exec_kexec(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:225:52 [INFO] [stdout] | [INFO] [stdout] 225 | fn exec_version(root_dir: &str, _: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/cmd/mod.rs:238:14 [INFO] [stdout] | [INFO] [stdout] 238 | val.map(|v| v.split(",").into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.split(",")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:241:32 [INFO] [stdout] | [INFO] [stdout] 241 | fn load_kdd(root_dir: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | mod block; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/block.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use yaml_rust::Yaml; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/block.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / //// Block Struct [INFO] [stdout] 15 | | #[derive(Debug, Default)] [INFO] [stdout] 16 | | pub struct Block { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 14 - //// Block Struct [INFO] [stdout] 15 - #[derive(Debug, Default)] [INFO] [stdout] 14 + /// Block Struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/block.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / //// Block Builder(s) [INFO] [stdout] 24 | | impl Block { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 23 - //// Block Builder(s) [INFO] [stdout] 24 - impl Block { [INFO] [stdout] 23 + /// Block Builder(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/block.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | dir: as_string(&yaml, BLOCK_KEY_DIR), [INFO] [stdout] | ^^^^^ help: change this to: `yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/block.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 38 | dependencies: as_strings(&yaml, BLOCK_KEY_DEP), [INFO] [stdout] | ^^^^^ help: change this to: `yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/build.rs:11:80 [INFO] [stdout] | [INFO] [stdout] 11 | ...ion<&[&str]>, docker_block: bool) -> Result<(Vec<&Block>, HashMap<&str, &Block>), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> src/kdd/build.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | / blocks_to_build = blocks_to_build [INFO] [stdout] 31 | | .into_iter() [INFO] [stdout] 32 | | .filter(|b| self.get_block_dir(b).join("Dockerfile").is_file()) [INFO] [stdout] 33 | | .collect(); [INFO] [stdout] | |__________________________^ help: consider calling `.retain()` instead: `blocks_to_build.retain(|b| self.get_block_dir(b).join("Dockerfile").is_file())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] = note: `#[warn(clippy::manual_retain)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/build.rs:63:55 [INFO] [stdout] | [INFO] [stdout] 63 | pub async fn watch(&self, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/build.rs:70:40 [INFO] [stdout] | [INFO] [stdout] 70 | let block_dir = self.get_block_dir(&block); [INFO] [stdout] | ^^^^^^ help: change this to: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/build.rs:89:75 [INFO] [stdout] | [INFO] [stdout] 89 | pub async fn build(&self, names: Option<&[&str]>, docker_build: bool) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `blocks_to_build` [INFO] [stdout] --> src/kdd/build.rs:108:3 [INFO] [stdout] | [INFO] [stdout] 108 | let blocks_to_build = blocks_to_build; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `blocks_to_build` is initially defined here [INFO] [stdout] --> src/kdd/build.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 90 | let (blocks_to_build, block_by_name) = self.blocks_for_names(names, docker_build)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/build.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 119 | let has_builder = builders.len() > 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!builders.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/build.rs:156:68 [INFO] [stdout] | [INFO] [stdout] 156 | ... (blocks_built, builders_executed) = build_block(dep_block, &self, blocks_built, builders_executed).await; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/build.rs:167:59 [INFO] [stdout] | [INFO] [stdout] 167 | (blocks_built, builders_executed) = build_block(block, &self, blocks_built, builders_executed).await; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::error::KddError; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / //// Builder Struct [INFO] [stdout] 16 | | #[derive(Debug)] [INFO] [stdout] 17 | | pub struct Builder { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 15 - //// Builder Struct [INFO] [stdout] 16 - #[derive(Debug)] [INFO] [stdout] 15 + /// Builder Struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / //// Builder Maker [INFO] [stdout] 33 | | impl Builder { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 32 - //// Builder Maker [INFO] [stdout] 33 - impl Builder { [INFO] [stdout] 32 + /// Builder Maker [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:121:1 [INFO] [stdout] | [INFO] [stdout] 121 | / //// Exec Builder(s) [INFO] [stdout] 122 | | impl Exec { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 121 - //// Exec Builder(s) [INFO] [stdout] 122 - impl Exec { [INFO] [stdout] 121 + /// Exec Builder(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/builder.rs:123:37 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn from_yaml(y_exec: &Yaml) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/kdd/builder.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 125 | let cmd_name = as_string(&y_exec, "cmd").ok_or_else(|| KddError::NoExecCmd)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 125 - let cmd_name = as_string(&y_exec, "cmd").ok_or_else(|| KddError::NoExecCmd)?; [INFO] [stdout] 125 + let cmd_name = as_string(&y_exec, "cmd").ok_or(KddError::NoExecCmd)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/builder.rs:125:28 [INFO] [stdout] | [INFO] [stdout] 125 | let cmd_name = as_string(&y_exec, "cmd").ok_or_else(|| KddError::NoExecCmd)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `y_exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/builder.rs:136:26 [INFO] [stdout] | [INFO] [stdout] 136 | let cwd = match as_str(&y_exec, "cwd") { [INFO] [stdout] | ^^^^^^^ help: change this to: `y_exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/builder.rs:147:57 [INFO] [stdout] | [INFO] [stdout] 147 | let args = as_strings(&y_exec, "args").unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/builder.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | let args = as_strings(&y_exec, "args").unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^ help: change this to: `y_exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/builder.rs:148:31 [INFO] [stdout] | [INFO] [stdout] 148 | let watch_args = as_strings(&y_exec, "watch_args"); [INFO] [stdout] | ^^^^^^^ help: change this to: `y_exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:158:1 [INFO] [stdout] | [INFO] [stdout] 158 | / //// Exec Public Methods [INFO] [stdout] 159 | | impl Exec { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 158 - //// Exec Public Methods [INFO] [stdout] 159 - impl Exec { [INFO] [stdout] 158 + /// Exec Public Methods [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/builder.rs:169:74 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn execute(&self, kdd_dir: &Path, block_dir: &Path, watch: bool) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kdd/builder.rs:196:20 [INFO] [stdout] | [INFO] [stdout] 196 | proc.current_dir(&cwd); [INFO] [stdout] | ^^^^ help: change this to: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/docker.rs:10:48 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn d_build_block(&self, block: &Block) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/docker.rs:11:32 [INFO] [stdout] | [INFO] [stdout] 11 | let cwd = self.get_block_dir(&block); [INFO] [stdout] | ^^^^^^ help: change this to: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/docker.rs:16:39 [INFO] [stdout] | [INFO] [stdout] 16 | let args = &["build", "--rm", "-t", &image_uri, "."]; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `image_uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/docker.rs:24:65 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn d_push(&self, realm: &Realm, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/docker.rs:36:62 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn d_push_block(&self, realm: &Realm, block: &Block) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/docker.rs:84:24 [INFO] [stdout] | [INFO] [stdout] 84 | let registry = realm.map(|r| r.registry.as_deref()).flatten().unwrap_or("localhost:5000"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|r| r.registry.as_deref())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/kctl.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use std::io::stdin; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:11:66 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn k_apply(&self, realm: &Realm, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:22:67 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn k_create(&self, realm: &Realm, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:34:67 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn k_delete(&self, realm: &Realm, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:56:47 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn k_create_context(&self, ctx: &str) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:63:34 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn k_list_context(&self) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:70:47 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn k_delete_context(&self, ctx: &str) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:77:37 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn k_current_context(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:84:44 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn k_set_context(&self, ctx: &str) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kdd/kevents.rs:71:31 [INFO] [stdout] | [INFO] [stdout] 71 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/kdd/kevents.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | let mut json = String::from(line); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kexec.rs:8:85 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn k_exec(&self, _realm: &Realm, names: Option<&[&str]>, pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> src/kdd/kexec.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | pods = pods.into_iter().filter(|pod| names_set.contains(&pod.service_name)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling `.retain()` instead: `pods.retain(|pod| names_set.contains(&pod.service_name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kexec.rs:23:54 [INFO] [stdout] | [INFO] [stdout] 23 | fn kexec_pods(pods: &Vec, pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/kexec.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | fn kexec_pods(pods: &Vec, pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn kexec_pods(pods: &Vec, pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] 23 + fn kexec_pods(pods: &[Pod], pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/klog.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::kevents::{monitor_kube_events, KubeEvent}; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/klog.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::kevents::{monitor_kube_events, KubeEvent}; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/klog.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::kevents::{monitor_kube_events, KubeEvent}; [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/klog.rs:30:69 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn k_log(&self, _realm: &Realm, names: Option>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/klog.rs:38:80 [INFO] [stdout] | [INFO] [stdout] 38 | async fn show_klogs_for_pods(kdd: &Kdd, service_names: Option>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/kdd/klog.rs:64:6 [INFO] [stdout] | [INFO] [stdout] 64 | / if pod_event.reason == "Started" { [INFO] [stdout] 65 | | // When restart, it says started, but the kubectl logs is not ready yet [INFO] [stdout] 66 | | sleep(Duration::from_secs(4)).await; [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ KubeEvent::Pod(pod_event) [INFO] [stdout] 64 ~ if pod_event.reason == "Started" => { [INFO] [stdout] 65 | // When restart, it says started, but the kubectl logs is not ready yet [INFO] [stdout] ... [INFO] [stdout] 78 | } [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/kdd/klog.rs:60:6 [INFO] [stdout] | [INFO] [stdout] 60 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/klog.rs:96:6 [INFO] [stdout] | [INFO] [stdout] 96 | if buf.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/kdd/klog.rs:102:7 [INFO] [stdout] | [INFO] [stdout] 102 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/klog.rs:128:53 [INFO] [stdout] | [INFO] [stdout] 128 | let pods = pods_provider.get_pods_by_service_names(&service_names)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `service_names` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/app_error.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / pub enum AppError { [INFO] [stdout] 5 | | #[error(transparent)] [INFO] [stdout] 6 | | IOError(#[from] std::io::Error), [INFO] [stdout] ... | [INFO] [stdout] 12 | | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kdd/klog.rs:168:30 [INFO] [stdout] | [INFO] [stdout] 168 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/cmd/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use self::argc::cmd_app; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] = note: `#[warn(clippy::four_forward_slashes)]` on by default [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/cmd/argc.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | .version(&crate_version!()[..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use the original value instead: `crate_version!()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/kdd/klog.rs:177:10 [INFO] [stdout] | [INFO] [stdout] 177 | if let Err(_) = tx [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 ~ if tx [INFO] [stdout] 178 ~ .send(LogMessage { [INFO] [stdout] 179 ~ service_name: pod.service_name.to_string(), [INFO] [stdout] 180 ~ pod_name: pod.name.to_string(), [INFO] [stdout] 181 ~ line: line, [INFO] [stdout] 182 ~ }) [INFO] [stdout] 183 ~ .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/ktemplate.rs:18:88 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn k_templates(&self, realm: &Realm, names: Option<&[&str]>, print_full: bool) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/ktemplate.rs:41:50 [INFO] [stdout] | [INFO] [stdout] 41 | if let Some(file_name) = src_file.file_name().map(|v| v.to_str()).flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/loader.rs:23:35 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn from_dir(dir: PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn cmd_run() -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/loader.rs:112:60 [INFO] [stdout] | [INFO] [stdout] 112 | fn parse_kdd_raw_part(dir: &PathBuf, kdd_content: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:53:73 [INFO] [stdout] | [INFO] [stdout] 53 | fn exec_build(root_dir: &str, argc: &ArgMatches, docker_build: bool) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:116:32 [INFO] [stdout] | [INFO] [stdout] 116 | let splits: Vec<_> = rx.split(&kdd_content).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `kdd_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:132:31 [INFO] [stdout] | [INFO] [stdout] 132 | let extra_vars = load_vars(&dir, &pre_yaml); [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:133:33 [INFO] [stdout] | [INFO] [stdout] 133 | let overlays = load_overlays(&dir, &pre_yaml); [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/loader.rs:169:6 [INFO] [stdout] | [INFO] [stdout] 169 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:171:48 [INFO] [stdout] | [INFO] [stdout] 171 | let rendered_yaml = match hbs.render_template(&kdd_yaml_txt, &root_vars) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `kdd_yaml_txt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/loader.rs:242:36 [INFO] [stdout] | [INFO] [stdout] 242 | fn load_vars(dir: &PathBuf, yamls: &Vec) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 242 - fn load_vars(dir: &PathBuf, yamls: &Vec) -> HashMap { [INFO] [stdout] 242 + fn load_vars(dir: &PathBuf, yamls: &[Yaml]) -> HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:248:21 [INFO] [stdout] | [INFO] [stdout] 248 | match (has_prop(&yaml_item, "from_file"), has_prop(&yaml_item, "from_env")) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `yaml_item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:248:56 [INFO] [stdout] | [INFO] [stdout] 248 | match (has_prop(&yaml_item, "from_file"), has_prop(&yaml_item, "from_env")) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `yaml_item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/cmd/mod.rs:56:47 [INFO] [stdout] | [INFO] [stdout] 56 | let blocks = argc.value_of("blocks").map(|v| v.split(",").into_iter().collect::>()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.split(",")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/loader.rs:272:29 [INFO] [stdout] | [INFO] [stdout] 272 | fn load_vars_from_file(dir: &PathBuf, yaml_item: &Yaml, vars: &mut HashMap) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 272 - fn load_vars_from_file(dir: &PathBuf, yaml_item: &Yaml, vars: &mut HashMap) { [INFO] [stdout] 272 + fn load_vars_from_file(dir: &Path, yaml_item: &Yaml, vars: &mut HashMap) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:64:53 [INFO] [stdout] | [INFO] [stdout] 64 | fn exec_watch(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/cmd/mod.rs:66:47 [INFO] [stdout] | [INFO] [stdout] 66 | let blocks = argc.value_of("blocks").map(|v| v.split(",").into_iter().collect::>()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.split(",")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:74:53 [INFO] [stdout] | [INFO] [stdout] 74 | fn exec_dpush(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/cmd/mod.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 80 | let realm = kdd.current_realm()?.ok_or_else(|| KddError::DpushFailNoRealm)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 80 - let realm = kdd.current_realm()?.ok_or_else(|| KddError::DpushFailNoRealm)?; [INFO] [stdout] 80 + let realm = kdd.current_realm()?.ok_or(KddError::DpushFailNoRealm)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:87:53 [INFO] [stdout] | [INFO] [stdout] 87 | fn exec_realm(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/loader.rs:332:23 [INFO] [stdout] | [INFO] [stdout] 332 | fn load_overlays(dir: &PathBuf, pre_yamls: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 332 - fn load_overlays(dir: &PathBuf, pre_yamls: &Vec) -> Vec { [INFO] [stdout] 332 + fn load_overlays(dir: &Path, pre_yamls: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/loader.rs:332:44 [INFO] [stdout] | [INFO] [stdout] 332 | fn load_overlays(dir: &PathBuf, pre_yamls: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 332 - fn load_overlays(dir: &PathBuf, pre_yamls: &Vec) -> Vec { [INFO] [stdout] 332 + fn load_overlays(dir: &PathBuf, pre_yamls: &[Yaml]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:103:69 [INFO] [stdout] | [INFO] [stdout] 103 | fn exec_kaction(action: &str, root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/loader.rs:345:7 [INFO] [stdout] | [INFO] [stdout] 345 | if overlays.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!overlays.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|v| v.as_slice())` on an `Option` value [INFO] [stdout] --> src/cmd/mod.rs:112:32 [INFO] [stdout] | [INFO] [stdout] 112 | let names = names.or_else(|| config_names.as_ref().map(|v| v.as_slice())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `config_names.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:128:52 [INFO] [stdout] | [INFO] [stdout] 128 | fn exec_kctx(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:384:29 [INFO] [stdout] | [INFO] [stdout] 384 | merge_yaml(&mut data, &base, true); [INFO] [stdout] | ^^^^^ help: change this to: `base` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:140:38 [INFO] [stdout] | [INFO] [stdout] 140 | fn exec_kctx_list(root_dir: &str) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:406:46 [INFO] [stdout] | [INFO] [stdout] 406 | .map(|y_blocks| y_blocks.iter().filter_map(|x| Block::from_yaml(x)).collect::>()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Block::from_yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:407:24 [INFO] [stdout] | [INFO] [stdout] 407 | blocks.unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:417:16 [INFO] [stdout] | [INFO] [stdout] 417 | .filter_map(|x| Builder::from_yaml(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Builder::from_yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:421:26 [INFO] [stdout] | [INFO] [stdout] 421 | builders.unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:156:59 [INFO] [stdout] | [INFO] [stdout] 156 | fn exec_kctx_create(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:431:16 [INFO] [stdout] | [INFO] [stdout] 431 | .filter_map(|x| Version::from_yaml(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Version::from_yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:435:26 [INFO] [stdout] | [INFO] [stdout] 435 | versions.unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/provider.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, Block, Realm}; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/provider.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, Block, Realm}; [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:165:59 [INFO] [stdout] | [INFO] [stdout] 165 | fn exec_kctx_delete(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/provider.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, Block, Realm}; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/provider.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, Block, Realm}; [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_realm(&self) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:24:32 [INFO] [stdout] | [INFO] [stdout] 24 | fn before_set_realm(&self) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:174:52 [INFO] [stdout] | [INFO] [stdout] 174 | fn exec_klog(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:28:82 [INFO] [stdout] | [INFO] [stdout] 28 | fn before_dpushes(&self, _system: &str, _realmm: &Realm, _blocks: &[&Block]) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:32:43 [INFO] [stdout] | [INFO] [stdout] 32 | fn docker_auth(&self, _realm: &Realm) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:190:53 [INFO] [stdout] | [INFO] [stdout] 190 | fn exec_kexec(root_dir: &str, argc: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:225:52 [INFO] [stdout] | [INFO] [stdout] 225 | fn exec_version(root_dir: &str, _: &ArgMatches) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kdd/provider.rs:90:32 [INFO] [stdout] | [INFO] [stdout] 90 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/cmd/mod.rs:238:14 [INFO] [stdout] | [INFO] [stdout] 238 | val.map(|v| v.split(",").into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.split(",")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/cmd/mod.rs:241:32 [INFO] [stdout] | [INFO] [stdout] 241 | fn load_kdd(root_dir: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:103:59 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn get_aws_repository_names(&self, realm: &Realm) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | mod block; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{ [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / //// Realm Struct [INFO] [stdout] 28 | | #[derive(Debug)] [INFO] [stdout] 29 | | pub struct Realm { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 27 - //// Realm Struct [INFO] [stdout] 28 - #[derive(Debug)] [INFO] [stdout] 27 + /// Realm Struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/block.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use yaml_rust::Yaml; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/block.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / //// Block Struct [INFO] [stdout] 15 | | #[derive(Debug, Default)] [INFO] [stdout] 16 | | pub struct Block { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 14 - //// Block Struct [INFO] [stdout] 15 - #[derive(Debug, Default)] [INFO] [stdout] 14 + /// Block Struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | / //// Realm Public Methods [INFO] [stdout] 43 | | impl Realm { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 42 - //// Realm Public Methods [INFO] [stdout] 43 - impl Realm { [INFO] [stdout] 42 + /// Realm Public Methods [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:44:41 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn provider_from_ctx(ctx: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/block.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / //// Block Builder(s) [INFO] [stdout] 24 | | impl Block { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 23 - //// Block Builder(s) [INFO] [stdout] 24 - impl Block { [INFO] [stdout] 23 + /// Block Builder(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/kdd/realm.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | / loop { [INFO] [stdout] 82 | | match yaml_dirs.next() { [INFO] [stdout] 83 | | Some(dir_path) => { [INFO] [stdout] 84 | | let yaml_path = dir_path.join(format!("{}.yaml", name)); [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_________________^ help: try: `while let Some(dir_path) = yaml_dirs.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/block.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | dir: as_string(&yaml, BLOCK_KEY_DIR), [INFO] [stdout] | ^^^^^ help: change this to: `yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/block.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 38 | dependencies: as_strings(&yaml, BLOCK_KEY_DEP), [INFO] [stdout] | ^^^^^ help: change this to: `yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/build.rs:11:80 [INFO] [stdout] | [INFO] [stdout] 11 | ...ion<&[&str]>, docker_block: bool) -> Result<(Vec<&Block>, HashMap<&str, &Block>), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> src/kdd/build.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | / blocks_to_build = blocks_to_build [INFO] [stdout] 31 | | .into_iter() [INFO] [stdout] 32 | | .filter(|b| self.get_block_dir(b).join("Dockerfile").is_file()) [INFO] [stdout] 33 | | .collect(); [INFO] [stdout] | |__________________________^ help: consider calling `.retain()` instead: `blocks_to_build.retain(|b| self.get_block_dir(b).join("Dockerfile").is_file())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] = note: `#[warn(clippy::manual_retain)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/kdd/realm.rs:101:6 [INFO] [stdout] | [INFO] [stdout] 101 | / for path in paths { [INFO] [stdout] 102 | | if let Ok(path) = path { [INFO] [stdout] 103 | | let path = path.path(); [INFO] [stdout] 104 | | if let (Some(stem), Some(ext)) = [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/kdd/realm.rs:102:7 [INFO] [stdout] | [INFO] [stdout] 102 | / if let Ok(path) = path { [INFO] [stdout] 103 | | let path = path.path(); [INFO] [stdout] 104 | | if let (Some(stem), Some(ext)) = [INFO] [stdout] 105 | | (path.file_stem().map(|v| v.to_str()).flatten(), path.extension().map(|v| v.to_str()).flatten()) [INFO] [stdout] ... | [INFO] [stdout] 112 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 101 ~ for path in paths.flatten() { [INFO] [stdout] 102 ~ let path = path.path(); [INFO] [stdout] 103 ~ if let (Some(stem), Some(ext)) = [INFO] [stdout] 104 ~ (path.file_stem().map(|v| v.to_str()).flatten(), path.extension().map(|v| v.to_str()).flatten()) [INFO] [stdout] 105 ~ { [INFO] [stdout] 106 ~ if path.is_file() && ext.to_lowercase() == "yaml" && !stems_set.contains(stem) { [INFO] [stdout] 107 ~ stems_set.insert(stem.to_string()); [INFO] [stdout] 108 ~ yaml_paths.push(path); [INFO] [stdout] 109 ~ } [INFO] [stdout] 110 ~ } [INFO] [stdout] 111 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/realm.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | ... (path.file_stem().map(|v| v.to_str()).flatten(), path.extension().map(|v| v.to_str()).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/realm.rs:105:75 [INFO] [stdout] | [INFO] [stdout] 105 | ... (path.file_stem().map(|v| v.to_str()).flatten(), path.extension().map(|v| v.to_str()).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:140:1 [INFO] [stdout] | [INFO] [stdout] 140 | / //// Realm Builder(s) [INFO] [stdout] 141 | | impl Realm { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 140 - //// Realm Builder(s) [INFO] [stdout] 141 - impl Realm { [INFO] [stdout] 140 + /// Realm Builder(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:142:66 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn from_yaml(kdd_dir: &PathBuf, name: &str, yaml: &Yaml) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/realm.rs:142:28 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn from_yaml(kdd_dir: &PathBuf, name: &str, yaml: &Yaml) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 142 - pub fn from_yaml(kdd_dir: &PathBuf, name: &str, yaml: &Yaml) -> Result { [INFO] [stdout] 142 + pub fn from_yaml(kdd_dir: &Path, name: &str, yaml: &Yaml) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/realm.rs:150:20 [INFO] [stdout] | [INFO] [stdout] 150 | .unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/realm.rs:152:6 [INFO] [stdout] | [INFO] [stdout] 152 | if yaml_dirs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `yaml_dirs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/build.rs:63:55 [INFO] [stdout] | [INFO] [stdout] 63 | pub async fn watch(&self, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/build.rs:70:40 [INFO] [stdout] | [INFO] [stdout] 70 | let block_dir = self.get_block_dir(&block); [INFO] [stdout] | ^^^^^^ help: change this to: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:192:1 [INFO] [stdout] | [INFO] [stdout] 192 | / //// Kdd Realm Methods [INFO] [stdout] 193 | | impl Kdd { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 192 - //// Kdd Realm Methods [INFO] [stdout] 193 - impl Kdd { [INFO] [stdout] 192 + /// Kdd Realm Methods [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:200:33 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn current_realm(&self) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/build.rs:89:75 [INFO] [stdout] | [INFO] [stdout] 89 | pub async fn build(&self, names: Option<&[&str]>, docker_build: bool) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:210:41 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn realm_set(&self, name: &str) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `blocks_to_build` [INFO] [stdout] --> src/kdd/build.rs:108:3 [INFO] [stdout] | [INFO] [stdout] 108 | let blocks_to_build = blocks_to_build; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `blocks_to_build` is initially defined here [INFO] [stdout] --> src/kdd/build.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 90 | let (blocks_to_build, block_by_name) = self.blocks_for_names(names, docker_build)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/realm.rs:228:30 [INFO] [stdout] | [INFO] [stdout] 228 | ... self.k_create_context(&ctx); [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/realm.rs:229:27 [INFO] [stdout] | [INFO] [stdout] 229 | ... self.k_set_context(&ctx); [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/build.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 119 | let has_builder = builders.len() > 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!builders.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/realm.rs:231:27 [INFO] [stdout] | [INFO] [stdout] 231 | ... self.k_set_context(&ctx); [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:242:32 [INFO] [stdout] | [INFO] [stdout] 242 | pub fn print_realms(&self) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/realm.rs:244:35 [INFO] [stdout] | [INFO] [stdout] 244 | let current_ctx = current_realm.map(|r| r.context.as_deref()).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|r| r.context.as_deref())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/version.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use regex::Regex; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/version.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / //// Version Struct [INFO] [stdout] 15 | | #[derive(Debug)] [INFO] [stdout] 16 | | pub struct Version { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 14 - //// Version Struct [INFO] [stdout] 15 - #[derive(Debug)] [INFO] [stdout] 14 + /// Version Struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/version.rs:39:58 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn version(&self, out: &mut impl std::io::Write) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/version.rs:41:6 [INFO] [stdout] | [INFO] [stdout] 41 | if self.versions.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.versions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/build.rs:156:68 [INFO] [stdout] | [INFO] [stdout] 156 | ... (blocks_built, builders_executed) = build_block(dep_block, &self, blocks_built, builders_executed).await; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/build.rs:167:59 [INFO] [stdout] | [INFO] [stdout] 167 | (blocks_built, builders_executed) = build_block(block, &self, blocks_built, builders_executed).await; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/version.rs:75:10 [INFO] [stdout] | [INFO] [stdout] 75 | ... .map(|caps| caps.get(caps.len() - 1).map(|m| m.as_str())) [INFO] [stdout] | ________________________^ [INFO] [stdout] 76 | | ... .flatten(); [INFO] [stdout] | |________________________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|caps| caps.get(caps.len() - 1).map(|m| m.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/version.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | ... .map(|caps| caps.get(caps.len() - 1).map(|m| m.as_str())) [INFO] [stdout] | ________________________^ [INFO] [stdout] 84 | | ... .flatten(); [INFO] [stdout] | |________________________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|caps| caps.get(caps.len() - 1).map(|m| m.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::error::KddError; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / //// Builder Struct [INFO] [stdout] 16 | | #[derive(Debug)] [INFO] [stdout] 17 | | pub struct Builder { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 15 - //// Builder Struct [INFO] [stdout] 16 - #[derive(Debug)] [INFO] [stdout] 15 + /// Builder Struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / //// Builder Maker [INFO] [stdout] 33 | | impl Builder { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 32 - //// Builder Maker [INFO] [stdout] 33 - impl Builder { [INFO] [stdout] 32 + /// Builder Maker [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/kdd/mod.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | block_dir.join(&path[2..]) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/kdd/mod.rs:115:3 [INFO] [stdout] | [INFO] [stdout] 115 | if path.starts_with("./") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 115 ~ if let Some() = path.strip_prefix("./") { [INFO] [stdout] 116 | let block_dir = self.get_block_dir(&block); [INFO] [stdout] 117 ~ block_dir.join() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/mod.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 116 | let block_dir = self.get_block_dir(&block); [INFO] [stdout] | ^^^^^^ help: change this to: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/mod.rs:138:82 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn get_pods_by_service_names(&self, service_names: &Option>) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/mod.rs:153:82 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn get_pods_by_service_names(&self, service_names: &Option>) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> src/kdd/mod.rs:162:4 [INFO] [stdout] | [INFO] [stdout] 162 | pods = pods.into_iter().filter(|pod| names_set.contains(&pod.service_name)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling `.retain()` instead: `pods.retain(|pod| names_set.contains(&pod.service_name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/mod.rs:172:22 [INFO] [stdout] | [INFO] [stdout] 172 | fn k_list_pods() -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/kdd/mod.rs:177:4 [INFO] [stdout] | [INFO] [stdout] 177 | / match (json_pod.pointer("/metadata/name"), json_pod.pointer("/metadata/labels/run")) { [INFO] [stdout] 178 | | (Some(Value::String(pod_name)), Some(Value::String(service_name))) => { [INFO] [stdout] 179 | | pods.push(Pod { [INFO] [stdout] 180 | | name: pod_name.to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 184 | | _ => {} [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 ~ if let (Some(Value::String(pod_name)), Some(Value::String(service_name))) = (json_pod.pointer("/metadata/name"), json_pod.pointer("/metadata/labels/run")) { [INFO] [stdout] 178 ~ pods.push(Pod { [INFO] [stdout] 179 ~ name: pod_name.to_owned(), [INFO] [stdout] 180 ~ service_name: service_name.to_owned(), [INFO] [stdout] 181 ~ }); [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:121:1 [INFO] [stdout] | [INFO] [stdout] 121 | / //// Exec Builder(s) [INFO] [stdout] 122 | | impl Exec { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 121 - //// Exec Builder(s) [INFO] [stdout] 122 - impl Exec { [INFO] [stdout] 121 + /// Exec Builder(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/builder.rs:123:37 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn from_yaml(y_exec: &Yaml) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/kdd/builder.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 125 | let cmd_name = as_string(&y_exec, "cmd").ok_or_else(|| KddError::NoExecCmd)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 125 - let cmd_name = as_string(&y_exec, "cmd").ok_or_else(|| KddError::NoExecCmd)?; [INFO] [stdout] 125 + let cmd_name = as_string(&y_exec, "cmd").ok_or(KddError::NoExecCmd)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/builder.rs:125:28 [INFO] [stdout] | [INFO] [stdout] 125 | let cmd_name = as_string(&y_exec, "cmd").ok_or_else(|| KddError::NoExecCmd)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `y_exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/builder.rs:136:26 [INFO] [stdout] | [INFO] [stdout] 136 | let cwd = match as_str(&y_exec, "cwd") { [INFO] [stdout] | ^^^^^^^ help: change this to: `y_exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/builder.rs:147:57 [INFO] [stdout] | [INFO] [stdout] 147 | let args = as_strings(&y_exec, "args").unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/builder.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | let args = as_strings(&y_exec, "args").unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^ help: change this to: `y_exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/builder.rs:148:31 [INFO] [stdout] | [INFO] [stdout] 148 | let watch_args = as_strings(&y_exec, "watch_args"); [INFO] [stdout] | ^^^^^^^ help: change this to: `y_exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/builder.rs:158:1 [INFO] [stdout] | [INFO] [stdout] 158 | / //// Exec Public Methods [INFO] [stdout] 159 | | impl Exec { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 158 - //// Exec Public Methods [INFO] [stdout] 159 - impl Exec { [INFO] [stdout] 158 + /// Exec Public Methods [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/mod.rs:190:44 [INFO] [stdout] | [INFO] [stdout] 190 | fn k_get_json_items(entity_type: &str) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/builder.rs:169:74 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn execute(&self, kdd_dir: &Path, block_dir: &Path, watch: bool) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kdd/builder.rs:196:20 [INFO] [stdout] | [INFO] [stdout] 196 | proc.current_dir(&cwd); [INFO] [stdout] | ^^^^ help: change this to: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utils/yamls.rs:48:3 [INFO] [stdout] | [INFO] [stdout] 40 | / let val = if val.contains("{{") { [INFO] [stdout] 41 | | match Template::compile(val) { [INFO] [stdout] 42 | | Ok(tmpl) => Stmpl::Tmpl(tmpl, val.to_string()), [INFO] [stdout] 43 | | Err(_) => Stmpl::Plain(val.to_owned()), [INFO] [stdout] ... | [INFO] [stdout] 46 | | Stmpl::Plain(val.to_owned()) [INFO] [stdout] 47 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 48 | val [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 40 ~ [INFO] [stdout] 41 ~ if val.contains("{{") { [INFO] [stdout] 42 ~ match Template::compile(val) { [INFO] [stdout] 43 ~ Ok(tmpl) => Stmpl::Tmpl(tmpl, val.to_string()), [INFO] [stdout] 44 ~ Err(_) => Stmpl::Plain(val.to_owned()), [INFO] [stdout] 45 ~ } [INFO] [stdout] 46 ~ } else { [INFO] [stdout] 47 ~ Stmpl::Plain(val.to_owned()) [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/yamls.rs:56:6 [INFO] [stdout] | [INFO] [stdout] 56 | if hash.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hash.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/docker.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, realm::Realm, Block, Kdd}; [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b [INFO] [stdout] --> src/utils/yamls.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn as_str<'a, 'b>(yaml: &'a Yaml, key: &'b str) -> Option<&'a str> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 85 - pub fn as_str<'a, 'b>(yaml: &'a Yaml, key: &'b str) -> Option<&'a str> { [INFO] [stdout] 85 + pub fn as_str<'a>(yaml: &'a Yaml, key: &str) -> Option<&'a str> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/docker.rs:10:48 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn d_build_block(&self, block: &Block) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/docker.rs:11:32 [INFO] [stdout] | [INFO] [stdout] 11 | let cwd = self.get_block_dir(&block); [INFO] [stdout] | ^^^^^^ help: change this to: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/docker.rs:16:39 [INFO] [stdout] | [INFO] [stdout] 16 | let args = &["build", "--rm", "-t", &image_uri, "."]; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `image_uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/docker.rs:24:65 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn d_push(&self, realm: &Realm, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/utils/yamls.rs:115:22 [INFO] [stdout] | [INFO] [stdout] 115 | let strings = vals.into_iter().filter_map(|x| x.as_str().map(|x| x.to_owned())).collect(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/utils/yamls.rs:139:1 [INFO] [stdout] | [INFO] [stdout] 139 | / //// Merge in place a extra yaml to a target [INFO] [stdout] 140 | | pub fn merge_yaml(target: &mut Yaml, extra: &Yaml, overwrite: bool) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 139 - //// Merge in place a extra yaml to a target [INFO] [stdout] 140 - pub fn merge_yaml(target: &mut Yaml, extra: &Yaml, overwrite: bool) { [INFO] [stdout] 139 + /// Merge in place a extra yaml to a target [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/docker.rs:36:62 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn d_push_block(&self, realm: &Realm, block: &Block) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/yamls.rs:144:7 [INFO] [stdout] | [INFO] [stdout] 144 | if !overwrite || overwrite && !target.contains_key(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 144 - if !overwrite || overwrite && !target.contains_key(key) { [INFO] [stdout] 144 + if !(overwrite && target.contains_key(key)) { [INFO] [stdout] | [INFO] [stdout] 144 - if !overwrite || overwrite && !target.contains_key(key) { [INFO] [stdout] 144 + if !overwrite || !target.contains_key(key) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils/mod.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn path_to_string(path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 34 - pub fn path_to_string(path: &PathBuf) -> Result { [INFO] [stdout] 34 + pub fn path_to_string(path: &Path) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/docker.rs:84:24 [INFO] [stdout] | [INFO] [stdout] 84 | let registry = realm.map(|r| r.registry.as_deref()).flatten().unwrap_or("localhost:5000"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|r| r.registry.as_deref())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/utils/mod.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | Ok(proc.spawn()?.wait()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 42 - Ok(proc.spawn()?.wait()?) [INFO] [stdout] 42 + proc.spawn()?.wait() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/mod.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 70 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/kctl.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use std::io::stdin; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:11:66 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn k_apply(&self, realm: &Realm, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:22:67 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn k_create(&self, realm: &Realm, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:34:67 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn k_delete(&self, realm: &Realm, names: Option<&[&str]>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:56:47 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn k_create_context(&self, ctx: &str) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:63:34 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn k_list_context(&self) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:70:47 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn k_delete_context(&self, ctx: &str) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:77:37 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn k_current_context(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kctl.rs:84:44 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn k_set_context(&self, ctx: &str) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kdd/kevents.rs:71:31 [INFO] [stdout] | [INFO] [stdout] 71 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/kdd/kevents.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | let mut json = String::from(line); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kexec.rs:8:85 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn k_exec(&self, _realm: &Realm, names: Option<&[&str]>, pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> src/kdd/kexec.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | pods = pods.into_iter().filter(|pod| names_set.contains(&pod.service_name)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling `.retain()` instead: `pods.retain(|pod| names_set.contains(&pod.service_name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/kexec.rs:23:54 [INFO] [stdout] | [INFO] [stdout] 23 | fn kexec_pods(pods: &Vec, pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/kexec.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | fn kexec_pods(pods: &Vec, pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn kexec_pods(pods: &Vec, pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] 23 + fn kexec_pods(pods: &[Pod], pod_args: &[&str]) -> Result<(), KddError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/klog.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::kevents::{monitor_kube_events, KubeEvent}; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/klog.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::kevents::{monitor_kube_events, KubeEvent}; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/klog.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::kevents::{monitor_kube_events, KubeEvent}; [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/klog.rs:30:69 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn k_log(&self, _realm: &Realm, names: Option>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/klog.rs:38:80 [INFO] [stdout] | [INFO] [stdout] 38 | async fn show_klogs_for_pods(kdd: &Kdd, service_names: Option>) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/kdd/klog.rs:64:6 [INFO] [stdout] | [INFO] [stdout] 64 | / if pod_event.reason == "Started" { [INFO] [stdout] 65 | | // When restart, it says started, but the kubectl logs is not ready yet [INFO] [stdout] 66 | | sleep(Duration::from_secs(4)).await; [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ KubeEvent::Pod(pod_event) [INFO] [stdout] 64 ~ if pod_event.reason == "Started" => { [INFO] [stdout] 65 | // When restart, it says started, but the kubectl logs is not ready yet [INFO] [stdout] ... [INFO] [stdout] 78 | } [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/kdd/klog.rs:60:6 [INFO] [stdout] | [INFO] [stdout] 60 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/klog.rs:96:6 [INFO] [stdout] | [INFO] [stdout] 96 | if buf.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/kdd/klog.rs:102:7 [INFO] [stdout] | [INFO] [stdout] 102 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/klog.rs:128:53 [INFO] [stdout] | [INFO] [stdout] 128 | let pods = pods_provider.get_pods_by_service_names(&service_names)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `service_names` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kdd/klog.rs:168:30 [INFO] [stdout] | [INFO] [stdout] 168 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/kdd/klog.rs:177:10 [INFO] [stdout] | [INFO] [stdout] 177 | if let Err(_) = tx [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 ~ if tx [INFO] [stdout] 178 ~ .send(LogMessage { [INFO] [stdout] 179 ~ service_name: pod.service_name.to_string(), [INFO] [stdout] 180 ~ pod_name: pod.name.to_string(), [INFO] [stdout] 181 ~ line: line, [INFO] [stdout] 182 ~ }) [INFO] [stdout] 183 ~ .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/ktemplate.rs:18:88 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn k_templates(&self, realm: &Realm, names: Option<&[&str]>, print_full: bool) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/ktemplate.rs:41:50 [INFO] [stdout] | [INFO] [stdout] 41 | if let Some(file_name) = src_file.file_name().map(|v| v.to_str()).flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/loader.rs:23:35 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn from_dir(dir: PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/loader.rs:112:60 [INFO] [stdout] | [INFO] [stdout] 112 | fn parse_kdd_raw_part(dir: &PathBuf, kdd_content: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:116:32 [INFO] [stdout] | [INFO] [stdout] 116 | let splits: Vec<_> = rx.split(&kdd_content).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `kdd_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:132:31 [INFO] [stdout] | [INFO] [stdout] 132 | let extra_vars = load_vars(&dir, &pre_yaml); [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:133:33 [INFO] [stdout] | [INFO] [stdout] 133 | let overlays = load_overlays(&dir, &pre_yaml); [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/loader.rs:169:6 [INFO] [stdout] | [INFO] [stdout] 169 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:171:48 [INFO] [stdout] | [INFO] [stdout] 171 | let rendered_yaml = match hbs.render_template(&kdd_yaml_txt, &root_vars) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `kdd_yaml_txt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/loader.rs:242:36 [INFO] [stdout] | [INFO] [stdout] 242 | fn load_vars(dir: &PathBuf, yamls: &Vec) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 242 - fn load_vars(dir: &PathBuf, yamls: &Vec) -> HashMap { [INFO] [stdout] 242 + fn load_vars(dir: &PathBuf, yamls: &[Yaml]) -> HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:248:21 [INFO] [stdout] | [INFO] [stdout] 248 | match (has_prop(&yaml_item, "from_file"), has_prop(&yaml_item, "from_env")) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `yaml_item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:248:56 [INFO] [stdout] | [INFO] [stdout] 248 | match (has_prop(&yaml_item, "from_file"), has_prop(&yaml_item, "from_env")) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `yaml_item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/loader.rs:272:29 [INFO] [stdout] | [INFO] [stdout] 272 | fn load_vars_from_file(dir: &PathBuf, yaml_item: &Yaml, vars: &mut HashMap) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 272 - fn load_vars_from_file(dir: &PathBuf, yaml_item: &Yaml, vars: &mut HashMap) { [INFO] [stdout] 272 + fn load_vars_from_file(dir: &Path, yaml_item: &Yaml, vars: &mut HashMap) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/loader.rs:332:23 [INFO] [stdout] | [INFO] [stdout] 332 | fn load_overlays(dir: &PathBuf, pre_yamls: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 332 - fn load_overlays(dir: &PathBuf, pre_yamls: &Vec) -> Vec { [INFO] [stdout] 332 + fn load_overlays(dir: &Path, pre_yamls: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/loader.rs:332:44 [INFO] [stdout] | [INFO] [stdout] 332 | fn load_overlays(dir: &PathBuf, pre_yamls: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 332 - fn load_overlays(dir: &PathBuf, pre_yamls: &Vec) -> Vec { [INFO] [stdout] 332 + fn load_overlays(dir: &PathBuf, pre_yamls: &[Yaml]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/loader.rs:345:7 [INFO] [stdout] | [INFO] [stdout] 345 | if overlays.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!overlays.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/loader.rs:384:29 [INFO] [stdout] | [INFO] [stdout] 384 | merge_yaml(&mut data, &base, true); [INFO] [stdout] | ^^^^^ help: change this to: `base` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:406:46 [INFO] [stdout] | [INFO] [stdout] 406 | .map(|y_blocks| y_blocks.iter().filter_map(|x| Block::from_yaml(x)).collect::>()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Block::from_yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:407:24 [INFO] [stdout] | [INFO] [stdout] 407 | blocks.unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:417:16 [INFO] [stdout] | [INFO] [stdout] 417 | .filter_map(|x| Builder::from_yaml(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Builder::from_yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:421:26 [INFO] [stdout] | [INFO] [stdout] 421 | builders.unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:431:16 [INFO] [stdout] | [INFO] [stdout] 431 | .filter_map(|x| Version::from_yaml(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Version::from_yaml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/loader.rs:435:26 [INFO] [stdout] | [INFO] [stdout] 435 | versions.unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/kdd/../_test/kdd_loader.rs:53:2 [INFO] [stdout] | [INFO] [stdout] 53 | assert_eq!(false, realm.confirm_delete); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 53 - assert_eq!(false, realm.confirm_delete); [INFO] [stdout] 53 + assert!(!realm.confirm_delete); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/kdd/../_test/kdd_loader.rs:72:2 [INFO] [stdout] | [INFO] [stdout] 72 | assert_eq!(true, realm.confirm_delete); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 - assert_eq!(true, realm.confirm_delete); [INFO] [stdout] 72 + assert!(realm.confirm_delete); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/provider.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, Block, Realm}; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/provider.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, Block, Realm}; [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/provider.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, Block, Realm}; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/provider.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{error::KddError, Block, Realm}; [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 20 | fn check_realm(&self) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:24:32 [INFO] [stdout] | [INFO] [stdout] 24 | fn before_set_realm(&self) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:28:82 [INFO] [stdout] | [INFO] [stdout] 28 | fn before_dpushes(&self, _system: &str, _realmm: &Realm, _blocks: &[&Block]) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:32:43 [INFO] [stdout] | [INFO] [stdout] 32 | fn docker_auth(&self, _realm: &Realm) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kdd/provider.rs:90:32 [INFO] [stdout] | [INFO] [stdout] 90 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/provider.rs:103:59 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn get_aws_repository_names(&self, realm: &Realm) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use super::{ [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / //// Realm Struct [INFO] [stdout] 28 | | #[derive(Debug)] [INFO] [stdout] 29 | | pub struct Realm { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 27 - //// Realm Struct [INFO] [stdout] 28 - #[derive(Debug)] [INFO] [stdout] 27 + /// Realm Struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | / //// Realm Public Methods [INFO] [stdout] 43 | | impl Realm { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 42 - //// Realm Public Methods [INFO] [stdout] 43 - impl Realm { [INFO] [stdout] 42 + /// Realm Public Methods [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:44:41 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn provider_from_ctx(ctx: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/kdd/realm.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | / loop { [INFO] [stdout] 82 | | match yaml_dirs.next() { [INFO] [stdout] 83 | | Some(dir_path) => { [INFO] [stdout] 84 | | let yaml_path = dir_path.join(format!("{}.yaml", name)); [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_________________^ help: try: `while let Some(dir_path) = yaml_dirs.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/kdd/realm.rs:101:6 [INFO] [stdout] | [INFO] [stdout] 101 | / for path in paths { [INFO] [stdout] 102 | | if let Ok(path) = path { [INFO] [stdout] 103 | | let path = path.path(); [INFO] [stdout] 104 | | if let (Some(stem), Some(ext)) = [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/kdd/realm.rs:102:7 [INFO] [stdout] | [INFO] [stdout] 102 | / if let Ok(path) = path { [INFO] [stdout] 103 | | let path = path.path(); [INFO] [stdout] 104 | | if let (Some(stem), Some(ext)) = [INFO] [stdout] 105 | | (path.file_stem().map(|v| v.to_str()).flatten(), path.extension().map(|v| v.to_str()).flatten()) [INFO] [stdout] ... | [INFO] [stdout] 112 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 101 ~ for path in paths.flatten() { [INFO] [stdout] 102 ~ let path = path.path(); [INFO] [stdout] 103 ~ if let (Some(stem), Some(ext)) = [INFO] [stdout] 104 ~ (path.file_stem().map(|v| v.to_str()).flatten(), path.extension().map(|v| v.to_str()).flatten()) [INFO] [stdout] 105 ~ { [INFO] [stdout] 106 ~ if path.is_file() && ext.to_lowercase() == "yaml" && !stems_set.contains(stem) { [INFO] [stdout] 107 ~ stems_set.insert(stem.to_string()); [INFO] [stdout] 108 ~ yaml_paths.push(path); [INFO] [stdout] 109 ~ } [INFO] [stdout] 110 ~ } [INFO] [stdout] 111 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/realm.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | ... (path.file_stem().map(|v| v.to_str()).flatten(), path.extension().map(|v| v.to_str()).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/realm.rs:105:75 [INFO] [stdout] | [INFO] [stdout] 105 | ... (path.file_stem().map(|v| v.to_str()).flatten(), path.extension().map(|v| v.to_str()).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|v| v.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:140:1 [INFO] [stdout] | [INFO] [stdout] 140 | / //// Realm Builder(s) [INFO] [stdout] 141 | | impl Realm { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 140 - //// Realm Builder(s) [INFO] [stdout] 141 - impl Realm { [INFO] [stdout] 140 + /// Realm Builder(s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:142:66 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn from_yaml(kdd_dir: &PathBuf, name: &str, yaml: &Yaml) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/kdd/realm.rs:142:28 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn from_yaml(kdd_dir: &PathBuf, name: &str, yaml: &Yaml) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 142 - pub fn from_yaml(kdd_dir: &PathBuf, name: &str, yaml: &Yaml) -> Result { [INFO] [stdout] 142 + pub fn from_yaml(kdd_dir: &Path, name: &str, yaml: &Yaml) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/kdd/realm.rs:150:20 [INFO] [stdout] | [INFO] [stdout] 150 | .unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/realm.rs:152:6 [INFO] [stdout] | [INFO] [stdout] 152 | if yaml_dirs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `yaml_dirs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/realm.rs:192:1 [INFO] [stdout] | [INFO] [stdout] 192 | / //// Kdd Realm Methods [INFO] [stdout] 193 | | impl Kdd { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 192 - //// Kdd Realm Methods [INFO] [stdout] 193 - impl Kdd { [INFO] [stdout] 192 + /// Kdd Realm Methods [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:200:33 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn current_realm(&self) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:210:41 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn realm_set(&self, name: &str) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/realm.rs:228:30 [INFO] [stdout] | [INFO] [stdout] 228 | ... self.k_create_context(&ctx); [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/realm.rs:229:27 [INFO] [stdout] | [INFO] [stdout] 229 | ... self.k_set_context(&ctx); [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/realm.rs:231:27 [INFO] [stdout] | [INFO] [stdout] 231 | ... self.k_set_context(&ctx); [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/realm.rs:242:32 [INFO] [stdout] | [INFO] [stdout] 242 | pub fn print_realms(&self) -> Result<(), KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/realm.rs:244:35 [INFO] [stdout] | [INFO] [stdout] 244 | let current_ctx = current_realm.map(|r| r.context.as_deref()).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|r| r.context.as_deref())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/version.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / //// [INFO] [stdout] 4 | | [INFO] [stdout] 5 | | use regex::Regex; [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 3 - //// [INFO] [stdout] 4 - [INFO] [stdout] 3 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/kdd/version.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / //// Version Struct [INFO] [stdout] 15 | | #[derive(Debug)] [INFO] [stdout] 16 | | pub struct Version { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 14 - //// Version Struct [INFO] [stdout] 15 - #[derive(Debug)] [INFO] [stdout] 14 + /// Version Struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/version.rs:39:58 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn version(&self, out: &mut impl std::io::Write) -> Result<(), AppError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/app_error.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | KddError(#[from] crate::kdd::error::KddError), [INFO] [stdout] | --------------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `app_error::AppError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/kdd/version.rs:41:6 [INFO] [stdout] | [INFO] [stdout] 41 | if self.versions.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.versions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/version.rs:75:10 [INFO] [stdout] | [INFO] [stdout] 75 | ... .map(|caps| caps.get(caps.len() - 1).map(|m| m.as_str())) [INFO] [stdout] | ________________________^ [INFO] [stdout] 76 | | ... .flatten(); [INFO] [stdout] | |________________________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|caps| caps.get(caps.len() - 1).map(|m| m.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/version.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | ... .map(|caps| caps.get(caps.len() - 1).map(|m| m.as_str())) [INFO] [stdout] | ________________________^ [INFO] [stdout] 84 | | ... .flatten(); [INFO] [stdout] | |________________________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|caps| caps.get(caps.len() - 1).map(|m| m.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/../_test/kdd_version.rs:37:27 [INFO] [stdout] | [INFO] [stdout] 37 | let val_rgx = Regex::new(&val)?; [INFO] [stdout] | ^^^^ help: change this to: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/../_test/kdd_version.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 39 | let replace_rgx = Regex::new(&replace)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `replace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/../_test/kdd_version.rs:46:4 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|caps| caps.get(caps.len() - 1).map(|m| m.as_str())) [INFO] [stdout] | __________^ [INFO] [stdout] 47 | | .flatten(); [INFO] [stdout] | |__________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|caps| caps.get(caps.len() - 1).map(|m| m.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/../_test/kdd_version.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | .captures(&content) [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/../_test/kdd_version.rs:53:40 [INFO] [stdout] | [INFO] [stdout] 53 | let content = replace_rgx.replace_all(&content, by); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/kdd/../_test/kdd_version.rs:63:4 [INFO] [stdout] | [INFO] [stdout] 63 | .map(|caps| caps.get(caps.len() - 1).map(|m| m.as_str())) [INFO] [stdout] | __________^ [INFO] [stdout] 64 | | .flatten(); [INFO] [stdout] | |__________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|caps| caps.get(caps.len() - 1).map(|m| m.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/kdd/mod.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | block_dir.join(&path[2..]) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/kdd/mod.rs:115:3 [INFO] [stdout] | [INFO] [stdout] 115 | if path.starts_with("./") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 115 ~ if let Some() = path.strip_prefix("./") { [INFO] [stdout] 116 | let block_dir = self.get_block_dir(&block); [INFO] [stdout] 117 ~ block_dir.join() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/kdd/mod.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 116 | let block_dir = self.get_block_dir(&block); [INFO] [stdout] | ^^^^^^ help: change this to: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/mod.rs:138:82 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn get_pods_by_service_names(&self, service_names: &Option>) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/mod.rs:153:82 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn get_pods_by_service_names(&self, service_names: &Option>) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> src/kdd/mod.rs:162:4 [INFO] [stdout] | [INFO] [stdout] 162 | pods = pods.into_iter().filter(|pod| names_set.contains(&pod.service_name)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling `.retain()` instead: `pods.retain(|pod| names_set.contains(&pod.service_name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/mod.rs:172:22 [INFO] [stdout] | [INFO] [stdout] 172 | fn k_list_pods() -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/kdd/mod.rs:177:4 [INFO] [stdout] | [INFO] [stdout] 177 | / match (json_pod.pointer("/metadata/name"), json_pod.pointer("/metadata/labels/run")) { [INFO] [stdout] 178 | | (Some(Value::String(pod_name)), Some(Value::String(service_name))) => { [INFO] [stdout] 179 | | pods.push(Pod { [INFO] [stdout] 180 | | name: pod_name.to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 184 | | _ => {} [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 ~ if let (Some(Value::String(pod_name)), Some(Value::String(service_name))) = (json_pod.pointer("/metadata/name"), json_pod.pointer("/metadata/labels/run")) { [INFO] [stdout] 178 ~ pods.push(Pod { [INFO] [stdout] 179 ~ name: pod_name.to_owned(), [INFO] [stdout] 180 ~ service_name: service_name.to_owned(), [INFO] [stdout] 181 ~ }); [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/kdd/mod.rs:190:44 [INFO] [stdout] | [INFO] [stdout] 190 | fn k_get_json_items(entity_type: &str) -> Result, KddError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utils/yamls.rs:48:3 [INFO] [stdout] | [INFO] [stdout] 40 | / let val = if val.contains("{{") { [INFO] [stdout] 41 | | match Template::compile(val) { [INFO] [stdout] 42 | | Ok(tmpl) => Stmpl::Tmpl(tmpl, val.to_string()), [INFO] [stdout] 43 | | Err(_) => Stmpl::Plain(val.to_owned()), [INFO] [stdout] ... | [INFO] [stdout] 46 | | Stmpl::Plain(val.to_owned()) [INFO] [stdout] 47 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 48 | val [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 40 ~ [INFO] [stdout] 41 ~ if val.contains("{{") { [INFO] [stdout] 42 ~ match Template::compile(val) { [INFO] [stdout] 43 ~ Ok(tmpl) => Stmpl::Tmpl(tmpl, val.to_string()), [INFO] [stdout] 44 ~ Err(_) => Stmpl::Plain(val.to_owned()), [INFO] [stdout] 45 ~ } [INFO] [stdout] 46 ~ } else { [INFO] [stdout] 47 ~ Stmpl::Plain(val.to_owned()) [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/yamls.rs:56:6 [INFO] [stdout] | [INFO] [stdout] 56 | if hash.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hash.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b [INFO] [stdout] --> src/utils/yamls.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn as_str<'a, 'b>(yaml: &'a Yaml, key: &'b str) -> Option<&'a str> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 85 - pub fn as_str<'a, 'b>(yaml: &'a Yaml, key: &'b str) -> Option<&'a str> { [INFO] [stdout] 85 + pub fn as_str<'a>(yaml: &'a Yaml, key: &str) -> Option<&'a str> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/utils/yamls.rs:115:22 [INFO] [stdout] | [INFO] [stdout] 115 | let strings = vals.into_iter().filter_map(|x| x.as_str().map(|x| x.to_owned())).collect(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/utils/yamls.rs:139:1 [INFO] [stdout] | [INFO] [stdout] 139 | / //// Merge in place a extra yaml to a target [INFO] [stdout] 140 | | pub fn merge_yaml(target: &mut Yaml, extra: &Yaml, overwrite: bool) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 139 - //// Merge in place a extra yaml to a target [INFO] [stdout] 140 - pub fn merge_yaml(target: &mut Yaml, extra: &Yaml, overwrite: bool) { [INFO] [stdout] 139 + /// Merge in place a extra yaml to a target [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/yamls.rs:144:7 [INFO] [stdout] | [INFO] [stdout] 144 | if !overwrite || overwrite && !target.contains_key(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 144 - if !overwrite || overwrite && !target.contains_key(key) { [INFO] [stdout] 144 + if !(overwrite && target.contains_key(key)) { [INFO] [stdout] | [INFO] [stdout] 144 - if !overwrite || overwrite && !target.contains_key(key) { [INFO] [stdout] 144 + if !overwrite || !target.contains_key(key) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils/mod.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn path_to_string(path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 34 - pub fn path_to_string(path: &PathBuf) -> Result { [INFO] [stdout] 34 + pub fn path_to_string(path: &Path) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/utils/mod.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | Ok(proc.spawn()?.wait()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 42 - Ok(proc.spawn()?.wait()?) [INFO] [stdout] 42 + proc.spawn()?.wait() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/mod.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 70 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/./_test/test_utils.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn load_kdd() -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/kdd/error.rs:87:2 [INFO] [stdout] | [INFO] [stdout] 87 | HbsTemplateError(#[from] TemplateError), [INFO] [stdout] | --------------------------------------- the largest variant contains at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `kdd::error::KddError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.54s [INFO] running `Command { std: "docker" "inspect" "28170d372a68c811f2d9186eace9f45b5af23dec4508ce7b39a60f5fa9a066c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28170d372a68c811f2d9186eace9f45b5af23dec4508ce7b39a60f5fa9a066c0", kill_on_drop: false }` [INFO] [stdout] 28170d372a68c811f2d9186eace9f45b5af23dec4508ce7b39a60f5fa9a066c0