[INFO] cloning repository https://github.com/jdpolicano/rsh
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jdpolicano/rsh" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjdpolicano%2Frsh", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjdpolicano%2Frsh'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 1f5653d49f7c0faf723410c65d5177981078796b
[INFO] linting jdpolicano/rsh against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjdpolicano%2Frsh" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/jdpolicano/rsh
[INFO] finished tweaking git repo https://github.com/jdpolicano/rsh
[INFO] tweaked toml for git repo https://github.com/jdpolicano/rsh written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/jdpolicano/rsh on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/jdpolicano/rsh already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded rustyline v13.0.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 127594ce69964a58631e141ceb88b1c656a6076a6aeed17d6bd2d9983cab744d
[INFO] running `Command { std: "docker" "start" "-a" "127594ce69964a58631e141ceb88b1c656a6076a6aeed17d6bd2d9983cab744d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "127594ce69964a58631e141ceb88b1c656a6076a6aeed17d6bd2d9983cab744d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "127594ce69964a58631e141ceb88b1c656a6076a6aeed17d6bd2d9983cab744d", kill_on_drop: false }`
[INFO] [stdout] 127594ce69964a58631e141ceb88b1c656a6076a6aeed17d6bd2d9983cab744d
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 8fcda2a7e8d01b2b1088b81bbe33b9609ab843235423c8955b53d868e21431f1
[INFO] running `Command { std: "docker" "start" "-a" "8fcda2a7e8d01b2b1088b81bbe33b9609ab843235423c8955b53d868e21431f1", kill_on_drop: false }`
[INFO] [stderr]    Compiling rustix v0.38.13
[INFO] [stderr]    Compiling libc v0.2.147
[INFO] [stderr]     Checking bitflags v2.4.2
[INFO] [stderr]     Checking smallvec v1.13.1
[INFO] [stderr]     Checking linux-raw-sys v0.4.13
[INFO] [stderr]     Checking endian-type v0.1.2
[INFO] [stderr]     Checking unicode-segmentation v1.11.0
[INFO] [stderr]     Checking log v0.4.21
[INFO] [stderr]     Checking utf8parse v0.2.1
[INFO] [stderr]     Checking nibble_vec v0.1.0
[INFO] [stderr]     Checking radix_trie v0.2.1
[INFO] [stderr]     Checking nix v0.27.1
[INFO] [stderr]     Checking fd-lock v4.0.2
[INFO] [stderr]     Checking rustyline v13.0.0
[INFO] [stderr]     Checking rsh v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/token.rs:58:13
[INFO] [stdout]    |
[INFO] [stdout] 58 |             input: input,
[INFO] [stdout]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/engine.rs:70:13
[INFO] [stdout]    |
[INFO] [stdout] 70 |             root: root,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `root`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/token.rs:58:13
[INFO] [stdout]    |
[INFO] [stdout] 58 |             input: input,
[INFO] [stdout]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/engine.rs:70:13
[INFO] [stdout]    |
[INFO] [stdout] 70 |             root: root,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `root`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/parser.rs:45:9
[INFO] [stdout]    |
[INFO] [stdout] 45 | /         match self {
[INFO] [stdout] 46 | |             RshNode::Background { .. } => true,
[INFO] [stdout] 47 | |             _ => false,
[INFO] [stdout] 48 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 45 -         match self {
[INFO] [stdout] 46 -             RshNode::Background { .. } => true,
[INFO] [stdout] 47 -             _ => false,
[INFO] [stdout] 48 -         }
[INFO] [stdout] 45 +         matches!(self, RshNode::Background { .. })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:190:7
[INFO] [stdout]     |
[INFO] [stdout] 190 |       return false;
[INFO] [stdout]     |       ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 190 -       return false;
[INFO] [stdout] 190 +       false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/shell.rs:99:9
[INFO] [stdout]    |
[INFO] [stdout] 99 |         return Ok(());
[INFO] [stdout]    |         ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -         return Ok(());
[INFO] [stdout] 99 +         Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/token.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 | /         match c {
[INFO] [stdout] 80 | |             '|' | '>' | '<' | '&' | '"' | '\'' | ' '  => true,
[INFO] [stdout] 81 | |             _ => false,
[INFO] [stdout] 82 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 79 -         match c {
[INFO] [stdout] 80 -             '|' | '>' | '<' | '&' | '"' | '\'' | ' '  => true,
[INFO] [stdout] 81 -             _ => false,
[INFO] [stdout] 82 -         }
[INFO] [stdout] 79 +         matches!(c, '|' | '>' | '<' | '&' | '"' | '\'' | ' ')
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: doc list item without indentation
[INFO] [stdout]  --> src/engine.rs:8:1
[INFO] [stdout]   |
[INFO] [stdout] 8 | keeps refs to all of the children, and other useful information.
[INFO] [stdout]   | ^
[INFO] [stdout]   |
[INFO] [stdout]   = help: if this is supposed to be its own paragraph, add a blank line
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
[INFO] [stdout]   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
[INFO] [stdout] help: indent this line
[INFO] [stdout]   |
[INFO] [stdout] 8 |   keeps refs to all of the children, and other useful information.
[INFO] [stdout]   | ++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `EngineCtx`
[INFO] [stdout]   --> src/engine.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /     pub fn new() -> EngineCtx {
[INFO] [stdout] 19 | |         EngineCtx {
[INFO] [stdout] 20 | |             command_count: 0,
[INFO] [stdout] 21 | |             should_pipe: false,
[INFO] [stdout] ...  |
[INFO] [stdout] 24 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 17 + impl Default for EngineCtx {
[INFO] [stdout] 18 +     fn default() -> Self {
[INFO] [stdout] 19 +         Self::new()
[INFO] [stdout] 20 +     }
[INFO] [stdout] 21 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/engine.rs:84:24
[INFO] [stdout]    |
[INFO] [stdout] 84 |                     if ctx.children.len() > 0 {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ctx.children.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/engine.rs:159:9
[INFO] [stdout]     |
[INFO] [stdout] 159 |         return Ok(())
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 159 -         return Ok(())
[INFO] [stdout] 159 +         Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing
[INFO] [stdout]   --> src/token.rs:33:37
[INFO] [stdout]    |
[INFO] [stdout] 33 |     pub fn new(token: &'src str) -> Token {
[INFO] [stdout]    |                        ----         ^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                        |
[INFO] [stdout]    |                        the lifetime is named here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: consistently use `'src`
[INFO] [stdout]    |
[INFO] [stdout] 33 |     pub fn new(token: &'src str) -> Token<'src> {
[INFO] [stdout]    |                                          ++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/token.rs:70:22
[INFO] [stdout]    |
[INFO] [stdout] 70 |     pub fn peek_next(&mut self) -> Option<Token> {
[INFO] [stdout]    |                      ^^^^^^^^^            ^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                      |
[INFO] [stdout]    |                      the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 70 |     pub fn peek_next(&mut self) -> Option<Token<'_>> {
[INFO] [stdout]    |                                                ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/token.rs:74:23
[INFO] [stdout]    |
[INFO] [stdout] 74 |     pub fn next_token(&mut self) -> Option<Token> {
[INFO] [stdout]    |                       ^^^^^^^^^            ^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                       |
[INFO] [stdout]    |                       the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 74 |     pub fn next_token(&mut self) -> Option<Token<'_>> {
[INFO] [stdout]    |                                                 ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/token.rs:85:25
[INFO] [stdout]    |
[INFO] [stdout] 85 |     fn parse_next_token(&mut self, advance_stream: bool) -> Option<Token> {
[INFO] [stdout]    |                         ^^^^^^^^^ the lifetime is elided here      ^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 85 |     fn parse_next_token(&mut self, advance_stream: bool) -> Option<Token<'_>> {
[INFO] [stdout]    |                                                                         ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/token.rs:101:22
[INFO] [stdout]     |
[INFO] [stdout] 101 |     fn special_token(&mut self, advance_stream: bool) -> Option<Token> {
[INFO] [stdout]     |                      ^^^^^^^^^ the lifetime is elided here      ^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 101 |     fn special_token(&mut self, advance_stream: bool) -> Option<Token<'_>> {
[INFO] [stdout]     |                                                                      ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/token.rs:116:19
[INFO] [stdout]     |
[INFO] [stdout] 116 |     fn text_token(&mut self, advance_stream: bool) -> Option<Token> {
[INFO] [stdout]     |                   ^^^^^^^^^ the lifetime is elided here      ^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 116 |     fn text_token(&mut self, advance_stream: bool) -> Option<Token<'_>> {
[INFO] [stdout]     |                                                                   ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/parser.rs:45:9
[INFO] [stdout]    |
[INFO] [stdout] 45 | /         match self {
[INFO] [stdout] 46 | |             RshNode::Background { .. } => true,
[INFO] [stdout] 47 | |             _ => false,
[INFO] [stdout] 48 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 45 -         match self {
[INFO] [stdout] 46 -             RshNode::Background { .. } => true,
[INFO] [stdout] 47 -             _ => false,
[INFO] [stdout] 48 -         }
[INFO] [stdout] 45 +         matches!(self, RshNode::Background { .. })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:190:7
[INFO] [stdout]     |
[INFO] [stdout] 190 |       return false;
[INFO] [stdout]     |       ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 190 -       return false;
[INFO] [stdout] 190 +       false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/parser.rs:266:12
[INFO] [stdout]     |
[INFO] [stdout] 266 |         if !result.is_ok() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^ help: try: `result.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this assertion is always `false`
[INFO] [stdout]    --> src/parser.rs:268:11
[INFO] [stdout]     |
[INFO] [stdout] 268 |           assert!(false);
[INFO] [stdout]     |           ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: replace this with `panic!()` or `unreachable!()`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
[INFO] [stdout]     = note: `#[warn(clippy::assertions_on_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/shell.rs:99:9
[INFO] [stdout]    |
[INFO] [stdout] 99 |         return Ok(());
[INFO] [stdout]    |         ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -         return Ok(());
[INFO] [stdout] 99 +         Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/token.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 | /         match c {
[INFO] [stdout] 80 | |             '|' | '>' | '<' | '&' | '"' | '\'' | ' '  => true,
[INFO] [stdout] 81 | |             _ => false,
[INFO] [stdout] 82 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 79 -         match c {
[INFO] [stdout] 80 -             '|' | '>' | '<' | '&' | '"' | '\'' | ' '  => true,
[INFO] [stdout] 81 -             _ => false,
[INFO] [stdout] 82 -         }
[INFO] [stdout] 79 +         matches!(c, '|' | '>' | '<' | '&' | '"' | '\'' | ' ')
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: doc list item without indentation
[INFO] [stdout]  --> src/engine.rs:8:1
[INFO] [stdout]   |
[INFO] [stdout] 8 | keeps refs to all of the children, and other useful information.
[INFO] [stdout]   | ^
[INFO] [stdout]   |
[INFO] [stdout]   = help: if this is supposed to be its own paragraph, add a blank line
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
[INFO] [stdout]   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
[INFO] [stdout] help: indent this line
[INFO] [stdout]   |
[INFO] [stdout] 8 |   keeps refs to all of the children, and other useful information.
[INFO] [stdout]   | ++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `EngineCtx`
[INFO] [stdout]   --> src/engine.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /     pub fn new() -> EngineCtx {
[INFO] [stdout] 19 | |         EngineCtx {
[INFO] [stdout] 20 | |             command_count: 0,
[INFO] [stdout] 21 | |             should_pipe: false,
[INFO] [stdout] ...  |
[INFO] [stdout] 24 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 17 + impl Default for EngineCtx {
[INFO] [stdout] 18 +     fn default() -> Self {
[INFO] [stdout] 19 +         Self::new()
[INFO] [stdout] 20 +     }
[INFO] [stdout] 21 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/engine.rs:84:24
[INFO] [stdout]    |
[INFO] [stdout] 84 |                     if ctx.children.len() > 0 {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ctx.children.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/engine.rs:159:9
[INFO] [stdout]     |
[INFO] [stdout] 159 |         return Ok(())
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 159 -         return Ok(())
[INFO] [stdout] 159 +         Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing
[INFO] [stdout]   --> src/token.rs:33:37
[INFO] [stdout]    |
[INFO] [stdout] 33 |     pub fn new(token: &'src str) -> Token {
[INFO] [stdout]    |                        ----         ^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                        |
[INFO] [stdout]    |                        the lifetime is named here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: consistently use `'src`
[INFO] [stdout]    |
[INFO] [stdout] 33 |     pub fn new(token: &'src str) -> Token<'src> {
[INFO] [stdout]    |                                          ++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/token.rs:70:22
[INFO] [stdout]    |
[INFO] [stdout] 70 |     pub fn peek_next(&mut self) -> Option<Token> {
[INFO] [stdout]    |                      ^^^^^^^^^            ^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                      |
[INFO] [stdout]    |                      the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 70 |     pub fn peek_next(&mut self) -> Option<Token<'_>> {
[INFO] [stdout]    |                                                ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/token.rs:74:23
[INFO] [stdout]    |
[INFO] [stdout] 74 |     pub fn next_token(&mut self) -> Option<Token> {
[INFO] [stdout]    |                       ^^^^^^^^^            ^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                       |
[INFO] [stdout]    |                       the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 74 |     pub fn next_token(&mut self) -> Option<Token<'_>> {
[INFO] [stdout]    |                                                 ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/token.rs:85:25
[INFO] [stdout]    |
[INFO] [stdout] 85 |     fn parse_next_token(&mut self, advance_stream: bool) -> Option<Token> {
[INFO] [stdout]    |                         ^^^^^^^^^ the lifetime is elided here      ^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 85 |     fn parse_next_token(&mut self, advance_stream: bool) -> Option<Token<'_>> {
[INFO] [stdout]    |                                                                         ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/token.rs:101:22
[INFO] [stdout]     |
[INFO] [stdout] 101 |     fn special_token(&mut self, advance_stream: bool) -> Option<Token> {
[INFO] [stdout]     |                      ^^^^^^^^^ the lifetime is elided here      ^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 101 |     fn special_token(&mut self, advance_stream: bool) -> Option<Token<'_>> {
[INFO] [stdout]     |                                                                      ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/token.rs:116:19
[INFO] [stdout]     |
[INFO] [stdout] 116 |     fn text_token(&mut self, advance_stream: bool) -> Option<Token> {
[INFO] [stdout]     |                   ^^^^^^^^^ the lifetime is elided here      ^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 116 |     fn text_token(&mut self, advance_stream: bool) -> Option<Token<'_>> {
[INFO] [stdout]     |                                                                   ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.05s
[INFO] running `Command { std: "docker" "inspect" "8fcda2a7e8d01b2b1088b81bbe33b9609ab843235423c8955b53d868e21431f1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8fcda2a7e8d01b2b1088b81bbe33b9609ab843235423c8955b53d868e21431f1", kill_on_drop: false }`
[INFO] [stdout] 8fcda2a7e8d01b2b1088b81bbe33b9609ab843235423c8955b53d868e21431f1