[INFO] cloning repository https://github.com/jcarvajal288/nes-emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jcarvajal288/nes-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjcarvajal288%2Fnes-emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjcarvajal288%2Fnes-emulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 32615f616782c63acae6569742fd85790c8dfe78 [INFO] linting jcarvajal288/nes-emulator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjcarvajal288%2Fnes-emulator" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jcarvajal288/nes-emulator [INFO] finished tweaking git repo https://github.com/jcarvajal288/nes-emulator [INFO] tweaked toml for git repo https://github.com/jcarvajal288/nes-emulator written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jcarvajal288/nes-emulator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jcarvajal288/nes-emulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hex v0.4.0 [INFO] [stderr] Downloaded regex v1.3.3 [INFO] [stderr] Downloaded regex-syntax v0.6.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d2e66d8a41e641ea6d0bf1b9f88926ca614d4919f982a1808f55abf8b51ad059 [INFO] running `Command { std: "docker" "start" "-a" "d2e66d8a41e641ea6d0bf1b9f88926ca614d4919f982a1808f55abf8b51ad059", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d2e66d8a41e641ea6d0bf1b9f88926ca614d4919f982a1808f55abf8b51ad059", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2e66d8a41e641ea6d0bf1b9f88926ca614d4919f982a1808f55abf8b51ad059", kill_on_drop: false }` [INFO] [stdout] d2e66d8a41e641ea6d0bf1b9f88926ca614d4919f982a1808f55abf8b51ad059 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3a0d62541fb295cfcd5f015178c76cc1a49d53953c7625e6699b98be6b553c6 [INFO] running `Command { std: "docker" "start" "-a" "c3a0d62541fb295cfcd5f015178c76cc1a49d53953c7625e6699b98be6b553c6", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Checking regex-syntax v0.6.13 [INFO] [stderr] Checking hex v0.4.0 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking regex v1.3.3 [INFO] [stderr] Checking nes-emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / return if addr <= 0x1FFF { [INFO] [stdout] 41 | | // cpu bus has 8k addressable range but only [INFO] [stdout] 42 | | // 2k physical ram, so mirror 2k ram 4 times [INFO] [stdout] 43 | | self.ram[usize::from(addr & 0x7FF)] [INFO] [stdout] ... | [INFO] [stdout] 57 | | 0x00 [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ if addr <= 0x1FFF { [INFO] [stdout] 41 + // cpu bus has 8k addressable range but only [INFO] [stdout] 42 + // 2k physical ram, so mirror 2k ram 4 times [INFO] [stdout] 43 + self.ram[usize::from(addr & 0x7FF)] [INFO] [stdout] 44 + } else if addr <= 0x3FFF { // ppu flags [INFO] [stdout] 45 + self.read_from_ppu(addr & 0x0007) [INFO] [stdout] 46 + } else if addr >= 0x4020 { [INFO] [stdout] 47 + // program rom (or cpu rom if no cartridge is loaded) [INFO] [stdout] 48 + match self.cartridge.as_ref() { [INFO] [stdout] 49 + Some(cart) => { [INFO] [stdout] 50 + cart.read(addr) [INFO] [stdout] 51 + } [INFO] [stdout] 52 + None => { [INFO] [stdout] 53 + self.ram[addr as usize] [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] 56 + } else { [INFO] [stdout] 57 + 0x00 [INFO] [stdout] 58 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return hex::encode_upper(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return hex::encode_upper(result); [INFO] [stdout] 78 + hex::encode_upper(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - 0x0000 => { // Control [INFO] [stdout] 84 - return; [INFO] [stdout] 83 + 0x0000 => { // Control [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - 0x0001 => { // Mask [INFO] [stdout] 87 - return; [INFO] [stdout] 86 + 0x0001 => { // Mask [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - 0x0002 => { // Status [INFO] [stdout] 90 - return; [INFO] [stdout] 89 + 0x0002 => { // Status [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - 0x0003 => { // OAM Address [INFO] [stdout] 93 - return; [INFO] [stdout] 92 + 0x0003 => { // OAM Address [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - 0x0004 => { // OAM Data [INFO] [stdout] 96 - return; [INFO] [stdout] 95 + 0x0004 => { // OAM Data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - 0x0005 => { // Scroll [INFO] [stdout] 99 - return; [INFO] [stdout] 98 + 0x0005 => { // Scroll [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - 0x0006 => { // PPU Address [INFO] [stdout] 102 - return; [INFO] [stdout] 101 + 0x0006 => { // PPU Address [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - 0x0007 => { // PPU Data [INFO] [stdout] 105 - return; [INFO] [stdout] 104 + 0x0007 => { // PPU Data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | return 0x0; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return 0x0; [INFO] [stdout] 116 + 0x0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | return 0x1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return 0x1; [INFO] [stdout] 119 + 0x1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:122:17 [INFO] [stdout] | [INFO] [stdout] 122 | return 0x2; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return 0x2; [INFO] [stdout] 122 + 0x2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 125 | return 0x3; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return 0x3; [INFO] [stdout] 125 + 0x3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | return 0x4; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return 0x4; [INFO] [stdout] 128 + 0x4 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 131 | return 0x5; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return 0x5; [INFO] [stdout] 131 + 0x5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | return 0x6; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return 0x6; [INFO] [stdout] 134 + 0x6 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | return 0x7; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return 0x7; [INFO] [stdout] 137 + 0x7 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / return Bus { [INFO] [stdout] 152 | | ram: [0x0; BUS_RAM_SIZE], [INFO] [stdout] 153 | | cartridge: None, [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 ~ Bus { [INFO] [stdout] 152 + ram: [0x0; BUS_RAM_SIZE], [INFO] [stdout] 153 + cartridge: None, [INFO] [stdout] 154 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cartridge.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return self.program_rom[mapped_addr as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return self.program_rom[mapped_addr as usize]; [INFO] [stdout] 23 + self.program_rom[mapped_addr as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cartridge.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / return Some(Box::new(Cartridge { [INFO] [stdout] 75 | | header, [INFO] [stdout] 76 | | mapper, [INFO] [stdout] 77 | | program_rom, [INFO] [stdout] 78 | | character_rom, [INFO] [stdout] 79 | | })) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ Some(Box::new(Cartridge { [INFO] [stdout] 75 + header, [INFO] [stdout] 76 + mapper, [INFO] [stdout] 77 + program_rom, [INFO] [stdout] 78 + character_rom, [INFO] [stdout] 79 + })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cartridge.rs:64:77 [INFO] [stdout] | [INFO] [stdout] 64 | program_rom = file_buffer[prg_starting_index..prg_ending_index].try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&[u8]` to `Vec` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 64 - program_rom = file_buffer[prg_starting_index..prg_ending_index].try_into().unwrap(); [INFO] [stdout] 64 + program_rom = file_buffer[prg_starting_index..prg_ending_index].into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cartridge.rs:68:77 [INFO] [stdout] | [INFO] [stdout] 68 | character_rom = file_buffer[prg_ending_index..chr_ending_index].try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&[u8]` to `Vec` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 68 - character_rom = file_buffer[prg_ending_index..chr_ending_index].try_into().unwrap(); [INFO] [stdout] 68 + character_rom = file_buffer[prg_ending_index..chr_ending_index].into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cartridge.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(file_buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Ok(file_buffer); [INFO] [stdout] 98 + Ok(file_buffer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cartridge.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / return Header { [INFO] [stdout] 103 | | name: file_buffer[0..4].try_into().unwrap(), [INFO] [stdout] 104 | | prg_rom_chunks: file_buffer[4], [INFO] [stdout] 105 | | chr_rom_chunks: file_buffer[5], [INFO] [stdout] ... | [INFO] [stdout] 111 | | unused: file_buffer[11..16].try_into().unwrap(), [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 ~ Header { [INFO] [stdout] 103 + name: file_buffer[0..4].try_into().unwrap(), [INFO] [stdout] 104 + prg_rom_chunks: file_buffer[4], [INFO] [stdout] 105 + chr_rom_chunks: file_buffer[5], [INFO] [stdout] 106 + mapper1: file_buffer[6], [INFO] [stdout] 107 + mapper2: file_buffer[7], [INFO] [stdout] 108 + prg_ram_size: file_buffer[8], [INFO] [stdout] 109 + tv_system1: file_buffer[9], [INFO] [stdout] 110 + tv_system2: file_buffer[10], [INFO] [stdout] 111 + unused: file_buffer[11..16].try_into().unwrap(), [INFO] [stdout] 112 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cartridge.rs:101:29 [INFO] [stdout] | [INFO] [stdout] 101 | fn read_header(file_buffer: &Vec) -> Header { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 101 - fn read_header(file_buffer: &Vec) -> Header { [INFO] [stdout] 101 + fn read_header(file_buffer: &[u8]) -> Header { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NROM` contains a capitalized acronym [INFO] [stdout] --> src/mapper.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct NROM { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Nrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mapper.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return if self.num_prg_banks > 1 { [INFO] [stdout] 18 | | (input_addr & 0x7FFF) as u32 [INFO] [stdout] 19 | | } else { [INFO] [stdout] 20 | | (input_addr & 0x3FFF) as u32 [INFO] [stdout] 21 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ if self.num_prg_banks > 1 { [INFO] [stdout] 18 + (input_addr & 0x7FFF) as u32 [INFO] [stdout] 19 + } else { [INFO] [stdout] 20 + (input_addr & 0x3FFF) as u32 [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mapper.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / return Box::new(NROM { [INFO] [stdout] 29 | | num_prg_banks, [INFO] [stdout] 30 | | num_chr_banks, [INFO] [stdout] 31 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Box::new(NROM { [INFO] [stdout] 29 + num_prg_banks, [INFO] [stdout] 30 + num_chr_banks, [INFO] [stdout] 31 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/logline.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / return Logline { [INFO] [stdout] 34 | | prog_ctr: splits[0], [INFO] [stdout] 35 | | stack_ptr: splits[len-1], [INFO] [stdout] 36 | | status_reg: splits[len-2], [INFO] [stdout] ... | [INFO] [stdout] 39 | | accumulator: splits[len-5], [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 ~ Logline { [INFO] [stdout] 34 + prog_ctr: splits[0], [INFO] [stdout] 35 + stack_ptr: splits[len-1], [INFO] [stdout] 36 + status_reg: splits[len-2], [INFO] [stdout] 37 + y_reg: splits[len-3], [INFO] [stdout] 38 + x_reg: splits[len-4], [INFO] [stdout] 39 + accumulator: splits[len-5], [INFO] [stdout] 40 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/logline.rs:30:28 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse_my_line(line: &String) -> Logline { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 - pub fn parse_my_line(line: &String) -> Logline { [INFO] [stdout] 30 + pub fn parse_my_line(line: &str) -> Logline { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/logline.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / return Logline { [INFO] [stdout] 53 | | prog_ctr: splits[0], [INFO] [stdout] 54 | | accumulator: A_REG.find(line).unwrap().as_str(), [INFO] [stdout] 55 | | x_reg: X_REG.find(line).unwrap().as_str(), [INFO] [stdout] ... | [INFO] [stdout] 58 | | stack_ptr: SP_REG.find(line).unwrap().as_str(), [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ Logline { [INFO] [stdout] 53 + prog_ctr: splits[0], [INFO] [stdout] 54 + accumulator: A_REG.find(line).unwrap().as_str(), [INFO] [stdout] 55 + x_reg: X_REG.find(line).unwrap().as_str(), [INFO] [stdout] 56 + y_reg: Y_REG.find(line).unwrap().as_str(), [INFO] [stdout] 57 + status_reg: P_REG.find(line).unwrap().as_str(), [INFO] [stdout] 58 + stack_ptr: SP_REG.find(line).unwrap().as_str(), [INFO] [stdout] 59 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/logline.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn parse_their_line(line: &String) -> Logline { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - pub fn parse_their_line(line: &String) -> Logline { [INFO] [stdout] 43 + pub fn parse_their_line(line: &str) -> Logline { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/nes.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if self.system_clock_counter % 3 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.system_clock_counter.is_multiple_of(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nes.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.ppu.cpu.load_program(program); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.ppu.cpu.load_program(program); [INFO] [stdout] 33 + self.ppu.cpu.load_program(program) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nes.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return self.ppu.cpu.bus.read(addr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return self.ppu.cpu.bus.read(addr); [INFO] [stdout] 41 + self.ppu.cpu.bus.read(addr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nes.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return nes; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return nes; [INFO] [stdout] 54 + nes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc2C02.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return self.cpu.bus.read(addr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return self.cpu.bus.read(addr); [INFO] [stdout] 38 + self.cpu.bus.read(addr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc2C02.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / return Olc2C02 { [INFO] [stdout] 49 | | cpu: olc6502::create_olc6502(), [INFO] [stdout] 50 | | nametables: [[0x0; NAMETABLE_SIZE]; NUM_NAMETABLES], [INFO] [stdout] 51 | | palettes: [0x0; NUM_PALLETES], [INFO] [stdout] ... | [INFO] [stdout] 54 | | frame_complete: false, [INFO] [stdout] 55 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 ~ Olc2C02 { [INFO] [stdout] 49 + cpu: olc6502::create_olc6502(), [INFO] [stdout] 50 + nametables: [[0x0; NAMETABLE_SIZE]; NUM_NAMETABLES], [INFO] [stdout] 51 + palettes: [0x0; NUM_PALLETES], [INFO] [stdout] 52 + scanline: 0, [INFO] [stdout] 53 + cycle: 0, [INFO] [stdout] 54 + frame_complete: false, [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | return self.bus.read(addr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return self.bus.read(addr); [INFO] [stdout] 121 + self.bus.read(addr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | / return if (self.status_reg & f) > 0 { [INFO] [stdout] 131 | | 1 [INFO] [stdout] 132 | | } else { [INFO] [stdout] 133 | | 0 [INFO] [stdout] 134 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 ~ if (self.status_reg & f) > 0 { [INFO] [stdout] 131 + 1 [INFO] [stdout] 132 + } else { [INFO] [stdout] 133 + 0 [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/olc6502.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 139 | if v == true { [INFO] [stdout] | ^^^^^^^^^ help: try: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/olc6502.rs:178:15 [INFO] [stdout] | [INFO] [stdout] 178 | while self.program_complete == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.program_complete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/olc6502.rs:187:15 [INFO] [stdout] | [INFO] [stdout] 187 | while self.program_complete == false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.program_complete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | return STACK_BASE | self.stack_ptr as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return STACK_BASE | self.stack_ptr as u16; [INFO] [stdout] 198 + STACK_BASE | self.stack_ptr as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/olc6502.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 205 | if b_flag == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `b_flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | return self.bus.read(current_stack_location); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - return self.bus.read(current_stack_location); [INFO] [stdout] 245 + self.bus.read(current_stack_location) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/olc6502.rs:257:17 [INFO] [stdout] | [INFO] [stdout] 257 | else if !(addrmode == imp) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(addrmode != imp)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | return self.fetched_data [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return self.fetched_data [INFO] [stdout] 260 + self.fetched_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:288:5 [INFO] [stdout] | [INFO] [stdout] 288 | return o; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 - return o; [INFO] [stdout] 288 + o [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:304:5 [INFO] [stdout] | [INFO] [stdout] 304 | / return [ [INFO] [stdout] 305 | | i("BRK", BRK, IMP, 1, 7), i("ORA", ORA, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP... [INFO] [stdout] 306 | | i("BPL", BPL, REL, 2, 2), i("ORA", ORA, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP... [INFO] [stdout] 307 | | i("JSR", JSR, ABS, 3, 6), i("AND", AND, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("BIT", BIT, ZP0... [INFO] [stdout] ... | [INFO] [stdout] 320 | | i("BEQ", BEQ, REL, 2, 2), i("SBC", SBC, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP... [INFO] [stdout] 321 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 304 ~ [ [INFO] [stdout] 305 + i("BRK", BRK, IMP, 1, 7), i("ORA", ORA, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ORA", ORA, ZP0, 2, 3), i("ASL", ASL, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("PHP", PHP, IMP, 1, 3), i("ORA", ORA, IMM, 2, 2), i("ASL", ASL, ACC, 1, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ORA", ORA, ABS, 3, 4), i("ASL", ASL, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 306 + i("BPL", BPL, REL, 2, 2), i("ORA", ORA, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ORA", ORA, ZPX, 2, 4), i("ASL", ASL, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("CLC", CLC, IMP, 1, 2), i("ORA", ORA, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ORA", ORA, ABX, 3, 4), i("ASL", ASL, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 307 + i("JSR", JSR, ABS, 3, 6), i("AND", AND, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("BIT", BIT, ZP0, 2, 3), i("AND", AND, ZP0, 2, 3), i("ROL", ROL, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("PLP", PLP, IMP, 1, 4), i("AND", AND, IMM, 2, 2), i("ROL", ROL, ACC, 1, 2), i("???", XXX, IMP, 0, 2), i("BIT", BIT, ABS, 3, 4), i("AND", AND, ABS, 3, 4), i("ROL", ROL, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 308 + i("BMI", BMI, REL, 2, 2), i("AND", AND, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("AND", AND, ZPX, 2, 4), i("ROL", ROL, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("SEC", SEC, IMP, 1, 2), i("AND", AND, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("AND", AND, ABX, 3, 4), i("ROL", ROL, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 309 + i("RTI", RTI, IMP, 1, 6), i("EOR", EOR, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("EOR", EOR, ZP0, 2, 3), i("LSR", LSR, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("PHA", PHA, IMP, 1, 3), i("EOR", EOR, IMM, 2, 2), i("LSR", LSR, ACC, 1, 2), i("???", XXX, IMP, 0, 2), i("JMP", JMP, ABS, 3, 3), i("EOR", EOR, ABS, 3, 4), i("LSR", LSR, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 310 + i("BVC", BVC, REL, 2, 2), i("EOR", EOR, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("EOR", EOR, ZPX, 2, 4), i("LSR", LSR, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("CLI", CLI, IMP, 1, 2), i("EOR", EOR, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("EOR", EOR, ABX, 3, 4), i("LSR", LSR, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 311 + i("RTS", RTS, IMP, 1, 6), i("ADC", ADC, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ADC", ADC, ZP0, 2, 3), i("ROR", ROR, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("PLA", PLA, IMP, 1, 4), i("ADC", ADC, IMM, 2, 2), i("ROR", ROR, ACC, 1, 2), i("???", XXX, IMP, 0, 2), i("JMP", JMP, IND, 3, 5), i("ADC", ADC, ABS, 3, 4), i("ROR", ROR, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 312 + i("BVS", BVS, REL, 2, 2), i("ADC", ADC, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ADC", ADC, ZPX, 2, 4), i("ROR", ROR, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("SEI", SEI, IMP, 1, 2), i("ADC", ADC, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ADC", ADC, ABX, 3, 4), i("ROR", ROR, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 313 + i("???", XXX, IMP, 0, 2), i("STA", STA, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("STY", STY, ZP0, 2, 3), i("STA", STA, ZP0, 2, 3), i("STX", STX, ZP0, 2, 3), i("???", XXX, IMP, 0, 2), i("DEY", DEY, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("TXA", TXA, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("STY", STY, ABS, 3, 4), i("STA", STA, ABS, 3, 4), i("STX", STX, ABS, 3, 4), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 314 + i("BCC", BCC, REL, 2, 2), i("STA", STA, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("STY", STY, ZPX, 2, 4), i("STA", STA, ZPX, 2, 4), i("STX", STX, ZPY, 2, 4), i("???", XXX, IMP, 0, 2), i("TYA", TYA, IMP, 1, 2), i("STA", STA, ABY, 3, 5), i("TXS", TXS, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("STA", STA, ABX, 3, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 315 + i("LDY", LDY, IMM, 2, 2), i("LDA", LDA, IZX, 2, 6), i("LDX", LDX, IMM, 2, 2), i("???", XXX, IMP, 0, 2), i("LDY", LDY, ZP0, 2, 3), i("LDA", LDA, ZP0, 2, 3), i("LDX", LDX, ZP0, 2, 3), i("???", XXX, IMP, 0, 2), i("TAY", TAY, IMP, 1, 2), i("LDA", LDA, IMM, 2, 2), i("TAX", TAX, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("LDY", LDY, ABS, 3, 4), i("LDA", LDA, ABS, 3, 4), i("LDX", LDX, ABS, 3, 4), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 316 + i("BCS", BCS, REL, 2, 2), i("LDA", LDA, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("LDY", LDY, ZPX, 2, 4), i("LDA", LDA, ZPX, 2, 4), i("LDX", LDX, ZPY, 2, 4), i("???", XXX, IMP, 0, 2), i("CLV", CLV, IMP, 1, 2), i("LDA", LDA, ABY, 3, 4), i("TSX", TSX, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("LDY", LDY, ABX, 3, 4), i("LDA", LDA, ABX, 3, 4), i("LDX", LDX, ABY, 3, 4), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 317 + i("CPY", CPY, IMM, 2, 2), i("CMP", CMP, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("CPY", CPY, ZP0, 2, 3), i("CMP", CMP, ZP0, 2, 3), i("DEC", DEC, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("INY", INY, IMP, 1, 2), i("CMP", CMP, IMM, 2, 2), i("DEX", DEX, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("CPY", CPY, ABS, 3, 4), i("CMP", CMP, ABS, 3, 4), i("DEC", DEC, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 318 + i("BNE", BNE, REL, 2, 2), i("CMP", CMP, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("CMP", CMP, ZPX, 2, 4), i("DEC", DEC, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("CLD", CLD, IMP, 1, 2), i("CMP", CMP, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("CMP", CMP, ABX, 3, 4), i("DEC", DEC, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 319 + i("CPX", CPX, IMM, 2, 2), i("SBC", SBC, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("CPX", CPX, ZP0, 2, 3), i("SBC", SBC, ZP0, 2, 3), i("INC", INC, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("INX", INX, IMP, 1, 2), i("SBC", SBC, IMM, 2, 2), i("NOP", NOP, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("CPX", CPX, ABS, 3, 4), i("SBC", SBC, ABS, 3, 4), i("INC", INC, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 320 + i("BEQ", BEQ, REL, 2, 2), i("SBC", SBC, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("SBC", SBC, ZPX, 2, 4), i("INC", INC, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("SED", SED, IMP, 1, 2), i("SBC", SBC, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("SBC", SBC, ABX, 3, 4), i("INC", INC, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 321 ~ ] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | return Instruction { name: String::from(name), operate, addrmode, num_bytes, cycles }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return Instruction { name: String::from(name), operate, addrmode, num_bytes, cycles }; [INFO] [stdout] 301 + Instruction { name: String::from(name), operate, addrmode, num_bytes, cycles } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return 0; [INFO] [stdout] 331 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:338:5 [INFO] [stdout] | [INFO] [stdout] 338 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 338 - return 0; [INFO] [stdout] 338 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:350:5 [INFO] [stdout] | [INFO] [stdout] 350 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return 0; [INFO] [stdout] 350 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:358:5 [INFO] [stdout] | [INFO] [stdout] 358 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 358 - return 0; [INFO] [stdout] 358 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:367:5 [INFO] [stdout] | [INFO] [stdout] 367 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 367 - return 0; [INFO] [stdout] 367 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:376:5 [INFO] [stdout] | [INFO] [stdout] 376 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 376 - return 0; [INFO] [stdout] 376 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 390 | / return if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 391 | | 1 [INFO] [stdout] 392 | | } else { [INFO] [stdout] 393 | | 0 [INFO] [stdout] 394 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 ~ if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 391 + 1 [INFO] [stdout] 392 + } else { [INFO] [stdout] 393 + 0 [INFO] [stdout] 394 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:408:5 [INFO] [stdout] | [INFO] [stdout] 408 | / return if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 409 | | 1 [INFO] [stdout] 410 | | } else { [INFO] [stdout] 411 | | 0 [INFO] [stdout] 412 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 408 ~ if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 409 + 1 [INFO] [stdout] 410 + } else { [INFO] [stdout] 411 + 0 [INFO] [stdout] 412 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:418:5 [INFO] [stdout] | [INFO] [stdout] 418 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 418 - return 0; [INFO] [stdout] 418 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:429:5 [INFO] [stdout] | [INFO] [stdout] 429 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - return 0; [INFO] [stdout] 429 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:444:5 [INFO] [stdout] | [INFO] [stdout] 444 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 444 - return 0; [INFO] [stdout] 444 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u16` [INFO] [stdout] --> src/olc6502.rs:438:24 [INFO] [stdout] | [INFO] [stdout] 438 | let lo_addr: u16 = u16::from((t + x) & 0x00FF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `u16::from()`: `((t + x) & 0x00FF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u16` [INFO] [stdout] --> src/olc6502.rs:439:24 [INFO] [stdout] | [INFO] [stdout] 439 | let hi_addr: u16 = u16::from((t + x + 1) & 0x00FF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `u16::from()`: `((t + x + 1) & 0x00FF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | / return if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 459 | | 1 [INFO] [stdout] 460 | | } else { [INFO] [stdout] 461 | | 0 [INFO] [stdout] 462 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 458 ~ if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 459 + 1 [INFO] [stdout] 460 + } else { [INFO] [stdout] 461 + 0 [INFO] [stdout] 462 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 480 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 480 - return 0; [INFO] [stdout] 480 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/olc6502.rs:475:80 [INFO] [stdout] | [INFO] [stdout] 475 | o.addr_abs = (u16::from(o.read(ptr & 0xFF00)) << 8) | u16::from(o.read(ptr + 0)); [INFO] [stdout] | ^^^^^^^ help: consider reducing it to: `ptr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/olc6502.rs:477:75 [INFO] [stdout] | [INFO] [stdout] 477 | o.addr_abs = (u16::from(o.read(ptr + 1)) << 8) | u16::from(o.read(ptr + 0)); [INFO] [stdout] | ^^^^^^^ help: consider reducing it to: `ptr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:490:5 [INFO] [stdout] | [INFO] [stdout] 490 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 490 - return 1; [INFO] [stdout] 490 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/olc6502.rs:501:30 [INFO] [stdout] | [INFO] [stdout] 501 | o.set_flag(Flags6502::V, !((a ^ data16) & 0x80 > 0) && ((a ^ sum) & 0x80) > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((a ^ data16) & 0x80 <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:511:5 [INFO] [stdout] | [INFO] [stdout] 511 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 511 - return 1; [INFO] [stdout] 511 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:527:5 [INFO] [stdout] | [INFO] [stdout] 527 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 527 - return 0; [INFO] [stdout] 527 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:543:5 [INFO] [stdout] | [INFO] [stdout] 543 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 543 - return 0; [INFO] [stdout] 543 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:551:5 [INFO] [stdout] | [INFO] [stdout] 551 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 551 - return 0; [INFO] [stdout] 551 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:559:5 [INFO] [stdout] | [INFO] [stdout] 559 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 559 - return 0; [INFO] [stdout] 559 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:569:5 [INFO] [stdout] | [INFO] [stdout] 569 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 569 - return 0; [INFO] [stdout] 569 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:577:5 [INFO] [stdout] | [INFO] [stdout] 577 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 577 - return 0; [INFO] [stdout] 577 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:585:5 [INFO] [stdout] | [INFO] [stdout] 585 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 585 - return 0; [INFO] [stdout] 585 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:593:5 [INFO] [stdout] | [INFO] [stdout] 593 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 593 - return 0; [INFO] [stdout] 593 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:601:5 [INFO] [stdout] | [INFO] [stdout] 601 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 601 - return 0; [INFO] [stdout] 601 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:609:5 [INFO] [stdout] | [INFO] [stdout] 609 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 609 - return 0; [INFO] [stdout] 609 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:617:5 [INFO] [stdout] | [INFO] [stdout] 617 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 617 - return 0; [INFO] [stdout] 617 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:623:5 [INFO] [stdout] | [INFO] [stdout] 623 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 623 - return 0; [INFO] [stdout] 623 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:629:5 [INFO] [stdout] | [INFO] [stdout] 629 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 629 - return 0; [INFO] [stdout] 629 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:635:5 [INFO] [stdout] | [INFO] [stdout] 635 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 635 - return 0; [INFO] [stdout] 635 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:641:5 [INFO] [stdout] | [INFO] [stdout] 641 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 641 - return 0; [INFO] [stdout] 641 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:651:5 [INFO] [stdout] | [INFO] [stdout] 651 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 651 - return 1; [INFO] [stdout] 651 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:661:5 [INFO] [stdout] | [INFO] [stdout] 661 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 661 - return 1; [INFO] [stdout] 661 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:671:5 [INFO] [stdout] | [INFO] [stdout] 671 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 671 - return 1; [INFO] [stdout] 671 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:681:5 [INFO] [stdout] | [INFO] [stdout] 681 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 681 - return 0; [INFO] [stdout] 681 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:689:5 [INFO] [stdout] | [INFO] [stdout] 689 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 689 - return 0; [INFO] [stdout] 689 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:697:5 [INFO] [stdout] | [INFO] [stdout] 697 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 697 - return 0; [INFO] [stdout] 697 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:706:5 [INFO] [stdout] | [INFO] [stdout] 706 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 706 - return 1; [INFO] [stdout] 706 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:716:5 [INFO] [stdout] | [INFO] [stdout] 716 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 716 - return 0; [INFO] [stdout] 716 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:724:5 [INFO] [stdout] | [INFO] [stdout] 724 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 724 - return 0; [INFO] [stdout] 724 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:732:5 [INFO] [stdout] | [INFO] [stdout] 732 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 732 - return 0; [INFO] [stdout] 732 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:738:5 [INFO] [stdout] | [INFO] [stdout] 738 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 738 - return 0; [INFO] [stdout] 738 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:749:5 [INFO] [stdout] | [INFO] [stdout] 749 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 749 - return 0; [INFO] [stdout] 749 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:757:5 [INFO] [stdout] | [INFO] [stdout] 757 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 757 - return 1; [INFO] [stdout] 757 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:765:5 [INFO] [stdout] | [INFO] [stdout] 765 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 765 - return 1; [INFO] [stdout] 765 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:773:5 [INFO] [stdout] | [INFO] [stdout] 773 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 773 - return 1; [INFO] [stdout] 773 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:789:5 [INFO] [stdout] | [INFO] [stdout] 789 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 789 - return 0; [INFO] [stdout] 789 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:794:5 [INFO] [stdout] | [INFO] [stdout] 794 | return 0x0; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 794 - return 0x0; [INFO] [stdout] 794 + 0x0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:803:5 [INFO] [stdout] | [INFO] [stdout] 803 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 803 - return 1; [INFO] [stdout] 803 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:809:5 [INFO] [stdout] | [INFO] [stdout] 809 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 809 - return 0; [INFO] [stdout] 809 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:816:5 [INFO] [stdout] | [INFO] [stdout] 816 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 816 - return 0; [INFO] [stdout] 816 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:824:5 [INFO] [stdout] | [INFO] [stdout] 824 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 824 - return 0; [INFO] [stdout] 824 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:837:5 [INFO] [stdout] | [INFO] [stdout] 837 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 837 - return 0; [INFO] [stdout] 837 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:853:5 [INFO] [stdout] | [INFO] [stdout] 853 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 853 - return 0; [INFO] [stdout] 853 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:869:5 [INFO] [stdout] | [INFO] [stdout] 869 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 869 - return 0; [INFO] [stdout] 869 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:885:5 [INFO] [stdout] | [INFO] [stdout] 885 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 885 - return 0; [INFO] [stdout] 885 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:893:5 [INFO] [stdout] | [INFO] [stdout] 893 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 893 - return 0; [INFO] [stdout] 893 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:901:5 [INFO] [stdout] | [INFO] [stdout] 901 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 901 - return 1; [INFO] [stdout] 901 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:907:5 [INFO] [stdout] | [INFO] [stdout] 907 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 907 - return 0; [INFO] [stdout] 907 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:913:5 [INFO] [stdout] | [INFO] [stdout] 913 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 913 - return 0; [INFO] [stdout] 913 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:919:5 [INFO] [stdout] | [INFO] [stdout] 919 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 919 - return 0; [INFO] [stdout] 919 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:925:5 [INFO] [stdout] | [INFO] [stdout] 925 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 925 - return 0; [INFO] [stdout] 925 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:931:5 [INFO] [stdout] | [INFO] [stdout] 931 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 931 - return 0; [INFO] [stdout] 931 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:937:5 [INFO] [stdout] | [INFO] [stdout] 937 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 937 - return 0; [INFO] [stdout] 937 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:945:5 [INFO] [stdout] | [INFO] [stdout] 945 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 945 - return 0; [INFO] [stdout] 945 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:953:5 [INFO] [stdout] | [INFO] [stdout] 953 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 953 - return 0; [INFO] [stdout] 953 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:961:5 [INFO] [stdout] | [INFO] [stdout] 961 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 961 - return 0; [INFO] [stdout] 961 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:969:5 [INFO] [stdout] | [INFO] [stdout] 969 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 969 - return 0; [INFO] [stdout] 969 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:975:5 [INFO] [stdout] | [INFO] [stdout] 975 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 975 - return 0; [INFO] [stdout] 975 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:983:5 [INFO] [stdout] | [INFO] [stdout] 983 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 983 - return 0; [INFO] [stdout] 983 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:988:5 [INFO] [stdout] | [INFO] [stdout] 988 | return 0x0; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 988 - return 0x0; [INFO] [stdout] 988 + 0x0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/logline.rs:30:28 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse_my_line(line: &String) -> Logline { [INFO] [stdout] | ^^^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse_my_line(line: &String) -> Logline<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/logline.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn parse_their_line(line: &String) -> Logline { [INFO] [stdout] | ^^^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 43 | pub fn parse_their_line(line: &String) -> Logline<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:252:30 [INFO] [stdout] | [INFO] [stdout] 252 | let imp: usize = IMP as usize; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(function_casts_as_integer)]` on by default [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 252 | let imp: usize = IMP as *const () as usize; [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:253:30 [INFO] [stdout] | [INFO] [stdout] 253 | let acc: usize = ACC as usize; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 253 | let acc: usize = ACC as *const () as usize; [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:522:61 [INFO] [stdout] | [INFO] [stdout] 522 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 522 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as *const () as usize { [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:784:61 [INFO] [stdout] | [INFO] [stdout] 784 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 784 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as *const () as usize { [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:848:61 [INFO] [stdout] | [INFO] [stdout] 848 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 848 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as *const () as usize { [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:864:61 [INFO] [stdout] | [INFO] [stdout] 864 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 864 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as *const () as usize { [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / return if addr <= 0x1FFF { [INFO] [stdout] 41 | | // cpu bus has 8k addressable range but only [INFO] [stdout] 42 | | // 2k physical ram, so mirror 2k ram 4 times [INFO] [stdout] 43 | | self.ram[usize::from(addr & 0x7FF)] [INFO] [stdout] ... | [INFO] [stdout] 57 | | 0x00 [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ if addr <= 0x1FFF { [INFO] [stdout] 41 + // cpu bus has 8k addressable range but only [INFO] [stdout] 42 + // 2k physical ram, so mirror 2k ram 4 times [INFO] [stdout] 43 + self.ram[usize::from(addr & 0x7FF)] [INFO] [stdout] 44 + } else if addr <= 0x3FFF { // ppu flags [INFO] [stdout] 45 + self.read_from_ppu(addr & 0x0007) [INFO] [stdout] 46 + } else if addr >= 0x4020 { [INFO] [stdout] 47 + // program rom (or cpu rom if no cartridge is loaded) [INFO] [stdout] 48 + match self.cartridge.as_ref() { [INFO] [stdout] 49 + Some(cart) => { [INFO] [stdout] 50 + cart.read(addr) [INFO] [stdout] 51 + } [INFO] [stdout] 52 + None => { [INFO] [stdout] 53 + self.ram[addr as usize] [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] 56 + } else { [INFO] [stdout] 57 + 0x00 [INFO] [stdout] 58 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return hex::encode_upper(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return hex::encode_upper(result); [INFO] [stdout] 78 + hex::encode_upper(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - 0x0000 => { // Control [INFO] [stdout] 84 - return; [INFO] [stdout] 83 + 0x0000 => { // Control [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - 0x0001 => { // Mask [INFO] [stdout] 87 - return; [INFO] [stdout] 86 + 0x0001 => { // Mask [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - 0x0002 => { // Status [INFO] [stdout] 90 - return; [INFO] [stdout] 89 + 0x0002 => { // Status [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - 0x0003 => { // OAM Address [INFO] [stdout] 93 - return; [INFO] [stdout] 92 + 0x0003 => { // OAM Address [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - 0x0004 => { // OAM Data [INFO] [stdout] 96 - return; [INFO] [stdout] 95 + 0x0004 => { // OAM Data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - 0x0005 => { // Scroll [INFO] [stdout] 99 - return; [INFO] [stdout] 98 + 0x0005 => { // Scroll [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - 0x0006 => { // PPU Address [INFO] [stdout] 102 - return; [INFO] [stdout] 101 + 0x0006 => { // PPU Address [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - 0x0007 => { // PPU Data [INFO] [stdout] 105 - return; [INFO] [stdout] 104 + 0x0007 => { // PPU Data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | return 0x0; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return 0x0; [INFO] [stdout] 116 + 0x0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | return 0x1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return 0x1; [INFO] [stdout] 119 + 0x1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:122:17 [INFO] [stdout] | [INFO] [stdout] 122 | return 0x2; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return 0x2; [INFO] [stdout] 122 + 0x2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 125 | return 0x3; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return 0x3; [INFO] [stdout] 125 + 0x3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | return 0x4; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return 0x4; [INFO] [stdout] 128 + 0x4 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 131 | return 0x5; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return 0x5; [INFO] [stdout] 131 + 0x5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | return 0x6; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return 0x6; [INFO] [stdout] 134 + 0x6 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | return 0x7; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return 0x7; [INFO] [stdout] 137 + 0x7 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / return Bus { [INFO] [stdout] 152 | | ram: [0x0; BUS_RAM_SIZE], [INFO] [stdout] 153 | | cartridge: None, [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 ~ Bus { [INFO] [stdout] 152 + ram: [0x0; BUS_RAM_SIZE], [INFO] [stdout] 153 + cartridge: None, [INFO] [stdout] 154 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cartridge.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return self.program_rom[mapped_addr as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return self.program_rom[mapped_addr as usize]; [INFO] [stdout] 23 + self.program_rom[mapped_addr as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cartridge.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / return Some(Box::new(Cartridge { [INFO] [stdout] 75 | | header, [INFO] [stdout] 76 | | mapper, [INFO] [stdout] 77 | | program_rom, [INFO] [stdout] 78 | | character_rom, [INFO] [stdout] 79 | | })) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ Some(Box::new(Cartridge { [INFO] [stdout] 75 + header, [INFO] [stdout] 76 + mapper, [INFO] [stdout] 77 + program_rom, [INFO] [stdout] 78 + character_rom, [INFO] [stdout] 79 + })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cartridge.rs:64:77 [INFO] [stdout] | [INFO] [stdout] 64 | program_rom = file_buffer[prg_starting_index..prg_ending_index].try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&[u8]` to `Vec` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 64 - program_rom = file_buffer[prg_starting_index..prg_ending_index].try_into().unwrap(); [INFO] [stdout] 64 + program_rom = file_buffer[prg_starting_index..prg_ending_index].into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cartridge.rs:68:77 [INFO] [stdout] | [INFO] [stdout] 68 | character_rom = file_buffer[prg_ending_index..chr_ending_index].try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&[u8]` to `Vec` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 68 - character_rom = file_buffer[prg_ending_index..chr_ending_index].try_into().unwrap(); [INFO] [stdout] 68 + character_rom = file_buffer[prg_ending_index..chr_ending_index].into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cartridge.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(file_buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Ok(file_buffer); [INFO] [stdout] 98 + Ok(file_buffer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cartridge.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / return Header { [INFO] [stdout] 103 | | name: file_buffer[0..4].try_into().unwrap(), [INFO] [stdout] 104 | | prg_rom_chunks: file_buffer[4], [INFO] [stdout] 105 | | chr_rom_chunks: file_buffer[5], [INFO] [stdout] ... | [INFO] [stdout] 111 | | unused: file_buffer[11..16].try_into().unwrap(), [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 ~ Header { [INFO] [stdout] 103 + name: file_buffer[0..4].try_into().unwrap(), [INFO] [stdout] 104 + prg_rom_chunks: file_buffer[4], [INFO] [stdout] 105 + chr_rom_chunks: file_buffer[5], [INFO] [stdout] 106 + mapper1: file_buffer[6], [INFO] [stdout] 107 + mapper2: file_buffer[7], [INFO] [stdout] 108 + prg_ram_size: file_buffer[8], [INFO] [stdout] 109 + tv_system1: file_buffer[9], [INFO] [stdout] 110 + tv_system2: file_buffer[10], [INFO] [stdout] 111 + unused: file_buffer[11..16].try_into().unwrap(), [INFO] [stdout] 112 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cartridge.rs:101:29 [INFO] [stdout] | [INFO] [stdout] 101 | fn read_header(file_buffer: &Vec) -> Header { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 101 - fn read_header(file_buffer: &Vec) -> Header { [INFO] [stdout] 101 + fn read_header(file_buffer: &[u8]) -> Header { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NROM` contains a capitalized acronym [INFO] [stdout] --> src/mapper.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct NROM { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Nrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mapper.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return if self.num_prg_banks > 1 { [INFO] [stdout] 18 | | (input_addr & 0x7FFF) as u32 [INFO] [stdout] 19 | | } else { [INFO] [stdout] 20 | | (input_addr & 0x3FFF) as u32 [INFO] [stdout] 21 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ if self.num_prg_banks > 1 { [INFO] [stdout] 18 + (input_addr & 0x7FFF) as u32 [INFO] [stdout] 19 + } else { [INFO] [stdout] 20 + (input_addr & 0x3FFF) as u32 [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mapper.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / return Box::new(NROM { [INFO] [stdout] 29 | | num_prg_banks, [INFO] [stdout] 30 | | num_chr_banks, [INFO] [stdout] 31 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Box::new(NROM { [INFO] [stdout] 29 + num_prg_banks, [INFO] [stdout] 30 + num_chr_banks, [INFO] [stdout] 31 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/logline.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / return Logline { [INFO] [stdout] 34 | | prog_ctr: splits[0], [INFO] [stdout] 35 | | stack_ptr: splits[len-1], [INFO] [stdout] 36 | | status_reg: splits[len-2], [INFO] [stdout] ... | [INFO] [stdout] 39 | | accumulator: splits[len-5], [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 ~ Logline { [INFO] [stdout] 34 + prog_ctr: splits[0], [INFO] [stdout] 35 + stack_ptr: splits[len-1], [INFO] [stdout] 36 + status_reg: splits[len-2], [INFO] [stdout] 37 + y_reg: splits[len-3], [INFO] [stdout] 38 + x_reg: splits[len-4], [INFO] [stdout] 39 + accumulator: splits[len-5], [INFO] [stdout] 40 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/logline.rs:30:28 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse_my_line(line: &String) -> Logline { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 - pub fn parse_my_line(line: &String) -> Logline { [INFO] [stdout] 30 + pub fn parse_my_line(line: &str) -> Logline { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/logline.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / return Logline { [INFO] [stdout] 53 | | prog_ctr: splits[0], [INFO] [stdout] 54 | | accumulator: A_REG.find(line).unwrap().as_str(), [INFO] [stdout] 55 | | x_reg: X_REG.find(line).unwrap().as_str(), [INFO] [stdout] ... | [INFO] [stdout] 58 | | stack_ptr: SP_REG.find(line).unwrap().as_str(), [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ Logline { [INFO] [stdout] 53 + prog_ctr: splits[0], [INFO] [stdout] 54 + accumulator: A_REG.find(line).unwrap().as_str(), [INFO] [stdout] 55 + x_reg: X_REG.find(line).unwrap().as_str(), [INFO] [stdout] 56 + y_reg: Y_REG.find(line).unwrap().as_str(), [INFO] [stdout] 57 + status_reg: P_REG.find(line).unwrap().as_str(), [INFO] [stdout] 58 + stack_ptr: SP_REG.find(line).unwrap().as_str(), [INFO] [stdout] 59 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/logline.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn parse_their_line(line: &String) -> Logline { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - pub fn parse_their_line(line: &String) -> Logline { [INFO] [stdout] 43 + pub fn parse_their_line(line: &str) -> Logline { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/nes.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if self.system_clock_counter % 3 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.system_clock_counter.is_multiple_of(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nes.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.ppu.cpu.load_program(program); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.ppu.cpu.load_program(program); [INFO] [stdout] 33 + self.ppu.cpu.load_program(program) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nes.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return self.ppu.cpu.bus.read(addr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return self.ppu.cpu.bus.read(addr); [INFO] [stdout] 41 + self.ppu.cpu.bus.read(addr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nes.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return nes; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return nes; [INFO] [stdout] 54 + nes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc2C02.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return self.cpu.bus.read(addr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return self.cpu.bus.read(addr); [INFO] [stdout] 38 + self.cpu.bus.read(addr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc2C02.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / return Olc2C02 { [INFO] [stdout] 49 | | cpu: olc6502::create_olc6502(), [INFO] [stdout] 50 | | nametables: [[0x0; NAMETABLE_SIZE]; NUM_NAMETABLES], [INFO] [stdout] 51 | | palettes: [0x0; NUM_PALLETES], [INFO] [stdout] ... | [INFO] [stdout] 54 | | frame_complete: false, [INFO] [stdout] 55 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 ~ Olc2C02 { [INFO] [stdout] 49 + cpu: olc6502::create_olc6502(), [INFO] [stdout] 50 + nametables: [[0x0; NAMETABLE_SIZE]; NUM_NAMETABLES], [INFO] [stdout] 51 + palettes: [0x0; NUM_PALLETES], [INFO] [stdout] 52 + scanline: 0, [INFO] [stdout] 53 + cycle: 0, [INFO] [stdout] 54 + frame_complete: false, [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | return self.bus.read(addr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return self.bus.read(addr); [INFO] [stdout] 121 + self.bus.read(addr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | / return if (self.status_reg & f) > 0 { [INFO] [stdout] 131 | | 1 [INFO] [stdout] 132 | | } else { [INFO] [stdout] 133 | | 0 [INFO] [stdout] 134 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 ~ if (self.status_reg & f) > 0 { [INFO] [stdout] 131 + 1 [INFO] [stdout] 132 + } else { [INFO] [stdout] 133 + 0 [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/olc6502.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 139 | if v == true { [INFO] [stdout] | ^^^^^^^^^ help: try: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/olc6502.rs:178:15 [INFO] [stdout] | [INFO] [stdout] 178 | while self.program_complete == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.program_complete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/olc6502.rs:187:15 [INFO] [stdout] | [INFO] [stdout] 187 | while self.program_complete == false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.program_complete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | return STACK_BASE | self.stack_ptr as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return STACK_BASE | self.stack_ptr as u16; [INFO] [stdout] 198 + STACK_BASE | self.stack_ptr as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/olc6502.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 205 | if b_flag == true { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `b_flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | return self.bus.read(current_stack_location); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - return self.bus.read(current_stack_location); [INFO] [stdout] 245 + self.bus.read(current_stack_location) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/olc6502.rs:257:17 [INFO] [stdout] | [INFO] [stdout] 257 | else if !(addrmode == imp) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(addrmode != imp)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | return self.fetched_data [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return self.fetched_data [INFO] [stdout] 260 + self.fetched_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:288:5 [INFO] [stdout] | [INFO] [stdout] 288 | return o; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 - return o; [INFO] [stdout] 288 + o [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:304:5 [INFO] [stdout] | [INFO] [stdout] 304 | / return [ [INFO] [stdout] 305 | | i("BRK", BRK, IMP, 1, 7), i("ORA", ORA, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP... [INFO] [stdout] 306 | | i("BPL", BPL, REL, 2, 2), i("ORA", ORA, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP... [INFO] [stdout] 307 | | i("JSR", JSR, ABS, 3, 6), i("AND", AND, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("BIT", BIT, ZP0... [INFO] [stdout] ... | [INFO] [stdout] 320 | | i("BEQ", BEQ, REL, 2, 2), i("SBC", SBC, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP... [INFO] [stdout] 321 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 304 ~ [ [INFO] [stdout] 305 + i("BRK", BRK, IMP, 1, 7), i("ORA", ORA, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ORA", ORA, ZP0, 2, 3), i("ASL", ASL, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("PHP", PHP, IMP, 1, 3), i("ORA", ORA, IMM, 2, 2), i("ASL", ASL, ACC, 1, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ORA", ORA, ABS, 3, 4), i("ASL", ASL, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 306 + i("BPL", BPL, REL, 2, 2), i("ORA", ORA, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ORA", ORA, ZPX, 2, 4), i("ASL", ASL, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("CLC", CLC, IMP, 1, 2), i("ORA", ORA, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ORA", ORA, ABX, 3, 4), i("ASL", ASL, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 307 + i("JSR", JSR, ABS, 3, 6), i("AND", AND, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("BIT", BIT, ZP0, 2, 3), i("AND", AND, ZP0, 2, 3), i("ROL", ROL, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("PLP", PLP, IMP, 1, 4), i("AND", AND, IMM, 2, 2), i("ROL", ROL, ACC, 1, 2), i("???", XXX, IMP, 0, 2), i("BIT", BIT, ABS, 3, 4), i("AND", AND, ABS, 3, 4), i("ROL", ROL, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 308 + i("BMI", BMI, REL, 2, 2), i("AND", AND, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("AND", AND, ZPX, 2, 4), i("ROL", ROL, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("SEC", SEC, IMP, 1, 2), i("AND", AND, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("AND", AND, ABX, 3, 4), i("ROL", ROL, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 309 + i("RTI", RTI, IMP, 1, 6), i("EOR", EOR, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("EOR", EOR, ZP0, 2, 3), i("LSR", LSR, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("PHA", PHA, IMP, 1, 3), i("EOR", EOR, IMM, 2, 2), i("LSR", LSR, ACC, 1, 2), i("???", XXX, IMP, 0, 2), i("JMP", JMP, ABS, 3, 3), i("EOR", EOR, ABS, 3, 4), i("LSR", LSR, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 310 + i("BVC", BVC, REL, 2, 2), i("EOR", EOR, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("EOR", EOR, ZPX, 2, 4), i("LSR", LSR, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("CLI", CLI, IMP, 1, 2), i("EOR", EOR, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("EOR", EOR, ABX, 3, 4), i("LSR", LSR, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 311 + i("RTS", RTS, IMP, 1, 6), i("ADC", ADC, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ADC", ADC, ZP0, 2, 3), i("ROR", ROR, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("PLA", PLA, IMP, 1, 4), i("ADC", ADC, IMM, 2, 2), i("ROR", ROR, ACC, 1, 2), i("???", XXX, IMP, 0, 2), i("JMP", JMP, IND, 3, 5), i("ADC", ADC, ABS, 3, 4), i("ROR", ROR, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 312 + i("BVS", BVS, REL, 2, 2), i("ADC", ADC, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ADC", ADC, ZPX, 2, 4), i("ROR", ROR, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("SEI", SEI, IMP, 1, 2), i("ADC", ADC, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("ADC", ADC, ABX, 3, 4), i("ROR", ROR, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 313 + i("???", XXX, IMP, 0, 2), i("STA", STA, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("STY", STY, ZP0, 2, 3), i("STA", STA, ZP0, 2, 3), i("STX", STX, ZP0, 2, 3), i("???", XXX, IMP, 0, 2), i("DEY", DEY, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("TXA", TXA, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("STY", STY, ABS, 3, 4), i("STA", STA, ABS, 3, 4), i("STX", STX, ABS, 3, 4), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 314 + i("BCC", BCC, REL, 2, 2), i("STA", STA, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("STY", STY, ZPX, 2, 4), i("STA", STA, ZPX, 2, 4), i("STX", STX, ZPY, 2, 4), i("???", XXX, IMP, 0, 2), i("TYA", TYA, IMP, 1, 2), i("STA", STA, ABY, 3, 5), i("TXS", TXS, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("STA", STA, ABX, 3, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 315 + i("LDY", LDY, IMM, 2, 2), i("LDA", LDA, IZX, 2, 6), i("LDX", LDX, IMM, 2, 2), i("???", XXX, IMP, 0, 2), i("LDY", LDY, ZP0, 2, 3), i("LDA", LDA, ZP0, 2, 3), i("LDX", LDX, ZP0, 2, 3), i("???", XXX, IMP, 0, 2), i("TAY", TAY, IMP, 1, 2), i("LDA", LDA, IMM, 2, 2), i("TAX", TAX, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("LDY", LDY, ABS, 3, 4), i("LDA", LDA, ABS, 3, 4), i("LDX", LDX, ABS, 3, 4), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 316 + i("BCS", BCS, REL, 2, 2), i("LDA", LDA, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("LDY", LDY, ZPX, 2, 4), i("LDA", LDA, ZPX, 2, 4), i("LDX", LDX, ZPY, 2, 4), i("???", XXX, IMP, 0, 2), i("CLV", CLV, IMP, 1, 2), i("LDA", LDA, ABY, 3, 4), i("TSX", TSX, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("LDY", LDY, ABX, 3, 4), i("LDA", LDA, ABX, 3, 4), i("LDX", LDX, ABY, 3, 4), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 317 + i("CPY", CPY, IMM, 2, 2), i("CMP", CMP, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("CPY", CPY, ZP0, 2, 3), i("CMP", CMP, ZP0, 2, 3), i("DEC", DEC, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("INY", INY, IMP, 1, 2), i("CMP", CMP, IMM, 2, 2), i("DEX", DEX, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("CPY", CPY, ABS, 3, 4), i("CMP", CMP, ABS, 3, 4), i("DEC", DEC, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 318 + i("BNE", BNE, REL, 2, 2), i("CMP", CMP, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("CMP", CMP, ZPX, 2, 4), i("DEC", DEC, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("CLD", CLD, IMP, 1, 2), i("CMP", CMP, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("CMP", CMP, ABX, 3, 4), i("DEC", DEC, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 319 + i("CPX", CPX, IMM, 2, 2), i("SBC", SBC, IZX, 2, 6), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("CPX", CPX, ZP0, 2, 3), i("SBC", SBC, ZP0, 2, 3), i("INC", INC, ZP0, 2, 5), i("???", XXX, IMP, 0, 2), i("INX", INX, IMP, 1, 2), i("SBC", SBC, IMM, 2, 2), i("NOP", NOP, IMP, 1, 2), i("???", XXX, IMP, 0, 2), i("CPX", CPX, ABS, 3, 4), i("SBC", SBC, ABS, 3, 4), i("INC", INC, ABS, 3, 6), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 320 + i("BEQ", BEQ, REL, 2, 2), i("SBC", SBC, IZY, 2, 5), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("SBC", SBC, ZPX, 2, 4), i("INC", INC, ZPX, 2, 6), i("???", XXX, IMP, 0, 2), i("SED", SED, IMP, 1, 2), i("SBC", SBC, ABY, 3, 4), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("???", XXX, IMP, 0, 2), i("SBC", SBC, ABX, 3, 4), i("INC", INC, ABX, 3, 7), i("???", XXX, IMP, 0, 2), [INFO] [stdout] 321 ~ ] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | return Instruction { name: String::from(name), operate, addrmode, num_bytes, cycles }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return Instruction { name: String::from(name), operate, addrmode, num_bytes, cycles }; [INFO] [stdout] 301 + Instruction { name: String::from(name), operate, addrmode, num_bytes, cycles } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return 0; [INFO] [stdout] 331 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:338:5 [INFO] [stdout] | [INFO] [stdout] 338 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 338 - return 0; [INFO] [stdout] 338 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:350:5 [INFO] [stdout] | [INFO] [stdout] 350 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return 0; [INFO] [stdout] 350 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:358:5 [INFO] [stdout] | [INFO] [stdout] 358 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 358 - return 0; [INFO] [stdout] 358 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:367:5 [INFO] [stdout] | [INFO] [stdout] 367 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 367 - return 0; [INFO] [stdout] 367 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:376:5 [INFO] [stdout] | [INFO] [stdout] 376 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 376 - return 0; [INFO] [stdout] 376 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 390 | / return if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 391 | | 1 [INFO] [stdout] 392 | | } else { [INFO] [stdout] 393 | | 0 [INFO] [stdout] 394 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 ~ if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 391 + 1 [INFO] [stdout] 392 + } else { [INFO] [stdout] 393 + 0 [INFO] [stdout] 394 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:408:5 [INFO] [stdout] | [INFO] [stdout] 408 | / return if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 409 | | 1 [INFO] [stdout] 410 | | } else { [INFO] [stdout] 411 | | 0 [INFO] [stdout] 412 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 408 ~ if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 409 + 1 [INFO] [stdout] 410 + } else { [INFO] [stdout] 411 + 0 [INFO] [stdout] 412 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:418:5 [INFO] [stdout] | [INFO] [stdout] 418 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 418 - return 0; [INFO] [stdout] 418 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:429:5 [INFO] [stdout] | [INFO] [stdout] 429 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - return 0; [INFO] [stdout] 429 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:444:5 [INFO] [stdout] | [INFO] [stdout] 444 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 444 - return 0; [INFO] [stdout] 444 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u16` [INFO] [stdout] --> src/olc6502.rs:438:24 [INFO] [stdout] | [INFO] [stdout] 438 | let lo_addr: u16 = u16::from((t + x) & 0x00FF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `u16::from()`: `((t + x) & 0x00FF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u16` [INFO] [stdout] --> src/olc6502.rs:439:24 [INFO] [stdout] | [INFO] [stdout] 439 | let hi_addr: u16 = u16::from((t + x + 1) & 0x00FF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `u16::from()`: `((t + x + 1) & 0x00FF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | / return if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 459 | | 1 [INFO] [stdout] 460 | | } else { [INFO] [stdout] 461 | | 0 [INFO] [stdout] 462 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 458 ~ if (o.addr_abs & 0xFF00) != (hi << 8) { [INFO] [stdout] 459 + 1 [INFO] [stdout] 460 + } else { [INFO] [stdout] 461 + 0 [INFO] [stdout] 462 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:480:5 [INFO] [stdout] | [INFO] [stdout] 480 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 480 - return 0; [INFO] [stdout] 480 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/olc6502.rs:475:80 [INFO] [stdout] | [INFO] [stdout] 475 | o.addr_abs = (u16::from(o.read(ptr & 0xFF00)) << 8) | u16::from(o.read(ptr + 0)); [INFO] [stdout] | ^^^^^^^ help: consider reducing it to: `ptr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/olc6502.rs:477:75 [INFO] [stdout] | [INFO] [stdout] 477 | o.addr_abs = (u16::from(o.read(ptr + 1)) << 8) | u16::from(o.read(ptr + 0)); [INFO] [stdout] | ^^^^^^^ help: consider reducing it to: `ptr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:490:5 [INFO] [stdout] | [INFO] [stdout] 490 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 490 - return 1; [INFO] [stdout] 490 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/olc6502.rs:501:30 [INFO] [stdout] | [INFO] [stdout] 501 | o.set_flag(Flags6502::V, !((a ^ data16) & 0x80 > 0) && ((a ^ sum) & 0x80) > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((a ^ data16) & 0x80 <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:511:5 [INFO] [stdout] | [INFO] [stdout] 511 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 511 - return 1; [INFO] [stdout] 511 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:527:5 [INFO] [stdout] | [INFO] [stdout] 527 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 527 - return 0; [INFO] [stdout] 527 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:543:5 [INFO] [stdout] | [INFO] [stdout] 543 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 543 - return 0; [INFO] [stdout] 543 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:551:5 [INFO] [stdout] | [INFO] [stdout] 551 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 551 - return 0; [INFO] [stdout] 551 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:559:5 [INFO] [stdout] | [INFO] [stdout] 559 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 559 - return 0; [INFO] [stdout] 559 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:569:5 [INFO] [stdout] | [INFO] [stdout] 569 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 569 - return 0; [INFO] [stdout] 569 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:577:5 [INFO] [stdout] | [INFO] [stdout] 577 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 577 - return 0; [INFO] [stdout] 577 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:585:5 [INFO] [stdout] | [INFO] [stdout] 585 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 585 - return 0; [INFO] [stdout] 585 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:593:5 [INFO] [stdout] | [INFO] [stdout] 593 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 593 - return 0; [INFO] [stdout] 593 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:601:5 [INFO] [stdout] | [INFO] [stdout] 601 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 601 - return 0; [INFO] [stdout] 601 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:609:5 [INFO] [stdout] | [INFO] [stdout] 609 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 609 - return 0; [INFO] [stdout] 609 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:617:5 [INFO] [stdout] | [INFO] [stdout] 617 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 617 - return 0; [INFO] [stdout] 617 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:623:5 [INFO] [stdout] | [INFO] [stdout] 623 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 623 - return 0; [INFO] [stdout] 623 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:629:5 [INFO] [stdout] | [INFO] [stdout] 629 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 629 - return 0; [INFO] [stdout] 629 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:635:5 [INFO] [stdout] | [INFO] [stdout] 635 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 635 - return 0; [INFO] [stdout] 635 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:641:5 [INFO] [stdout] | [INFO] [stdout] 641 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 641 - return 0; [INFO] [stdout] 641 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:651:5 [INFO] [stdout] | [INFO] [stdout] 651 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 651 - return 1; [INFO] [stdout] 651 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:661:5 [INFO] [stdout] | [INFO] [stdout] 661 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 661 - return 1; [INFO] [stdout] 661 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:671:5 [INFO] [stdout] | [INFO] [stdout] 671 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 671 - return 1; [INFO] [stdout] 671 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:681:5 [INFO] [stdout] | [INFO] [stdout] 681 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 681 - return 0; [INFO] [stdout] 681 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:689:5 [INFO] [stdout] | [INFO] [stdout] 689 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 689 - return 0; [INFO] [stdout] 689 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:697:5 [INFO] [stdout] | [INFO] [stdout] 697 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 697 - return 0; [INFO] [stdout] 697 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:706:5 [INFO] [stdout] | [INFO] [stdout] 706 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 706 - return 1; [INFO] [stdout] 706 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:716:5 [INFO] [stdout] | [INFO] [stdout] 716 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 716 - return 0; [INFO] [stdout] 716 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:724:5 [INFO] [stdout] | [INFO] [stdout] 724 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 724 - return 0; [INFO] [stdout] 724 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:732:5 [INFO] [stdout] | [INFO] [stdout] 732 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 732 - return 0; [INFO] [stdout] 732 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:738:5 [INFO] [stdout] | [INFO] [stdout] 738 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 738 - return 0; [INFO] [stdout] 738 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:749:5 [INFO] [stdout] | [INFO] [stdout] 749 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 749 - return 0; [INFO] [stdout] 749 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:757:5 [INFO] [stdout] | [INFO] [stdout] 757 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 757 - return 1; [INFO] [stdout] 757 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:765:5 [INFO] [stdout] | [INFO] [stdout] 765 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 765 - return 1; [INFO] [stdout] 765 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:773:5 [INFO] [stdout] | [INFO] [stdout] 773 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 773 - return 1; [INFO] [stdout] 773 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:789:5 [INFO] [stdout] | [INFO] [stdout] 789 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 789 - return 0; [INFO] [stdout] 789 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:794:5 [INFO] [stdout] | [INFO] [stdout] 794 | return 0x0; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 794 - return 0x0; [INFO] [stdout] 794 + 0x0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:803:5 [INFO] [stdout] | [INFO] [stdout] 803 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 803 - return 1; [INFO] [stdout] 803 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:809:5 [INFO] [stdout] | [INFO] [stdout] 809 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 809 - return 0; [INFO] [stdout] 809 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:816:5 [INFO] [stdout] | [INFO] [stdout] 816 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 816 - return 0; [INFO] [stdout] 816 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:824:5 [INFO] [stdout] | [INFO] [stdout] 824 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 824 - return 0; [INFO] [stdout] 824 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:837:5 [INFO] [stdout] | [INFO] [stdout] 837 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 837 - return 0; [INFO] [stdout] 837 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:853:5 [INFO] [stdout] | [INFO] [stdout] 853 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 853 - return 0; [INFO] [stdout] 853 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:869:5 [INFO] [stdout] | [INFO] [stdout] 869 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 869 - return 0; [INFO] [stdout] 869 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:885:5 [INFO] [stdout] | [INFO] [stdout] 885 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 885 - return 0; [INFO] [stdout] 885 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:893:5 [INFO] [stdout] | [INFO] [stdout] 893 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 893 - return 0; [INFO] [stdout] 893 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:901:5 [INFO] [stdout] | [INFO] [stdout] 901 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 901 - return 1; [INFO] [stdout] 901 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:907:5 [INFO] [stdout] | [INFO] [stdout] 907 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 907 - return 0; [INFO] [stdout] 907 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:913:5 [INFO] [stdout] | [INFO] [stdout] 913 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 913 - return 0; [INFO] [stdout] 913 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:919:5 [INFO] [stdout] | [INFO] [stdout] 919 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 919 - return 0; [INFO] [stdout] 919 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:925:5 [INFO] [stdout] | [INFO] [stdout] 925 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 925 - return 0; [INFO] [stdout] 925 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:931:5 [INFO] [stdout] | [INFO] [stdout] 931 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 931 - return 0; [INFO] [stdout] 931 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:937:5 [INFO] [stdout] | [INFO] [stdout] 937 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 937 - return 0; [INFO] [stdout] 937 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:945:5 [INFO] [stdout] | [INFO] [stdout] 945 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 945 - return 0; [INFO] [stdout] 945 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:953:5 [INFO] [stdout] | [INFO] [stdout] 953 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 953 - return 0; [INFO] [stdout] 953 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:961:5 [INFO] [stdout] | [INFO] [stdout] 961 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 961 - return 0; [INFO] [stdout] 961 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:969:5 [INFO] [stdout] | [INFO] [stdout] 969 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 969 - return 0; [INFO] [stdout] 969 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:975:5 [INFO] [stdout] | [INFO] [stdout] 975 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 975 - return 0; [INFO] [stdout] 975 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:983:5 [INFO] [stdout] | [INFO] [stdout] 983 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 983 - return 0; [INFO] [stdout] 983 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/olc6502.rs:988:5 [INFO] [stdout] | [INFO] [stdout] 988 | return 0x0; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 988 - return 0x0; [INFO] [stdout] 988 + 0x0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.55s [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/logline.rs:30:28 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse_my_line(line: &String) -> Logline { [INFO] [stdout] | ^^^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse_my_line(line: &String) -> Logline<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/logline.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn parse_their_line(line: &String) -> Logline { [INFO] [stdout] | ^^^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 43 | pub fn parse_their_line(line: &String) -> Logline<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:252:30 [INFO] [stdout] | [INFO] [stdout] 252 | let imp: usize = IMP as usize; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(function_casts_as_integer)]` on by default [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 252 | let imp: usize = IMP as *const () as usize; [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:253:30 [INFO] [stdout] | [INFO] [stdout] 253 | let acc: usize = ACC as usize; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 253 | let acc: usize = ACC as *const () as usize; [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:522:61 [INFO] [stdout] | [INFO] [stdout] 522 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 522 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as *const () as usize { [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:784:61 [INFO] [stdout] | [INFO] [stdout] 784 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 784 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as *const () as usize { [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:848:61 [INFO] [stdout] | [INFO] [stdout] 848 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 848 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as *const () as usize { [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct cast of function item into an integer [INFO] [stdout] --> src/olc6502.rs:864:61 [INFO] [stdout] | [INFO] [stdout] 864 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: first cast to a pointer `as *const ()` [INFO] [stdout] | [INFO] [stdout] 864 | if o.lookup[o.opcode as usize].addrmode as usize == ACC as *const () as usize { [INFO] [stdout] | ++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "c3a0d62541fb295cfcd5f015178c76cc1a49d53953c7625e6699b98be6b553c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3a0d62541fb295cfcd5f015178c76cc1a49d53953c7625e6699b98be6b553c6", kill_on_drop: false }` [INFO] [stdout] c3a0d62541fb295cfcd5f015178c76cc1a49d53953c7625e6699b98be6b553c6