[INFO] cloning repository https://github.com/jbteves/rsdiff
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jbteves/rsdiff" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjbteves%2Frsdiff", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjbteves%2Frsdiff'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] ece5de8dda1ae0df499f5b646d19c8727feb99c7
[INFO] linting jbteves/rsdiff against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjbteves%2Frsdiff" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/jbteves/rsdiff
[INFO] finished tweaking git repo https://github.com/jbteves/rsdiff
[INFO] tweaked toml for git repo https://github.com/jbteves/rsdiff written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/jbteves/rsdiff on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/jbteves/rsdiff already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded byteordered v0.5.0
[INFO] [stderr]   Downloaded safe-transmute v0.11.2
[INFO] [stderr]   Downloaded nifti v0.14.0
[INFO] [stderr]   Downloaded ndarray v0.15.3
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 1c44a308ce01918bda5795054ddaeac022583fcf91921574b30559cb1b8136d3
[INFO] running `Command { std: "docker" "start" "-a" "1c44a308ce01918bda5795054ddaeac022583fcf91921574b30559cb1b8136d3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "1c44a308ce01918bda5795054ddaeac022583fcf91921574b30559cb1b8136d3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1c44a308ce01918bda5795054ddaeac022583fcf91921574b30559cb1b8136d3", kill_on_drop: false }`
[INFO] [stdout] 1c44a308ce01918bda5795054ddaeac022583fcf91921574b30559cb1b8136d3
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 0d20cf52f78d62e20a91ab23a65c6fb2ff0777ae3f097757aabf1ece5b5d76f9
[INFO] running `Command { std: "docker" "start" "-a" "0d20cf52f78d62e20a91ab23a65c6fb2ff0777ae3f097757aabf1ece5b5d76f9", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.98
[INFO] [stderr]    Compiling num-traits v0.2.14
[INFO] [stderr]    Compiling cc v1.0.69
[INFO] [stderr]    Compiling proc-macro2 v1.0.28
[INFO] [stderr]    Compiling syn v1.0.74
[INFO] [stderr]     Checking rawpointer v0.2.1
[INFO] [stderr]    Compiling bitflags v1.2.1
[INFO] [stderr]     Checking unicode-width v0.1.8
[INFO] [stderr]     Checking matrixmultiply v0.3.1
[INFO] [stderr]     Checking byteordered v0.5.0
[INFO] [stderr]     Checking textwrap v0.11.0
[INFO] [stderr]     Checking quick-error v2.0.1
[INFO] [stderr]     Checking safe-transmute v0.11.2
[INFO] [stderr]     Checking either v1.6.1
[INFO] [stderr]    Compiling cmake v0.1.45
[INFO] [stderr]    Compiling quote v1.0.9
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking colored v2.0.0
[INFO] [stderr]     Checking clap v2.33.3
[INFO] [stderr]    Compiling libz-sys v1.1.3
[INFO] [stderr]     Checking num-integer v0.1.44
[INFO] [stderr]     Checking approx v0.4.0
[INFO] [stderr]     Checking num-complex v0.4.0
[INFO] [stderr]     Checking ndarray v0.15.3
[INFO] [stderr]    Compiling num-derive v0.3.3
[INFO] [stderr]     Checking flate2 v1.0.20
[INFO] [stderr]     Checking nifti v0.14.0
[INFO] [stderr]     Checking rsdiff v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: empty lines after doc comment
[INFO] [stdout]  --> src/lib.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | / /// Library for rsdiff
[INFO] [stdout] ... |
[INFO] [stdout] 6 | |
[INFO] [stdout]   | |_^
[INFO] [stdout] 7 |   use std::{
[INFO] [stdout]   |   - the comment documents this `use` import
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]   = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]   = help: if the empty lines are unintentional, remove them
[INFO] [stdout] help: if the doc comment should not document the following item then comment it out
[INFO] [stdout]   |
[INFO] [stdout] 1 | // /// Library for rsdiff
[INFO] [stdout]   | ++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `time`
[INFO] [stdout]   --> src/lib.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     time,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty lines after doc comment
[INFO] [stdout]  --> src/lib.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | / /// Library for rsdiff
[INFO] [stdout] ... |
[INFO] [stdout] 6 | |
[INFO] [stdout]   | |_^
[INFO] [stdout] 7 |   use std::{
[INFO] [stdout]   |   - the comment documents this `use` import
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]   = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]   = help: if the empty lines are unintentional, remove them
[INFO] [stdout] help: if the doc comment should not document the following item then comment it out
[INFO] [stdout]   |
[INFO] [stdout] 1 | // /// Library for rsdiff
[INFO] [stdout]   | ++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `time`
[INFO] [stdout]   --> src/lib.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     time,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `TOLERANCE` is never used
[INFO] [stdout]    --> src/lib.rs:469:11
[INFO] [stdout]     |
[INFO] [stdout] 469 |     const TOLERANCE: f32 = 1e-16;
[INFO] [stdout]     |           ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `TOLERANCE` is never used
[INFO] [stdout]    --> src/lib.rs:513:11
[INFO] [stdout]     |
[INFO] [stdout] 513 |     const TOLERANCE: f32 = 1e-16;
[INFO] [stdout]     |           ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `TOLERANCE` is never used
[INFO] [stdout]    --> src/lib.rs:469:11
[INFO] [stdout]     |
[INFO] [stdout] 469 |     const TOLERANCE: f32 = 1e-16;
[INFO] [stdout]     |           ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `TOLERANCE` is never used
[INFO] [stdout]    --> src/lib.rs:513:11
[INFO] [stdout]     |
[INFO] [stdout] 513 |     const TOLERANCE: f32 = 1e-16;
[INFO] [stdout]     |           ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:72:9
[INFO] [stdout]    |
[INFO] [stdout] 72 |         return diff_directory(left, right);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -         return diff_directory(left, right);
[INFO] [stdout] 72 +         diff_directory(left, right)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 |         return diff_bytes(left, right);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 79 -         return diff_bytes(left, right);
[INFO] [stdout] 79 +         diff_bytes(left, right)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:189:5
[INFO] [stdout]     |
[INFO] [stdout] 189 |     return d;
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 189 -     return d;
[INFO] [stdout] 189 +     d
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:72:9
[INFO] [stdout]    |
[INFO] [stdout] 72 |         return diff_directory(left, right);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -         return diff_directory(left, right);
[INFO] [stdout] 72 +         diff_directory(left, right)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 |         return diff_bytes(left, right);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 79 -         return diff_bytes(left, right);
[INFO] [stdout] 79 +         diff_bytes(left, right)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:189:5
[INFO] [stdout]     |
[INFO] [stdout] 189 |     return d;
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 189 -     return d;
[INFO] [stdout] 189 +     d
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:125:27
[INFO] [stdout]     |
[INFO] [stdout] 125 |             d.common.push(String::from(x));
[INFO] [stdout]     |                           ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:128:30
[INFO] [stdout]     |
[INFO] [stdout] 128 |             d.left_only.push(String::from(x));
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:133:31
[INFO] [stdout]     |
[INFO] [stdout] 133 |             d.right_only.push(String::from(x));
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:150:8
[INFO] [stdout]     |
[INFO] [stdout] 150 |     if d.left_only.len() == 0 && d.right_only.len() == 0 && 
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.left_only.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:150:34
[INFO] [stdout]     |
[INFO] [stdout] 150 |     if d.left_only.len() == 0 && d.right_only.len() == 0 && 
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.right_only.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:158:12
[INFO] [stdout]     |
[INFO] [stdout] 158 |         if d.left_only.len() != 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!d.left_only.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:125:27
[INFO] [stdout]     |
[INFO] [stdout] 125 |             d.common.push(String::from(x));
[INFO] [stdout]     |                           ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:163:12
[INFO] [stdout]     |
[INFO] [stdout] 163 |         if d.right_only.len() != 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!d.right_only.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:128:30
[INFO] [stdout]     |
[INFO] [stdout] 128 |             d.left_only.push(String::from(x));
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:133:31
[INFO] [stdout]     |
[INFO] [stdout] 133 |             d.right_only.push(String::from(x));
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:287:5
[INFO] [stdout]     |
[INFO] [stdout] 287 |     return d;
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 287 -     return d;
[INFO] [stdout] 287 +     d
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:150:8
[INFO] [stdout]     |
[INFO] [stdout] 150 |     if d.left_only.len() == 0 && d.right_only.len() == 0 && 
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.left_only.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:238:20
[INFO] [stdout]     |
[INFO] [stdout] 238 |                 if left_buffer.len() != 0 {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!left_buffer.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:150:34
[INFO] [stdout]     |
[INFO] [stdout] 150 |     if d.left_only.len() == 0 && d.right_only.len() == 0 && 
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.right_only.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:158:12
[INFO] [stdout]     |
[INFO] [stdout] 158 |         if d.left_only.len() != 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!d.left_only.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:163:12
[INFO] [stdout]     |
[INFO] [stdout] 163 |         if d.right_only.len() != 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!d.right_only.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:259:33
[INFO] [stdout]     |
[INFO] [stdout] 259 |               d.additional_info = String::from(
[INFO] [stdout]     |  _________________________________^
[INFO] [stdout] 260 | |                 format!(
[INFO] [stdout] 261 | |                     "{} of {} bytes match ({2:.1}%)",
[INFO] [stdout] 262 | |                     total_matches,
[INFO] [stdout] ...   |
[INFO] [stdout] 266 | |             );
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `String::from()`
[INFO] [stdout]     |
[INFO] [stdout] 259 ~             d.additional_info = format!(
[INFO] [stdout] 260 +                     "{} of {} bytes match ({2:.1}%)",
[INFO] [stdout] 261 +                     total_matches,
[INFO] [stdout] 262 +                     fsize,
[INFO] [stdout] 263 +                     percentage
[INFO] [stdout] 264 ~                 );
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:271:29
[INFO] [stdout]     |
[INFO] [stdout] 271 |           d.additional_info = String::from(
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 272 | |             format!(
[INFO] [stdout] 273 | |                 "file sizes differ: {} vs. {}",
[INFO] [stdout] 274 | |                 left_meta.len(),
[INFO] [stdout] ...   |
[INFO] [stdout] 277 | |         );
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `String::from()`
[INFO] [stdout]     |
[INFO] [stdout] 271 ~         d.additional_info = format!(
[INFO] [stdout] 272 +                 "file sizes differ: {} vs. {}",
[INFO] [stdout] 273 +                 left_meta.len(),
[INFO] [stdout] 274 +                 right_meta.len()
[INFO] [stdout] 275 ~             );
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:282:20
[INFO] [stdout]     |
[INFO] [stdout] 282 |           d.report = String::from(
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 283 | |             format!("{} vs {}: {}", d.left, d.right, d.additional_info)
[INFO] [stdout] 284 | |         );
[INFO] [stdout]     | |_________^ help: consider removing `String::from()`: `format!("{} vs {}: {}", d.left, d.right, d.additional_info)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:292:8
[INFO] [stdout]     |
[INFO] [stdout] 292 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:309:5
[INFO] [stdout]     |
[INFO] [stdout] 309 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 309 -     return matches
[INFO] [stdout] 309 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:314:8
[INFO] [stdout]     |
[INFO] [stdout] 314 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:287:5
[INFO] [stdout]     |
[INFO] [stdout] 287 |     return d;
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 287 -     return d;
[INFO] [stdout] 287 +     d
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:331:5
[INFO] [stdout]     |
[INFO] [stdout] 331 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 331 -     return matches
[INFO] [stdout] 331 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:336:8
[INFO] [stdout]     |
[INFO] [stdout] 336 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:353:5
[INFO] [stdout]     |
[INFO] [stdout] 353 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 353 -     return matches
[INFO] [stdout] 353 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:358:8
[INFO] [stdout]     |
[INFO] [stdout] 358 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:375:5
[INFO] [stdout]     |
[INFO] [stdout] 375 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 375 -     return matches
[INFO] [stdout] 375 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:238:20
[INFO] [stdout]     |
[INFO] [stdout] 238 |                 if left_buffer.len() != 0 {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!left_buffer.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:259:33
[INFO] [stdout]     |
[INFO] [stdout] 259 |               d.additional_info = String::from(
[INFO] [stdout]     |  _________________________________^
[INFO] [stdout] 260 | |                 format!(
[INFO] [stdout] 261 | |                     "{} of {} bytes match ({2:.1}%)",
[INFO] [stdout] 262 | |                     total_matches,
[INFO] [stdout] ...   |
[INFO] [stdout] 266 | |             );
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `String::from()`
[INFO] [stdout]     |
[INFO] [stdout] 259 ~             d.additional_info = format!(
[INFO] [stdout] 260 +                     "{} of {} bytes match ({2:.1}%)",
[INFO] [stdout] 261 +                     total_matches,
[INFO] [stdout] 262 +                     fsize,
[INFO] [stdout] 263 +                     percentage
[INFO] [stdout] 264 ~                 );
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:271:29
[INFO] [stdout]     |
[INFO] [stdout] 271 |           d.additional_info = String::from(
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 272 | |             format!(
[INFO] [stdout] 273 | |                 "file sizes differ: {} vs. {}",
[INFO] [stdout] 274 | |                 left_meta.len(),
[INFO] [stdout] ...   |
[INFO] [stdout] 277 | |         );
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `String::from()`
[INFO] [stdout]     |
[INFO] [stdout] 271 ~         d.additional_info = format!(
[INFO] [stdout] 272 +                 "file sizes differ: {} vs. {}",
[INFO] [stdout] 273 +                 left_meta.len(),
[INFO] [stdout] 274 +                 right_meta.len()
[INFO] [stdout] 275 ~             );
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/lib.rs:282:20
[INFO] [stdout]     |
[INFO] [stdout] 282 |           d.report = String::from(
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 283 | |             format!("{} vs {}: {}", d.left, d.right, d.additional_info)
[INFO] [stdout] 284 | |         );
[INFO] [stdout]     | |_________^ help: consider removing `String::from()`: `format!("{} vs {}: {}", d.left, d.right, d.additional_info)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:292:8
[INFO] [stdout]     |
[INFO] [stdout] 292 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:309:5
[INFO] [stdout]     |
[INFO] [stdout] 309 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 309 -     return matches
[INFO] [stdout] 309 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:380:8
[INFO] [stdout]     |
[INFO] [stdout] 380 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:397:5
[INFO] [stdout]     |
[INFO] [stdout] 397 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 397 -     return matches
[INFO] [stdout] 397 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:402:8
[INFO] [stdout]     |
[INFO] [stdout] 402 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:419:5
[INFO] [stdout]     |
[INFO] [stdout] 419 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 419 -     return matches
[INFO] [stdout] 419 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:424:8
[INFO] [stdout]     |
[INFO] [stdout] 424 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:441:5
[INFO] [stdout]     |
[INFO] [stdout] 441 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 441 -     return matches
[INFO] [stdout] 441 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:314:8
[INFO] [stdout]     |
[INFO] [stdout] 314 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:331:5
[INFO] [stdout]     |
[INFO] [stdout] 331 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 331 -     return matches
[INFO] [stdout] 331 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:336:8
[INFO] [stdout]     |
[INFO] [stdout] 336 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:353:5
[INFO] [stdout]     |
[INFO] [stdout] 353 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 353 -     return matches
[INFO] [stdout] 353 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:446:8
[INFO] [stdout]     |
[INFO] [stdout] 446 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:463:5
[INFO] [stdout]     |
[INFO] [stdout] 463 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 463 -     return matches
[INFO] [stdout] 463 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/lib.rs:478:5
[INFO] [stdout]     |
[INFO] [stdout] 478 | /     let _offset_left = left_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout] 479 | |         .expect("I can't read the GZ file!");
[INFO] [stdout]     | |_____________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout]     = note: `#[warn(clippy::let_unit_value)]` on by default
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 478 -     let _offset_left = left_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout] 478 +     left_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/lib.rs:480:5
[INFO] [stdout]     |
[INFO] [stdout] 480 | /     let _offset_right = right_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout] 481 | |         .expect("I can't read the right GZ file!");
[INFO] [stdout]     | |___________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 480 -     let _offset_right = right_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout] 480 +     right_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:358:8
[INFO] [stdout]     |
[INFO] [stdout] 358 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:375:5
[INFO] [stdout]     |
[INFO] [stdout] 375 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 375 -     return matches
[INFO] [stdout] 375 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:380:8
[INFO] [stdout]     |
[INFO] [stdout] 380 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:397:5
[INFO] [stdout]     |
[INFO] [stdout] 397 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 397 -     return matches
[INFO] [stdout] 397 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:402:8
[INFO] [stdout]     |
[INFO] [stdout] 402 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:531:16
[INFO] [stdout]     |
[INFO] [stdout] 531 |             if left_buffer.len() !=  0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!left_buffer.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:419:5
[INFO] [stdout]     |
[INFO] [stdout] 419 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 419 -     return matches
[INFO] [stdout] 419 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:532:48
[INFO] [stdout]     |
[INFO] [stdout] 532 |                 total_matches += buffer_differ(&left_buffer, &right_buffer);
[INFO] [stdout]     |                                                ^^^^^^^^^^^^ help: change this to: `left_buffer`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:424:8
[INFO] [stdout]     |
[INFO] [stdout] 424 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:441:5
[INFO] [stdout]     |
[INFO] [stdout] 441 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 441 -     return matches
[INFO] [stdout] 441 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:532:62
[INFO] [stdout]     |
[INFO] [stdout] 532 |                 total_matches += buffer_differ(&left_buffer, &right_buffer);
[INFO] [stdout]     |                                                              ^^^^^^^^^^^^^ help: change this to: `right_buffer`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:446:8
[INFO] [stdout]     |
[INFO] [stdout] 446 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:463:5
[INFO] [stdout]     |
[INFO] [stdout] 463 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 463 -     return matches
[INFO] [stdout] 463 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:631:5
[INFO] [stdout]     |
[INFO] [stdout] 631 |     return d;
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 631 -     return d;
[INFO] [stdout] 631 +     d
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/lib.rs:478:5
[INFO] [stdout]     |
[INFO] [stdout] 478 | /     let _offset_left = left_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout] 479 | |         .expect("I can't read the GZ file!");
[INFO] [stdout]     | |_____________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout]     = note: `#[warn(clippy::let_unit_value)]` on by default
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 478 -     let _offset_left = left_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout] 478 +     left_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/lib.rs:480:5
[INFO] [stdout]     |
[INFO] [stdout] 480 | /     let _offset_right = right_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout] 481 | |         .expect("I can't read the right GZ file!");
[INFO] [stdout]     | |___________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 480 -     let _offset_right = right_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout] 480 +     right_gz.read_exact(&mut place_holder_buffer)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:531:16
[INFO] [stdout]     |
[INFO] [stdout] 531 |             if left_buffer.len() !=  0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!left_buffer.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:532:48
[INFO] [stdout]     |
[INFO] [stdout] 532 |                 total_matches += buffer_differ(&left_buffer, &right_buffer);
[INFO] [stdout]     |                                                ^^^^^^^^^^^^ help: change this to: `left_buffer`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:532:62
[INFO] [stdout]     |
[INFO] [stdout] 532 |                 total_matches += buffer_differ(&left_buffer, &right_buffer);
[INFO] [stdout]     |                                                              ^^^^^^^^^^^^^ help: change this to: `right_buffer`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:640:8
[INFO] [stdout]     |
[INFO] [stdout] 640 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:651:5
[INFO] [stdout]     |
[INFO] [stdout] 651 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 651 -     return matches
[INFO] [stdout] 651 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:631:5
[INFO] [stdout]     |
[INFO] [stdout] 631 |     return d;
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 631 -     return d;
[INFO] [stdout] 631 +     d
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:640:8
[INFO] [stdout]     |
[INFO] [stdout] 640 |     if !(left.len() == right.len()) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(left.len() != right.len())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:651:5
[INFO] [stdout]     |
[INFO] [stdout] 651 |     return matches
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 651 -     return matches
[INFO] [stdout] 651 +     matches
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]  --> src/main.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | / /// Will use Rust to perform abstracted diff
[INFO] [stdout] 3 | |
[INFO] [stdout]   | |_^
[INFO] [stdout] 4 |   // Build a friendly CLI
[INFO] [stdout] 5 |   use clap::{Arg, App};
[INFO] [stdout]   |   - the comment documents this `use` import
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]   = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]   = help: if the empty line is unintentional, remove it
[INFO] [stdout] help: if the doc comment should not document the following item then comment it out
[INFO] [stdout]   |
[INFO] [stdout] 1 ~ // /// rsdiff
[INFO] [stdout] 2 ~ // /// Will use Rust to perform abstracted diff
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]  --> src/main.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | / /// Will use Rust to perform abstracted diff
[INFO] [stdout] 3 | |
[INFO] [stdout]   | |_^
[INFO] [stdout] 4 |   // Build a friendly CLI
[INFO] [stdout] 5 |   use clap::{Arg, App};
[INFO] [stdout]   |   - the comment documents this `use` import
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]   = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]   = help: if the empty line is unintentional, remove it
[INFO] [stdout] help: if the doc comment should not document the following item then comment it out
[INFO] [stdout]   |
[INFO] [stdout] 1 ~ // /// rsdiff
[INFO] [stdout] 2 ~ // /// Will use Rust to perform abstracted diff
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.77s
[INFO] running `Command { std: "docker" "inspect" "0d20cf52f78d62e20a91ab23a65c6fb2ff0777ae3f097757aabf1ece5b5d76f9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0d20cf52f78d62e20a91ab23a65c6fb2ff0777ae3f097757aabf1ece5b5d76f9", kill_on_drop: false }`
[INFO] [stdout] 0d20cf52f78d62e20a91ab23a65c6fb2ff0777ae3f097757aabf1ece5b5d76f9