[INFO] cloning repository https://github.com/jay-goyal/snek-game [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jay-goyal/snek-game" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjay-goyal%2Fsnek-game", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjay-goyal%2Fsnek-game'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] da302215396f364d05789ae7234d9f13b0d48389 [INFO] linting jay-goyal/snek-game against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjay-goyal%2Fsnek-game" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jay-goyal/snek-game [INFO] finished tweaking git repo https://github.com/jay-goyal/snek-game [INFO] tweaked toml for git repo https://github.com/jay-goyal/snek-game written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jay-goyal/snek-game on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2987e5e10fa9a33ddb1beafe1a512a0d28f72647d019fed56ccc9a9330141dd4 [INFO] running `Command { std: "docker" "start" "-a" "2987e5e10fa9a33ddb1beafe1a512a0d28f72647d019fed56ccc9a9330141dd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2987e5e10fa9a33ddb1beafe1a512a0d28f72647d019fed56ccc9a9330141dd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2987e5e10fa9a33ddb1beafe1a512a0d28f72647d019fed56ccc9a9330141dd4", kill_on_drop: false }` [INFO] [stdout] 2987e5e10fa9a33ddb1beafe1a512a0d28f72647d019fed56ccc9a9330141dd4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c4a8777a766e3936ff11bfb0e337fda4a4485321a449cebe087a80ab45c508c7 [INFO] running `Command { std: "docker" "start" "-a" "c4a8777a766e3936ff11bfb0e337fda4a4485321a449cebe087a80ab45c508c7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling ncurses v5.101.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking pancurses v0.17.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking snek v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/users_and_scores.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | if player == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `player.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/users_and_scores.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn set_new_highscore(player: &String, highscore: u64) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - pub fn set_new_highscore(player: &String, highscore: u64) { [INFO] [stdout] 45 + pub fn set_new_highscore(player: &str, highscore: u64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:126:59 [INFO] [stdout] | [INFO] [stdout] 126 | if !(snake.body.contains(&food.coord)) && !(food.coord == snake.head) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(food.coord != snake.head)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/users_and_scores.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | if player == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `player.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/users_and_scores.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn set_new_highscore(player: &String, highscore: u64) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - pub fn set_new_highscore(player: &String, highscore: u64) { [INFO] [stdout] 45 + pub fn set_new_highscore(player: &str, highscore: u64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | ((my / 2) as i32, (mx / 4) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((my / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | ((my / 2) as i32, (mx / 4) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((mx / 4))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 55 | ((my / 2) as i32, (mx / 4 - 1) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((my / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:55:31 [INFO] [stdout] | [INFO] [stdout] 55 | ((my / 2) as i32, (mx / 4 - 1) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `((mx / 4 - 1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | ((my / 2) as i32, (mx / 4 - 2) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((my / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:56:31 [INFO] [stdout] | [INFO] [stdout] 56 | ((my / 2) as i32, (mx / 4 - 2) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `((mx / 4 - 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 62 | let mut food = Food::new((my / 2) as i32, (mx / 2) as i32); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((my / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:62:47 [INFO] [stdout] | [INFO] [stdout] 62 | let mut food = Food::new((my / 2) as i32, (mx / 2) as i32); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((mx / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/main.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | let player_name = match env::args().nth(1) { [INFO] [stdout] | _______________________^ [INFO] [stdout] 75 | | Some(name) => name, [INFO] [stdout] 76 | | None => String::from(""), [INFO] [stdout] 77 | | }; [INFO] [stdout] | |_____^ help: replace it with: `env::args().nth(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | if player_name == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `player_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:126:59 [INFO] [stdout] | [INFO] [stdout] 126 | if !(snake.body.contains(&food.coord)) && !(food.coord == snake.head) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(food.coord != snake.head)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:81:41 [INFO] [stdout] | [INFO] [stdout] 81 | window.mvprintw(1, mx / 2 - 10, format!("PLAYING ANONYMUSLY")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PLAYING ANONYMUSLY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if player_name != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!player_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | ((my / 2) as i32, (mx / 4) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((my / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | ((my / 2) as i32, (mx / 4) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((mx / 4))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 55 | ((my / 2) as i32, (mx / 4 - 1) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((my / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:55:31 [INFO] [stdout] | [INFO] [stdout] 55 | ((my / 2) as i32, (mx / 4 - 1) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `((mx / 4 - 1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 56 | ((my / 2) as i32, (mx / 4 - 2) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((my / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:56:31 [INFO] [stdout] | [INFO] [stdout] 56 | ((my / 2) as i32, (mx / 4 - 2) as i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `((mx / 4 - 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 62 | let mut food = Food::new((my / 2) as i32, (mx / 2) as i32); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((my / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:62:47 [INFO] [stdout] | [INFO] [stdout] 62 | let mut food = Food::new((my / 2) as i32, (mx / 2) as i32); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `((mx / 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:108:37 [INFO] [stdout] | [INFO] [stdout] 108 | window.mvprintw(1, mx - 15, format!("Press Q to quit")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Press Q to quit".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/main.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | let player_name = match env::args().nth(1) { [INFO] [stdout] | _______________________^ [INFO] [stdout] 75 | | Some(name) => name, [INFO] [stdout] 76 | | None => String::from(""), [INFO] [stdout] 77 | | }; [INFO] [stdout] | |_____^ help: replace it with: `env::args().nth(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | if player_name == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `player_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:81:41 [INFO] [stdout] | [INFO] [stdout] 81 | window.mvprintw(1, mx / 2 - 10, format!("PLAYING ANONYMUSLY")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PLAYING ANONYMUSLY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if player_name != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!player_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:108:37 [INFO] [stdout] | [INFO] [stdout] 108 | window.mvprintw(1, mx - 15, format!("Press Q to quit")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Press Q to quit".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:150:28 [INFO] [stdout] | [INFO] [stdout] 150 | if (new_highscore) && (player_name != "") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!player_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:150:28 [INFO] [stdout] | [INFO] [stdout] 150 | if (new_highscore) && (player_name != "") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!player_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.75s [INFO] running `Command { std: "docker" "inspect" "c4a8777a766e3936ff11bfb0e337fda4a4485321a449cebe087a80ab45c508c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4a8777a766e3936ff11bfb0e337fda4a4485321a449cebe087a80ab45c508c7", kill_on_drop: false }` [INFO] [stdout] c4a8777a766e3936ff11bfb0e337fda4a4485321a449cebe087a80ab45c508c7