[INFO] cloning repository https://github.com/jaropis/rust_rr_tools
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jaropis/rust_rr_tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjaropis%2Frust_rr_tools", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjaropis%2Frust_rr_tools'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 00c269afe0fbecac0216c1812078dd5c8e0f18f7
[INFO] linting jaropis/rust_rr_tools against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjaropis%2Frust_rr_tools" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/jaropis/rust_rr_tools
[INFO] finished tweaking git repo https://github.com/jaropis/rust_rr_tools
[INFO] tweaked toml for git repo https://github.com/jaropis/rust_rr_tools written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/jaropis/rust_rr_tools on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/jaropis/rust_rr_tools already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] dd1dc0b9a4ad73946ebc6c8911576dc5297055b6fadba64e91a2abfb919f1a48
[INFO] running `Command { std: "docker" "start" "-a" "dd1dc0b9a4ad73946ebc6c8911576dc5297055b6fadba64e91a2abfb919f1a48", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "dd1dc0b9a4ad73946ebc6c8911576dc5297055b6fadba64e91a2abfb919f1a48", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "dd1dc0b9a4ad73946ebc6c8911576dc5297055b6fadba64e91a2abfb919f1a48", kill_on_drop: false }`
[INFO] [stdout] dd1dc0b9a4ad73946ebc6c8911576dc5297055b6fadba64e91a2abfb919f1a48
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 61e8a82bf13c934598b011bea097529293a0a5f03b793b3b7e26fdc4c24490d7
[INFO] running `Command { std: "docker" "start" "-a" "61e8a82bf13c934598b011bea097529293a0a5f03b793b3b7e26fdc4c24490d7", kill_on_drop: false }`
[INFO] [stderr]     Checking rust_rr_tools v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:33:21
[INFO] [stdout]    |
[INFO] [stdout] 33 | fn parse_args(argv: &Vec<String>) -> Arguments {
[INFO] [stdout]    |                     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 33 - fn parse_args(argv: &Vec<String>) -> Arguments {
[INFO] [stdout] 33 + fn parse_args(argv: &[String]) -> Arguments {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:40:5
[INFO] [stdout]    |
[INFO] [stdout] 40 |     let sampling_rate: f32;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `sampling_rate` here and remove the assignments from the branches
[INFO] [stdout]    |
[INFO] [stdout] 40 ~     
[INFO] [stdout] 41 |     let owned_scout = &argv[6].to_string();
[INFO] [stdout] ...
[INFO] [stdout] 44 |     let correct = owned_correct.parse::<bool>().unwrap();
[INFO] [stdout] 45 ~     let sampling_rate: f32 = if argv.len() == 9 {
[INFO] [stdout] 46 |         let owned_sampling_rate = &argv[8].to_string();
[INFO] [stdout] 47 ~         owned_sampling_rate.parse::<f32>().unwrap()
[INFO] [stdout] 48 |     } else {
[INFO] [stdout] 49 ~         0.0
[INFO] [stdout] 50 ~     };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:63:41
[INFO] [stdout]    |
[INFO] [stdout] 63 | fn correct_processed_rr_intervals(data: &mut Vec<Vec<String>>) {
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 63 - fn correct_processed_rr_intervals(data: &mut Vec<Vec<String>>) {
[INFO] [stdout] 63 + fn correct_processed_rr_intervals(data: &mut [Vec<String>]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:171:16
[INFO] [stdout]     |
[INFO] [stdout] 171 |             if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 171 -             if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout] 171 +             if !(args.diff && rr_idx <= args.skip) {
[INFO] [stdout]     |
[INFO] [stdout] 171 -             if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout] 171 +             if !args.diff || rr_idx > args.skip {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:175:12
[INFO] [stdout]     |
[INFO] [stdout] 175 |         if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 175 -         if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout] 175 +         if !(args.diff && rr_idx <= args.skip) {
[INFO] [stdout]     |
[INFO] [stdout] 175 -         if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout] 175 +         if !args.diff || rr_idx > args.skip {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:207:62
[INFO] [stdout]     |
[INFO] [stdout] 207 |             let (mut contents, new_annotations) = read_lines(&entry_path.to_str().unwrap(), &args);
[INFO] [stdout]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `entry_path.to_str().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:221:17
[INFO] [stdout]     |
[INFO] [stdout] 221 |                 &entry_path.to_str().unwrap(),
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `entry_path.to_str().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:222:17
[INFO] [stdout]     |
[INFO] [stdout] 222 |                 &args.output_extension,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `args.output_extension`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/main.rs:33:21
[INFO] [stdout]    |
[INFO] [stdout] 33 | fn parse_args(argv: &Vec<String>) -> Arguments {
[INFO] [stdout]    |                     ^^^^^^^^^^^^     ^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 33 | fn parse_args(argv: &Vec<String>) -> Arguments<'_> {
[INFO] [stdout]    |                                               ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:33:21
[INFO] [stdout]    |
[INFO] [stdout] 33 | fn parse_args(argv: &Vec<String>) -> Arguments {
[INFO] [stdout]    |                     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 33 - fn parse_args(argv: &Vec<String>) -> Arguments {
[INFO] [stdout] 33 + fn parse_args(argv: &[String]) -> Arguments {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:40:5
[INFO] [stdout]    |
[INFO] [stdout] 40 |     let sampling_rate: f32;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `sampling_rate` here and remove the assignments from the branches
[INFO] [stdout]    |
[INFO] [stdout] 40 ~     
[INFO] [stdout] 41 |     let owned_scout = &argv[6].to_string();
[INFO] [stdout] ...
[INFO] [stdout] 44 |     let correct = owned_correct.parse::<bool>().unwrap();
[INFO] [stdout] 45 ~     let sampling_rate: f32 = if argv.len() == 9 {
[INFO] [stdout] 46 |         let owned_sampling_rate = &argv[8].to_string();
[INFO] [stdout] 47 ~         owned_sampling_rate.parse::<f32>().unwrap()
[INFO] [stdout] 48 |     } else {
[INFO] [stdout] 49 ~         0.0
[INFO] [stdout] 50 ~     };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:63:41
[INFO] [stdout]    |
[INFO] [stdout] 63 | fn correct_processed_rr_intervals(data: &mut Vec<Vec<String>>) {
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 63 - fn correct_processed_rr_intervals(data: &mut Vec<Vec<String>>) {
[INFO] [stdout] 63 + fn correct_processed_rr_intervals(data: &mut [Vec<String>]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:171:16
[INFO] [stdout]     |
[INFO] [stdout] 171 |             if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 171 -             if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout] 171 +             if !(args.diff && rr_idx <= args.skip) {
[INFO] [stdout]     |
[INFO] [stdout] 171 -             if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout] 171 +             if !args.diff || rr_idx > args.skip {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:175:12
[INFO] [stdout]     |
[INFO] [stdout] 175 |         if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 175 -         if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout] 175 +         if !(args.diff && rr_idx <= args.skip) {
[INFO] [stdout]     |
[INFO] [stdout] 175 -         if (args.diff && rr_idx > args.skip) || (!args.diff) {
[INFO] [stdout] 175 +         if !args.diff || rr_idx > args.skip {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:207:62
[INFO] [stdout]     |
[INFO] [stdout] 207 |             let (mut contents, new_annotations) = read_lines(&entry_path.to_str().unwrap(), &args);
[INFO] [stdout]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `entry_path.to_str().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:221:17
[INFO] [stdout]     |
[INFO] [stdout] 221 |                 &entry_path.to_str().unwrap(),
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `entry_path.to_str().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:222:17
[INFO] [stdout]     |
[INFO] [stdout] 222 |                 &args.output_extension,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `args.output_extension`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/main.rs:33:21
[INFO] [stdout]    |
[INFO] [stdout] 33 | fn parse_args(argv: &Vec<String>) -> Arguments {
[INFO] [stdout]    |                     ^^^^^^^^^^^^     ^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 33 | fn parse_args(argv: &Vec<String>) -> Arguments<'_> {
[INFO] [stdout]    |                                               ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s
[INFO] running `Command { std: "docker" "inspect" "61e8a82bf13c934598b011bea097529293a0a5f03b793b3b7e26fdc4c24490d7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "61e8a82bf13c934598b011bea097529293a0a5f03b793b3b7e26fdc4c24490d7", kill_on_drop: false }`
[INFO] [stdout] 61e8a82bf13c934598b011bea097529293a0a5f03b793b3b7e26fdc4c24490d7