[INFO] cloning repository https://github.com/jamesma100/inverted-index [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jamesma100/inverted-index" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjamesma100%2Finverted-index", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjamesma100%2Finverted-index'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 95795335043a7c4a733a876e9b0272208b33494c [INFO] linting jamesma100/inverted-index against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjamesma100%2Finverted-index" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jamesma100/inverted-index [INFO] finished tweaking git repo https://github.com/jamesma100/inverted-index [INFO] tweaked toml for git repo https://github.com/jamesma100/inverted-index written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jamesma100/inverted-index on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jamesma100/inverted-index already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22dae418a45110af4f0a13bb0357eba54111677cc5f08e9bb0bc98061abe2b87 [INFO] running `Command { std: "docker" "start" "-a" "22dae418a45110af4f0a13bb0357eba54111677cc5f08e9bb0bc98061abe2b87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22dae418a45110af4f0a13bb0357eba54111677cc5f08e9bb0bc98061abe2b87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22dae418a45110af4f0a13bb0357eba54111677cc5f08e9bb0bc98061abe2b87", kill_on_drop: false }` [INFO] [stdout] 22dae418a45110af4f0a13bb0357eba54111677cc5f08e9bb0bc98061abe2b87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd01daf24bcf4ca20a3bc01231b6b39827bcacd9029d9213f1f1619da5da9cf9 [INFO] running `Command { std: "docker" "start" "-a" "dd01daf24bcf4ca20a3bc01231b6b39827bcacd9029d9213f1f1619da5da9cf9", kill_on_drop: false }` [INFO] [stderr] Checking inv-idx v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/main.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | hm.entry(word.to_owned()).or_insert(Vec::new()).push(doc.to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 44 | for (_, pos) in hm { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 44 - for (_, pos) in hm { [INFO] [stdout] 44 + for pos in hm.values_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | if !opt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `opt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/main.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | hm.entry(word.to_owned()).or_insert(Vec::new()).push(doc.to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 44 | for (_, pos) in hm { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 44 - for (_, pos) in hm { [INFO] [stdout] 44 + for pos in hm.values_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | if !opt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `opt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opt` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 52 | if !opt.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 53 | let docs = opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opt` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 52 | if !opt.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 53 | let docs = opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.15s [INFO] running `Command { std: "docker" "inspect" "dd01daf24bcf4ca20a3bc01231b6b39827bcacd9029d9213f1f1619da5da9cf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd01daf24bcf4ca20a3bc01231b6b39827bcacd9029d9213f1f1619da5da9cf9", kill_on_drop: false }` [INFO] [stdout] dd01daf24bcf4ca20a3bc01231b6b39827bcacd9029d9213f1f1619da5da9cf9