[INFO] cloning repository https://github.com/jakyle/rust-algos [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jakyle/rust-algos" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakyle%2Frust-algos", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakyle%2Frust-algos'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a116745ec5efb4a2aa4edf0bc11ee1963173f076 [INFO] linting jakyle/rust-algos against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakyle%2Frust-algos" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jakyle/rust-algos [INFO] finished tweaking git repo https://github.com/jakyle/rust-algos [INFO] tweaked toml for git repo https://github.com/jakyle/rust-algos written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jakyle/rust-algos on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jakyle/rust-algos already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf79295575ec2cb9d36786e2735137e4455099a6f972d80324222eabc68cf897 [INFO] running `Command { std: "docker" "start" "-a" "bf79295575ec2cb9d36786e2735137e4455099a6f972d80324222eabc68cf897", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf79295575ec2cb9d36786e2735137e4455099a6f972d80324222eabc68cf897", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf79295575ec2cb9d36786e2735137e4455099a6f972d80324222eabc68cf897", kill_on_drop: false }` [INFO] [stdout] bf79295575ec2cb9d36786e2735137e4455099a6f972d80324222eabc68cf897 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c57e55ff60dde774ba979433ad36e4b5695cc5f2351bda85bea7649f59e163e5 [INFO] running `Command { std: "docker" "start" "-a" "c57e55ff60dde774ba979433ad36e4b5695cc5f2351bda85bea7649f59e163e5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking getrandom v0.2.2 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking rust_algos v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/balanced_string_split.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | / /// s is a balanced string. [INFO] [stdout] 43 | | [INFO] [stdout] | |_^ [INFO] [stdout] 44 | pub fn balanced_string_split(s: String) -> i32 { [INFO] [stdout] | ---------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! 1221. Split a String in Balanced Strings [INFO] [stdout] 2 ~ //! Easy [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Balanced strings are those that have an equal quantity of 'L' and 'R' characters. [INFO] [stdout] 5 ~ //! [INFO] [stdout] 6 ~ //! Given a balanced string s, split it in the maximum amount of balanced strings. [INFO] [stdout] 7 ~ //! [INFO] [stdout] 8 ~ //! Return the maximum amount of split balanced strings. [INFO] [stdout] 9 ~ //! [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! [INFO] [stdout] 12 ~ //! Example 1: [INFO] [stdout] 13 ~ //! [INFO] [stdout] 14 ~ //! Input: s = "RLRRLLRLRL" [INFO] [stdout] 15 ~ //! Output: 4 [INFO] [stdout] 16 ~ //! Explanation: s can be split into "RL", "RRLL", "RL", "RL", each substring contains same number of 'L' and 'R'. [INFO] [stdout] 17 ~ //! [INFO] [stdout] 18 ~ //! Example 2: [INFO] [stdout] 19 ~ //! [INFO] [stdout] 20 ~ //! Input: s = "RLLLLRRRLR" [INFO] [stdout] 21 ~ //! Output: 3 [INFO] [stdout] 22 ~ //! Explanation: s can be split into "RL", "LLLRRR", "LR", each substring contains same number of 'L' and 'R'. [INFO] [stdout] 23 ~ //! [INFO] [stdout] 24 ~ //! Example 3: [INFO] [stdout] 25 ~ //! [INFO] [stdout] 26 ~ //! Input: s = "LLLLRRRR" [INFO] [stdout] 27 ~ //! Output: 1 [INFO] [stdout] 28 ~ //! Explanation: s can be split into "LLLLRRRR". [INFO] [stdout] 29 ~ //! [INFO] [stdout] 30 ~ //! Example 4: [INFO] [stdout] 31 ~ //! [INFO] [stdout] 32 ~ //! Input: s = "RLRRRLLRLL" [INFO] [stdout] 33 ~ //! Output: 2 [INFO] [stdout] 34 ~ //! Explanation: s can be split into "RL", "RRRLLRLL", since each substring contains an equal number of 'L' and 'R' [INFO] [stdout] 35 ~ //! [INFO] [stdout] 36 ~ //! [INFO] [stdout] 37 ~ //! [INFO] [stdout] 38 ~ //! Constraints: [INFO] [stdout] 39 ~ //! [INFO] [stdout] 40 ~ //! 1 <= s.length <= 1000 [INFO] [stdout] 41 ~ //! s[i] is either 'L' or 'R'. [INFO] [stdout] 42 ~ //! s is a balanced string. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/balanced_string_split.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | / /// s is a balanced string. [INFO] [stdout] 43 | | [INFO] [stdout] | |_^ [INFO] [stdout] 44 | pub fn balanced_string_split(s: String) -> i32 { [INFO] [stdout] | ---------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! 1221. Split a String in Balanced Strings [INFO] [stdout] 2 ~ //! Easy [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Balanced strings are those that have an equal quantity of 'L' and 'R' characters. [INFO] [stdout] 5 ~ //! [INFO] [stdout] 6 ~ //! Given a balanced string s, split it in the maximum amount of balanced strings. [INFO] [stdout] 7 ~ //! [INFO] [stdout] 8 ~ //! Return the maximum amount of split balanced strings. [INFO] [stdout] 9 ~ //! [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! [INFO] [stdout] 12 ~ //! Example 1: [INFO] [stdout] 13 ~ //! [INFO] [stdout] 14 ~ //! Input: s = "RLRRLLRLRL" [INFO] [stdout] 15 ~ //! Output: 4 [INFO] [stdout] 16 ~ //! Explanation: s can be split into "RL", "RRLL", "RL", "RL", each substring contains same number of 'L' and 'R'. [INFO] [stdout] 17 ~ //! [INFO] [stdout] 18 ~ //! Example 2: [INFO] [stdout] 19 ~ //! [INFO] [stdout] 20 ~ //! Input: s = "RLLLLRRRLR" [INFO] [stdout] 21 ~ //! Output: 3 [INFO] [stdout] 22 ~ //! Explanation: s can be split into "RL", "LLLRRR", "LR", each substring contains same number of 'L' and 'R'. [INFO] [stdout] 23 ~ //! [INFO] [stdout] 24 ~ //! Example 3: [INFO] [stdout] 25 ~ //! [INFO] [stdout] 26 ~ //! Input: s = "LLLLRRRR" [INFO] [stdout] 27 ~ //! Output: 1 [INFO] [stdout] 28 ~ //! Explanation: s can be split into "LLLLRRRR". [INFO] [stdout] 29 ~ //! [INFO] [stdout] 30 ~ //! Example 4: [INFO] [stdout] 31 ~ //! [INFO] [stdout] 32 ~ //! Input: s = "RLRRRLLRLL" [INFO] [stdout] 33 ~ //! Output: 2 [INFO] [stdout] 34 ~ //! Explanation: s can be split into "RL", "RRRLLRLL", since each substring contains an equal number of 'L' and 'R' [INFO] [stdout] 35 ~ //! [INFO] [stdout] 36 ~ //! [INFO] [stdout] 37 ~ //! [INFO] [stdout] 38 ~ //! Constraints: [INFO] [stdout] 39 ~ //! [INFO] [stdout] 40 ~ //! 1 <= s.length <= 1000 [INFO] [stdout] 41 ~ //! s[i] is either 'L' or 'R'. [INFO] [stdout] 42 ~ //! s is a balanced string. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `count_points` is never used [INFO] [stdout] --> src/count_points.rs:1:4 [INFO] [stdout] | [INFO] [stdout] 1 | fn count_points(points: Vec>, queries: Vec>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/merge_two_lists.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl ListNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 8 | #[inline] [INFO] [stdout] 9 | fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParkingSystem` is never constructed [INFO] [stdout] --> src/parking_system.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct ParkingSystem { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `add_car` are never used [INFO] [stdout] --> src/parking_system.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | impl ParkingSystem { [INFO] [stdout] | ------------------ associated items in this implementation [INFO] [stdout] 10 | fn new(big: i32, medium: i32, small: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | fn add_car(mut self, car_type: i32) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width` and `matrix` are never read [INFO] [stdout] --> src/sub_rectangle_queries.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct SubRectangleQueries { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] 2 | width: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 3 | matrix: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `update_subrectangle`, `get_value`, and `xy_idx` are never used [INFO] [stdout] --> src/sub_rectangle_queries.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 6 | impl SubRectangleQueries { [INFO] [stdout] | ------------------------ associated items in this implementation [INFO] [stdout] 7 | fn new(rectangle: Vec>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | fn update_subrectangle(&mut self, row1: i32, col1: i32, row2: i32, col2: i32, new_value: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | fn get_value(&self, row: i32, col: i32) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | fn xy_idx(&self, x: i32, y: i32) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/balanced_string_split.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | /// Easy [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2 | /// Easy [INFO] [stdout] | ++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/common_chars.rs:16:36 [INFO] [stdout] | [INFO] [stdout] 16 | let test_map = char_maps.pop().unwrap_or(HashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/common_chars.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | let mut x = num.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/deepest_leaves_sum.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | count(left, &mut sum, depth + 1, best_depth); [INFO] [stdout] | ^^^^^^^^ help: change this to: `sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/deepest_leaves_sum.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | count(right, &mut sum, depth + 1, best_depth); [INFO] [stdout] | ^^^^^^^^ help: change this to: `sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/find_special_integer.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | kvp_arr.sort_by(|x, y| y.1.cmp(&x.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 14 - kvp_arr.sort_by(|x, y| y.1.cmp(&x.1)); [INFO] [stdout] 14 + kvp_arr.sort_by_key(|y| std::cmp::Reverse(y.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/move_zeroes.rs:1:26 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn move_zeroes(nums: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn move_zeroes(nums: &mut Vec) { [INFO] [stdout] 1 + pub fn move_zeroes(nums: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/rotate.rs:1:21 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn rotate(nums: &mut Vec, k: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn rotate(nums: &mut Vec, k: i32) { [INFO] [stdout] 1 + pub fn rotate(nums: &mut [i32], k: i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/self_dividing_number.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if !(num % x == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(num % x != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `mat` [INFO] [stdout] --> src/update_matrix.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for x in 0..width { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 5 - for x in 0..width { [INFO] [stdout] 5 + for (x, ) in mat.iter().enumerate().take(width) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `mat` [INFO] [stdout] --> src/update_matrix.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | for y in 0..height { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 6 - for y in 0..height { [INFO] [stdout] 6 + for (y, ) in mat.iter().enumerate().take(height) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/find_words.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | let rows = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 20 | | hashset! {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'}, [INFO] [stdout] 21 | | hashset! {'a', 's', 'd', 'f', 'g', 'h', 'j', 'k', 'l'}, [INFO] [stdout] 22 | | hashset! {'z', 'x', 'c', 'v', 'b', 'n', 'm'}, [INFO] [stdout] 23 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 19 ~ let rows = [hashset! {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'}, [INFO] [stdout] 20 + hashset! {'a', 's', 'd', 'f', 'g', 'h', 'j', 'k', 'l'}, [INFO] [stdout] 21 ~ hashset! {'z', 'x', 'c', 'v', 'b', 'n', 'm'}]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `count_points` is never used [INFO] [stdout] --> src/count_points.rs:1:4 [INFO] [stdout] | [INFO] [stdout] 1 | fn count_points(points: Vec>, queries: Vec>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/merge_two_lists.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl ListNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 8 | #[inline] [INFO] [stdout] 9 | fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `min_operations_test_one` is never used [INFO] [stdout] --> src/min_operations.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | fn min_operations_test_one() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParkingSystem` is never constructed [INFO] [stdout] --> src/parking_system.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct ParkingSystem { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `add_car` are never used [INFO] [stdout] --> src/parking_system.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | impl ParkingSystem { [INFO] [stdout] | ------------------ associated items in this implementation [INFO] [stdout] 10 | fn new(big: i32, medium: i32, small: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | fn add_car(mut self, car_type: i32) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/array_strings_are_equal.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 52 - assert_eq!(result, true); [INFO] [stdout] 52 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/balanced_string_split.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | /// Easy [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 2 | /// Easy [INFO] [stdout] | ++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/buddy_strings.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(result, true); [INFO] [stdout] 30 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/buddy_strings.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!(result, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 43 - assert_eq!(result, false); [INFO] [stdout] 43 + assert!(!result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/buddy_strings.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 56 - assert_eq!(result, true); [INFO] [stdout] 56 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/check_inclusion.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | assert_eq!(check_inclusion("ab".into(), "eidbaooo".into()), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 34 - assert_eq!(check_inclusion("ab".into(), "eidbaooo".into()), true); [INFO] [stdout] 34 + assert!(check_inclusion("ab".into(), "eidbaooo".into())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/check_inclusion.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | assert_eq!(check_inclusion("abc".into(), "ccccbbbbaaaa".into()), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 39 - assert_eq!(check_inclusion("abc".into(), "ccccbbbbaaaa".into()), false); [INFO] [stdout] 39 + assert!(!check_inclusion("abc".into(), "ccccbbbbaaaa".into())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/check_perfect_number.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 36 - assert_eq!(result, true); [INFO] [stdout] 36 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/common_chars.rs:16:36 [INFO] [stdout] | [INFO] [stdout] 16 | let test_map = char_maps.pop().unwrap_or(HashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/common_chars.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | let mut x = num.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/deepest_leaves_sum.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | count(left, &mut sum, depth + 1, best_depth); [INFO] [stdout] | ^^^^^^^^ help: change this to: `sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/deepest_leaves_sum.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | count(right, &mut sum, depth + 1, best_depth); [INFO] [stdout] | ^^^^^^^^ help: change this to: `sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/find_special_integer.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | kvp_arr.sort_by(|x, y| y.1.cmp(&x.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 14 - kvp_arr.sort_by(|x, y| y.1.cmp(&x.1)); [INFO] [stdout] 14 + kvp_arr.sort_by_key(|y| std::cmp::Reverse(y.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/is_palindrome.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 24 - assert_eq!(result, true); [INFO] [stdout] 24 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/is_palindrome.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | assert_eq!(result, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 36 - assert_eq!(result, false); [INFO] [stdout] 36 + assert!(!result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/is_power_of_four.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 18 - assert_eq!(result, true); [INFO] [stdout] 18 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/is_power_of_four.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(result, true); [INFO] [stdout] 30 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/is_same_tree.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | assert_eq!(is_same_tree(node_one, node_two), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 82 - assert_eq!(is_same_tree(node_one, node_two), true); [INFO] [stdout] 82 + assert!(is_same_tree(node_one, node_two)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/move_zeroes.rs:1:26 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn move_zeroes(nums: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn move_zeroes(nums: &mut Vec) { [INFO] [stdout] 1 + pub fn move_zeroes(nums: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/rotate.rs:1:21 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn rotate(nums: &mut Vec, k: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn rotate(nums: &mut Vec, k: i32) { [INFO] [stdout] 1 + pub fn rotate(nums: &mut [i32], k: i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/self_dividing_number.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if !(num % x == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(num % x != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/unique_occurrences.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 25 - assert_eq!(result, true); [INFO] [stdout] 25 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/unique_occurrences.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 37 - assert_eq!(result, true); [INFO] [stdout] 37 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/unique_occurrences.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | assert_eq!(result, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 49 - assert_eq!(result, false); [INFO] [stdout] 49 + assert!(!result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `mat` [INFO] [stdout] --> src/update_matrix.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for x in 0..width { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 5 - for x in 0..width { [INFO] [stdout] 5 + for (x, ) in mat.iter().enumerate().take(width) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `mat` [INFO] [stdout] --> src/update_matrix.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | for y in 0..height { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 6 - for y in 0..height { [INFO] [stdout] 6 + for (y, ) in mat.iter().enumerate().take(height) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/word_pattern.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 38 - assert_eq!(result, true); [INFO] [stdout] 38 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/word_pattern.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | assert_eq!(result, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 51 - assert_eq!(result, false); [INFO] [stdout] 51 + assert!(!result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/word_pattern.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | assert_eq!(result, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 64 - assert_eq!(result, false); [INFO] [stdout] 64 + assert!(!result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/find_words.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | let rows = vec![ [INFO] [stdout] | ________________^ [INFO] [stdout] 20 | | hashset! {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'}, [INFO] [stdout] 21 | | hashset! {'a', 's', 'd', 'f', 'g', 'h', 'j', 'k', 'l'}, [INFO] [stdout] 22 | | hashset! {'z', 'x', 'c', 'v', 'b', 'n', 'm'}, [INFO] [stdout] 23 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 19 ~ let rows = [hashset! {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'}, [INFO] [stdout] 20 + hashset! {'a', 's', 'd', 'f', 'g', 'h', 'j', 'k', 'l'}, [INFO] [stdout] 21 ~ hashset! {'z', 'x', 'c', 'v', 'b', 'n', 'm'}]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.53s [INFO] running `Command { std: "docker" "inspect" "c57e55ff60dde774ba979433ad36e4b5695cc5f2351bda85bea7649f59e163e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c57e55ff60dde774ba979433ad36e4b5695cc5f2351bda85bea7649f59e163e5", kill_on_drop: false }` [INFO] [stdout] c57e55ff60dde774ba979433ad36e4b5695cc5f2351bda85bea7649f59e163e5