[INFO] cloning repository https://github.com/jakubbbdev/flow [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jakubbbdev/flow" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakubbbdev%2Fflow", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakubbbdev%2Fflow'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cb14ffe5848572dd598f7fdf25356cb01ccef087 [INFO] linting jakubbbdev/flow against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakubbbdev%2Fflow" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jakubbbdev/flow [INFO] finished tweaking git repo https://github.com/jakubbbdev/flow [INFO] tweaked toml for git repo https://github.com/jakubbbdev/flow written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jakubbbdev/flow on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jakubbbdev/flow already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-tar v0.3.1 [INFO] [stderr] Downloaded structmeta-derive v0.3.0 [INFO] [stderr] Downloaded structmeta v0.3.0 [INFO] [stderr] Downloaded parse-display-derive v0.9.1 [INFO] [stderr] Downloaded docker_credential v1.3.2 [INFO] [stderr] Downloaded tucana v0.0.31 [INFO] [stderr] Downloaded parse-display v0.9.1 [INFO] [stderr] Downloaded p12-keystore v0.1.5 [INFO] [stderr] Downloaded rustls-connector v0.21.7 [INFO] [stderr] Downloaded amq-protocol-tcp v8.1.2 [INFO] [stderr] Downloaded tcp-stream v0.30.1 [INFO] [stderr] Downloaded amq-protocol v8.1.2 [INFO] [stderr] Downloaded amq-protocol-types v8.1.2 [INFO] [stderr] Downloaded amq-protocol-uri v8.1.2 [INFO] [stderr] Downloaded async-global-executor-trait v2.2.0 [INFO] [stderr] Downloaded testcontainers v0.24.0 [INFO] [stderr] Downloaded async-reactor-trait v2.0.0 [INFO] [stderr] Downloaded reactor-trait v2.0.0 [INFO] [stderr] Downloaded executor-trait v2.1.2 [INFO] [stderr] Downloaded lapin v3.0.0 [INFO] [stderr] Downloaded async-std v1.13.1 [INFO] [stderr] Downloaded aws-lc-rs v1.13.1 [INFO] [stderr] Downloaded redis v0.32.3 [INFO] [stderr] Downloaded tokio v1.46.0 [INFO] [stderr] Downloaded aws-lc-sys v0.29.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2d8465f8237dd5afd6d08896d4946d7b88af32e31e37bea6b0f33b89321b9111 [INFO] running `Command { std: "docker" "start" "-a" "2d8465f8237dd5afd6d08896d4946d7b88af32e31e37bea6b0f33b89321b9111", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2d8465f8237dd5afd6d08896d4946d7b88af32e31e37bea6b0f33b89321b9111", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d8465f8237dd5afd6d08896d4946d7b88af32e31e37bea6b0f33b89321b9111", kill_on_drop: false }` [INFO] [stdout] 2d8465f8237dd5afd6d08896d4946d7b88af32e31e37bea6b0f33b89321b9111 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4fd49d333420915add371256e1c3813ac0d1a8b8ac753ce1613d1603f25da21 [INFO] running `Command { std: "docker" "start" "-a" "f4fd49d333420915add371256e1c3813ac0d1a8b8ac753ce1613d1603f25da21", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Compiling cc v1.2.21 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Compiling aws-lc-rs v1.13.1 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking value-bag v1.11.1 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling rustls v0.23.27 [INFO] [stderr] Checking flagset v0.4.7 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking rustls-native-certs v0.8.1 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking rc2 v0.8.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking cookie-factory v0.3.3 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Checking axum-core v0.5.2 [INFO] [stderr] Compiling amq-protocol v8.1.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Compiling lapin v3.0.0 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling aws-lc-sys v0.29.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking etcetera v0.10.0 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking xattr v1.5.0 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking tokio v1.46.0 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling der_derive v0.7.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Compiling asn1-rs-impl v0.2.0 [INFO] [stderr] Compiling asn1-rs-derive v0.6.0 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking asn1-rs v0.7.1 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking x509-cert v0.2.5 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking cms v0.2.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling prost-derive v0.13.5 [INFO] [stderr] Checking der-parser v10.0.0 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking oid-registry v0.8.1 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking pkcs12 v0.1.0 [INFO] [stderr] Checking x509-parser v0.17.0 [INFO] [stderr] Checking h2 v0.4.10 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling serde_with_macros v3.12.0 [INFO] [stderr] Checking prost v0.13.5 [INFO] [stderr] Checking p12-keystore v0.1.5 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling structmeta-derive v0.3.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking executor-trait v2.1.2 [INFO] [stderr] Checking reactor-trait v2.0.0 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-global-executor v3.1.0 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking async-std v1.13.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking axum v0.8.4 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking serde_with v3.12.0 [INFO] [stderr] Checking amq-protocol-types v8.1.2 [INFO] [stderr] Compiling structmeta v0.3.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling parse-display-derive v0.9.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking amq-protocol-uri v8.1.2 [INFO] [stderr] Checking async-global-executor-trait v2.2.0 [INFO] [stderr] Checking async-reactor-trait v2.0.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking prost-types v0.13.5 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking docker_credential v1.3.2 [INFO] [stderr] Checking tokio-tar v0.3.1 [INFO] [stderr] Checking hyper-util v0.1.11 [INFO] [stderr] Compiling serial_test_derive v3.2.0 [INFO] [stderr] Checking bollard-stubs v1.47.1-rc.27.3.1 [INFO] [stderr] Checking parse-display v0.9.1 [INFO] [stderr] Checking serial_test v3.2.0 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking hyperlocal v0.9.1 [INFO] [stderr] Checking tonic v0.13.1 [INFO] [stderr] Checking tucana v0.0.31 [INFO] [stderr] Checking redis v0.32.3 [INFO] [stderr] Checking rustls-webpki v0.103.2 [INFO] [stderr] Checking rustls-connector v0.21.7 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking tcp-stream v0.30.1 [INFO] [stderr] Checking hyper-rustls v0.27.5 [INFO] [stderr] Checking bollard v0.18.1 [INFO] [stderr] Checking amq-protocol-tcp v8.1.2 [INFO] [stderr] Checking flow v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking testcontainers v0.24.0 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/flow_store/flow_identifier.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | / if k == field_name { [INFO] [stdout] 12 | | if let Some(Kind::StringValue(s)) = &v.kind { [INFO] [stdout] 13 | | return Some(s.clone()); [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 11 ~ if k == field_name [INFO] [stdout] 12 ~ && let Some(Kind::StringValue(s)) = &v.kind { [INFO] [stdout] 13 | return Some(s.clone()); [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/flow_store/flow_identifier.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 42 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - _ => return None, [INFO] [stdout] 42 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `splitn` [INFO] [stdout] --> src/flow_store/service.rs:137:30 [INFO] [stdout] | [INFO] [stdout] 137 | let number = key.splitn(2, "::").next(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `key.split("::")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn [INFO] [stdout] = note: `#[warn(clippy::needless_splitn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/flow_queue/service.rs:178:57 [INFO] [stdout] | [INFO] [stdout] 178 | let message_str = match std::str::from_utf8(&data) { [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/flow_queue/service.rs:197:17 [INFO] [stdout] | [INFO] [stdout] 197 | / if ack_on_success { [INFO] [stdout] 198 | | if let Err(delivery_error) = delivery [INFO] [stdout] 199 | | .ack(lapin::options::BasicAckOptions::default()) [INFO] [stdout] 200 | | .await [INFO] [stdout] ... | [INFO] [stdout] 204 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 197 ~ if ack_on_success [INFO] [stdout] 198 ~ && let Err(delivery_error) = delivery [INFO] [stdout] 199 | .ack(lapin::options::BasicAckOptions::default()) [INFO] [stdout] ... [INFO] [stdout] 202 | log::error!("Failed to acknowledge message: {:?}", delivery_error); [INFO] [stdout] 203 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/flow_queue/service.rs:254:57 [INFO] [stdout] | [INFO] [stdout] 254 | let message_str = match std::str::from_utf8(&data) { [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/flow_store/flow_identifier.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | / if k == field_name { [INFO] [stdout] 12 | | if let Some(Kind::StringValue(s)) = &v.kind { [INFO] [stdout] 13 | | return Some(s.clone()); [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 11 ~ if k == field_name [INFO] [stdout] 12 ~ && let Some(Kind::StringValue(s)) = &v.kind { [INFO] [stdout] 13 | return Some(s.clone()); [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/flow_store/flow_identifier.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 42 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - _ => return None, [INFO] [stdout] 42 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `splitn` [INFO] [stdout] --> src/flow_store/service.rs:137:30 [INFO] [stdout] | [INFO] [stdout] 137 | let number = key.splitn(2, "::").next(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `key.split("::")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn [INFO] [stdout] = note: `#[warn(clippy::needless_splitn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/flow_store/service.rs:330:38 [INFO] [stdout] | [INFO] [stdout] 330 | serde_json::from_str(&*redis_result.unwrap()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&redis_result.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/flow_store/service.rs:349:21 [INFO] [stdout] | [INFO] [stdout] 349 | assert!(!service.insert_flow(flow.clone()).await.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `service.insert_flow(flow.clone()).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/flow_store/service.rs:396:32 [INFO] [stdout] | [INFO] [stdout] 396 | let string: &str = &*redis_result[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&redis_result[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/flow_queue/connection.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | build_connection(&*url).await; [INFO] [stdout] | ^^^^^ help: try: `&url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/flow_queue/service.rs:178:57 [INFO] [stdout] | [INFO] [stdout] 178 | let message_str = match std::str::from_utf8(&data) { [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/flow_queue/service.rs:197:17 [INFO] [stdout] | [INFO] [stdout] 197 | / if ack_on_success { [INFO] [stdout] 198 | | if let Err(delivery_error) = delivery [INFO] [stdout] 199 | | .ack(lapin::options::BasicAckOptions::default()) [INFO] [stdout] 200 | | .await [INFO] [stdout] ... | [INFO] [stdout] 204 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 197 ~ if ack_on_success [INFO] [stdout] 198 ~ && let Err(delivery_error) = delivery [INFO] [stdout] 199 | .ack(lapin::options::BasicAckOptions::default()) [INFO] [stdout] ... [INFO] [stdout] 202 | log::error!("Failed to acknowledge message: {:?}", delivery_error); [INFO] [stdout] 203 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/flow_queue/service.rs:254:57 [INFO] [stdout] | [INFO] [stdout] 254 | let message_str = match std::str::from_utf8(&data) { [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/flow_config/mod.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | assert_eq!(result, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 108 - assert_eq!(result, true); [INFO] [stdout] 108 + assert!(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/flow_config/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | assert_eq!(result, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 124 - assert_eq!(result, false); [INFO] [stdout] 124 + assert!(!result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/flow_config/mod.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | assert_eq!(result, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 153 - assert_eq!(result, false); [INFO] [stdout] 153 + assert!(!result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 53s [INFO] running `Command { std: "docker" "inspect" "f4fd49d333420915add371256e1c3813ac0d1a8b8ac753ce1613d1603f25da21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4fd49d333420915add371256e1c3813ac0d1a8b8ac753ce1613d1603f25da21", kill_on_drop: false }` [INFO] [stdout] f4fd49d333420915add371256e1c3813ac0d1a8b8ac753ce1613d1603f25da21