[INFO] cloning repository https://github.com/jakeec/compiler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jakeec/compiler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakeec%2Fcompiler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakeec%2Fcompiler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 23f1f872e93cc6cbc4a91550a5cc0a68ac3717f1 [INFO] linting jakeec/compiler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakeec%2Fcompiler" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jakeec/compiler [INFO] finished tweaking git repo https://github.com/jakeec/compiler [INFO] tweaked toml for git repo https://github.com/jakeec/compiler written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jakeec/compiler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jakeec/compiler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memchr v2.3.2 [INFO] [stderr] Downloaded aho-corasick v0.7.8 [INFO] [stderr] Downloaded regex v1.3.4 [INFO] [stderr] Downloaded regex-syntax v0.6.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7c0fb0d80fbbb0ac6a31b22d2c960d3b0cf6e23357d616f2c36e37e882f8acd [INFO] running `Command { std: "docker" "start" "-a" "c7c0fb0d80fbbb0ac6a31b22d2c960d3b0cf6e23357d616f2c36e37e882f8acd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7c0fb0d80fbbb0ac6a31b22d2c960d3b0cf6e23357d616f2c36e37e882f8acd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7c0fb0d80fbbb0ac6a31b22d2c960d3b0cf6e23357d616f2c36e37e882f8acd", kill_on_drop: false }` [INFO] [stdout] c7c0fb0d80fbbb0ac6a31b22d2c960d3b0cf6e23357d616f2c36e37e882f8acd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0dfc81d9adb5033690fc542492fa99e5a18dbffe238432b75793c3b54be7f0a5 [INFO] running `Command { std: "docker" "start" "-a" "0dfc81d9adb5033690fc542492fa99e5a18dbffe238432b75793c3b54be7f0a5", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.2 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking aho-corasick v0.7.8 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking compiler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/assembly_interpreter.rs:421:9 [INFO] [stdout] | [INFO] [stdout] 421 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TestReader` [INFO] [stdout] --> src/compiler.rs:1:29 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::reader::{Reader, TestReader}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TestWriter` [INFO] [stdout] --> src/compiler.rs:2:21 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::writer::{TestWriter, Writer}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/compiler.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | reader: reader, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/compiler.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 287 | if (self.get_name() == String::from("else")) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 287 - if (self.get_name() == String::from("else")) { [INFO] [stdout] 287 + if self.get_name() == String::from("else") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StdinReader` [INFO] [stdout] --> src/main.rs:6:45 [INFO] [stdout] | [INFO] [stdout] 6 | use reader::{FileReader, Reader, ReaderArg, StdinReader}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Writer` [INFO] [stdout] --> src/main.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 8 | use writer::{StdoutWriter, Writer}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TestReader` [INFO] [stdout] --> src/compiler.rs:1:29 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::reader::{Reader, TestReader}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TestWriter` [INFO] [stdout] --> src/compiler.rs:2:21 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::writer::{TestWriter, Writer}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/compiler.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | reader: reader, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/compiler.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 287 | if (self.get_name() == String::from("else")) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 287 - if (self.get_name() == String::from("else")) { [INFO] [stdout] 287 + if self.get_name() == String::from("else") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StdinReader` [INFO] [stdout] --> src/main.rs:6:45 [INFO] [stdout] | [INFO] [stdout] 6 | use reader::{FileReader, Reader, ReaderArg, StdinReader}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Writer` [INFO] [stdout] --> src/main.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 8 | use writer::{StdoutWriter, Writer}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/assembly_interpreter.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | let mut instruction: Vec = instruction.chars().collect(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/assembly_interpreter.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut rands = &instruction[index..instruction.len()]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/assembly_interpreter.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | let mut instruction: Vec = instruction.chars().collect(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/assembly_interpreter.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut rands = &instruction[index..instruction.len()]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/compiler.rs:267:13 [INFO] [stdout] | [INFO] [stdout] 267 | for c in keyword.chars() {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `arg` [INFO] [stdout] --> src/reader.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 64 | fn read(&mut self, arg: ReaderArg) -> io::Result<()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_arg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/writer.rs:15:25 [INFO] [stdout] | [INFO] [stdout] 15 | fn write(&mut self, output: String) {} [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/writer.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | fn writeln(&mut self, output: String) {} [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AssemblyInterpreter` is never constructed [INFO] [stdout] --> src/assembly_interpreter.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct AssemblyInterpreter { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `AssemblyInterpreterError` is never used [INFO] [stdout] --> src/assembly_interpreter.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | pub enum AssemblyInterpreterError { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/assembly_interpreter.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 13 | impl AssemblyInterpreter { [INFO] [stdout] | ------------------------ associated items in this implementation [INFO] [stdout] 14 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | fn eval(&mut self, input: String) -> Result<(), AssemblyInterpreterError> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | fn process_instruction(&mut self, instruction: String) -> Result<(), AssemblyInterpreterError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | fn divs_op(&mut self, rands: &[char]) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | fn muls_op(&mut self, rands: &[char]) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 183 | fn neg_op(&mut self, rands: &[char]) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 240 | fn sub_op(&mut self, rands: &[char]) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 297 | fn add_op(&mut self, rands: &[char]) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 354 | fn move_op(&mut self, rands: &[char]) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `keyword` is never used [INFO] [stdout] --> src/compiler.rs:266:8 [INFO] [stdout] | [INFO] [stdout] 15 | impl<'a, R: Reader, W: Writer> Compiler<'a, R, W> { [INFO] [stdout] | ------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 266 | fn keyword(&mut self, keyword: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Raw` and `None` are never constructed [INFO] [stdout] --> src/reader.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum ReaderArg { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 6 | Raw(String), [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | FilePath(String), [INFO] [stdout] 8 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReaderArg` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `StdinReader` is never constructed [INFO] [stdout] --> src/reader.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct StdinReader { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TestReader` is never constructed [INFO] [stdout] --> src/reader.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct TestReader { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/reader.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 46 | impl StdinReader { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 47 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/reader.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 52 | impl TestReader { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 53 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TestWriter` is never constructed [INFO] [stdout] --> src/writer.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct TestWriter { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/writer.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 6 | impl TestWriter { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 7 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/compiler.rs:267:13 [INFO] [stdout] | [INFO] [stdout] 267 | for c in keyword.chars() {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/assembly_interpreter.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/compiler.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | let mut outputs = fs::read_to_string("./test_data/assembly_outputs.txt") [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `instruction` [INFO] [stdout] --> src/assembly_interpreter.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for i in 0..instruction.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 45 - for i in 0..instruction.len() { [INFO] [stdout] 45 + for (i, ) in instruction.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `arg` [INFO] [stdout] --> src/reader.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 64 | fn read(&mut self, arg: ReaderArg) -> io::Result<()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_arg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/writer.rs:15:25 [INFO] [stdout] | [INFO] [stdout] 15 | fn write(&mut self, output: String) {} [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/writer.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | fn writeln(&mut self, output: String) {} [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `output` is never read [INFO] [stdout] --> src/assembly_interpreter.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct AssemblyInterpreter { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | output: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AssemblyInterpreter` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Unexpected` is never constructed [INFO] [stdout] --> src/assembly_interpreter.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub enum AssemblyInterpreterError { [INFO] [stdout] | ------------------------ variant in this enum [INFO] [stdout] 10 | Unexpected, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `neg_op` is never used [INFO] [stdout] --> src/assembly_interpreter.rs:183:8 [INFO] [stdout] | [INFO] [stdout] 13 | impl AssemblyInterpreter { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 183 | fn neg_op(&mut self, rands: &[char]) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `keyword` is never used [INFO] [stdout] --> src/compiler.rs:266:8 [INFO] [stdout] | [INFO] [stdout] 15 | impl<'a, R: Reader, W: Writer> Compiler<'a, R, W> { [INFO] [stdout] | ------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 266 | fn keyword(&mut self, keyword: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `None` is never constructed [INFO] [stdout] --> src/reader.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum ReaderArg { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 8 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReaderArg` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `StdinReader` is never constructed [INFO] [stdout] --> src/reader.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct StdinReader { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/reader.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 46 | impl StdinReader { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 47 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/assembly_interpreter.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `instruction` [INFO] [stdout] --> src/assembly_interpreter.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for i in 0..instruction.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 45 - for i in 0..instruction.len() { [INFO] [stdout] 45 + for (i, ) in instruction.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Box<&'a mut W>` [INFO] [stdout] --> src/compiler.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | writer: Box<&'a mut W>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `&'a mut W` [INFO] [stdout] | [INFO] [stdout] = note: `&'a mut W` is already a pointer, `Box<&'a mut W>` allocates a pointer on the heap [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation [INFO] [stdout] = note: `#[warn(clippy::redundant_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/compiler.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if self.source.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.source.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 65 | self.writer.write(format!("{}", s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | self.writer.writeln(format!("{}", s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/compiler.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | x.is_digit(10) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/compiler.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 139 | if self.lookahead != None && ['*', '/'].contains(&self.lookahead.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `self.lookahead.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compiler.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | / match self.lookahead { [INFO] [stdout] 142 | | Some(c) => match c { [INFO] [stdout] 143 | | '*' => self.multiply(), [INFO] [stdout] 144 | | '/' => self.divide(), [INFO] [stdout] ... | [INFO] [stdout] 147 | | None => (), [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 141 ~ if let Some(c) = self.lookahead { match c { [INFO] [stdout] 142 + '*' => self.multiply(), [INFO] [stdout] 143 + '/' => self.divide(), [INFO] [stdout] 144 + _ => self.expected(String::from("Operator")), [INFO] [stdout] 145 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/compiler.rs:213:15 [INFO] [stdout] | [INFO] [stdout] 213 | while self.lookahead != None && self.is_addop(&self.lookahead.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `self.lookahead.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compiler.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | / match self.lookahead { [INFO] [stdout] 216 | | Some(c) => match c { [INFO] [stdout] 217 | | '+' => self.add(), [INFO] [stdout] 218 | | '-' => self.subtract(), [INFO] [stdout] ... | [INFO] [stdout] 223 | | None => (), [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 215 ~ if let Some(c) = self.lookahead { match c { [INFO] [stdout] 216 + '+' => self.add(), [INFO] [stdout] 217 + '-' => self.subtract(), [INFO] [stdout] 218 + _ => { [INFO] [stdout] 219 + self.term(); [INFO] [stdout] 220 + } [INFO] [stdout] 221 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler.rs:234:24 [INFO] [stdout] | [INFO] [stdout] 234 | self.emit_line(format!("MOVE D0,(A0)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"MOVE D0,(A0)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 258 | return label; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 258 - return label; [INFO] [stdout] 258 + label [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/compiler.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 275 | if !(self.get_name() == String::from("if")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_name() != String::from("if"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/compiler.rs:275:33 [INFO] [stdout] | [INFO] [stdout] 275 | if !(self.get_name() == String::from("if")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"if"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/compiler.rs:287:32 [INFO] [stdout] | [INFO] [stdout] 287 | if (self.get_name() == String::from("else")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"else"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Box<&'a mut W>` [INFO] [stdout] --> src/compiler.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | writer: Box<&'a mut W>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `&'a mut W` [INFO] [stdout] | [INFO] [stdout] = note: `&'a mut W` is already a pointer, `Box<&'a mut W>` allocates a pointer on the heap [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation [INFO] [stdout] = note: `#[warn(clippy::redundant_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/compiler.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if self.source.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.source.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 65 | self.writer.write(format!("{}", s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | self.writer.writeln(format!("{}", s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `s.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/compiler.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | x.is_digit(10) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/compiler.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 139 | if self.lookahead != None && ['*', '/'].contains(&self.lookahead.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `self.lookahead.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compiler.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | / match self.lookahead { [INFO] [stdout] 142 | | Some(c) => match c { [INFO] [stdout] 143 | | '*' => self.multiply(), [INFO] [stdout] 144 | | '/' => self.divide(), [INFO] [stdout] ... | [INFO] [stdout] 147 | | None => (), [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 141 ~ if let Some(c) = self.lookahead { match c { [INFO] [stdout] 142 + '*' => self.multiply(), [INFO] [stdout] 143 + '/' => self.divide(), [INFO] [stdout] 144 + _ => self.expected(String::from("Operator")), [INFO] [stdout] 145 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | self.process_instruction(instruction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 34 | let _ = self.process_instruction(instruction); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/compiler.rs:213:15 [INFO] [stdout] | [INFO] [stdout] 213 | while self.lookahead != None && self.is_addop(&self.lookahead.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `self.lookahead.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/compiler.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | / match self.lookahead { [INFO] [stdout] 216 | | Some(c) => match c { [INFO] [stdout] 217 | | '+' => self.add(), [INFO] [stdout] 218 | | '-' => self.subtract(), [INFO] [stdout] ... | [INFO] [stdout] 223 | | None => (), [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 215 ~ if let Some(c) = self.lookahead { match c { [INFO] [stdout] 216 + '+' => self.add(), [INFO] [stdout] 217 + '-' => self.subtract(), [INFO] [stdout] 218 + _ => { [INFO] [stdout] 219 + self.term(); [INFO] [stdout] 220 + } [INFO] [stdout] 221 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | self.match_char(&'('); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 155 | let _ = self.match_char(&'('); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | self.match_char(&')'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 156 | let _ = self.match_char(&')'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 165 | self.match_char(&'('); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 165 | let _ = self.match_char(&'('); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | self.match_char(&')'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 167 | let _ = self.match_char(&')'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | self.get_char(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 202 | let _ = self.get_char(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compiler.rs:234:24 [INFO] [stdout] | [INFO] [stdout] 234 | self.emit_line(format!("MOVE D0,(A0)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"MOVE D0,(A0)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | self.match_char(&'='); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 231 | let _ = self.match_char(&'='); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | self.match_char(&';'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 239 | let _ = self.match_char(&';'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | self.match_char(&'{'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 243 | let _ = self.match_char(&'{'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | self.match_char(&'}'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 247 | let _ = self.match_char(&'}'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/compiler.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 258 | return label; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 258 - return label; [INFO] [stdout] 258 + label [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/compiler.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 275 | if !(self.get_name() == String::from("if")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_name() != String::from("if"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/compiler.rs:275:33 [INFO] [stdout] | [INFO] [stdout] 275 | if !(self.get_name() == String::from("if")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"if"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/compiler.rs:287:32 [INFO] [stdout] | [INFO] [stdout] 287 | if (self.get_name() == String::from("else")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"else"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/compiler.rs:311:18 [INFO] [stdout] | [INFO] [stdout] 311 | .map(|s| String::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | self.process_instruction(instruction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 34 | let _ = self.process_instruction(instruction); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 434 | asm_interp.eval(writer.output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 434 | let _ = asm_interp.eval(writer.output); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:450:9 [INFO] [stdout] | [INFO] [stdout] 450 | asm_interp.eval(writer.output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 450 | let _ = asm_interp.eval(writer.output); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:466:9 [INFO] [stdout] | [INFO] [stdout] 466 | asm_interp.eval(writer.output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 466 | let _ = asm_interp.eval(writer.output); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:483:9 [INFO] [stdout] | [INFO] [stdout] 483 | asm_interp.eval(writer.output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 483 | let _ = asm_interp.eval(writer.output); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:499:9 [INFO] [stdout] | [INFO] [stdout] 499 | asm_interp.eval(writer.output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 499 | let _ = asm_interp.eval(writer.output); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:517:9 [INFO] [stdout] | [INFO] [stdout] 517 | asm_interp.eval(writer.output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 517 | let _ = asm_interp.eval(writer.output); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembly_interpreter.rs:536:9 [INFO] [stdout] | [INFO] [stdout] 536 | asm_interp.eval(writer.output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 536 | let _ = asm_interp.eval(writer.output); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | self.match_char(&'('); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 155 | let _ = self.match_char(&'('); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | self.match_char(&')'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 156 | let _ = self.match_char(&')'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 165 | self.match_char(&'('); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 165 | let _ = self.match_char(&'('); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | self.match_char(&')'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 167 | let _ = self.match_char(&')'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | self.get_char(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 202 | let _ = self.get_char(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | self.match_char(&'='); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 231 | let _ = self.match_char(&'='); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | self.match_char(&';'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 239 | let _ = self.match_char(&';'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | self.match_char(&'{'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 243 | let _ = self.match_char(&'{'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/compiler.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | self.match_char(&'}'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 247 | let _ = self.match_char(&'}'); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.23s [INFO] running `Command { std: "docker" "inspect" "0dfc81d9adb5033690fc542492fa99e5a18dbffe238432b75793c3b54be7f0a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0dfc81d9adb5033690fc542492fa99e5a18dbffe238432b75793c3b54be7f0a5", kill_on_drop: false }` [INFO] [stdout] 0dfc81d9adb5033690fc542492fa99e5a18dbffe238432b75793c3b54be7f0a5