[INFO] cloning repository https://github.com/j-millet/scriptrunner [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/j-millet/scriptrunner" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fj-millet%2Fscriptrunner", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fj-millet%2Fscriptrunner'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 17ac2e65e38f2b5a732cfe580a7c919ce89babb3 [INFO] linting j-millet/scriptrunner against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fj-millet%2Fscriptrunner" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/j-millet/scriptrunner [INFO] finished tweaking git repo https://github.com/j-millet/scriptrunner [INFO] tweaked toml for git repo https://github.com/j-millet/scriptrunner written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/j-millet/scriptrunner on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/j-millet/scriptrunner already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.17 [INFO] [stderr] Downloaded evalexpr v11.3.0 [INFO] [stderr] Downloaded clap_builder v4.5.17 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e53febc043d142f8d6f6e9716537226bb57065be7e946a8e5a22287871ba49d2 [INFO] running `Command { std: "docker" "start" "-a" "e53febc043d142f8d6f6e9716537226bb57065be7e946a8e5a22287871ba49d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e53febc043d142f8d6f6e9716537226bb57065be7e946a8e5a22287871ba49d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e53febc043d142f8d6f6e9716537226bb57065be7e946a8e5a22287871ba49d2", kill_on_drop: false }` [INFO] [stdout] e53febc043d142f8d6f6e9716537226bb57065be7e946a8e5a22287871ba49d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f787ef3711fe44bffa22ee04af59d4b3ab25107dfe23ea7c9cf9684d8b91671 [INFO] running `Command { std: "docker" "start" "-a" "1f787ef3711fe44bffa22ee04af59d4b3ab25107dfe23ea7c9cf9684d8b91671", kill_on_drop: false }` [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking evalexpr v11.3.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking clap_builder v4.5.17 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.17 [INFO] [stderr] Checking scriptrunner v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `Float` is never constructed [INFO] [stdout] --> src/info_objects.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum SystemStateVar{ [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 24 | Float(f64) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SystemStateVar` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `split.get(0)` [INFO] [stdout] --> src/info_objects/display_info.rs:44:31 [INFO] [stdout] | [INFO] [stdout] 44 | String::from(*split.get(0).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/info_objects/display_info.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | / match *split.get(1).unwrap(){ [INFO] [stdout] 46 | | "connected" => {true}, [INFO] [stdout] 47 | | _ => {false} [INFO] [stdout] 48 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 45 - match *split.get(1).unwrap(){ [INFO] [stdout] 46 - "connected" => {true}, [INFO] [stdout] 47 - _ => {false} [INFO] [stdout] 48 - }); [INFO] [stdout] 45 + matches!(*split.get(1).unwrap(), "connected")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/info_objects.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if !(line_split.len() == 2){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(line_split.len() != 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/info_objects.rs:48:35 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn from_config_line(line: &String) -> Result>,&str>{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - pub fn from_config_line(line: &String) -> Result>,&str>{ [INFO] [stdout] 48 + pub fn from_config_line(line: &str) -> Result>,&str>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `line_split.get(0)` [INFO] [stdout] --> src/info_objects.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | let dependencies = String::from(line_split.get(0).unwrap().trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `line_split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | return p1_new; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return p1_new; [INFO] [stdout] 8 + p1_new [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/common.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | p1_new.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `p1_new.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:72:74 [INFO] [stdout] | [INFO] [stdout] 72 | let mut subs = match info_objects::utils::make_subs_from_config_file(&config_file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `config_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/info_objects.rs:176:38 [INFO] [stdout] | [INFO] [stdout] 176 | subs_to_update = vec![subs_to_update,self.subscribers.get(key).unwrap().to_owned()].concat(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[subs_to_update,self.subscribers.get(key).unwrap().to_owned()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Float` is never constructed [INFO] [stdout] --> src/info_objects.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum SystemStateVar{ [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 24 | Float(f64) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SystemStateVar` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `split.get(0)` [INFO] [stdout] --> src/info_objects/display_info.rs:44:31 [INFO] [stdout] | [INFO] [stdout] 44 | String::from(*split.get(0).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/info_objects/display_info.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | / match *split.get(1).unwrap(){ [INFO] [stdout] 46 | | "connected" => {true}, [INFO] [stdout] 47 | | _ => {false} [INFO] [stdout] 48 | | }); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 45 - match *split.get(1).unwrap(){ [INFO] [stdout] 46 - "connected" => {true}, [INFO] [stdout] 47 - _ => {false} [INFO] [stdout] 48 - }); [INFO] [stdout] 45 + matches!(*split.get(1).unwrap(), "connected")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/info_objects.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if !(line_split.len() == 2){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(line_split.len() != 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/info_objects.rs:48:35 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn from_config_line(line: &String) -> Result>,&str>{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - pub fn from_config_line(line: &String) -> Result>,&str>{ [INFO] [stdout] 48 + pub fn from_config_line(line: &str) -> Result>,&str>{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `line_split.get(0)` [INFO] [stdout] --> src/info_objects.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | let dependencies = String::from(line_split.get(0).unwrap().trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `line_split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | return p1_new; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return p1_new; [INFO] [stdout] 8 + p1_new [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/common.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | p1_new.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `p1_new.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:72:74 [INFO] [stdout] | [INFO] [stdout] 72 | let mut subs = match info_objects::utils::make_subs_from_config_file(&config_file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `config_file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/info_objects.rs:176:38 [INFO] [stdout] | [INFO] [stdout] 176 | subs_to_update = vec![subs_to_update,self.subscribers.get(key).unwrap().to_owned()].concat(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[subs_to_update,self.subscribers.get(key).unwrap().to_owned()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.03s [INFO] running `Command { std: "docker" "inspect" "1f787ef3711fe44bffa22ee04af59d4b3ab25107dfe23ea7c9cf9684d8b91671", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f787ef3711fe44bffa22ee04af59d4b3ab25107dfe23ea7c9cf9684d8b91671", kill_on_drop: false }` [INFO] [stdout] 1f787ef3711fe44bffa22ee04af59d4b3ab25107dfe23ea7c9cf9684d8b91671