[INFO] cloning repository https://github.com/itstauq/process-wick [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/itstauq/process-wick" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fitstauq%2Fprocess-wick", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fitstauq%2Fprocess-wick'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4e3ad51b8beb4d0ee1427c34c594b2c6d8cfe49e [INFO] linting itstauq/process-wick against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fitstauq%2Fprocess-wick" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-0-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/itstauq/process-wick [INFO] finished tweaking git repo https://github.com/itstauq/process-wick [INFO] tweaked toml for git repo https://github.com/itstauq/process-wick written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/itstauq/process-wick on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/itstauq/process-wick already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jiff-static v0.2.21 [INFO] [stderr] Downloaded sysinfo v0.35.2 [INFO] [stderr] Downloaded jiff v0.2.21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76809acc49a2d201543ceb9b70f2044f1814146132397cd49dba45fbcc31822b [INFO] running `Command { std: "docker" "start" "-a" "76809acc49a2d201543ceb9b70f2044f1814146132397cd49dba45fbcc31822b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76809acc49a2d201543ceb9b70f2044f1814146132397cd49dba45fbcc31822b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76809acc49a2d201543ceb9b70f2044f1814146132397cd49dba45fbcc31822b", kill_on_drop: false }` [INFO] [stdout] 76809acc49a2d201543ceb9b70f2044f1814146132397cd49dba45fbcc31822b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 110f2e0c9c69eae2435a12d0b45c1d0955b15eb22742c9bfa7a679b476783d43 [INFO] running `Command { std: "docker" "start" "-a" "110f2e0c9c69eae2435a12d0b45c1d0955b15eb22742c9bfa7a679b476783d43", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking jiff v0.2.21 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking sysinfo v0.35.2 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking process-wick v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/lib.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | / if !process_tree.contains_key(&pid) { [INFO] [stdout] 67 | | let mut child_node = ProcessNode::new(pid, parent_pid); [INFO] [stdout] 68 | | child_node.depth = current_depth + 1; [INFO] [stdout] 69 | | process_tree.insert(pid, child_node); [INFO] [stdout] 70 | | to_visit.push_back(pid); [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 ~ if let std::collections::hash_map::Entry::Vacant(e) = process_tree.entry(pid) { [INFO] [stdout] 67 + let mut child_node = ProcessNode::new(pid, parent_pid); [INFO] [stdout] 68 + child_node.depth = current_depth + 1; [INFO] [stdout] 69 + e.insert(child_node); [INFO] [stdout] 70 + to_visit.push_back(pid); [INFO] [stdout] 71 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/lib.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | / if !process_tree.contains_key(&pid) { [INFO] [stdout] 67 | | let mut child_node = ProcessNode::new(pid, parent_pid); [INFO] [stdout] 68 | | child_node.depth = current_depth + 1; [INFO] [stdout] 69 | | process_tree.insert(pid, child_node); [INFO] [stdout] 70 | | to_visit.push_back(pid); [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 ~ if let std::collections::hash_map::Entry::Vacant(e) = process_tree.entry(pid) { [INFO] [stdout] 67 + let mut child_node = ProcessNode::new(pid, parent_pid); [INFO] [stdout] 68 + child_node.depth = current_depth + 1; [INFO] [stdout] 69 + e.insert(child_node); [INFO] [stdout] 70 + to_visit.push_back(pid); [INFO] [stdout] 71 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> tests/integration_tests.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 175 | std::process::exit(0); [INFO] [stdout] | --------------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 179 | _handle.join().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basic_integration_tests.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | .args(&["build", "--release"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["build", "--release"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basic_integration_tests.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 61 | .args(&["--dog", "1234", "--tick", "1"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--dog", "1234", "--tick", "1"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basic_integration_tests.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 87 | .args(&["--dog", "1234", "--targets", "5678", "--log-level", level]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--dog", "1234", "--targets", "5678", "--log-level", level]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basic_integration_tests.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 107 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 108 | | "--dog", [INFO] [stdout] 109 | | "1234", [INFO] [stdout] 110 | | "--targets", [INFO] [stdout] ... | [INFO] [stdout] 117 | | "debug", [INFO] [stdout] 118 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 107 ~ .args([ [INFO] [stdout] 108 + "--dog", [INFO] [stdout] 109 + "1234", [INFO] [stdout] 110 + "--targets", [INFO] [stdout] 111 + "5678,9012", [INFO] [stdout] 112 + "--vengeance-delay", [INFO] [stdout] 113 + "10", [INFO] [stdout] 114 + "--tick", [INFO] [stdout] 115 + "5", [INFO] [stdout] 116 + "--log-level", [INFO] [stdout] 117 + "debug", [INFO] [stdout] 118 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basic_integration_tests.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 136 | .args(&["--dog", "1234", "--targets", "5678,9012,3456,7890"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--dog", "1234", "--targets", "5678,9012,3456,7890"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basic_integration_tests.rs:153:15 [INFO] [stdout] | [INFO] [stdout] 153 | .args(&["--dog", "1234", "--targets", "5678,notanumber,9012"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--dog", "1234", "--targets", "5678,notanumber,9012"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basic_integration_tests.rs:173:15 [INFO] [stdout] | [INFO] [stdout] 173 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 174 | | "--dog", [INFO] [stdout] 175 | | "999999", // Non-existent PID [INFO] [stdout] 176 | | "--targets", [INFO] [stdout] ... | [INFO] [stdout] 181 | | "1", [INFO] [stdout] 182 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 173 ~ .args([ [INFO] [stdout] 174 + "--dog", [INFO] [stdout] 175 + "999999", // Non-existent PID [INFO] [stdout] 176 + "--targets", [INFO] [stdout] 177 + "999998", // Non-existent PID [INFO] [stdout] 178 + "--tick", [INFO] [stdout] 179 + "1", [INFO] [stdout] 180 + "--vengeance-delay", [INFO] [stdout] 181 + "1", [INFO] [stdout] 182 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_tests.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | .args(&["build", "--release"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["build", "--release"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_tests.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | !target1.try_wait().unwrap().is_some(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target1.try_wait().unwrap().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_tests.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | !target2.try_wait().unwrap().is_some(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target2.try_wait().unwrap().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> tests/integration_tests.rs:83:27 [INFO] [stdout] | [INFO] [stdout] 83 | let mut dog_process = create_test_process(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_tests.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 98 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 99 | | "--dog", [INFO] [stdout] 100 | | &dog_pid.to_string(), [INFO] [stdout] 101 | | "--targets", [INFO] [stdout] ... | [INFO] [stdout] 107 | | "2", [INFO] [stdout] 108 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 ~ .args([ [INFO] [stdout] 99 + "--dog", [INFO] [stdout] 100 + &dog_pid.to_string(), [INFO] [stdout] 101 + "--targets", [INFO] [stdout] 102 + &target1_pid.to_string(), [INFO] [stdout] 103 + &target2_pid.to_string(), [INFO] [stdout] 104 + "--tick", [INFO] [stdout] 105 + "1", [INFO] [stdout] 106 + "--vengeance-delay", [INFO] [stdout] 107 + "2", [INFO] [stdout] 108 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_tests.rs:156:19 [INFO] [stdout] | [INFO] [stdout] 156 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 157 | | "--targets", [INFO] [stdout] 158 | | &target1_pid.to_string(), [INFO] [stdout] 159 | | "--tick", [INFO] [stdout] ... | [INFO] [stdout] 162 | | "1", [INFO] [stdout] 163 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 156 ~ .args([ [INFO] [stdout] 157 + "--targets", [INFO] [stdout] 158 + &target1_pid.to_string(), [INFO] [stdout] 159 + "--tick", [INFO] [stdout] 160 + "1", [INFO] [stdout] 161 + "--vengeance-delay", [INFO] [stdout] 162 + "1", [INFO] [stdout] 163 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> tests/integration_tests.rs:194:27 [INFO] [stdout] | [INFO] [stdout] 194 | let mut dog_process = create_test_process(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> tests/integration_tests.rs:198:22 [INFO] [stdout] | [INFO] [stdout] 198 | let mut target = create_test_process(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_tests.rs:207:19 [INFO] [stdout] | [INFO] [stdout] 207 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 208 | | "--dog", [INFO] [stdout] 209 | | &dog_pid.to_string(), [INFO] [stdout] 210 | | "--targets", [INFO] [stdout] ... | [INFO] [stdout] 219 | | "debug", [INFO] [stdout] 220 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 207 ~ .args([ [INFO] [stdout] 208 + "--dog", [INFO] [stdout] 209 + &dog_pid.to_string(), [INFO] [stdout] 210 + "--targets", [INFO] [stdout] 211 + &target_pid.to_string(), [INFO] [stdout] 212 + "--tick", [INFO] [stdout] 213 + "1", [INFO] [stdout] 214 + "--vengeance-delay", [INFO] [stdout] 215 + "2", [INFO] [stdout] 216 + "--log-file", [INFO] [stdout] 217 + log_file, [INFO] [stdout] 218 + "--log-level", [INFO] [stdout] 219 + "debug", [INFO] [stdout] 220 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_tests.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | !target.try_wait().unwrap().is_some(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.try_wait().unwrap().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> tests/integration_tests.rs:269:27 [INFO] [stdout] | [INFO] [stdout] 269 | let mut dog_process = create_test_process(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> tests/integration_tests.rs:344:27 [INFO] [stdout] | [INFO] [stdout] 344 | let mut dog_process = create_test_process(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> tests/integration_tests.rs:348:22 [INFO] [stdout] | [INFO] [stdout] 348 | let mut target = create_test_process(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_tests.rs:359:19 [INFO] [stdout] | [INFO] [stdout] 359 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 360 | | "--dog", [INFO] [stdout] 361 | | &dog_pid.to_string(), [INFO] [stdout] 362 | | "--targets", [INFO] [stdout] ... | [INFO] [stdout] 367 | | "3", [INFO] [stdout] 368 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 359 ~ .args([ [INFO] [stdout] 360 + "--dog", [INFO] [stdout] 361 + &dog_pid.to_string(), [INFO] [stdout] 362 + "--targets", [INFO] [stdout] 363 + &target_pid.to_string(), [INFO] [stdout] 364 + "--tick", [INFO] [stdout] 365 + "1", [INFO] [stdout] 366 + "--vengeance-delay", [INFO] [stdout] 367 + "3", [INFO] [stdout] 368 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_tests.rs:405:15 [INFO] [stdout] | [INFO] [stdout] 405 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 406 | | "--dog", [INFO] [stdout] 407 | | "999999", [INFO] [stdout] 408 | | "--targets", [INFO] [stdout] ... | [INFO] [stdout] 413 | | "1", [INFO] [stdout] 414 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 405 ~ .args([ [INFO] [stdout] 406 + "--dog", [INFO] [stdout] 407 + "999999", [INFO] [stdout] 408 + "--targets", [INFO] [stdout] 409 + "999998", [INFO] [stdout] 410 + "--tick", [INFO] [stdout] 411 + "1", [INFO] [stdout] 412 + "--vengeance-delay", [INFO] [stdout] 413 + "1", [INFO] [stdout] 414 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_tests.rs:466:15 [INFO] [stdout] | [INFO] [stdout] 466 | .args(&["--dog", "1234", "--tick", "1"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["--dog", "1234", "--tick", "1"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_tests.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | !target.try_wait().unwrap().is_some(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.try_wait().unwrap().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> tests/integration_tests.rs:488:30 [INFO] [stdout] | [INFO] [stdout] 488 | let mut parent_process = create_parent_with_children(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_tests.rs:504:19 [INFO] [stdout] | [INFO] [stdout] 504 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 505 | | "--dog", [INFO] [stdout] 506 | | &parent_pid.to_string(), [INFO] [stdout] 507 | | "--targets", [INFO] [stdout] ... | [INFO] [stdout] 512 | | "2", [INFO] [stdout] 513 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 504 ~ .args([ [INFO] [stdout] 505 + "--dog", [INFO] [stdout] 506 + &parent_pid.to_string(), [INFO] [stdout] 507 + "--targets", [INFO] [stdout] 508 + &target_pid.to_string(), [INFO] [stdout] 509 + "--tick", [INFO] [stdout] 510 + "1", [INFO] [stdout] 511 + "--vengeance-delay", [INFO] [stdout] 512 + "2", [INFO] [stdout] 513 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.24s [INFO] running `Command { std: "docker" "inspect" "110f2e0c9c69eae2435a12d0b45c1d0955b15eb22742c9bfa7a679b476783d43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "110f2e0c9c69eae2435a12d0b45c1d0955b15eb22742c9bfa7a679b476783d43", kill_on_drop: false }` [INFO] [stdout] 110f2e0c9c69eae2435a12d0b45c1d0955b15eb22742c9bfa7a679b476783d43