[INFO] cloning repository https://github.com/itsrainingmani/bresson [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/itsrainingmani/bresson" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fitsrainingmani%2Fbresson", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fitsrainingmani%2Fbresson'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dd51336471feb2936fd2969f42d518548d821b8f [INFO] linting itsrainingmani/bresson against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fitsrainingmani%2Fbresson" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/itsrainingmani/bresson [INFO] finished tweaking git repo https://github.com/itsrainingmani/bresson [INFO] tweaked toml for git repo https://github.com/itsrainingmani/bresson written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/itsrainingmani/bresson on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/itsrainingmani/bresson already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded signal-hook-mio v0.2.4 [INFO] [stderr] Downloaded signal-hook v0.3.17 [INFO] [stderr] Downloaded instability v0.3.2 [INFO] [stderr] Downloaded lru v0.12.4 [INFO] [stderr] Downloaded ratatui-image v1.0.5 [INFO] [stderr] Downloaded mutate_once v0.1.1 [INFO] [stderr] Downloaded profiling v1.0.15 [INFO] [stderr] Downloaded thiserror-impl v1.0.63 [INFO] [stderr] Downloaded dyn-clone v1.0.17 [INFO] [stderr] Downloaded ravif v0.11.10 [INFO] [stderr] Downloaded avif-serialize v0.8.1 [INFO] [stderr] Downloaded profiling-procmacros v1.0.15 [INFO] [stderr] Downloaded icy_sixel v0.1.2 [INFO] [stderr] Downloaded arbitrary v1.3.2 [INFO] [stderr] Downloaded bitstream-io v2.5.3 [INFO] [stderr] Downloaded anyhow v1.0.88 [INFO] [stderr] Downloaded kamadak-exif v0.5.5 [INFO] [stderr] Downloaded toml v0.8.19 [INFO] [stderr] Downloaded cc v1.1.18 [INFO] [stderr] Downloaded flate2 v1.0.33 [INFO] [stderr] Downloaded libfuzzer-sys v0.4.7 [INFO] [stderr] Downloaded mio v1.0.2 [INFO] [stderr] Downloaded winnow v0.6.18 [INFO] [stderr] Downloaded indexmap v2.5.0 [INFO] [stderr] Downloaded toml_edit v0.22.20 [INFO] [stderr] Downloaded miniz_oxide v0.8.0 [INFO] [stderr] Downloaded image v0.25.2 [INFO] [stderr] Downloaded compact_str v0.8.0 [INFO] [stderr] Downloaded image-webp v0.1.3 [INFO] [stderr] Downloaded imgref v1.10.1 [INFO] [stderr] Downloaded built v0.7.4 [INFO] [stderr] Downloaded zune-jpeg v0.4.13 [INFO] [stderr] Downloaded rustix v0.38.37 [INFO] [stderr] Downloaded thiserror v1.0.63 [INFO] [stderr] Downloaded redox_syscall v0.5.3 [INFO] [stderr] Downloaded allocator-api2 v0.2.18 [INFO] [stderr] Downloaded serde_spanned v0.6.7 [INFO] [stderr] Downloaded castaway v0.2.3 [INFO] [stderr] Downloaded ratatui v0.28.1 [INFO] [stderr] Downloaded libc v0.2.158 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8edd87d26f3a4c4824c5d993bf1cede0762a7563e622025e723a85a0f5b1b938 [INFO] running `Command { std: "docker" "start" "-a" "8edd87d26f3a4c4824c5d993bf1cede0762a7563e622025e723a85a0f5b1b938", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8edd87d26f3a4c4824c5d993bf1cede0762a7563e622025e723a85a0f5b1b938", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8edd87d26f3a4c4824c5d993bf1cede0762a7563e622025e723a85a0f5b1b938", kill_on_drop: false }` [INFO] [stdout] 8edd87d26f3a4c4824c5d993bf1cede0762a7563e622025e723a85a0f5b1b938 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 572853d3a0a848a47505d1ff5002680fbe79ecdabe6b5cc8146689f6e0903917 [INFO] running `Command { std: "docker" "start" "-a" "572853d3a0a848a47505d1ff5002680fbe79ecdabe6b5cc8146689f6e0903917", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling anyhow v1.0.88 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Compiling built v0.7.4 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking bitstream-io v2.5.3 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking avif-serialize v0.8.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking zune-jpeg v0.4.13 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking image-webp v0.1.3 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking icy_sixel v0.1.2 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking mutate_once v0.1.1 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking kamadak-exif v0.5.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling instability v0.3.2 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking ratatui v0.28.1 [INFO] [stderr] Checking ravif v0.11.10 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking ratatui-image v1.0.5 [INFO] [stderr] Checking bresson v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ThreadImage` [INFO] [stdout] --> src/image.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> ThreadImage { [INFO] [stdout] 14 | | ThreadImage { [INFO] [stdout] 15 | | resize: Resize::Fit(Some(FilterType::Gaussian)), [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for ThreadImage { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:275:28 [INFO] [stdout] | [INFO] [stdout] 275 | should_rotate: false || !has_gps, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 275 - should_rotate: false || !has_gps, [INFO] [stdout] 275 + should_rotate: !has_gps, [INFO] [stdout] | [INFO] [stdout] 275 - should_rotate: false || !has_gps, [INFO] [stdout] 275 + should_rotate: !has_gps, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `image::DynamicImage` [INFO] [stdout] --> src/state.rs:233:23 [INFO] [stdout] | [INFO] [stdout] 233 | let dyn_img = image::DynamicImage::from(image::open(path_to_image)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `image::DynamicImage::from()`: `image::open(path_to_image)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/state.rs:306:59 [INFO] [stdout] | [INFO] [stdout] 306 | for (_idx, t) in order::EXIF_FIELDS_ORDERED.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 306 - for (_idx, t) in order::EXIF_FIELDS_ORDERED.iter().enumerate() { [INFO] [stdout] 306 + for t in order::EXIF_FIELDS_ORDERED.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/state.rs:310:20 [INFO] [stdout] | [INFO] [stdout] 310 | if f_val.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!f_val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/state.rs:315:53 [INFO] [stdout] | [INFO] [stdout] 315 | ... if x.iter().all(|x| x.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:512:66 [INFO] [stdout] | [INFO] [stdout] 512 | if let Some(field_in_map) = self.modified_fields.get_mut(&tag_at_index) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `tag_at_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/state.rs:532:80 [INFO] [stdout] | [INFO] [stdout] 532 | self.show_message(format!("Randomized {}", tag_at_index.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/state.rs:535:86 [INFO] [stdout] | [INFO] [stdout] 535 | self.show_message(format!("Cannot randomize {}", tag_at_index.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:551:66 [INFO] [stdout] | [INFO] [stdout] 551 | if let Some(field_in_map) = self.modified_fields.get_mut(&tag_at_index) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `tag_at_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/state.rs:558:65 [INFO] [stdout] | [INFO] [stdout] 558 | self.show_message(format!("Cleared {}", tag_at_index.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/state.rs:687:23 [INFO] [stdout] | [INFO] [stdout] 687 | for (_, m) in &self.modified_fields { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 687 - for (_, m) in &self.modified_fields { [INFO] [stdout] 687 + for m in self.modified_fields.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:730:39 [INFO] [stdout] | [INFO] [stdout] 730 | exif_header.extend_from_slice(&img_data); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `img_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:737:29 [INFO] [stdout] | [INFO] [stdout] 737 | copy_file.write_all(&exif_header.as_slice())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `exif_header.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/state.rs:706:21 [INFO] [stdout] | [INFO] [stdout] 706 | if let Some(ref tn_jpeg) = tn_jpeg { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 706 - if let Some(ref tn_jpeg) = tn_jpeg { [INFO] [stdout] 706 + if let Some(tn_jpeg) = tn_jpeg { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/ui.rs:100:46 [INFO] [stdout] | [INFO] [stdout] 100 | ... ' ' => ctx.print(translated_j as f64, translated_i as f64, " "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `translated_j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/ui.rs:103:43 [INFO] [stdout] | [INFO] [stdout] 103 | ... ctx.print(translated_j as f64, translated_i as f64, x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `translated_j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/ui.rs:116:43 [INFO] [stdout] | [INFO] [stdout] 116 | ... ctx.print(translated_j as f64, translated_i as f64, long_lat_color) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `translated_j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn clean_disp(dv: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn clean_disp(dv: &String) -> String { [INFO] [stdout] 3 + pub fn clean_disp(dv: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ThreadImage` [INFO] [stdout] --> src/image.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> ThreadImage { [INFO] [stdout] 14 | | ThreadImage { [INFO] [stdout] 15 | | resize: Resize::Fit(Some(FilterType::Gaussian)), [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for ThreadImage { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/state.rs:408:41 [INFO] [stdout] | [INFO] [stdout] 408 | let lat_internals = vec![ [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 409 | | (v[0].num as f32 / v[0].denom as f32), [INFO] [stdout] 410 | | (v[1].num as f32 / v[1].denom as f32) / 60., [INFO] [stdout] 411 | | (v[2].num as f32 / v[2].denom as f32) / (60. * 100.), [INFO] [stdout] 412 | | ]; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 408 ~ let lat_internals = [(v[0].num as f32 / v[0].denom as f32), [INFO] [stdout] 409 + (v[1].num as f32 / v[1].denom as f32) / 60., [INFO] [stdout] 410 ~ (v[2].num as f32 / v[2].denom as f32) / (60. * 100.)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/state.rs:424:42 [INFO] [stdout] | [INFO] [stdout] 424 | let long_internals = vec![ [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 425 | | (v[0].num as f32 / v[0].denom as f32), [INFO] [stdout] 426 | | (v[1].num as f32 / v[1].denom as f32) / 60., [INFO] [stdout] 427 | | (v[2].num as f32 / v[2].denom as f32) / (60. * 100.), [INFO] [stdout] 428 | | ]; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 424 ~ let long_internals = [(v[0].num as f32 / v[0].denom as f32), [INFO] [stdout] 425 + (v[1].num as f32 / v[1].denom as f32) / 60., [INFO] [stdout] 426 ~ (v[2].num as f32 / v[2].denom as f32) / (60. * 100.)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/state.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | pub fn keybind_rows(&self) -> Vec { [INFO] [stdout] | ^^^^^ ^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 280 | pub fn keybind_rows(&self) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/state.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn process_rows(&self, _term_width: u16) -> Vec { [INFO] [stdout] | ^^^^^ ^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 304 | pub fn process_rows(&self, _term_width: u16) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/state.rs:275:28 [INFO] [stdout] | [INFO] [stdout] 275 | should_rotate: false || !has_gps, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 275 - should_rotate: false || !has_gps, [INFO] [stdout] 275 + should_rotate: !has_gps, [INFO] [stdout] | [INFO] [stdout] 275 - should_rotate: false || !has_gps, [INFO] [stdout] 275 + should_rotate: !has_gps, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `image::DynamicImage` [INFO] [stdout] --> src/state.rs:233:23 [INFO] [stdout] | [INFO] [stdout] 233 | let dyn_img = image::DynamicImage::from(image::open(path_to_image)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `image::DynamicImage::from()`: `image::open(path_to_image)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/state.rs:306:59 [INFO] [stdout] | [INFO] [stdout] 306 | for (_idx, t) in order::EXIF_FIELDS_ORDERED.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 306 - for (_idx, t) in order::EXIF_FIELDS_ORDERED.iter().enumerate() { [INFO] [stdout] 306 + for t in order::EXIF_FIELDS_ORDERED.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/state.rs:310:20 [INFO] [stdout] | [INFO] [stdout] 310 | if f_val.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!f_val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/state.rs:315:53 [INFO] [stdout] | [INFO] [stdout] 315 | ... if x.iter().all(|x| x.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:512:66 [INFO] [stdout] | [INFO] [stdout] 512 | if let Some(field_in_map) = self.modified_fields.get_mut(&tag_at_index) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `tag_at_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/state.rs:532:80 [INFO] [stdout] | [INFO] [stdout] 532 | self.show_message(format!("Randomized {}", tag_at_index.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/state.rs:535:86 [INFO] [stdout] | [INFO] [stdout] 535 | self.show_message(format!("Cannot randomize {}", tag_at_index.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:551:66 [INFO] [stdout] | [INFO] [stdout] 551 | if let Some(field_in_map) = self.modified_fields.get_mut(&tag_at_index) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `tag_at_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/state.rs:558:65 [INFO] [stdout] | [INFO] [stdout] 558 | self.show_message(format!("Cleared {}", tag_at_index.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/state.rs:687:23 [INFO] [stdout] | [INFO] [stdout] 687 | for (_, m) in &self.modified_fields { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 687 - for (_, m) in &self.modified_fields { [INFO] [stdout] 687 + for m in self.modified_fields.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:730:39 [INFO] [stdout] | [INFO] [stdout] 730 | exif_header.extend_from_slice(&img_data); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `img_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state.rs:737:29 [INFO] [stdout] | [INFO] [stdout] 737 | copy_file.write_all(&exif_header.as_slice())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `exif_header.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/state.rs:706:21 [INFO] [stdout] | [INFO] [stdout] 706 | if let Some(ref tn_jpeg) = tn_jpeg { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 706 - if let Some(ref tn_jpeg) = tn_jpeg { [INFO] [stdout] 706 + if let Some(tn_jpeg) = tn_jpeg { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/ui.rs:100:46 [INFO] [stdout] | [INFO] [stdout] 100 | ... ' ' => ctx.print(translated_j as f64, translated_i as f64, " "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `translated_j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/ui.rs:103:43 [INFO] [stdout] | [INFO] [stdout] 103 | ... ctx.print(translated_j as f64, translated_i as f64, x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `translated_j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/ui.rs:116:43 [INFO] [stdout] | [INFO] [stdout] 116 | ... ctx.print(translated_j as f64, translated_i as f64, long_lat_color) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `translated_j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn clean_disp(dv: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn clean_disp(dv: &String) -> String { [INFO] [stdout] 3 + pub fn clean_disp(dv: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/state.rs:408:41 [INFO] [stdout] | [INFO] [stdout] 408 | let lat_internals = vec![ [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 409 | | (v[0].num as f32 / v[0].denom as f32), [INFO] [stdout] 410 | | (v[1].num as f32 / v[1].denom as f32) / 60., [INFO] [stdout] 411 | | (v[2].num as f32 / v[2].denom as f32) / (60. * 100.), [INFO] [stdout] 412 | | ]; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 408 ~ let lat_internals = [(v[0].num as f32 / v[0].denom as f32), [INFO] [stdout] 409 + (v[1].num as f32 / v[1].denom as f32) / 60., [INFO] [stdout] 410 ~ (v[2].num as f32 / v[2].denom as f32) / (60. * 100.)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/state.rs:424:42 [INFO] [stdout] | [INFO] [stdout] 424 | let long_internals = vec![ [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 425 | | (v[0].num as f32 / v[0].denom as f32), [INFO] [stdout] 426 | | (v[1].num as f32 / v[1].denom as f32) / 60., [INFO] [stdout] 427 | | (v[2].num as f32 / v[2].denom as f32) / (60. * 100.), [INFO] [stdout] 428 | | ]; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 424 ~ let long_internals = [(v[0].num as f32 / v[0].denom as f32), [INFO] [stdout] 425 + (v[1].num as f32 / v[1].denom as f32) / 60., [INFO] [stdout] 426 ~ (v[2].num as f32 / v[2].denom as f32) / (60. * 100.)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/state.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | pub fn keybind_rows(&self) -> Vec { [INFO] [stdout] | ^^^^^ ^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 280 | pub fn keybind_rows(&self) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/state.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn process_rows(&self, _term_width: u16) -> Vec { [INFO] [stdout] | ^^^^^ ^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 304 | pub fn process_rows(&self, _term_width: u16) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:95:37 [INFO] [stdout] | [INFO] [stdout] 95 | / ... match table_state.selected() { [INFO] [stdout] 96 | | ... Some(index) => { [INFO] [stdout] 97 | | ... app.randomize(index, false); [INFO] [stdout] ... | [INFO] [stdout] 100 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 ~ if let Some(index) = table_state.selected() { [INFO] [stdout] 96 + app.randomize(index, false); [INFO] [stdout] 97 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:107:40 [INFO] [stdout] | [INFO] [stdout] 107 | ... 'c' => match table_state.selected() { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 108 | | ... Some(index) => { [INFO] [stdout] 109 | | ... app.clear_field(index, false); [INFO] [stdout] ... | [INFO] [stdout] 112 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 ~ 'c' => if let Some(index) = table_state.selected() { [INFO] [stdout] 108 + app.clear_field(index, false); [INFO] [stdout] 109 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:184:49 [INFO] [stdout] | [INFO] [stdout] 184 | ... KeyCode::Char(c) => match c { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 185 | | ... '?' => { [INFO] [stdout] ... | [INFO] [stdout] 195 | | ... _ => {} [INFO] [stdout] 196 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:184:43 [INFO] [stdout] | [INFO] [stdout] 184 | ... KeyCode::Char(c) => match c { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 185 | ... '?' => { [INFO] [stdout] | ^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:184:49 [INFO] [stdout] | [INFO] [stdout] 184 | ... KeyCode::Char(c) => match c { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 185 | | ... '?' => { [INFO] [stdout] ... | [INFO] [stdout] 195 | | ... _ => {} [INFO] [stdout] 196 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 184 ~ KeyCode::Char(c) => if c == '?' { [INFO] [stdout] 185 + // Display a popup window with keybinds [INFO] [stdout] 186 + // toggle the show_keybinds state [INFO] [stdout] 187 + app.toggle_keybinds(); [INFO] [stdout] 188 + if app.show_keybinds { [INFO] [stdout] 189 + app.show_message("Showing Keybinds window".to_owned()); [INFO] [stdout] 190 + } else { [INFO] [stdout] 191 + app.show_message("Hid Keybinds window".to_owned()); [INFO] [stdout] 192 + } [INFO] [stdout] 193 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:95:37 [INFO] [stdout] | [INFO] [stdout] 95 | / ... match table_state.selected() { [INFO] [stdout] 96 | | ... Some(index) => { [INFO] [stdout] 97 | | ... app.randomize(index, false); [INFO] [stdout] ... | [INFO] [stdout] 100 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 ~ if let Some(index) = table_state.selected() { [INFO] [stdout] 96 + app.randomize(index, false); [INFO] [stdout] 97 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:107:40 [INFO] [stdout] | [INFO] [stdout] 107 | ... 'c' => match table_state.selected() { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 108 | | ... Some(index) => { [INFO] [stdout] 109 | | ... app.clear_field(index, false); [INFO] [stdout] ... | [INFO] [stdout] 112 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 ~ 'c' => if let Some(index) = table_state.selected() { [INFO] [stdout] 108 + app.clear_field(index, false); [INFO] [stdout] 109 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:184:49 [INFO] [stdout] | [INFO] [stdout] 184 | ... KeyCode::Char(c) => match c { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 185 | | ... '?' => { [INFO] [stdout] ... | [INFO] [stdout] 195 | | ... _ => {} [INFO] [stdout] 196 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:184:43 [INFO] [stdout] | [INFO] [stdout] 184 | ... KeyCode::Char(c) => match c { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 185 | ... '?' => { [INFO] [stdout] | ^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:184:49 [INFO] [stdout] | [INFO] [stdout] 184 | ... KeyCode::Char(c) => match c { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 185 | | ... '?' => { [INFO] [stdout] ... | [INFO] [stdout] 195 | | ... _ => {} [INFO] [stdout] 196 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 184 ~ KeyCode::Char(c) => if c == '?' { [INFO] [stdout] 185 + // Display a popup window with keybinds [INFO] [stdout] 186 + // toggle the show_keybinds state [INFO] [stdout] 187 + app.toggle_keybinds(); [INFO] [stdout] 188 + if app.show_keybinds { [INFO] [stdout] 189 + app.show_message("Showing Keybinds window".to_owned()); [INFO] [stdout] 190 + } else { [INFO] [stdout] 191 + app.show_message("Hid Keybinds window".to_owned()); [INFO] [stdout] 192 + } [INFO] [stdout] 193 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.29s [INFO] running `Command { std: "docker" "inspect" "572853d3a0a848a47505d1ff5002680fbe79ecdabe6b5cc8146689f6e0903917", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "572853d3a0a848a47505d1ff5002680fbe79ecdabe6b5cc8146689f6e0903917", kill_on_drop: false }` [INFO] [stdout] 572853d3a0a848a47505d1ff5002680fbe79ecdabe6b5cc8146689f6e0903917