[INFO] cloning repository https://github.com/iszak/jpeg2000 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/iszak/jpeg2000" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fiszak%2Fjpeg2000", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fiszak%2Fjpeg2000'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cd46cb933dd5475cb30b554bad870c1cb96d6149 [INFO] linting iszak/jpeg2000 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fiszak%2Fjpeg2000" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/iszak/jpeg2000 [INFO] finished tweaking git repo https://github.com/iszak/jpeg2000 [INFO] tweaked toml for git repo https://github.com/iszak/jpeg2000 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/iszak/jpeg2000 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/iszak/jpeg2000 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5ae2651b826acf5416103287aec1193f9ea4ac279eba1467d98b3e029b386197 [INFO] running `Command { std: "docker" "start" "-a" "5ae2651b826acf5416103287aec1193f9ea4ac279eba1467d98b3e029b386197", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5ae2651b826acf5416103287aec1193f9ea4ac279eba1467d98b3e029b386197", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ae2651b826acf5416103287aec1193f9ea4ac279eba1467d98b3e029b386197", kill_on_drop: false }` [INFO] [stdout] 5ae2651b826acf5416103287aec1193f9ea4ac279eba1467d98b3e029b386197 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b5a7fbcd5a7897b2ffea62a921552ffa8cf6054fad4142804337b46255a528ee [INFO] running `Command { std: "docker" "start" "-a" "b5a7fbcd5a7897b2ffea62a921552ffa8cf6054fad4142804337b46255a528ee", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Compiling jpc v0.1.0 (/opt/rustwide/workdir/jpc) [INFO] [stderr] Checking jiff v0.2.19 [INFO] [stderr] Checking jp2 v0.1.0 (/opt/rustwide/workdir/jp2) [INFO] [stderr] Checking cc v0.1.0 (/opt/rustwide/workdir/icc) [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking clap_builder v4.5.57 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stdout] warning: unused variable: `u0` [INFO] [stdout] --> jpc/src/dwt.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | let u0 = 0; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_u0` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v0` [INFO] [stdout] --> jpc/src/dwt.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 276 | let v0 = 0; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> jp2/src/extension.rs:732:24 [INFO] [stdout] | [INFO] [stdout] 732 | assert_eq!(value as u16, i, "mismatch for {flag:?}"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `dwt::ValidNumeric` is more private than the item `dwt::FilterType::idwt` [INFO] [stdout] --> jpc/src/dwt.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn idwt( [INFO] [stdout] 30 | | &self, [INFO] [stdout] 31 | | ll: Array2D, [INFO] [stdout] 32 | | groups: Vec>>, [INFO] [stdout] 33 | | ) -> Array2D { [INFO] [stdout] | |___________________^ method `dwt::FilterType::idwt` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but trait `dwt::ValidNumeric` is only usable at visibility `pub(self)` [INFO] [stdout] --> jpc/src/dwt.rs:190:1 [INFO] [stdout] | [INFO] [stdout] 190 | trait ValidNumeric: Num + Copy + Default + Euclid + FromPrimitive + std::fmt::Debug {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> jp2/src/lib.rs:3073:9 [INFO] [stdout] | [INFO] [stdout] 3073 | colour_specification_box.length = input.len() as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `colour_specification::ColourSpecificationBox { length: input.len() as u64, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> jp2/src/lib.rs:3072:9 [INFO] [stdout] | [INFO] [stdout] 3072 | let mut colour_specification_box = ColourSpecificationBox::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:219:15 [INFO] [stdout] | [INFO] [stdout] 219 | while !(vb >= v1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vb < v1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:221:19 [INFO] [stdout] | [INFO] [stdout] 221 | while !(ub >= u1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ub < u1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:234:15 [INFO] [stdout] | [INFO] [stdout] 234 | while !(vb >= v1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vb < v1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:236:19 [INFO] [stdout] | [INFO] [stdout] 236 | while !(ub >= u1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(ub < u1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 248 | while !(vb >= v1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(vb < v1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:250:19 [INFO] [stdout] | [INFO] [stdout] 250 | while !(ub >= u1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ub < u1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:261:15 [INFO] [stdout] | [INFO] [stdout] 261 | while !(vb >= v1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(vb < v1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:263:19 [INFO] [stdout] | [INFO] [stdout] 263 | while !(ub >= u1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(ub < u1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:283:15 [INFO] [stdout] | [INFO] [stdout] 283 | while !(vb >= v1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vb < v1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:285:19 [INFO] [stdout] | [INFO] [stdout] 285 | while !(ub >= u1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ub < u1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:296:15 [INFO] [stdout] | [INFO] [stdout] 296 | while !(vb >= v1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vb < v1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:298:19 [INFO] [stdout] | [INFO] [stdout] 298 | while !(ub >= u1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(ub < u1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:309:15 [INFO] [stdout] | [INFO] [stdout] 309 | while !(vb >= v1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(vb < v1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:311:19 [INFO] [stdout] | [INFO] [stdout] 311 | while !(ub >= u1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ub < u1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:322:15 [INFO] [stdout] | [INFO] [stdout] 322 | while !(vb >= v1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(vb < v1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:324:19 [INFO] [stdout] | [INFO] [stdout] 324 | while !(ub >= u1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(ub < u1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `reader_requirements.standard_flags().get(0)` [INFO] [stdout] --> jp2/tests/parse_tests.rs:216:10 [INFO] [stdout] | [INFO] [stdout] 216 | *reader_requirements.standard_flags().get(0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reader_requirements.standard_flags().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking jpxml v0.1.0 (/opt/rustwide/workdir/jpxml) [INFO] [stdout] warning: accessing first element with `reader_requirements.standard_flags().get(0)` [INFO] [stdout] --> jp2/tests/parse_tests.rs:311:10 [INFO] [stdout] | [INFO] [stdout] 311 | *reader_requirements.standard_flags().get(0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reader_requirements.standard_flags().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jp2/tests/parse_tests.rs:747:5 [INFO] [stdout] | [INFO] [stdout] 747 | assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 747 - assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] 747 + assert!(!image_header_box.values_are_signed()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jp2/tests/parse_tests.rs:876:5 [INFO] [stdout] | [INFO] [stdout] 876 | assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 876 - assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] 876 + assert!(!image_header_box.values_are_signed()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jp2/tests/parse_tests.rs:926:5 [INFO] [stdout] | [INFO] [stdout] 926 | assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 926 - assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] 926 + assert!(!image_header_box.values_are_signed()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jp2/tests/parse_tests.rs:960:5 [INFO] [stdout] | [INFO] [stdout] 960 | assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 960 - assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] 960 + assert!(!image_header_box.values_are_signed()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jp2/tests/parse_tests.rs:1043:5 [INFO] [stdout] | [INFO] [stdout] 1043 | assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1043 - assert_eq!(image_header_box.values_are_signed(), false); [INFO] [stdout] 1043 + assert!(!image_header_box.values_are_signed()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/pointer_marker_tests.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 46 - assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] 46 + assert!(!siz.values_are_signed(0).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/pointer_marker_tests.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | assert_eq!(siz.values_are_signed(1).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 48 - assert_eq!(siz.values_are_signed(1).unwrap(), false); [INFO] [stdout] 48 + assert!(!siz.values_are_signed(1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/pointer_marker_tests.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | assert_eq!(siz.values_are_signed(2).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 50 - assert_eq!(siz.values_are_signed(2).unwrap(), false); [INFO] [stdout] 50 + assert!(!siz.values_are_signed(2).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/pointer_marker_tests.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | / assert_eq!( [INFO] [stdout] 110 | | cod.coding_style_parameters().has_defined_precinct_size(), [INFO] [stdout] 111 | | false [INFO] [stdout] 112 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 109 ~ assert!( [INFO] [stdout] 110 ~ !cod.coding_style_parameters().has_defined_precinct_size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/pointer_marker_tests.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | / assert_eq!( [INFO] [stdout] 114 | | cod.coding_style_parameters().has_default_precinct_size(), [INFO] [stdout] 115 | | true [INFO] [stdout] 116 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 113 ~ assert!( [INFO] [stdout] 114 ~ cod.coding_style_parameters().has_default_precinct_size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 38 - assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] 38 + assert!(!siz.values_are_signed(0).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | assert_eq!(siz.values_are_signed(1).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 40 - assert_eq!(siz.values_are_signed(1).unwrap(), false); [INFO] [stdout] 40 + assert!(!siz.values_are_signed(1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | assert_eq!(siz.values_are_signed(2).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 42 - assert_eq!(siz.values_are_signed(2).unwrap(), false); [INFO] [stdout] 42 + assert!(!siz.values_are_signed(2).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | / assert_eq!( [INFO] [stdout] 102 | | cod.coding_style_parameters().has_defined_precinct_size(), [INFO] [stdout] 103 | | false [INFO] [stdout] 104 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 101 ~ assert!( [INFO] [stdout] 102 ~ !cod.coding_style_parameters().has_defined_precinct_size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | / assert_eq!( [INFO] [stdout] 106 | | cod.coding_style_parameters().has_default_precinct_size(), [INFO] [stdout] 107 | | true [INFO] [stdout] 108 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 105 ~ assert!( [INFO] [stdout] 106 ~ cod.coding_style_parameters().has_default_precinct_size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 191 - assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] 191 + assert!(!siz.values_are_signed(0).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | assert_eq!(siz.values_are_signed(1).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 193 - assert_eq!(siz.values_are_signed(1).unwrap(), false); [INFO] [stdout] 193 + assert!(!siz.values_are_signed(1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | assert_eq!(siz.values_are_signed(2).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 195 - assert_eq!(siz.values_are_signed(2).unwrap(), false); [INFO] [stdout] 195 + assert!(!siz.values_are_signed(2).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | / assert_eq!( [INFO] [stdout] 255 | | cod.coding_style_parameters().has_defined_precinct_size(), [INFO] [stdout] 256 | | false [INFO] [stdout] 257 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 254 ~ assert!( [INFO] [stdout] 255 ~ !cod.coding_style_parameters().has_defined_precinct_size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/packet_marker_tests.rs:258:5 [INFO] [stdout] | [INFO] [stdout] 258 | / assert_eq!( [INFO] [stdout] 259 | | cod.coding_style_parameters().has_default_precinct_size(), [INFO] [stdout] 260 | | true [INFO] [stdout] 261 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 258 ~ assert!( [INFO] [stdout] 259 ~ cod.coding_style_parameters().has_default_precinct_size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/parse_tests.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 38 - assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] 38 + assert!(!siz.values_are_signed(0).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/parse_tests.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | assert_eq!(siz.values_are_signed(1).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 40 - assert_eq!(siz.values_are_signed(1).unwrap(), false); [INFO] [stdout] 40 + assert!(!siz.values_are_signed(1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/parse_tests.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | assert_eq!(siz.values_are_signed(2).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 42 - assert_eq!(siz.values_are_signed(2).unwrap(), false); [INFO] [stdout] 42 + assert!(!siz.values_are_signed(2).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/tests/parse_caps_tests.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 43 - assert_eq!(siz.values_are_signed(0).unwrap(), false); [INFO] [stdout] 43 + assert!(!siz.values_are_signed(0).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking clap v4.5.57 [INFO] [stderr] Checking jp2000 v0.1.0 (/opt/rustwide/workdir/jpeg2000) [INFO] [stdout] warning: unused variable: `u0` [INFO] [stdout] --> jpc/src/dwt.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | let u0 = 0; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_u0` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v0` [INFO] [stdout] --> jpc/src/dwt.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 276 | let v0 = 0; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> jpc/src/dwt.rs:436:14 [INFO] [stdout] | [INFO] [stdout] 436 | for (i, (&orig, &recon)) in signal.iter().zip(reconstructed.iter()).enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `dwt::ValidNumeric` is more private than the item `dwt::FilterType::idwt` [INFO] [stdout] --> jpc/src/dwt.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn idwt( [INFO] [stdout] 30 | | &self, [INFO] [stdout] 31 | | ll: Array2D, [INFO] [stdout] 32 | | groups: Vec>>, [INFO] [stdout] 33 | | ) -> Array2D { [INFO] [stdout] | |___________________^ method `dwt::FilterType::idwt` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but trait `dwt::ValidNumeric` is only usable at visibility `pub(self)` [INFO] [stdout] --> jpc/src/dwt.rs:190:1 [INFO] [stdout] | [INFO] [stdout] 190 | trait ValidNumeric: Num + Copy + Default + Euclid + FromPrimitive + std::fmt::Debug {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/src/coder.rs:557:9 [INFO] [stdout] | [INFO] [stdout] 557 | assert_eq!(QE_TABLE[0].switch, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 557 - assert_eq!(QE_TABLE[0].switch, true); [INFO] [stdout] 557 + assert!(QE_TABLE[0].switch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/src/coder.rs:562:9 [INFO] [stdout] | [INFO] [stdout] 562 | assert_eq!(QE_TABLE[22].switch, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 562 - assert_eq!(QE_TABLE[22].switch, false); [INFO] [stdout] 562 + assert!(!QE_TABLE[22].switch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> jpc/src/coder.rs:567:9 [INFO] [stdout] | [INFO] [stdout] 567 | assert_eq!(QE_TABLE[46].switch, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 567 - assert_eq!(QE_TABLE[46].switch, false); [INFO] [stdout] 567 + assert!(!QE_TABLE[46].switch); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `cx` is used to index `decoded_sequences` [INFO] [stdout] --> jpc/src/coder.rs:725:23 [INFO] [stdout] | [INFO] [stdout] 725 | for cx in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 725 - for cx in 0..4 { [INFO] [stdout] 725 + for (cx, ) in decoded_sequences.iter_mut().enumerate().take(4) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:219:15 [INFO] [stdout] | [INFO] [stdout] 219 | while !(vb >= v1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vb < v1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:221:19 [INFO] [stdout] | [INFO] [stdout] 221 | while !(ub >= u1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ub < u1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:234:15 [INFO] [stdout] | [INFO] [stdout] 234 | while !(vb >= v1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vb < v1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:236:19 [INFO] [stdout] | [INFO] [stdout] 236 | while !(ub >= u1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(ub < u1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 248 | while !(vb >= v1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(vb < v1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:250:19 [INFO] [stdout] | [INFO] [stdout] 250 | while !(ub >= u1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ub < u1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:261:15 [INFO] [stdout] | [INFO] [stdout] 261 | while !(vb >= v1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(vb < v1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:263:19 [INFO] [stdout] | [INFO] [stdout] 263 | while !(ub >= u1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(ub < u1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:283:15 [INFO] [stdout] | [INFO] [stdout] 283 | while !(vb >= v1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vb < v1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:285:19 [INFO] [stdout] | [INFO] [stdout] 285 | while !(ub >= u1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ub < u1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:296:15 [INFO] [stdout] | [INFO] [stdout] 296 | while !(vb >= v1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vb < v1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:298:19 [INFO] [stdout] | [INFO] [stdout] 298 | while !(ub >= u1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(ub < u1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:309:15 [INFO] [stdout] | [INFO] [stdout] 309 | while !(vb >= v1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(vb < v1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:311:19 [INFO] [stdout] | [INFO] [stdout] 311 | while !(ub >= u1.div_ceil(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ub < u1.div_ceil(2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:322:15 [INFO] [stdout] | [INFO] [stdout] 322 | while !(vb >= v1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(vb < v1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> jpc/src/dwt.rs:324:19 [INFO] [stdout] | [INFO] [stdout] 324 | while !(ub >= u1 / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(ub < u1 / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.36s [INFO] running `Command { std: "docker" "inspect" "b5a7fbcd5a7897b2ffea62a921552ffa8cf6054fad4142804337b46255a528ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5a7fbcd5a7897b2ffea62a921552ffa8cf6054fad4142804337b46255a528ee", kill_on_drop: false }` [INFO] [stdout] b5a7fbcd5a7897b2ffea62a921552ffa8cf6054fad4142804337b46255a528ee