[INFO] cloning repository https://github.com/isotope-rs/adrnaln-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/isotope-rs/adrnaln-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisotope-rs%2Fadrnaln-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisotope-rs%2Fadrnaln-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7248abbb45d39e581028c15105cce0bacb0cb4b5 [INFO] linting isotope-rs/adrnaln-cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisotope-rs%2Fadrnaln-cli" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/isotope-rs/adrnaln-cli [INFO] finished tweaking git repo https://github.com/isotope-rs/adrnaln-cli [INFO] tweaked toml for git repo https://github.com/isotope-rs/adrnaln-cli written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/isotope-rs/adrnaln-cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/isotope-rs/adrnaln-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zerocopy-derive v0.8.0-alpha.6 [INFO] [stderr] Downloaded anstyle-query v1.0.3 [INFO] [stderr] Downloaded rand_chacha v0.9.0-alpha.1 [INFO] [stderr] Downloaded opentelemetry-semantic-conventions v0.9.0 [INFO] [stderr] Downloaded thrift v0.15.0 [INFO] [stderr] Downloaded opentelemetry-jaeger v0.16.0 [INFO] [stderr] Downloaded rand v0.9.0-alpha.1 [INFO] [stderr] Downloaded tracing-opentelemetry v0.17.4 [INFO] [stderr] Downloaded rand_core v0.9.0-alpha.1 [INFO] [stderr] Downloaded zerocopy v0.8.0-alpha.6 [INFO] [stderr] Downloaded adrnaln v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a03b6b6d27d9cc9c11a2512aeb37df3bd68147900874a15f8bc95b586cd02f1f [INFO] running `Command { std: "docker" "start" "-a" "a03b6b6d27d9cc9c11a2512aeb37df3bd68147900874a15f8bc95b586cd02f1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a03b6b6d27d9cc9c11a2512aeb37df3bd68147900874a15f8bc95b586cd02f1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a03b6b6d27d9cc9c11a2512aeb37df3bd68147900874a15f8bc95b586cd02f1f", kill_on_drop: false }` [INFO] [stdout] a03b6b6d27d9cc9c11a2512aeb37df3bd68147900874a15f8bc95b586cd02f1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35e5d63b2270a63537d45db736c89f7a5f35eb5d77b3b15d054b734a3740f34c [INFO] running `Command { std: "docker" "start" "-a" "35e5d63b2270a63537d45db736c89f7a5f35eb5d77b3b15d054b734a3740f34c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling zerocopy v0.8.0-alpha.6 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking thrift v0.15.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_core v0.9.0-alpha.1 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking rand v0.9.0-alpha.1 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking opentelemetry v0.17.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking opentelemetry-semantic-conventions v0.9.0 [INFO] [stderr] Checking tracing-opentelemetry v0.17.4 [INFO] [stderr] Checking opentelemetry-jaeger v0.16.0 [INFO] [stderr] Checking adrnaln v0.1.2 [INFO] [stderr] Checking adrnaln-cli v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `ServerArgs` is more private than the item `Mode::Server::0` [INFO] [stdout] --> src/main.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | Server(ServerArgs), [INFO] [stdout] | ^^^^^^^^^^ field `Mode::Server::0` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `ServerArgs` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/main.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | struct ServerArgs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ClientArgs` is more private than the item `Mode::Client::0` [INFO] [stdout] --> src/main.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | Client(ClientArgs), [INFO] [stdout] | ^^^^^^^^^^ field `Mode::Client::0` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `ClientArgs` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | struct ClientArgs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:79:36 [INFO] [stdout] | [INFO] [stdout] 79 | ... if !download_directory.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `download_directory.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `download_directory` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:80:44 [INFO] [stdout] | [INFO] [stdout] 79 | ... if !download_directory.is_none() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] 80 | ... path = download_directory.as_ref().unwrap().as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ServerArgs` is more private than the item `Mode::Server::0` [INFO] [stdout] --> src/main.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | Server(ServerArgs), [INFO] [stdout] | ^^^^^^^^^^ field `Mode::Server::0` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `ServerArgs` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/main.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | struct ServerArgs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ClientArgs` is more private than the item `Mode::Client::0` [INFO] [stdout] --> src/main.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | Client(ClientArgs), [INFO] [stdout] | ^^^^^^^^^^ field `Mode::Client::0` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `ClientArgs` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | struct ClientArgs { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:79:36 [INFO] [stdout] | [INFO] [stdout] 79 | ... if !download_directory.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `download_directory.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `download_directory` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:80:44 [INFO] [stdout] | [INFO] [stdout] 79 | ... if !download_directory.is_none() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] 80 | ... path = download_directory.as_ref().unwrap().as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.46s [INFO] running `Command { std: "docker" "inspect" "35e5d63b2270a63537d45db736c89f7a5f35eb5d77b3b15d054b734a3740f34c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35e5d63b2270a63537d45db736c89f7a5f35eb5d77b3b15d054b734a3740f34c", kill_on_drop: false }` [INFO] [stdout] 35e5d63b2270a63537d45db736c89f7a5f35eb5d77b3b15d054b734a3740f34c