[INFO] cloning repository https://github.com/isamert/marks [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/isamert/marks" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisamert%2Fmarks", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisamert%2Fmarks'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7dfc4bff5be40aac45ae14f5ba3f9a93da2494dc [INFO] linting isamert/marks against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisamert%2Fmarks" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/isamert/marks [INFO] finished tweaking git repo https://github.com/isamert/marks [INFO] tweaked toml for git repo https://github.com/isamert/marks written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/isamert/marks on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/isamert/marks already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded structopt v0.3.26 [INFO] [stderr] Downloaded fuzzy-matcher v0.3.7 [INFO] [stderr] Downloaded paw-raw v1.0.0 [INFO] [stderr] Downloaded paw-attributes v1.0.2 [INFO] [stderr] Downloaded term v1.0.1 [INFO] [stderr] Downloaded paw v1.0.0 [INFO] [stderr] Downloaded structopt-derive v0.4.18 [INFO] [stderr] Downloaded cc v1.2.11 [INFO] [stderr] Downloaded chrono v0.4.39 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ef655ccadc5565d47fa2a5ad4e66d0875607a24aa44cd335e9bd5223182dbf0 [INFO] running `Command { std: "docker" "start" "-a" "3ef655ccadc5565d47fa2a5ad4e66d0875607a24aa44cd335e9bd5223182dbf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ef655ccadc5565d47fa2a5ad4e66d0875607a24aa44cd335e9bd5223182dbf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ef655ccadc5565d47fa2a5ad4e66d0875607a24aa44cd335e9bd5223182dbf0", kill_on_drop: false }` [INFO] [stdout] 3ef655ccadc5565d47fa2a5ad4e66d0875607a24aa44cd335e9bd5223182dbf0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fd4c306bacfaa89066c93f09806cab9f1e17dcb3001a5d9dbe9f072e5ee1036d [INFO] running `Command { std: "docker" "start" "-a" "fd4c306bacfaa89066c93f09806cab9f1e17dcb3001a5d9dbe9f072e5ee1036d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking paw-raw v1.0.0 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking clap_builder v4.5.27 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking term v1.0.1 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking clap v4.5.27 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling paw-attributes v1.0.2 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking paw v1.0.0 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking marks v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/org/datetime.rs:47:114 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn compare_with(&self, other: &Self, compare1: fn(&DateTime, &DateTime) -> bool, compare2: fn(&Date, &Date` instead [INFO] [stdout] --> src/org/datetime.rs:47:126 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn compare_with(&self, other: &Self, compare1: fn(&DateTime, &DateTime) -> bool, compare2: fn(&Date, &Date` instead [INFO] [stdout] --> src/org/datetime.rs:47:114 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn compare_with(&self, other: &Self, compare1: fn(&DateTime, &DateTime) -> bool, compare2: fn(&Date, &Date` instead [INFO] [stdout] --> src/org/datetime.rs:47:126 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn compare_with(&self, other: &Self, compare1: fn(&DateTime, &DateTime) -> bool, compare2: fn(&Date, &Date src/parsers.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | Utc.ymd(year, month, day).and_hms(hour.0 .0, hour.0 .1, 0), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 51 | Utc.ymd(year, month, day).and_hms(hour.0 .0, hour.0 .1, 0), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | hour.1.map(|end| Utc.ymd(year, month, day).and_hms(end.0, end.1, 0)) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:52:52 [INFO] [stdout] | [INFO] [stdout] 52 | hour.1.map(|end| Utc.ymd(year, month, day).and_hms(end.0, end.1, 0)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | Utc.ymd(year, month, day).and_hms(hour.0 .0, hour.0 .1, 0), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 51 | Utc.ymd(year, month, day).and_hms(hour.0 .0, hour.0 .1, 0), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | hour.1.map(|end| Utc.ymd(year, month, day).and_hms(end.0, end.1, 0)) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:52:52 [INFO] [stdout] | [INFO] [stdout] 52 | hour.1.map(|end| Utc.ymd(year, month, day).and_hms(end.0, end.1, 0)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/org/datetime.rs:52:39 [INFO] [stdout] | [INFO] [stdout] 52 | compare2(&self.date_start.date(), &other.date_start.date()) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/org/datetime.rs:52:65 [INFO] [stdout] | [INFO] [stdout] 52 | compare2(&self.date_start.date(), &other.date_start.date()) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:170:29 [INFO] [stdout] | [INFO] [stdout] 170 | date_start: Utc.ymd(2020, 12, 24).and_hms(0, 0, 0), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:170:47 [INFO] [stdout] | [INFO] [stdout] 170 | date_start: Utc.ymd(2020, 12, 24).and_hms(0, 0, 0), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:184:29 [INFO] [stdout] | [INFO] [stdout] 184 | date_start: Utc.ymd(2020, 12, 24).and_hms(13, 30, 0), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:184:47 [INFO] [stdout] | [INFO] [stdout] 184 | date_start: Utc.ymd(2020, 12, 24).and_hms(13, 30, 0), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:198:29 [INFO] [stdout] | [INFO] [stdout] 198 | date_start: Utc.ymd(2020, 12, 24).and_hms(13, 30, 0), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:198:47 [INFO] [stdout] | [INFO] [stdout] 198 | date_start: Utc.ymd(2020, 12, 24).and_hms(13, 30, 0), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:212:29 [INFO] [stdout] | [INFO] [stdout] 212 | date_start: Utc.ymd(2020, 12, 24).and_hms(13, 30, 0), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:212:47 [INFO] [stdout] | [INFO] [stdout] 212 | date_start: Utc.ymd(2020, 12, 24).and_hms(13, 30, 0), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:226:29 [INFO] [stdout] | [INFO] [stdout] 226 | date_start: Utc.ymd(2020, 12, 24).and_hms(13, 30, 0), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:226:47 [INFO] [stdout] | [INFO] [stdout] 226 | date_start: Utc.ymd(2020, 12, 24).and_hms(13, 30, 0), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/parsers.rs:227:32 [INFO] [stdout] | [INFO] [stdout] 227 | date_end: Some(Utc.ymd(2020, 12, 24).and_hms(22, 35, 0)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/parsers.rs:227:50 [INFO] [stdout] | [INFO] [stdout] 227 | date_end: Some(Utc.ymd(2020, 12, 24).and_hms(22, 35, 0)), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/org/datetime.rs:52:39 [INFO] [stdout] | [INFO] [stdout] 52 | compare2(&self.date_start.date(), &other.date_start.date()) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/org/datetime.rs:52:65 [INFO] [stdout] | [INFO] [stdout] 52 | compare2(&self.date_start.date(), &other.date_start.date()) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/org/header.rs:13:42 [INFO] [stdout] | [INFO] [stdout] 13 | } else if self.0.chars().all(|x| x.is_digit(10)) { // 2 > 1 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/query.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | many1(non_ws).map(|x| QueryToken::Plain(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `QueryToken::Plain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/query.rs:81:1 [INFO] [stdout] | [INFO] [stdout] 81 | / impl Default for Query { [INFO] [stdout] 82 | | fn default() -> Self { [INFO] [stdout] 83 | | Query { [INFO] [stdout] 84 | | full: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Default)] [INFO] [stdout] 17 | pub struct Query { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/query.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/result.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | if self.headers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.headers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/args.rs:121:16 [INFO] [stdout] | [INFO] [stdout] 121 | fn parse_props<'a>(s: &'a str) -> Result<(String, String), String> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 121 - fn parse_props<'a>(s: &'a str) -> Result<(String, String), String> { [INFO] [stdout] 121 + fn parse_props(s: &str) -> Result<(String, String), String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/args.rs:136:16 [INFO] [stdout] | [INFO] [stdout] 136 | fn parse_todos<'a>(s: &'a str) -> Result { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 136 - fn parse_todos<'a>(s: &'a str) -> Result { [INFO] [stdout] 136 + fn parse_todos(s: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/args.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | fn parse_priority<'a>(s: &'a str) -> Result { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 144 - fn parse_priority<'a>(s: &'a str) -> Result { [INFO] [stdout] 144 + fn parse_priority(s: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/marks.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return None; [INFO] [stdout] 52 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/marks.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | / if e.file_type().is_file() { [INFO] [stdout] 45 | | if (!self.args.no_org && self.is_org_file(&e)) [INFO] [stdout] 46 | | || (!self.args.no_markdown && self.is_md_file(&e)) [INFO] [stdout] ... | [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 44 ~ if e.file_type().is_file() [INFO] [stdout] 45 ~ && ((!self.args.no_org && self.is_org_file(&e)) [INFO] [stdout] 46 ~ || (!self.args.no_markdown && self.is_md_file(&e))) [INFO] [stdout] 47 | { [INFO] [stdout] 48 | return Some(e); [INFO] [stdout] 49 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/marks.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | if !(!skip_section && depth > last_depth) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `skip_section || depth <= last_depth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/marks.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | return Some(results); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return Some(results); [INFO] [stdout] 227 + Some(results) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/marks.rs:59:42 [INFO] [stdout] | [INFO] [stdout] 59 | let doc_type = self.get_doc_type(&file); [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/marks.rs:68:39 [INFO] [stdout] | [INFO] [stdout] 68 | let mut iter = reader.lines().filter_map(|x| x.ok()).enumerate().peekable(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/marks.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | let mut iter = reader.lines().filter_map(|x| x.ok()).enumerate().peekable(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:120:38 [INFO] [stdout] | [INFO] [stdout] 120 | ... .any(|x| curr_header.todo.as_ref().map_or(false, |y| y == x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 120 - .any(|x| curr_header.todo.as_ref().map_or(false, |y| y == x)); [INFO] [stdout] 120 + .any(|x| curr_header.todo.as_ref() == Some(x)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:129:38 [INFO] [stdout] | [INFO] [stdout] 129 | ... .any(|x| curr_header.priority.as_ref().map_or(false, |y| x == y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 129 - .any(|x| curr_header.priority.as_ref().map_or(false, |y| x == y)); [INFO] [stdout] 129 + .any(|x| curr_header.priority.as_ref() == Some(x)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:135:42 [INFO] [stdout] | [INFO] [stdout] 135 | let is_lt_than = curr_header [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 136 | | .priority [INFO] [stdout] 137 | | .as_ref() [INFO] [stdout] 138 | | .map_or(false, |x| x < priority); [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 138 - .map_or(false, |x| x < priority); [INFO] [stdout] 138 + .is_some_and(|x| x < priority); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:143:42 [INFO] [stdout] | [INFO] [stdout] 143 | let is_gt_than = curr_header [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 144 | | .priority [INFO] [stdout] 145 | | .as_ref() [INFO] [stdout] 146 | | .map_or(false, |x| x > priority); [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 146 - .map_or(false, |x| x > priority); [INFO] [stdout] 146 + .is_some_and(|x| x > priority); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:152:57 [INFO] [stdout] | [INFO] [stdout] 152 | skip_section = skip_section || !curr_header [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 153 | | .datetime [INFO] [stdout] 154 | | .as_ref() [INFO] [stdout] 155 | | .map_or(false, |datetime| datetime.compare_with(schedule, PartialEq::eq, PartialEq::eq)); [INFO] [stdout] | |____________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 155 - .map_or(false, |datetime| datetime.compare_with(schedule, PartialEq::eq, PartialEq::eq)); [INFO] [stdout] 155 + .is_some_and(|datetime| datetime.compare_with(schedule, PartialEq::eq, PartialEq::eq)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/marks.rs:192:37 [INFO] [stdout] | [INFO] [stdout] 192 | result.push_str(&filename); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `filename` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/marks.rs:212:65 [INFO] [stdout] | [INFO] [stdout] 212 | .filter_map(|q| self.matcher.fuzzy_match(&full, &q)) [INFO] [stdout] | ^^ help: change this to: `q` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/marks.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | if points.len() > 0 || self.args.query.rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!points.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/marks.rs:214:36 [INFO] [stdout] | [INFO] [stdout] 214 | if points.len() > 0 || self.args.query.rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.args.query.rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/marks.rs:239:36 [INFO] [stdout] | [INFO] [stdout] 239 | match e.path().extension().map(|x| x.to_str()).flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/marks.rs:246:36 [INFO] [stdout] | [INFO] [stdout] 246 | match e.path().extension().map(|x| x.to_str()).flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/marks.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | return DocType::Markdown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return DocType::Markdown; [INFO] [stdout] 254 + DocType::Markdown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/marks.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | return DocType::OrgMode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return DocType::OrgMode; [INFO] [stdout] 256 + DocType::OrgMode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/marks.rs:275:25 [INFO] [stdout] | [INFO] [stdout] 275 | let mut chars = line.chars().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `line.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/marks.rs:369:13 [INFO] [stdout] | [INFO] [stdout] 369 | while let Some((_, prop)) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (_, prop) in iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/marks.rs:57:24 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn search_file(&self, file: &DirEntry) -> Option> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 57 | pub fn search_file(&self, file: &DirEntry) -> Option>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/marks.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 266 | ) -> Option [INFO] [stdout] | ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 266 | ) -> Option> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/org/header.rs:13:42 [INFO] [stdout] | [INFO] [stdout] 13 | } else if self.0.chars().all(|x| x.is_digit(10)) { // 2 > 1 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/query.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | many1(non_ws).map(|x| QueryToken::Plain(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `QueryToken::Plain` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/query.rs:81:1 [INFO] [stdout] | [INFO] [stdout] 81 | / impl Default for Query { [INFO] [stdout] 82 | | fn default() -> Self { [INFO] [stdout] 83 | | Query { [INFO] [stdout] 84 | | full: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Default)] [INFO] [stdout] 17 | pub struct Query { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/result.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | if self.headers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.headers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/args.rs:121:16 [INFO] [stdout] | [INFO] [stdout] 121 | fn parse_props<'a>(s: &'a str) -> Result<(String, String), String> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 121 - fn parse_props<'a>(s: &'a str) -> Result<(String, String), String> { [INFO] [stdout] 121 + fn parse_props(s: &str) -> Result<(String, String), String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/args.rs:136:16 [INFO] [stdout] | [INFO] [stdout] 136 | fn parse_todos<'a>(s: &'a str) -> Result { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 136 - fn parse_todos<'a>(s: &'a str) -> Result { [INFO] [stdout] 136 + fn parse_todos(s: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/args.rs:144:19 [INFO] [stdout] | [INFO] [stdout] 144 | fn parse_priority<'a>(s: &'a str) -> Result { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 144 - fn parse_priority<'a>(s: &'a str) -> Result { [INFO] [stdout] 144 + fn parse_priority(s: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/marks.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return None; [INFO] [stdout] 52 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/marks.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | / if e.file_type().is_file() { [INFO] [stdout] 45 | | if (!self.args.no_org && self.is_org_file(&e)) [INFO] [stdout] 46 | | || (!self.args.no_markdown && self.is_md_file(&e)) [INFO] [stdout] ... | [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 44 ~ if e.file_type().is_file() [INFO] [stdout] 45 ~ && ((!self.args.no_org && self.is_org_file(&e)) [INFO] [stdout] 46 ~ || (!self.args.no_markdown && self.is_md_file(&e))) [INFO] [stdout] 47 | { [INFO] [stdout] 48 | return Some(e); [INFO] [stdout] 49 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/marks.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | if !(!skip_section && depth > last_depth) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `skip_section || depth <= last_depth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/marks.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | return Some(results); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return Some(results); [INFO] [stdout] 227 + Some(results) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/marks.rs:59:42 [INFO] [stdout] | [INFO] [stdout] 59 | let doc_type = self.get_doc_type(&file); [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/marks.rs:68:39 [INFO] [stdout] | [INFO] [stdout] 68 | let mut iter = reader.lines().filter_map(|x| x.ok()).enumerate().peekable(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/marks.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | let mut iter = reader.lines().filter_map(|x| x.ok()).enumerate().peekable(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:120:38 [INFO] [stdout] | [INFO] [stdout] 120 | ... .any(|x| curr_header.todo.as_ref().map_or(false, |y| y == x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 120 - .any(|x| curr_header.todo.as_ref().map_or(false, |y| y == x)); [INFO] [stdout] 120 + .any(|x| curr_header.todo.as_ref() == Some(x)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:129:38 [INFO] [stdout] | [INFO] [stdout] 129 | ... .any(|x| curr_header.priority.as_ref().map_or(false, |y| x == y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 129 - .any(|x| curr_header.priority.as_ref().map_or(false, |y| x == y)); [INFO] [stdout] 129 + .any(|x| curr_header.priority.as_ref() == Some(x)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:135:42 [INFO] [stdout] | [INFO] [stdout] 135 | let is_lt_than = curr_header [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 136 | | .priority [INFO] [stdout] 137 | | .as_ref() [INFO] [stdout] 138 | | .map_or(false, |x| x < priority); [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 138 - .map_or(false, |x| x < priority); [INFO] [stdout] 138 + .is_some_and(|x| x < priority); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:143:42 [INFO] [stdout] | [INFO] [stdout] 143 | let is_gt_than = curr_header [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 144 | | .priority [INFO] [stdout] 145 | | .as_ref() [INFO] [stdout] 146 | | .map_or(false, |x| x > priority); [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 146 - .map_or(false, |x| x > priority); [INFO] [stdout] 146 + .is_some_and(|x| x > priority); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/marks.rs:152:57 [INFO] [stdout] | [INFO] [stdout] 152 | skip_section = skip_section || !curr_header [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 153 | | .datetime [INFO] [stdout] 154 | | .as_ref() [INFO] [stdout] 155 | | .map_or(false, |datetime| datetime.compare_with(schedule, PartialEq::eq, PartialEq::eq)); [INFO] [stdout] | |____________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 155 - .map_or(false, |datetime| datetime.compare_with(schedule, PartialEq::eq, PartialEq::eq)); [INFO] [stdout] 155 + .is_some_and(|datetime| datetime.compare_with(schedule, PartialEq::eq, PartialEq::eq)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/marks.rs:192:37 [INFO] [stdout] | [INFO] [stdout] 192 | result.push_str(&filename); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `filename` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/marks.rs:212:65 [INFO] [stdout] | [INFO] [stdout] 212 | .filter_map(|q| self.matcher.fuzzy_match(&full, &q)) [INFO] [stdout] | ^^ help: change this to: `q` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/marks.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | if points.len() > 0 || self.args.query.rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!points.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/marks.rs:214:36 [INFO] [stdout] | [INFO] [stdout] 214 | if points.len() > 0 || self.args.query.rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.args.query.rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/marks.rs:239:36 [INFO] [stdout] | [INFO] [stdout] 239 | match e.path().extension().map(|x| x.to_str()).flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/marks.rs:246:36 [INFO] [stdout] | [INFO] [stdout] 246 | match e.path().extension().map(|x| x.to_str()).flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.to_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/marks.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | return DocType::Markdown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return DocType::Markdown; [INFO] [stdout] 254 + DocType::Markdown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/marks.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | return DocType::OrgMode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return DocType::OrgMode; [INFO] [stdout] 256 + DocType::OrgMode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/marks.rs:275:25 [INFO] [stdout] | [INFO] [stdout] 275 | let mut chars = line.chars().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `line.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/marks.rs:369:13 [INFO] [stdout] | [INFO] [stdout] 369 | while let Some((_, prop)) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (_, prop) in iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/marks.rs:57:24 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn search_file(&self, file: &DirEntry) -> Option> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 57 | pub fn search_file(&self, file: &DirEntry) -> Option>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/marks.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 261 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 266 | ) -> Option [INFO] [stdout] | ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 266 | ) -> Option> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:21:41 [INFO] [stdout] | [INFO] [stdout] 21 | .filter_map(|f| app.search_file(&f)) [INFO] [stdout] | ^^ help: change this to: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/main.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|x| { x.is_header = true; x }) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 - .map(|x| { x.is_header = true; x }) [INFO] [stdout] 33 + .inspect(|x| { x.is_header = true; }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:21:41 [INFO] [stdout] | [INFO] [stdout] 21 | .filter_map(|f| app.search_file(&f)) [INFO] [stdout] | ^^ help: change this to: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/main.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|x| { x.is_header = true; x }) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 - .map(|x| { x.is_header = true; x }) [INFO] [stdout] 33 + .inspect(|x| { x.is_header = true; }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.38s [INFO] running `Command { std: "docker" "inspect" "fd4c306bacfaa89066c93f09806cab9f1e17dcb3001a5d9dbe9f072e5ee1036d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd4c306bacfaa89066c93f09806cab9f1e17dcb3001a5d9dbe9f072e5ee1036d", kill_on_drop: false }` [INFO] [stdout] fd4c306bacfaa89066c93f09806cab9f1e17dcb3001a5d9dbe9f072e5ee1036d