[INFO] cloning repository https://github.com/isabelroses/bellado [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/isabelroses/bellado" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisabelroses%2Fbellado", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisabelroses%2Fbellado'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8b9bb4e19b06a35acd8b2d39830c2751246ff189 [INFO] linting isabelroses/bellado against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisabelroses%2Fbellado" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/isabelroses/bellado [INFO] finished tweaking git repo https://github.com/isabelroses/bellado [INFO] tweaked toml for git repo https://github.com/isabelroses/bellado written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/isabelroses/bellado on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/isabelroses/bellado already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror-impl v1.0.50 [INFO] [stderr] Downloaded clap_complete v4.4.4 [INFO] [stderr] Downloaded thiserror v1.0.50 [INFO] [stderr] Downloaded iana-time-zone v0.1.58 [INFO] [stderr] Downloaded prettytable v0.10.0 [INFO] [stderr] Downloaded clap v4.4.10 [INFO] [stderr] Downloaded serde_derive v1.0.193 [INFO] [stderr] Downloaded serde v1.0.193 [INFO] [stderr] Downloaded clap_builder v4.4.9 [INFO] [stderr] Downloaded rustix v0.38.25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36d012f2e7e075df74c329b59fed278342b1be6cc5ed3dbf9ea332709058a8ff [INFO] running `Command { std: "docker" "start" "-a" "36d012f2e7e075df74c329b59fed278342b1be6cc5ed3dbf9ea332709058a8ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36d012f2e7e075df74c329b59fed278342b1be6cc5ed3dbf9ea332709058a8ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36d012f2e7e075df74c329b59fed278342b1be6cc5ed3dbf9ea332709058a8ff", kill_on_drop: false }` [INFO] [stdout] 36d012f2e7e075df74c329b59fed278342b1be6cc5ed3dbf9ea332709058a8ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] caf150654b8bf56fd2729a03e2be37fc0a632f0fa1e0dd388e4196020e53741d [INFO] running `Command { std: "docker" "start" "-a" "caf150654b8bf56fd2729a03e2be37fc0a632f0fa1e0dd388e4196020e53741d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Compiling anstyle-query v1.0.0 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Compiling anstyle v1.0.4 [INFO] [stderr] Compiling clap_lex v0.6.0 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling anstream v0.6.4 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Compiling clap_builder v4.4.9 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling clap v4.4.10 [INFO] [stderr] Checking clap_complete v4.4.4 [INFO] [stderr] Compiling bellado v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/cli.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / #[command(about, long_about = None, version, author, arg_required_else_help = true)] [INFO] [stdout] 7 | | [INFO] [stdout] | |_^ [INFO] [stdout] 8 | pub struct Cli { [INFO] [stdout] | -------------- the attribute applies to this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking prettytable v0.10.0 [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/cli.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / #[command(about, long_about = None, version, author, arg_required_else_help = true)] [INFO] [stdout] 7 | | [INFO] [stdout] | |_^ [INFO] [stdout] 8 | pub struct Cli { [INFO] [stdout] | -------------- the attribute applies to this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/io.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tasks.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/cli.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / #[command(about, long_about = None, version, author, arg_required_else_help = true)] [INFO] [stdout] 7 | | [INFO] [stdout] | |_^ [INFO] [stdout] 8 | pub struct Cli { [INFO] [stdout] | -------------- the attribute applies to this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/io.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tasks.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 27 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:49:14 [INFO] [stdout] | [INFO] [stdout] 49 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/io.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if !check_file().is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_file().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tasks.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 20 | let file = File::open(&path).context("fs failed to read the file")?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/tasks.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | return Ok(store [INFO] [stdout] | ___________________^ [INFO] [stdout] 55 | | .iter() [INFO] [stdout] 56 | | .filter(|t| t.completed) [INFO] [stdout] 57 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 54 ~ return Ok(store [INFO] [stdout] 55 + .iter() [INFO] [stdout] 56 + .filter(|t| t.completed).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/tasks.rs:62:19 [INFO] [stdout] | [INFO] [stdout] 62 | return Ok(store [INFO] [stdout] | ___________________^ [INFO] [stdout] 63 | | .iter() [INFO] [stdout] 64 | | .filter(|t| !t.completed) [INFO] [stdout] 65 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 62 ~ return Ok(store [INFO] [stdout] 63 + .iter() [INFO] [stdout] 64 + .filter(|t| !t.completed).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/tasks.rs:71:26 [INFO] [stdout] | [INFO] [stdout] 71 | let filtered_tasks = store [INFO] [stdout] | __________________________^ [INFO] [stdout] 72 | | .iter() [INFO] [stdout] 73 | | .filter(|t| t.categories.iter().any(|c| category_set.contains(c))) [INFO] [stdout] 74 | | .map(|t| t.clone()) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 71 ~ let filtered_tasks = store [INFO] [stdout] 72 + .iter() [INFO] [stdout] 73 + .filter(|t| t.categories.iter().any(|c| category_set.contains(c))).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/tasks.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | store.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - store.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] 82 + store.sort_by_key(|a| a.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/tasks.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 27 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:49:14 [INFO] [stdout] | [INFO] [stdout] 49 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/git.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | .arg(&io::get_datastore_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `io::get_datastore_dir().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/io.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if !check_file().is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_file().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tasks.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 20 | let file = File::open(&path).context("fs failed to read the file")?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/tasks.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | return Ok(store [INFO] [stdout] | ___________________^ [INFO] [stdout] 55 | | .iter() [INFO] [stdout] 56 | | .filter(|t| t.completed) [INFO] [stdout] 57 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 54 ~ return Ok(store [INFO] [stdout] 55 + .iter() [INFO] [stdout] 56 + .filter(|t| t.completed).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/tasks.rs:62:19 [INFO] [stdout] | [INFO] [stdout] 62 | return Ok(store [INFO] [stdout] | ___________________^ [INFO] [stdout] 63 | | .iter() [INFO] [stdout] 64 | | .filter(|t| !t.completed) [INFO] [stdout] 65 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 62 ~ return Ok(store [INFO] [stdout] 63 + .iter() [INFO] [stdout] 64 + .filter(|t| !t.completed).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/tasks.rs:71:26 [INFO] [stdout] | [INFO] [stdout] 71 | let filtered_tasks = store [INFO] [stdout] | __________________________^ [INFO] [stdout] 72 | | .iter() [INFO] [stdout] 73 | | .filter(|t| t.categories.iter().any(|c| category_set.contains(c))) [INFO] [stdout] 74 | | .map(|t| t.clone()) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 71 ~ let filtered_tasks = store [INFO] [stdout] 72 + .iter() [INFO] [stdout] 73 + .filter(|t| t.categories.iter().any(|c| category_set.contains(c))).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/tasks.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | store.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - store.sort_by(|a, b| a.id.cmp(&b.id)); [INFO] [stdout] 82 + store.sort_by_key(|a| a.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/tasks.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | markdown.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `markdown.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.15s [INFO] running `Command { std: "docker" "inspect" "caf150654b8bf56fd2729a03e2be37fc0a632f0fa1e0dd388e4196020e53741d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "caf150654b8bf56fd2729a03e2be37fc0a632f0fa1e0dd388e4196020e53741d", kill_on_drop: false }` [INFO] [stdout] caf150654b8bf56fd2729a03e2be37fc0a632f0fa1e0dd388e4196020e53741d