[INFO] cloning repository https://github.com/isaacs4m/evoartlab [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/isaacs4m/evoartlab" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisaacs4m%2Fevoartlab", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisaacs4m%2Fevoartlab'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f1ca726c13a87e5427d498c6c91a1e7abfbae182 [INFO] linting isaacs4m/evoartlab against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fisaacs4m%2Fevoartlab" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/isaacs4m/evoartlab [INFO] finished tweaking git repo https://github.com/isaacs4m/evoartlab [INFO] tweaked toml for git repo https://github.com/isaacs4m/evoartlab written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/isaacs4m/evoartlab on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/isaacs4m/evoartlab already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zbus_names v4.1.1 [INFO] [stderr] Downloaded zvariant_derive v5.2.0 [INFO] [stderr] Downloaded bitflags v2.7.0 [INFO] [stderr] Downloaded zvariant_utils v3.1.0 [INFO] [stderr] Downloaded gpu-descriptor v0.3.1 [INFO] [stderr] Downloaded rfd v0.15.2 [INFO] [stderr] Downloaded zbus_xml v4.0.0 [INFO] [stderr] Downloaded atspi-connection v0.6.0 [INFO] [stderr] Downloaded egui-wgpu v0.30.0 [INFO] [stderr] Downloaded accesskit v0.17.1 [INFO] [stderr] Downloaded zbus-lockstep v0.4.4 [INFO] [stderr] Downloaded accesskit_consumer v0.26.0 [INFO] [stderr] Downloaded zbus-lockstep-macros v0.4.4 [INFO] [stderr] Downloaded accesskit_windows v0.24.1 [INFO] [stderr] Downloaded webbrowser v1.0.3 [INFO] [stderr] Downloaded accesskit_macos v0.18.1 [INFO] [stderr] Downloaded egui_glow v0.30.0 [INFO] [stderr] Downloaded wgpu-types v23.0.0 [INFO] [stderr] Downloaded atspi-common v0.6.0 [INFO] [stderr] Downloaded eframe v0.30.0 [INFO] [stderr] Downloaded cc v1.2.9 [INFO] [stderr] Downloaded wgpu v23.0.1 [INFO] [stderr] Downloaded glow v0.14.2 [INFO] [stderr] Downloaded wayland-protocols v0.32.5 [INFO] [stderr] Downloaded owned_ttf_parser v0.25.0 [INFO] [stderr] Downloaded wgpu-core v23.0.1 [INFO] [stderr] Downloaded zbus v5.3.0 [INFO] [stderr] Downloaded statrs v0.18.0 [INFO] [stderr] Downloaded image v0.25.5 [INFO] [stderr] Downloaded epaint v0.30.0 [INFO] [stderr] Downloaded glutin v0.32.2 [INFO] [stderr] Downloaded miniz_oxide v0.8.3 [INFO] [stderr] Downloaded wgpu-hal v23.0.1 [INFO] [stderr] Downloaded rustix v0.38.43 [INFO] [stderr] Downloaded egui v0.30.0 [INFO] [stderr] Downloaded ashpd v0.10.2 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.5 [INFO] [stderr] Downloaded wayland-backend v0.3.7 [INFO] [stderr] Downloaded wayland-scanner v0.31.5 [INFO] [stderr] Downloaded zbus_macros v5.3.0 [INFO] [stderr] Downloaded zvariant v5.2.0 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.5 [INFO] [stderr] Downloaded wayland-client v0.31.7 [INFO] [stderr] Downloaded accesskit_atspi_common v0.10.1 [INFO] [stderr] Downloaded naga v23.1.0 [INFO] [stderr] Downloaded atspi v0.22.0 [INFO] [stderr] Downloaded accesskit_winit v0.23.1 [INFO] [stderr] Downloaded winit v0.30.8 [INFO] [stderr] Downloaded egui-winit v0.30.0 [INFO] [stderr] Downloaded ab_glyph v0.2.29 [INFO] [stderr] Downloaded emath v0.30.0 [INFO] [stderr] Downloaded atspi-proxies v0.6.0 [INFO] [stderr] Downloaded ecolor v0.30.0 [INFO] [stderr] Downloaded wayland-cursor v0.31.7 [INFO] [stderr] Downloaded wayland-sys v0.31.5 [INFO] [stderr] Downloaded accesskit_unix v0.13.1 [INFO] [stderr] Downloaded epaint_default_fonts v0.30.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ef102bc6cd4db0a8fe5ca0361a2c8b79c781608aa3efded56572c7eed8932b0 [INFO] running `Command { std: "docker" "start" "-a" "3ef102bc6cd4db0a8fe5ca0361a2c8b79c781608aa3efded56572c7eed8932b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ef102bc6cd4db0a8fe5ca0361a2c8b79c781608aa3efded56572c7eed8932b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ef102bc6cd4db0a8fe5ca0361a2c8b79c781608aa3efded56572c7eed8932b0", kill_on_drop: false }` [INFO] [stdout] 3ef102bc6cd4db0a8fe5ca0361a2c8b79c781608aa3efded56572c7eed8932b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c40d1ba65ba9b89d0a18ab12f6c882c8269b53311c98829d241642199ffe6a04 [INFO] running `Command { std: "docker" "start" "-a" "c40d1ba65ba9b89d0a18ab12f6c882c8269b53311c98829d241642199ffe6a04", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking bitflags v2.7.0 [INFO] [stderr] Compiling rustix v0.38.43 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling hashbrown v0.15.2 [INFO] [stderr] Compiling winnow v0.6.24 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling cc v1.2.9 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling quick-xml v0.36.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling wayland-client v0.31.7 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling indexmap v2.7.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking event-listener-strategy v0.5.3 [INFO] [stderr] Compiling wayland-sys v0.31.5 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking accesskit v0.17.1 [INFO] [stderr] Compiling wayland-scanner v0.31.5 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking foldhash v0.1.4 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Compiling wayland-backend v0.3.7 [INFO] [stderr] Checking immutable-chunkmap v2.0.6 [INFO] [stderr] Compiling winit v0.30.8 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking accesskit_consumer v0.26.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking dpi v0.1.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking epaint_default_fonts v0.30.0 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking miniz_oxide v0.8.3 [INFO] [stderr] Compiling glutin v0.32.2 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling rfd v0.15.2 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling bytemuck_derive v1.8.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.85 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking bytemuck v1.21.0 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.30.0 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking image v0.25.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking wide v0.7.32 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking ecolor v0.30.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking epaint v0.30.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking async-process v2.3.0 [INFO] [stderr] Checking egui v0.30.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking simba v0.9.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking wayland-protocols v0.32.5 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-cursor v0.31.7 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking nalgebra v0.33.2 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking quick-xml v0.30.0 [INFO] [stderr] Checking zvariant_utils v3.1.0 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking egui_glow v0.30.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Compiling zvariant_derive v5.2.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling zvariant v5.2.0 [INFO] [stderr] Checking webbrowser v1.0.3 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking zbus_xml v4.0.0 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.5 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.5 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking zbus-lockstep v0.4.4 [INFO] [stderr] Compiling zbus_names v4.1.1 [INFO] [stderr] Compiling zbus-lockstep-macros v0.4.4 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking arboard v3.4.1 [INFO] [stderr] Compiling zbus_macros v5.3.0 [INFO] [stderr] Checking zbus v5.3.0 [INFO] [stderr] Checking statrs v0.18.0 [INFO] [stderr] Checking atspi-common v0.6.0 [INFO] [stderr] Checking ashpd v0.10.2 [INFO] [stderr] Checking atspi-proxies v0.6.0 [INFO] [stderr] Checking accesskit_atspi_common v0.10.1 [INFO] [stderr] Checking atspi-connection v0.6.0 [INFO] [stderr] Checking atspi v0.22.0 [INFO] [stderr] Checking accesskit_unix v0.13.1 [INFO] [stderr] Checking accesskit_winit v0.23.1 [INFO] [stderr] Checking egui-winit v0.30.0 [INFO] [stderr] Checking eframe v0.30.0 [INFO] [stderr] Checking evoartlab v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/draw.rs:6:29 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn draw_concur(vectors: &Vec, width: u32, height: u32, num_workers: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - pub fn draw_concur(vectors: &Vec, width: u32, height: u32, num_workers: usize) -> Vec { [INFO] [stdout] 6 + pub fn draw_concur(vectors: &[Vector], width: u32, height: u32, num_workers: usize) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/draw.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | let chunk_size = (vectors.len() + num_workers - 1) / num_workers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `vectors.len().div_ceil(num_workers)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/vector.rs:118:79 [INFO] [stdout] | [INFO] [stdout] 118 | fn apply_scaling_factor_in_triangle(t: &mut Triangle, scaling_factor: f64) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/vector.rs:131:65 [INFO] [stdout] | [INFO] [stdout] 131 | fn clamp_triangle(t: &mut Triangle, width: u32, height: u32) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/vector.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 252 | / pub fn new( [INFO] [stdout] 253 | | pool_size: usize, [INFO] [stdout] 254 | | scaling_factor: f64, [INFO] [stdout] 255 | | crossover_probability: f64, [INFO] [stdout] ... | [INFO] [stdout] 260 | | tournament_size: usize [INFO] [stdout] 261 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/vector.rs:287:44 [INFO] [stdout] | [INFO] [stdout] 287 | pub fn generate_initial_pool(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `fronts.get(0)` [INFO] [stdout] --> src/vector.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | fronts.get(0).cloned().unwrap_or_default() [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fronts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `old_pool` [INFO] [stdout] --> src/vector.rs:360:18 [INFO] [stdout] | [INFO] [stdout] 360 | for i in 0..self.pool_size { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 360 - for i in 0..self.pool_size { [INFO] [stdout] 360 + for (i, ) in old_pool.iter().enumerate().take(self.pool_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/vector.rs:374:54 [INFO] [stdout] | [INFO] [stdout] 374 | fn calculate_crowding_distance(&mut self, front: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 374 - fn calculate_crowding_distance(&mut self, front: &mut Vec) { [INFO] [stdout] 374 + fn calculate_crowding_distance(&mut self, front: &mut [Vector]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/fitness/pixel_compare.rs:8:60 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn calculate_fitness(env: &mut Environment, idx: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/fitness/pixel_compare.rs:21:52 [INFO] [stdout] | [INFO] [stdout] 21 | fn calculate_mse_concur(env: &Environment, images: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - fn calculate_mse_concur(env: &Environment, images: &Vec) -> Vec { [INFO] [stdout] 21 + fn calculate_mse_concur(env: &Environment, images: &[RgbaImage]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/fitness/pixel_compare.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | let chunk_size = (images.len() + env.num_threads - 1) / env.num_threads; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `images.len().div_ceil(env.num_threads)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/fitness/benford.rs:7:60 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn calculate_fitness(env: &mut Environment, idx: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/draw.rs:6:29 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn draw_concur(vectors: &Vec, width: u32, height: u32, num_workers: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - pub fn draw_concur(vectors: &Vec, width: u32, height: u32, num_workers: usize) -> Vec { [INFO] [stdout] 6 + pub fn draw_concur(vectors: &[Vector], width: u32, height: u32, num_workers: usize) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/draw.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | let chunk_size = (vectors.len() + num_workers - 1) / num_workers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `vectors.len().div_ceil(num_workers)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/fitness/contrast.rs:7:60 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn calculate_fitness(env: &mut Environment, idx: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | let final_img: Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `final_img` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 110 ~ [INFO] [stdout] 111 ~ let final_img: Option = if self.target_img.is_none() { [INFO] [stdout] 112 ~ Some(image::open("test.jpg").unwrap().to_rgba8()) [INFO] [stdout] 113 | } else { [INFO] [stdout] 114 ~ self.target_img.clone() [INFO] [stdout] 115 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:132:24 [INFO] [stdout] | [INFO] [stdout] 132 | if self.running == false { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.running` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:191:90 [INFO] [stdout] | [INFO] [stdout] 191 | ... ui.add(egui::DragValue::new(&mut self.stop_condition).prefix(format!("Time Elapsed in Seconds:"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Time Elapsed in Seconds:".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:253:52 [INFO] [stdout] | [INFO] [stdout] 253 | for (_, vector) in front.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 253 - for (_, vector) in front.iter().enumerate() { [INFO] [stdout] 253 + for vector in front.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:254:28 [INFO] [stdout] | [INFO] [stdout] 254 | if vector.fitness.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!vector.fitness.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:255:57 [INFO] [stdout] | [INFO] [stdout] 255 | ... let img = draw::draw_vector(&vector, env.target_width, env.target_height); [INFO] [stdout] | ^^^^^^^ help: change this to: `vector` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:257:29 [INFO] [stdout] | [INFO] [stdout] 257 | ... let file_name; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `file_name` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 257 ~ [INFO] [stdout] 258 ~ let file_name = if self.destination_folder != "No folder selected" { [INFO] [stdout] 259 ~ format!("{}/front_{}.png", self.destination_folder, fitnesses) [INFO] [stdout] 260 | } else { [INFO] [stdout] 261 ~ format!("front_{}.png", fitnesses) [INFO] [stdout] 262 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/vector.rs:118:79 [INFO] [stdout] | [INFO] [stdout] 118 | fn apply_scaling_factor_in_triangle(t: &mut Triangle, scaling_factor: f64) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/fitness/benford.rs:47:28 [INFO] [stdout] | [INFO] [stdout] 47 | let mut digit_counts = vec![0; 10]; [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `[0; 10]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/vector.rs:131:65 [INFO] [stdout] | [INFO] [stdout] 131 | fn clamp_triangle(t: &mut Triangle, width: u32, height: u32) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/vector.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 252 | / pub fn new( [INFO] [stdout] 253 | | pool_size: usize, [INFO] [stdout] 254 | | scaling_factor: f64, [INFO] [stdout] 255 | | crossover_probability: f64, [INFO] [stdout] ... | [INFO] [stdout] 260 | | tournament_size: usize [INFO] [stdout] 261 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/vector.rs:287:44 [INFO] [stdout] | [INFO] [stdout] 287 | pub fn generate_initial_pool(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `fronts.get(0)` [INFO] [stdout] --> src/vector.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | fronts.get(0).cloned().unwrap_or_default() [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fronts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `old_pool` [INFO] [stdout] --> src/vector.rs:360:18 [INFO] [stdout] | [INFO] [stdout] 360 | for i in 0..self.pool_size { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 360 - for i in 0..self.pool_size { [INFO] [stdout] 360 + for (i, ) in old_pool.iter().enumerate().take(self.pool_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/vector.rs:374:54 [INFO] [stdout] | [INFO] [stdout] 374 | fn calculate_crowding_distance(&mut self, front: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 374 - fn calculate_crowding_distance(&mut self, front: &mut Vec) { [INFO] [stdout] 374 + fn calculate_crowding_distance(&mut self, front: &mut [Vector]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/fitness/pixel_compare.rs:8:60 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn calculate_fitness(env: &mut Environment, idx: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/fitness/pixel_compare.rs:21:52 [INFO] [stdout] | [INFO] [stdout] 21 | fn calculate_mse_concur(env: &Environment, images: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - fn calculate_mse_concur(env: &Environment, images: &Vec) -> Vec { [INFO] [stdout] 21 + fn calculate_mse_concur(env: &Environment, images: &[RgbaImage]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/fitness/pixel_compare.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | let chunk_size = (images.len() + env.num_threads - 1) / env.num_threads; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `images.len().div_ceil(env.num_threads)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/fitness/benford.rs:7:60 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn calculate_fitness(env: &mut Environment, idx: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/fitness/contrast.rs:7:60 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn calculate_fitness(env: &mut Environment, idx: usize) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | let final_img: Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `final_img` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 110 ~ [INFO] [stdout] 111 ~ let final_img: Option = if self.target_img.is_none() { [INFO] [stdout] 112 ~ Some(image::open("test.jpg").unwrap().to_rgba8()) [INFO] [stdout] 113 | } else { [INFO] [stdout] 114 ~ self.target_img.clone() [INFO] [stdout] 115 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:132:24 [INFO] [stdout] | [INFO] [stdout] 132 | if self.running == false { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.running` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:191:90 [INFO] [stdout] | [INFO] [stdout] 191 | ... ui.add(egui::DragValue::new(&mut self.stop_condition).prefix(format!("Time Elapsed in Seconds:"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Time Elapsed in Seconds:".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:253:52 [INFO] [stdout] | [INFO] [stdout] 253 | for (_, vector) in front.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 253 - for (_, vector) in front.iter().enumerate() { [INFO] [stdout] 253 + for vector in front.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:254:28 [INFO] [stdout] | [INFO] [stdout] 254 | if vector.fitness.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!vector.fitness.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:255:57 [INFO] [stdout] | [INFO] [stdout] 255 | ... let img = draw::draw_vector(&vector, env.target_width, env.target_height); [INFO] [stdout] | ^^^^^^^ help: change this to: `vector` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:257:29 [INFO] [stdout] | [INFO] [stdout] 257 | ... let file_name; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `file_name` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 257 ~ [INFO] [stdout] 258 ~ let file_name = if self.destination_folder != "No folder selected" { [INFO] [stdout] 259 ~ format!("{}/front_{}.png", self.destination_folder, fitnesses) [INFO] [stdout] 260 | } else { [INFO] [stdout] 261 ~ format!("front_{}.png", fitnesses) [INFO] [stdout] 262 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/fitness/benford.rs:47:28 [INFO] [stdout] | [INFO] [stdout] 47 | let mut digit_counts = vec![0; 10]; [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `[0; 10]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 40s [INFO] running `Command { std: "docker" "inspect" "c40d1ba65ba9b89d0a18ab12f6c882c8269b53311c98829d241642199ffe6a04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c40d1ba65ba9b89d0a18ab12f6c882c8269b53311c98829d241642199ffe6a04", kill_on_drop: false }` [INFO] [stdout] c40d1ba65ba9b89d0a18ab12f6c882c8269b53311c98829d241642199ffe6a04