[INFO] cloning repository https://github.com/ingalls/geojson-rewind-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ingalls/geojson-rewind-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fingalls%2Fgeojson-rewind-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fingalls%2Fgeojson-rewind-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2e514eb86e2a6bae75fd74215ba4091d756c804b [INFO] linting ingalls/geojson-rewind-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fingalls%2Fgeojson-rewind-rs" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ingalls/geojson-rewind-rs [INFO] finished tweaking git repo https://github.com/ingalls/geojson-rewind-rs [INFO] tweaked toml for git repo https://github.com/ingalls/geojson-rewind-rs written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ingalls/geojson-rewind-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ingalls/geojson-rewind-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded geo-types v0.1.1 [INFO] [stderr] Downloaded serde_json v1.0.24 [INFO] [stderr] Downloaded serde v1.0.71 [INFO] [stderr] Downloaded geojson v0.11.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e798f808f2c3550bf751107a1aa14e36ae0fbdd2ab4ec47d25ee51c817b9715 [INFO] running `Command { std: "docker" "start" "-a" "1e798f808f2c3550bf751107a1aa14e36ae0fbdd2ab4ec47d25ee51c817b9715", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e798f808f2c3550bf751107a1aa14e36ae0fbdd2ab4ec47d25ee51c817b9715", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e798f808f2c3550bf751107a1aa14e36ae0fbdd2ab4ec47d25ee51c817b9715", kill_on_drop: false }` [INFO] [stdout] 1e798f808f2c3550bf751107a1aa14e36ae0fbdd2ab4ec47d25ee51c817b9715 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 318d491c26522607511cc781de5eca06e51fc198a1c7b280c2e9a6b3bc789f77 [INFO] running `Command { std: "docker" "start" "-a" "318d491c26522607511cc781de5eca06e51fc198a1c7b280c2e9a6b3bc789f77", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling serde v1.0.71 [INFO] [stderr] Checking dtoa v0.4.3 [INFO] [stderr] Checking itoa v0.4.2 [INFO] [stderr] Checking geo-types v0.1.1 [INFO] [stderr] Checking serde_json v1.0.24 [INFO] [stderr] Checking geojson v0.11.1 [INFO] [stderr] Checking geojson_rewind v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let mut lower_index: u32; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let mut middle_index: u32; [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut upper_index: u32; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut p1 = &coords[lower_index as usize]; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let mut p2 = &coords[middle_index as usize]; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let mut p3 = &coords[upper_index as usize]; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | _ => { return } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - _ => { return } [INFO] [stdout] 23 + _ => { } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 27 | fn correct_rings(coords: &mut Vec>, outer: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 - fn correct_rings(coords: &mut Vec>, outer: bool) { [INFO] [stdout] 27 + fn correct_rings(coords: &mut [Vec], outer: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | fn wind(coords: &mut Vec, outer: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - fn wind(coords: &mut Vec, outer: bool) { [INFO] [stdout] 37 + fn wind(coords: &mut [geojson::Position], outer: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | area = area + ((p3[0] * PI / 180.0) - (p1[0] * PI / 180.0)) * (p2[1] * PI / 180.0).sin(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `area += ((p3[0] * PI / 180.0) - (p1[0] * PI / 180.0)) * (p2[1] * PI / 180.0).sin()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:83:8 [INFO] [stdout] | [INFO] [stdout] 83 | if (area > 0.0) == !outer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(area > 0.0) != outer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let mut lower_index: u32; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let mut middle_index: u32; [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut upper_index: u32; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut p1 = &coords[lower_index as usize]; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let mut p2 = &coords[middle_index as usize]; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let mut p3 = &coords[upper_index as usize]; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | _ => { return } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - _ => { return } [INFO] [stdout] 23 + _ => { } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 27 | fn correct_rings(coords: &mut Vec>, outer: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 - fn correct_rings(coords: &mut Vec>, outer: bool) { [INFO] [stdout] 27 + fn correct_rings(coords: &mut [Vec], outer: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | fn wind(coords: &mut Vec, outer: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - fn wind(coords: &mut Vec, outer: bool) { [INFO] [stdout] 37 + fn wind(coords: &mut [geojson::Position], outer: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | area = area + ((p3[0] * PI / 180.0) - (p1[0] * PI / 180.0)) * (p2[1] * PI / 180.0).sin(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `area += ((p3[0] * PI / 180.0) - (p1[0] * PI / 180.0)) * (p2[1] * PI / 180.0).sin()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:83:8 [INFO] [stdout] | [INFO] [stdout] 83 | if (area > 0.0) == !outer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(area > 0.0) != outer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.72s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: geojson v0.11.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "318d491c26522607511cc781de5eca06e51fc198a1c7b280c2e9a6b3bc789f77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "318d491c26522607511cc781de5eca06e51fc198a1c7b280c2e9a6b3bc789f77", kill_on_drop: false }` [INFO] [stdout] 318d491c26522607511cc781de5eca06e51fc198a1c7b280c2e9a6b3bc789f77