[INFO] cloning repository https://github.com/ilyail3/json_reader [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ilyail3/json_reader" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Filyail3%2Fjson_reader", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Filyail3%2Fjson_reader'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 523d504fd163eaaa5a9d785b16f176cc6af63857 [INFO] linting ilyail3/json_reader against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Filyail3%2Fjson_reader" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ilyail3/json_reader [INFO] finished tweaking git repo https://github.com/ilyail3/json_reader [INFO] tweaked toml for git repo https://github.com/ilyail3/json_reader written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ilyail3/json_reader on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ilyail3/json_reader already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 40eda52ddbcde7112a6895366941d53a925a10ac246e4a84b2df27084dfcbdb4 [INFO] running `Command { std: "docker" "start" "-a" "40eda52ddbcde7112a6895366941d53a925a10ac246e4a84b2df27084dfcbdb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "40eda52ddbcde7112a6895366941d53a925a10ac246e4a84b2df27084dfcbdb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40eda52ddbcde7112a6895366941d53a925a10ac246e4a84b2df27084dfcbdb4", kill_on_drop: false }` [INFO] [stdout] 40eda52ddbcde7112a6895366941d53a925a10ac246e4a84b2df27084dfcbdb4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 095c5261dc93e4ba2c6a623cf60a6683aaac539637675d88f738ca1227712e83 [INFO] running `Command { std: "docker" "start" "-a" "095c5261dc93e4ba2c6a623cf60a6683aaac539637675d88f738ca1227712e83", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking json_reader v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | const LF: u8 = '\n' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | const CR: u8 = '\r' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 7 | const SPACE: u8 = ' ' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b' '` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | const TAB: u8 = '\t' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\t'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | const COMMA: u8 = ',' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b','` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | const DOT: u8 = '.' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'.'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | const MINUS: u8 = '-' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'-'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:12:24 [INFO] [stdout] | [INFO] [stdout] 12 | const ARRAY_OPEN: u8 = '[' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'['` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | const ARRAY_CLOSE: u8 = ']' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b']'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:14:25 [INFO] [stdout] | [INFO] [stdout] 14 | const OBJECT_OPEN: u8 = '{' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'{'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | const OBJECT_CLOSE: u8 = '}' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'}'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | const NUMBER0: u8 = '0' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | const NUMBER9: u8 = '9' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'9'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:18:25 [INFO] [stdout] | [INFO] [stdout] 18 | const ESCAPE_CHAR: u8 = '\\' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\\'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | const CHAR_N: u8 = 'n' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | const CHAR_T: u8 = 't' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b't'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 21 | const CHAR_R: u8 = 'r' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 22 | const CHAR_F: u8 = 'f' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'f'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 23 | const CHAR_DOUBLE_QUOTE: u8 = '"' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'"'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/token.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | read: r.bytes().peekable(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/token.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / let mut c = Vec::new(); [INFO] [stdout] 68 | | [INFO] [stdout] 69 | | c.push(Container::Document); [INFO] [stdout] | |____________________________________^ help: consider using the `vec![]` macro: `let c = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/token.rs:82:30 [INFO] [stdout] | [INFO] [stdout] 82 | while return_byte == LF as u8 || return_byte == CR as u8 || return_byte == TAB as u8 || return_byte == SPACE as u8 { [INFO] [stdout] | ^^^^^^^^ help: try: `LF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/token.rs:82:57 [INFO] [stdout] | [INFO] [stdout] 82 | while return_byte == LF as u8 || return_byte == CR as u8 || return_byte == TAB as u8 || return_byte == SPACE as u8 { [INFO] [stdout] | ^^^^^^^^ help: try: `CR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/token.rs:82:84 [INFO] [stdout] | [INFO] [stdout] 82 | while return_byte == LF as u8 || return_byte == CR as u8 || return_byte == TAB as u8 || return_byte == SPACE as u8 { [INFO] [stdout] | ^^^^^^^^^ help: try: `TAB` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/token.rs:82:112 [INFO] [stdout] | [INFO] [stdout] 82 | while return_byte == LF as u8 || return_byte == CR as u8 || return_byte == TAB as u8 || return_byte == SPACE as u8 { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `SPACE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/token.rs:168:24 [INFO] [stdout] | [INFO] [stdout] 168 | } else if *c >= NUMBER0 && *c <= NUMBER9 { [INFO] [stdout] | ________________________^ [INFO] [stdout] 169 | | true [INFO] [stdout] 170 | | } else { [INFO] [stdout] 171 | | false [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `{ *c >= NUMBER0 && *c <= NUMBER9 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/token.rs:222:63 [INFO] [stdout] | [INFO] [stdout] 222 | let key = Some(self.read_string().map(|f| JsonToken::Key(f))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `JsonToken::Key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/token.rs:226:45 [INFO] [stdout] | [INFO] [stdout] 226 | ... return Some(Err(Error::new(ErrorKind::Other, "EOF after key string"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 226 - return Some(Err(Error::new(ErrorKind::Other, "EOF after key string"))); [INFO] [stdout] 226 + return Some(Err(Error::other("EOF after key string"))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/token.rs:244:45 [INFO] [stdout] | [INFO] [stdout] 244 | ... return Some(Err(Error::new(ErrorKind::Other, "Not expecting array end"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 244 - return Some(Err(Error::new(ErrorKind::Other, "Not expecting array end"))) [INFO] [stdout] 244 + return Some(Err(Error::other("Not expecting array end"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/token.rs:252:53 [INFO] [stdout] | [INFO] [stdout] 252 | Some(self.read_string().map(|f| JsonToken::String(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `JsonToken::String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/token.rs:262:45 [INFO] [stdout] | [INFO] [stdout] 262 | ... return Some(Err(Error::new(ErrorKind::Other, "Not expecting obj end"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 262 - return Some(Err(Error::new(ErrorKind::Other, "Not expecting obj end"))) [INFO] [stdout] 262 + return Some(Err(Error::other("Not expecting obj end"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/token.rs:270:25 [INFO] [stdout] | [INFO] [stdout] 270 | / match self.read_const("null") { [INFO] [stdout] 271 | | Err(e) => return Some(Err(e)), [INFO] [stdout] 272 | | Ok(_) => {} [INFO] [stdout] 273 | | }; [INFO] [stdout] | |_________________________^ help: try: `if let Err(e) = self.read_const("null") { return Some(Err(e)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/token.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | / match self.read_const("true") { [INFO] [stdout] 280 | | Err(e) => return Some(Err(e)), [INFO] [stdout] 281 | | Ok(_) => {} [INFO] [stdout] 282 | | }; [INFO] [stdout] | |_________________________^ help: try: `if let Err(e) = self.read_const("true") { return Some(Err(e)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/token.rs:288:25 [INFO] [stdout] | [INFO] [stdout] 288 | / match self.read_const("false") { [INFO] [stdout] 289 | | Err(e) => return Some(Err(e)), [INFO] [stdout] 290 | | Ok(_) => {} [INFO] [stdout] 291 | | }; [INFO] [stdout] | |_________________________^ help: try: `if let Err(e) = self.read_const("false") { return Some(Err(e)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/token.rs:296:31 [INFO] [stdout] | [INFO] [stdout] 296 | } else if (byte >= NUMBER0 && byte <= NUMBER9) || byte == MINUS { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(NUMBER0..=NUMBER9).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/token.rs:300:57 [INFO] [stdout] | [INFO] [stdout] 300 | Some(self.read_number(byte).map(|f| JsonToken::Number(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `JsonToken::Number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/token.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | / match *(self.container.last().unwrap()) { [INFO] [stdout] 312 | | Container::Object => { [INFO] [stdout] 313 | | self.next_key = true; [INFO] [stdout] ... | [INFO] [stdout] 316 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 311 ~ if *(self.container.last().unwrap()) == Container::Object { [INFO] [stdout] 312 + self.next_key = true; [INFO] [stdout] 313 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:4:25 [INFO] [stdout] | [INFO] [stdout] 4 | const ESCAPE_CHAR: u8 = '\\' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\\'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | const CHAR_DOUBLE_QUOTE: u8 = '"' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'"'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | const ARRAY_OPEN: u8 = '[' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'['` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:7:25 [INFO] [stdout] | [INFO] [stdout] 7 | const ARRAY_CLOSE: u8 = ']' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b']'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | const OBJECT_OPEN: u8 = '{' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'{'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:9:26 [INFO] [stdout] | [INFO] [stdout] 9 | const OBJECT_CLOSE: u8 = '}' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'}'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/level.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | while !next_char_result.is_none() && (pre || self.level > self.target_level) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next_char_result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/level.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 70 | read: r.bytes(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | const LF: u8 = '\n' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | const CR: u8 = '\r' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 7 | const SPACE: u8 = ' ' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b' '` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | const TAB: u8 = '\t' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\t'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:9:19 [INFO] [stdout] | [INFO] [stdout] 9 | const COMMA: u8 = ',' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b','` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | const DOT: u8 = '.' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'.'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | const MINUS: u8 = '-' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'-'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:12:24 [INFO] [stdout] | [INFO] [stdout] 12 | const ARRAY_OPEN: u8 = '[' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'['` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | const ARRAY_CLOSE: u8 = ']' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b']'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:14:25 [INFO] [stdout] | [INFO] [stdout] 14 | const OBJECT_OPEN: u8 = '{' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'{'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | const OBJECT_CLOSE: u8 = '}' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'}'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | const NUMBER0: u8 = '0' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | const NUMBER9: u8 = '9' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'9'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:18:25 [INFO] [stdout] | [INFO] [stdout] 18 | const ESCAPE_CHAR: u8 = '\\' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\\'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | const CHAR_N: u8 = 'n' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | const CHAR_T: u8 = 't' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b't'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 21 | const CHAR_R: u8 = 'r' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 22 | const CHAR_F: u8 = 'f' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'f'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/token.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 23 | const CHAR_DOUBLE_QUOTE: u8 = '"' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'"'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/token.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | read: r.bytes().peekable(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/token.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / let mut c = Vec::new(); [INFO] [stdout] 68 | | [INFO] [stdout] 69 | | c.push(Container::Document); [INFO] [stdout] | |____________________________________^ help: consider using the `vec![]` macro: `let c = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/token.rs:82:30 [INFO] [stdout] | [INFO] [stdout] 82 | while return_byte == LF as u8 || return_byte == CR as u8 || return_byte == TAB as u8 || return_byte == SPACE as u8 { [INFO] [stdout] | ^^^^^^^^ help: try: `LF` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/token.rs:82:57 [INFO] [stdout] | [INFO] [stdout] 82 | while return_byte == LF as u8 || return_byte == CR as u8 || return_byte == TAB as u8 || return_byte == SPACE as u8 { [INFO] [stdout] | ^^^^^^^^ help: try: `CR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/token.rs:82:84 [INFO] [stdout] | [INFO] [stdout] 82 | while return_byte == LF as u8 || return_byte == CR as u8 || return_byte == TAB as u8 || return_byte == SPACE as u8 { [INFO] [stdout] | ^^^^^^^^^ help: try: `TAB` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/token.rs:82:112 [INFO] [stdout] | [INFO] [stdout] 82 | while return_byte == LF as u8 || return_byte == CR as u8 || return_byte == TAB as u8 || return_byte == SPACE as u8 { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `SPACE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/token.rs:168:24 [INFO] [stdout] | [INFO] [stdout] 168 | } else if *c >= NUMBER0 && *c <= NUMBER9 { [INFO] [stdout] | ________________________^ [INFO] [stdout] 169 | | true [INFO] [stdout] 170 | | } else { [INFO] [stdout] 171 | | false [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `{ *c >= NUMBER0 && *c <= NUMBER9 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/token.rs:222:63 [INFO] [stdout] | [INFO] [stdout] 222 | let key = Some(self.read_string().map(|f| JsonToken::Key(f))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `JsonToken::Key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/token.rs:226:45 [INFO] [stdout] | [INFO] [stdout] 226 | ... return Some(Err(Error::new(ErrorKind::Other, "EOF after key string"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 226 - return Some(Err(Error::new(ErrorKind::Other, "EOF after key string"))); [INFO] [stdout] 226 + return Some(Err(Error::other("EOF after key string"))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/token.rs:244:45 [INFO] [stdout] | [INFO] [stdout] 244 | ... return Some(Err(Error::new(ErrorKind::Other, "Not expecting array end"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 244 - return Some(Err(Error::new(ErrorKind::Other, "Not expecting array end"))) [INFO] [stdout] 244 + return Some(Err(Error::other("Not expecting array end"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/token.rs:252:53 [INFO] [stdout] | [INFO] [stdout] 252 | Some(self.read_string().map(|f| JsonToken::String(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `JsonToken::String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/token.rs:262:45 [INFO] [stdout] | [INFO] [stdout] 262 | ... return Some(Err(Error::new(ErrorKind::Other, "Not expecting obj end"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 262 - return Some(Err(Error::new(ErrorKind::Other, "Not expecting obj end"))) [INFO] [stdout] 262 + return Some(Err(Error::other("Not expecting obj end"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/token.rs:270:25 [INFO] [stdout] | [INFO] [stdout] 270 | / match self.read_const("null") { [INFO] [stdout] 271 | | Err(e) => return Some(Err(e)), [INFO] [stdout] 272 | | Ok(_) => {} [INFO] [stdout] 273 | | }; [INFO] [stdout] | |_________________________^ help: try: `if let Err(e) = self.read_const("null") { return Some(Err(e)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/token.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 279 | / match self.read_const("true") { [INFO] [stdout] 280 | | Err(e) => return Some(Err(e)), [INFO] [stdout] 281 | | Ok(_) => {} [INFO] [stdout] 282 | | }; [INFO] [stdout] | |_________________________^ help: try: `if let Err(e) = self.read_const("true") { return Some(Err(e)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/token.rs:288:25 [INFO] [stdout] | [INFO] [stdout] 288 | / match self.read_const("false") { [INFO] [stdout] 289 | | Err(e) => return Some(Err(e)), [INFO] [stdout] 290 | | Ok(_) => {} [INFO] [stdout] 291 | | }; [INFO] [stdout] | |_________________________^ help: try: `if let Err(e) = self.read_const("false") { return Some(Err(e)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/token.rs:296:31 [INFO] [stdout] | [INFO] [stdout] 296 | } else if (byte >= NUMBER0 && byte <= NUMBER9) || byte == MINUS { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(NUMBER0..=NUMBER9).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/token.rs:300:57 [INFO] [stdout] | [INFO] [stdout] 300 | Some(self.read_number(byte).map(|f| JsonToken::Number(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `JsonToken::Number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/token.rs:311:13 [INFO] [stdout] | [INFO] [stdout] 311 | / match *(self.container.last().unwrap()) { [INFO] [stdout] 312 | | Container::Object => { [INFO] [stdout] 313 | | self.next_key = true; [INFO] [stdout] ... | [INFO] [stdout] 316 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 311 ~ if *(self.container.last().unwrap()) == Container::Object { [INFO] [stdout] 312 + self.next_key = true; [INFO] [stdout] 313 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:4:25 [INFO] [stdout] | [INFO] [stdout] 4 | const ESCAPE_CHAR: u8 = '\\' as u8; [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\\'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | const CHAR_DOUBLE_QUOTE: u8 = '"' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'"'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | const ARRAY_OPEN: u8 = '[' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'['` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:7:25 [INFO] [stdout] | [INFO] [stdout] 7 | const ARRAY_CLOSE: u8 = ']' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b']'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | const OBJECT_OPEN: u8 = '{' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'{'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/level.rs:9:26 [INFO] [stdout] | [INFO] [stdout] 9 | const OBJECT_CLOSE: u8 = '}' as u8; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'}'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/level.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | while !next_char_result.is_none() && (pre || self.level > self.target_level) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next_char_result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/level.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 70 | read: r.bytes(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> tests/token.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | / match err { [INFO] [stdout] 142 | | Ok(_) => panic!("Got ok, was expecting an error"), [INFO] [stdout] 143 | | Err(_) => {} [INFO] [stdout] 144 | | } [INFO] [stdout] | |_____^ help: try: `if let Ok(_) = err { panic!("Got ok, was expecting an error") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "095c5261dc93e4ba2c6a623cf60a6683aaac539637675d88f738ca1227712e83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "095c5261dc93e4ba2c6a623cf60a6683aaac539637675d88f738ca1227712e83", kill_on_drop: false }` [INFO] [stdout] 095c5261dc93e4ba2c6a623cf60a6683aaac539637675d88f738ca1227712e83