[INFO] cloning repository https://github.com/idoflax/rust_circuit_breaker
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/idoflax/rust_circuit_breaker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fidoflax%2Frust_circuit_breaker", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fidoflax%2Frust_circuit_breaker'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 3300bf8d477e6816078d7a5cee860dce10fa98f4
[INFO] linting idoflax/rust_circuit_breaker against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fidoflax%2Frust_circuit_breaker" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/idoflax/rust_circuit_breaker
[INFO] finished tweaking git repo https://github.com/idoflax/rust_circuit_breaker
[INFO] tweaked toml for git repo https://github.com/idoflax/rust_circuit_breaker written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/idoflax/rust_circuit_breaker on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/idoflax/rust_circuit_breaker already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 81995d5228dd804d84248b062475c1924169318c8538d501597ab8529a7af5d7
[INFO] running `Command { std: "docker" "start" "-a" "81995d5228dd804d84248b062475c1924169318c8538d501597ab8529a7af5d7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "81995d5228dd804d84248b062475c1924169318c8538d501597ab8529a7af5d7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "81995d5228dd804d84248b062475c1924169318c8538d501597ab8529a7af5d7", kill_on_drop: false }`
[INFO] [stdout] 81995d5228dd804d84248b062475c1924169318c8538d501597ab8529a7af5d7
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a73d0534b6be4ef3247e2be5b269c6aeac6f0431f874b86eb0c9300de71807ac
[INFO] running `Command { std: "docker" "start" "-a" "a73d0534b6be4ef3247e2be5b269c6aeac6f0431f874b86eb0c9300de71807ac", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.125
[INFO] [stderr]     Checking parking_lot_core v0.9.3
[INFO] [stderr]     Checking parking_lot v0.12.0
[INFO] [stderr]     Checking circuit_breaker v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: type alias `Action` is never used
[INFO] [stdout]   --> src/circuit_breaker.rs:13:6
[INFO] [stdout]    |
[INFO] [stdout] 13 | type Action<T, E> = Box<dyn Fn() -> Result<T, E>>;
[INFO] [stdout]    |      ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type alias `CircuitBreakerResult` is never used
[INFO] [stdout]   --> src/circuit_breaker.rs:14:6
[INFO] [stdout]    |
[INFO] [stdout] 14 | type CircuitBreakerResult<T, E> = Result<T, CircuitBreakerError<E>>;
[INFO] [stdout]    |      ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `CircuitBreaker` is never constructed
[INFO] [stdout]   --> src/circuit_breaker.rs:17:12
[INFO] [stdout]    |
[INFO] [stdout] 17 | pub struct CircuitBreaker {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated items `new`, `guard`, `attempt_action`, and `open_circuit` are never used
[INFO] [stdout]   --> src/circuit_breaker.rs:34:10
[INFO] [stdout]    |
[INFO] [stdout] 25 | impl CircuitBreaker {
[INFO] [stdout]    | ------------------- associated items in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 34 |   pub fn new(failure_threshold: i8, half_open_attempts: i8, timeout: Duration) -> Self {
[INFO] [stdout]    |          ^^^
[INFO] [stdout] ...
[INFO] [stdout] 49 |   pub fn guard<T, E: Display>(&mut self, action: Action<T, E>) -> CircuitBreakerResult<T, E> {
[INFO] [stdout]    |          ^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 78 |   fn attempt_action<T, E: Display>(
[INFO] [stdout]    |      ^^^^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 99 |   fn open_circuit(&mut self) {
[INFO] [stdout]    |      ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `CircuitBreakerState` is never used
[INFO] [stdout]    --> src/circuit_breaker.rs:113:6
[INFO] [stdout]     |
[INFO] [stdout] 113 | enum CircuitBreakerState {
[INFO] [stdout]     |      ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `CircuitBreakerError` is never used
[INFO] [stdout]  --> src/circuit_breaker_error.rs:7:10
[INFO] [stdout]   |
[INFO] [stdout] 7 | pub enum CircuitBreakerError<E: Display> {
[INFO] [stdout]   |          ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `CircuitBreakerState` which implements the `Copy` trait
[INFO] [stdout]   --> src/circuit_breaker.rs:51:23
[INFO] [stdout]    |
[INFO] [stdout] 51 |     let state_clone = state.clone();
[INFO] [stdout]    |                       ^^^^^^^^^^^^^ help: try removing the `clone` call: `state`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]    = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/circuit_breaker.rs:83:5
[INFO] [stdout]    |
[INFO] [stdout] 83 | /     return if self.error_counter.load(Ordering::Relaxed) < threshold {
[INFO] [stdout] 84 | |       match action() {
[INFO] [stdout] 85 | |         Ok(t) => Ok(t),
[INFO] [stdout] 86 | |         Err(e) => {
[INFO] [stdout] ...  |
[INFO] [stdout] 95 | |       })
[INFO] [stdout] 96 | |     };
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 83 ~     if self.error_counter.load(Ordering::Relaxed) < threshold {
[INFO] [stdout] 84 +       match action() {
[INFO] [stdout] 85 +         Ok(t) => Ok(t),
[INFO] [stdout] 86 +         Err(e) => {
[INFO] [stdout] 87 +           self.error_counter.fetch_add(1, Ordering::Relaxed);
[INFO] [stdout] 88 +           Err(CircuitBreakerError::Wrapped(e))
[INFO] [stdout] 89 +         }
[INFO] [stdout] 90 +       }
[INFO] [stdout] 91 +     } else {
[INFO] [stdout] 92 +       self.open_circuit();
[INFO] [stdout] 93 +       Err(CircuitBreakerError::Open {
[INFO] [stdout] 94 +         threshold: self.failure_threshold,
[INFO] [stdout] 95 +       })
[INFO] [stdout] 96 ~     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing
[INFO] [stdout]   --> src/circuit_breaker.rs:52:5
[INFO] [stdout]    |
[INFO] [stdout] 52 |     mem::drop(state);
[INFO] [stdout]    |     ^^^^^^^^^^-----^
[INFO] [stdout]    |               |
[INFO] [stdout]    |               argument has type `circuit_breaker::CircuitBreakerState`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dropping_copy_types)]` on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the expression or result
[INFO] [stdout]    |
[INFO] [stdout] 52 -     mem::drop(state);
[INFO] [stdout] 52 +     let _ = state;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `CircuitBreakerState` which implements the `Copy` trait
[INFO] [stdout]   --> src/circuit_breaker.rs:51:23
[INFO] [stdout]    |
[INFO] [stdout] 51 |     let state_clone = state.clone();
[INFO] [stdout]    |                       ^^^^^^^^^^^^^ help: try removing the `clone` call: `state`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]    = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/circuit_breaker.rs:83:5
[INFO] [stdout]    |
[INFO] [stdout] 83 | /     return if self.error_counter.load(Ordering::Relaxed) < threshold {
[INFO] [stdout] 84 | |       match action() {
[INFO] [stdout] 85 | |         Ok(t) => Ok(t),
[INFO] [stdout] 86 | |         Err(e) => {
[INFO] [stdout] ...  |
[INFO] [stdout] 95 | |       })
[INFO] [stdout] 96 | |     };
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 83 ~     if self.error_counter.load(Ordering::Relaxed) < threshold {
[INFO] [stdout] 84 +       match action() {
[INFO] [stdout] 85 +         Ok(t) => Ok(t),
[INFO] [stdout] 86 +         Err(e) => {
[INFO] [stdout] 87 +           self.error_counter.fetch_add(1, Ordering::Relaxed);
[INFO] [stdout] 88 +           Err(CircuitBreakerError::Wrapped(e))
[INFO] [stdout] 89 +         }
[INFO] [stdout] 90 +       }
[INFO] [stdout] 91 +     } else {
[INFO] [stdout] 92 +       self.open_circuit();
[INFO] [stdout] 93 +       Err(CircuitBreakerError::Open {
[INFO] [stdout] 94 +         threshold: self.failure_threshold,
[INFO] [stdout] 95 +       })
[INFO] [stdout] 96 ~     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 21 |     return CircuitBreaker::new(FAILURE_THRESHOLD, HALF_OPEN_ATTEMPTS, TIMEOUT);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 21 -     return CircuitBreaker::new(FAILURE_THRESHOLD, HALF_OPEN_ATTEMPTS, TIMEOUT);
[INFO] [stdout] 21 +     CircuitBreaker::new(FAILURE_THRESHOLD, HALF_OPEN_ATTEMPTS, TIMEOUT)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:170:13
[INFO] [stdout]     |
[INFO] [stdout] 170 |     assert!(!result.is_err());
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/lib.rs:178:23
[INFO] [stdout]     |
[INFO] [stdout] 178 |       write!(f, "{}", "Action Error")
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal
[INFO] [stdout]     = note: `#[warn(clippy::write_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 178 -       write!(f, "{}", "Action Error")
[INFO] [stdout] 178 +       write!(f, "Action Error")
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/lib.rs:184:23
[INFO] [stdout]     |
[INFO] [stdout] 184 |       write!(f, "{}", "Action Error")
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 184 -       write!(f, "{}", "Action Error")
[INFO] [stdout] 184 +       write!(f, "Action Error")
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing
[INFO] [stdout]   --> src/circuit_breaker.rs:52:5
[INFO] [stdout]    |
[INFO] [stdout] 52 |     mem::drop(state);
[INFO] [stdout]    |     ^^^^^^^^^^-----^
[INFO] [stdout]    |               |
[INFO] [stdout]    |               argument has type `circuit_breaker::CircuitBreakerState`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dropping_copy_types)]` on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the expression or result
[INFO] [stdout]    |
[INFO] [stdout] 52 -     mem::drop(state);
[INFO] [stdout] 52 +     let _ = state;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.59s
[INFO] running `Command { std: "docker" "inspect" "a73d0534b6be4ef3247e2be5b269c6aeac6f0431f874b86eb0c9300de71807ac", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a73d0534b6be4ef3247e2be5b269c6aeac6f0431f874b86eb0c9300de71807ac", kill_on_drop: false }`
[INFO] [stdout] a73d0534b6be4ef3247e2be5b269c6aeac6f0431f874b86eb0c9300de71807ac