[INFO] cloning repository https://github.com/hzy-hits/light_orchestra [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hzy-hits/light_orchestra" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhzy-hits%2Flight_orchestra", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhzy-hits%2Flight_orchestra'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f919c172aaffba1dfdabd9e950093e6f14f526a9 [INFO] linting hzy-hits/light_orchestra against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhzy-hits%2Flight_orchestra" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hzy-hits/light_orchestra [INFO] finished tweaking git repo https://github.com/hzy-hits/light_orchestra [INFO] tweaked toml for git repo https://github.com/hzy-hits/light_orchestra written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hzy-hits/light_orchestra on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hzy-hits/light_orchestra already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quote v1.0.45 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.114 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.114 [INFO] [stderr] Downloaded futures-macro v0.3.32 [INFO] [stderr] Downloaded futures-task v0.3.32 [INFO] [stderr] Downloaded futures-sink v0.3.32 [INFO] [stderr] Downloaded clap_lex v1.0.0 [INFO] [stderr] Downloaded pastey v0.2.1 [INFO] [stderr] Downloaded futures-io v0.3.32 [INFO] [stderr] Downloaded async-trait v0.1.89 [INFO] [stderr] Downloaded slab v0.4.12 [INFO] [stderr] Downloaded anyhow v1.0.102 [INFO] [stderr] Downloaded futures v0.3.32 [INFO] [stderr] Downloaded bumpalo v3.20.2 [INFO] [stderr] Downloaded schemars v1.2.1 [INFO] [stderr] Downloaded crossterm v0.28.1 [INFO] [stderr] Downloaded memchr v2.8.0 [INFO] [stderr] Downloaded wasm-bindgen v0.2.114 [INFO] [stderr] Downloaded clap_builder v4.5.60 [INFO] [stderr] Downloaded futures-util v0.3.32 [INFO] [stderr] Downloaded tokio-util v0.7.18 [INFO] [stderr] Downloaded chrono v0.4.44 [INFO] [stderr] Downloaded ryu v1.0.23 [INFO] [stderr] Downloaded rmcp v1.1.0 [INFO] [stderr] Downloaded syn v2.0.117 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.114 [INFO] [stderr] Downloaded clap v4.5.60 [INFO] [stderr] Downloaded futures-channel v0.3.32 [INFO] [stderr] Downloaded zmij v1.0.21 [INFO] [stderr] Downloaded bitflags v2.11.0 [INFO] [stderr] Downloaded rmcp-macros v1.1.0 [INFO] [stderr] Downloaded schemars_derive v1.2.1 [INFO] [stderr] Downloaded futures-executor v0.3.32 [INFO] [stderr] Downloaded pin-project-lite v0.2.17 [INFO] [stderr] Downloaded tokio-macros v2.6.1 [INFO] [stderr] Downloaded js-sys v0.3.91 [INFO] [stderr] Downloaded unicode-ident v1.0.24 [INFO] [stderr] Downloaded futures-core v0.3.32 [INFO] [stderr] Downloaded libc v0.2.182 [INFO] [stderr] Downloaded tokio v1.50.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c4cc68d9c6781563bfb3d3726cf6478ab1e12be208a54ae708a2ecfd5c2ba22 [INFO] running `Command { std: "docker" "start" "-a" "2c4cc68d9c6781563bfb3d3726cf6478ab1e12be208a54ae708a2ecfd5c2ba22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c4cc68d9c6781563bfb3d3726cf6478ab1e12be208a54ae708a2ecfd5c2ba22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c4cc68d9c6781563bfb3d3726cf6478ab1e12be208a54ae708a2ecfd5c2ba22", kill_on_drop: false }` [INFO] [stdout] 2c4cc68d9c6781563bfb3d3726cf6478ab1e12be208a54ae708a2ecfd5c2ba22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8251fb0cdae9493553ad82975ebbf233dd6f98d25b85be3f9f2673684319dcda [INFO] running `Command { std: "docker" "start" "-a" "8251fb0cdae9493553ad82975ebbf233dd6f98d25b85be3f9f2673684319dcda", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling ref-cast v1.0.25 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Compiling rmcp v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Compiling pastey v0.2.1 [INFO] [stderr] Checking tempfile v3.26.0 (/opt/rustwide/workdir/vendor/tempfile) [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling schemars_derive v1.2.1 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling rmcp-macros v1.1.0 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking schemars v1.2.1 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking codex-par v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> tests/fixtures/fake_codex.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | r#"{"payload":{"type":"token_count","info":{"total_token_usage":{"input_tokens":5000,"output_tokens":200}}}}"# [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 - "{}", [INFO] [stdout] 80 - r#"{"payload":{"type":"token_count","info":{"total_token_usage":{"input_tokens":5000,"output_tokens":200}}}}"# [INFO] [stdout] 79 + "{{\"payload\":{{\"type\":\"token_count\",\"info\":{{\"total_token_usage\":{{\"input_tokens\":5000,\"output_tokens\":200}}}}}}}}" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> tests/fixtures/fake_codex.rs:82:24 [INFO] [stdout] | [INFO] [stdout] 82 | println!("{}", r#"{"payload":{"type":"task_complete"}}"#); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - println!("{}", r#"{"payload":{"type":"task_complete"}}"#); [INFO] [stdout] 82 + println!("{{\"payload\":{{\"type\":\"task_complete\"}}}}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> tests/fixtures/fake_codex.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | r#"{"payload":{"type":"token_count","info":{"total_token_usage":{"input_tokens":1000,"output_tokens":50}}}}"# [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - "{}", [INFO] [stdout] 95 - r#"{"payload":{"type":"token_count","info":{"total_token_usage":{"input_tokens":1000,"output_tokens":50}}}}"# [INFO] [stdout] 94 + "{{\"payload\":{{\"type\":\"token_count\",\"info\":{{\"total_token_usage\":{{\"input_tokens\":1000,\"output_tokens\":50}}}}}}}}" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> tests/fixtures/fake_codex.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | println!("{}", r#"{"payload":{"type":"task_complete"}}"#); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 - println!("{}", r#"{"payload":{"type":"task_complete"}}"#); [INFO] [stdout] 97 + println!("{{\"payload\":{{\"type\":\"task_complete\"}}}}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> tests/fixtures/fake_codex.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | r#"{"payload":{"type":"token_count","info":{"total_token_usage":{"input_tokens":5000,"output_tokens":200}}}}"# [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 - "{}", [INFO] [stdout] 80 - r#"{"payload":{"type":"token_count","info":{"total_token_usage":{"input_tokens":5000,"output_tokens":200}}}}"# [INFO] [stdout] 79 + "{{\"payload\":{{\"type\":\"token_count\",\"info\":{{\"total_token_usage\":{{\"input_tokens\":5000,\"output_tokens\":200}}}}}}}}" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> tests/fixtures/fake_codex.rs:82:24 [INFO] [stdout] | [INFO] [stdout] 82 | println!("{}", r#"{"payload":{"type":"task_complete"}}"#); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - println!("{}", r#"{"payload":{"type":"task_complete"}}"#); [INFO] [stdout] 82 + println!("{{\"payload\":{{\"type\":\"task_complete\"}}}}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> tests/fixtures/fake_codex.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | r#"{"payload":{"type":"token_count","info":{"total_token_usage":{"input_tokens":1000,"output_tokens":50}}}}"# [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - "{}", [INFO] [stdout] 95 - r#"{"payload":{"type":"token_count","info":{"total_token_usage":{"input_tokens":1000,"output_tokens":50}}}}"# [INFO] [stdout] 94 + "{{\"payload\":{{\"type\":\"token_count\",\"info\":{{\"total_token_usage\":{{\"input_tokens\":1000,\"output_tokens\":50}}}}}}}}" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> tests/fixtures/fake_codex.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | println!("{}", r#"{"payload":{"type":"task_complete"}}"#); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 - println!("{}", r#"{"payload":{"type":"task_complete"}}"#); [INFO] [stdout] 97 + println!("{{\"payload\":{{\"type\":\"task_complete\"}}}}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/serve.rs:1175:5 [INFO] [stdout] | [INFO] [stdout] 1175 | messages.sort_by(|a, b| a.created_at.cmp(&b.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1175 - messages.sort_by(|a, b| a.created_at.cmp(&b.created_at)); [INFO] [stdout] 1175 + messages.sort_by_key(|a| a.created_at); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/tail.rs:7:57 [INFO] [stdout] | [INFO] [stdout] 7 | pub async fn tail_follow(log_path: &PathBuf, meta_path: &PathBuf) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 7 - pub async fn tail_follow(log_path: &PathBuf, meta_path: &PathBuf) -> anyhow::Result<()> { [INFO] [stdout] 7 + pub async fn tail_follow(log_path: &PathBuf, meta_path: &Path) -> anyhow::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / impl Default for Sandbox { [INFO] [stdout] 12 | | fn default() -> Self { [INFO] [stdout] 13 | | Sandbox::ReadWrite [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Default)] [INFO] [stdout] 6 | pub enum Sandbox { [INFO] [stdout] 7 | ReadOnly, [INFO] [stdout] 8 ~ #[default] [INFO] [stdout] 9 ~ ReadWrite, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:141:21 [INFO] [stdout] | [INFO] [stdout] 141 | !(has_scope && !task.prompt.trim().is_empty()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!has_scope || task.prompt.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/config.rs:213:25 [INFO] [stdout] | [INFO] [stdout] 213 | .enumerate() [INFO] [stdout] | _________________________^ [INFO] [stdout] 214 | | .map(|(i, t)| (i, t)) [INFO] [stdout] | |_________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/coordinator.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / pub enum DispatchRequest { [INFO] [stdout] 16 | | Task(TaskDef), [INFO] [stdout] | | ------------- the largest variant contains at least 440 bytes [INFO] [stdout] 17 | | Wave(Vec), [INFO] [stdout] | | ------------------ the second-largest variant contains at least 24 bytes [INFO] [stdout] 18 | | Seal, [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ the entire enum is at least 440 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 16 - Task(TaskDef), [INFO] [stdout] 16 + Task(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/serve.rs:1175:5 [INFO] [stdout] | [INFO] [stdout] 1175 | messages.sort_by(|a, b| a.created_at.cmp(&b.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1175 - messages.sort_by(|a, b| a.created_at.cmp(&b.created_at)); [INFO] [stdout] 1175 + messages.sort_by_key(|a| a.created_at); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/commands/tail.rs:7:57 [INFO] [stdout] | [INFO] [stdout] 7 | pub async fn tail_follow(log_path: &PathBuf, meta_path: &PathBuf) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 7 - pub async fn tail_follow(log_path: &PathBuf, meta_path: &PathBuf) -> anyhow::Result<()> { [INFO] [stdout] 7 + pub async fn tail_follow(log_path: &PathBuf, meta_path: &Path) -> anyhow::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / impl Default for Sandbox { [INFO] [stdout] 12 | | fn default() -> Self { [INFO] [stdout] 13 | | Sandbox::ReadWrite [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Default)] [INFO] [stdout] 6 | pub enum Sandbox { [INFO] [stdout] 7 | ReadOnly, [INFO] [stdout] 8 ~ #[default] [INFO] [stdout] 9 ~ ReadWrite, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:141:21 [INFO] [stdout] | [INFO] [stdout] 141 | !(has_scope && !task.prompt.trim().is_empty()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!has_scope || task.prompt.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/config.rs:213:25 [INFO] [stdout] | [INFO] [stdout] 213 | .enumerate() [INFO] [stdout] | _________________________^ [INFO] [stdout] 214 | | .map(|(i, t)| (i, t)) [INFO] [stdout] | |_________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/coordinator.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / pub enum DispatchRequest { [INFO] [stdout] 16 | | Task(TaskDef), [INFO] [stdout] | | ------------- the largest variant contains at least 440 bytes [INFO] [stdout] 17 | | Wave(Vec), [INFO] [stdout] | | ------------------ the second-largest variant contains at least 24 bytes [INFO] [stdout] 18 | | Seal, [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ the entire enum is at least 440 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 16 - Task(TaskDef), [INFO] [stdout] 16 + Task(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/runner.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | let result_path_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `result_path_str` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 167 ~ [INFO] [stdout] 168 ~ let result_path_str = if is_review { [INFO] [stdout] 169 | let abs_result = std::fs::canonicalize(self.output_dir.as_path()) [INFO] [stdout] 170 | .unwrap_or_else(|_| self.output_dir.clone()) [INFO] [stdout] 171 | .join(format!("{}.md", task.name)); [INFO] [stdout] 172 ~ abs_result [INFO] [stdout] 173 | .to_str() [INFO] [stdout] 174 | .ok_or_else(|| anyhow::anyhow!("output file path is not valid UTF-8"))? [INFO] [stdout] 175 ~ .to_string() [INFO] [stdout] 176 | } else { [INFO] [stdout] 177 ~ result_file [INFO] [stdout] 178 | .to_str() [INFO] [stdout] 179 | .ok_or_else(|| anyhow::anyhow!("output file path is not valid UTF-8"))? [INFO] [stdout] 180 ~ .to_string() [INFO] [stdout] 181 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/runner.rs:286:32 [INFO] [stdout] | [INFO] [stdout] 286 | ... if meta.events_count % META_UPDATE_INTERVAL == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `meta.events_count.is_multiple_of(META_UPDATE_INTERVAL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/runner.rs:395:24 [INFO] [stdout] | [INFO] [stdout] 395 | if meta.events_count % META_UPDATE_INTERVAL == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `meta.events_count.is_multiple_of(META_UPDATE_INTERVAL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/runner.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | let result_path_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `result_path_str` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 167 ~ [INFO] [stdout] 168 ~ let result_path_str = if is_review { [INFO] [stdout] 169 | let abs_result = std::fs::canonicalize(self.output_dir.as_path()) [INFO] [stdout] 170 | .unwrap_or_else(|_| self.output_dir.clone()) [INFO] [stdout] 171 | .join(format!("{}.md", task.name)); [INFO] [stdout] 172 ~ abs_result [INFO] [stdout] 173 | .to_str() [INFO] [stdout] 174 | .ok_or_else(|| anyhow::anyhow!("output file path is not valid UTF-8"))? [INFO] [stdout] 175 ~ .to_string() [INFO] [stdout] 176 | } else { [INFO] [stdout] 177 ~ result_file [INFO] [stdout] 178 | .to_str() [INFO] [stdout] 179 | .ok_or_else(|| anyhow::anyhow!("output file path is not valid UTF-8"))? [INFO] [stdout] 180 ~ .to_string() [INFO] [stdout] 181 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/runner.rs:286:32 [INFO] [stdout] | [INFO] [stdout] 286 | ... if meta.events_count % META_UPDATE_INTERVAL == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `meta.events_count.is_multiple_of(META_UPDATE_INTERVAL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/runner.rs:395:24 [INFO] [stdout] | [INFO] [stdout] 395 | if meta.events_count % META_UPDATE_INTERVAL == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `meta.events_count.is_multiple_of(META_UPDATE_INTERVAL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.59s [INFO] running `Command { std: "docker" "inspect" "8251fb0cdae9493553ad82975ebbf233dd6f98d25b85be3f9f2673684319dcda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8251fb0cdae9493553ad82975ebbf233dd6f98d25b85be3f9f2673684319dcda", kill_on_drop: false }` [INFO] [stdout] 8251fb0cdae9493553ad82975ebbf233dd6f98d25b85be3f9f2673684319dcda