[INFO] cloning repository https://github.com/humanalgorithm/data_structures_algorithms_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/humanalgorithm/data_structures_algorithms_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhumanalgorithm%2Fdata_structures_algorithms_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhumanalgorithm%2Fdata_structures_algorithms_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 76ded9d65b66e020657a06fdc1976aaa04f92dfa [INFO] linting humanalgorithm/data_structures_algorithms_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhumanalgorithm%2Fdata_structures_algorithms_rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/humanalgorithm/data_structures_algorithms_rust [INFO] finished tweaking git repo https://github.com/humanalgorithm/data_structures_algorithms_rust [INFO] tweaked toml for git repo https://github.com/humanalgorithm/data_structures_algorithms_rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/humanalgorithm/data_structures_algorithms_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/humanalgorithm/data_structures_algorithms_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitflags v2.9.1 [INFO] [stderr] Downloaded syn v2.0.101 [INFO] [stderr] Downloaded zerocopy-derive v0.8.25 [INFO] [stderr] Downloaded zerocopy v0.8.25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9cab3bd5b3136dc934d4ece8ecbfe73e1348214da09826ba3e39410b23d73726 [INFO] running `Command { std: "docker" "start" "-a" "9cab3bd5b3136dc934d4ece8ecbfe73e1348214da09826ba3e39410b23d73726", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9cab3bd5b3136dc934d4ece8ecbfe73e1348214da09826ba3e39410b23d73726", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9cab3bd5b3136dc934d4ece8ecbfe73e1348214da09826ba3e39410b23d73726", kill_on_drop: false }` [INFO] [stdout] 9cab3bd5b3136dc934d4ece8ecbfe73e1348214da09826ba3e39410b23d73726 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84016e6d09f8c5e5e51e3b2369ab7f304200fbc799a36d4604c28d70d777f4c1 [INFO] running `Command { std: "docker" "start" "-a" "84016e6d09f8c5e5e51e3b2369ab7f304200fbc799a36d4604c28d70d777f4c1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking remove_nth_node_from_end_of_list v0.1.0 (/opt/rustwide/workdir/remove_nth_node_from_end_of_list) [INFO] [stderr] Checking container_with_most_water v0.1.0 (/opt/rustwide/workdir/container_with_most_water) [INFO] [stderr] Checking three_sum v0.1.0 (/opt/rustwide/workdir/three_sum) [INFO] [stderr] Checking group_anagrams v0.1.0 (/opt/rustwide/workdir/group_anagrams) [INFO] [stderr] Checking decode_string v0.1.0 (/opt/rustwide/workdir/decode_string) [INFO] [stderr] Checking target_sum v0.1.0 (/opt/rustwide/workdir/target_sum) [INFO] [stderr] Checking combination_sum_ii v0.1.0 (/opt/rustwide/workdir/combination_sum_ii) [INFO] [stderr] Checking minimum_path_sum v0.1.0 (/opt/rustwide/workdir/minimum_path_sum) [INFO] [stderr] Checking unique_binary_search_trees v0.1.0 (/opt/rustwide/workdir/unique_binary_search_trees) [INFO] [stderr] Checking reverse_words_in_a_string_ii v0.1.0 (/opt/rustwide/workdir/reverse_words_in_a_string_ii) [INFO] [stderr] Checking add_binary v0.1.0 (/opt/rustwide/workdir/add_binary) [INFO] [stderr] Checking merge_two_sorted_lists v0.1.0 (/opt/rustwide/workdir/merge_two_sorted_lists) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> add_binary/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | a: "11".to_string(), [INFO] [stdout] 9 | | b: "1".to_string(), [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + a: "11".to_string(), [INFO] [stdout] 9 + b: "1".to_string(), [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> add_binary/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | a: "1010".to_string(), [INFO] [stdout] 16 | | b: "1011".to_string(), [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + a: "1010".to_string(), [INFO] [stdout] 16 + b: "1011".to_string(), [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> add_binary/src/solution.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return output.iter().rev().map(|s| s.to_string()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return output.iter().rev().map(|s| s.to_string()).collect(); [INFO] [stdout] 26 + output.iter().rev().map(|s| s.to_string()).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> remove_nth_node_from_end_of_list/src/data.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | Data { head: head, n: 1 } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> container_with_most_water/src/solution.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return max_vol; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return max_vol; [INFO] [stdout] 19 + max_vol [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> container_with_most_water/src/solution.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | let ci_height = height[i as usize] as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `height[i as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> container_with_most_water/src/solution.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | let ci_height = height[i as usize] as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> container_with_most_water/src/solution.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | let cj_height = height[j as usize] as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `height[j as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> container_with_most_water/src/solution.rs:9:32 [INFO] [stdout] | [INFO] [stdout] 9 | let cj_height = height[j as usize] as i32; [INFO] [stdout] | ^^^^^^^^^^ help: try: `j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> container_with_most_water/src/solution.rs:11:38 [INFO] [stdout] | [INFO] [stdout] 11 | let curr_vol: i32 = cmp::min(ci_height as i32, cj_height) * (j as i32 - i as i32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `ci_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum_ii/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | candidates: vec![10, 1, 2, 7, 6, 1, 5], [INFO] [stdout] 9 | | target: 8, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + candidates: vec![10, 1, 2, 7, 6, 1, 5], [INFO] [stdout] 9 + target: 8, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum_ii/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | candidates: vec![2, 5, 2, 1, 2], [INFO] [stdout] 16 | | target: 5, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + candidates: vec![2, 5, 2, 1, 2], [INFO] [stdout] 16 + target: 5, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> combination_sum_ii/src/solution.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | candidates: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - candidates: &mut Vec, [INFO] [stdout] 4 + candidates: &mut [i32], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum_ii/src/solution.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return res; [INFO] [stdout] 44 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking implement_trie_prefix_tree v0.1.0 (/opt/rustwide/workdir/implement_trie_prefix_tree) [INFO] [stderr] Checking roman_to_integer v0.1.0 (/opt/rustwide/workdir/roman_to_integer) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> minimum_path_sum/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | grid: vec![vec![1, 3, 1], vec![1, 5, 1], vec![4, 2, 1]], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + grid: vec![vec![1, 3, 1], vec![1, 5, 1], vec![4, 2, 1]], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> minimum_path_sum/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | grid: vec![vec![1, 2, 3], vec![4, 5, 6]], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + grid: vec![vec![1, 2, 3], vec![4, 5, 6]], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> minimum_path_sum/src/solution.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return side_matrix[row_len - 1][col_len - 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return side_matrix[row_len - 1][col_len - 1]; [INFO] [stdout] 28 + side_matrix[row_len - 1][col_len - 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking find_duplicate_file_in_system v0.1.0 (/opt/rustwide/workdir/find_duplicate_file_in_system) [INFO] [stderr] Checking coin_change v0.1.0 (/opt/rustwide/workdir/coin_change) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | list1: list1, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `list1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | list2: list2, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `list2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | list1: list1, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `list1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | list2: list2, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `list2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | list1: list1, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `list1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | list2: list2, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `list2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> three_sum/src/solution.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return output_set.into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return output_set.into_iter().collect(); [INFO] [stdout] 31 + output_set.into_iter().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking course_schedule_ii v0.1.0 (/opt/rustwide/workdir/course_schedule_ii) [INFO] [stderr] Checking integer_to_roman v0.1.0 (/opt/rustwide/workdir/integer_to_roman) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> group_anagrams/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | strs: vec![ [INFO] [stdout] 8 | | "eat".to_string(), [INFO] [stdout] 9 | | "tea".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 14 | | ], [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + strs: vec![ [INFO] [stdout] 8 + "eat".to_string(), [INFO] [stdout] 9 + "tea".to_string(), [INFO] [stdout] 10 + "tan".to_string(), [INFO] [stdout] 11 + "ate".to_string(), [INFO] [stdout] 12 + "nat".to_string(), [INFO] [stdout] 13 + "bat".to_string(), [INFO] [stdout] 14 + ], [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> group_anagrams/src/data.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / return Data { [INFO] [stdout] 20 | | strs: vec!["".to_string()], [INFO] [stdout] 21 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Data { [INFO] [stdout] 20 + strs: vec!["".to_string()], [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> group_anagrams/src/data.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / return Data { [INFO] [stdout] 26 | | strs: vec!["a".to_string()], [INFO] [stdout] 27 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ Data { [INFO] [stdout] 26 + strs: vec!["a".to_string()], [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> group_anagrams/src/solution.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return ret_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return ret_value; [INFO] [stdout] 14 + ret_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> decode_string/src/solution.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return res; [INFO] [stdout] 27 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `s_chars` [INFO] [stdout] --> decode_string/src/solution.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for x in 0..s_chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 5 - for x in 0..s_chars.len() { [INFO] [stdout] 5 + for in &s_chars { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> reverse_words_in_a_string_ii/src/solution.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn reverse_words(s: &mut Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn reverse_words(s: &mut Vec) -> Vec { [INFO] [stdout] 1 + pub fn reverse_words(s: &mut [char]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> decode_string/src/solution.rs:16:40 [INFO] [stdout] | [INFO] [stdout] 16 | while !stack.is_empty() && stack.last().unwrap().is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stack.last().unwrap().is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> target_sum/src/solution.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return dp[&(index, current)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return dp[&(index, current)]; [INFO] [stdout] 18 + dp[&(index, current)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> target_sum/src/solution.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | let res = backtrack(nums, &mut dp, index + 1, current + nums[index], target) [INFO] [stdout] | ^^^^^^^ help: change this to: `dp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> target_sum/src/solution.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | + backtrack(nums, &mut dp, index + 1, current - nums[index], target); [INFO] [stdout] | ^^^^^^^ help: change this to: `dp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> target_sum/src/solution.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return dp[&(0, 0)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return dp[&(0, 0)]; [INFO] [stdout] 23 + dp[&(0, 0)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_binary_search_trees/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | return Data { n: 3 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return Data { n: 3 }; [INFO] [stdout] 7 + Data { n: 3 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_binary_search_trees/src/data.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return Data { n: 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return Data { n: 1 }; [INFO] [stdout] 11 + Data { n: 1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_binary_search_trees/src/solution.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return num_trees[n as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return num_trees[n as usize]; [INFO] [stdout] 14 + num_trees[n as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking combination_sum v0.1.0 (/opt/rustwide/workdir/combination_sum) [INFO] [stderr] Checking letter_combinations_of_a_phone_number v0.1.0 (/opt/rustwide/workdir/letter_combinations_of_a_phone_number) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 32 | let head = Some(node1); [INFO] [stdout] | ----------------------- unnecessary `let` binding [INFO] [stdout] 33 | head [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 32 ~ [INFO] [stdout] 33 ~ Some(node1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | let head = Some(node1); [INFO] [stdout] | ----------------------- unnecessary `let` binding [INFO] [stdout] 49 | head [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 48 ~ [INFO] [stdout] 49 ~ Some(node1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> merge_two_sorted_lists/src/data.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 86 | let head = Some(Box::new(ListNode::new(0))); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 87 | head [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 86 ~ [INFO] [stdout] 87 ~ Some(Box::new(ListNode::new(0))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking partition_equal_subset_sum v0.1.0 (/opt/rustwide/workdir/partition_equal_subset_sum) [INFO] [stderr] Checking find_the_index_of_the_first_occurrence_in_a_string v0.1.0 (/opt/rustwide/workdir/find_the_index_of_the_first_occurrence_in_a_string) [INFO] [stderr] Checking game_of_life v0.1.0 (/opt/rustwide/workdir/game_of_life) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | num_courses: 2, [INFO] [stdout] 9 | | prerequisites: vec![vec![1, 0]], [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + num_courses: 2, [INFO] [stdout] 9 + prerequisites: vec![vec![1, 0]], [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | num_courses: 4, [INFO] [stdout] 16 | | prerequisites: vec![vec![1, 0], vec![2, 0], vec![3, 1], vec![3, 2]], [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + num_courses: 4, [INFO] [stdout] 16 + prerequisites: vec![vec![1, 0], vec![2, 0], vec![3, 1], vec![3, 2]], [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | num_courses: 1, [INFO] [stdout] 23 | | prerequisites: vec![], [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + num_courses: 1, [INFO] [stdout] 23 + prerequisites: vec![], [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/solution.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/solution.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return path; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return path; [INFO] [stdout] 54 + path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_duplicate_file_in_system/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | paths: vec![ [INFO] [stdout] 8 | | "root/a 1.txt(abcd) 2.txt(efgh)".to_string(), [INFO] [stdout] 9 | | "root/c 3.txt(abcd)".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 12 | | ], [INFO] [stdout] 13 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + paths: vec![ [INFO] [stdout] 8 + "root/a 1.txt(abcd) 2.txt(efgh)".to_string(), [INFO] [stdout] 9 + "root/c 3.txt(abcd)".to_string(), [INFO] [stdout] 10 + "root/c/d 4.txt(efgh)".to_string(), [INFO] [stdout] 11 + "root 4.txt(efgh)".to_string(), [INFO] [stdout] 12 + ], [INFO] [stdout] 13 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_duplicate_file_in_system/src/data.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return Data { [INFO] [stdout] 18 | | paths: vec![ [INFO] [stdout] 19 | | "root/a 1.txt(abcd) 2.txt(efgh)".to_string(), [INFO] [stdout] 20 | | "root/c 3.txt(abcd)".to_string(), [INFO] [stdout] 21 | | "root/c/d 4.txt(efgh)".to_string(), [INFO] [stdout] 22 | | ], [INFO] [stdout] 23 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Data { [INFO] [stdout] 18 + paths: vec![ [INFO] [stdout] 19 + "root/a 1.txt(abcd) 2.txt(efgh)".to_string(), [INFO] [stdout] 20 + "root/c 3.txt(abcd)".to_string(), [INFO] [stdout] 21 + "root/c/d 4.txt(efgh)".to_string(), [INFO] [stdout] 22 + ], [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_duplicate_file_in_system/src/solution.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return res; [INFO] [stdout] 48 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking construct_binary_tree_from_preorder_and_inorder_traversal v0.1.0 (/opt/rustwide/workdir/construct_binary_tree_from_preorder_and_inorder_traversal) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> integer_to_roman/src/solution.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return output_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return output_str; [INFO] [stdout] 59 + output_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> integer_to_roman/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | exp = exp - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `exp -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> roman_to_integer/src/solution.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return output_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return output_num; [INFO] [stdout] 42 + output_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking remove_element v0.1.0 (/opt/rustwide/workdir/remove_element) [INFO] [stderr] Checking course_schedule v0.1.0 (/opt/rustwide/workdir/course_schedule) [INFO] [stdout] warning: the loop variable `x` is used to index `char_vec` [INFO] [stdout] --> roman_to_integer/src/solution.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | for x in 0..char_len { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 19 - for x in 0..char_len { [INFO] [stdout] 19 + for (x, ) in char_vec.iter().enumerate().take(char_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> coin_change/src/solution.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / return if dp[amount as usize] != amount + 1 { [INFO] [stdout] 14 | | dp[amount as usize] [INFO] [stdout] 15 | | } else { [INFO] [stdout] 16 | | -1 [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ if dp[amount as usize] != amount + 1 { [INFO] [stdout] 14 + dp[amount as usize] [INFO] [stdout] 15 + } else { [INFO] [stdout] 16 + -1 [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> partition_equal_subset_sum/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![1, 5, 11, 5], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![1, 5, 11, 5], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> partition_equal_subset_sum/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![1, 2, 3, 5], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![1, 2, 3, 5], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> partition_equal_subset_sum/src/solution.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return false; [INFO] [stdout] 22 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> roman_to_integer/src/solution.rs:29:48 [INFO] [stdout] | [INFO] [stdout] 29 | } else if value_prev > current_val { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 30 | | output_num += value_prev; [INFO] [stdout] 31 | | } else if current_val == value_prev { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> roman_to_integer/src/solution.rs:31:49 [INFO] [stdout] | [INFO] [stdout] 31 | } else if current_val == value_prev { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 32 | | output_num += value_prev; [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> partition_equal_subset_sum/src/solution.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | let total_sum: i32 = nums.iter().map(|&i| i).sum(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `nums.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> coin_change/src/solution.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 8 | if (a as i32 - c as i32) as i32 >= 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(a as i32 - c as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking daily_temperatures v0.1.0 (/opt/rustwide/workdir/daily_temperatures) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> implement_trie_prefix_tree/src/data.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / return Data { [INFO] [stdout] 9 | | commands: vec![ [INFO] [stdout] 10 | | "Trie".to_string(), [INFO] [stdout] 11 | | "insert".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 26 | | ], [INFO] [stdout] 27 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 ~ Data { [INFO] [stdout] 9 + commands: vec![ [INFO] [stdout] 10 + "Trie".to_string(), [INFO] [stdout] 11 + "insert".to_string(), [INFO] [stdout] 12 + "search".to_string(), [INFO] [stdout] 13 + "search".to_string(), [INFO] [stdout] 14 + "startsWith".to_string(), [INFO] [stdout] 15 + "insert".to_string(), [INFO] [stdout] 16 + "search".to_string(), [INFO] [stdout] 17 + ], [INFO] [stdout] 18 + values: vec![ [INFO] [stdout] 19 + vec![], [INFO] [stdout] 20 + vec!["apple".to_string()], [INFO] [stdout] 21 + vec!["apple".to_string()], [INFO] [stdout] 22 + vec!["app".to_string()], [INFO] [stdout] 23 + vec!["app".to_string()], [INFO] [stdout] 24 + vec!["app".to_string()], [INFO] [stdout] 25 + vec!["app".to_string()], [INFO] [stdout] 26 + ], [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> daily_temperatures/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | temperatures: vec![73, 74, 75, 71, 69, 72, 76, 73], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + temperatures: vec![73, 74, 75, 71, 69, 72, 76, 73], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> daily_temperatures/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | temperatures: vec![30, 40, 50, 60], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + temperatures: vec![30, 40, 50, 60], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> daily_temperatures/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | temperatures: vec![30, 60, 90], [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + temperatures: vec![30, 60, 90], [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> daily_temperatures/src/solution.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return output; [INFO] [stdout] 13 + output [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking reconstruct_itinerary v0.1.0 (/opt/rustwide/workdir/reconstruct_itinerary) [INFO] [stderr] Checking find_leaves_of_binary_tree v0.1.0 (/opt/rustwide/workdir/find_leaves_of_binary_tree) [INFO] [stderr] Checking kth_smallest_element_in_a_bst v0.1.0 (/opt/rustwide/workdir/kth_smallest_element_in_a_bst) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Trie` [INFO] [stdout] --> implement_trie_prefix_tree/src/solution.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn new() -> Self { [INFO] [stdout] 29 | | Self { [INFO] [stdout] 30 | | root: TrieNode::new(), [INFO] [stdout] 31 | | } [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 27 + impl Default for Trie { [INFO] [stdout] 28 + fn default() -> Self { [INFO] [stdout] 29 + Self::new() [INFO] [stdout] 30 + } [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | digits: "23".to_string(), [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + digits: "23".to_string(), [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | digits: "".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + digits: "".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | digits: "2".to_string(), [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + digits: "2".to_string(), [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | candidates: vec![2, 3, 6, 7], [INFO] [stdout] 9 | | target: 7, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + candidates: vec![2, 3, 6, 7], [INFO] [stdout] 9 + target: 7, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | candidates: vec![2, 3, 5], [INFO] [stdout] 16 | | target: 8, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + candidates: vec![2, 3, 5], [INFO] [stdout] 16 + target: 8, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | dfs(&digits, &map, index + 1, new_path, res.as_mut()); [INFO] [stdout] | ^^^^^^^ help: change this to: `digits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:16:22 [INFO] [stdout] | [INFO] [stdout] 16 | dfs(&digits, &map, index + 1, new_path, res.as_mut()); [INFO] [stdout] | ^^^^ help: change this to: `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_mut` does nothing [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:16:49 [INFO] [stdout] | [INFO] [stdout] 16 | dfs(&digits, &map, index + 1, new_path, res.as_mut()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return res; [INFO] [stdout] 39 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | candidates: vec![2], [INFO] [stdout] 23 | | target: 1, [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + candidates: vec![2], [INFO] [stdout] 23 + target: 1, [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if digits.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `digits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> combination_sum/src/solution.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | candidates: &Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - candidates: &Vec, [INFO] [stdout] 3 + candidates: &[i32], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&letter).is_some()` [INFO] [stdout] --> implement_trie_prefix_tree/src/solution.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 38 | if node.children.get(&letter).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&letter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking swap_nodes_in_pairs v0.1.0 (/opt/rustwide/workdir/swap_nodes_in_pairs) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum/src/solution.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return combinations.iter().map(|v| v.to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return combinations.iter().map(|v| v.to_vec()).collect(); [INFO] [stdout] 38 + combinations.iter().map(|v| v.to_vec()).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> game_of_life/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | board: vec![vec![0, 1, 0], vec![0, 0, 1], vec![1, 1, 1], vec![0, 0, 0]], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + board: vec![vec![0, 1, 0], vec![0, 0, 1], vec![1, 1, 1], vec![0, 0, 0]], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> game_of_life/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | board: vec![vec![1, 1], vec![1, 0]], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + board: vec![vec![1, 1], vec![1, 0]], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking insert_interval v0.1.0 (/opt/rustwide/workdir/insert_interval) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> implement_trie_prefix_tree/src/solution.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return node.end_word; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return node.end_word; [INFO] [stdout] 58 + node.end_word [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking four_sum v0.1.0 (/opt/rustwide/workdir/four_sum) [INFO] [stdout] warning: unnecessary use of `get(&letter).is_some()` [INFO] [stdout] --> implement_trie_prefix_tree/src/solution.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | if node.children.get(&letter).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&letter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> implement_trie_prefix_tree/src/solution.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return true; [INFO] [stdout] 72 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&letter).is_some()` [INFO] [stdout] --> implement_trie_prefix_tree/src/solution.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | if node.children.get(&letter).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&letter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking invert_binary_tree v0.1.0 (/opt/rustwide/workdir/invert_binary_tree) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | _num_courses: 2, [INFO] [stdout] 9 | | prerequisites: vec![vec![1, 0]], [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + _num_courses: 2, [INFO] [stdout] 9 + prerequisites: vec![vec![1, 0]], [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | _num_courses: 2, [INFO] [stdout] 16 | | prerequisites: vec![vec![1, 0], vec![0, 1]], [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + _num_courses: 2, [INFO] [stdout] 16 + prerequisites: vec![vec![1, 0], vec![0, 1]], [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> swap_nodes_in_pairs/src/data.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking climbing_stairs v0.1.0 (/opt/rustwide/workdir/climbing_stairs) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> swap_nodes_in_pairs/src/data.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> swap_nodes_in_pairs/src/data.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> swap_nodes_in_pairs/src/data.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_the_index_of_the_first_occurrence_in_a_string/src/solution.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return -1; [INFO] [stdout] 18 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> course_schedule/src/solution.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | if !course_map.get(¤t).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `course_map.get(¤t).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule/src/solution.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return true; [INFO] [stdout] 23 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule/src/solution.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return true; [INFO] [stdout] 41 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> invert_binary_tree/src/data.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> invert_binary_tree/src/data.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 68 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> invert_binary_tree/src/data.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking move_zeroes v0.1.0 (/opt/rustwide/workdir/move_zeroes) [INFO] [stderr] Checking validate_binary_search_tree v0.1.0 (/opt/rustwide/workdir/validate_binary_search_tree) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_leaves_of_binary_tree/src/solution.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return max_layer + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return max_layer + 1; [INFO] [stdout] 24 + max_layer + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> reconstruct_itinerary/src/solution.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | if !has_tickets.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `has_tickets.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> reconstruct_itinerary/src/solution.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return false; [INFO] [stdout] 36 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking number_of_islands v0.1.0 (/opt/rustwide/workdir/number_of_islands) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_leaves_of_binary_tree/src/solution.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return res; [INFO] [stdout] 37 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> find_leaves_of_binary_tree/src/solution.rs:32:49 [INFO] [stdout] | [INFO] [stdout] 32 | let mut keys: Vec = map.keys().map(|m| *m as i32).collect(); [INFO] [stdout] | ^^^^^^^^^ help: try: `*m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> reconstruct_itinerary/src/solution.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | if ticket == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ticket.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> reconstruct_itinerary/src/solution.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return path; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return path; [INFO] [stdout] 72 + path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> insert_interval/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | intervals: vec![vec![1, 3], vec![6, 9]], [INFO] [stdout] 9 | | new_interval: vec![2, 5], [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + intervals: vec![vec![1, 3], vec![6, 9]], [INFO] [stdout] 9 + new_interval: vec![2, 5], [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> invert_binary_tree/src/solution.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | if !root.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `root.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> insert_interval/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | intervals: vec![ [INFO] [stdout] 16 | | vec![1, 2], [INFO] [stdout] 17 | | vec![3, 5], [INFO] [stdout] ... | [INFO] [stdout] 22 | | new_interval: vec![4, 8], [INFO] [stdout] 23 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + intervals: vec![ [INFO] [stdout] 16 + vec![1, 2], [INFO] [stdout] 17 + vec![3, 5], [INFO] [stdout] 18 + vec![6, 7], [INFO] [stdout] 19 + vec![8, 10], [INFO] [stdout] 20 + vec![12, 16], [INFO] [stdout] 21 + ], [INFO] [stdout] 22 + new_interval: vec![4, 8], [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> invert_binary_tree/src/solution.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return root; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return root; [INFO] [stdout] 30 + root [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking valid_sudoku v0.1.0 (/opt/rustwide/workdir/valid_sudoku) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> swap_nodes_in_pairs/src/solution.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return dummy.next; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return dummy.next; [INFO] [stdout] 22 + dummy.next [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> insert_interval/src/solution.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return stack; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return stack; [INFO] [stdout] 25 + stack [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> kth_smallest_element_in_a_bst/src/solution.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return 0; [INFO] [stdout] 23 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking edit_distance v0.1.0 (/opt/rustwide/workdir/edit_distance) [INFO] [stderr] Checking permutations_ii v0.1.0 (/opt/rustwide/workdir/permutations_ii) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> construct_binary_tree_from_preorder_and_inorder_traversal/src/solution.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return Some(Rc::new(RefCell::new(root))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return Some(Rc::new(RefCell::new(root))); [INFO] [stdout] 13 + Some(Rc::new(RefCell::new(root))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking two_sum v0.1.0 (/opt/rustwide/workdir/two_sum) [INFO] [stderr] Checking permutations v0.1.0 (/opt/rustwide/workdir/permutations) [INFO] [stderr] Checking fizz_buzz v0.1.0 (/opt/rustwide/workdir/fizz_buzz) [INFO] [stderr] Checking remove_duplicates_from_sorted_array v0.1.0 (/opt/rustwide/workdir/remove_duplicates_from_sorted_array) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> valid_sudoku/src/solution.rs:3:27 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn print_board(board: &Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn print_board(board: &Vec>) { [INFO] [stdout] 3 + pub fn print_board(board: &[Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:4:14 [INFO] [stdout] | [INFO] [stdout] 4 | for i in 0..board.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 4 - for i in 0..board.len() { [INFO] [stdout] 4 + for (i, ) in board.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | for j in 0..board[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 6 - for j in 0..board[i].len() { [INFO] [stdout] 6 + for (j, ) in board.iter().enumerate().take(board[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> valid_sudoku/src/solution.rs:7:38 [INFO] [stdout] | [INFO] [stdout] 7 | let char_print: String = format!("{}", board[i][j].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `board[i][j].to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> valid_sudoku/src/solution.rs:7:63 [INFO] [stdout] | [INFO] [stdout] 7 | let char_print: String = format!("{}", board[i][j].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> valid_sudoku/src/solution.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_sudoku/src/solution.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return true; [INFO] [stdout] 35 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> valid_sudoku/src/solution.rs:21:26 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn check_rows(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - pub fn check_rows(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] 21 + pub fn check_rows(board: &[Vec], row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | for i in 0..row_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 22 - for i in 0..row_len { [INFO] [stdout] 22 + for in board.iter().take(row_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 24 | for j in 0..col_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 24 - for j in 0..col_len { [INFO] [stdout] 24 + for in board.iter().take(col_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> valid_sudoku/src/solution.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | / match row_chars.get(&this_char) { [INFO] [stdout] 27 | | Some(_) => return false, [INFO] [stdout] 28 | | None => {} [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(_) = row_chars.get(&this_char) { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> validate_binary_search_tree/src/data.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_sudoku/src/solution.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return true; [INFO] [stdout] 51 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> valid_sudoku/src/solution.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn check_cols(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - pub fn check_cols(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] 37 + pub fn check_cols(board: &[Vec], row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 38 | for i in 0..col_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 38 - for i in 0..col_len { [INFO] [stdout] 38 + for in board.iter().take(col_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 40 | for j in 0..row_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 40 - for j in 0..row_len { [INFO] [stdout] 40 + for in board.iter().take(row_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> valid_sudoku/src/solution.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | / match col_chars.get(&this_char) { [INFO] [stdout] 43 | | Some(_) => return false, [INFO] [stdout] 44 | | None => {} [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(_) = col_chars.get(&this_char) { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_sudoku/src/solution.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return true; [INFO] [stdout] 76 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> valid_sudoku/src/solution.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn check_grid(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - pub fn check_grid(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] 53 + pub fn check_grid(board: &[Vec], row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | for i in box_row * 3..box_row * 3 + 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 60 - for i in box_row * 3..box_row * 3 + 3 { [INFO] [stdout] 60 + for in board.iter().skip(box_row * 3).take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 61 | for j in box_col * 3..box_col * 3 + 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 61 - for j in box_col * 3..box_col * 3 + 3 { [INFO] [stdout] 61 + for in board.iter().skip(box_col * 3).take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> climbing_stairs/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | return Data { n: 2 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return Data { n: 2 }; [INFO] [stdout] 6 + Data { n: 2 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> climbing_stairs/src/data.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return Data { n: 3 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return Data { n: 3 }; [INFO] [stdout] 10 + Data { n: 3 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> valid_sudoku/src/solution.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | / match box_chars.get(&this_char) { [INFO] [stdout] 64 | | Some(_) => return false, [INFO] [stdout] 65 | | None => {} [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(_) = box_chars.get(&this_char) { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_sudoku/src/solution.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return rows_valid && cols_valid && grid_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return rows_valid && cols_valid && grid_valid; [INFO] [stdout] 83 + rows_valid && cols_valid && grid_valid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> climbing_stairs/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return step_1 + step_2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return step_1 + step_2; [INFO] [stdout] 21 + step_1 + step_2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking add_two_numbers v0.1.0 (/opt/rustwide/workdir/add_two_numbers) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> four_sum/src/solution.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return output.iter().map(|m| m.to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return output.iter().map(|m| m.to_vec()).collect(); [INFO] [stdout] 62 + output.iter().map(|m| m.to_vec()).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> climbing_stairs/src/solution.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return dfs(n, 0, &mut solutions); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return dfs(n, 0, &mut solutions); [INFO] [stdout] 26 + dfs(n, 0, &mut solutions) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations_ii/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![1, 1, 2], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![1, 1, 2], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations_ii/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![1, 2, 3], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![1, 2, 3], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> permutations_ii/src/solution.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | post: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - post: &mut Vec, [INFO] [stdout] 6 + post: &mut [i32], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> move_zeroes/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![0, 1, 0, 3, 12], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![0, 1, 0, 3, 12], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> move_zeroes/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return Data { nums: vec![0] }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return Data { nums: vec![0] }; [INFO] [stdout] 12 + Data { nums: vec![0] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `nums` [INFO] [stdout] --> move_zeroes/src/solution.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | for x in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 3 - for x in 0..nums.len() { [INFO] [stdout] 3 + for in &nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> validate_binary_search_tree/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return result.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return result.is_empty(); [INFO] [stdout] 21 + result.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations_ii/src/solution.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return res; [INFO] [stdout] 26 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> validate_binary_search_tree/src/solution.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | .filter(|n| *n == false) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `!*n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking search_in_rotated_sorted_array v0.1.0 (/opt/rustwide/workdir/search_in_rotated_sorted_array) [INFO] [stderr] Checking house_robber_iii v0.1.0 (/opt/rustwide/workdir/house_robber_iii) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> number_of_islands/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | grid: vec![ [INFO] [stdout] 8 | | vec!['1', '1', '1', '1', '0'], [INFO] [stdout] 9 | | vec!['1', '1', '0', '1', '0'], [INFO] [stdout] ... | [INFO] [stdout] 12 | | ], [INFO] [stdout] 13 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + grid: vec![ [INFO] [stdout] 8 + vec!['1', '1', '1', '1', '0'], [INFO] [stdout] 9 + vec!['1', '1', '0', '1', '0'], [INFO] [stdout] 10 + vec!['1', '1', '0', '0', '0'], [INFO] [stdout] 11 + vec!['0', '0', '0', '0', '0'], [INFO] [stdout] 12 + ], [INFO] [stdout] 13 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> number_of_islands/src/data.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return Data { [INFO] [stdout] 18 | | grid: vec![ [INFO] [stdout] 19 | | vec!['1', '1', '0', '0', '0'], [INFO] [stdout] 20 | | vec!['1', '1', '0', '0', '0'], [INFO] [stdout] ... | [INFO] [stdout] 23 | | ], [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Data { [INFO] [stdout] 18 + grid: vec![ [INFO] [stdout] 19 + vec!['1', '1', '0', '0', '0'], [INFO] [stdout] 20 + vec!['1', '1', '0', '0', '0'], [INFO] [stdout] 21 + vec!['0', '0', '1', '0', '0'], [INFO] [stdout] 22 + vec!['0', '0', '0', '1', '1'], [INFO] [stdout] 23 + ], [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> number_of_islands/src/solution.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return islands; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return islands; [INFO] [stdout] 42 + islands [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking kth_largest_element_in_an_array v0.1.0 (/opt/rustwide/workdir/kth_largest_element_in_an_array) [INFO] [stderr] Checking maximum_subarray v0.1.0 (/opt/rustwide/workdir/maximum_subarray) [INFO] [stderr] Checking find_first_and_last_position_of_element_in_sorted_array v0.1.0 (/opt/rustwide/workdir/find_first_and_last_position_of_element_in_sorted_array) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> two_sum/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![2, 7, 11, 15], [INFO] [stdout] 9 | | target: 9, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![2, 7, 11, 15], [INFO] [stdout] 9 + target: 9, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking maximum_product_subarray v0.1.0 (/opt/rustwide/workdir/maximum_product_subarray) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> two_sum/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![3, 2, 4], [INFO] [stdout] 16 | | target: 6, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![3, 2, 4], [INFO] [stdout] 16 + target: 6, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking permutation_in_string v0.1.0 (/opt/rustwide/workdir/permutation_in_string) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> two_sum/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | nums: vec![3, 3], [INFO] [stdout] 23 | | target: 6, [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + nums: vec![3, 3], [INFO] [stdout] 23 + target: 6, [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> two_sum/src/solution.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return nums; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return nums; [INFO] [stdout] 13 + nums [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> house_robber_iii/src/solution.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return (with_root, without_root); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return (with_root, without_root); [INFO] [stdout] 17 + (with_root, without_root) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> house_robber_iii/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return cmp::max(pair.0, pair.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return cmp::max(pair.0, pair.1); [INFO] [stdout] 21 + cmp::max(pair.0, pair.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![1, 2, 3], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![1, 2, 3], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> add_two_numbers/src/data.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return Some(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return Some(head); [INFO] [stdout] 24 + Some(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking asteroid_collision v0.1.0 (/opt/rustwide/workdir/asteroid_collision) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![0,1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![0,1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | nums: vec![1], [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + nums: vec![1], [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> add_two_numbers/src/solution.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return head.next; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return head.next; [INFO] [stdout] 32 + head.next [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking longest_consecutive_sequence v0.1.0 (/opt/rustwide/workdir/longest_consecutive_sequence) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> edit_distance/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | word1: "horse".to_string(), [INFO] [stdout] 9 | | word2: "ros".to_string(), [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + word1: "horse".to_string(), [INFO] [stdout] 9 + word2: "ros".to_string(), [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> permutations/src/solution.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn dfs(nums: &Vec, pre: &mut Vec, post: Vec, perms: &mut HashSet>) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_nums` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> permutations/src/solution.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | dfs(nums, pre, new_post, perms); [INFO] [stdout] | ^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations/src/solution.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return ret_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return ret_value; [INFO] [stdout] 20 + ret_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking palindrome_permutation v0.1.0 (/opt/rustwide/workdir/palindrome_permutation) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutation_in_string/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | s1: "ab".to_string(), [INFO] [stdout] 9 | | s2: "eidbaooo".to_string(), [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + s1: "ab".to_string(), [INFO] [stdout] 9 + s2: "eidbaooo".to_string(), [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutation_in_string/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | s1: "ab".to_string(), [INFO] [stdout] 16 | | s2: "eidboaoo".to_string(), [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + s1: "ab".to_string(), [INFO] [stdout] 16 + s2: "eidboaoo".to_string(), [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutation_in_string/src/solution.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return false; [INFO] [stdout] 43 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> permutation_in_string/src/solution.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `s2_chars` [INFO] [stdout] --> permutation_in_string/src/solution.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 18 | for x in 0..s1_chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 18 - for x in 0..s1_chars.len() { [INFO] [stdout] 18 + for in s2_chars.iter().take(s1_chars.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> permutation_in_string/src/solution.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 22 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> edit_distance/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | word1: "intention".to_string(), [INFO] [stdout] 16 | | word2: "execution".to_string(), [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + word1: "intention".to_string(), [INFO] [stdout] 16 + word2: "execution".to_string(), [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> kth_largest_element_in_an_array/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![3, 2, 1, 5, 6, 4], [INFO] [stdout] 9 | | k: 2, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![3, 2, 1, 5, 6, 4], [INFO] [stdout] 9 + k: 2, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> edit_distance/src/solution.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return matrix[0][0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return matrix[0][0]; [INFO] [stdout] 34 + matrix[0][0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> kth_largest_element_in_an_array/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![3, 2, 3, 1, 2, 4, 5, 5, 6], [INFO] [stdout] 16 | | k: 4, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![3, 2, 3, 1, 2, 4, 5, 5, 6], [INFO] [stdout] 16 + k: 4, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `left` is used as a loop counter [INFO] [stdout] --> permutation_in_string/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | for right in s1_chars.len()..s2_chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (left, right) in (s1_chars.len()..s2_chars.len()).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> permutation_in_string/src/solution.rs:30:53 [INFO] [stdout] | [INFO] [stdout] 30 | s2_map.entry(s2_chars[left]).and_modify(|m| *m = *m - 1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> permutation_in_string/src/solution.rs:37:29 [INFO] [stdout] | [INFO] [stdout] 37 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking product_of_array_except_self v0.1.0 (/opt/rustwide/workdir/product_of_array_except_self) [INFO] [stderr] Checking word_ladder v0.1.0 (/opt/rustwide/workdir/word_ladder) [INFO] [stderr] Checking reverse_integer v0.1.0 (/opt/rustwide/workdir/reverse_integer) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> fizz_buzz/src/solution.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return res; [INFO] [stdout] 15 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> palindrome_permutation/src/solution.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if !(value % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(value % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindrome_permutation/src/solution.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return odd_count_chars <= 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return odd_count_chars <= 1; [INFO] [stdout] 17 + odd_count_chars <= 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> palindrome_permutation/src/solution.rs:8:42 [INFO] [stdout] | [INFO] [stdout] 8 | map.entry(letter).and_modify(|m| *m = *m + 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> palindrome_permutation/src/solution.rs:12:29 [INFO] [stdout] | [INFO] [stdout] 12 | let value = map.get(&key).unwrap(); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_consecutive_sequence/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![100, 4, 200, 1, 3, 2], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![100, 4, 200, 1, 3, 2], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking word_search v0.1.0 (/opt/rustwide/workdir/word_search) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_consecutive_sequence/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![0, 3, 7, 2, 5, 8, 4, 6, 0, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![0, 3, 7, 2, 5, 8, 4, 6, 0, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_consecutive_sequence/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | nums: vec![1, 0, 1, 2], [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + nums: vec![1, 0, 1, 2], [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_consecutive_sequence/src/solution.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return max_length; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return max_length; [INFO] [stdout] 17 + max_length [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> longest_consecutive_sequence/src/solution.rs:13:51 [INFO] [stdout] | [INFO] [stdout] 13 | max_length = cmp::max(max_length, length as i32); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking binary_tree_right_side_view v0.1.0 (/opt/rustwide/workdir/binary_tree_right_side_view) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_subarray/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![-2, 1, -3, 4, -1, 2, 1, -5, 4], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![-2, 1, -3, 4, -1, 2, 1, -5, 4], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_subarray/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return Data { nums: vec![1] }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return Data { nums: vec![1] }; [INFO] [stdout] 12 + Data { nums: vec![1] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_subarray/src/data.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / return Data { [INFO] [stdout] 17 | | nums: vec![5, 4, -1, 7, 8], [INFO] [stdout] 18 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ Data { [INFO] [stdout] 17 + nums: vec![5, 4, -1, 7, 8], [INFO] [stdout] 18 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking longest_substring_without_repeating_characters v0.1.0 (/opt/rustwide/workdir/longest_substring_without_repeating_characters) [INFO] [stderr] Checking palindrome_number v0.1.0 (/opt/rustwide/workdir/palindrome_number) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_subarray/src/solution.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return max_sum; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return max_sum; [INFO] [stdout] 14 + max_sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking top_k_frequent_elements v0.1.0 (/opt/rustwide/workdir/top_k_frequent_elements) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return -1; [INFO] [stdout] 20 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:10:45 [INFO] [stdout] | [INFO] [stdout] 10 | let right_res = binary_search_right(&nums, mid + 1, right, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> product_of_array_except_self/src/solution.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return nums; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return nums; [INFO] [stdout] 27 + nums [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:15:44 [INFO] [stdout] | [INFO] [stdout] 15 | let left_res = binary_search_right(&nums, left, mid, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return -1; [INFO] [stdout] 42 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:32:44 [INFO] [stdout] | [INFO] [stdout] 32 | let left_left = binary_search_left(&nums, left, mid, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:37:45 [INFO] [stdout] | [INFO] [stdout] 37 | let left_right = binary_search_left(&nums, mid + 1, right, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return [left, right].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return [left, right].to_vec(); [INFO] [stdout] 53 + [left, right].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `nums` [INFO] [stdout] --> product_of_array_except_self/src/solution.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | for x in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 7 - for x in 0..nums.len() { [INFO] [stdout] 7 + for in &nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `nums` [INFO] [stdout] --> product_of_array_except_self/src/solution.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 17 | for x in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 17 - for x in 0..nums.len() { [INFO] [stdout] 17 + for in &mut nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> asteroid_collision/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | asteroids: vec![5, 10, -5], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + asteroids: vec![5, 10, -5], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> asteroid_collision/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | asteroids: vec![8, -8], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + asteroids: vec![8, -8], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> asteroid_collision/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | asteroids: vec![10, 2, -5], [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + asteroids: vec![10, 2, -5], [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> asteroid_collision/src/solution.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return asteroids; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return asteroids; [INFO] [stdout] 27 + asteroids [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> asteroid_collision/src/solution.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | if crashed == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!crashed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking word_break v0.1.0 (/opt/rustwide/workdir/word_break) [INFO] [stderr] Checking spiral_matrix v0.1.0 (/opt/rustwide/workdir/spiral_matrix) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_ladder/src/data.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / return Data { [INFO] [stdout] 9 | | begin_word: "hit".to_string(), [INFO] [stdout] 10 | | end_word: "cog".to_string(), [INFO] [stdout] 11 | | word_list: vec![ [INFO] [stdout] ... | [INFO] [stdout] 18 | | ], [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 ~ Data { [INFO] [stdout] 9 + begin_word: "hit".to_string(), [INFO] [stdout] 10 + end_word: "cog".to_string(), [INFO] [stdout] 11 + word_list: vec![ [INFO] [stdout] 12 + "hot".to_string(), [INFO] [stdout] 13 + "dot".to_string(), [INFO] [stdout] 14 + "dog".to_string(), [INFO] [stdout] 15 + "lot".to_string(), [INFO] [stdout] 16 + "log".to_string(), [INFO] [stdout] 17 + "cog".to_string(), [INFO] [stdout] 18 + ], [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_ladder/src/data.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return Data { [INFO] [stdout] 24 | | begin_word: "hit".to_string(), [INFO] [stdout] 25 | | end_word: "cog".to_string(), [INFO] [stdout] 26 | | word_list: vec![ [INFO] [stdout] ... | [INFO] [stdout] 32 | | ], [INFO] [stdout] 33 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ Data { [INFO] [stdout] 24 + begin_word: "hit".to_string(), [INFO] [stdout] 25 + end_word: "cog".to_string(), [INFO] [stdout] 26 + word_list: vec![ [INFO] [stdout] 27 + "hot".to_string(), [INFO] [stdout] 28 + "dot".to_string(), [INFO] [stdout] 29 + "dog".to_string(), [INFO] [stdout] 30 + "lot".to_string(), [INFO] [stdout] 31 + "log".to_string(), [INFO] [stdout] 32 + ], [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_ladder/src/solution.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return 0; [INFO] [stdout] 47 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(neighbor).is_some()` [INFO] [stdout] --> word_ladder/src/solution.rs:37:32 [INFO] [stdout] | [INFO] [stdout] 37 | if visited.get(neighbor).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains(neighbor)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_in_rotated_sorted_array/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return -1; [INFO] [stdout] 16 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_in_rotated_sorted_array/src/solution.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return cmp::max(res_left, res_right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return cmp::max(res_left, res_right); [INFO] [stdout] 32 + cmp::max(res_left, res_right) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking find_the_duplicate_number v0.1.0 (/opt/rustwide/workdir/find_the_duplicate_number) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_product_subarray/src/solution.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return res; [INFO] [stdout] 19 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `nums` [INFO] [stdout] --> maximum_product_subarray/src/solution.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | for x in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 7 - for x in 0..nums.len() { [INFO] [stdout] 7 + for in &nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> binary_tree_right_side_view/src/data.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking binary_tree_level_order_traversal v0.1.0 (/opt/rustwide/workdir/binary_tree_level_order_traversal) [INFO] [stderr] Checking jump_game v0.1.0 (/opt/rustwide/workdir/jump_game) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> binary_tree_level_order_traversal/src/data.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 63 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> reverse_integer/src/solution.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return output_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return output_num; [INFO] [stdout] 23 + output_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> reverse_integer/src/solution.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | current = current / 10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current /= 10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> binary_tree_level_order_traversal/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return result; [INFO] [stdout] 29 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking min_cost_climbing_stairs v0.1.0 (/opt/rustwide/workdir/min_cost_climbing_stairs) [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> reverse_integer/src/solution.rs:21:52 [INFO] [stdout] | [INFO] [stdout] 21 | ten_p = if ten_p != 0 { ten_p - 1 } else { 0 as u32 }; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | board: vec![ [INFO] [stdout] 9 | | vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 10 | | vec!['S', 'F', 'C', 'S'], [INFO] [stdout] ... | [INFO] [stdout] 13 | | word: "ABCCED".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + board: vec![ [INFO] [stdout] 9 + vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 10 + vec!['S', 'F', 'C', 'S'], [INFO] [stdout] 11 + vec!['A', 'D', 'E', 'E'], [INFO] [stdout] 12 + ], [INFO] [stdout] 13 + word: "ABCCED".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | board: vec![ [INFO] [stdout] 20 | | vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 21 | | vec!['S', 'F', 'C', 'S'], [INFO] [stdout] ... | [INFO] [stdout] 24 | | word: "SEE".to_string(), [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + board: vec![ [INFO] [stdout] 20 + vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 21 + vec!['S', 'F', 'C', 'S'], [INFO] [stdout] 22 + vec!['A', 'D', 'E', 'E'], [INFO] [stdout] 23 + ], [INFO] [stdout] 24 + word: "SEE".to_string(), [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking valid_anagram v0.1.0 (/opt/rustwide/workdir/valid_anagram) [INFO] [stderr] Checking flatten_binary_tree_to_linked_list v0.1.0 (/opt/rustwide/workdir/flatten_binary_tree_to_linked_list) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/data.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / return Data { [INFO] [stdout] 30 | | board: vec![ [INFO] [stdout] 31 | | vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 32 | | vec!['S', 'F', 'C', 'S'], [INFO] [stdout] ... | [INFO] [stdout] 35 | | word: "ABCB".to_string(), [INFO] [stdout] 36 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Data { [INFO] [stdout] 30 + board: vec![ [INFO] [stdout] 31 + vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 32 + vec!['S', 'F', 'C', 'S'], [INFO] [stdout] 33 + vec!['A', 'D', 'E', 'E'], [INFO] [stdout] 34 + ], [INFO] [stdout] 35 + word: "ABCB".to_string(), [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/solution.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return right || down || left || up; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return right || down || left || up; [INFO] [stdout] 49 + right || down || left || up [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/solution.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return false; [INFO] [stdout] 65 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rotate_array v0.1.0 (/opt/rustwide/workdir/rotate_array) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_substring_without_repeating_characters/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | s: "abcabcbb".to_string(), [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + s: "abcabcbb".to_string(), [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_substring_without_repeating_characters/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | s: "bbbbb".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + s: "bbbbb".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_substring_without_repeating_characters/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | s: "pwwkew".to_string(), [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + s: "pwwkew".to_string(), [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_the_duplicate_number/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![1, 3, 4, 2, 2], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![1, 3, 4, 2, 2], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_the_duplicate_number/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![3, 1, 3, 4, 2], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![3, 1, 3, 4, 2], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `chars` [INFO] [stdout] --> longest_substring_without_repeating_characters/src/solution.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | for j in i + 1..str_len { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 16 - for j in i + 1..str_len { [INFO] [stdout] 16 + for (j, ) in chars.iter().enumerate().take(str_len).skip(i + 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&chars[j]).is_some()` [INFO] [stdout] --> longest_substring_without_repeating_characters/src/solution.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 17 | if char_set.get(&chars[j]).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains(&chars[j])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_the_duplicate_number/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | nums: vec![3, 3, 3, 3, 3], [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + nums: vec![3, 3, 3, 3, 3], [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindrome_number/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return true; [INFO] [stdout] 16 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> palindrome_number/src/solution.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if &x_str_chars[left] != &x_str_chars[right] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 10 - if &x_str_chars[left] != &x_str_chars[right] { [INFO] [stdout] 10 + if x_str_chars[left] != x_str_chars[right] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> palindrome_number/src/solution.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | left = left + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `left += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> palindrome_number/src/solution.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | right = right - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `right -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking reverse_string v0.1.0 (/opt/rustwide/workdir/reverse_string) [INFO] [stderr] Checking binary_tree_zigzag_level_order_traversal v0.1.0 (/opt/rustwide/workdir/binary_tree_zigzag_level_order_traversal) [INFO] [stderr] Checking task_scheduler v0.1.0 (/opt/rustwide/workdir/task_scheduler) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_cost_climbing_stairs/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | costs: vec![10, 15, 20], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + costs: vec![10, 15, 20], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> spiral_matrix/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | matrix: vec![vec![1, 2, 3], vec![4, 5, 6], vec![7, 8, 9]], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + matrix: vec![vec![1, 2, 3], vec![4, 5, 6], vec![7, 8, 9]], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> spiral_matrix/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | matrix: vec![vec![1, 2, 3, 4], vec![5, 6, 7, 8], vec![9, 10, 11, 12]], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + matrix: vec![vec![1, 2, 3, 4], vec![5, 6, 7, 8], vec![9, 10, 11, 12]], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> spiral_matrix/src/solution.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return output; [INFO] [stdout] 30 + output [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&(row, col)).is_some()` [INFO] [stdout] --> spiral_matrix/src/solution.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | if visited.get(&(row, col)).is_some() || row >= row_len || col >= col_len { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains(&(row, col))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_cost_climbing_stairs/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | costs: vec![1, 100, 1, 1, 1, 100, 1, 1, 100, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + costs: vec![1, 100, 1, 1, 1, 100, 1, 1, 100, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_cost_climbing_stairs/src/solution.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return cmp::min(costs[0], costs[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return cmp::min(costs[0], costs[1]); [INFO] [stdout] 10 + cmp::min(costs[0], costs[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking maximal_square v0.1.0 (/opt/rustwide/workdir/maximal_square) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> binary_tree_right_side_view/src/solution.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | if !root.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `root.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node_ref.left` after checking its variant with `is_some` [INFO] [stdout] --> binary_tree_right_side_view/src/solution.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 23 | if node_ref.left.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = &node_ref.left` [INFO] [stdout] 24 | let val = node_ref.left.as_ref().unwrap().borrow().val; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node_ref.right` after checking its variant with `is_some` [INFO] [stdout] --> binary_tree_right_side_view/src/solution.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 28 | if node_ref.right.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &node_ref.right` [INFO] [stdout] 29 | let val = node_ref.right.as_ref().unwrap().borrow().val; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> binary_tree_right_side_view/src/solution.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return res; [INFO] [stdout] 42 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_break/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | s: "leetcode".to_string(), [INFO] [stdout] 9 | | word_dict: vec!["leet".to_string(), "code".to_string()], [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + s: "leetcode".to_string(), [INFO] [stdout] 9 + word_dict: vec!["leet".to_string(), "code".to_string()], [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_break/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | s: "applepenapple".to_string(), [INFO] [stdout] 16 | | word_dict: vec!["apple".to_string(), "pen".to_string()], [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + s: "applepenapple".to_string(), [INFO] [stdout] 16 + word_dict: vec!["apple".to_string(), "pen".to_string()], [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_break/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | s: "catsandog".to_string(), [INFO] [stdout] 23 | | word_dict: vec![ [INFO] [stdout] 24 | | "cats".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 29 | | ], [INFO] [stdout] 30 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + s: "catsandog".to_string(), [INFO] [stdout] 23 + word_dict: vec![ [INFO] [stdout] 24 + "cats".to_string(), [INFO] [stdout] 25 + "dog".to_string(), [INFO] [stdout] 26 + "sand".to_string(), [INFO] [stdout] 27 + "and".to_string(), [INFO] [stdout] 28 + "cat".to_string(), [INFO] [stdout] 29 + ], [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_break/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return false; [INFO] [stdout] 29 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> rotate_array/src/solution.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn shift_by_one(nums: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn shift_by_one(nums: &mut Vec) { [INFO] [stdout] 1 + pub fn shift_by_one(nums: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `nums` [INFO] [stdout] --> rotate_array/src/solution.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | for x in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 3 - for x in 0..nums.len() { [INFO] [stdout] 3 + for in &mut nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping `nums[x]` and `prev` manually [INFO] [stdout] --> rotate_array/src/solution.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | / let tmp = nums[x]; [INFO] [stdout] 5 | | nums[x] = prev; [INFO] [stdout] 6 | | prev = tmp; [INFO] [stdout] | |___________________^ help: try: `std::mem::swap(&mut nums[x], &mut prev);` [INFO] [stdout] | [INFO] [stdout] = note: or maybe you should use `std::mem::replace`? [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking reverse_linked_list v0.1.0 (/opt/rustwide/workdir/reverse_linked_list) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![2, 3, 1, 1, 4], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![2, 3, 1, 1, 4], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![3, 2, 1, 0, 4], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![3, 2, 1, 0, 4], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> rotate_array/src/solution.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | k = k % nums.len() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k %= nums.len() as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_break/src/solution.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return dfs(&s_char, &mut vec![], &mut word_vecs, &mut visited); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return dfs(&s_char, &mut vec![], &mut word_vecs, &mut visited); [INFO] [stdout] 39 + dfs(&s_char, &mut vec![], &mut word_vecs, &mut visited) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game/src/solution.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return last_reachable == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return last_reachable == 0; [INFO] [stdout] 11 + last_reachable == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> top_k_frequent_elements/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![1, 1, 1, 2, 2, 3], [INFO] [stdout] 9 | | k: 2, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![1, 1, 1, 2, 2, 3], [INFO] [stdout] 9 + k: 2, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking remove_duplicates_from_sorted_list v0.1.0 (/opt/rustwide/workdir/remove_duplicates_from_sorted_list) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> top_k_frequent_elements/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![1], [INFO] [stdout] 16 | | k: 1, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![1], [INFO] [stdout] 16 + k: 1, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking lru_cache v0.1.0 (/opt/rustwide/workdir/lru_cache) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> flatten_binary_tree_to_linked_list/src/data.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking unique_paths v0.1.0 (/opt/rustwide/workdir/unique_paths) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> top_k_frequent_elements/src/solution.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return res; [INFO] [stdout] 19 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking merge_intervals v0.1.0 (/opt/rustwide/workdir/merge_intervals) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> remove_duplicates_from_sorted_list/src/data.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking find_all_anagrams_in_a_string v0.1.0 (/opt/rustwide/workdir/find_all_anagrams_in_a_string) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> remove_duplicates_from_sorted_list/src/data.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> task_scheduler/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | tasks: vec!['A', 'A', 'A', 'B', 'B', 'B'], [INFO] [stdout] 9 | | n: 2, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + tasks: vec!['A', 'A', 'A', 'B', 'B', 'B'], [INFO] [stdout] 9 + n: 2, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> task_scheduler/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | tasks: vec!['A', 'C', 'A', 'B', 'D', 'B'], [INFO] [stdout] 16 | | n: 1, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + tasks: vec!['A', 'C', 'A', 'B', 'D', 'B'], [INFO] [stdout] 16 + n: 1, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> task_scheduler/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | tasks: vec!['A', 'A', 'A', 'B', 'B', 'B'], [INFO] [stdout] 23 | | n: 3, [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + tasks: vec!['A', 'A', 'A', 'B', 'B', 'B'], [INFO] [stdout] 23 + n: 3, [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> task_scheduler/src/solution.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return time; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return time; [INFO] [stdout] 39 + time [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> task_scheduler/src/solution.rs:11:40 [INFO] [stdout] | [INFO] [stdout] 11 | map.entry(task).and_modify(|m| *m = *m + 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> task_scheduler/src/solution.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | / if task.1 == time { [INFO] [stdout] 30 | | let next_task = q.pop_front().unwrap().0; [INFO] [stdout] 31 | | heap.push(next_task); [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ Some(task) [INFO] [stdout] 29 ~ if task.1 == time => { [INFO] [stdout] 30 | let next_task = q.pop_front().unwrap().0; [INFO] [stdout] 31 | heap.push(next_task); [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> task_scheduler/src/solution.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | / match q.front() { [INFO] [stdout] 28 | | Some(task) => { [INFO] [stdout] 29 | | if task.1 == time { [INFO] [stdout] 30 | | let next_task = q.pop_front().unwrap().0; [INFO] [stdout] ... | [INFO] [stdout] 34 | | None => {} [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 ~ if let Some(task) = q.front() { [INFO] [stdout] 28 + if task.1 == time { [INFO] [stdout] 29 + let next_task = q.pop_front().unwrap().0; [INFO] [stdout] 30 + heap.push(next_task); [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> remove_duplicates_from_sorted_list/src/solution.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return head; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return head; [INFO] [stdout] 19 + head [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> lru_cache/src/solution.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | capacity: capacity, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> binary_tree_zigzag_level_order_traversal/src/data.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking house_robber v0.1.0 (/opt/rustwide/workdir/house_robber) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_paths/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | return Data { m: 3, n: 7 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return Data { m: 3, n: 7 }; [INFO] [stdout] 7 + Data { m: 3, n: 7 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_paths/src/data.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return Data { m: 3, n: 2 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return Data { m: 3, n: 2 }; [INFO] [stdout] 11 + Data { m: 3, n: 2 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking merge_sorted_array v0.1.0 (/opt/rustwide/workdir/merge_sorted_array) [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> unique_paths/src/solution.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 15 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 16 | path_count += left.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `above` after checking its variant with `is_some` [INFO] [stdout] --> unique_paths/src/solution.rs:19:31 [INFO] [stdout] | [INFO] [stdout] 18 | if above.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = above` [INFO] [stdout] 19 | path_count += above.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_paths/src/solution.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return *map.get(&(m - 1, n - 1)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return *map.get(&(m - 1, n - 1)).unwrap(); [INFO] [stdout] 24 + *map.get(&(m - 1, n - 1)).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_anagram/src/solution.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | return s_chars == t_chars; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return s_chars == t_chars; [INFO] [stdout] 6 + s_chars == t_chars [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking best_time_to_buy_and_sell_stock v0.1.0 (/opt/rustwide/workdir/best_time_to_buy_and_sell_stock) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> reverse_linked_list/src/data.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> merge_intervals/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | intervals: vec![vec![1, 3], vec![2, 6], vec![8, 10], vec![15, 18]], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + intervals: vec![vec![1, 3], vec![2, 6], vec![8, 10], vec![15, 18]], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sort_colors v0.1.0 (/opt/rustwide/workdir/sort_colors) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> merge_intervals/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | intervals: vec![vec![1, 4], vec![4, 5]], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + intervals: vec![vec![1, 4], vec![4, 5]], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> merge_intervals/src/solution.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return stack; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return stack; [INFO] [stdout] 24 + stack [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking longest_increasing_subsequence v0.1.0 (/opt/rustwide/workdir/longest_increasing_subsequence) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> merge_sorted_array/src/data.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / return Data { [INFO] [stdout] 10 | | nums1: vec![1, 2, 3, 0, 0, 0], [INFO] [stdout] 11 | | m: 3, [INFO] [stdout] 12 | | nums2: vec![2, 5, 6], [INFO] [stdout] 13 | | n: 3, [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 ~ Data { [INFO] [stdout] 10 + nums1: vec![1, 2, 3, 0, 0, 0], [INFO] [stdout] 11 + m: 3, [INFO] [stdout] 12 + nums2: vec![2, 5, 6], [INFO] [stdout] 13 + n: 3, [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> merge_sorted_array/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | nums1: vec![1], [INFO] [stdout] 20 | | m: 1, [INFO] [stdout] 21 | | nums2: vec![], [INFO] [stdout] 22 | | n: 0, [INFO] [stdout] 23 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + nums1: vec![1], [INFO] [stdout] 20 + m: 1, [INFO] [stdout] 21 + nums2: vec![], [INFO] [stdout] 22 + n: 0, [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> merge_sorted_array/src/data.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / return Data { [INFO] [stdout] 28 | | nums1: vec![0], [INFO] [stdout] 29 | | m: 0, [INFO] [stdout] 30 | | nums2: vec![1], [INFO] [stdout] 31 | | n: 1, [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 ~ Data { [INFO] [stdout] 28 + nums1: vec![0], [INFO] [stdout] 29 + m: 0, [INFO] [stdout] 30 + nums2: vec![1], [INFO] [stdout] 31 + n: 1, [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> merge_sorted_array/src/solution.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | nums2: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - nums2: &mut Vec, [INFO] [stdout] 6 + nums2: &mut [i32], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `nums1` [INFO] [stdout] --> merge_sorted_array/src/solution.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | for x in 0..m as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 10 - for x in 0..m as usize { [INFO] [stdout] 10 + for in nums1.iter().take(m as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> merge_sorted_array/src/solution.rs:11:44 [INFO] [stdout] | [INFO] [stdout] 11 | map.entry(nums1[x]).and_modify(|m| *m = *m + 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `nums2` [INFO] [stdout] --> merge_sorted_array/src/solution.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | for x in 0..n as usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 13 - for x in 0..n as usize { [INFO] [stdout] 13 + for in nums2.iter().take(n as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> merge_sorted_array/src/solution.rs:14:44 [INFO] [stdout] | [INFO] [stdout] 14 | map.entry(nums2[x]).and_modify(|m| *m = *m + 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::Keys<'_, i32, i32>` [INFO] [stdout] --> merge_sorted_array/src/solution.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | let mut keys: Vec<&i32> = map.keys().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `map.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `s` manually [INFO] [stdout] --> reverse_string/src/solution.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | / let tmp = s[l]; [INFO] [stdout] 6 | | s[l] = s[r]; [INFO] [stdout] 7 | | s[r] = tmp; [INFO] [stdout] | |___________________^ help: try: `s.swap(l, r);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lru_cache/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | commands: vec![ [INFO] [stdout] 9 | | "LRUCache".to_string(), [INFO] [stdout] 10 | | "put".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 31 | | ], [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + commands: vec![ [INFO] [stdout] 9 + "LRUCache".to_string(), [INFO] [stdout] 10 + "put".to_string(), [INFO] [stdout] 11 + "put".to_string(), [INFO] [stdout] 12 + "get".to_string(), [INFO] [stdout] 13 + "put".to_string(), [INFO] [stdout] 14 + "get".to_string(), [INFO] [stdout] 15 + "put".to_string(), [INFO] [stdout] 16 + "get".to_string(), [INFO] [stdout] 17 + "get".to_string(), [INFO] [stdout] 18 + "get".to_string(), [INFO] [stdout] 19 + ], [INFO] [stdout] 20 + values: vec![ [INFO] [stdout] 21 + vec![2], [INFO] [stdout] 22 + vec![1, 1], [INFO] [stdout] 23 + vec![2, 2], [INFO] [stdout] 24 + vec![1], [INFO] [stdout] 25 + vec![3, 3], [INFO] [stdout] 26 + vec![2], [INFO] [stdout] 27 + vec![4, 4], [INFO] [stdout] 28 + vec![1], [INFO] [stdout] 29 + vec![3], [INFO] [stdout] 30 + vec![4], [INFO] [stdout] 31 + ], [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> reverse_linked_list/src/solution.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return prev; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return prev; [INFO] [stdout] 12 + prev [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> binary_tree_zigzag_level_order_traversal/src/solution.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return result; [INFO] [stdout] 32 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_all_anagrams_in_a_string/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | s: "cbaebabacd".to_string(), [INFO] [stdout] 9 | | p: "abc".to_string(), [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + s: "cbaebabacd".to_string(), [INFO] [stdout] 9 + p: "abc".to_string(), [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_all_anagrams_in_a_string/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | s: "abab".to_string(), [INFO] [stdout] 16 | | p: "ab".to_string(), [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + s: "abab".to_string(), [INFO] [stdout] 16 + p: "ab".to_string(), [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking subarray_sum_equals_k v0.1.0 (/opt/rustwide/workdir/subarray_sum_equals_k) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return res; [INFO] [stdout] 43 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:14:29 [INFO] [stdout] | [INFO] [stdout] 14 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:28:33 [INFO] [stdout] | [INFO] [stdout] 28 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:33:29 [INFO] [stdout] | [INFO] [stdout] 33 | .and_modify(|m| *m = *m - 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> binary_tree_zigzag_level_order_traversal/src/solution.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if forward == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!forward` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking min_stack v0.1.0 (/opt/rustwide/workdir/min_stack) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lru_cache/src/solution.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / return Self { [INFO] [stdout] 14 | | capacity: capacity, [INFO] [stdout] 15 | | map: HashMap::with_capacity(capacity as usize), [INFO] [stdout] 16 | | q: VecDeque::new(), [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + capacity: capacity, [INFO] [stdout] 15 + map: HashMap::with_capacity(capacity as usize), [INFO] [stdout] 16 + q: VecDeque::new(), [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> sort_colors/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![2, 0, 2, 1, 1, 0], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![2, 0, 2, 1, 1, 0], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking string_to_integer_atoi v0.1.0 (/opt/rustwide/workdir/string_to_integer_atoi) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> sort_colors/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![2, 0, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![2, 0, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking design_tic_tac_toe v0.1.0 (/opt/rustwide/workdir/design_tic_tac_toe) [INFO] [stdout] warning: this looks like you are swapping elements of `nums` manually [INFO] [stdout] --> sort_colors/src/solution.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | / let tmp = nums[j - 1]; [INFO] [stdout] 6 | | nums[j - 1] = nums[j]; [INFO] [stdout] 7 | | nums[j] = tmp; [INFO] [stdout] | |______________________________^ help: try: `nums.swap(j - 1, j);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking plus_one v0.1.0 (/opt/rustwide/workdir/plus_one) [INFO] [stdout] warning: called `unwrap` on `index` after checking its variant with `is_some` [INFO] [stdout] --> lru_cache/src/solution.rs:24:31 [INFO] [stdout] | [INFO] [stdout] 23 | if index.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = index` [INFO] [stdout] 24 | self.q.remove(index.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking longest_common_prefix v0.1.0 (/opt/rustwide/workdir/longest_common_prefix) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lru_cache/src/solution.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return -1; [INFO] [stdout] 29 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking lowest_common_ancestor_of_a_binary_tree v0.1.0 (/opt/rustwide/workdir/lowest_common_ancestor_of_a_binary_tree) [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> lru_cache/src/solution.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if self.map.contains_key(&key) { [INFO] [stdout] 34 | | self.map.entry(key).and_modify(|m| *m = value); [INFO] [stdout] 35 | | let index: usize = self.q.iter().position(|x| x == &key).unwrap(); [INFO] [stdout] 36 | | self.q.remove(index); [INFO] [stdout] ... | [INFO] [stdout] 40 | | self.q.push_front(key); [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ if let std::collections::hash_map::Entry::Vacant(e) = self.map.entry(key) { [INFO] [stdout] 34 + e.insert(value); [INFO] [stdout] 35 + self.q.push_front(key); [INFO] [stdout] 36 + } else { [INFO] [stdout] 37 + self.map.entry(key).and_modify(|m| *m = value); [INFO] [stdout] 38 + let index: usize = self.q.iter().position(|x| x == &key).unwrap(); [INFO] [stdout] 39 + self.q.remove(index); [INFO] [stdout] 40 + self.q.push_front(key); [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sort_list v0.1.0 (/opt/rustwide/workdir/sort_list) [INFO] [stderr] Checking perfect_squares v0.1.0 (/opt/rustwide/workdir/perfect_squares) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subarray_sum_equals_k/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![1, 1, 1], [INFO] [stdout] 9 | | k: 2, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![1, 1, 1], [INFO] [stdout] 9 + k: 2, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subarray_sum_equals_k/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![1, 2, 3], [INFO] [stdout] 16 | | k: 3, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![1, 2, 3], [INFO] [stdout] 16 + k: 3, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subarray_sum_equals_k/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return total; [INFO] [stdout] 16 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> subarray_sum_equals_k/src/solution.rs:14:44 [INFO] [stdout] | [INFO] [stdout] 14 | map.entry(curr_sum).and_modify(|m| *m = *m + 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | matrix: vec![ [INFO] [stdout] 8 | | vec!['1', '0', '1', '0', '0'], [INFO] [stdout] 9 | | vec!['1', '0', '1', '1', '1'], [INFO] [stdout] ... | [INFO] [stdout] 12 | | ], [INFO] [stdout] 13 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + matrix: vec![ [INFO] [stdout] 8 + vec!['1', '0', '1', '0', '0'], [INFO] [stdout] 9 + vec!['1', '0', '1', '1', '1'], [INFO] [stdout] 10 + vec!['1', '1', '1', '1', '1'], [INFO] [stdout] 11 + vec!['1', '0', '0', '1', '0'], [INFO] [stdout] 12 + ], [INFO] [stdout] 13 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/data.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return Data { [INFO] [stdout] 18 | | matrix: vec![vec!['0', '1'], vec!['1', '0']], [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Data { [INFO] [stdout] 18 + matrix: vec![vec!['0', '1'], vec!['1', '0']], [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/data.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return Data { [INFO] [stdout] 24 | | matrix: vec![vec!['0']], [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ Data { [INFO] [stdout] 24 + matrix: vec![vec!['0']], [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return cache_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return cache_value; [INFO] [stdout] 29 + cache_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking three_sum_closest v0.1.0 (/opt/rustwide/workdir/three_sum_closest) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> perfect_squares/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | return Data { n: 12 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return Data { n: 12 }; [INFO] [stdout] 6 + Data { n: 12 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> perfect_squares/src/data.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return Data { n: 13 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return Data { n: 13 }; [INFO] [stdout] 10 + Data { n: 13 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/solution.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return max_square[0] * max_square[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return max_square[0] * max_square[0]; [INFO] [stdout] 37 + max_square[0] * max_square[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> sort_list/src/data.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> perfect_squares/src/solution.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | target: i32, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_target` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> perfect_squares/src/solution.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | target, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> perfect_squares/src/solution.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return min_use_count[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return min_use_count[0]; [INFO] [stdout] 48 + min_use_count[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> design_tic_tac_toe/src/solution.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | board: board, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_increasing_subsequence/src/solution.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return max_val; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return max_val; [INFO] [stdout] 15 + max_val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> best_time_to_buy_and_sell_stock/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | prices: vec![7, 1, 5, 3, 6, 4], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + prices: vec![7, 1, 5, 3, 6, 4], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> best_time_to_buy_and_sell_stock/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | prices: vec![7, 6, 4, 3, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + prices: vec![7, 6, 4, 3, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> best_time_to_buy_and_sell_stock/src/solution.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return profit; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return profit; [INFO] [stdout] 10 + profit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `prices` [INFO] [stdout] --> best_time_to_buy_and_sell_stock/src/solution.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | for i in 0..prices.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 6 - for i in 0..prices.len() { [INFO] [stdout] 6 + for in &prices { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking search_a_2d_matrix_ii v0.1.0 (/opt/rustwide/workdir/search_a_2d_matrix_ii) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> house_robber/src/solution.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return nums[nums.len() - 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return nums[nums.len() - 1]; [INFO] [stdout] 10 + nums[nums.len() - 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking subsets v0.1.0 (/opt/rustwide/workdir/subsets) [INFO] [stderr] Checking valid_parentheses v0.1.0 (/opt/rustwide/workdir/valid_parentheses) [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> longest_common_prefix/src/solution.rs:2:52 [INFO] [stdout] | [INFO] [stdout] 2 | let (mut longest, mut index) = (String::new(), 0 as usize); [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> sort_list/src/solution.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return head_ptr; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return head_ptr; [INFO] [stdout] 18 + head_ptr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> sort_list/src/solution.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let mut this_node = node_stack.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 13 ~ while let Some(mut this_node) = node_stack.pop() { [INFO] [stdout] 14 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `str_vecs` [INFO] [stdout] --> longest_common_prefix/src/solution.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | for x in 0..str_vecs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 13 - for x in 0..str_vecs.len() { [INFO] [stdout] 13 + for in &str_vecs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character converted to string [INFO] [stdout] --> longest_common_prefix/src/solution.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | longest.push_str(¤t_letter.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` without `to_string()`: `longest.push(current_letter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> plus_one/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | digits: vec![1, 2, 3], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + digits: vec![1, 2, 3], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> plus_one/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | digits: vec![4, 3, 2, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + digits: vec![4, 3, 2, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> plus_one/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return Data { digits: vec![9] }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Data { digits: vec![9] }; [INFO] [stdout] 18 + Data { digits: vec![9] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> plus_one/src/solution.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return res.iter().rev().map(|m| *m).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return res.iter().rev().map(|m| *m).collect(); [INFO] [stdout] 18 + res.iter().rev().map(|m| *m).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking jump_game_ii v0.1.0 (/opt/rustwide/workdir/jump_game_ii) [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> plus_one/src/solution.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | return res.iter().rev().map(|m| *m).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.iter().rev().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking divide_two_integers v0.1.0 (/opt/rustwide/workdir/divide_two_integers) [INFO] [stderr] Checking search_insert_position v0.1.0 (/opt/rustwide/workdir/search_insert_position) [INFO] [stderr] Checking next_permutation v0.1.0 (/opt/rustwide/workdir/next_permutation) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lowest_common_ancestor_of_a_binary_tree/src/solution.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | if l.is_some() { return l } else { return r } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - if l.is_some() { return l } else { return r } [INFO] [stdout] 31 + if l.is_some() { l } else { return r } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lowest_common_ancestor_of_a_binary_tree/src/solution.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 31 | if l.is_some() { return l } else { return r } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - if l.is_some() { return l } else { return r } [INFO] [stdout] 31 + if l.is_some() { return l } else { r } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> lowest_common_ancestor_of_a_binary_tree/src/solution.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / if root.is_none() { [INFO] [stdout] 10 | | return None; [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ help: replace it with: `root.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rotate_image v0.1.0 (/opt/rustwide/workdir/rotate_image) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subsets/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![1, 2, 3], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![1, 2, 3], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subsets/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return Data { nums: vec![0] }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return Data { nums: vec![0] }; [INFO] [stdout] 12 + Data { nums: vec![0] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> subsets/src/solution.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | avail_path: &Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - avail_path: &Vec, [INFO] [stdout] 6 + avail_path: &[i32], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subsets/src/solution.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return paths.iter().map(|m| m.to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return paths.iter().map(|m| m.to_vec()).collect(); [INFO] [stdout] 20 + paths.iter().map(|m| m.to_vec()).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> valid_parentheses/src/solution.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 11 | stack.push(curr_char.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `curr_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> design_tic_tac_toe/src/data.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / return Data { [INFO] [stdout] 9 | | commands: vec![ [INFO] [stdout] 10 | | "TicTacToe".to_string(), [INFO] [stdout] 11 | | "move".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 28 | | ], [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 ~ Data { [INFO] [stdout] 9 + commands: vec![ [INFO] [stdout] 10 + "TicTacToe".to_string(), [INFO] [stdout] 11 + "move".to_string(), [INFO] [stdout] 12 + "move".to_string(), [INFO] [stdout] 13 + "move".to_string(), [INFO] [stdout] 14 + "move".to_string(), [INFO] [stdout] 15 + "move".to_string(), [INFO] [stdout] 16 + "move".to_string(), [INFO] [stdout] 17 + "move".to_string(), [INFO] [stdout] 18 + ], [INFO] [stdout] 19 + values: vec![ [INFO] [stdout] 20 + vec![3], [INFO] [stdout] 21 + vec![0, 0, 1], [INFO] [stdout] 22 + vec![0, 2, 2], [INFO] [stdout] 23 + vec![2, 2, 1], [INFO] [stdout] 24 + vec![1, 1, 2], [INFO] [stdout] 25 + vec![2, 0, 1], [INFO] [stdout] 26 + vec![1, 0, 2], [INFO] [stdout] 27 + vec![2, 1, 1], [INFO] [stdout] 28 + ], [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_stack/src/data.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / return Data { [INFO] [stdout] 9 | | commands: vec![ [INFO] [stdout] 10 | | "MinStack".to_string(), [INFO] [stdout] 11 | | "push".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 28 | | ], [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 ~ Data { [INFO] [stdout] 9 + commands: vec![ [INFO] [stdout] 10 + "MinStack".to_string(), [INFO] [stdout] 11 + "push".to_string(), [INFO] [stdout] 12 + "push".to_string(), [INFO] [stdout] 13 + "push".to_string(), [INFO] [stdout] 14 + "getMin".to_string(), [INFO] [stdout] 15 + "pop".to_string(), [INFO] [stdout] 16 + "top".to_string(), [INFO] [stdout] 17 + "getMin".to_string(), [INFO] [stdout] 18 + ], [INFO] [stdout] 19 + values: vec![ [INFO] [stdout] 20 + vec![], [INFO] [stdout] 21 + vec![-2], [INFO] [stdout] 22 + vec![0], [INFO] [stdout] 23 + vec![-3], [INFO] [stdout] 24 + vec![], [INFO] [stdout] 25 + vec![], [INFO] [stdout] 26 + vec![], [INFO] [stdout] 27 + vec![], [INFO] [stdout] 28 + ], [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking longest_palindromic_substring v0.1.0 (/opt/rustwide/workdir/longest_palindromic_substring) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MinStack` [INFO] [stdout] --> min_stack/src/solution.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / pub fn new() -> Self { [INFO] [stdout] 10 | | return Self { stack: Vec::new() }; [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 8 + impl Default for MinStack { [INFO] [stdout] 9 + fn default() -> Self { [INFO] [stdout] 10 + Self::new() [INFO] [stdout] 11 + } [INFO] [stdout] 12 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking diameter_of_binary_tree v0.1.0 (/opt/rustwide/workdir/diameter_of_binary_tree) [INFO] [stderr] Checking path_sum_iii v0.1.0 (/opt/rustwide/workdir/path_sum_iii) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> design_tic_tac_toe/src/solution.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | / return Self { [INFO] [stdout] 12 | | board: board, [INFO] [stdout] 13 | | board_size: n as usize, [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ Self { [INFO] [stdout] 12 + board: board, [INFO] [stdout] 13 + board_size: n as usize, [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> design_tic_tac_toe/src/solution.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return true; [INFO] [stdout] 22 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> design_tic_tac_toe/src/solution.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return true; [INFO] [stdout] 30 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_insert_position/src/solution.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return -1; [INFO] [stdout] 39 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> search_insert_position/src/solution.rs:23:36 [INFO] [stdout] | [INFO] [stdout] 23 | let result = binary_search(&nums, left, mid, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> search_insert_position/src/solution.rs:30:36 [INFO] [stdout] | [INFO] [stdout] 30 | let result = binary_search(&nums, mid + 1, right, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_insert_position/src/solution.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return result; [INFO] [stdout] 44 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_stack/src/solution.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | return Self { stack: Vec::new() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return Self { stack: Vec::new() }; [INFO] [stdout] 10 + Self { stack: Vec::new() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_stack/src/solution.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return self.stack.last().unwrap().0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return self.stack.last().unwrap().0; [INFO] [stdout] 27 + self.stack.last().unwrap().0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_stack/src/solution.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return self.stack.last().unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return self.stack.last().unwrap().1; [INFO] [stdout] 31 + self.stack.last().unwrap().1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> three_sum_closest/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![-1, 2, 1, -4], [INFO] [stdout] 9 | | target: 1, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![-1, 2, 1, -4], [INFO] [stdout] 9 + target: 1, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking palindromic_substrings v0.1.0 (/opt/rustwide/workdir/palindromic_substrings) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> three_sum_closest/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![0, 0, 0], [INFO] [stdout] 16 | | target: 1, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![0, 0, 0], [INFO] [stdout] 16 + target: 1, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> three_sum_closest/src/solution.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return closest_target; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return closest_target; [INFO] [stdout] 36 + closest_target [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> string_to_integer_atoi/src/solution.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return output_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return output_num; [INFO] [stdout] 42 + output_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> string_to_integer_atoi/src/solution.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | if !str_chars[index_start].is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_chars[index_start].is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `str_chars` [INFO] [stdout] --> string_to_integer_atoi/src/solution.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | for x in index_start..str_chars_len { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 26 - for x in index_start..str_chars_len { [INFO] [stdout] 26 + for in str_chars.iter().take(str_chars_len).skip(index_start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> string_to_integer_atoi/src/solution.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | if !(str_chars[x].is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_chars[x].is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> design_tic_tac_toe/src/solution.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return true; [INFO] [stdout] 38 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> design_tic_tac_toe/src/solution.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return true; [INFO] [stdout] 46 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> design_tic_tac_toe/src/solution.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return 0; [INFO] [stdout] 61 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game_ii/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![2, 3, 1, 1, 4], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![2, 3, 1, 1, 4], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game_ii/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![2, 3, 0, 1, 4], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![2, 3, 0, 1, 4], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game_ii/src/solution.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return res; [INFO] [stdout] 17 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `nums` [INFO] [stdout] --> jump_game_ii/src/solution.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | for i in l..(r + 1) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 10 - for i in l..(r + 1) { [INFO] [stdout] 10 + for (i, ) in nums.iter().enumerate().take((r + 1)).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking generate_parentheses v0.1.0 (/opt/rustwide/workdir/generate_parentheses) [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> jump_game_ii/src/solution.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | res = res + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `res += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> min_stack/src/bin/execute.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | let res = obj.push(input[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 18 ~ obj.push(input[0]); [INFO] [stdout] 19 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> min_stack/src/bin/execute.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | let res = obj.push(input[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 24 ~ obj.push(input[0]); [INFO] [stdout] 25 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> min_stack/src/bin/execute.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | let res = obj.push(input[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 30 ~ obj.push(input[0]); [INFO] [stdout] 31 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> min_stack/src/bin/execute.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | let res = obj.pop(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 42 ~ obj.pop(); [INFO] [stdout] 43 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_a_2d_matrix_ii/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | matrix: vec![ [INFO] [stdout] 9 | | vec![1, 4, 7, 11, 15], [INFO] [stdout] 10 | | vec![2, 5, 8, 12, 19], [INFO] [stdout] ... | [INFO] [stdout] 15 | | target: 5, [INFO] [stdout] 16 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + matrix: vec![ [INFO] [stdout] 9 + vec![1, 4, 7, 11, 15], [INFO] [stdout] 10 + vec![2, 5, 8, 12, 19], [INFO] [stdout] 11 + vec![3, 6, 9, 16, 22], [INFO] [stdout] 12 + vec![10, 13, 14, 17, 24], [INFO] [stdout] 13 + vec![18, 21, 23, 26, 30], [INFO] [stdout] 14 + ], [INFO] [stdout] 15 + target: 5, [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_palindromic_substring/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | s: "babad".to_string(), [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + s: "babad".to_string(), [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> next_permutation/src/solution.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return nums; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return nums; [INFO] [stdout] 25 + nums [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_palindromic_substring/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | s: "cbbd".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + s: "cbbd".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_palindromic_substring/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return longest_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return longest_str; [INFO] [stdout] 29 + longest_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `nums` manually [INFO] [stdout] --> next_permutation/src/solution.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / let tmp = nums[swap]; [INFO] [stdout] 21 | | nums[swap] = nums[pivot]; [INFO] [stdout] 22 | | nums[pivot] = tmp; [INFO] [stdout] | |______________________^ help: try: `nums.swap(swap, pivot);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_a_2d_matrix_ii/src/data.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / return Data { [INFO] [stdout] 21 | | matrix: vec![ [INFO] [stdout] 22 | | vec![1, 4, 7, 11, 15], [INFO] [stdout] 23 | | vec![2, 5, 8, 12, 19], [INFO] [stdout] ... | [INFO] [stdout] 28 | | target: 20, [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 ~ Data { [INFO] [stdout] 21 + matrix: vec![ [INFO] [stdout] 22 + vec![1, 4, 7, 11, 15], [INFO] [stdout] 23 + vec![2, 5, 8, 12, 19], [INFO] [stdout] 24 + vec![3, 6, 9, 16, 22], [INFO] [stdout] 25 + vec![10, 13, 14, 17, 24], [INFO] [stdout] 26 + vec![18, 21, 23, 26, 30], [INFO] [stdout] 27 + ], [INFO] [stdout] 28 + target: 20, [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_a_2d_matrix_ii/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return false; [INFO] [stdout] 29 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_a_2d_matrix_ii/src/solution.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return res; [INFO] [stdout] 34 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this binary expression can be simplified [INFO] [stdout] --> longest_palindromic_substring/src/solution.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | if left == right || left > right { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `left >= right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stdout] = note: `#[warn(clippy::double_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> longest_palindromic_substring/src/solution.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | x = x + 1 [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> longest_palindromic_substring/src/solution.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | window_size = window_size - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_size -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> divide_two_integers/src/solution.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | if sign { [INFO] [stdout] | _________________^ [INFO] [stdout] 34 | | return dividend_i32 >> log2_32; [INFO] [stdout] 35 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> divide_two_integers/src/solution.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | } else { [INFO] [stdout] | ________________^ [INFO] [stdout] 36 | | return dividend_i32 >> log2_32; [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rotate_image/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | matrix: vec![vec![1, 2, 3], vec![4, 5, 6], vec![7, 8, 9]], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + matrix: vec![vec![1, 2, 3], vec![4, 5, 6], vec![7, 8, 9]], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rotate_image/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | matrix: vec![ [INFO] [stdout] 14 | | vec![5, 1, 9, 11], [INFO] [stdout] 15 | | vec![2, 4, 8, 10], [INFO] [stdout] ... | [INFO] [stdout] 18 | | ], [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + matrix: vec![ [INFO] [stdout] 14 + vec![5, 1, 9, 11], [INFO] [stdout] 15 + vec![2, 4, 8, 10], [INFO] [stdout] 16 + vec![13, 3, 6, 7], [INFO] [stdout] 17 + vec![15, 14, 12, 16], [INFO] [stdout] 18 + ], [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> rotate_image/src/solution.rs:9:23 [INFO] [stdout] | [INFO] [stdout] 9 | let lu = (0 + layer, increment + layer); [INFO] [stdout] | ^^^^^^^^^ help: consider reducing it to: `layer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> rotate_image/src/solution.rs:15:61 [INFO] [stdout] | [INFO] [stdout] 15 | let ld = (matrix_end_index - layer - increment, 0 + layer); [INFO] [stdout] | ^^^^^^^^^ help: consider reducing it to: `layer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindromic_substrings/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | s: "abc".to_string(), [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + s: "abc".to_string(), [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindromic_substrings/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | s: "aaa".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + s: "aaa".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindromic_substrings/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return count; [INFO] [stdout] 21 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> palindromic_substrings/src/solution.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | let mut r = l as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> palindromic_substrings/src/solution.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | let mut r = l as i32 + 1; [INFO] [stdout] | ^^^^^^^^ help: try: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_mut` does nothing [INFO] [stdout] --> generate_parentheses/src/solution.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | output_vec.as_mut(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `output_vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_mut` does nothing [INFO] [stdout] --> generate_parentheses/src/solution.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | output_vec.as_mut(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `output_vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> generate_parentheses/src/solution.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return output_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return output_vec; [INFO] [stdout] 36 + output_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> path_sum_iii/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / match current.checked_add(root_ref.val) { [INFO] [stdout] 17 | | None => return, [INFO] [stdout] 18 | | _ => {} [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ help: try: `if current.checked_add(root_ref.val) == None { return }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> path_sum_iii/src/solution.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return total_count[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return total_count[0]; [INFO] [stdout] 51 + total_count[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> diameter_of_binary_tree/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return 1 + cmp::max(left, right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return 1 + cmp::max(left, right); [INFO] [stdout] 16 + 1 + cmp::max(left, right) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> diameter_of_binary_tree/src/solution.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return max_width[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return max_width[0]; [INFO] [stdout] 22 + max_width[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> min_stack/src/bin/execute.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | let res = obj.push(input[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 18 ~ obj.push(input[0]); [INFO] [stdout] 19 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> min_stack/src/bin/execute.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | let res = obj.push(input[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 24 ~ obj.push(input[0]); [INFO] [stdout] 25 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> min_stack/src/bin/execute.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | let res = obj.push(input[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 30 ~ obj.push(input[0]); [INFO] [stdout] 31 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> min_stack/src/bin/execute.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | let res = obj.pop(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 42 ~ obj.pop(); [INFO] [stdout] 43 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> lru_cache/src/bin/execute.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | let res = obj.put(input[0], input[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 18 ~ obj.put(input[0], input[1]); [INFO] [stdout] 19 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> lru_cache/src/bin/execute.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | let res = obj.put(input[0], input[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 24 ~ obj.put(input[0], input[1]); [INFO] [stdout] 25 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> lru_cache/src/bin/execute.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | let res = obj.put(input[0], input[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 36 ~ obj.put(input[0], input[1]); [INFO] [stdout] 37 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> lru_cache/src/bin/execute.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | let res = obj.put(input[0], input[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 48 ~ obj.put(input[0], input[1]); [INFO] [stdout] 49 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> lru_cache/src/bin/execute.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | let res = obj.put(input[0], input[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 18 ~ obj.put(input[0], input[1]); [INFO] [stdout] 19 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> lru_cache/src/bin/execute.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | let res = obj.put(input[0], input[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 24 ~ obj.put(input[0], input[1]); [INFO] [stdout] 25 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> lru_cache/src/bin/execute.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | let res = obj.put(input[0], input[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 36 ~ obj.put(input[0], input[1]); [INFO] [stdout] 37 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> lru_cache/src/bin/execute.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | let res = obj.put(input[0], input[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 48 ~ obj.put(input[0], input[1]); [INFO] [stdout] 49 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking meeting_rooms_ii v0.1.0 (/opt/rustwide/workdir/meeting_rooms_ii) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> meeting_rooms_ii/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | intervals: vec![vec![0, 30], vec![5, 10], vec![15, 20]], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + intervals: vec![vec![0, 30], vec![5, 10], vec![15, 20]], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> meeting_rooms_ii/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | intervals: vec![vec![7, 10], vec![2, 4]], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + intervals: vec![vec![7, 10], vec![2, 4]], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> meeting_rooms_ii/src/solution.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return max_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return max_count; [INFO] [stdout] 30 + max_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> meeting_rooms_ii/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | intervals: vec![vec![0, 30], vec![5, 10], vec![15, 20]], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + intervals: vec![vec![0, 30], vec![5, 10], vec![15, 20]], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> meeting_rooms_ii/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | intervals: vec![vec![7, 10], vec![2, 4]], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + intervals: vec![vec![7, 10], vec![2, 4]], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> meeting_rooms_ii/src/solution.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return max_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return max_count; [INFO] [stdout] 30 + max_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> implement_trie_prefix_tree/src/bin/execute.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | let res = obj.insert(input[0].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 18 ~ obj.insert(input[0].clone()); [INFO] [stdout] 19 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> implement_trie_prefix_tree/src/bin/execute.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | let res = obj.insert(input[0].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 18 ~ obj.insert(input[0].clone()); [INFO] [stdout] 19 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> implement_trie_prefix_tree/src/bin/execute.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | let res = obj.insert(input[0].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 42 ~ obj.insert(input[0].clone()); [INFO] [stdout] 43 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> implement_trie_prefix_tree/src/bin/execute.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | let res = obj.insert(input[0].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 42 ~ obj.insert(input[0].clone()); [INFO] [stdout] 43 ~ println!("result: {:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> two_sum/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![2, 7, 11, 15], [INFO] [stdout] 9 | | target: 9, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![2, 7, 11, 15], [INFO] [stdout] 9 + target: 9, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> two_sum/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![3, 2, 4], [INFO] [stdout] 16 | | target: 6, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![3, 2, 4], [INFO] [stdout] 16 + target: 6, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> two_sum/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | nums: vec![3, 3], [INFO] [stdout] 23 | | target: 6, [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + nums: vec![3, 3], [INFO] [stdout] 23 + target: 6, [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> two_sum/src/solution.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return nums; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return nums; [INFO] [stdout] 13 + nums [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_binary_search_trees/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | return Data { n: 3 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return Data { n: 3 }; [INFO] [stdout] 7 + Data { n: 3 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_binary_search_trees/src/data.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return Data { n: 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return Data { n: 1 }; [INFO] [stdout] 11 + Data { n: 1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_binary_search_trees/src/solution.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return num_trees[n as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return num_trees[n as usize]; [INFO] [stdout] 14 + num_trees[n as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | board: vec![ [INFO] [stdout] 9 | | vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 10 | | vec!['S', 'F', 'C', 'S'], [INFO] [stdout] ... | [INFO] [stdout] 13 | | word: "ABCCED".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + board: vec![ [INFO] [stdout] 9 + vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 10 + vec!['S', 'F', 'C', 'S'], [INFO] [stdout] 11 + vec!['A', 'D', 'E', 'E'], [INFO] [stdout] 12 + ], [INFO] [stdout] 13 + word: "ABCCED".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | board: vec![ [INFO] [stdout] 20 | | vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 21 | | vec!['S', 'F', 'C', 'S'], [INFO] [stdout] ... | [INFO] [stdout] 24 | | word: "SEE".to_string(), [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + board: vec![ [INFO] [stdout] 20 + vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 21 + vec!['S', 'F', 'C', 'S'], [INFO] [stdout] 22 + vec!['A', 'D', 'E', 'E'], [INFO] [stdout] 23 + ], [INFO] [stdout] 24 + word: "SEE".to_string(), [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/data.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / return Data { [INFO] [stdout] 30 | | board: vec![ [INFO] [stdout] 31 | | vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 32 | | vec!['S', 'F', 'C', 'S'], [INFO] [stdout] ... | [INFO] [stdout] 35 | | word: "ABCB".to_string(), [INFO] [stdout] 36 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Data { [INFO] [stdout] 30 + board: vec![ [INFO] [stdout] 31 + vec!['A', 'B', 'C', 'E'], [INFO] [stdout] 32 + vec!['S', 'F', 'C', 'S'], [INFO] [stdout] 33 + vec!['A', 'D', 'E', 'E'], [INFO] [stdout] 34 + ], [INFO] [stdout] 35 + word: "ABCB".to_string(), [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/solution.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return right || down || left || up; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return right || down || left || up; [INFO] [stdout] 49 + right || down || left || up [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> word_search/src/solution.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return false; [INFO] [stdout] 65 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> coin_change/src/solution.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / return if dp[amount as usize] != amount + 1 { [INFO] [stdout] 14 | | dp[amount as usize] [INFO] [stdout] 15 | | } else { [INFO] [stdout] 16 | | -1 [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 ~ if dp[amount as usize] != amount + 1 { [INFO] [stdout] 14 + dp[amount as usize] [INFO] [stdout] 15 + } else { [INFO] [stdout] 16 + -1 [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> coin_change/src/solution.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 8 | if (a as i32 - c as i32) as i32 >= 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(a as i32 - c as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> reverse_words_in_a_string_ii/src/solution.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn reverse_words(s: &mut Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn reverse_words(s: &mut Vec) -> Vec { [INFO] [stdout] 1 + pub fn reverse_words(s: &mut [char]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_consecutive_sequence/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![100, 4, 200, 1, 3, 2], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![100, 4, 200, 1, 3, 2], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_consecutive_sequence/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![0, 3, 7, 2, 5, 8, 4, 6, 0, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![0, 3, 7, 2, 5, 8, 4, 6, 0, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_consecutive_sequence/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | nums: vec![1, 0, 1, 2], [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + nums: vec![1, 0, 1, 2], [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_consecutive_sequence/src/solution.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return max_length; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return max_length; [INFO] [stdout] 17 + max_length [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> longest_consecutive_sequence/src/solution.rs:13:51 [INFO] [stdout] | [INFO] [stdout] 13 | max_length = cmp::max(max_length, length as i32); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> kth_largest_element_in_an_array/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![3, 2, 1, 5, 6, 4], [INFO] [stdout] 9 | | k: 2, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![3, 2, 1, 5, 6, 4], [INFO] [stdout] 9 + k: 2, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> reconstruct_itinerary/src/solution.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | if !has_tickets.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `has_tickets.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> kth_largest_element_in_an_array/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![3, 2, 3, 1, 2, 4, 5, 5, 6], [INFO] [stdout] 16 | | k: 4, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![3, 2, 3, 1, 2, 4, 5, 5, 6], [INFO] [stdout] 16 + k: 4, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> reconstruct_itinerary/src/solution.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return false; [INFO] [stdout] 36 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> reconstruct_itinerary/src/solution.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | if ticket == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ticket.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> reconstruct_itinerary/src/solution.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return path; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return path; [INFO] [stdout] 72 + path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> top_k_frequent_elements/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![1, 1, 1, 2, 2, 3], [INFO] [stdout] 9 | | k: 2, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![1, 1, 1, 2, 2, 3], [INFO] [stdout] 9 + k: 2, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> top_k_frequent_elements/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![1], [INFO] [stdout] 16 | | k: 1, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![1], [INFO] [stdout] 16 + k: 1, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> top_k_frequent_elements/src/solution.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return res; [INFO] [stdout] 19 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lowest_common_ancestor_of_a_binary_tree/src/solution.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | if l.is_some() { return l } else { return r } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - if l.is_some() { return l } else { return r } [INFO] [stdout] 31 + if l.is_some() { l } else { return r } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lowest_common_ancestor_of_a_binary_tree/src/solution.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 31 | if l.is_some() { return l } else { return r } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - if l.is_some() { return l } else { return r } [INFO] [stdout] 31 + if l.is_some() { return l } else { r } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> lowest_common_ancestor_of_a_binary_tree/src/solution.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / if root.is_none() { [INFO] [stdout] 10 | | return None; [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ help: replace it with: `root.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> remove_duplicates_from_sorted_list/src/data.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> remove_duplicates_from_sorted_list/src/data.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> four_sum/src/solution.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return output.iter().map(|m| m.to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return output.iter().map(|m| m.to_vec()).collect(); [INFO] [stdout] 62 + output.iter().map(|m| m.to_vec()).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindrome_number/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return true; [INFO] [stdout] 16 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> palindrome_number/src/solution.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if &x_str_chars[left] != &x_str_chars[right] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 10 - if &x_str_chars[left] != &x_str_chars[right] { [INFO] [stdout] 10 + if x_str_chars[left] != x_str_chars[right] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> palindrome_number/src/solution.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | left = left + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `left += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> palindrome_number/src/solution.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | right = right - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `right -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_the_duplicate_number/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![1, 3, 4, 2, 2], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![1, 3, 4, 2, 2], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_the_duplicate_number/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![3, 1, 3, 4, 2], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![3, 1, 3, 4, 2], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_the_duplicate_number/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | nums: vec![3, 3, 3, 3, 3], [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + nums: vec![3, 3, 3, 3, 3], [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> valid_sudoku/src/solution.rs:3:27 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn print_board(board: &Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn print_board(board: &Vec>) { [INFO] [stdout] 3 + pub fn print_board(board: &[Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:4:14 [INFO] [stdout] | [INFO] [stdout] 4 | for i in 0..board.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 4 - for i in 0..board.len() { [INFO] [stdout] 4 + for (i, ) in board.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | for j in 0..board[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 6 - for j in 0..board[i].len() { [INFO] [stdout] 6 + for (j, ) in board.iter().enumerate().take(board[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> valid_sudoku/src/solution.rs:7:38 [INFO] [stdout] | [INFO] [stdout] 7 | let char_print: String = format!("{}", board[i][j].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `board[i][j].to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> valid_sudoku/src/solution.rs:7:63 [INFO] [stdout] | [INFO] [stdout] 7 | let char_print: String = format!("{}", board[i][j].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> valid_sudoku/src/solution.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_sudoku/src/solution.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return true; [INFO] [stdout] 35 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> valid_sudoku/src/solution.rs:21:26 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn check_rows(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - pub fn check_rows(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] 21 + pub fn check_rows(board: &[Vec], row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | for i in 0..row_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 22 - for i in 0..row_len { [INFO] [stdout] 22 + for in board.iter().take(row_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 24 | for j in 0..col_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 24 - for j in 0..col_len { [INFO] [stdout] 24 + for in board.iter().take(col_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> valid_sudoku/src/solution.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | / match row_chars.get(&this_char) { [INFO] [stdout] 27 | | Some(_) => return false, [INFO] [stdout] 28 | | None => {} [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(_) = row_chars.get(&this_char) { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_sudoku/src/solution.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return true; [INFO] [stdout] 51 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> valid_sudoku/src/solution.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn check_cols(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - pub fn check_cols(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] 37 + pub fn check_cols(board: &[Vec], row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 38 | for i in 0..col_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 38 - for i in 0..col_len { [INFO] [stdout] 38 + for in board.iter().take(col_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 40 | for j in 0..row_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 40 - for j in 0..row_len { [INFO] [stdout] 40 + for in board.iter().take(row_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> valid_sudoku/src/solution.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | / match col_chars.get(&this_char) { [INFO] [stdout] 43 | | Some(_) => return false, [INFO] [stdout] 44 | | None => {} [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(_) = col_chars.get(&this_char) { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_sudoku/src/solution.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return true; [INFO] [stdout] 76 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> valid_sudoku/src/solution.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn check_grid(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - pub fn check_grid(board: &Vec>, row_len: usize, col_len: usize) -> bool { [INFO] [stdout] 53 + pub fn check_grid(board: &[Vec], row_len: usize, col_len: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | for i in box_row * 3..box_row * 3 + 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 60 - for i in box_row * 3..box_row * 3 + 3 { [INFO] [stdout] 60 + for in board.iter().skip(box_row * 3).take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `board` [INFO] [stdout] --> valid_sudoku/src/solution.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 61 | for j in box_col * 3..box_col * 3 + 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 61 - for j in box_col * 3..box_col * 3 + 3 { [INFO] [stdout] 61 + for in board.iter().skip(box_col * 3).take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> valid_sudoku/src/solution.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | / match box_chars.get(&this_char) { [INFO] [stdout] 64 | | Some(_) => return false, [INFO] [stdout] 65 | | None => {} [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(_) = box_chars.get(&this_char) { return false }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_sudoku/src/solution.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return rows_valid && cols_valid && grid_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return rows_valid && cols_valid && grid_valid; [INFO] [stdout] 83 + rows_valid && cols_valid && grid_valid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> spiral_matrix/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | matrix: vec![vec![1, 2, 3], vec![4, 5, 6], vec![7, 8, 9]], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + matrix: vec![vec![1, 2, 3], vec![4, 5, 6], vec![7, 8, 9]], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> spiral_matrix/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | matrix: vec![vec![1, 2, 3, 4], vec![5, 6, 7, 8], vec![9, 10, 11, 12]], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + matrix: vec![vec![1, 2, 3, 4], vec![5, 6, 7, 8], vec![9, 10, 11, 12]], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> spiral_matrix/src/solution.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return output; [INFO] [stdout] 30 + output [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&(row, col)).is_some()` [INFO] [stdout] --> spiral_matrix/src/solution.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | if visited.get(&(row, col)).is_some() || row >= row_len || col >= col_len { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains(&(row, col))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking data_structures_algorithms_rust_2 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> flatten_binary_tree_to_linked_list/src/data.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | Data { root: root } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> remove_duplicates_from_sorted_list/src/solution.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return head; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return head; [INFO] [stdout] 19 + head [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | digits: "23".to_string(), [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + digits: "23".to_string(), [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> fizz_buzz/src/solution.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return res; [INFO] [stdout] 15 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | digits: "".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + digits: "".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / return Data { [INFO] [stdout] 19 | | digits: "2".to_string(), [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 ~ Data { [INFO] [stdout] 19 + digits: "2".to_string(), [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | dfs(&digits, &map, index + 1, new_path, res.as_mut()); [INFO] [stdout] | ^^^^^^^ help: change this to: `digits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:16:22 [INFO] [stdout] | [INFO] [stdout] 16 | dfs(&digits, &map, index + 1, new_path, res.as_mut()); [INFO] [stdout] | ^^^^ help: change this to: `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_mut` does nothing [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:16:49 [INFO] [stdout] | [INFO] [stdout] 16 | dfs(&digits, &map, index + 1, new_path, res.as_mut()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return res; [INFO] [stdout] 39 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> letter_combinations_of_a_phone_number/src/solution.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if digits.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `digits.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> house_robber/src/solution.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return nums[nums.len() - 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return nums[nums.len() - 1]; [INFO] [stdout] 10 + nums[nums.len() - 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_cost_climbing_stairs/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | costs: vec![10, 15, 20], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + costs: vec![10, 15, 20], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_cost_climbing_stairs/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | costs: vec![1, 100, 1, 1, 1, 100, 1, 1, 100, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + costs: vec![1, 100, 1, 1, 1, 100, 1, 1, 100, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> min_cost_climbing_stairs/src/solution.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return cmp::min(costs[0], costs[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return cmp::min(costs[0], costs[1]); [INFO] [stdout] 10 + cmp::min(costs[0], costs[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindromic_substrings/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | s: "abc".to_string(), [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + s: "abc".to_string(), [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindromic_substrings/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | s: "aaa".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + s: "aaa".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindromic_substrings/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return count; [INFO] [stdout] 21 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> palindromic_substrings/src/solution.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | let mut r = l as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> palindromic_substrings/src/solution.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | let mut r = l as i32 + 1; [INFO] [stdout] | ^^^^^^^^ help: try: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_mut` does nothing [INFO] [stdout] --> generate_parentheses/src/solution.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | output_vec.as_mut(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `output_vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_mut` does nothing [INFO] [stdout] --> generate_parentheses/src/solution.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | output_vec.as_mut(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `output_vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> generate_parentheses/src/solution.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return output_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return output_vec; [INFO] [stdout] 36 + output_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_palindromic_substring/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | s: "babad".to_string(), [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + s: "babad".to_string(), [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_palindromic_substring/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | s: "cbbd".to_string(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + s: "cbbd".to_string(), [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> longest_palindromic_substring/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return longest_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return longest_str; [INFO] [stdout] 29 + longest_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this binary expression can be simplified [INFO] [stdout] --> longest_palindromic_substring/src/solution.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | if left == right || left > right { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `left >= right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stdout] = note: `#[warn(clippy::double_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> longest_palindromic_substring/src/solution.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | x = x + 1 [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> longest_palindromic_substring/src/solution.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | window_size = window_size - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_size -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> insert_interval/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | intervals: vec![vec![1, 3], vec![6, 9]], [INFO] [stdout] 9 | | new_interval: vec![2, 5], [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + intervals: vec![vec![1, 3], vec![6, 9]], [INFO] [stdout] 9 + new_interval: vec![2, 5], [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> insert_interval/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | intervals: vec![ [INFO] [stdout] 16 | | vec![1, 2], [INFO] [stdout] 17 | | vec![3, 5], [INFO] [stdout] ... | [INFO] [stdout] 22 | | new_interval: vec![4, 8], [INFO] [stdout] 23 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + intervals: vec![ [INFO] [stdout] 16 + vec![1, 2], [INFO] [stdout] 17 + vec![3, 5], [INFO] [stdout] 18 + vec![6, 7], [INFO] [stdout] 19 + vec![8, 10], [INFO] [stdout] 20 + vec![12, 16], [INFO] [stdout] 21 + ], [INFO] [stdout] 22 + new_interval: vec![4, 8], [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> insert_interval/src/solution.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return stack; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return stack; [INFO] [stdout] 25 + stack [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> valid_anagram/src/solution.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | return s_chars == t_chars; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return s_chars == t_chars; [INFO] [stdout] 6 + s_chars == t_chars [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | candidates: vec![2, 3, 6, 7], [INFO] [stdout] 9 | | target: 7, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + candidates: vec![2, 3, 6, 7], [INFO] [stdout] 9 + target: 7, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | candidates: vec![2, 3, 5], [INFO] [stdout] 16 | | target: 8, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + candidates: vec![2, 3, 5], [INFO] [stdout] 16 + target: 8, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | candidates: vec![2], [INFO] [stdout] 23 | | target: 1, [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + candidates: vec![2], [INFO] [stdout] 23 + target: 1, [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> combination_sum/src/solution.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | candidates: &Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - candidates: &Vec, [INFO] [stdout] 3 + candidates: &[i32], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum/src/solution.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return combinations.iter().map(|v| v.to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return combinations.iter().map(|v| v.to_vec()).collect(); [INFO] [stdout] 38 + combinations.iter().map(|v| v.to_vec()).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_subarray/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![-2, 1, -3, 4, -1, 2, 1, -5, 4], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![-2, 1, -3, 4, -1, 2, 1, -5, 4], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_subarray/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return Data { nums: vec![1] }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return Data { nums: vec![1] }; [INFO] [stdout] 12 + Data { nums: vec![1] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_subarray/src/data.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / return Data { [INFO] [stdout] 17 | | nums: vec![5, 4, -1, 7, 8], [INFO] [stdout] 18 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ Data { [INFO] [stdout] 17 + nums: vec![5, 4, -1, 7, 8], [INFO] [stdout] 18 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximum_subarray/src/solution.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return max_sum; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return max_sum; [INFO] [stdout] 14 + max_sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return -1; [INFO] [stdout] 20 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:10:45 [INFO] [stdout] | [INFO] [stdout] 10 | let right_res = binary_search_right(&nums, mid + 1, right, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_in_rotated_sorted_array/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return -1; [INFO] [stdout] 16 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_in_rotated_sorted_array/src/solution.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return cmp::max(res_left, res_right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return cmp::max(res_left, res_right); [INFO] [stdout] 32 + cmp::max(res_left, res_right) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:15:44 [INFO] [stdout] | [INFO] [stdout] 15 | let left_res = binary_search_right(&nums, left, mid, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return -1; [INFO] [stdout] 42 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_paths/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | return Data { m: 3, n: 7 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return Data { m: 3, n: 7 }; [INFO] [stdout] 7 + Data { m: 3, n: 7 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:32:44 [INFO] [stdout] | [INFO] [stdout] 32 | let left_left = binary_search_left(&nums, left, mid, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:37:45 [INFO] [stdout] | [INFO] [stdout] 37 | let left_right = binary_search_left(&nums, mid + 1, right, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_first_and_last_position_of_element_in_sorted_array/src/solution.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return [left, right].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return [left, right].to_vec(); [INFO] [stdout] 53 + [left, right].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_paths/src/data.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return Data { m: 3, n: 2 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return Data { m: 3, n: 2 }; [INFO] [stdout] 11 + Data { m: 3, n: 2 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left` after checking its variant with `is_some` [INFO] [stdout] --> unique_paths/src/solution.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 15 | if left.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = left` [INFO] [stdout] 16 | path_count += left.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `above` after checking its variant with `is_some` [INFO] [stdout] --> unique_paths/src/solution.rs:19:31 [INFO] [stdout] | [INFO] [stdout] 18 | if above.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = above` [INFO] [stdout] 19 | path_count += above.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> unique_paths/src/solution.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return *map.get(&(m - 1, n - 1)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return *map.get(&(m - 1, n - 1)).unwrap(); [INFO] [stdout] 24 + *map.get(&(m - 1, n - 1)).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> climbing_stairs/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | return Data { n: 2 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return Data { n: 2 }; [INFO] [stdout] 6 + Data { n: 2 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> climbing_stairs/src/data.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return Data { n: 3 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return Data { n: 3 }; [INFO] [stdout] 10 + Data { n: 3 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> climbing_stairs/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return step_1 + step_2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return step_1 + step_2; [INFO] [stdout] 21 + step_1 + step_2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> climbing_stairs/src/solution.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return dfs(n, 0, &mut solutions); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return dfs(n, 0, &mut solutions); [INFO] [stdout] 26 + dfs(n, 0, &mut solutions) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> next_permutation/src/solution.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return nums; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return nums; [INFO] [stdout] 25 + nums [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `nums` manually [INFO] [stdout] --> next_permutation/src/solution.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / let tmp = nums[swap]; [INFO] [stdout] 21 | | nums[swap] = nums[pivot]; [INFO] [stdout] 22 | | nums[pivot] = tmp; [INFO] [stdout] | |______________________^ help: try: `nums.swap(swap, pivot);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> palindrome_permutation/src/solution.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if !(value % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(value % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_insert_position/src/solution.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return -1; [INFO] [stdout] 39 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> palindrome_permutation/src/solution.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return odd_count_chars <= 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return odd_count_chars <= 1; [INFO] [stdout] 17 + odd_count_chars <= 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> palindrome_permutation/src/solution.rs:8:42 [INFO] [stdout] | [INFO] [stdout] 8 | map.entry(letter).and_modify(|m| *m = *m + 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> palindrome_permutation/src/solution.rs:12:29 [INFO] [stdout] | [INFO] [stdout] 12 | let value = map.get(&key).unwrap(); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_leaves_of_binary_tree/src/solution.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return max_layer + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return max_layer + 1; [INFO] [stdout] 24 + max_layer + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_leaves_of_binary_tree/src/solution.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return res; [INFO] [stdout] 37 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> find_leaves_of_binary_tree/src/solution.rs:32:49 [INFO] [stdout] | [INFO] [stdout] 32 | let mut keys: Vec = map.keys().map(|m| *m as i32).collect(); [INFO] [stdout] | ^^^^^^^^^ help: try: `*m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | matrix: vec![ [INFO] [stdout] 8 | | vec!['1', '0', '1', '0', '0'], [INFO] [stdout] 9 | | vec!['1', '0', '1', '1', '1'], [INFO] [stdout] ... | [INFO] [stdout] 12 | | ], [INFO] [stdout] 13 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + matrix: vec![ [INFO] [stdout] 8 + vec!['1', '0', '1', '0', '0'], [INFO] [stdout] 9 + vec!['1', '0', '1', '1', '1'], [INFO] [stdout] 10 + vec!['1', '1', '1', '1', '1'], [INFO] [stdout] 11 + vec!['1', '0', '0', '1', '0'], [INFO] [stdout] 12 + ], [INFO] [stdout] 13 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/data.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return Data { [INFO] [stdout] 18 | | matrix: vec![vec!['0', '1'], vec!['1', '0']], [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Data { [INFO] [stdout] 18 + matrix: vec![vec!['0', '1'], vec!['1', '0']], [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/data.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return Data { [INFO] [stdout] 24 | | matrix: vec![vec!['0']], [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ Data { [INFO] [stdout] 24 + matrix: vec![vec!['0']], [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return cache_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return cache_value; [INFO] [stdout] 29 + cache_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> search_insert_position/src/solution.rs:23:36 [INFO] [stdout] | [INFO] [stdout] 23 | let result = binary_search(&nums, left, mid, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> search_insert_position/src/solution.rs:30:36 [INFO] [stdout] | [INFO] [stdout] 30 | let result = binary_search(&nums, mid + 1, right, target); [INFO] [stdout] | ^^^^^ help: change this to: `nums` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> maximal_square/src/solution.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return max_square[0] * max_square[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return max_square[0] * max_square[0]; [INFO] [stdout] 37 + max_square[0] * max_square[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_insert_position/src/solution.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return result; [INFO] [stdout] 44 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> integer_to_roman/src/solution.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return output_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return output_str; [INFO] [stdout] 59 + output_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> integer_to_roman/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | exp = exp - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `exp -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> plus_one/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | digits: vec![1, 2, 3], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + digits: vec![1, 2, 3], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> best_time_to_buy_and_sell_stock/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | prices: vec![7, 1, 5, 3, 6, 4], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + prices: vec![7, 1, 5, 3, 6, 4], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> plus_one/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | digits: vec![4, 3, 2, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + digits: vec![4, 3, 2, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> best_time_to_buy_and_sell_stock/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | prices: vec![7, 6, 4, 3, 1], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + prices: vec![7, 6, 4, 3, 1], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> best_time_to_buy_and_sell_stock/src/solution.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return profit; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return profit; [INFO] [stdout] 10 + profit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `prices` [INFO] [stdout] --> best_time_to_buy_and_sell_stock/src/solution.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | for i in 0..prices.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 6 - for i in 0..prices.len() { [INFO] [stdout] 6 + for in &prices { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> plus_one/src/data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return Data { digits: vec![9] }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Data { digits: vec![9] }; [INFO] [stdout] 18 + Data { digits: vec![9] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> plus_one/src/solution.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return res.iter().rev().map(|m| *m).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return res.iter().rev().map(|m| *m).collect(); [INFO] [stdout] 18 + res.iter().rev().map(|m| *m).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> plus_one/src/solution.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | return res.iter().rev().map(|m| *m).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.iter().rev().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum_ii/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | candidates: vec![10, 1, 2, 7, 6, 1, 5], [INFO] [stdout] 9 | | target: 8, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + candidates: vec![10, 1, 2, 7, 6, 1, 5], [INFO] [stdout] 9 + target: 8, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum_ii/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | candidates: vec![2, 5, 2, 1, 2], [INFO] [stdout] 16 | | target: 5, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + candidates: vec![2, 5, 2, 1, 2], [INFO] [stdout] 16 + target: 5, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> three_sum_closest/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![-1, 2, 1, -4], [INFO] [stdout] 9 | | target: 1, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![-1, 2, 1, -4], [INFO] [stdout] 9 + target: 1, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> three_sum_closest/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![0, 0, 0], [INFO] [stdout] 16 | | target: 1, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![0, 0, 0], [INFO] [stdout] 16 + target: 1, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> three_sum_closest/src/solution.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return closest_target; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return closest_target; [INFO] [stdout] 36 + closest_target [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> number_of_islands/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | grid: vec![ [INFO] [stdout] 8 | | vec!['1', '1', '1', '1', '0'], [INFO] [stdout] 9 | | vec!['1', '1', '0', '1', '0'], [INFO] [stdout] ... | [INFO] [stdout] 12 | | ], [INFO] [stdout] 13 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + grid: vec![ [INFO] [stdout] 8 + vec!['1', '1', '1', '1', '0'], [INFO] [stdout] 9 + vec!['1', '1', '0', '1', '0'], [INFO] [stdout] 10 + vec!['1', '1', '0', '0', '0'], [INFO] [stdout] 11 + vec!['0', '0', '0', '0', '0'], [INFO] [stdout] 12 + ], [INFO] [stdout] 13 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> number_of_islands/src/data.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return Data { [INFO] [stdout] 18 | | grid: vec![ [INFO] [stdout] 19 | | vec!['1', '1', '0', '0', '0'], [INFO] [stdout] 20 | | vec!['1', '1', '0', '0', '0'], [INFO] [stdout] ... | [INFO] [stdout] 23 | | ], [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Data { [INFO] [stdout] 18 + grid: vec![ [INFO] [stdout] 19 + vec!['1', '1', '0', '0', '0'], [INFO] [stdout] 20 + vec!['1', '1', '0', '0', '0'], [INFO] [stdout] 21 + vec!['0', '0', '1', '0', '0'], [INFO] [stdout] 22 + vec!['0', '0', '0', '1', '1'], [INFO] [stdout] 23 + ], [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> combination_sum_ii/src/solution.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | candidates: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - candidates: &mut Vec, [INFO] [stdout] 4 + candidates: &mut [i32], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> combination_sum_ii/src/solution.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return res; [INFO] [stdout] 44 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> number_of_islands/src/solution.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return islands; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return islands; [INFO] [stdout] 42 + islands [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subarray_sum_equals_k/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | nums: vec![1, 1, 1], [INFO] [stdout] 9 | | k: 2, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + nums: vec![1, 1, 1], [INFO] [stdout] 9 + k: 2, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subarray_sum_equals_k/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | nums: vec![1, 2, 3], [INFO] [stdout] 16 | | k: 3, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + nums: vec![1, 2, 3], [INFO] [stdout] 16 + k: 3, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> subarray_sum_equals_k/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return total; [INFO] [stdout] 16 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> house_robber_iii/src/solution.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return (with_root, without_root); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return (with_root, without_root); [INFO] [stdout] 17 + (with_root, without_root) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> task_scheduler/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | tasks: vec!['A', 'A', 'A', 'B', 'B', 'B'], [INFO] [stdout] 9 | | n: 2, [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + tasks: vec!['A', 'A', 'A', 'B', 'B', 'B'], [INFO] [stdout] 9 + n: 2, [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> house_robber_iii/src/solution.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return cmp::max(pair.0, pair.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return cmp::max(pair.0, pair.1); [INFO] [stdout] 21 + cmp::max(pair.0, pair.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> task_scheduler/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | tasks: vec!['A', 'C', 'A', 'B', 'D', 'B'], [INFO] [stdout] 16 | | n: 1, [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + tasks: vec!['A', 'C', 'A', 'B', 'D', 'B'], [INFO] [stdout] 16 + n: 1, [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> task_scheduler/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | tasks: vec!['A', 'A', 'A', 'B', 'B', 'B'], [INFO] [stdout] 23 | | n: 3, [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + tasks: vec!['A', 'A', 'A', 'B', 'B', 'B'], [INFO] [stdout] 23 + n: 3, [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> subarray_sum_equals_k/src/solution.rs:14:44 [INFO] [stdout] | [INFO] [stdout] 14 | map.entry(curr_sum).and_modify(|m| *m = *m + 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> task_scheduler/src/solution.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return time; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return time; [INFO] [stdout] 39 + time [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> task_scheduler/src/solution.rs:11:40 [INFO] [stdout] | [INFO] [stdout] 11 | map.entry(task).and_modify(|m| *m = *m + 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations_ii/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![1, 1, 2], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![1, 1, 2], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations_ii/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![1, 2, 3], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![1, 2, 3], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> task_scheduler/src/solution.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | / if task.1 == time { [INFO] [stdout] 30 | | let next_task = q.pop_front().unwrap().0; [INFO] [stdout] 31 | | heap.push(next_task); [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ Some(task) [INFO] [stdout] 29 ~ if task.1 == time => { [INFO] [stdout] 30 | let next_task = q.pop_front().unwrap().0; [INFO] [stdout] 31 | heap.push(next_task); [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> task_scheduler/src/solution.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | / match q.front() { [INFO] [stdout] 28 | | Some(task) => { [INFO] [stdout] 29 | | if task.1 == time { [INFO] [stdout] 30 | | let next_task = q.pop_front().unwrap().0; [INFO] [stdout] ... | [INFO] [stdout] 34 | | None => {} [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 ~ if let Some(task) = q.front() { [INFO] [stdout] 28 + if task.1 == time { [INFO] [stdout] 29 + let next_task = q.pop_front().unwrap().0; [INFO] [stdout] 30 + heap.push(next_task); [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> permutations_ii/src/solution.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | post: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - post: &mut Vec, [INFO] [stdout] 6 + post: &mut [i32], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> permutations_ii/src/solution.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return res; [INFO] [stdout] 26 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![2, 3, 1, 1, 4], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![2, 3, 1, 1, 4], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![3, 2, 1, 0, 4], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![3, 2, 1, 0, 4], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> jump_game/src/solution.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return last_reachable == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return last_reachable == 0; [INFO] [stdout] 11 + last_reachable == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> path_sum_iii/src/solution.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / match current.checked_add(root_ref.val) { [INFO] [stdout] 17 | | None => return, [INFO] [stdout] 18 | | _ => {} [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ help: try: `if current.checked_add(root_ref.val) == None { return }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> kth_smallest_element_in_a_bst/src/solution.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return 0; [INFO] [stdout] 23 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> path_sum_iii/src/solution.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return total_count[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return total_count[0]; [INFO] [stdout] 51 + total_count[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_a_2d_matrix_ii/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | matrix: vec![ [INFO] [stdout] 9 | | vec![1, 4, 7, 11, 15], [INFO] [stdout] 10 | | vec![2, 5, 8, 12, 19], [INFO] [stdout] ... | [INFO] [stdout] 15 | | target: 5, [INFO] [stdout] 16 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + matrix: vec![ [INFO] [stdout] 9 + vec![1, 4, 7, 11, 15], [INFO] [stdout] 10 + vec![2, 5, 8, 12, 19], [INFO] [stdout] 11 + vec![3, 6, 9, 16, 22], [INFO] [stdout] 12 + vec![10, 13, 14, 17, 24], [INFO] [stdout] 13 + vec![18, 21, 23, 26, 30], [INFO] [stdout] 14 + ], [INFO] [stdout] 15 + target: 5, [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_all_anagrams_in_a_string/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | s: "cbaebabacd".to_string(), [INFO] [stdout] 9 | | p: "abc".to_string(), [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + s: "cbaebabacd".to_string(), [INFO] [stdout] 9 + p: "abc".to_string(), [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_a_2d_matrix_ii/src/data.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / return Data { [INFO] [stdout] 21 | | matrix: vec![ [INFO] [stdout] 22 | | vec![1, 4, 7, 11, 15], [INFO] [stdout] 23 | | vec![2, 5, 8, 12, 19], [INFO] [stdout] ... | [INFO] [stdout] 28 | | target: 20, [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 ~ Data { [INFO] [stdout] 21 + matrix: vec![ [INFO] [stdout] 22 + vec![1, 4, 7, 11, 15], [INFO] [stdout] 23 + vec![2, 5, 8, 12, 19], [INFO] [stdout] 24 + vec![3, 6, 9, 16, 22], [INFO] [stdout] 25 + vec![10, 13, 14, 17, 24], [INFO] [stdout] 26 + vec![18, 21, 23, 26, 30], [INFO] [stdout] 27 + ], [INFO] [stdout] 28 + target: 20, [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_a_2d_matrix_ii/src/solution.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return false; [INFO] [stdout] 29 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> search_a_2d_matrix_ii/src/solution.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return res; [INFO] [stdout] 34 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_all_anagrams_in_a_string/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | s: "abab".to_string(), [INFO] [stdout] 16 | | p: "ab".to_string(), [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + s: "abab".to_string(), [INFO] [stdout] 16 + p: "ab".to_string(), [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> reverse_linked_list/src/data.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return res; [INFO] [stdout] 43 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:14:29 [INFO] [stdout] | [INFO] [stdout] 14 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:28:33 [INFO] [stdout] | [INFO] [stdout] 28 | .and_modify(|m| *m = *m + 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> find_all_anagrams_in_a_string/src/solution.rs:33:29 [INFO] [stdout] | [INFO] [stdout] 33 | .and_modify(|m| *m = *m - 1) [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*m -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> design_tic_tac_toe/src/solution.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | board: board, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/data.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / return Data { [INFO] [stdout] 8 | | num_courses: 2, [INFO] [stdout] 9 | | prerequisites: vec![vec![1, 0]], [INFO] [stdout] 10 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 ~ Data { [INFO] [stdout] 8 + num_courses: 2, [INFO] [stdout] 9 + prerequisites: vec![vec![1, 0]], [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/data.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / return Data { [INFO] [stdout] 15 | | num_courses: 4, [INFO] [stdout] 16 | | prerequisites: vec![vec![1, 0], vec![2, 0], vec![3, 1], vec![3, 2]], [INFO] [stdout] 17 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Data { [INFO] [stdout] 15 + num_courses: 4, [INFO] [stdout] 16 + prerequisites: vec![vec![1, 0], vec![2, 0], vec![3, 1], vec![3, 2]], [INFO] [stdout] 17 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/data.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Data { [INFO] [stdout] 22 | | num_courses: 1, [INFO] [stdout] 23 | | prerequisites: vec![], [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Data { [INFO] [stdout] 22 + num_courses: 1, [INFO] [stdout] 23 + prerequisites: vec![], [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/solution.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> course_schedule_ii/src/solution.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return path; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return path; [INFO] [stdout] 54 + path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> partition_equal_subset_sum/src/data.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return Data { [INFO] [stdout] 7 | | nums: vec![1, 5, 11, 5], [INFO] [stdout] 8 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ Data { [INFO] [stdout] 7 + nums: vec![1, 5, 11, 5], [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> partition_equal_subset_sum/src/data.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return Data { [INFO] [stdout] 13 | | nums: vec![1, 2, 3, 5], [INFO] [stdout] 14 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Data { [INFO] [stdout] 13 + nums: vec![1, 2, 3, 5], [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> partition_equal_subset_sum/src/solution.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return false; [INFO] [stdout] 22 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> partition_equal_subset_sum/src/solution.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | let total_sum: i32 = nums.iter().map(|&i| i).sum(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `nums.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> sort_list/src/data.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | Data { head: head } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> reverse_linked_list/src/solution.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return prev; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return prev; [INFO] [stdout] 12 + prev [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> add_two_numbers/src/data.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return Some(head); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return Some(head); [INFO] [stdout] 24 + Some(head) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> add_two_numbers/src/solution.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return head.next; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [WARN] too many lines in the log, truncating it