[INFO] cloning repository https://github.com/huffs-projects/sky [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/huffs-projects/sky" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhuffs-projects%2Fsky", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhuffs-projects%2Fsky'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a41dc84b03899be56eb412652c0e79c42357c6d1 [INFO] linting huffs-projects/sky against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhuffs-projects%2Fsky" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/huffs-projects/sky [INFO] finished tweaking git repo https://github.com/huffs-projects/sky [INFO] tweaked toml for git repo https://github.com/huffs-projects/sky written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/huffs-projects/sky on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 282 packages to latest compatible versions [INFO] [stderr] Adding dialoguer v0.11.0 (available: v0.12.0) [INFO] [stderr] Adding dirs v5.0.1 (available: v6.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding reqwest v0.12.28 (available: v0.13.2) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] [stderr] Adding toml v0.8.23 (available: v1.0.7+spec-1.1.0) [INFO] [stderr] Adding zip v0.6.6 (available: v8.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dialoguer v0.11.0 [INFO] [stderr] Downloaded openssl-sys v0.9.112 [INFO] [stderr] Downloaded openssl v0.10.76 [INFO] [stderr] Downloaded bzip2-sys v0.1.13+1.0.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdfb9ceeb16fe906703f50f66b3f026b25ec2e051b1b2efb1a85e2b44afb840b [INFO] running `Command { std: "docker" "start" "-a" "cdfb9ceeb16fe906703f50f66b3f026b25ec2e051b1b2efb1a85e2b44afb840b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdfb9ceeb16fe906703f50f66b3f026b25ec2e051b1b2efb1a85e2b44afb840b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdfb9ceeb16fe906703f50f66b3f026b25ec2e051b1b2efb1a85e2b44afb840b", kill_on_drop: false }` [INFO] [stdout] cdfb9ceeb16fe906703f50f66b3f026b25ec2e051b1b2efb1a85e2b44afb840b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b82e0e56742912c53a44071b66dfa78ffeb81203dcb07c69ee3f9ead8cfddeb5 [INFO] running `Command { std: "docker" "start" "-a" "b82e0e56742912c53a44071b66dfa78ffeb81203dcb07c69ee3f9ead8cfddeb5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle-parse v1.0.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking anstream v1.0.0 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking time-core v0.1.8 [INFO] [stderr] Checking winnow v0.7.15 [INFO] [stderr] Checking num-conv v0.2.0 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking jiff v0.2.23 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling clap_derive v4.6.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking sky v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if show_config || (!show_index && !show_config && !show_managers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 153 - if show_config || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 153 + if (!show_managers || show_config) && (!show_index || show_config) { [INFO] [stdout] | [INFO] [stdout] 153 - if show_config || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 153 + if show_config || !show_index && !show_managers { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 165 | if show_managers || (!show_index && !show_config && !show_managers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 165 - if show_managers || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 165 + if (!show_config || show_managers) && (!show_index || show_managers) { [INFO] [stdout] | [INFO] [stdout] 165 - if show_managers || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 165 + if show_managers || !show_index && !show_config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if show_index || (!show_index && !show_config && !show_managers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 182 - if show_index || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 182 + if (!show_managers || show_index) && (!show_config || show_index) { [INFO] [stdout] | [INFO] [stdout] 182 - if show_index || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 182 + if show_index || !show_config && !show_managers { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/index.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | pkg.description.as_ref().map_or(false, |d| d.contains(query)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 136 - pkg.description.as_ref().map_or(false, |d| d.contains(query)) [INFO] [stdout] 136 + pkg.description.as_ref().is_some_and(|d| d.contains(query)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/modes/declarative.rs:57:30 [INFO] [stdout] | [INFO] [stdout] 57 | for (name, _spec) in &package_list.packages { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 57 - for (name, _spec) in &package_list.packages { [INFO] [stdout] 57 + for name in package_list.packages.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/package.rs:143:25 [INFO] [stdout] | [INFO] [stdout] 143 | if let Some(ref build_command) = pkg.build.get(&platform) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 - if let Some(ref build_command) = pkg.build.get(&platform) { [INFO] [stdout] 143 + if let Some(build_command) = pkg.build.get(&platform) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/package.rs:419:9 [INFO] [stdout] | [INFO] [stdout] 419 | / if pkg.pkg_type == "system" && self.system_manager != SystemPackageManager::Unknown { [INFO] [stdout] 420 | | if self.system_manager.is_package_installed(&pkg.name)? { [INFO] [stdout] 421 | | return Ok(true); [INFO] [stdout] 422 | | } [INFO] [stdout] 423 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 419 ~ if pkg.pkg_type == "system" && self.system_manager != SystemPackageManager::Unknown [INFO] [stdout] 420 ~ && self.system_manager.is_package_installed(&pkg.name)? { [INFO] [stdout] 421 | return Ok(true); [INFO] [stdout] 422 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/package.rs:434:13 [INFO] [stdout] | [INFO] [stdout] 434 | / if lang_manager != LanguagePackageManager::Unknown { [INFO] [stdout] 435 | | if lang_manager.is_package_installed(&pkg.name)? { [INFO] [stdout] 436 | | return Ok(true); [INFO] [stdout] 437 | | } [INFO] [stdout] 438 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 434 ~ if lang_manager != LanguagePackageManager::Unknown [INFO] [stdout] 435 ~ && lang_manager.is_package_installed(&pkg.name)? { [INFO] [stdout] 436 | return Ok(true); [INFO] [stdout] 437 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/package.rs:600:25 [INFO] [stdout] | [INFO] [stdout] 600 | let file_name = download_url [INFO] [stdout] | _________________________^ [INFO] [stdout] 601 | | .split('/') [INFO] [stdout] 602 | | .last() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 602 - .last() [INFO] [stdout] 602 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/utils/deps.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/utils/deps.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | for (_pkg, deps) in package_requirements { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 93 - for (_pkg, deps) in package_requirements { [INFO] [stdout] 93 + for deps in package_requirements.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/utils/deps.rs:95:68 [INFO] [stdout] | [INFO] [stdout] 95 | let versions = version_map.entry(dep_req.name.clone()).or_insert_with(HashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/utils/deps.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | let major = parts.get(0).and_then(|s| s.parse().ok()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `version_parts.get(0)` [INFO] [stdout] --> src/utils/deps.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | let major = version_parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `version_parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/utils/system.rs:276:40 [INFO] [stdout] | [INFO] [stdout] 276 | if let Some(pkg) = line.split('/').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 276 - if let Some(pkg) = line.split('/').last() { [INFO] [stdout] 276 + if let Some(pkg) = line.split('/').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/utils/language.rs:30:49 [INFO] [stdout] | [INFO] [stdout] 30 | if Self::command_exists("pip3") { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 31 | | Self::Pip [INFO] [stdout] 32 | | } else if Self::command_exists("pip") { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/utils/language.rs:32:55 [INFO] [stdout] | [INFO] [stdout] 32 | } else if Self::command_exists("pip") { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 33 | | Self::Pip [INFO] [stdout] 34 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/utils/language.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | / match self { [INFO] [stdout] 327 | | Self::Go => { [INFO] [stdout] 328 | | // Go installs to GOPATH/bin, ensure it exists [INFO] [stdout] 329 | | if let Ok(gopath) = std::env::var("GOPATH") { [INFO] [stdout] ... | [INFO] [stdout] 334 | | _ => {} [INFO] [stdout] 335 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 326 ~ if self == &Self::Go { [INFO] [stdout] 327 + // Go installs to GOPATH/bin, ensure it exists [INFO] [stdout] 328 + if let Ok(gopath) = std::env::var("GOPATH") { [INFO] [stdout] 329 + let gobin = PathBuf::from(gopath).join("bin"); [INFO] [stdout] 330 + std::fs::create_dir_all(&gobin).ok(); [INFO] [stdout] 331 + } [INFO] [stdout] 332 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if show_config || (!show_index && !show_config && !show_managers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 153 - if show_config || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 153 + if (!show_managers || show_config) && (!show_index || show_config) { [INFO] [stdout] | [INFO] [stdout] 153 - if show_config || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 153 + if show_config || !show_index && !show_managers { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 165 | if show_managers || (!show_index && !show_config && !show_managers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 165 - if show_managers || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 165 + if (!show_config || show_managers) && (!show_index || show_managers) { [INFO] [stdout] | [INFO] [stdout] 165 - if show_managers || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 165 + if show_managers || !show_index && !show_config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if show_index || (!show_index && !show_config && !show_managers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 182 - if show_index || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 182 + if (!show_managers || show_index) && (!show_config || show_index) { [INFO] [stdout] | [INFO] [stdout] 182 - if show_index || (!show_index && !show_config && !show_managers) { [INFO] [stdout] 182 + if show_index || !show_config && !show_managers { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/index.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | pkg.description.as_ref().map_or(false, |d| d.contains(query)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 136 - pkg.description.as_ref().map_or(false, |d| d.contains(query)) [INFO] [stdout] 136 + pkg.description.as_ref().is_some_and(|d| d.contains(query)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/modes/declarative.rs:57:30 [INFO] [stdout] | [INFO] [stdout] 57 | for (name, _spec) in &package_list.packages { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 57 - for (name, _spec) in &package_list.packages { [INFO] [stdout] 57 + for name in package_list.packages.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/package.rs:143:25 [INFO] [stdout] | [INFO] [stdout] 143 | if let Some(ref build_command) = pkg.build.get(&platform) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 - if let Some(ref build_command) = pkg.build.get(&platform) { [INFO] [stdout] 143 + if let Some(build_command) = pkg.build.get(&platform) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/package.rs:419:9 [INFO] [stdout] | [INFO] [stdout] 419 | / if pkg.pkg_type == "system" && self.system_manager != SystemPackageManager::Unknown { [INFO] [stdout] 420 | | if self.system_manager.is_package_installed(&pkg.name)? { [INFO] [stdout] 421 | | return Ok(true); [INFO] [stdout] 422 | | } [INFO] [stdout] 423 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 419 ~ if pkg.pkg_type == "system" && self.system_manager != SystemPackageManager::Unknown [INFO] [stdout] 420 ~ && self.system_manager.is_package_installed(&pkg.name)? { [INFO] [stdout] 421 | return Ok(true); [INFO] [stdout] 422 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/package.rs:434:13 [INFO] [stdout] | [INFO] [stdout] 434 | / if lang_manager != LanguagePackageManager::Unknown { [INFO] [stdout] 435 | | if lang_manager.is_package_installed(&pkg.name)? { [INFO] [stdout] 436 | | return Ok(true); [INFO] [stdout] 437 | | } [INFO] [stdout] 438 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 434 ~ if lang_manager != LanguagePackageManager::Unknown [INFO] [stdout] 435 ~ && lang_manager.is_package_installed(&pkg.name)? { [INFO] [stdout] 436 | return Ok(true); [INFO] [stdout] 437 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/package.rs:600:25 [INFO] [stdout] | [INFO] [stdout] 600 | let file_name = download_url [INFO] [stdout] | _________________________^ [INFO] [stdout] 601 | | .split('/') [INFO] [stdout] 602 | | .last() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 602 - .last() [INFO] [stdout] 602 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/utils/deps.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/utils/deps.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | for (_pkg, deps) in package_requirements { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 93 - for (_pkg, deps) in package_requirements { [INFO] [stdout] 93 + for deps in package_requirements.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/utils/deps.rs:95:68 [INFO] [stdout] | [INFO] [stdout] 95 | let versions = version_map.entry(dep_req.name.clone()).or_insert_with(HashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/utils/deps.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | let major = parts.get(0).and_then(|s| s.parse().ok()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `version_parts.get(0)` [INFO] [stdout] --> src/utils/deps.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | let major = version_parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `version_parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/utils/system.rs:276:40 [INFO] [stdout] | [INFO] [stdout] 276 | if let Some(pkg) = line.split('/').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 276 - if let Some(pkg) = line.split('/').last() { [INFO] [stdout] 276 + if let Some(pkg) = line.split('/').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/utils/language.rs:30:49 [INFO] [stdout] | [INFO] [stdout] 30 | if Self::command_exists("pip3") { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 31 | | Self::Pip [INFO] [stdout] 32 | | } else if Self::command_exists("pip") { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/utils/language.rs:32:55 [INFO] [stdout] | [INFO] [stdout] 32 | } else if Self::command_exists("pip") { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 33 | | Self::Pip [INFO] [stdout] 34 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/utils/language.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | / match self { [INFO] [stdout] 327 | | Self::Go => { [INFO] [stdout] 328 | | // Go installs to GOPATH/bin, ensure it exists [INFO] [stdout] 329 | | if let Ok(gopath) = std::env::var("GOPATH") { [INFO] [stdout] ... | [INFO] [stdout] 334 | | _ => {} [INFO] [stdout] 335 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 326 ~ if self == &Self::Go { [INFO] [stdout] 327 + // Go installs to GOPATH/bin, ensure it exists [INFO] [stdout] 328 + if let Ok(gopath) = std::env::var("GOPATH") { [INFO] [stdout] 329 + let gobin = PathBuf::from(gopath).join("bin"); [INFO] [stdout] 330 + std::fs::create_dir_all(&gobin).ok(); [INFO] [stdout] 331 + } [INFO] [stdout] 332 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `Command { std: "docker" "inspect" "b82e0e56742912c53a44071b66dfa78ffeb81203dcb07c69ee3f9ead8cfddeb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b82e0e56742912c53a44071b66dfa78ffeb81203dcb07c69ee3f9ead8cfddeb5", kill_on_drop: false }` [INFO] [stdout] b82e0e56742912c53a44071b66dfa78ffeb81203dcb07c69ee3f9ead8cfddeb5