[INFO] cloning repository https://github.com/hub2/rustpoker
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hub2/rustpoker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhub2%2Frustpoker", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhub2%2Frustpoker'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 25fd2e6d2070a2766a00390a9ddcd0ad29980c3b
[INFO] linting hub2/rustpoker against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhub2%2Frustpoker" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/hub2/rustpoker
[INFO] finished tweaking git repo https://github.com/hub2/rustpoker
[INFO] tweaked toml for git repo https://github.com/hub2/rustpoker written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/hub2/rustpoker on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/hub2/rustpoker already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded strum v0.25.0
[INFO] [stderr]   Downloaded strum_macros v0.25.3
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] f3e1441c6d1b22b61ba98a70e1a6d92b210c2e744a0f394af3e0397a4294a159
[INFO] running `Command { std: "docker" "start" "-a" "f3e1441c6d1b22b61ba98a70e1a6d92b210c2e744a0f394af3e0397a4294a159", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "f3e1441c6d1b22b61ba98a70e1a6d92b210c2e744a0f394af3e0397a4294a159", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f3e1441c6d1b22b61ba98a70e1a6d92b210c2e744a0f394af3e0397a4294a159", kill_on_drop: false }`
[INFO] [stdout] f3e1441c6d1b22b61ba98a70e1a6d92b210c2e744a0f394af3e0397a4294a159
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] f2b58c27b8cbd05bcfe98178929be1c7610151353903f4e33e4d6fceb3bd8a6d
[INFO] running `Command { std: "docker" "start" "-a" "f2b58c27b8cbd05bcfe98178929be1c7610151353903f4e33e4d6fceb3bd8a6d", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.150
[INFO] [stderr]    Compiling rustversion v1.0.14
[INFO] [stderr]     Checking strum v0.25.0
[INFO] [stderr]    Compiling syn v2.0.38
[INFO] [stderr]     Checking getrandom v0.2.10
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]    Compiling strum_macros v0.25.3
[INFO] [stderr]     Checking poker v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: field `name` is never read
[INFO] [stdout]   --> src/pokerlogic/models.rs:63:9
[INFO] [stdout]    |
[INFO] [stdout] 62 | pub struct Player {
[INFO] [stdout]    |            ------ field in this struct
[INFO] [stdout] 63 |     pub name: String,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Player` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pokerlogic/logic.rs:72:5
[INFO] [stdout]    |
[INFO] [stdout] 72 | /     return PokerHand {
[INFO] [stdout] 73 | |         poker_hand: PokerHandEnum::HighCard,
[INFO] [stdout] 74 | |         cards: vec![cards.last().unwrap().clone()],
[INFO] [stdout] 75 | |     };
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 ~     PokerHand {
[INFO] [stdout] 73 +         poker_hand: PokerHandEnum::HighCard,
[INFO] [stdout] 74 +         cards: vec![cards.last().unwrap().clone()],
[INFO] [stdout] 75 ~     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/pokerlogic/logic.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 |     cards.sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 18 -     cards.sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 18 +     cards.sort_by_key(|a| a.rank.value());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/pokerlogic/logic.rs:78:25
[INFO] [stdout]    |
[INFO] [stdout] 78 | pub fn poker(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 78 ~ pub fn poker(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 79 |     let mut poker_hand = PokerHand {
[INFO] [stdout] ...
[INFO] [stdout] 82 |     };
[INFO] [stdout] 83 ~     let mut cards = tmp_cards.to_owned();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:110:29
[INFO] [stdout]     |
[INFO] [stdout] 110 | pub fn fullhouse(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 110 ~ pub fn fullhouse(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 111 |     let mut poker_hand = PokerHand {
[INFO] [stdout] ...
[INFO] [stdout] 114 |     };
[INFO] [stdout] 115 ~     let mut cards = tmp_cards.to_owned();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:133:25
[INFO] [stdout]     |
[INFO] [stdout] 133 | pub fn flush(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 133 - pub fn flush(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 133 + pub fn flush(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/pokerlogic/logic.rs:177:16
[INFO] [stdout]     |
[INFO] [stdout] 177 |             if !(cards[i + idx].rank.value() + 1 == cards[i + idx + 1].rank.value()) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(cards[i + idx].rank.value() + 1 != cards[i + idx + 1].rank.value())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:154:28
[INFO] [stdout]     |
[INFO] [stdout] 154 | pub fn straight(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 154 ~ pub fn straight(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 155 |     let mut poker_hand = PokerHand {
[INFO] [stdout] ...
[INFO] [stdout] 158 |     };
[INFO] [stdout] 159 ~     let mut cards = tmp_cards.to_owned();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `idx` is only used to index `cards`
[INFO] [stdout]    --> src/pokerlogic/logic.rs:167:20
[INFO] [stdout]     |
[INFO] [stdout] 167 |         for idx in 0..5 {
[INFO] [stdout]     |                    ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 167 -         for idx in 0..5 {
[INFO] [stdout] 167 +         for <item> in cards.iter().take(5) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:194:24
[INFO] [stdout]     |
[INFO] [stdout] 194 | pub fn four(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 194 - pub fn four(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 194 + pub fn four(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:222:25
[INFO] [stdout]     |
[INFO] [stdout] 222 | pub fn three(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 222 - pub fn three(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 222 + pub fn three(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:245:28
[INFO] [stdout]     |
[INFO] [stdout] 245 | pub fn two_pair(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 245 - pub fn two_pair(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 245 + pub fn two_pair(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:275:24
[INFO] [stdout]     |
[INFO] [stdout] 275 | pub fn pair(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 275 - pub fn pair(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 275 + pub fn pair(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:53:5
[INFO] [stdout]    |
[INFO] [stdout] 53 |     println!("");
[INFO] [stdout]    |     ^^^^^^^^^--^
[INFO] [stdout]    |              |
[INFO] [stdout]    |              help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 |     println!("");
[INFO] [stdout]    |     ^^^^^^^^^--^
[INFO] [stdout]    |              |
[INFO] [stdout]    |              help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:65:5
[INFO] [stdout]    |
[INFO] [stdout] 65 |     println!("");
[INFO] [stdout]    |     ^^^^^^^^^--^
[INFO] [stdout]    |              |
[INFO] [stdout]    |              help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/main.rs:75:9
[INFO] [stdout]    |
[INFO] [stdout] 75 | /         best.cards
[INFO] [stdout] 76 | |             .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]    | |________________________________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 76 -             .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 76 +             .sort_by_key(|a| a.rank.value());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/main.rs:77:9
[INFO] [stdout]    |
[INFO] [stdout] 77 | /         best2
[INFO] [stdout] 78 | |             .cards
[INFO] [stdout] 79 | |             .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]    | |________________________________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 79 -             .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 79 +             .sort_by_key(|a| a.rank.value());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> src/main.rs:104:17
[INFO] [stdout]     |
[INFO] [stdout] 104 | /                 player1
[INFO] [stdout] 105 | |                     .cards
[INFO] [stdout] 106 | |                     .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]     | |________________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 106 -                     .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 106 +                     .sort_by_key(|a| a.rank.value());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> src/main.rs:107:17
[INFO] [stdout]     |
[INFO] [stdout] 107 | /                 player2
[INFO] [stdout] 108 | |                     .cards
[INFO] [stdout] 109 | |                     .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]     | |________________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 109 -                     .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 109 +                     .sort_by_key(|a| a.rank.value());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `name` is never read
[INFO] [stdout]   --> src/pokerlogic/models.rs:63:9
[INFO] [stdout]    |
[INFO] [stdout] 62 | pub struct Player {
[INFO] [stdout]    |            ------ field in this struct
[INFO] [stdout] 63 |     pub name: String,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Player` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pokerlogic/logic.rs:72:5
[INFO] [stdout]    |
[INFO] [stdout] 72 | /     return PokerHand {
[INFO] [stdout] 73 | |         poker_hand: PokerHandEnum::HighCard,
[INFO] [stdout] 74 | |         cards: vec![cards.last().unwrap().clone()],
[INFO] [stdout] 75 | |     };
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 ~     PokerHand {
[INFO] [stdout] 73 +         poker_hand: PokerHandEnum::HighCard,
[INFO] [stdout] 74 +         cards: vec![cards.last().unwrap().clone()],
[INFO] [stdout] 75 ~     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/pokerlogic/logic.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 |     cards.sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 18 -     cards.sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 18 +     cards.sort_by_key(|a| a.rank.value());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/pokerlogic/logic.rs:78:25
[INFO] [stdout]    |
[INFO] [stdout] 78 | pub fn poker(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 78 ~ pub fn poker(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 79 |     let mut poker_hand = PokerHand {
[INFO] [stdout] ...
[INFO] [stdout] 82 |     };
[INFO] [stdout] 83 ~     let mut cards = tmp_cards.to_owned();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:110:29
[INFO] [stdout]     |
[INFO] [stdout] 110 | pub fn fullhouse(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 110 ~ pub fn fullhouse(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 111 |     let mut poker_hand = PokerHand {
[INFO] [stdout] ...
[INFO] [stdout] 114 |     };
[INFO] [stdout] 115 ~     let mut cards = tmp_cards.to_owned();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:133:25
[INFO] [stdout]     |
[INFO] [stdout] 133 | pub fn flush(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 133 - pub fn flush(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 133 + pub fn flush(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/pokerlogic/logic.rs:177:16
[INFO] [stdout]     |
[INFO] [stdout] 177 |             if !(cards[i + idx].rank.value() + 1 == cards[i + idx + 1].rank.value()) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(cards[i + idx].rank.value() + 1 != cards[i + idx + 1].rank.value())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:154:28
[INFO] [stdout]     |
[INFO] [stdout] 154 | pub fn straight(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 154 ~ pub fn straight(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 155 |     let mut poker_hand = PokerHand {
[INFO] [stdout] ...
[INFO] [stdout] 158 |     };
[INFO] [stdout] 159 ~     let mut cards = tmp_cards.to_owned();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `idx` is only used to index `cards`
[INFO] [stdout]    --> src/pokerlogic/logic.rs:167:20
[INFO] [stdout]     |
[INFO] [stdout] 167 |         for idx in 0..5 {
[INFO] [stdout]     |                    ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 167 -         for idx in 0..5 {
[INFO] [stdout] 167 +         for <item> in cards.iter().take(5) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:194:24
[INFO] [stdout]     |
[INFO] [stdout] 194 | pub fn four(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 194 - pub fn four(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 194 + pub fn four(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:222:25
[INFO] [stdout]     |
[INFO] [stdout] 222 | pub fn three(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 222 - pub fn three(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 222 + pub fn three(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:245:28
[INFO] [stdout]     |
[INFO] [stdout] 245 | pub fn two_pair(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 245 - pub fn two_pair(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 245 + pub fn two_pair(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pokerlogic/logic.rs:275:24
[INFO] [stdout]     |
[INFO] [stdout] 275 | pub fn pair(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 275 - pub fn pair(tmp_cards: &mut Vec<Card>) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout] 275 + pub fn pair(tmp_cards: &mut [Card]) -> Result<PokerHand, NotFoundError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:53:5
[INFO] [stdout]    |
[INFO] [stdout] 53 |     println!("");
[INFO] [stdout]    |     ^^^^^^^^^--^
[INFO] [stdout]    |              |
[INFO] [stdout]    |              help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 |     println!("");
[INFO] [stdout]    |     ^^^^^^^^^--^
[INFO] [stdout]    |              |
[INFO] [stdout]    |              help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:65:5
[INFO] [stdout]    |
[INFO] [stdout] 65 |     println!("");
[INFO] [stdout]    |     ^^^^^^^^^--^
[INFO] [stdout]    |              |
[INFO] [stdout]    |              help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/main.rs:75:9
[INFO] [stdout]    |
[INFO] [stdout] 75 | /         best.cards
[INFO] [stdout] 76 | |             .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]    | |________________________________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 76 -             .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 76 +             .sort_by_key(|a| a.rank.value());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/main.rs:77:9
[INFO] [stdout]    |
[INFO] [stdout] 77 | /         best2
[INFO] [stdout] 78 | |             .cards
[INFO] [stdout] 79 | |             .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]    | |________________________________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 79 -             .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 79 +             .sort_by_key(|a| a.rank.value());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> src/main.rs:104:17
[INFO] [stdout]     |
[INFO] [stdout] 104 | /                 player1
[INFO] [stdout] 105 | |                     .cards
[INFO] [stdout] 106 | |                     .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]     | |________________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 106 -                     .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 106 +                     .sort_by_key(|a| a.rank.value());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> src/main.rs:107:17
[INFO] [stdout]     |
[INFO] [stdout] 107 | /                 player2
[INFO] [stdout] 108 | |                     .cards
[INFO] [stdout] 109 | |                     .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout]     | |________________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 109 -                     .sort_by(|a, b| a.rank.value().cmp(&b.rank.value()));
[INFO] [stdout] 109 +                     .sort_by_key(|a| a.rank.value());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.21s
[INFO] running `Command { std: "docker" "inspect" "f2b58c27b8cbd05bcfe98178929be1c7610151353903f4e33e4d6fceb3bd8a6d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f2b58c27b8cbd05bcfe98178929be1c7610151353903f4e33e4d6fceb3bd8a6d", kill_on_drop: false }`
[INFO] [stdout] f2b58c27b8cbd05bcfe98178929be1c7610151353903f4e33e4d6fceb3bd8a6d