[INFO] cloning repository https://github.com/hub2/bf.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hub2/bf.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhub2%2Fbf.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhub2%2Fbf.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8b9d861c4b956a5b705336bcbfb00bbac21eca92 [INFO] linting hub2/bf.rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhub2%2Fbf.rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hub2/bf.rs [INFO] finished tweaking git repo https://github.com/hub2/bf.rs [INFO] tweaked toml for git repo https://github.com/hub2/bf.rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hub2/bf.rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hub2/bf.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 39cc58261e6e6c24d5ded137e349d957c67d04ef891204cbef2dbfeb75bd8a8c [INFO] running `Command { std: "docker" "start" "-a" "39cc58261e6e6c24d5ded137e349d957c67d04ef891204cbef2dbfeb75bd8a8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "39cc58261e6e6c24d5ded137e349d957c67d04ef891204cbef2dbfeb75bd8a8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39cc58261e6e6c24d5ded137e349d957c67d04ef891204cbef2dbfeb75bd8a8c", kill_on_drop: false }` [INFO] [stdout] 39cc58261e6e6c24d5ded137e349d957c67d04ef891204cbef2dbfeb75bd8a8c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 57e3b1760d5d3626248d59f706e497907e1dd358fa1a0f1433cbeb22509fc78b [INFO] running `Command { std: "docker" "start" "-a" "57e3b1760d5d3626248d59f706e497907e1dd358fa1a0f1433cbeb22509fc78b", kill_on_drop: false }` [INFO] [stderr] Checking brainfuck v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | if !top.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `top.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 58 | if !top.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `top.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 47 | if !top.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 48 | if *top.unwrap() != codeptr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 58 | if !top.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 59 | codeptr = top.unwrap() - 1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | fn run(code: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn run(code: &String) { [INFO] [stdout] 14 + fn run(code: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`char` -> `char`) [INFO] [stdout] --> src/main.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | if current_char as char == '[' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `current_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`char` -> `char`) [INFO] [stdout] --> src/main.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 37 | if current_char as char == ']' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `current_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | memory[memoryptr] = std::io::stdin() [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 70 | | .bytes() [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/main.rs:73:33 [INFO] [stdout] | [INFO] [stdout] 73 | .map(|byte| byte as u8) [INFO] [stdout] | ^^^^^^^^^^ help: try: `byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | if !top.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `top.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 58 | if !top.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `top.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 47 | if !top.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 48 | if *top.unwrap() != codeptr { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 58 | if !top.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 59 | codeptr = top.unwrap() - 1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | fn run(code: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn run(code: &String) { [INFO] [stdout] 14 + fn run(code: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`char` -> `char`) [INFO] [stdout] --> src/main.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | if current_char as char == '[' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `current_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`char` -> `char`) [INFO] [stdout] --> src/main.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 37 | if current_char as char == ']' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `current_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | memory[memoryptr] = std::io::stdin() [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 70 | | .bytes() [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/main.rs:73:33 [INFO] [stdout] | [INFO] [stdout] 73 | .map(|byte| byte as u8) [INFO] [stdout] | ^^^^^^^^^^ help: try: `byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s [INFO] running `Command { std: "docker" "inspect" "57e3b1760d5d3626248d59f706e497907e1dd358fa1a0f1433cbeb22509fc78b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57e3b1760d5d3626248d59f706e497907e1dd358fa1a0f1433cbeb22509fc78b", kill_on_drop: false }` [INFO] [stdout] 57e3b1760d5d3626248d59f706e497907e1dd358fa1a0f1433cbeb22509fc78b