[INFO] cloning repository https://github.com/hsnmtw/erp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hsnmtw/erp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhsnmtw%2Ferp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhsnmtw%2Ferp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cb05d03c36f07882c79ec8929f4a59e3a84448e0 [INFO] linting hsnmtw/erp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhsnmtw%2Ferp" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hsnmtw/erp [INFO] finished tweaking git repo https://github.com/hsnmtw/erp [INFO] tweaked toml for git repo https://github.com/hsnmtw/erp written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hsnmtw/erp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hsnmtw/erp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded recursive v0.1.1 [INFO] [stderr] Downloaded psm v0.1.28 [INFO] [stderr] Downloaded stacker v0.1.22 [INFO] [stderr] Downloaded if_chain v1.0.3 [INFO] [stderr] Downloaded nanosql_macros v0.10.0 [INFO] [stderr] Downloaded deluxe-core v0.5.0 [INFO] [stderr] Downloaded deluxe-macros v0.5.0 [INFO] [stderr] Downloaded ar_archive_writer v0.2.0 [INFO] [stderr] Downloaded deluxe v0.5.0 [INFO] [stderr] Downloaded nanosql v0.10.0 [INFO] [stderr] Downloaded rusqlite v0.33.0 [INFO] [stderr] Downloaded recursive-proc-macro-impl v0.1.1 [INFO] [stderr] Downloaded cc v1.2.44 [INFO] [stderr] Downloaded syn v2.0.108 [INFO] [stderr] Downloaded sqlparser v0.54.0 [INFO] [stderr] Downloaded libsqlite3-sys v0.31.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a58fbe4868addb35dae922e9c4b11dad2f0ac14d0a2b0e0f2bcc08dee9049494 [INFO] running `Command { std: "docker" "start" "-a" "a58fbe4868addb35dae922e9c4b11dad2f0ac14d0a2b0e0f2bcc08dee9049494", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a58fbe4868addb35dae922e9c4b11dad2f0ac14d0a2b0e0f2bcc08dee9049494", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a58fbe4868addb35dae922e9c4b11dad2f0ac14d0a2b0e0f2bcc08dee9049494", kill_on_drop: false }` [INFO] [stdout] a58fbe4868addb35dae922e9c4b11dad2f0ac14d0a2b0e0f2bcc08dee9049494 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90a722475b3d208a962a9d3d9ef8dea8806ef4cc0ec5e1acf2d2573823b778fc [INFO] running `Command { std: "docker" "start" "-a" "90a722475b3d208a962a9d3d9ef8dea8806ef4cc0ec5e1acf2d2573823b778fc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling find-msvc-tools v0.1.4 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling hashbrown v0.16.0 [INFO] [stderr] Compiling equivalent v1.0.2 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling toml_datetime v0.6.11 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Compiling arrayvec v0.7.6 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling libsqlite3-sys v0.31.0 [INFO] [stderr] Compiling if_chain v1.0.3 [INFO] [stderr] Compiling log v0.4.28 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling cc v1.2.44 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling object v0.32.2 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking rusqlite v0.33.0 [INFO] [stderr] Compiling indexmap v2.12.0 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling stacker v0.1.22 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling ar_archive_writer v0.2.0 [INFO] [stderr] Compiling psm v0.1.28 [INFO] [stderr] Compiling deluxe-core v0.5.0 [INFO] [stderr] Compiling recursive-proc-macro-impl v0.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling recursive v0.1.1 [INFO] [stderr] Compiling sqlparser v0.54.0 [INFO] [stderr] Compiling deluxe-macros v0.5.0 [INFO] [stderr] Compiling deluxe v0.5.0 [INFO] [stderr] Compiling nanosql_macros v0.10.0 [INFO] [stderr] Checking nanosql v0.10.0 [INFO] [stderr] Checking erp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/engines/db/server.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/engines/db/server.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/engines/db/sql.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | pub const HOME_DIR : &'static str = "./databases"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/engines/db/server.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/engines/db/server.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/engines/db/sql.rs:5:23 [INFO] [stdout] | [INFO] [stdout] 5 | pub const HOME_DIR : &'static str = "./databases"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `name` are never read [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 42 | struct Person { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 43 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 44 | name: String [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Person` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/engines/db/tokens.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 104 | impl Token { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 105 | pub fn new(kind: &'static TokenKinds, val : String) -> Token { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `source`, `sql`, and `pos` are never read [INFO] [stdout] --> src/engines/db/lexer.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Lexer { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 4 | pub tokens : Vec, [INFO] [stdout] 5 | source : Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 6 | sql : String, [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | pos : usize [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/engines/db/lexer.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl Lexer { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 12 | fn current(&self) -> char { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn to_string(&self) -> &str { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | fn next(&self) -> char { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | fn has_next(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | fn done(&self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fn advance(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 262 | pub fn new(source : &str) -> Lexer { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `join` is never used [INFO] [stdout] --> src/engines/db/grammer.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn join(sep : &str, values : &[&T]) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_error` is never used [INFO] [stdout] --> src/engines/db/grammer.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn get_error(db: &str, lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `validate_use` is never used [INFO] [stdout] --> src/engines/db/grammer.rs:99:4 [INFO] [stdout] | [INFO] [stdout] 99 | fn validate_use(lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `HOME_DIR` is never used [INFO] [stdout] --> src/engines/db/sql.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub const HOME_DIR : &'static str = "./databases"; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_sql` is never used [INFO] [stdout] --> src/engines/db/sql.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn execute_sql(db: &str, lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_create` is never used [INFO] [stdout] --> src/engines/db/sql.rs:22:4 [INFO] [stdout] | [INFO] [stdout] 22 | fn execute_create(lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_create_database` is never used [INFO] [stdout] --> src/engines/db/sql.rs:41:4 [INFO] [stdout] | [INFO] [stdout] 41 | fn execute_create_database(lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_show` is never used [INFO] [stdout] --> src/engines/db/sql.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn execute_show(lex: &Lexer, db : &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_views` is never used [INFO] [stdout] --> src/engines/db/sql.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 68 | fn get_views(db : &str) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_tables` is never used [INFO] [stdout] --> src/engines/db/sql.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | fn get_tables(db : &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_databases` is never used [INFO] [stdout] --> src/engines/db/sql.rs:78:4 [INFO] [stdout] | [INFO] [stdout] 78 | fn get_databases() -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `list_fs` is never used [INFO] [stdout] --> src/engines/db/filemgr.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn list_fs(pth: &str, fstype : &FsType) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SELECT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | SELECT = 0, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Select` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UPDATE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | UPDATE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Update` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INSERT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | INSERT , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Insert` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INTO` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | INTO , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VALUES` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | VALUES , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DELETE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | DELETE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Delete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CREATE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | CREATE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Create` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TABLE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | TABLE , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COLUMN` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | COLUMN , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ALTER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | ALTER , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Alter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PRIMARY` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | PRIMARY , [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Primary` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `KEY` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | KEY , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | NOT , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Not` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NULL` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | NULL , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CASE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | CASE , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Case` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WHEN` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | WHEN , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `When` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THEN` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | THEN , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Then` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `END` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | END , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `End` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JOIN` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | JOIN , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Join` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FROM` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | FROM , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `From` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | LEFT , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | RIGHT , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WHERE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | WHERE , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Where` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | AND , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COUNT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | COUNT , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUM` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | SUM , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AVG` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | AVG , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Avg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASTRISKS` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | ASTRISKS , [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Astrisks` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DOT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | DOT , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GROUP` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | GROUP , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Group` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORDER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | ORDER , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Order` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASC` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | ASC , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Asc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DESC` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | DESC , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Desc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DISTINCT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | DISTINCT , [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Distinct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LIMIT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | LIMIT , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OFFSET` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | OFFSET , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHOW` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | SHOW , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Show` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | USE , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Use` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXIT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | EXIT , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Exit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEFAULT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | DEFAULT , [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UNIQUE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | UNIQUE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Unique` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `QUIT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | QUIT , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Quit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATABASES` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | DATABASES , [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Databases` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TABLES` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | TABLES , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Tables` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VIEWES` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | VIEWES , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Viewes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATABASE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | DATABASE , [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Database` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VIEW` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | VIEW , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `View` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HAVING` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | HAVING , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Having` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FORMAT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | FORMAT , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COLON` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | COLON , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Colon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IDENTIFIER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | IDENTIFIER , [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Identifier` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NUMBER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | NUMBER , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLUS` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | PLUS , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Plus` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DIVIDE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | DIVIDE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Divide` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MINUS` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | MINUS , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Minus` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | STRING , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PARAMETER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | PARAMETER , [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Parameter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PERIOD` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | PERIOD , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Period` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EQUALS` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | EQUALS , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Equals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `engines::db::tokens::Token` [INFO] [stdout] --> src/engines/db/tokens.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / pub fn to_string(&self) -> String { [INFO] [stdout] ... | [INFO] [stdout] 115 | | format!("{:15} ({})", get_token_name(self.kind), self.val) [INFO] [stdout] 116 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `engines::db::tokens::Token` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/engines/db/lexer.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | if (!(is_bracket && c==' ') && !(c=='_'||c.is_ascii_alphanumeric())) || (is_bracket && self.current() == ']') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(c=='_' || c.is_ascii_alphanumeric() || is_bracket && c==' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/engines/db/grammer.rs:73:31 [INFO] [stdout] | [INFO] [stdout] 73 | let curr = lex.tokens[idx+0].kind; [INFO] [stdout] | ^^^^^ help: consider reducing it to: `idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/engines/db/grammer.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if accepted_next_term.len()> 0 && !accepted_next_term.contains(&next) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!accepted_next_term.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/grammer.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | / match lex.tokens[0].kind { [INFO] [stdout] 86 | | &TokenKinds::SELECT => validate_select(lex), [INFO] [stdout] 87 | | &TokenKinds::UPDATE => validate_update(lex), [INFO] [stdout] 88 | | &TokenKinds::INSERT => validate_insert(lex), [INFO] [stdout] ... | [INFO] [stdout] 93 | | _ => None [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 85 ~ match *lex.tokens[0].kind { [INFO] [stdout] 86 ~ TokenKinds::SELECT => validate_select(lex), [INFO] [stdout] 87 ~ TokenKinds::UPDATE => validate_update(lex), [INFO] [stdout] 88 ~ TokenKinds::INSERT => validate_insert(lex), [INFO] [stdout] 89 ~ TokenKinds::DELETE => validate_delete(lex), [INFO] [stdout] 90 ~ TokenKinds::CREATE => validate_create(db, lex), [INFO] [stdout] 91 ~ TokenKinds::SHOW => validate_show(lex), [INFO] [stdout] 92 ~ TokenKinds::USE => validate_use(lex), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/engines/db/grammer.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 106 | || lex.tokens[1].val.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lex.tokens[1].val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/grammer.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | / match lex.tokens[1].kind { [INFO] [stdout] 186 | | &TokenKinds::DATABASE => validate_create_database(lex), [INFO] [stdout] 187 | | &TokenKinds::TABLE => validate_create_table(db, lex), [INFO] [stdout] 188 | | &TokenKinds::VIEW => validate_create_view(db, lex), [INFO] [stdout] 189 | | _ => Some(format!("expected {:?} ... [INFO] [stdout] 190 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 185 ~ match *lex.tokens[1].kind { [INFO] [stdout] 186 ~ TokenKinds::DATABASE => validate_create_database(lex), [INFO] [stdout] 187 ~ TokenKinds::TABLE => validate_create_table(db, lex), [INFO] [stdout] 188 ~ TokenKinds::VIEW => validate_create_view(db, lex), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:20 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Int` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:25 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLOAT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:30 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Float` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATETIME` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:37 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Datetime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:47 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Date` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TIME` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:53 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VARCHAR` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:59 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Varchar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NVARCHAR` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:68 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Nvarchar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/engines/db/grammer.rs:249:23 [INFO] [stdout] | [INFO] [stdout] 249 | let dtp = format!("{}", lex.tokens[idx+1].val.to_uppercase()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `lex.tokens[idx+1].val.to_uppercase().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/engines/db/grammer.rs:286:38 [INFO] [stdout] | [INFO] [stdout] 286 | coldef.default = format!("{}", lex.tokens[idx+1].val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `lex.tokens[idx+1].val.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/engines/db/server.rs:4:27 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn db_query(sql: &str) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/engines/db/server.rs:38:25 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn start_db_server() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/engines/db/sql.rs:11:47 [INFO] [stdout] | [INFO] [stdout] 11 | if let Some(err) = grammer::get_error(db, &lex) { [INFO] [stdout] | ^^^^ help: change this to: `lex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/sql.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / match lex.tokens[0].kind { [INFO] [stdout] 16 | | &TokenKinds::SHOW => execute_show(lex,db), [INFO] [stdout] 17 | | &TokenKinds::CREATE => execute_create(lex), [INFO] [stdout] 18 | | _ => None [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 15 ~ match *lex.tokens[0].kind { [INFO] [stdout] 16 ~ TokenKinds::SHOW => execute_show(lex,db), [INFO] [stdout] 17 ~ TokenKinds::CREATE => execute_create(lex), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/sql.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / match lex.tokens[1].kind { [INFO] [stdout] 24 | | &TokenKinds::DATABASE => execute_create_database(lex), [INFO] [stdout] 25 | | &TokenKinds::TABLE => execute_create_table(lex), [INFO] [stdout] 26 | | &TokenKinds::VIEW => execute_create_view(lex), [INFO] [stdout] 27 | | _ => None [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 23 ~ match *lex.tokens[1].kind { [INFO] [stdout] 24 ~ TokenKinds::DATABASE => execute_create_database(lex), [INFO] [stdout] 25 ~ TokenKinds::TABLE => execute_create_table(lex), [INFO] [stdout] 26 ~ TokenKinds::VIEW => execute_create_view(lex), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/sql.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | / match lex.tokens[1].kind { [INFO] [stdout] 61 | | &TokenKinds::DATABASES => get_databases(), [INFO] [stdout] 62 | | &TokenKinds::TABLES => get_tables(db), [INFO] [stdout] 63 | | &TokenKinds::VIEWES => get_views(db), [INFO] [stdout] 64 | | _ => Some(format!("ERROR: unknown command SHOW {:?}", lex.tokens[1].kind)) [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 60 ~ match *lex.tokens[1].kind { [INFO] [stdout] 61 ~ TokenKinds::DATABASES => get_databases(), [INFO] [stdout] 62 ~ TokenKinds::TABLES => get_tables(db), [INFO] [stdout] 63 ~ TokenKinds::VIEWES => get_views(db), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLDR` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/filemgr.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | FLDR, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Fldr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FILE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/filemgr.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | FILE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `File` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BOTH` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/filemgr.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | BOTH [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Both` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/filemgr.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | / match fstype { [INFO] [stdout] 17 | | &FsType::FLDR if metadata.is_dir() => folders.push(path), [INFO] [stdout] 18 | | &FsType::FILE if metadata.is_file() => folders.push(path), [INFO] [stdout] 19 | | &FsType::BOTH if metadata.is_dir() || metadata.is_file() => folders.push(path), [INFO] [stdout] 20 | | _ => {} [INFO] [stdout] 21 | | }; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 16 ~ match *fstype { [INFO] [stdout] 17 ~ FsType::FLDR if metadata.is_dir() => folders.push(path), [INFO] [stdout] 18 ~ FsType::FILE if metadata.is_file() => folders.push(path), [INFO] [stdout] 19 ~ FsType::BOTH if metadata.is_dir() || metadata.is_file() => folders.push(path), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / for person in rows { [INFO] [stdout] 61 | | if let Ok(p) = person { [INFO] [stdout] 62 | | println!("{:?}",p); [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | / if let Ok(p) = person { [INFO] [stdout] 62 | | println!("{:?}",p); [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ for p in rows.flatten() { [INFO] [stdout] 61 + println!("{:?}",p); [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `name` are never read [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 42 | struct Person { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 43 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 44 | name: String [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Person` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/engines/db/tokens.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 104 | impl Token { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 105 | pub fn new(kind: &'static TokenKinds, val : String) -> Token { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `source`, `sql`, and `pos` are never read [INFO] [stdout] --> src/engines/db/lexer.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Lexer { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 4 | pub tokens : Vec, [INFO] [stdout] 5 | source : Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 6 | sql : String, [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | pos : usize [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/engines/db/lexer.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl Lexer { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 12 | fn current(&self) -> char { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn to_string(&self) -> &str { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | fn next(&self) -> char { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | fn has_next(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | fn done(&self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fn advance(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 262 | pub fn new(source : &str) -> Lexer { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `join` is never used [INFO] [stdout] --> src/engines/db/grammer.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn join(sep : &str, values : &[&T]) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_error` is never used [INFO] [stdout] --> src/engines/db/grammer.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn get_error(db: &str, lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `validate_use` is never used [INFO] [stdout] --> src/engines/db/grammer.rs:99:4 [INFO] [stdout] | [INFO] [stdout] 99 | fn validate_use(lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `HOME_DIR` is never used [INFO] [stdout] --> src/engines/db/sql.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub const HOME_DIR : &'static str = "./databases"; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_sql` is never used [INFO] [stdout] --> src/engines/db/sql.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn execute_sql(db: &str, lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_create` is never used [INFO] [stdout] --> src/engines/db/sql.rs:22:4 [INFO] [stdout] | [INFO] [stdout] 22 | fn execute_create(lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_create_database` is never used [INFO] [stdout] --> src/engines/db/sql.rs:41:4 [INFO] [stdout] | [INFO] [stdout] 41 | fn execute_create_database(lex: &Lexer) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_show` is never used [INFO] [stdout] --> src/engines/db/sql.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn execute_show(lex: &Lexer, db : &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_views` is never used [INFO] [stdout] --> src/engines/db/sql.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 68 | fn get_views(db : &str) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_tables` is never used [INFO] [stdout] --> src/engines/db/sql.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | fn get_tables(db : &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_databases` is never used [INFO] [stdout] --> src/engines/db/sql.rs:78:4 [INFO] [stdout] | [INFO] [stdout] 78 | fn get_databases() -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `list_fs` is never used [INFO] [stdout] --> src/engines/db/filemgr.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn list_fs(pth: &str, fstype : &FsType) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SELECT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | SELECT = 0, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Select` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UPDATE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | UPDATE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Update` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INSERT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | INSERT , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Insert` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INTO` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | INTO , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Into` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VALUES` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | VALUES , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DELETE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | DELETE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Delete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CREATE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | CREATE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Create` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TABLE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | TABLE , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COLUMN` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | COLUMN , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ALTER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | ALTER , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Alter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PRIMARY` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | PRIMARY , [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Primary` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `KEY` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | KEY , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | NOT , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Not` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NULL` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | NULL , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CASE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | CASE , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Case` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WHEN` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | WHEN , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `When` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THEN` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | THEN , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Then` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `END` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | END , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `End` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JOIN` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | JOIN , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Join` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FROM` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | FROM , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `From` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | LEFT , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | RIGHT , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WHERE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | WHERE , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Where` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | AND , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COUNT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | COUNT , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUM` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | SUM , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AVG` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | AVG , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Avg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASTRISKS` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | ASTRISKS , [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Astrisks` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DOT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | DOT , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GROUP` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | GROUP , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Group` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORDER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | ORDER , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Order` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASC` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | ASC , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Asc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DESC` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | DESC , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Desc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DISTINCT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | DISTINCT , [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Distinct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LIMIT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | LIMIT , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OFFSET` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | OFFSET , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHOW` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | SHOW , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Show` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | USE , [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Use` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXIT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | EXIT , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Exit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEFAULT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | DEFAULT , [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UNIQUE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | UNIQUE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Unique` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `QUIT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | QUIT , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Quit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATABASES` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | DATABASES , [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Databases` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TABLES` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | TABLES , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Tables` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VIEWES` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | VIEWES , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Viewes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATABASE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | DATABASE , [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Database` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VIEW` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | VIEW , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `View` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HAVING` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | HAVING , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Having` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FORMAT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | FORMAT , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COLON` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | COLON , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Colon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IDENTIFIER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | IDENTIFIER , [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Identifier` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NUMBER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | NUMBER , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLUS` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | PLUS , [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Plus` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DIVIDE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | DIVIDE , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Divide` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MINUS` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | MINUS , [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Minus` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | STRING , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PARAMETER` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | PARAMETER , [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Parameter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PERIOD` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | PERIOD , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Period` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EQUALS` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/tokens.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | EQUALS , [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Equals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `engines::db::tokens::Token` [INFO] [stdout] --> src/engines/db/tokens.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / pub fn to_string(&self) -> String { [INFO] [stdout] ... | [INFO] [stdout] 115 | | format!("{:15} ({})", get_token_name(self.kind), self.val) [INFO] [stdout] 116 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `engines::db::tokens::Token` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/engines/db/lexer.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | if (!(is_bracket && c==' ') && !(c=='_'||c.is_ascii_alphanumeric())) || (is_bracket && self.current() == ']') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(c=='_' || c.is_ascii_alphanumeric() || is_bracket && c==' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/engines/db/grammer.rs:73:31 [INFO] [stdout] | [INFO] [stdout] 73 | let curr = lex.tokens[idx+0].kind; [INFO] [stdout] | ^^^^^ help: consider reducing it to: `idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/engines/db/grammer.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if accepted_next_term.len()> 0 && !accepted_next_term.contains(&next) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!accepted_next_term.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/grammer.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | / match lex.tokens[0].kind { [INFO] [stdout] 86 | | &TokenKinds::SELECT => validate_select(lex), [INFO] [stdout] 87 | | &TokenKinds::UPDATE => validate_update(lex), [INFO] [stdout] 88 | | &TokenKinds::INSERT => validate_insert(lex), [INFO] [stdout] ... | [INFO] [stdout] 93 | | _ => None [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 85 ~ match *lex.tokens[0].kind { [INFO] [stdout] 86 ~ TokenKinds::SELECT => validate_select(lex), [INFO] [stdout] 87 ~ TokenKinds::UPDATE => validate_update(lex), [INFO] [stdout] 88 ~ TokenKinds::INSERT => validate_insert(lex), [INFO] [stdout] 89 ~ TokenKinds::DELETE => validate_delete(lex), [INFO] [stdout] 90 ~ TokenKinds::CREATE => validate_create(db, lex), [INFO] [stdout] 91 ~ TokenKinds::SHOW => validate_show(lex), [INFO] [stdout] 92 ~ TokenKinds::USE => validate_use(lex), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/engines/db/grammer.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 106 | || lex.tokens[1].val.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lex.tokens[1].val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/grammer.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | / match lex.tokens[1].kind { [INFO] [stdout] 186 | | &TokenKinds::DATABASE => validate_create_database(lex), [INFO] [stdout] 187 | | &TokenKinds::TABLE => validate_create_table(db, lex), [INFO] [stdout] 188 | | &TokenKinds::VIEW => validate_create_view(db, lex), [INFO] [stdout] 189 | | _ => Some(format!("expected {:?} ... [INFO] [stdout] 190 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 185 ~ match *lex.tokens[1].kind { [INFO] [stdout] 186 ~ TokenKinds::DATABASE => validate_create_database(lex), [INFO] [stdout] 187 ~ TokenKinds::TABLE => validate_create_table(db, lex), [INFO] [stdout] 188 ~ TokenKinds::VIEW => validate_create_view(db, lex), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:20 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Int` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:25 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLOAT` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:30 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Float` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATETIME` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:37 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Datetime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DATE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:47 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Date` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TIME` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:53 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VARCHAR` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:59 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Varchar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NVARCHAR` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/grammer.rs:201:68 [INFO] [stdout] | [INFO] [stdout] 201 | pub enum DataType {INT, BIT, FLOAT, DATETIME, DATE, TIME, VARCHAR, NVARCHAR,} [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Nvarchar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/engines/db/grammer.rs:249:23 [INFO] [stdout] | [INFO] [stdout] 249 | let dtp = format!("{}", lex.tokens[idx+1].val.to_uppercase()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `lex.tokens[idx+1].val.to_uppercase().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/engines/db/grammer.rs:286:38 [INFO] [stdout] | [INFO] [stdout] 286 | coldef.default = format!("{}", lex.tokens[idx+1].val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `lex.tokens[idx+1].val.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/engines/db/server.rs:4:27 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn db_query(sql: &str) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/engines/db/server.rs:38:25 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn start_db_server() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/engines/db/sql.rs:11:47 [INFO] [stdout] | [INFO] [stdout] 11 | if let Some(err) = grammer::get_error(db, &lex) { [INFO] [stdout] | ^^^^ help: change this to: `lex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/sql.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / match lex.tokens[0].kind { [INFO] [stdout] 16 | | &TokenKinds::SHOW => execute_show(lex,db), [INFO] [stdout] 17 | | &TokenKinds::CREATE => execute_create(lex), [INFO] [stdout] 18 | | _ => None [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 15 ~ match *lex.tokens[0].kind { [INFO] [stdout] 16 ~ TokenKinds::SHOW => execute_show(lex,db), [INFO] [stdout] 17 ~ TokenKinds::CREATE => execute_create(lex), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/sql.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / match lex.tokens[1].kind { [INFO] [stdout] 24 | | &TokenKinds::DATABASE => execute_create_database(lex), [INFO] [stdout] 25 | | &TokenKinds::TABLE => execute_create_table(lex), [INFO] [stdout] 26 | | &TokenKinds::VIEW => execute_create_view(lex), [INFO] [stdout] 27 | | _ => None [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 23 ~ match *lex.tokens[1].kind { [INFO] [stdout] 24 ~ TokenKinds::DATABASE => execute_create_database(lex), [INFO] [stdout] 25 ~ TokenKinds::TABLE => execute_create_table(lex), [INFO] [stdout] 26 ~ TokenKinds::VIEW => execute_create_view(lex), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/sql.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | / match lex.tokens[1].kind { [INFO] [stdout] 61 | | &TokenKinds::DATABASES => get_databases(), [INFO] [stdout] 62 | | &TokenKinds::TABLES => get_tables(db), [INFO] [stdout] 63 | | &TokenKinds::VIEWES => get_views(db), [INFO] [stdout] 64 | | _ => Some(format!("ERROR: unknown command SHOW {:?}", lex.tokens[1].kind)) [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 60 ~ match *lex.tokens[1].kind { [INFO] [stdout] 61 ~ TokenKinds::DATABASES => get_databases(), [INFO] [stdout] 62 ~ TokenKinds::TABLES => get_tables(db), [INFO] [stdout] 63 ~ TokenKinds::VIEWES => get_views(db), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLDR` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/filemgr.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | FLDR, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Fldr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FILE` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/filemgr.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | FILE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `File` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BOTH` contains a capitalized acronym [INFO] [stdout] --> src/engines/db/filemgr.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | BOTH [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Both` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/engines/db/filemgr.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | / match fstype { [INFO] [stdout] 17 | | &FsType::FLDR if metadata.is_dir() => folders.push(path), [INFO] [stdout] 18 | | &FsType::FILE if metadata.is_file() => folders.push(path), [INFO] [stdout] 19 | | &FsType::BOTH if metadata.is_dir() || metadata.is_file() => folders.push(path), [INFO] [stdout] 20 | | _ => {} [INFO] [stdout] 21 | | }; [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 16 ~ match *fstype { [INFO] [stdout] 17 ~ FsType::FLDR if metadata.is_dir() => folders.push(path), [INFO] [stdout] 18 ~ FsType::FILE if metadata.is_file() => folders.push(path), [INFO] [stdout] 19 ~ FsType::BOTH if metadata.is_dir() || metadata.is_file() => folders.push(path), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / for person in rows { [INFO] [stdout] 61 | | if let Ok(p) = person { [INFO] [stdout] 62 | | println!("{:?}",p); [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | / if let Ok(p) = person { [INFO] [stdout] 62 | | println!("{:?}",p); [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ for p in rows.flatten() { [INFO] [stdout] 61 + println!("{:?}",p); [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 38.41s [INFO] running `Command { std: "docker" "inspect" "90a722475b3d208a962a9d3d9ef8dea8806ef4cc0ec5e1acf2d2573823b778fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90a722475b3d208a962a9d3d9ef8dea8806ef4cc0ec5e1acf2d2573823b778fc", kill_on_drop: false }` [INFO] [stdout] 90a722475b3d208a962a9d3d9ef8dea8806ef4cc0ec5e1acf2d2573823b778fc