[INFO] cloning repository https://github.com/hollow-owl/rust-edn [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hollow-owl/rust-edn" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhollow-owl%2Frust-edn", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhollow-owl%2Frust-edn'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cb3b242f1f948036e7e6a55afb462021cc66c8ba [INFO] linting hollow-owl/rust-edn against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhollow-owl%2Frust-edn" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hollow-owl/rust-edn [INFO] finished tweaking git repo https://github.com/hollow-owl/rust-edn [INFO] tweaked toml for git repo https://github.com/hollow-owl/rust-edn written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hollow-owl/rust-edn on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hollow-owl/rust-edn already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded term v0.2.14 [INFO] [stderr] Downloaded bigdecimal v0.4.7 [INFO] [stderr] Downloaded ordermap v0.5.5 [INFO] [stderr] Downloaded text-diff v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ce25784c9c43883c659e2f2ad292f854cc13e47688a93f12b0a5a86978cfe79b [INFO] running `Command { std: "docker" "start" "-a" "ce25784c9c43883c659e2f2ad292f854cc13e47688a93f12b0a5a86978cfe79b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ce25784c9c43883c659e2f2ad292f854cc13e47688a93f12b0a5a86978cfe79b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce25784c9c43883c659e2f2ad292f854cc13e47688a93f12b0a5a86978cfe79b", kill_on_drop: false }` [INFO] [stdout] ce25784c9c43883c659e2f2ad292f854cc13e47688a93f12b0a5a86978cfe79b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 234ab04d786caa49a46567d46161f8920223b34c555e84b65936551ebd8faf66 [INFO] running `Command { std: "docker" "start" "-a" "234ab04d786caa49a46567d46161f8920223b34c555e84b65936551ebd8faf66", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Compiling once_cell v1.20.3 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling bigdecimal v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking ordermap v0.5.5 [INFO] [stderr] Checking term v0.2.14 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Checking text-diff v0.4.0 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Checking pest v2.7.15 [INFO] [stderr] Compiling pest_meta v2.7.15 [INFO] [stderr] Compiling pest_generator v2.7.15 [INFO] [stderr] Compiling pest_derive v2.7.15 [INFO] [stderr] Checking edn-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/edn_compare.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | let mut child = Command::new("clojure") [INFO] [stdout] | _____________________^ [INFO] [stdout] 16 | | .arg("-M") [INFO] [stdout] 17 | | .arg("-e") [INFO] [stdout] 18 | | .arg("(do (set! *print-namespace-maps* false) (clojure.edn/read *in*))") [INFO] [stdout] ... | [INFO] [stdout] 22 | | .spawn() [INFO] [stdout] 23 | | .expect("Failed to start Clojure Process"); [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/edn_reader.rs:361:9 [INFO] [stdout] | [INFO] [stdout] 361 | return macro_(reader, ch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return macro_(reader, ch); [INFO] [stdout] 361 + macro_(reader, ch) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/edn_reader.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | return read_tagged(reader, ch).map(Some); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 363 - return read_tagged(reader, ch).map(Some); [INFO] [stdout] 363 + read_tagged(reader, ch).map(Some) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/edn_reader.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 365 | return Err(format!("No dispatch macro for: {ch}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 365 - return Err(format!("No dispatch macro for: {ch}")); [INFO] [stdout] 365 + Err(format!("No dispatch macro for: {ch}")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/edn_reader.rs:432:16 [INFO] [stdout] | [INFO] [stdout] 432 | if !ns.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `ns.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/edn_reader.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | return Err("Map literal must contain an even number of forms".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - return Err("Map literal must contain an even number of forms".to_string()); [INFO] [stdout] 449 + Err("Map literal must contain an even number of forms".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/edn_reader.rs:460:45 [INFO] [stdout] | [INFO] [stdout] 460 | ... Some(ns) if ns == "_/" => Keyword(format!("{name}")), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 460 - Some(ns) if ns == "_/" => Keyword(format!("{name}")), [INFO] [stdout] 460 + Some("_/") => Keyword(format!("{name}")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/edn_reader.rs:460:67 [INFO] [stdout] | [INFO] [stdout] 460 | ... Some(ns) if ns == "_/" => Keyword(format!("{name}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/edn_reader.rs:468:45 [INFO] [stdout] | [INFO] [stdout] 468 | ... Some(ns) if ns == "_/" => Symbol(format!("{name}")), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 468 - Some(ns) if ns == "_/" => Symbol(format!("{name}")), [INFO] [stdout] 468 + Some("_/") => Symbol(format!("{name}")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/edn_reader.rs:468:66 [INFO] [stdout] | [INFO] [stdout] 468 | ... Some(ns) if ns == "_/" => Symbol(format!("{name}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/edn_compare.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | let mut child = Command::new("clojure") [INFO] [stdout] | _____________________^ [INFO] [stdout] 16 | | .arg("-M") [INFO] [stdout] 17 | | .arg("-e") [INFO] [stdout] 18 | | .arg("(do (set! *print-namespace-maps* false) (clojure.edn/read *in*))") [INFO] [stdout] ... | [INFO] [stdout] 22 | | .spawn() [INFO] [stdout] 23 | | .expect("Failed to start Clojure Process"); [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/edn_reader.rs:361:9 [INFO] [stdout] | [INFO] [stdout] 361 | return macro_(reader, ch); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return macro_(reader, ch); [INFO] [stdout] 361 + macro_(reader, ch) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/edn_reader.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | return read_tagged(reader, ch).map(Some); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 363 - return read_tagged(reader, ch).map(Some); [INFO] [stdout] 363 + read_tagged(reader, ch).map(Some) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/edn_reader.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 365 | return Err(format!("No dispatch macro for: {ch}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 365 - return Err(format!("No dispatch macro for: {ch}")); [INFO] [stdout] 365 + Err(format!("No dispatch macro for: {ch}")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/edn_reader.rs:432:16 [INFO] [stdout] | [INFO] [stdout] 432 | if !ns.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `ns.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/edn_reader.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | return Err("Map literal must contain an even number of forms".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - return Err("Map literal must contain an even number of forms".to_string()); [INFO] [stdout] 449 + Err("Map literal must contain an even number of forms".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/edn_reader.rs:460:45 [INFO] [stdout] | [INFO] [stdout] 460 | ... Some(ns) if ns == "_/" => Keyword(format!("{name}")), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 460 - Some(ns) if ns == "_/" => Keyword(format!("{name}")), [INFO] [stdout] 460 + Some("_/") => Keyword(format!("{name}")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/edn_reader.rs:460:67 [INFO] [stdout] | [INFO] [stdout] 460 | ... Some(ns) if ns == "_/" => Keyword(format!("{name}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/edn_reader.rs:468:45 [INFO] [stdout] | [INFO] [stdout] 468 | ... Some(ns) if ns == "_/" => Symbol(format!("{name}")), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 468 - Some(ns) if ns == "_/" => Symbol(format!("{name}")), [INFO] [stdout] 468 + Some("_/") => Symbol(format!("{name}")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/edn_reader.rs:468:66 [INFO] [stdout] | [INFO] [stdout] 468 | ... Some(ns) if ns == "_/" => Symbol(format!("{name}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.31s [INFO] running `Command { std: "docker" "inspect" "234ab04d786caa49a46567d46161f8920223b34c555e84b65936551ebd8faf66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "234ab04d786caa49a46567d46161f8920223b34c555e84b65936551ebd8faf66", kill_on_drop: false }` [INFO] [stdout] 234ab04d786caa49a46567d46161f8920223b34c555e84b65936551ebd8faf66