[INFO] cloning repository https://github.com/hodlin-37/avane_ck_kevgir_rust_public [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hodlin-37/avane_ck_kevgir_rust_public" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhodlin-37%2Favane_ck_kevgir_rust_public", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhodlin-37%2Favane_ck_kevgir_rust_public'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8ce4489085f614b671c49da99366a3902b1a854c [INFO] linting hodlin-37/avane_ck_kevgir_rust_public against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhodlin-37%2Favane_ck_kevgir_rust_public" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hodlin-37/avane_ck_kevgir_rust_public [INFO] finished tweaking git repo https://github.com/hodlin-37/avane_ck_kevgir_rust_public [INFO] tweaked toml for git repo https://github.com/hodlin-37/avane_ck_kevgir_rust_public written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hodlin-37/avane_ck_kevgir_rust_public on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hodlin-37/avane_ck_kevgir_rust_public already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/hodlin-37/avane_ck_rust_lib.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded embed-resource v3.0.4 [INFO] [stderr] Downloaded avif-serialize v0.8.4 [INFO] [stderr] Downloaded block-modes v0.8.1 [INFO] [stderr] Downloaded egui-wgpu v0.31.1 [INFO] [stderr] Downloaded egui-winit v0.31.1 [INFO] [stderr] Downloaded arboard v3.6.0 [INFO] [stderr] Downloaded webbrowser v1.0.5 [INFO] [stderr] Downloaded eframe v0.31.1 [INFO] [stderr] Downloaded zune-jpeg v0.4.18 [INFO] [stderr] Downloaded zip v4.2.0 [INFO] [stderr] Downloaded egui_glow v0.31.1 [INFO] [stderr] Downloaded zip-extract v0.4.0 [INFO] [stderr] Downloaded tokio v1.46.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c874904ccc3825b910d88ee28dce8b98e47efc56a252ab8accab9e4428b937d [INFO] running `Command { std: "docker" "start" "-a" "4c874904ccc3825b910d88ee28dce8b98e47efc56a252ab8accab9e4428b937d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c874904ccc3825b910d88ee28dce8b98e47efc56a252ab8accab9e4428b937d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c874904ccc3825b910d88ee28dce8b98e47efc56a252ab8accab9e4428b937d", kill_on_drop: false }` [INFO] [stdout] 4c874904ccc3825b910d88ee28dce8b98e47efc56a252ab8accab9e4428b937d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1b3f23bea33bd93add08f274d173a3eeb40923170457226cea4447543840544 [INFO] running `Command { std: "docker" "start" "-a" "f1b3f23bea33bd93add08f274d173a3eeb40923170457226cea4447543840544", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Compiling indexmap v2.10.0 [INFO] [stderr] Checking libloading v0.8.8 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling wayland-sys v0.31.6 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling wayland-client v0.31.10 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.9 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking zlib-rs v0.5.1 [INFO] [stderr] Compiling log v0.4.27 [INFO] [stderr] Compiling xml-rs v0.8.26 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Compiling built v0.7.7 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Compiling cc v1.2.27 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking immutable-chunkmap v2.0.6 [INFO] [stderr] Compiling winit v0.30.11 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking weezl v0.1.10 [INFO] [stderr] Checking avif-serialize v0.8.4 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Compiling wayland-scanner v0.31.6 [INFO] [stderr] Checking epaint_default_fonts v0.31.1 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking exr v1.73.0 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking image-webp v0.2.3 [INFO] [stderr] Checking libz-rs-sys v0.5.1 [INFO] [stderr] Checking zune-jpeg v0.4.18 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ab_glyph v0.2.30 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking bumpalo v3.19.0 [INFO] [stderr] Compiling wayland-backend v0.3.10 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling liblzma-sys v0.4.4 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking zopfli v0.8.2 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking pem v3.0.5 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Checking block-modes v0.8.1 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking fern v0.7.1 [INFO] [stderr] Compiling kevgir v2.3.40 (/opt/rustwide/workdir) [INFO] [stderr] Checking bzip2 v0.5.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling bytemuck_derive v1.9.3 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking bytemuck v1.23.1 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tokio v1.46.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling enumn v0.1.14 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking av1-grain v0.2.4 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking liblzma v0.4.2 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking zip v4.2.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking zip-extract v0.4.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking quick-xml v0.30.0 [INFO] [stderr] Checking accesskit v0.17.1 [INFO] [stderr] Checking emath v0.31.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking jsonwebtoken v9.3.1 [INFO] [stderr] Checking ecolor v0.31.1 [INFO] [stderr] Checking epaint v0.31.1 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.11 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking accesskit_consumer v0.26.0 [INFO] [stderr] Checking ravif v0.11.20 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Checking zbus_xml v4.0.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking egui v0.31.1 [INFO] [stderr] Checking zbus-lockstep v0.4.4 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking polling v3.8.0 [INFO] [stderr] Checking async-io v2.4.1 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking hyper-util v0.1.14 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Compiling zbus-lockstep-macros v0.4.4 [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stderr] Checking wayland-protocols v0.32.8 [INFO] [stderr] Checking wayland-cursor v0.31.10 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking arboard v3.6.0 [INFO] [stderr] Checking avane_ck_rust_lib v0.1.0 (https://github.com/hodlin-37/avane_ck_rust_lib.git?branch=master#5497535a) [INFO] [stderr] Checking atspi-common v0.6.0 [INFO] [stderr] Checking egui_glow v0.31.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.8 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.8 [INFO] [stderr] Checking atspi-proxies v0.6.0 [INFO] [stderr] Checking accesskit_atspi_common v0.10.1 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking atspi-connection v0.6.0 [INFO] [stderr] Checking atspi v0.22.0 [INFO] [stderr] Checking accesskit_unix v0.13.1 [INFO] [stderr] Checking accesskit_winit v0.23.1 [INFO] [stderr] Checking egui-winit v0.31.1 [INFO] [stderr] Checking eframe v0.31.1 [INFO] [stdout] warning: unused imports: `Write` and `self` [INFO] [stdout] --> installer.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | io::{self, Cursor, Write}, [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Write` and `self` [INFO] [stdout] --> installer.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | io::{self, Cursor, Write}, [INFO] [stdout] | ^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> installer.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | .get(&format!("https://api.github.com/repos/{}/releases/latest", REPO)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("https://api.github.com/repos/{}/releases/latest", REPO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> installer.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / if let Some(name) = file_name.to_str() { [INFO] [stdout] 86 | | if name == "installer.exe" { [INFO] [stdout] 87 | | println!("⚠️ installer.exe kendini overwrite etmiyor, atlanıyor."); [INFO] [stdout] 88 | | continue; [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 85 ~ if let Some(name) = file_name.to_str() [INFO] [stdout] 86 ~ && name == "installer.exe" { [INFO] [stdout] 87 | println!("⚠️ installer.exe kendini overwrite etmiyor, atlanıyor."); [INFO] [stdout] 88 | continue; [INFO] [stdout] 89 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> installer.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | / Command::new(exe_path) [INFO] [stdout] 102 | | .spawn() [INFO] [stdout] 103 | | .expect("❌ Yeni sürüm başlatılamadı"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |______________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> installer.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | .get(&format!("https://api.github.com/repos/{}/releases/latest", REPO)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("https://api.github.com/repos/{}/releases/latest", REPO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> installer.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / if let Some(name) = file_name.to_str() { [INFO] [stdout] 86 | | if name == "installer.exe" { [INFO] [stdout] 87 | | println!("⚠️ installer.exe kendini overwrite etmiyor, atlanıyor."); [INFO] [stdout] 88 | | continue; [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 85 ~ if let Some(name) = file_name.to_str() [INFO] [stdout] 86 ~ && name == "installer.exe" { [INFO] [stdout] 87 | println!("⚠️ installer.exe kendini overwrite etmiyor, atlanıyor."); [INFO] [stdout] 88 | continue; [INFO] [stdout] 89 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> installer.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | / Command::new(exe_path) [INFO] [stdout] 102 | | .spawn() [INFO] [stdout] 103 | | .expect("❌ Yeni sürüm başlatılamadı"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |______________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `GetirResponseMenuCategoryProduct`, `GetirResponseMenuCategory`, and `GetirResponseProductsModifierGroup` [INFO] [stdout] --> src/services/getir.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | GetirResponseMenu, GetirResponseMenuCategory, GetirResponseMenuCategoryProduct, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 17 | GetirResponseModifierGroup, GetirResponseProduct, GetirResponseProductsModifierGroup, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ACMA_KAPAMA_SHEET_ID` and `RECIPES_RANGE` [INFO] [stdout] --> src/services/getir.rs:20:31 [INFO] [stdout] | [INFO] [stdout] 20 | use crate::config::constant::{ACMA_KAPAMA_SHEET_ID, RECIPES_RANGE}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::services::getir` [INFO] [stdout] --> src/services/getir.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use crate::services::getir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `GetirResponseMenuCategoryProduct`, `GetirResponseMenuCategory`, and `GetirResponseProductsModifierGroup` [INFO] [stdout] --> src/services/getir.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | GetirResponseMenu, GetirResponseMenuCategory, GetirResponseMenuCategoryProduct, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 17 | GetirResponseModifierGroup, GetirResponseProduct, GetirResponseProductsModifierGroup, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ACMA_KAPAMA_SHEET_ID` and `RECIPES_RANGE` [INFO] [stdout] --> src/services/getir.rs:20:31 [INFO] [stdout] | [INFO] [stdout] 20 | use crate::config::constant::{ACMA_KAPAMA_SHEET_ID, RECIPES_RANGE}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::services::getir` [INFO] [stdout] --> src/services/getir.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use crate::services::getir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `GOOGLE_API_SCOPES` is never used [INFO] [stdout] --> src/config/google_api_scopes.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | pub const GOOGLE_API_SCOPES: [&str; 4] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ServiceAccountCredentials` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ServiceAccountCredentials { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `JWTClaims` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct JWTClaims<'a> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GoogleTokenResponse` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct GoogleTokenResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GoogleSheetResponse` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct GoogleSheetResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GoogleDriveFileInfo` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct GoogleDriveFileInfo{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GoogleDriveFileListResponse` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct GoogleDriveFileListResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `validaton_error_messages` is never read [INFO] [stdout] --> src/schemas/struct_migros.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 150 | pub struct MigrosActivateResponse { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 155 | pub validaton_error_messages: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MigrosActivateResponse` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `error_code`, `error_title`, `error_detail`, and `is_system_error` are never read [INFO] [stdout] --> src/schemas/struct_migros.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 159 | pub struct MigrosErrorMessage { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 160 | #[serde(rename = "errorCode")] [INFO] [stdout] 161 | pub error_code: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 162 | #[serde(rename = "errorTitle")] [INFO] [stdout] 163 | pub error_title: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 164 | #[serde(rename = "errorDetail")] [INFO] [stdout] 165 | pub error_detail: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 166 | #[serde(rename = "isSystemError")] [INFO] [stdout] 167 | pub is_system_error: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MigrosErrorMessage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `step` and `result` are never read [INFO] [stdout] --> src/schemas/struct_enums.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub struct RoofStepResult { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 26 | pub step: RoofStep, [INFO] [stdout] | ^^^^ [INFO] [stdout] 27 | pub result: Result<(), String>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `YemeksepetiBranchJsonResponse` is never constructed [INFO] [stdout] --> src/schemas/struct_yemeksepeti.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 142 | pub struct YemeksepetiBranchJsonResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `YemeksepetiBranchJsonRow` is never constructed [INFO] [stdout] --> src/schemas/struct_yemeksepeti.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | pub struct YemeksepetiBranchJsonRow { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/schemas/struct_getir.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct GetirResponseMenuCategory { [INFO] [stdout] | ------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | pub status: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetirResponseMenuCategory` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/schemas/struct_getir.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct GetirResponseMenuCategoryProduct { [INFO] [stdout] | -------------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 51 | pub status: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetirResponseMenuCategoryProduct` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/schemas/struct_getir.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub struct GetirResponseProductsModifierGroup { [INFO] [stdout] | ---------------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 68 | pub status: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetirResponseProductsModifierGroup` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/schemas/struct_getir.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub struct GetirResponseModifierGroup { [INFO] [stdout] | -------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 75 | pub status: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetirResponseModifierGroup` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/migros.rs:292:85 [INFO] [stdout] | [INFO] [stdout] 292 | let branch_name_mapped = find_value_by_key_in_json(DIRECTORY_BRANCH_NAMES_JSON, &branch_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `branch_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/migros.rs:652:13 [INFO] [stdout] | [INFO] [stdout] 652 | / if row["type"] == "Option" { [INFO] [stdout] 653 | | if let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 654 | | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 655 | | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 656 | | } [INFO] [stdout] 657 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 652 ~ if row["type"] == "Option" [INFO] [stdout] 653 ~ && let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 654 | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 655 | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 656 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/migros.rs:663:13 [INFO] [stdout] | [INFO] [stdout] 663 | / if row["type"] == "Product" { [INFO] [stdout] 664 | | if let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 665 | | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... | [INFO] [stdout] 709 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 663 ~ if row["type"] == "Product" [INFO] [stdout] 664 ~ && let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 665 | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... [INFO] [stdout] 707 | } [INFO] [stdout] 708 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/migros.rs:668:25 [INFO] [stdout] | [INFO] [stdout] 668 | / if let Some(cat_id) = modifier.as_i64() { [INFO] [stdout] 669 | | if let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 670 | | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... | [INFO] [stdout] 706 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 668 ~ if let Some(cat_id) = modifier.as_i64() [INFO] [stdout] 669 ~ && let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 670 | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... [INFO] [stdout] 704 | } [INFO] [stdout] 705 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/migros.rs:736:15 [INFO] [stdout] | [INFO] [stdout] 736 | progress: Arc< [INFO] [stdout] | _______________^ [INFO] [stdout] 737 | | tokio::sync::Mutex>>, [INFO] [stdout] 738 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/migros.rs:758:17 [INFO] [stdout] | [INFO] [stdout] 758 | / if let Some(product_id) = json.get("product_id").and_then(|v| v.as_i64()) { [INFO] [stdout] 759 | | if seen_product_ids.insert(product_id) { [INFO] [stdout] 760 | | unique_items.push(json); [INFO] [stdout] 761 | | } [INFO] [stdout] 762 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 758 ~ if let Some(product_id) = json.get("product_id").and_then(|v| v.as_i64()) [INFO] [stdout] 759 ~ && seen_product_ids.insert(product_id) { [INFO] [stdout] 760 | unique_items.push(json); [INFO] [stdout] 761 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `columns` [INFO] [stdout] --> src/services/flagger.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | for i in 0..col_count { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 78 - for i in 0..col_count { [INFO] [stdout] 78 + for (i, ) in columns.iter_mut().enumerate().take(col_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `GOOGLE_API_SCOPES` is never used [INFO] [stdout] --> src/config/google_api_scopes.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | pub const GOOGLE_API_SCOPES: [&str; 4] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ServiceAccountCredentials` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ServiceAccountCredentials { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `JWTClaims` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct JWTClaims<'a> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GoogleTokenResponse` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct GoogleTokenResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GoogleSheetResponse` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct GoogleSheetResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GoogleDriveFileInfo` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct GoogleDriveFileInfo{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GoogleDriveFileListResponse` is never constructed [INFO] [stdout] --> src/schemas/struct_google_api.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct GoogleDriveFileListResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `validaton_error_messages` is never read [INFO] [stdout] --> src/schemas/struct_migros.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 150 | pub struct MigrosActivateResponse { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 155 | pub validaton_error_messages: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MigrosActivateResponse` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `error_code`, `error_title`, `error_detail`, and `is_system_error` are never read [INFO] [stdout] --> src/schemas/struct_migros.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 159 | pub struct MigrosErrorMessage { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 160 | #[serde(rename = "errorCode")] [INFO] [stdout] 161 | pub error_code: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 162 | #[serde(rename = "errorTitle")] [INFO] [stdout] 163 | pub error_title: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 164 | #[serde(rename = "errorDetail")] [INFO] [stdout] 165 | pub error_detail: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 166 | #[serde(rename = "isSystemError")] [INFO] [stdout] 167 | pub is_system_error: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MigrosErrorMessage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `step` and `result` are never read [INFO] [stdout] --> src/schemas/struct_enums.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub struct RoofStepResult { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 26 | pub step: RoofStep, [INFO] [stdout] | ^^^^ [INFO] [stdout] 27 | pub result: Result<(), String>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `col.get(0)` [INFO] [stdout] --> src/services/flagger.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | if col.get(0).map(|v| v == branch_name).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `col.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/services/flagger.rs:103:91 [INFO] [stdout] | [INFO] [stdout] 103 | if cell.as_str() == "Coca-Cola (330 ML x 24 AD) KOLİ" && cc_situation { [INFO] [stdout] | ___________________________________________________________________________________________^ [INFO] [stdout] 104 | | continue; [INFO] [stdout] 105 | | } else if cell.as_str() == "Coca-Cola Zero (330 ML x 24 AD) KOLİ" [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/services/flagger.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | / { [INFO] [stdout] 108 | | continue; [INFO] [stdout] 109 | | } else { [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `YemeksepetiBranchJsonResponse` is never constructed [INFO] [stdout] --> src/schemas/struct_yemeksepeti.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 142 | pub struct YemeksepetiBranchJsonResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `YemeksepetiBranchJsonRow` is never constructed [INFO] [stdout] --> src/schemas/struct_yemeksepeti.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | pub struct YemeksepetiBranchJsonRow { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/schemas/struct_getir.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct GetirResponseMenuCategory { [INFO] [stdout] | ------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | pub status: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetirResponseMenuCategory` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/schemas/struct_getir.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub struct GetirResponseMenuCategoryProduct { [INFO] [stdout] | -------------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 51 | pub status: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetirResponseMenuCategoryProduct` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/schemas/struct_getir.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 65 | pub struct GetirResponseProductsModifierGroup { [INFO] [stdout] | ---------------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 68 | pub status: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetirResponseProductsModifierGroup` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/schemas/struct_getir.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub struct GetirResponseModifierGroup { [INFO] [stdout] | -------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 75 | pub status: i64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetirResponseModifierGroup` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `columns` [INFO] [stdout] --> src/services/flagger.rs:185:18 [INFO] [stdout] | [INFO] [stdout] 185 | for i in 0..col_count { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 185 - for i in 0..col_count { [INFO] [stdout] 185 + for (i, ) in columns.iter_mut().enumerate().take(col_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `col.get(0)` [INFO] [stdout] --> src/services/flagger.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 192 | if col.get(0).map(|v| v == branch_name).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `col.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/services/trendyol.rs:160:21 [INFO] [stdout] | [INFO] [stdout] 160 | / for modifier_group in &product.modifier_groups { [INFO] [stdout] 161 | | if let Some(modifier_group) = modifier_group { [INFO] [stdout] 162 | | modifier_group_ids.push(modifier_group.modifier_group_id); [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/services/trendyol.rs:161:25 [INFO] [stdout] | [INFO] [stdout] 161 | / if let Some(modifier_group) = modifier_group { [INFO] [stdout] 162 | | modifier_group_ids.push(modifier_group.modifier_group_id); [INFO] [stdout] 163 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 160 ~ for modifier_group in product.modifier_groups.iter().flatten() { [INFO] [stdout] 161 + modifier_group_ids.push(modifier_group.modifier_group_id); [INFO] [stdout] 162 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/trendyol.rs:289:85 [INFO] [stdout] | [INFO] [stdout] 289 | let branch_name_mapped = find_value_by_key_in_json(DIRECTORY_BRANCH_NAMES_JSON, &branch_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `branch_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:447:13 [INFO] [stdout] | [INFO] [stdout] 447 | / if row["type"] == "Option" { [INFO] [stdout] 448 | | if let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 449 | | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 450 | | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] ... | [INFO] [stdout] 453 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 447 ~ if row["type"] == "Option" [INFO] [stdout] 448 ~ && let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 449 | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 450 | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 451 | category_rows.entry(cat_id).or_default().push(row); [INFO] [stdout] 452 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:472:13 [INFO] [stdout] | [INFO] [stdout] 472 | / if group.len() > 2 { [INFO] [stdout] 473 | | if let Some(i) = true_flag_index { [INFO] [stdout] 474 | | if group[i]["urun_id"] == json!(58579) { [INFO] [stdout] 475 | | group[i]["flag"] = json!(false); [INFO] [stdout] ... | [INFO] [stdout] 492 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 472 ~ if group.len() > 2 [INFO] [stdout] 473 ~ && let Some(i) = true_flag_index { [INFO] [stdout] 474 | if group[i]["urun_id"] == json!(58579) { [INFO] [stdout] ... [INFO] [stdout] 490 | } [INFO] [stdout] 491 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:473:17 [INFO] [stdout] | [INFO] [stdout] 473 | / if let Some(i) = true_flag_index { [INFO] [stdout] 474 | | if group[i]["urun_id"] == json!(58579) { [INFO] [stdout] 475 | | group[i]["flag"] = json!(false); [INFO] [stdout] ... | [INFO] [stdout] 491 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 473 ~ if let Some(i) = true_flag_index [INFO] [stdout] 474 ~ && group[i]["urun_id"] == json!(58579) { [INFO] [stdout] 475 | group[i]["flag"] = json!(false); [INFO] [stdout] ... [INFO] [stdout] 489 | } [INFO] [stdout] 490 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:498:13 [INFO] [stdout] | [INFO] [stdout] 498 | / if row["type"] == "Product" { [INFO] [stdout] 499 | | if let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 500 | | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... | [INFO] [stdout] 544 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 498 ~ if row["type"] == "Product" [INFO] [stdout] 499 ~ && let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 500 | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... [INFO] [stdout] 542 | } [INFO] [stdout] 543 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:503:25 [INFO] [stdout] | [INFO] [stdout] 503 | / if let Some(cat_id) = modifier.as_i64() { [INFO] [stdout] 504 | | if let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 505 | | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... | [INFO] [stdout] 541 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 503 ~ if let Some(cat_id) = modifier.as_i64() [INFO] [stdout] 504 ~ && let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 505 | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... [INFO] [stdout] 539 | } [INFO] [stdout] 540 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/services/trendyol.rs:555:34 [INFO] [stdout] | [INFO] [stdout] 555 | let sorted_all: Vec = updated_rows_by_store [INFO] [stdout] | __________________________________^ [INFO] [stdout] 556 | | .into_iter() [INFO] [stdout] 557 | | .flat_map(|(_store_id, rows)| { [INFO] [stdout] ... | [INFO] [stdout] 589 | | all [INFO] [stdout] 590 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 555 ~ let sorted_all: Vec = updated_rows_by_store.into_values().flat_map(|rows| { [INFO] [stdout] 556 ~ // Tüm Product ID'leri çıkar [INFO] [stdout] 557 + let product_ids: std::collections::HashSet = rows [INFO] [stdout] 558 + .iter() [INFO] [stdout] 559 + .filter(|r| r["type"] == "Product") [INFO] [stdout] 560 + .filter_map(|r| r["product_id"].as_i64().map(|id| id.to_string())) [INFO] [stdout] 561 + .collect(); [INFO] [stdout] 562 + [INFO] [stdout] 563 ~ // Sıralama fonksiyonu [INFO] [stdout] 564 + let sort_key = |r: &Value| { [INFO] [stdout] 565 + let flag = r.get("flag"); [INFO] [stdout] 566 + let type_ = r["type"].as_str().unwrap_or(""); [INFO] [stdout] 567 + let pid = r["product_id"].as_i64().map(|id| id.to_string()); [INFO] [stdout] 568 + let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 569 + [INFO] [stdout] 570 + match flag { [INFO] [stdout] 571 + Some(val) if val == &json!(false) => match type_ { [INFO] [stdout] 572 + "Product" => (0, 0), [INFO] [stdout] 573 + "Option" => (1, if is_linked { 0 } else { 1 }), [INFO] [stdout] 574 + _ => (2, 0), [INFO] [stdout] 575 + }, [INFO] [stdout] 576 + Some(val) if val == &json!(true) => match type_ { [INFO] [stdout] 577 + "Option" => (3, if is_linked { 1 } else { 0 }), [INFO] [stdout] 578 + "Product" => (4, 0), [INFO] [stdout] 579 + _ => (4, 1), [INFO] [stdout] 580 + }, [INFO] [stdout] 581 + _ => (5, 0), // flag null veya eksik [INFO] [stdout] 582 + } [INFO] [stdout] 583 + }; [INFO] [stdout] 584 + [INFO] [stdout] 585 + let mut all = rows.clone(); [INFO] [stdout] 586 + all.sort_by_key(|r| sort_key(r)); [INFO] [stdout] 587 + all [INFO] [stdout] 588 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/services/trendyol.rs:570:33 [INFO] [stdout] | [INFO] [stdout] 570 | let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 570 - let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 570 + let is_linked = pid.as_ref().is_some_and(|id| product_ids.contains(id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/trendyol.rs:709:15 [INFO] [stdout] | [INFO] [stdout] 709 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:131:15 [INFO] [stdout] | [INFO] [stdout] 131 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:246:15 [INFO] [stdout] | [INFO] [stdout] 246 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:361:15 [INFO] [stdout] | [INFO] [stdout] 361 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:477:15 [INFO] [stdout] | [INFO] [stdout] 477 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/services/yemeksepeti.rs:169:19 [INFO] [stdout] | [INFO] [stdout] 169 | let menu_id = response [INFO] [stdout] | ___________________^ [INFO] [stdout] 170 | | .data [INFO] [stdout] 171 | | .get(0) [INFO] [stdout] 172 | | .and_then(|data| Some(data.menu_id.clone())) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 169 ~ let menu_id = response [INFO] [stdout] 170 + .data [INFO] [stdout] 171 + .get(0).map(|data| data.menu_id.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response [INFO] [stdout] .data.get(0)` [INFO] [stdout] --> src/services/yemeksepeti.rs:169:19 [INFO] [stdout] | [INFO] [stdout] 169 | let menu_id = response [INFO] [stdout] | ___________________^ [INFO] [stdout] 170 | | .data [INFO] [stdout] 171 | | .get(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 169 ~ let menu_id = response [INFO] [stdout] 170 + .data.first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/services/yemeksepeti.rs:172:31 [INFO] [stdout] | [INFO] [stdout] 172 | .and_then(|data| Some(data.menu_id.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `data.menu_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:255:41 [INFO] [stdout] | [INFO] [stdout] 255 | let raw_response = http_request_get(&yemeksepeti_url_modifiers, yemeksepeti_menu_headers) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `yemeksepeti_url_modifiers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:292:41 [INFO] [stdout] | [INFO] [stdout] 292 | let raw_response = http_request_get(&yemeksepeti_url_toppings, yemeksepeti_menu_headers) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `yemeksepeti_url_toppings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/services/yemeksepeti.rs:392:24 [INFO] [stdout] | [INFO] [stdout] 392 | && !choice.variation_prices.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `choice.variation_prices.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:507:85 [INFO] [stdout] | [INFO] [stdout] 507 | let branch_name_mapped = find_value_by_key_in_json(DIRECTORY_BRANCH_NAMES_JSON, &branch_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `branch_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/yemeksepeti.rs:516:21 [INFO] [stdout] | [INFO] [stdout] 516 | / if row.len() >= 2 { [INFO] [stdout] 517 | | if let (Ok(urun_id), Ok(remote_code)) = [INFO] [stdout] 518 | | (row[0].parse::(), row[1].parse::()) [INFO] [stdout] ... | [INFO] [stdout] 522 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 516 ~ if row.len() >= 2 [INFO] [stdout] 517 ~ && let (Ok(urun_id), Ok(remote_code)) = [INFO] [stdout] 518 | (row[0].parse::(), row[1].parse::()) [INFO] [stdout] 519 | { [INFO] [stdout] 520 | map.insert(remote_code, urun_id); [INFO] [stdout] 521 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/yemeksepeti.rs:677:13 [INFO] [stdout] | [INFO] [stdout] 677 | / if row["type"] == "Option" { [INFO] [stdout] 678 | | if let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 679 | | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 680 | | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 681 | | } [INFO] [stdout] 682 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 677 ~ if row["type"] == "Option" [INFO] [stdout] 678 ~ && let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 679 | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 680 | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 681 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/yemeksepeti.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 688 | / if row["type"] == "Product" { [INFO] [stdout] 689 | | if let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 690 | | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... | [INFO] [stdout] 734 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 688 ~ if row["type"] == "Product" [INFO] [stdout] 689 ~ && let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 690 | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... [INFO] [stdout] 732 | } [INFO] [stdout] 733 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/yemeksepeti.rs:693:25 [INFO] [stdout] | [INFO] [stdout] 693 | / if let Some(cat_id) = modifier.as_i64() { [INFO] [stdout] 694 | | if let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 695 | | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... | [INFO] [stdout] 731 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 693 ~ if let Some(cat_id) = modifier.as_i64() [INFO] [stdout] 694 ~ && let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 695 | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... [INFO] [stdout] 729 | } [INFO] [stdout] 730 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/services/yemeksepeti.rs:745:34 [INFO] [stdout] | [INFO] [stdout] 745 | let sorted_all: Vec = updated_rows_by_store [INFO] [stdout] | __________________________________^ [INFO] [stdout] 746 | | .into_iter() [INFO] [stdout] 747 | | .flat_map(|(_vendor_id, rows)| { [INFO] [stdout] ... | [INFO] [stdout] 779 | | all [INFO] [stdout] 780 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 745 ~ let sorted_all: Vec = updated_rows_by_store.into_values().flat_map(|rows| { [INFO] [stdout] 746 ~ // Tüm Product ID'leri çıkar [INFO] [stdout] 747 + let product_ids: std::collections::HashSet = rows [INFO] [stdout] 748 + .iter() [INFO] [stdout] 749 + .filter(|r| r["type"] == "Product") [INFO] [stdout] 750 + .filter_map(|r| r["product_id"].as_i64().map(|id| id.to_string())) [INFO] [stdout] 751 + .collect(); [INFO] [stdout] 752 + [INFO] [stdout] 753 ~ // Sıralama fonksiyonu [INFO] [stdout] 754 + let sort_key = |r: &Value| { [INFO] [stdout] 755 + let flag = r.get("flag"); [INFO] [stdout] 756 + let type_ = r["type"].as_str().unwrap_or(""); [INFO] [stdout] 757 + let pid = r["product_id"].as_i64().map(|id| id.to_string()); [INFO] [stdout] 758 + let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 759 + [INFO] [stdout] 760 + match flag { [INFO] [stdout] 761 + Some(val) if val == &json!(false) => match type_ { [INFO] [stdout] 762 + "Product" => (0, 0), [INFO] [stdout] 763 + "Option" => (1, if is_linked { 0 } else { 1 }), [INFO] [stdout] 764 + _ => (2, 0), [INFO] [stdout] 765 + }, [INFO] [stdout] 766 + Some(val) if val == &json!(true) => match type_ { [INFO] [stdout] 767 + "Option" => (3, if is_linked { 1 } else { 0 }), [INFO] [stdout] 768 + "Product" => (4, 0), [INFO] [stdout] 769 + _ => (4, 1), [INFO] [stdout] 770 + }, [INFO] [stdout] 771 + _ => (5, 0), // flag null veya eksik [INFO] [stdout] 772 + } [INFO] [stdout] 773 + }; [INFO] [stdout] 774 + [INFO] [stdout] 775 + let mut all = rows.clone(); [INFO] [stdout] 776 + all.sort_by_key(|r| sort_key(r)); [INFO] [stdout] 777 + all [INFO] [stdout] 778 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/services/yemeksepeti.rs:760:33 [INFO] [stdout] | [INFO] [stdout] 760 | let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 760 - let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 760 + let is_linked = pid.as_ref().is_some_and(|id| product_ids.contains(id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:832:9 [INFO] [stdout] | [INFO] [stdout] 832 | &YEMEKSEPETI_URL_STATUS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `YEMEKSEPETI_URL_STATUS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:887:9 [INFO] [stdout] | [INFO] [stdout] 887 | &YEMEKSEPETI_URL_STATUS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `YEMEKSEPETI_URL_STATUS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/yemeksepeti.rs:916:15 [INFO] [stdout] | [INFO] [stdout] 916 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/services/getir.rs:191:26 [INFO] [stdout] | [INFO] [stdout] 191 | .with_context(|| format!("❌ Products yanıtı parse edilemedi."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"❌ Products yanıtı parse edilemedi.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/services/getir.rs:223:26 [INFO] [stdout] | [INFO] [stdout] 223 | .with_context(|| format!("❌ Menü yanıtı parse edilemedi."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"❌ Menü yanıtı parse edilemedi.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/services/getir.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | / for product_modifier_group in &product.modifier_groups { [INFO] [stdout] 277 | | if let Some(product_modifier_group) = product_modifier_group { [INFO] [stdout] 278 | | let modifier_group_id = &product_modifier_group.modifier_group_id; [INFO] [stdout] 279 | | product_modifier_group_ids.push(modifier_group_id.clone()); [INFO] [stdout] 280 | | } [INFO] [stdout] 281 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/services/getir.rs:277:25 [INFO] [stdout] | [INFO] [stdout] 277 | / if let Some(product_modifier_group) = product_modifier_group { [INFO] [stdout] 278 | | let modifier_group_id = &product_modifier_group.modifier_group_id; [INFO] [stdout] 279 | | product_modifier_group_ids.push(modifier_group_id.clone()); [INFO] [stdout] 280 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 276 ~ for product_modifier_group in product.modifier_groups.iter().flatten() { [INFO] [stdout] 277 + let modifier_group_id = &product_modifier_group.modifier_group_id; [INFO] [stdout] 278 + product_modifier_group_ids.push(modifier_group_id.clone()); [INFO] [stdout] 279 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/getir.rs:436:85 [INFO] [stdout] | [INFO] [stdout] 436 | let branch_name_mapped = find_value_by_key_in_json(DIRECTORY_BRANCH_NAMES_JSON, &branch_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `branch_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/getir.rs:601:13 [INFO] [stdout] | [INFO] [stdout] 601 | / if row["type"] == "Option" { [INFO] [stdout] 602 | | if let Some(cat_id) = row["category_id"].as_str() { [INFO] [stdout] 603 | | let flag_val = match row.get("flag") { [INFO] [stdout] 604 | | Some(Value::Bool(b)) => *b, [INFO] [stdout] ... | [INFO] [stdout] 620 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 601 ~ if row["type"] == "Option" [INFO] [stdout] 602 ~ && let Some(cat_id) = row["category_id"].as_str() { [INFO] [stdout] 603 | let flag_val = match row.get("flag") { [INFO] [stdout] ... [INFO] [stdout] 618 | .push(flag_val); [INFO] [stdout] 619 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/getir.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | / if row["type"] == "Product" { [INFO] [stdout] 627 | | if let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 628 | | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... | [INFO] [stdout] 672 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 626 ~ if row["type"] == "Product" [INFO] [stdout] 627 ~ && let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 628 | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... [INFO] [stdout] 670 | } [INFO] [stdout] 671 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/getir.rs:631:25 [INFO] [stdout] | [INFO] [stdout] 631 | / if let Some(cat_id) = modifier.as_str() { [INFO] [stdout] 632 | | if let Some(flag_list) = category_flags.get(cat_id) { [INFO] [stdout] 633 | | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... | [INFO] [stdout] 669 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 631 ~ if let Some(cat_id) = modifier.as_str() [INFO] [stdout] 632 ~ && let Some(flag_list) = category_flags.get(cat_id) { [INFO] [stdout] 633 | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... [INFO] [stdout] 667 | } [INFO] [stdout] 668 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/services/getir.rs:683:34 [INFO] [stdout] | [INFO] [stdout] 683 | let sorted_all: Vec = updated_rows_by_store [INFO] [stdout] | __________________________________^ [INFO] [stdout] 684 | | .into_iter() [INFO] [stdout] 685 | | .flat_map(|(_store_id, rows)| { [INFO] [stdout] ... | [INFO] [stdout] 717 | | all [INFO] [stdout] 718 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 683 ~ let sorted_all: Vec = updated_rows_by_store.into_values().flat_map(|rows| { [INFO] [stdout] 684 ~ // Tüm Product ID'leri çıkar [INFO] [stdout] 685 + let product_ids: std::collections::HashSet = rows [INFO] [stdout] 686 + .iter() [INFO] [stdout] 687 + .filter(|r| r["type"] == "Product") [INFO] [stdout] 688 + .filter_map(|r| r["product_id"].as_str().map(|id| id.to_string())) [INFO] [stdout] 689 + .collect(); [INFO] [stdout] 690 + [INFO] [stdout] 691 ~ // Sıralama fonksiyonu [INFO] [stdout] 692 + let sort_key = |r: &Value| { [INFO] [stdout] 693 + let flag = r.get("flag"); [INFO] [stdout] 694 + let type_ = r["type"].as_str().unwrap_or(""); [INFO] [stdout] 695 + let pid = r["product_id"].as_str().map(|id| id.to_string()); [INFO] [stdout] 696 + let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 697 + [INFO] [stdout] 698 + match flag { [INFO] [stdout] 699 + Some(val) if val == &json!(false) => match type_ { [INFO] [stdout] 700 + "Product" => (0, 0), [INFO] [stdout] 701 + "Option" => (1, if is_linked { 0 } else { 1 }), [INFO] [stdout] 702 + _ => (2, 0), [INFO] [stdout] 703 + }, [INFO] [stdout] 704 + Some(val) if val == &json!(true) => match type_ { [INFO] [stdout] 705 + "Option" => (3, if is_linked { 1 } else { 0 }), [INFO] [stdout] 706 + "Product" => (4, 0), [INFO] [stdout] 707 + _ => (4, 1), [INFO] [stdout] 708 + }, [INFO] [stdout] 709 + _ => (5, 0), // flag null veya eksik [INFO] [stdout] 710 + } [INFO] [stdout] 711 + }; [INFO] [stdout] 712 + [INFO] [stdout] 713 + let mut all = rows.clone(); [INFO] [stdout] 714 + all.sort_by_key(|r| sort_key(r)); [INFO] [stdout] 715 + all [INFO] [stdout] 716 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/services/getir.rs:698:33 [INFO] [stdout] | [INFO] [stdout] 698 | let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 698 - let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 698 + let is_linked = pid.as_ref().is_some_and(|id| product_ids.contains(id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/services/getir.rs:757:42 [INFO] [stdout] | [INFO] [stdout] 757 | &GETIR_URL_STATUS.replacen("{}", &product_id.to_string(), 1), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `product_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/services/getir.rs:798:42 [INFO] [stdout] | [INFO] [stdout] 798 | &GETIR_URL_STATUS.replacen("{}", &product_id.to_string(), 1), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `product_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/getir.rs:826:15 [INFO] [stdout] | [INFO] [stdout] 826 | progress: Arc< [INFO] [stdout] | _______________^ [INFO] [stdout] 827 | | tokio::sync::Mutex>>, [INFO] [stdout] 828 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/gui/main_window.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/main_window.rs:303:37 [INFO] [stdout] | [INFO] [stdout] 303 | / ... if let Ok(progress_map) = self.progress.try_lock() { [INFO] [stdout] 304 | | ... if let Some(Some((current, total))) = [INFO] [stdout] 305 | | ... progress_map.get(&platform.to_lowercase()) [INFO] [stdout] ... | [INFO] [stdout] 320 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 303 ~ if let Ok(progress_map) = self.progress.try_lock() [INFO] [stdout] 304 ~ && let Some(Some((current, total))) = [INFO] [stdout] 305 | progress_map.get(&platform.to_lowercase()) [INFO] [stdout] ... [INFO] [stdout] 318 | } [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/main_window.rs:304:41 [INFO] [stdout] | [INFO] [stdout] 304 | / ... if let Some(Some((current, total))) = [INFO] [stdout] 305 | | ... progress_map.get(&platform.to_lowercase()) [INFO] [stdout] 306 | | ... { [INFO] [stdout] 307 | | ... if *total > 0 { [INFO] [stdout] ... | [INFO] [stdout] 319 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 305 ~ progress_map.get(&platform.to_lowercase()) [INFO] [stdout] 306 ~ && *total > 0 { [INFO] [stdout] 307 | ui.add( [INFO] [stdout] ... [INFO] [stdout] 316 | ); [INFO] [stdout] 317 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/migros.rs:292:85 [INFO] [stdout] | [INFO] [stdout] 292 | let branch_name_mapped = find_value_by_key_in_json(DIRECTORY_BRANCH_NAMES_JSON, &branch_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `branch_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/migros.rs:652:13 [INFO] [stdout] | [INFO] [stdout] 652 | / if row["type"] == "Option" { [INFO] [stdout] 653 | | if let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 654 | | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 655 | | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 656 | | } [INFO] [stdout] 657 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 652 ~ if row["type"] == "Option" [INFO] [stdout] 653 ~ && let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 654 | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 655 | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 656 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/migros.rs:663:13 [INFO] [stdout] | [INFO] [stdout] 663 | / if row["type"] == "Product" { [INFO] [stdout] 664 | | if let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 665 | | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... | [INFO] [stdout] 709 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 663 ~ if row["type"] == "Product" [INFO] [stdout] 664 ~ && let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 665 | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... [INFO] [stdout] 707 | } [INFO] [stdout] 708 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/migros.rs:668:25 [INFO] [stdout] | [INFO] [stdout] 668 | / if let Some(cat_id) = modifier.as_i64() { [INFO] [stdout] 669 | | if let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 670 | | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... | [INFO] [stdout] 706 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 668 ~ if let Some(cat_id) = modifier.as_i64() [INFO] [stdout] 669 ~ && let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 670 | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... [INFO] [stdout] 704 | } [INFO] [stdout] 705 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/migros.rs:736:15 [INFO] [stdout] | [INFO] [stdout] 736 | progress: Arc< [INFO] [stdout] | _______________^ [INFO] [stdout] 737 | | tokio::sync::Mutex>>, [INFO] [stdout] 738 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/migros.rs:758:17 [INFO] [stdout] | [INFO] [stdout] 758 | / if let Some(product_id) = json.get("product_id").and_then(|v| v.as_i64()) { [INFO] [stdout] 759 | | if seen_product_ids.insert(product_id) { [INFO] [stdout] 760 | | unique_items.push(json); [INFO] [stdout] 761 | | } [INFO] [stdout] 762 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 758 ~ if let Some(product_id) = json.get("product_id").and_then(|v| v.as_i64()) [INFO] [stdout] 759 ~ && seen_product_ids.insert(product_id) { [INFO] [stdout] 760 | unique_items.push(json); [INFO] [stdout] 761 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `columns` [INFO] [stdout] --> src/services/flagger.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | for i in 0..col_count { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 78 - for i in 0..col_count { [INFO] [stdout] 78 + for (i, ) in columns.iter_mut().enumerate().take(col_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `col.get(0)` [INFO] [stdout] --> src/services/flagger.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | if col.get(0).map(|v| v == branch_name).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `col.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/services/flagger.rs:103:91 [INFO] [stdout] | [INFO] [stdout] 103 | if cell.as_str() == "Coca-Cola (330 ML x 24 AD) KOLİ" && cc_situation { [INFO] [stdout] | ___________________________________________________________________________________________^ [INFO] [stdout] 104 | | continue; [INFO] [stdout] 105 | | } else if cell.as_str() == "Coca-Cola Zero (330 ML x 24 AD) KOLİ" [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/services/flagger.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | / { [INFO] [stdout] 108 | | continue; [INFO] [stdout] 109 | | } else { [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `columns` [INFO] [stdout] --> src/services/flagger.rs:185:18 [INFO] [stdout] | [INFO] [stdout] 185 | for i in 0..col_count { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 185 - for i in 0..col_count { [INFO] [stdout] 185 + for (i, ) in columns.iter_mut().enumerate().take(col_count) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `col.get(0)` [INFO] [stdout] --> src/services/flagger.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 192 | if col.get(0).map(|v| v == branch_name).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `col.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/services/trendyol.rs:160:21 [INFO] [stdout] | [INFO] [stdout] 160 | / for modifier_group in &product.modifier_groups { [INFO] [stdout] 161 | | if let Some(modifier_group) = modifier_group { [INFO] [stdout] 162 | | modifier_group_ids.push(modifier_group.modifier_group_id); [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/services/trendyol.rs:161:25 [INFO] [stdout] | [INFO] [stdout] 161 | / if let Some(modifier_group) = modifier_group { [INFO] [stdout] 162 | | modifier_group_ids.push(modifier_group.modifier_group_id); [INFO] [stdout] 163 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 160 ~ for modifier_group in product.modifier_groups.iter().flatten() { [INFO] [stdout] 161 + modifier_group_ids.push(modifier_group.modifier_group_id); [INFO] [stdout] 162 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/trendyol.rs:289:85 [INFO] [stdout] | [INFO] [stdout] 289 | let branch_name_mapped = find_value_by_key_in_json(DIRECTORY_BRANCH_NAMES_JSON, &branch_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `branch_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:447:13 [INFO] [stdout] | [INFO] [stdout] 447 | / if row["type"] == "Option" { [INFO] [stdout] 448 | | if let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 449 | | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 450 | | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] ... | [INFO] [stdout] 453 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 447 ~ if row["type"] == "Option" [INFO] [stdout] 448 ~ && let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 449 | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 450 | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 451 | category_rows.entry(cat_id).or_default().push(row); [INFO] [stdout] 452 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:472:13 [INFO] [stdout] | [INFO] [stdout] 472 | / if group.len() > 2 { [INFO] [stdout] 473 | | if let Some(i) = true_flag_index { [INFO] [stdout] 474 | | if group[i]["urun_id"] == json!(58579) { [INFO] [stdout] 475 | | group[i]["flag"] = json!(false); [INFO] [stdout] ... | [INFO] [stdout] 492 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 472 ~ if group.len() > 2 [INFO] [stdout] 473 ~ && let Some(i) = true_flag_index { [INFO] [stdout] 474 | if group[i]["urun_id"] == json!(58579) { [INFO] [stdout] ... [INFO] [stdout] 490 | } [INFO] [stdout] 491 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:473:17 [INFO] [stdout] | [INFO] [stdout] 473 | / if let Some(i) = true_flag_index { [INFO] [stdout] 474 | | if group[i]["urun_id"] == json!(58579) { [INFO] [stdout] 475 | | group[i]["flag"] = json!(false); [INFO] [stdout] ... | [INFO] [stdout] 491 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 473 ~ if let Some(i) = true_flag_index [INFO] [stdout] 474 ~ && group[i]["urun_id"] == json!(58579) { [INFO] [stdout] 475 | group[i]["flag"] = json!(false); [INFO] [stdout] ... [INFO] [stdout] 489 | } [INFO] [stdout] 490 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:498:13 [INFO] [stdout] | [INFO] [stdout] 498 | / if row["type"] == "Product" { [INFO] [stdout] 499 | | if let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 500 | | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... | [INFO] [stdout] 544 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 498 ~ if row["type"] == "Product" [INFO] [stdout] 499 ~ && let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 500 | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... [INFO] [stdout] 542 | } [INFO] [stdout] 543 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/trendyol.rs:503:25 [INFO] [stdout] | [INFO] [stdout] 503 | / if let Some(cat_id) = modifier.as_i64() { [INFO] [stdout] 504 | | if let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 505 | | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... | [INFO] [stdout] 541 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 503 ~ if let Some(cat_id) = modifier.as_i64() [INFO] [stdout] 504 ~ && let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 505 | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... [INFO] [stdout] 539 | } [INFO] [stdout] 540 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/services/trendyol.rs:555:34 [INFO] [stdout] | [INFO] [stdout] 555 | let sorted_all: Vec = updated_rows_by_store [INFO] [stdout] | __________________________________^ [INFO] [stdout] 556 | | .into_iter() [INFO] [stdout] 557 | | .flat_map(|(_store_id, rows)| { [INFO] [stdout] ... | [INFO] [stdout] 589 | | all [INFO] [stdout] 590 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 555 ~ let sorted_all: Vec = updated_rows_by_store.into_values().flat_map(|rows| { [INFO] [stdout] 556 ~ // Tüm Product ID'leri çıkar [INFO] [stdout] 557 + let product_ids: std::collections::HashSet = rows [INFO] [stdout] 558 + .iter() [INFO] [stdout] 559 + .filter(|r| r["type"] == "Product") [INFO] [stdout] 560 + .filter_map(|r| r["product_id"].as_i64().map(|id| id.to_string())) [INFO] [stdout] 561 + .collect(); [INFO] [stdout] 562 + [INFO] [stdout] 563 ~ // Sıralama fonksiyonu [INFO] [stdout] 564 + let sort_key = |r: &Value| { [INFO] [stdout] 565 + let flag = r.get("flag"); [INFO] [stdout] 566 + let type_ = r["type"].as_str().unwrap_or(""); [INFO] [stdout] 567 + let pid = r["product_id"].as_i64().map(|id| id.to_string()); [INFO] [stdout] 568 + let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 569 + [INFO] [stdout] 570 + match flag { [INFO] [stdout] 571 + Some(val) if val == &json!(false) => match type_ { [INFO] [stdout] 572 + "Product" => (0, 0), [INFO] [stdout] 573 + "Option" => (1, if is_linked { 0 } else { 1 }), [INFO] [stdout] 574 + _ => (2, 0), [INFO] [stdout] 575 + }, [INFO] [stdout] 576 + Some(val) if val == &json!(true) => match type_ { [INFO] [stdout] 577 + "Option" => (3, if is_linked { 1 } else { 0 }), [INFO] [stdout] 578 + "Product" => (4, 0), [INFO] [stdout] 579 + _ => (4, 1), [INFO] [stdout] 580 + }, [INFO] [stdout] 581 + _ => (5, 0), // flag null veya eksik [INFO] [stdout] 582 + } [INFO] [stdout] 583 + }; [INFO] [stdout] 584 + [INFO] [stdout] 585 + let mut all = rows.clone(); [INFO] [stdout] 586 + all.sort_by_key(|r| sort_key(r)); [INFO] [stdout] 587 + all [INFO] [stdout] 588 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/services/trendyol.rs:570:33 [INFO] [stdout] | [INFO] [stdout] 570 | let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 570 - let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 570 + let is_linked = pid.as_ref().is_some_and(|id| product_ids.contains(id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/trendyol.rs:709:15 [INFO] [stdout] | [INFO] [stdout] 709 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:131:15 [INFO] [stdout] | [INFO] [stdout] 131 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:246:15 [INFO] [stdout] | [INFO] [stdout] 246 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:361:15 [INFO] [stdout] | [INFO] [stdout] 361 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/roof.rs:477:15 [INFO] [stdout] | [INFO] [stdout] 477 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/services/yemeksepeti.rs:169:19 [INFO] [stdout] | [INFO] [stdout] 169 | let menu_id = response [INFO] [stdout] | ___________________^ [INFO] [stdout] 170 | | .data [INFO] [stdout] 171 | | .get(0) [INFO] [stdout] 172 | | .and_then(|data| Some(data.menu_id.clone())) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 169 ~ let menu_id = response [INFO] [stdout] 170 + .data [INFO] [stdout] 171 + .get(0).map(|data| data.menu_id.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response [INFO] [stdout] .data.get(0)` [INFO] [stdout] --> src/services/yemeksepeti.rs:169:19 [INFO] [stdout] | [INFO] [stdout] 169 | let menu_id = response [INFO] [stdout] | ___________________^ [INFO] [stdout] 170 | | .data [INFO] [stdout] 171 | | .get(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 169 ~ let menu_id = response [INFO] [stdout] 170 + .data.first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/services/yemeksepeti.rs:172:31 [INFO] [stdout] | [INFO] [stdout] 172 | .and_then(|data| Some(data.menu_id.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `data.menu_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:255:41 [INFO] [stdout] | [INFO] [stdout] 255 | let raw_response = http_request_get(&yemeksepeti_url_modifiers, yemeksepeti_menu_headers) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `yemeksepeti_url_modifiers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:292:41 [INFO] [stdout] | [INFO] [stdout] 292 | let raw_response = http_request_get(&yemeksepeti_url_toppings, yemeksepeti_menu_headers) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `yemeksepeti_url_toppings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/services/yemeksepeti.rs:392:24 [INFO] [stdout] | [INFO] [stdout] 392 | && !choice.variation_prices.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `choice.variation_prices.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:507:85 [INFO] [stdout] | [INFO] [stdout] 507 | let branch_name_mapped = find_value_by_key_in_json(DIRECTORY_BRANCH_NAMES_JSON, &branch_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `branch_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/yemeksepeti.rs:516:21 [INFO] [stdout] | [INFO] [stdout] 516 | / if row.len() >= 2 { [INFO] [stdout] 517 | | if let (Ok(urun_id), Ok(remote_code)) = [INFO] [stdout] 518 | | (row[0].parse::(), row[1].parse::()) [INFO] [stdout] ... | [INFO] [stdout] 522 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 516 ~ if row.len() >= 2 [INFO] [stdout] 517 ~ && let (Ok(urun_id), Ok(remote_code)) = [INFO] [stdout] 518 | (row[0].parse::(), row[1].parse::()) [INFO] [stdout] 519 | { [INFO] [stdout] 520 | map.insert(remote_code, urun_id); [INFO] [stdout] 521 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/yemeksepeti.rs:677:13 [INFO] [stdout] | [INFO] [stdout] 677 | / if row["type"] == "Option" { [INFO] [stdout] 678 | | if let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 679 | | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 680 | | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 681 | | } [INFO] [stdout] 682 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 677 ~ if row["type"] == "Option" [INFO] [stdout] 678 ~ && let Some(cat_id) = row["category_id"].as_i64() { [INFO] [stdout] 679 | let val = row["flag"].as_bool().unwrap_or(false); [INFO] [stdout] 680 | category_flags.entry(cat_id).or_default().push(val); [INFO] [stdout] 681 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/yemeksepeti.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 688 | / if row["type"] == "Product" { [INFO] [stdout] 689 | | if let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 690 | | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... | [INFO] [stdout] 734 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 688 ~ if row["type"] == "Product" [INFO] [stdout] 689 ~ && let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 690 | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... [INFO] [stdout] 732 | } [INFO] [stdout] 733 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/yemeksepeti.rs:693:25 [INFO] [stdout] | [INFO] [stdout] 693 | / if let Some(cat_id) = modifier.as_i64() { [INFO] [stdout] 694 | | if let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 695 | | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... | [INFO] [stdout] 731 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 693 ~ if let Some(cat_id) = modifier.as_i64() [INFO] [stdout] 694 ~ && let Some(flag_list) = category_flags.get(&cat_id) { [INFO] [stdout] 695 | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... [INFO] [stdout] 729 | } [INFO] [stdout] 730 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/services/yemeksepeti.rs:745:34 [INFO] [stdout] | [INFO] [stdout] 745 | let sorted_all: Vec = updated_rows_by_store [INFO] [stdout] | __________________________________^ [INFO] [stdout] 746 | | .into_iter() [INFO] [stdout] 747 | | .flat_map(|(_vendor_id, rows)| { [INFO] [stdout] ... | [INFO] [stdout] 779 | | all [INFO] [stdout] 780 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 745 ~ let sorted_all: Vec = updated_rows_by_store.into_values().flat_map(|rows| { [INFO] [stdout] 746 ~ // Tüm Product ID'leri çıkar [INFO] [stdout] 747 + let product_ids: std::collections::HashSet = rows [INFO] [stdout] 748 + .iter() [INFO] [stdout] 749 + .filter(|r| r["type"] == "Product") [INFO] [stdout] 750 + .filter_map(|r| r["product_id"].as_i64().map(|id| id.to_string())) [INFO] [stdout] 751 + .collect(); [INFO] [stdout] 752 + [INFO] [stdout] 753 ~ // Sıralama fonksiyonu [INFO] [stdout] 754 + let sort_key = |r: &Value| { [INFO] [stdout] 755 + let flag = r.get("flag"); [INFO] [stdout] 756 + let type_ = r["type"].as_str().unwrap_or(""); [INFO] [stdout] 757 + let pid = r["product_id"].as_i64().map(|id| id.to_string()); [INFO] [stdout] 758 + let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 759 + [INFO] [stdout] 760 + match flag { [INFO] [stdout] 761 + Some(val) if val == &json!(false) => match type_ { [INFO] [stdout] 762 + "Product" => (0, 0), [INFO] [stdout] 763 + "Option" => (1, if is_linked { 0 } else { 1 }), [INFO] [stdout] 764 + _ => (2, 0), [INFO] [stdout] 765 + }, [INFO] [stdout] 766 + Some(val) if val == &json!(true) => match type_ { [INFO] [stdout] 767 + "Option" => (3, if is_linked { 1 } else { 0 }), [INFO] [stdout] 768 + "Product" => (4, 0), [INFO] [stdout] 769 + _ => (4, 1), [INFO] [stdout] 770 + }, [INFO] [stdout] 771 + _ => (5, 0), // flag null veya eksik [INFO] [stdout] 772 + } [INFO] [stdout] 773 + }; [INFO] [stdout] 774 + [INFO] [stdout] 775 + let mut all = rows.clone(); [INFO] [stdout] 776 + all.sort_by_key(|r| sort_key(r)); [INFO] [stdout] 777 + all [INFO] [stdout] 778 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/services/yemeksepeti.rs:760:33 [INFO] [stdout] | [INFO] [stdout] 760 | let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 760 - let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 760 + let is_linked = pid.as_ref().is_some_and(|id| product_ids.contains(id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:832:9 [INFO] [stdout] | [INFO] [stdout] 832 | &YEMEKSEPETI_URL_STATUS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `YEMEKSEPETI_URL_STATUS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/yemeksepeti.rs:887:9 [INFO] [stdout] | [INFO] [stdout] 887 | &YEMEKSEPETI_URL_STATUS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `YEMEKSEPETI_URL_STATUS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/yemeksepeti.rs:916:15 [INFO] [stdout] | [INFO] [stdout] 916 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/services/getir.rs:191:26 [INFO] [stdout] | [INFO] [stdout] 191 | .with_context(|| format!("❌ Products yanıtı parse edilemedi."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"❌ Products yanıtı parse edilemedi.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/services/getir.rs:223:26 [INFO] [stdout] | [INFO] [stdout] 223 | .with_context(|| format!("❌ Menü yanıtı parse edilemedi."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"❌ Menü yanıtı parse edilemedi.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/services/getir.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | / for product_modifier_group in &product.modifier_groups { [INFO] [stdout] 277 | | if let Some(product_modifier_group) = product_modifier_group { [INFO] [stdout] 278 | | let modifier_group_id = &product_modifier_group.modifier_group_id; [INFO] [stdout] 279 | | product_modifier_group_ids.push(modifier_group_id.clone()); [INFO] [stdout] 280 | | } [INFO] [stdout] 281 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/services/getir.rs:277:25 [INFO] [stdout] | [INFO] [stdout] 277 | / if let Some(product_modifier_group) = product_modifier_group { [INFO] [stdout] 278 | | let modifier_group_id = &product_modifier_group.modifier_group_id; [INFO] [stdout] 279 | | product_modifier_group_ids.push(modifier_group_id.clone()); [INFO] [stdout] 280 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 276 ~ for product_modifier_group in product.modifier_groups.iter().flatten() { [INFO] [stdout] 277 + let modifier_group_id = &product_modifier_group.modifier_group_id; [INFO] [stdout] 278 + product_modifier_group_ids.push(modifier_group_id.clone()); [INFO] [stdout] 279 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/getir.rs:436:85 [INFO] [stdout] | [INFO] [stdout] 436 | let branch_name_mapped = find_value_by_key_in_json(DIRECTORY_BRANCH_NAMES_JSON, &branch_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `branch_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/getir.rs:601:13 [INFO] [stdout] | [INFO] [stdout] 601 | / if row["type"] == "Option" { [INFO] [stdout] 602 | | if let Some(cat_id) = row["category_id"].as_str() { [INFO] [stdout] 603 | | let flag_val = match row.get("flag") { [INFO] [stdout] 604 | | Some(Value::Bool(b)) => *b, [INFO] [stdout] ... | [INFO] [stdout] 620 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 601 ~ if row["type"] == "Option" [INFO] [stdout] 602 ~ && let Some(cat_id) = row["category_id"].as_str() { [INFO] [stdout] 603 | let flag_val = match row.get("flag") { [INFO] [stdout] ... [INFO] [stdout] 618 | .push(flag_val); [INFO] [stdout] 619 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/getir.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | / if row["type"] == "Product" { [INFO] [stdout] 627 | | if let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 628 | | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... | [INFO] [stdout] 672 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 626 ~ if row["type"] == "Product" [INFO] [stdout] 627 ~ && let Some(modifiers) = row["modifier_group_ids"].as_array() { [INFO] [stdout] 628 | let modifiers_cloned = modifiers.clone(); [INFO] [stdout] ... [INFO] [stdout] 670 | } [INFO] [stdout] 671 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/getir.rs:631:25 [INFO] [stdout] | [INFO] [stdout] 631 | / if let Some(cat_id) = modifier.as_str() { [INFO] [stdout] 632 | | if let Some(flag_list) = category_flags.get(cat_id) { [INFO] [stdout] 633 | | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... | [INFO] [stdout] 669 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 631 ~ if let Some(cat_id) = modifier.as_str() [INFO] [stdout] 632 ~ && let Some(flag_list) = category_flags.get(cat_id) { [INFO] [stdout] 633 | let has_true = flag_list.iter().any(|&f| f); [INFO] [stdout] ... [INFO] [stdout] 667 | } [INFO] [stdout] 668 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/services/getir.rs:683:34 [INFO] [stdout] | [INFO] [stdout] 683 | let sorted_all: Vec = updated_rows_by_store [INFO] [stdout] | __________________________________^ [INFO] [stdout] 684 | | .into_iter() [INFO] [stdout] 685 | | .flat_map(|(_store_id, rows)| { [INFO] [stdout] ... | [INFO] [stdout] 717 | | all [INFO] [stdout] 718 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 683 ~ let sorted_all: Vec = updated_rows_by_store.into_values().flat_map(|rows| { [INFO] [stdout] 684 ~ // Tüm Product ID'leri çıkar [INFO] [stdout] 685 + let product_ids: std::collections::HashSet = rows [INFO] [stdout] 686 + .iter() [INFO] [stdout] 687 + .filter(|r| r["type"] == "Product") [INFO] [stdout] 688 + .filter_map(|r| r["product_id"].as_str().map(|id| id.to_string())) [INFO] [stdout] 689 + .collect(); [INFO] [stdout] 690 + [INFO] [stdout] 691 ~ // Sıralama fonksiyonu [INFO] [stdout] 692 + let sort_key = |r: &Value| { [INFO] [stdout] 693 + let flag = r.get("flag"); [INFO] [stdout] 694 + let type_ = r["type"].as_str().unwrap_or(""); [INFO] [stdout] 695 + let pid = r["product_id"].as_str().map(|id| id.to_string()); [INFO] [stdout] 696 + let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 697 + [INFO] [stdout] 698 + match flag { [INFO] [stdout] 699 + Some(val) if val == &json!(false) => match type_ { [INFO] [stdout] 700 + "Product" => (0, 0), [INFO] [stdout] 701 + "Option" => (1, if is_linked { 0 } else { 1 }), [INFO] [stdout] 702 + _ => (2, 0), [INFO] [stdout] 703 + }, [INFO] [stdout] 704 + Some(val) if val == &json!(true) => match type_ { [INFO] [stdout] 705 + "Option" => (3, if is_linked { 1 } else { 0 }), [INFO] [stdout] 706 + "Product" => (4, 0), [INFO] [stdout] 707 + _ => (4, 1), [INFO] [stdout] 708 + }, [INFO] [stdout] 709 + _ => (5, 0), // flag null veya eksik [INFO] [stdout] 710 + } [INFO] [stdout] 711 + }; [INFO] [stdout] 712 + [INFO] [stdout] 713 + let mut all = rows.clone(); [INFO] [stdout] 714 + all.sort_by_key(|r| sort_key(r)); [INFO] [stdout] 715 + all [INFO] [stdout] 716 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/services/getir.rs:698:33 [INFO] [stdout] | [INFO] [stdout] 698 | let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 698 - let is_linked = pid.as_ref().map_or(false, |id| product_ids.contains(id)); [INFO] [stdout] 698 + let is_linked = pid.as_ref().is_some_and(|id| product_ids.contains(id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/services/getir.rs:757:42 [INFO] [stdout] | [INFO] [stdout] 757 | &GETIR_URL_STATUS.replacen("{}", &product_id.to_string(), 1), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `product_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/services/getir.rs:798:42 [INFO] [stdout] | [INFO] [stdout] 798 | &GETIR_URL_STATUS.replacen("{}", &product_id.to_string(), 1), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `product_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/services/getir.rs:826:15 [INFO] [stdout] | [INFO] [stdout] 826 | progress: Arc< [INFO] [stdout] | _______________^ [INFO] [stdout] 827 | | tokio::sync::Mutex>>, [INFO] [stdout] 828 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/gui/main_window.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | progress: Arc>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/main_window.rs:303:37 [INFO] [stdout] | [INFO] [stdout] 303 | / ... if let Ok(progress_map) = self.progress.try_lock() { [INFO] [stdout] 304 | | ... if let Some(Some((current, total))) = [INFO] [stdout] 305 | | ... progress_map.get(&platform.to_lowercase()) [INFO] [stdout] ... | [INFO] [stdout] 320 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 303 ~ if let Ok(progress_map) = self.progress.try_lock() [INFO] [stdout] 304 ~ && let Some(Some((current, total))) = [INFO] [stdout] 305 | progress_map.get(&platform.to_lowercase()) [INFO] [stdout] ... [INFO] [stdout] 318 | } [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/main_window.rs:304:41 [INFO] [stdout] | [INFO] [stdout] 304 | / ... if let Some(Some((current, total))) = [INFO] [stdout] 305 | | ... progress_map.get(&platform.to_lowercase()) [INFO] [stdout] 306 | | ... { [INFO] [stdout] 307 | | ... if *total > 0 { [INFO] [stdout] ... | [INFO] [stdout] 319 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 305 ~ progress_map.get(&platform.to_lowercase()) [INFO] [stdout] 306 ~ && *total > 0 { [INFO] [stdout] 307 | ui.add( [INFO] [stdout] ... [INFO] [stdout] 316 | ); [INFO] [stdout] 317 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 42s [INFO] running `Command { std: "docker" "inspect" "f1b3f23bea33bd93add08f274d173a3eeb40923170457226cea4447543840544", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1b3f23bea33bd93add08f274d173a3eeb40923170457226cea4447543840544", kill_on_drop: false }` [INFO] [stdout] f1b3f23bea33bd93add08f274d173a3eeb40923170457226cea4447543840544