[INFO] cloning repository https://github.com/higumachan/programming_bitcoin_book_in_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/higumachan/programming_bitcoin_book_in_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhigumachan%2Fprogramming_bitcoin_book_in_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhigumachan%2Fprogramming_bitcoin_book_in_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 219ff95ff59654c7a0d977bad882632cfc8b54bf [INFO] linting higumachan/programming_bitcoin_book_in_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhigumachan%2Fprogramming_bitcoin_book_in_rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/higumachan/programming_bitcoin_book_in_rust [INFO] finished tweaking git repo https://github.com/higumachan/programming_bitcoin_book_in_rust [INFO] tweaked toml for git repo https://github.com/higumachan/programming_bitcoin_book_in_rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/higumachan/programming_bitcoin_book_in_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/higumachan/programming_bitcoin_book_in_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-complex v0.4.0 [INFO] [stderr] Downloaded num v0.4.0 [INFO] [stderr] Downloaded num-integer v0.1.44 [INFO] [stderr] Downloaded num-iter v0.1.42 [INFO] [stderr] Downloaded num-traits v0.2.14 [INFO] [stderr] Downloaded autocfg v1.0.1 [INFO] [stderr] Downloaded num-rational v0.4.0 [INFO] [stderr] Downloaded num-bigint v0.4.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] efbd0305bda370664ba1f20d328cddff7410c8b09b244e4b2a9089c301cf90a6 [INFO] running `Command { std: "docker" "start" "-a" "efbd0305bda370664ba1f20d328cddff7410c8b09b244e4b2a9089c301cf90a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "efbd0305bda370664ba1f20d328cddff7410c8b09b244e4b2a9089c301cf90a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efbd0305bda370664ba1f20d328cddff7410c8b09b244e4b2a9089c301cf90a6", kill_on_drop: false }` [INFO] [stdout] efbd0305bda370664ba1f20d328cddff7410c8b09b244e4b2a9089c301cf90a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fe5e37100404d7fa1690024092da5edcf5a69c4228f9d1777d09098f917b4f4 [INFO] running `Command { std: "docker" "start" "-a" "5fe5e37100404d7fa1690024092da5edcf5a69c4228f9d1777d09098f917b4f4", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-bigint v0.4.2 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Checking encriptions v0.1.0 (/opt/rustwide/workdir/crates/encriptions) [INFO] [stdout] warning: unused import: `num::traits::real::Real` [INFO] [stdout] --> crates/encriptions/src/curve.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use num::traits::real::Real; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AddAssign`, `Add`, and `Mul` [INFO] [stdout] --> crates/encriptions/src/curve.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ops::{Add, AddAssign, Mul}; [INFO] [stdout] | ^^^ ^^^^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `f64FieldElement` should have an upper camel case name [INFO] [stdout] --> crates/encriptions/src/field.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | pub struct f64FieldElement(f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `F64fieldElement` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Float` [INFO] [stdout] --> crates/encriptions/src/point.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | use num::{BigInt, Float}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> crates/encriptions/src/point.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `y2.clone() - y1.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> crates/encriptions/src/point.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 102 - T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] 102 + T::from(y2.clone() - y1.clone() ) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> crates/encriptions/src/point.rs:102:70 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `x2.clone() - x1.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> crates/encriptions/src/point.rs:102:70 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 102 - T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] 102 + T::from((y2.clone() - y1.clone())) / T::from(x2.clone() - x1.clone() ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num::traits::real::Real` [INFO] [stdout] --> crates/encriptions/src/curve.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use num::traits::real::Real; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AddAssign`, `Add`, and `Mul` [INFO] [stdout] --> crates/encriptions/src/curve.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ops::{Add, AddAssign, Mul}; [INFO] [stdout] | ^^^ ^^^^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `f64FieldElement` should have an upper camel case name [INFO] [stdout] --> crates/encriptions/src/field.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | pub struct f64FieldElement(f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `F64fieldElement` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Float` [INFO] [stdout] --> crates/encriptions/src/point.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | use num::{BigInt, Float}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> crates/encriptions/src/point.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `y2.clone() - y1.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> crates/encriptions/src/point.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 102 - T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] 102 + T::from(y2.clone() - y1.clone() ) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> crates/encriptions/src/point.rs:102:70 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `x2.clone() - x1.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> crates/encriptions/src/point.rs:102:70 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 102 - T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] 102 + T::from((y2.clone() - y1.clone())) / T::from(x2.clone() - x1.clone() ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::Pow` [INFO] [stdout] --> crates/encriptions/src/curve.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use num_traits::Pow; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> crates/encriptions/src/point.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 73 | fn mul(self, rhs: PointOnCurve) -> Self::Output { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Prime` is never used [INFO] [stdout] --> crates/encriptions/src/field.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | pub trait Prime { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Prime13` is never constructed [INFO] [stdout] --> crates/encriptions/src/field.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | def_prime_struct!(Prime13, 13); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `def_prime_struct` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Prime19` is never constructed [INFO] [stdout] --> crates/encriptions/src/field.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | def_prime_struct!(Prime19, 19); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `def_prime_struct` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Prime29` is never constructed [INFO] [stdout] --> crates/encriptions/src/field.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 26 | def_prime_struct!(Prime29, 29); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `def_prime_struct` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Prime223` is never constructed [INFO] [stdout] --> crates/encriptions/src/field.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 27 | def_prime_struct!(Prime223, 223); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `def_prime_struct` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FiniteFieldElement` is never constructed [INFO] [stdout] --> crates/encriptions/src/field.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct FiniteFieldElement(BigUint, PhantomData

); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new` and `new_from_u64` are never used [INFO] [stdout] --> crates/encriptions/src/field.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl FiniteFieldElement

{ [INFO] [stdout] | ------------------------------------ associated functions in this implementation [INFO] [stdout] 48 | pub fn new(value: BigUint) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub fn new_from_u64(value: u64) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rem_euclid` is never used [INFO] [stdout] --> crates/encriptions/src/field.rs:119:4 [INFO] [stdout] | [INFO] [stdout] 119 | fn rem_euclid(a: &BigInt, b: &BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `f64FieldElement` is never constructed [INFO] [stdout] --> crates/encriptions/src/field.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | pub struct f64FieldElement(f64); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> crates/encriptions/src/curve.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | fn on<'a>(point: &impl Point) -> bool [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/curve.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 35 | impl<'a, T: Field + From> EllipticCurve for Secp256k1 { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/curve.rs:48:6 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a, T: Field + From> EllipticCurve for TestEllipticCurve { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/field.rs:133:6 [INFO] [stdout] | [INFO] [stdout] 133 | impl<'a, P: Prime + PartialEq> Field for FiniteFieldElement

{ [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/field.rs:192:6 [INFO] [stdout] | [INFO] [stdout] 192 | impl<'a> Field for f64FieldElement { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::Pow` [INFO] [stdout] --> crates/encriptions/src/curve.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use num_traits::Pow; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/point.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 21 | impl<'a, T: Field> GeneralPoint { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/point.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 27 | impl<'a, T: Field + Clone> Point for GeneralPoint { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/point.rs:46:6 [INFO] [stdout] | [INFO] [stdout] 46 | impl<'a, T: Field + Clone, C: EllipticCurve> PointOnCurve { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `T` [INFO] [stdout] --> crates/encriptions/src/point.rs:101:29 [INFO] [stdout] | [INFO] [stdout] 101 | let s = T::from( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 102 | | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] 103 | | ); [INFO] [stdout] | |_____________________^ help: consider removing `T::from()`: `(T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `T` [INFO] [stdout] --> crates/encriptions/src/point.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `T::from()`: `(y2.clone() - y1.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `T` [INFO] [stdout] --> crates/encriptions/src/point.rs:102:62 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `T::from()`: `(x2.clone() - x1.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> crates/encriptions/src/point.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 73 | fn mul(self, rhs: PointOnCurve) -> Self::Output { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> crates/encriptions/src/curve.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | fn on<'a>(point: &impl Point) -> bool [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking programming_bitcoin_book_in_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/curve.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 35 | impl<'a, T: Field + From> EllipticCurve for Secp256k1 { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/curve.rs:48:6 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a, T: Field + From> EllipticCurve for TestEllipticCurve { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/field.rs:133:6 [INFO] [stdout] | [INFO] [stdout] 133 | impl<'a, P: Prime + PartialEq> Field for FiniteFieldElement

{ [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/field.rs:192:6 [INFO] [stdout] | [INFO] [stdout] 192 | impl<'a> Field for f64FieldElement { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/point.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 21 | impl<'a, T: Field> GeneralPoint { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/point.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 27 | impl<'a, T: Field + Clone> Point for GeneralPoint { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> crates/encriptions/src/point.rs:46:6 [INFO] [stdout] | [INFO] [stdout] 46 | impl<'a, T: Field + Clone, C: EllipticCurve> PointOnCurve { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `T` [INFO] [stdout] --> crates/encriptions/src/point.rs:101:29 [INFO] [stdout] | [INFO] [stdout] 101 | let s = T::from( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 102 | | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] 103 | | ); [INFO] [stdout] | |_____________________^ help: consider removing `T::from()`: `(T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `T` [INFO] [stdout] --> crates/encriptions/src/point.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `T::from()`: `(y2.clone() - y1.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `T` [INFO] [stdout] --> crates/encriptions/src/point.rs:102:62 [INFO] [stdout] | [INFO] [stdout] 102 | T::from((y2.clone() - y1.clone())) / T::from((x2.clone() - x1.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `T::from()`: `(x2.clone() - x1.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/encriptions/src/point.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | / !(PointOnCurve::, Secp256k1>::new(GeneralPoint::finite( [INFO] [stdout] 232 | | FiniteFieldElement::from(200), [INFO] [stdout] 233 | | FiniteFieldElement::from(119) [INFO] [stdout] 234 | | ),) [INFO] [stdout] 235 | | .is_some()) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 231 ~ PointOnCurve::, Secp256k1>::new(GeneralPoint::finite( [INFO] [stdout] 232 + FiniteFieldElement::from(200), [INFO] [stdout] 233 + FiniteFieldElement::from(119) [INFO] [stdout] 234 + ),).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/encriptions/src/point.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 245 | / !(PointOnCurve::, Secp256k1>::new(GeneralPoint::finite( [INFO] [stdout] 246 | | FiniteFieldElement::from(42), [INFO] [stdout] 247 | | FiniteFieldElement::from(99) [INFO] [stdout] 248 | | ),) [INFO] [stdout] 249 | | .is_some()) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 245 ~ PointOnCurve::, Secp256k1>::new(GeneralPoint::finite( [INFO] [stdout] 246 + FiniteFieldElement::from(42), [INFO] [stdout] 247 + FiniteFieldElement::from(99) [INFO] [stdout] 248 + ),).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.76s [INFO] running `Command { std: "docker" "inspect" "5fe5e37100404d7fa1690024092da5edcf5a69c4228f9d1777d09098f917b4f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fe5e37100404d7fa1690024092da5edcf5a69c4228f9d1777d09098f917b4f4", kill_on_drop: false }` [INFO] [stdout] 5fe5e37100404d7fa1690024092da5edcf5a69c4228f9d1777d09098f917b4f4