[INFO] cloning repository https://github.com/hieuxyz00/hieuxyz_rpc_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hieuxyz00/hieuxyz_rpc_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhieuxyz00%2Fhieuxyz_rpc_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhieuxyz00%2Fhieuxyz_rpc_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6460bb8f3576ddcebb53e9f999bd6a43234ba97f [INFO] linting hieuxyz00/hieuxyz_rpc_rs/6460bb8f3576ddcebb53e9f999bd6a43234ba97f against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhieuxyz00%2Fhieuxyz_rpc_rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hieuxyz00/hieuxyz_rpc_rs [INFO] finished tweaking git repo https://github.com/hieuxyz00/hieuxyz_rpc_rs [INFO] tweaked toml for git repo https://github.com/hieuxyz00/hieuxyz_rpc_rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hieuxyz00/hieuxyz_rpc_rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hieuxyz00/hieuxyz_rpc_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tikv-jemallocator v0.6.1 [INFO] [stderr] Downloaded tikv-jemalloc-sys v0.6.1+5.3.0-1-ge13ca993e8ccb9ba9847cc330696e02839f328f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 33182ec2adbfd079b48d58b4644d992323d1b3f23f2a3f832c441d7330646c82 [INFO] running `Command { std: "docker" "start" "-a" "33182ec2adbfd079b48d58b4644d992323d1b3f23f2a3f832c441d7330646c82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "33182ec2adbfd079b48d58b4644d992323d1b3f23f2a3f832c441d7330646c82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33182ec2adbfd079b48d58b4644d992323d1b3f23f2a3f832c441d7330646c82", kill_on_drop: false }` [INFO] [stdout] 33182ec2adbfd079b48d58b4644d992323d1b3f23f2a3f832c441d7330646c82 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9785d55b7737e12ab2736322e9bb4e9f53cdd83b64d41b55662102f033214a10 [INFO] running `Command { std: "docker" "start" "-a" "9785d55b7737e12ab2736322e9bb4e9f53cdd83b64d41b55662102f033214a10", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Compiling aws-lc-rs v1.16.1 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling aws-lc-sys v0.38.0 [INFO] [stderr] Compiling tikv-jemalloc-sys v0.6.1+5.3.0-1-ge13ca993e8ccb9ba9847cc330696e02839f328f7 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tikv-jemallocator v0.6.1 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tungstenite v0.28.0 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking tokio-tungstenite v0.28.0 [INFO] [stderr] Checking hieuxyz_rpc v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/hieuxyz/client.rs:214:56 [INFO] [stdout] | [INFO] [stdout] 214 | let activities: Vec<_> = potential.into_iter().filter_map(|a| a).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/hieuxyz/client.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | / match val { [INFO] [stdout] 274 | | Value::Object(map) => { [INFO] [stdout] 275 | | let entries: Vec<_> = map.iter().collect(); [INFO] [stdout] 276 | | for (i, (k, v)) in entries.iter().enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 325 | | _ => {} [INFO] [stdout] 326 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 273 ~ if let Value::Object(map) = val { [INFO] [stdout] 274 + let entries: Vec<_> = map.iter().collect(); [INFO] [stdout] 275 + for (i, (k, v)) in entries.iter().enumerate() { [INFO] [stdout] 276 + let is_last = i == entries.len() - 1; [INFO] [stdout] 277 ~ let connector = if is_last { "└── " } else { "├── " }; [INFO] [stdout] 278 ~ let child_prefix = format!("{}{}", prefix, if is_last { " " } else { "│ " }); [INFO] [stdout] 279 + [INFO] [stdout] 280 + if v.is_object() && !v.is_array() { [INFO] [stdout] 281 + println!("{}{}\x1b[1m{}\x1b[0m", prefix, connector, k); [INFO] [stdout] 282 + self.printDynamicTree(v, &child_prefix, None); [INFO] [stdout] 283 + } else if v.is_array() { [INFO] [stdout] 284 + let display = if v.as_array().unwrap().is_empty() { "[Array(0)]".to_string() } else { [INFO] [stdout] 285 + let arr = v.as_array().unwrap(); [INFO] [stdout] 286 + if arr.len() > 0 && !arr[0].is_object() { [INFO] [stdout] 287 + let items: Vec = arr.iter().map(|i| i.to_string()).collect(); [INFO] [stdout] 288 + format!("[ {} ]", items.join(", ")) [INFO] [stdout] 289 + } else { [INFO] [stdout] 290 + format!("[Array({})]", arr.len()) [INFO] [stdout] 291 + } [INFO] [stdout] 292 + }; [INFO] [stdout] 293 + println!("{}{}{}: {}", prefix, connector, k, display); [INFO] [stdout] 294 + } else { [INFO] [stdout] 295 + let display = if *k == "email" || *k == "phone" { [INFO] [stdout] 296 + if !v.is_null() { "\x1b[90m\x1b[0m".to_string() } else { "null".to_string() } [INFO] [stdout] 297 + } else if *k == "flags" || *k == "public_flags" { [INFO] [stdout] 298 + if let Some(f) = v.as_u64() { Self::formatFlags(f) } else { "0".to_string() } [INFO] [stdout] 299 + } else if *k == "premium_type" { [INFO] [stdout] 300 + match v.as_u64() { [INFO] [stdout] 301 + Some(0) => "0 (\x1b[32mNone\x1b[0m)".to_string(), [INFO] [stdout] 302 + Some(1) => "1 (\x1b[32mClassic\x1b[0m)".to_string(), [INFO] [stdout] 303 + Some(2) => "2 (\x1b[32mNitro\x1b[0m)".to_string(), [INFO] [stdout] 304 + Some(3) => "3 (\x1b[32mBasic\x1b[0m)".to_string(), [INFO] [stdout] 305 + _ => format!("{} (\x1b[32mUnknown\x1b[0m)", v) [INFO] [stdout] 306 + } [INFO] [stdout] 307 + } else if *k == "avatar" || *k == "banner" { [INFO] [stdout] 308 + if v.is_null() { "null".to_string() } else { [INFO] [stdout] 309 + let s = v.as_str().unwrap_or(""); [INFO] [stdout] 310 + format!("\"{}\"", s) [INFO] [stdout] 311 + } [INFO] [stdout] 312 + } else if *k == "banner_color" || *k == "accent_color" { [INFO] [stdout] 313 + format!("\x1b[33m{}\x1b[0m", v) [INFO] [stdout] 314 + } else { [INFO] [stdout] 315 + if v.is_string() { format!("\"\x1b[32m{}\x1b[0m\"", v.as_str().unwrap()) } [INFO] [stdout] 316 + else if v.is_boolean() { if v.as_bool().unwrap() { "\x1b[32mtrue\x1b[0m".to_string() } else { "\x1b[31mfalse\x1b[0m".to_string() } } [INFO] [stdout] 317 + else if v.is_number() { format!("\x1b[33m{}\x1b[0m", v) } [INFO] [stdout] 318 + else { "null".to_string() } [INFO] [stdout] 319 + }; [INFO] [stdout] 320 + println!("{}{}{}: {}", prefix, connector, k, display); [INFO] [stdout] 321 + } [INFO] [stdout] 322 + } [INFO] [stdout] 323 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/hieuxyz/client.rs:287:33 [INFO] [stdout] | [INFO] [stdout] 287 | ... if arr.len() > 0 && !arr[0].is_object() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!arr.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/hieuxyz/client.rs:214:56 [INFO] [stdout] | [INFO] [stdout] 214 | let activities: Vec<_> = potential.into_iter().filter_map(|a| a).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/hieuxyz/gateway/discord_websocket.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub enum GatewayEvent { [INFO] [stdout] 17 | | Ready(DiscordUser), [INFO] [stdout] | | ------------------ the largest variant contains at least 336 bytes [INFO] [stdout] 18 | | Resumed, [INFO] [stdout] | | ------- the second-largest variant carries no data at all [INFO] [stdout] 19 | | Disconnected, [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ the entire enum is at least 336 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 17 - Ready(DiscordUser), [INFO] [stdout] 17 + Ready(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/hieuxyz/client.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | / match val { [INFO] [stdout] 274 | | Value::Object(map) => { [INFO] [stdout] 275 | | let entries: Vec<_> = map.iter().collect(); [INFO] [stdout] 276 | | for (i, (k, v)) in entries.iter().enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 325 | | _ => {} [INFO] [stdout] 326 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 273 ~ if let Value::Object(map) = val { [INFO] [stdout] 274 + let entries: Vec<_> = map.iter().collect(); [INFO] [stdout] 275 + for (i, (k, v)) in entries.iter().enumerate() { [INFO] [stdout] 276 + let is_last = i == entries.len() - 1; [INFO] [stdout] 277 ~ let connector = if is_last { "└── " } else { "├── " }; [INFO] [stdout] 278 ~ let child_prefix = format!("{}{}", prefix, if is_last { " " } else { "│ " }); [INFO] [stdout] 279 + [INFO] [stdout] 280 + if v.is_object() && !v.is_array() { [INFO] [stdout] 281 + println!("{}{}\x1b[1m{}\x1b[0m", prefix, connector, k); [INFO] [stdout] 282 + self.printDynamicTree(v, &child_prefix, None); [INFO] [stdout] 283 + } else if v.is_array() { [INFO] [stdout] 284 + let display = if v.as_array().unwrap().is_empty() { "[Array(0)]".to_string() } else { [INFO] [stdout] 285 + let arr = v.as_array().unwrap(); [INFO] [stdout] 286 + if arr.len() > 0 && !arr[0].is_object() { [INFO] [stdout] 287 + let items: Vec = arr.iter().map(|i| i.to_string()).collect(); [INFO] [stdout] 288 + format!("[ {} ]", items.join(", ")) [INFO] [stdout] 289 + } else { [INFO] [stdout] 290 + format!("[Array({})]", arr.len()) [INFO] [stdout] 291 + } [INFO] [stdout] 292 + }; [INFO] [stdout] 293 + println!("{}{}{}: {}", prefix, connector, k, display); [INFO] [stdout] 294 + } else { [INFO] [stdout] 295 + let display = if *k == "email" || *k == "phone" { [INFO] [stdout] 296 + if !v.is_null() { "\x1b[90m\x1b[0m".to_string() } else { "null".to_string() } [INFO] [stdout] 297 + } else if *k == "flags" || *k == "public_flags" { [INFO] [stdout] 298 + if let Some(f) = v.as_u64() { Self::formatFlags(f) } else { "0".to_string() } [INFO] [stdout] 299 + } else if *k == "premium_type" { [INFO] [stdout] 300 + match v.as_u64() { [INFO] [stdout] 301 + Some(0) => "0 (\x1b[32mNone\x1b[0m)".to_string(), [INFO] [stdout] 302 + Some(1) => "1 (\x1b[32mClassic\x1b[0m)".to_string(), [INFO] [stdout] 303 + Some(2) => "2 (\x1b[32mNitro\x1b[0m)".to_string(), [INFO] [stdout] 304 + Some(3) => "3 (\x1b[32mBasic\x1b[0m)".to_string(), [INFO] [stdout] 305 + _ => format!("{} (\x1b[32mUnknown\x1b[0m)", v) [INFO] [stdout] 306 + } [INFO] [stdout] 307 + } else if *k == "avatar" || *k == "banner" { [INFO] [stdout] 308 + if v.is_null() { "null".to_string() } else { [INFO] [stdout] 309 + let s = v.as_str().unwrap_or(""); [INFO] [stdout] 310 + format!("\"{}\"", s) [INFO] [stdout] 311 + } [INFO] [stdout] 312 + } else if *k == "banner_color" || *k == "accent_color" { [INFO] [stdout] 313 + format!("\x1b[33m{}\x1b[0m", v) [INFO] [stdout] 314 + } else { [INFO] [stdout] 315 + if v.is_string() { format!("\"\x1b[32m{}\x1b[0m\"", v.as_str().unwrap()) } [INFO] [stdout] 316 + else if v.is_boolean() { if v.as_bool().unwrap() { "\x1b[32mtrue\x1b[0m".to_string() } else { "\x1b[31mfalse\x1b[0m".to_string() } } [INFO] [stdout] 317 + else if v.is_number() { format!("\x1b[33m{}\x1b[0m", v) } [INFO] [stdout] 318 + else { "null".to_string() } [INFO] [stdout] 319 + }; [INFO] [stdout] 320 + println!("{}{}{}: {}", prefix, connector, k, display); [INFO] [stdout] 321 + } [INFO] [stdout] 322 + } [INFO] [stdout] 323 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/hieuxyz/client.rs:287:33 [INFO] [stdout] | [INFO] [stdout] 287 | ... if arr.len() > 0 && !arr[0].is_object() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!arr.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `sequence` after checking its variant with `is_some` [INFO] [stdout] --> src/hieuxyz/gateway/discord_websocket.rs:201:80 [INFO] [stdout] | [INFO] [stdout] 195 | ... if session_id.is_some() && sequence.is_some() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 201 | ... "seq": sequence.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/hieuxyz/gateway/discord_websocket.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub enum GatewayEvent { [INFO] [stdout] 17 | | Ready(DiscordUser), [INFO] [stdout] | | ------------------ the largest variant contains at least 336 bytes [INFO] [stdout] 18 | | Resumed, [INFO] [stdout] | | ------- the second-largest variant carries no data at all [INFO] [stdout] 19 | | Disconnected, [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ the entire enum is at least 336 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 17 - Ready(DiscordUser), [INFO] [stdout] 17 + Ready(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `sequence` after checking its variant with `is_some` [INFO] [stdout] --> src/hieuxyz/gateway/discord_websocket.rs:201:80 [INFO] [stdout] | [INFO] [stdout] 195 | ... if session_id.is_some() && sequence.is_some() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 201 | ... "seq": sequence.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hieuxyz/gateway/discord_websocket.rs:271:37 [INFO] [stdout] | [INFO] [stdout] 271 | / ... if has_sent_first_heartbeat { [INFO] [stdout] 272 | | ... if last_ack_received < last_heartbeat_sent.checked_sub(Duration::from_secs(5)).unwrap_or(last_heartbeat_sent) { [INFO] [stdout] 273 | | ... logger::warn("Heartbeat ACK missing. Connection is zombie. Terminating to resume..."); [INFO] [stdout] 274 | | ... break; [INFO] [stdout] 275 | | ... } [INFO] [stdout] 276 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 271 ~ if has_sent_first_heartbeat [INFO] [stdout] 272 ~ && last_ack_received < last_heartbeat_sent.checked_sub(Duration::from_secs(5)).unwrap_or(last_heartbeat_sent) { [INFO] [stdout] 273 | logger::warn("Heartbeat ACK missing. Connection is zombie. Terminating to resume..."); [INFO] [stdout] 274 | break; [INFO] [stdout] 275 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hieuxyz/gateway/discord_websocket.rs:271:37 [INFO] [stdout] | [INFO] [stdout] 271 | / ... if has_sent_first_heartbeat { [INFO] [stdout] 272 | | ... if last_ack_received < last_heartbeat_sent.checked_sub(Duration::from_secs(5)).unwrap_or(last_heartbeat_sent) { [INFO] [stdout] 273 | | ... logger::warn("Heartbeat ACK missing. Connection is zombie. Terminating to resume..."); [INFO] [stdout] 274 | | ... break; [INFO] [stdout] 275 | | ... } [INFO] [stdout] 276 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 271 ~ if has_sent_first_heartbeat [INFO] [stdout] 272 ~ && last_ack_received < last_heartbeat_sent.checked_sub(Duration::from_secs(5)).unwrap_or(last_heartbeat_sent) { [INFO] [stdout] 273 | logger::warn("Heartbeat ACK missing. Connection is zombie. Terminating to resume..."); [INFO] [stdout] 274 | break; [INFO] [stdout] 275 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:318:63 [INFO] [stdout] | [INFO] [stdout] 318 | return format!("https://media.discordapp.net/{}", &assetKey[3..]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:317:9 [INFO] [stdout] | [INFO] [stdout] 317 | if assetKey.starts_with("mp:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 317 ~ if let Some() = assetKey.strip_prefix("mp:") { [INFO] [stdout] 318 ~ return format!("https://media.discordapp.net/{}", ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:321:58 [INFO] [stdout] | [INFO] [stdout] 321 | return format!("https://i.scdn.co/image/{}", &assetKey[8..]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | if assetKey.starts_with("spotify:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 320 ~ if let Some() = assetKey.strip_prefix("spotify:") { [INFO] [stdout] 321 ~ return format!("https://i.scdn.co/image/{}", ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:324:71 [INFO] [stdout] | [INFO] [stdout] 324 | return format!("https://i.ytimg.com/vi/{}/hqdefault.jpg", &assetKey[8..]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | if assetKey.starts_with("youtube:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 323 ~ if let Some() = assetKey.strip_prefix("youtube:") { [INFO] [stdout] 324 ~ return format!("https://i.ytimg.com/vi/{}/hqdefault.jpg", ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:329:17 [INFO] [stdout] | [INFO] [stdout] 329 | &assetKey[7..] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | if assetKey.starts_with("twitch:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 326 ~ if let Some() = assetKey.strip_prefix("twitch:") { [INFO] [stdout] 327 | return format!( [INFO] [stdout] 328 | "https://static-cdn.jtvnw.net/previews-ttv/live_user_{}.png", [INFO] [stdout] 329 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:318:63 [INFO] [stdout] | [INFO] [stdout] 318 | return format!("https://media.discordapp.net/{}", &assetKey[3..]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:317:9 [INFO] [stdout] | [INFO] [stdout] 317 | if assetKey.starts_with("mp:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 317 ~ if let Some() = assetKey.strip_prefix("mp:") { [INFO] [stdout] 318 ~ return format!("https://media.discordapp.net/{}", ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:321:58 [INFO] [stdout] | [INFO] [stdout] 321 | return format!("https://i.scdn.co/image/{}", &assetKey[8..]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | if assetKey.starts_with("spotify:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 320 ~ if let Some() = assetKey.strip_prefix("spotify:") { [INFO] [stdout] 321 ~ return format!("https://i.scdn.co/image/{}", ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:324:71 [INFO] [stdout] | [INFO] [stdout] 324 | return format!("https://i.ytimg.com/vi/{}/hqdefault.jpg", &assetKey[8..]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | if assetKey.starts_with("youtube:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 323 ~ if let Some() = assetKey.strip_prefix("youtube:") { [INFO] [stdout] 324 ~ return format!("https://i.ytimg.com/vi/{}/hqdefault.jpg", ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:329:17 [INFO] [stdout] | [INFO] [stdout] 329 | &assetKey[7..] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | if assetKey.starts_with("twitch:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 326 ~ if let Some() = assetKey.strip_prefix("twitch:") { [INFO] [stdout] 327 | return format!( [INFO] [stdout] 328 | "https://static-cdn.jtvnw.net/previews-ttv/live_user_{}.png", [INFO] [stdout] 329 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:441:47 [INFO] [stdout] | [INFO] [stdout] 441 | RpcImage::Application(asset_id["app_asset:".len()..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:439:17 [INFO] [stdout] | [INFO] [stdout] 439 | if asset_id.starts_with("app_asset:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 439 ~ if let Some() = asset_id.strip_prefix("app_asset:") { [INFO] [stdout] 440 | let recursive_img = [INFO] [stdout] 441 ~ RpcImage::Application(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:441:47 [INFO] [stdout] | [INFO] [stdout] 441 | RpcImage::Application(asset_id["app_asset:".len()..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/hieuxyz/rpc/hieuxyz_rpc.rs:439:17 [INFO] [stdout] | [INFO] [stdout] 439 | if asset_id.starts_with("app_asset:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 439 ~ if let Some() = asset_id.strip_prefix("app_asset:") { [INFO] [stdout] 440 | let recursive_img = [INFO] [stdout] 441 ~ RpcImage::Application(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data.id` after checking its variant with `is_some` [INFO] [stdout] --> src/hieuxyz/rpc/image_service.rs:61:37 [INFO] [stdout] | [INFO] [stdout] 59 | if data.status == 200 && data.id.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 60 | return Some(UploadResult { [INFO] [stdout] 61 | id: data.id.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data.id` after checking its variant with `is_some` [INFO] [stdout] --> src/hieuxyz/rpc/image_service.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 98 | if data.status == 200 && data.id.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 99 | return Some(UploadResult { [INFO] [stdout] 100 | id: data.id.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data.id` after checking its variant with `is_some` [INFO] [stdout] --> src/hieuxyz/rpc/image_service.rs:61:37 [INFO] [stdout] | [INFO] [stdout] 59 | if data.status == 200 && data.id.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 60 | return Some(UploadResult { [INFO] [stdout] 61 | id: data.id.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | impl DiscordImage { pub fn new(key: &str) -> RpcImage { RpcImage::Discord(key.to_string()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | impl ExternalImage { pub fn new(url: &str) -> RpcImage { RpcImage::External(url.to_string()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data.id` after checking its variant with `is_some` [INFO] [stdout] --> src/hieuxyz/rpc/image_service.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 98 | if data.status == 200 && data.id.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 99 | return Some(UploadResult { [INFO] [stdout] 100 | id: data.id.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / pub fn new(filePath: &str, fileName: Option<&str>) -> RpcImage { [INFO] [stdout] 35 | | let name = fileName.map(|s| s.to_string()).unwrap_or_else(|| { [INFO] [stdout] 36 | | Path::new(filePath).file_name().unwrap_or_default().to_string_lossy().to_string() [INFO] [stdout] 37 | | }); [INFO] [stdout] 38 | | RpcImage::Local { path: filePath.to_string(), name } [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | impl RawImage { pub fn new(key: &str) -> RpcImage { RpcImage::Raw(key.to_string()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | impl ApplicationImage { pub fn new(name: &str) -> RpcImage { RpcImage::Application(name.to_string()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/hieuxyz/gateway/discord_websocket.rs:151:71 [INFO] [stdout] | [INFO] [stdout] 151 | ... let fatal_codes = vec![4004, 4010, 4011, 4013, 4014]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[4004, 4010, 4011, 4013, 4014]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | impl DiscordImage { pub fn new(key: &str) -> RpcImage { RpcImage::Discord(key.to_string()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | impl ExternalImage { pub fn new(url: &str) -> RpcImage { RpcImage::External(url.to_string()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / pub fn new(filePath: &str, fileName: Option<&str>) -> RpcImage { [INFO] [stdout] 35 | | let name = fileName.map(|s| s.to_string()).unwrap_or_else(|| { [INFO] [stdout] 36 | | Path::new(filePath).file_name().unwrap_or_default().to_string_lossy().to_string() [INFO] [stdout] 37 | | }); [INFO] [stdout] 38 | | RpcImage::Local { path: filePath.to_string(), name } [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | impl RawImage { pub fn new(key: &str) -> RpcImage { RpcImage::Raw(key.to_string()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hieuxyz/rpc/rpc_image.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | impl ApplicationImage { pub fn new(name: &str) -> RpcImage { RpcImage::Application(name.to_string()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/hieuxyz/gateway/discord_websocket.rs:151:71 [INFO] [stdout] | [INFO] [stdout] 151 | ... let fatal_codes = vec![4004, 4010, 4011, 4013, 4014]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[4004, 4010, 4011, 4013, 4014]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 21s [INFO] running `Command { std: "docker" "inspect" "9785d55b7737e12ab2736322e9bb4e9f53cdd83b64d41b55662102f033214a10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9785d55b7737e12ab2736322e9bb4e9f53cdd83b64d41b55662102f033214a10", kill_on_drop: false }` [INFO] [stdout] 9785d55b7737e12ab2736322e9bb4e9f53cdd83b64d41b55662102f033214a10