[INFO] cloning repository https://github.com/herring-under-fur-coat/bitcalc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/herring-under-fur-coat/bitcalc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fherring-under-fur-coat%2Fbitcalc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fherring-under-fur-coat%2Fbitcalc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d64e3b7b74543aee15df38b359d72b0a1e2b0ae [INFO] linting herring-under-fur-coat/bitcalc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fherring-under-fur-coat%2Fbitcalc" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/herring-under-fur-coat/bitcalc [INFO] finished tweaking git repo https://github.com/herring-under-fur-coat/bitcalc [INFO] tweaked toml for git repo https://github.com/herring-under-fur-coat/bitcalc written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/herring-under-fur-coat/bitcalc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/herring-under-fur-coat/bitcalc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d983c14290741472189cdcede3b7e74c836eaff628b56c2a6e6e714cc325628 [INFO] running `Command { std: "docker" "start" "-a" "8d983c14290741472189cdcede3b7e74c836eaff628b56c2a6e6e714cc325628", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d983c14290741472189cdcede3b7e74c836eaff628b56c2a6e6e714cc325628", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d983c14290741472189cdcede3b7e74c836eaff628b56c2a6e6e714cc325628", kill_on_drop: false }` [INFO] [stdout] 8d983c14290741472189cdcede3b7e74c836eaff628b56c2a6e6e714cc325628 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 67f86e348dd18643617c606b5fec8ce8772ee96b644aab75eeeaa5adb138e75c [INFO] running `Command { std: "docker" "start" "-a" "67f86e348dd18643617c606b5fec8ce8772ee96b644aab75eeeaa5adb138e75c", kill_on_drop: false }` [INFO] [stderr] Checking bitcalc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | tokens: tokens, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | tokens: tokens, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/evaluator.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return rest.fold(first, |acc, c| op(acc, ev(c.as_ref()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return rest.fold(first, |acc, c| op(acc, ev(c.as_ref()))); [INFO] [stdout] 32 + rest.fold(first, |acc, c| op(acc, ev(c.as_ref()))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/lexer.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn to_string(&self) -> String [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `lexer::Token` [INFO] [stdout] --> src/lexer.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn to_string(&self) -> String [INFO] [stdout] 27 | | { [INFO] [stdout] 28 | | match self { [INFO] [stdout] 29 | | Token::Plus => String::from("+"), [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `lexer::Token` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lexer.rs:42:33 [INFO] [stdout] | [INFO] [stdout] 42 | Token::Number(n) => String::from(format!("{n}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{n}")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 83 | if !num.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `num.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lexer.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | let num: Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `num` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 63 ~ [INFO] [stdout] 64 | [INFO] [stdout] 65 ~ let num: Result = if s.chars().count() >= 2 [INFO] [stdout] 66 | { [INFO] [stdout] 67 ~ match &s[0..2] [INFO] [stdout] 68 | { [INFO] [stdout] ... [INFO] [stdout] 75 | _ => u64::from_str_radix(&s, 10), [INFO] [stdout] 76 ~ } [INFO] [stdout] 77 | } [INFO] [stdout] 78 | else [INFO] [stdout] 79 | { [INFO] [stdout] 80 ~ u64::from_str_radix(&s, 10) [INFO] [stdout] 81 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/lexer.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | _ => u64::from_str_radix(&s, 10), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:75:53 [INFO] [stdout] | [INFO] [stdout] 75 | _ => u64::from_str_radix(&s, 10), [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/lexer.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | num = u64::from_str_radix(&s, 10); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:80:47 [INFO] [stdout] | [INFO] [stdout] 80 | num = u64::from_str_radix(&s, 10); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lexer.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | / if let Some(item) = s.chars().nth(i+1) [INFO] [stdout] 141 | | { [INFO] [stdout] 142 | | if item != c [INFO] [stdout] ... | [INFO] [stdout] 147 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 140 ~ if let Some(item) = s.chars().nth(i+1) [INFO] [stdout] 141 ~ && item != c [INFO] [stdout] 142 | { [INFO] [stdout] 143 | let inp = String::from(s); [INFO] [stdout] 144 | error::error_condition(ErrorType::Lexer(inp, i)); [INFO] [stdout] 145 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/lexer.rs:172:25 [INFO] [stdout] | [INFO] [stdout] 172 | / if i > 0 [INFO] [stdout] 173 | | { [INFO] [stdout] 174 | | i -= 1; [INFO] [stdout] 175 | | } [INFO] [stdout] | |_________________________^ help: try: `i = i.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/parser.rs:9:16 [INFO] [stdout] | [INFO] [stdout] 9 | pub child: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | f(self, &mut n.child.last_mut().unwrap().as_mut()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `n.child.last_mut().unwrap().as_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | f(self, &mut n.child.last_mut().unwrap().as_mut()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `n.child.last_mut().unwrap().as_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | fn main() -> () [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/main.rs:11:44 [INFO] [stdout] | [INFO] [stdout] 11 | println!("Usage: {} ", std::env::args().nth(0).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `std::env::args().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/evaluator.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return rest.fold(first, |acc, c| op(acc, ev(c.as_ref()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return rest.fold(first, |acc, c| op(acc, ev(c.as_ref()))); [INFO] [stdout] 32 + rest.fold(first, |acc, c| op(acc, ev(c.as_ref()))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/lexer.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn to_string(&self) -> String [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `lexer::Token` [INFO] [stdout] --> src/lexer.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn to_string(&self) -> String [INFO] [stdout] 27 | | { [INFO] [stdout] 28 | | match self { [INFO] [stdout] 29 | | Token::Plus => String::from("+"), [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `lexer::Token` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lexer.rs:42:33 [INFO] [stdout] | [INFO] [stdout] 42 | Token::Number(n) => String::from(format!("{n}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{n}")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 83 | if !num.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `num.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lexer.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | let num: Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `num` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 63 ~ [INFO] [stdout] 64 | [INFO] [stdout] 65 ~ let num: Result = if s.chars().count() >= 2 [INFO] [stdout] 66 | { [INFO] [stdout] 67 ~ match &s[0..2] [INFO] [stdout] 68 | { [INFO] [stdout] ... [INFO] [stdout] 75 | _ => u64::from_str_radix(&s, 10), [INFO] [stdout] 76 ~ } [INFO] [stdout] 77 | } [INFO] [stdout] 78 | else [INFO] [stdout] 79 | { [INFO] [stdout] 80 ~ u64::from_str_radix(&s, 10) [INFO] [stdout] 81 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/lexer.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | _ => u64::from_str_radix(&s, 10), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:75:53 [INFO] [stdout] | [INFO] [stdout] 75 | _ => u64::from_str_radix(&s, 10), [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/lexer.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | num = u64::from_str_radix(&s, 10); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:80:47 [INFO] [stdout] | [INFO] [stdout] 80 | num = u64::from_str_radix(&s, 10); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lexer.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | / if let Some(item) = s.chars().nth(i+1) [INFO] [stdout] 141 | | { [INFO] [stdout] 142 | | if item != c [INFO] [stdout] ... | [INFO] [stdout] 147 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 140 ~ if let Some(item) = s.chars().nth(i+1) [INFO] [stdout] 141 ~ && item != c [INFO] [stdout] 142 | { [INFO] [stdout] 143 | let inp = String::from(s); [INFO] [stdout] 144 | error::error_condition(ErrorType::Lexer(inp, i)); [INFO] [stdout] 145 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/lexer.rs:172:25 [INFO] [stdout] | [INFO] [stdout] 172 | / if i > 0 [INFO] [stdout] 173 | | { [INFO] [stdout] 174 | | i -= 1; [INFO] [stdout] 175 | | } [INFO] [stdout] | |_________________________^ help: try: `i = i.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/parser.rs:9:16 [INFO] [stdout] | [INFO] [stdout] 9 | pub child: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | f(self, &mut n.child.last_mut().unwrap().as_mut()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `n.child.last_mut().unwrap().as_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | f(self, &mut n.child.last_mut().unwrap().as_mut()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `n.child.last_mut().unwrap().as_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | fn main() -> () [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/main.rs:11:44 [INFO] [stdout] | [INFO] [stdout] 11 | println!("Usage: {} ", std::env::args().nth(0).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `std::env::args().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `Command { std: "docker" "inspect" "67f86e348dd18643617c606b5fec8ce8772ee96b644aab75eeeaa5adb138e75c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67f86e348dd18643617c606b5fec8ce8772ee96b644aab75eeeaa5adb138e75c", kill_on_drop: false }` [INFO] [stdout] 67f86e348dd18643617c606b5fec8ce8772ee96b644aab75eeeaa5adb138e75c