[INFO] cloning repository https://github.com/helloiamgio/kubie [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/helloiamgio/kubie" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhelloiamgio%2Fkubie", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhelloiamgio%2Fkubie'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d4be9a029da9c6a7569f82a66f32d56c08aef601 [INFO] linting helloiamgio/kubie against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhelloiamgio%2Fkubie" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/helloiamgio/kubie [INFO] finished tweaking git repo https://github.com/helloiamgio/kubie [INFO] tweaked toml for git repo https://github.com/helloiamgio/kubie written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/helloiamgio/kubie on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/helloiamgio/kubie already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_yaml v0.8.15 [INFO] [stderr] Downloaded wildmatch v1.0.13 [INFO] [stderr] Downloaded signal-hook v0.1.17 [INFO] [stderr] Downloaded dtoa v0.4.7 [INFO] [stderr] Downloaded backtrace v0.3.55 [INFO] [stderr] Downloaded anyhow v1.0.37 [INFO] [stderr] Downloaded flate2 v1.0.19 [INFO] [stderr] Downloaded attohttpc v0.16.0 [INFO] [stderr] Downloaded ring v0.16.19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c312ae4f0b49de4a78c5530e01ef7d1b45ee73617cea247ec13609fd4c384a48 [INFO] running `Command { std: "docker" "start" "-a" "c312ae4f0b49de4a78c5530e01ef7d1b45ee73617cea247ec13609fd4c384a48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c312ae4f0b49de4a78c5530e01ef7d1b45ee73617cea247ec13609fd4c384a48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c312ae4f0b49de4a78c5530e01ef7d1b45ee73617cea247ec13609fd4c384a48", kill_on_drop: false }` [INFO] [stdout] c312ae4f0b49de4a78c5530e01ef7d1b45ee73617cea247ec13609fd4c384a48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dad673044468bc5862c1e99f4c67c65d8d02810cedf0c54080a8080cd8638573 [INFO] running `Command { std: "docker" "start" "-a" "dad673044468bc5862c1e99f4c67c65d8d02810cedf0c54080a8080cd8638573", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Checking tinyvec v1.1.0 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking object v0.22.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking bytes v1.0.0 [INFO] [stderr] Compiling anyhow v1.0.37 [INFO] [stderr] Checking wildmatch v1.0.13 [INFO] [stderr] Checking dtoa v0.4.7 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking http v0.2.3 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking flate2 v1.0.19 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Compiling ring v0.16.19 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking unicode-normalization v0.1.16 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking addr2line v0.14.1 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking url v2.2.0 [INFO] [stderr] Checking backtrace v0.3.55 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking which v3.1.1 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.0 [INFO] [stderr] Checking rustls v0.18.1 [INFO] [stderr] Checking webpki-roots v0.19.0 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking serde_yaml v0.8.15 [INFO] [stderr] Checking attohttpc v0.16.0 [INFO] [stderr] Checking kubie v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `prerelease` is never read [INFO] [stdout] --> src/cmd/update.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Release { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 16 | tag_name: String, [INFO] [stdout] 17 | prerelease: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Release` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `state` are never read [INFO] [stdout] --> src/cmd/update.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 56 | struct Asset { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 57 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 58 | browser_download_url: String, [INFO] [stdout] 59 | state: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Asset` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `prerelease` is never read [INFO] [stdout] --> src/cmd/update.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Release { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 16 | tag_name: String, [INFO] [stdout] 17 | prerelease: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Release` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/context.rs:32:47 [INFO] [stdout] | [INFO] [stdout] 32 | installed.make_kubeconfig_for_context(&context_name, namespace_name)? [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `context_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `state` are never read [INFO] [stdout] --> src/cmd/update.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 56 | struct Asset { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 57 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 58 | browser_download_url: String, [INFO] [stdout] 59 | state: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Asset` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/context.rs:32:47 [INFO] [stdout] | [INFO] [stdout] 32 | installed.make_kubeconfig_for_context(&context_name, namespace_name)? [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `context_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cmd/exec.rs:21:32 [INFO] [stdout] | [INFO] [stdout] 21 | let signals = Signals::new(&[ [INFO] [stdout] | ________________________________^ [INFO] [stdout] 22 | | signal_hook::SIGHUP, [INFO] [stdout] 23 | | signal_hook::SIGTERM, [INFO] [stdout] 24 | | signal_hook::SIGINT, [INFO] [stdout] ... | [INFO] [stdout] 28 | | signal_hook::SIGUSR2, [INFO] [stdout] 29 | | ]) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 ~ let signals = Signals::new([ [INFO] [stdout] 22 + signal_hook::SIGHUP, [INFO] [stdout] 23 + signal_hook::SIGTERM, [INFO] [stdout] 24 + signal_hook::SIGINT, [INFO] [stdout] 25 + signal_hook::SIGQUIT, [INFO] [stdout] 26 + signal_hook::SIGWINCH, [INFO] [stdout] 27 + signal_hook::SIGUSR1, [INFO] [stdout] 28 + signal_hook::SIGUSR2, [INFO] [stdout] 29 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cmd/exec.rs:21:32 [INFO] [stdout] | [INFO] [stdout] 21 | let signals = Signals::new(&[ [INFO] [stdout] | ________________________________^ [INFO] [stdout] 22 | | signal_hook::SIGHUP, [INFO] [stdout] 23 | | signal_hook::SIGTERM, [INFO] [stdout] 24 | | signal_hook::SIGINT, [INFO] [stdout] ... | [INFO] [stdout] 28 | | signal_hook::SIGUSR2, [INFO] [stdout] 29 | | ]) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 ~ let signals = Signals::new([ [INFO] [stdout] 22 + signal_hook::SIGHUP, [INFO] [stdout] 23 + signal_hook::SIGTERM, [INFO] [stdout] 24 + signal_hook::SIGINT, [INFO] [stdout] 25 + signal_hook::SIGQUIT, [INFO] [stdout] 26 + signal_hook::SIGWINCH, [INFO] [stdout] 27 + signal_hook::SIGUSR1, [INFO] [stdout] 28 + signal_hook::SIGUSR2, [INFO] [stdout] 29 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmd/exec.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | if args.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/cmd/exec.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | if args.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/namespace.rs:65:39 [INFO] [stdout] | [INFO] [stdout] 65 | spawn_shell(settings, config, &session)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `session` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/namespace.rs:65:39 [INFO] [stdout] | [INFO] [stdout] 65 | spawn_shell(settings, config, &session)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `session` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cmd/update.rs:23:45 [INFO] [stdout] | [INFO] [stdout] 23 | let latest_release = attohttpc::get(&LATEST_RELEASE_URL).send()?.json()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `LATEST_RELEASE_URL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cmd/update.rs:23:45 [INFO] [stdout] | [INFO] [stdout] 23 | let latest_release = attohttpc::get(&LATEST_RELEASE_URL).send()?.json()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `LATEST_RELEASE_URL` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cmd/update.rs:92:14 [INFO] [stdout] | [INFO] [stdout] 92 | fs::copy(&new_file, old_file)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `new_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cmd/update.rs:92:14 [INFO] [stdout] | [INFO] [stdout] 92 | fs::copy(&new_file, old_file)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `new_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/fzf.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | !which("fzf").is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `which("fzf").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/fzf.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | !which("fzf").is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `which("fzf").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kubeconfig.rs:214:64 [INFO] [stdout] | [INFO] [stdout] 214 | let kubeconfig: Result = ioutil::read_yaml(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/kubeconfig.rs:214:64 [INFO] [stdout] | [INFO] [stdout] 214 | let kubeconfig: Result = ioutil::read_yaml(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/session.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | / impl Default for Session { [INFO] [stdout] 19 | | fn default() -> Self { [INFO] [stdout] 20 | | Session { history: Vec::new() } [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 14 + #[derive(Default)] [INFO] [stdout] 15 | pub struct Session { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/session.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | / impl Default for Session { [INFO] [stdout] 19 | | fn default() -> Self { [INFO] [stdout] 20 | | Session { history: Vec::new() } [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 14 + #[derive(Default)] [INFO] [stdout] 15 | pub struct Session { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/session.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / for entry in self.history.iter().rev().skip(1) { [INFO] [stdout] 57 | | if current_context.context != entry.context { [INFO] [stdout] 58 | | return Some(entry); [INFO] [stdout] ... | [INFO] [stdout] 61 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.history.iter().rev().skip(1).find(|&entry| current_context.context != entry.context).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/session.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / for entry in self.history.iter().rev().skip(1) { [INFO] [stdout] 57 | | if current_context.context != entry.context { [INFO] [stdout] 58 | | return Some(entry); [INFO] [stdout] ... | [INFO] [stdout] 61 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.history.iter().rev().skip(1).find(|&entry| current_context.context != entry.context).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/settings.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | &*HOME_DIR [INFO] [stdout] | ^^^^^^^^^^ help: try: `&HOME_DIR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/settings.rs:26:38 [INFO] [stdout] | [INFO] [stdout] 26 | format!("{}/{}", home_dir(), &path[2..]) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/settings.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | if path.starts_with("~/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 25 ~ if let Some() = path.strip_prefix("~/") { [INFO] [stdout] 26 ~ format!("{}/{}", home_dir(), ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/settings.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | &*HOME_DIR [INFO] [stdout] | ^^^^^^^^^^ help: try: `&HOME_DIR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/settings.rs:26:38 [INFO] [stdout] | [INFO] [stdout] 26 | format!("{}/{}", home_dir(), &path[2..]) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/settings.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | if path.starts_with("~/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 25 ~ if let Some() = path.strip_prefix("~/") { [INFO] [stdout] 26 ~ format!("{}/{}", home_dir(), ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | let expanded = expanduser(&inc); [INFO] [stdout] | ^^^^ help: change this to: `inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:74:39 [INFO] [stdout] | [INFO] [stdout] 74 | let expanded = expanduser(&exc); [INFO] [stdout] | ^^^^ help: change this to: `exc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/settings.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | / impl Default for Settings { [INFO] [stdout] 85 | | fn default() -> Self { [INFO] [stdout] 86 | | Settings { [INFO] [stdout] 87 | | shell: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Default)] [INFO] [stdout] 34 | pub struct Settings { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | let expanded = expanduser(&inc); [INFO] [stdout] | ^^^^ help: change this to: `inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:74:39 [INFO] [stdout] | [INFO] [stdout] 74 | let expanded = expanduser(&exc); [INFO] [stdout] | ^^^^ help: change this to: `exc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/settings.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | / impl Default for Settings { [INFO] [stdout] 85 | | fn default() -> Self { [INFO] [stdout] 86 | | Settings { [INFO] [stdout] 87 | | shell: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Default)] [INFO] [stdout] 34 | pub struct Settings { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shell/mod.rs:49:44 [INFO] [stdout] | [INFO] [stdout] 49 | Some(shell) => ShellKind::from_str(&shell).ok_or_else(|| anyhow!("Invalid shell setting: {}", shell))?, [INFO] [stdout] | ^^^^^^ help: change this to: `shell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/state.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | &*KUBIE_STATE_PATH [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `&KUBIE_STATE_PATH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vars.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return active == "1"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return active == "1"; [INFO] [stdout] 17 + active == "1" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shell/mod.rs:49:44 [INFO] [stdout] | [INFO] [stdout] 49 | Some(shell) => ShellKind::from_str(&shell).ok_or_else(|| anyhow!("Invalid shell setting: {}", shell))?, [INFO] [stdout] | ^^^^^^ help: change this to: `shell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/state.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | &*KUBIE_STATE_PATH [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `&KUBIE_STATE_PATH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vars.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return active == "1"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return active == "1"; [INFO] [stdout] 17 + active == "1" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.16s [INFO] running `Command { std: "docker" "inspect" "dad673044468bc5862c1e99f4c67c65d8d02810cedf0c54080a8080cd8638573", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dad673044468bc5862c1e99f4c67c65d8d02810cedf0c54080a8080cd8638573", kill_on_drop: false }` [INFO] [stdout] dad673044468bc5862c1e99f4c67c65d8d02810cedf0c54080a8080cd8638573