[INFO] cloning repository https://github.com/hedonhermdev/png-message
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hedonhermdev/png-message" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhedonhermdev%2Fpng-message", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhedonhermdev%2Fpng-message'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] c54017707e8ed5dbaacf3bcc54dabae41676a385
[INFO] linting hedonhermdev/png-message against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhedonhermdev%2Fpng-message" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/hedonhermdev/png-message
[INFO] finished tweaking git repo https://github.com/hedonhermdev/png-message
[INFO] tweaked toml for git repo https://github.com/hedonhermdev/png-message written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/hedonhermdev/png-message on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/hedonhermdev/png-message already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded structopt-derive v0.4.8
[INFO] [stderr]   Downloaded structopt v0.3.15
[INFO] [stderr]   Downloaded hermit-abi v0.1.14
[INFO] [stderr]   Downloaded syn v1.0.31
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 858b9351e46c87e9bfcfc48bb500b4218fde1a8f9afcf868310e89f822cd8b39
[INFO] running `Command { std: "docker" "start" "-a" "858b9351e46c87e9bfcfc48bb500b4218fde1a8f9afcf868310e89f822cd8b39", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "858b9351e46c87e9bfcfc48bb500b4218fde1a8f9afcf868310e89f822cd8b39", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "858b9351e46c87e9bfcfc48bb500b4218fde1a8f9afcf868310e89f822cd8b39", kill_on_drop: false }`
[INFO] [stdout] 858b9351e46c87e9bfcfc48bb500b4218fde1a8f9afcf868310e89f822cd8b39
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] d963d5d35c788424f95c2a1091aed358e8b4e323e07c369f71b37d4bdb2c4627
[INFO] running `Command { std: "docker" "start" "-a" "d963d5d35c788424f95c2a1091aed358e8b4e323e07c369f71b37d4bdb2c4627", kill_on_drop: false }`
[INFO] [stderr]    Compiling syn v1.0.31
[INFO] [stderr]    Compiling libc v0.2.71
[INFO] [stderr]     Checking unicode-width v0.1.7
[INFO] [stderr]    Compiling proc-macro-error-attr v1.0.2
[INFO] [stderr]    Compiling proc-macro-error v1.0.2
[INFO] [stderr]    Compiling quote v1.0.7
[INFO] [stderr]    Compiling anyhow v1.0.31
[INFO] [stderr]    Compiling crc v1.8.1
[INFO] [stderr]     Checking textwrap v0.11.0
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking clap v2.33.1
[INFO] [stderr]    Compiling syn-mid v0.5.0
[INFO] [stderr]    Compiling structopt-derive v0.4.8
[INFO] [stderr]     Checking structopt v0.3.15
[INFO] [stderr]     Checking pngme v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/chunk.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std;
[INFO] [stdout]   | ^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/chunk_type.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use char;
[INFO] [stdout]   | ^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/chunk.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std;
[INFO] [stdout]   | ^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/chunk_type.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use char;
[INFO] [stdout]   | ^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `data_as_string` and `crc` are never used
[INFO] [stdout]    --> src/chunk.rs:105:12
[INFO] [stdout]     |
[INFO] [stdout]  80 | impl Chunk {
[INFO] [stdout]     | ---------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 105 |     pub fn data_as_string(&self) -> Result<String, std::string::FromUtf8Error> {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 109 |     pub fn crc(&self) -> u32 {
[INFO] [stdout]     |            ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `is_reserved_bit_valid`, `is_critical`, `is_public`, `is_valid`, and `is_safe_to_copy` are never used
[INFO] [stdout]   --> src/chunk_type.rs:58:12
[INFO] [stdout]    |
[INFO] [stdout] 53 | impl ChunkType {
[INFO] [stdout]    | -------------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 58 |     pub fn is_reserved_bit_valid(&self) -> bool {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 62 |     pub fn is_critical(&self) -> bool {
[INFO] [stdout]    |            ^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 66 |     pub fn is_public(&self) -> bool {
[INFO] [stdout]    |            ^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 70 |     pub fn is_valid(&self) -> bool {
[INFO] [stdout]    |            ^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 74 |     pub fn is_safe_to_copy(&self) -> bool {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated items `from_chunks` and `chunks` are never used
[INFO] [stdout]   --> src/png.rs:65:12
[INFO] [stdout]    |
[INFO] [stdout] 62 | impl Png {
[INFO] [stdout]    | -------- associated items in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 65 |     pub fn from_chunks(chunks: Vec<Chunk>) -> Png {
[INFO] [stdout]    |            ^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 89 |     pub fn chunks(&self) -> &[Chunk] {
[INFO] [stdout]    |            ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/chunk.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | use std::u32;
[INFO] [stdout]   |     ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `u32::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk.rs:71:9
[INFO] [stdout]    |
[INFO] [stdout] 71 | /         return Ok(Chunk {
[INFO] [stdout] 72 | |             length,
[INFO] [stdout] 73 | |             chunk_type: chunk_type.unwrap(),
[INFO] [stdout] 74 | |             chunk_data,
[INFO] [stdout] 75 | |             crc,
[INFO] [stdout] 76 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 ~         Ok(Chunk {
[INFO] [stdout] 72 +             length,
[INFO] [stdout] 73 +             chunk_type: chunk_type.unwrap(),
[INFO] [stdout] 74 +             chunk_data,
[INFO] [stdout] 75 +             crc,
[INFO] [stdout] 76 ~         })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk.rs:86:9
[INFO] [stdout]    |
[INFO] [stdout] 86 | /         return Chunk {
[INFO] [stdout] 87 | |             length,
[INFO] [stdout] 88 | |             chunk_type,
[INFO] [stdout] 89 | |             chunk_data,
[INFO] [stdout] 90 | |             crc,
[INFO] [stdout] 91 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 ~         Chunk {
[INFO] [stdout] 87 +             length,
[INFO] [stdout] 88 +             chunk_type,
[INFO] [stdout] 89 +             chunk_data,
[INFO] [stdout] 90 +             crc,
[INFO] [stdout] 91 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk.rs:94:9
[INFO] [stdout]    |
[INFO] [stdout] 94 |         return self.length;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 94 -         return self.length;
[INFO] [stdout] 94 +         self.length
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk.rs:98:9
[INFO] [stdout]    |
[INFO] [stdout] 98 |         return &self.chunk_type;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 98 -         return &self.chunk_type;
[INFO] [stdout] 98 +         &self.chunk_type
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/chunk.rs:102:9
[INFO] [stdout]     |
[INFO] [stdout] 102 |         return &self.chunk_data;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 102 -         return &self.chunk_data;
[INFO] [stdout] 102 +         &self.chunk_data
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/chunk.rs:106:9
[INFO] [stdout]     |
[INFO] [stdout] 106 |         return String::from_utf8(self.chunk_data.clone());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 106 -         return String::from_utf8(self.chunk_data.clone());
[INFO] [stdout] 106 +         String::from_utf8(self.chunk_data.clone())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/chunk.rs:110:9
[INFO] [stdout]     |
[INFO] [stdout] 110 |         return self.crc;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 110 -         return self.crc;
[INFO] [stdout] 110 +         self.crc
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/chunk.rs:132:9
[INFO] [stdout]     |
[INFO] [stdout] 132 |         return bytes;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 132 -         return bytes;
[INFO] [stdout] 132 +         bytes
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:22:9
[INFO] [stdout]    |
[INFO] [stdout] 22 |         return Ok(ChunkType { data: value });
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 22 -         return Ok(ChunkType { data: value });
[INFO] [stdout] 22 +         Ok(ChunkType { data: value })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:43:9
[INFO] [stdout]    |
[INFO] [stdout] 43 |         return Ok(ChunkType { data: byte_array });
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 43 -         return Ok(ChunkType { data: byte_array });
[INFO] [stdout] 43 +         Ok(ChunkType { data: byte_array })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stdout]   --> src/chunk_type.rs:34:55
[INFO] [stdout]    |
[INFO] [stdout] 34 |         let string_is_alpha: bool = s.chars().all(|c| (c as char).is_ascii_alphabetic());
[INFO] [stdout]    |                                                       ^^^^^^^^^^^ help: try: `c`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         return self.data;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 55 -         return self.data;
[INFO] [stdout] 55 +         self.data
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         return (self.data[2] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 59 -         return (self.data[2] as char).is_ascii_uppercase();
[INFO] [stdout] 59 +         (self.data[2] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:63:9
[INFO] [stdout]    |
[INFO] [stdout] 63 |         return (self.data[0] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 63 -         return (self.data[0] as char).is_ascii_uppercase();
[INFO] [stdout] 63 +         (self.data[0] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:67:9
[INFO] [stdout]    |
[INFO] [stdout] 67 |         return (self.data[1] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 67 -         return (self.data[1] as char).is_ascii_uppercase();
[INFO] [stdout] 67 +         (self.data[1] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:71:9
[INFO] [stdout]    |
[INFO] [stdout] 71 |         return (self.data[2] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -         return (self.data[2] as char).is_ascii_uppercase();
[INFO] [stdout] 71 +         (self.data[2] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:75:9
[INFO] [stdout]    |
[INFO] [stdout] 75 |         return !(self.data[3] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 75 -         return !(self.data[3] as char).is_ascii_uppercase();
[INFO] [stdout] 75 +         !(self.data[3] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `CLI` contains a capitalized acronym
[INFO] [stdout]  --> src/cli.rs:9:10
[INFO] [stdout]   |
[INFO] [stdout] 9 | pub enum CLI {
[INFO] [stdout]   |          ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]   = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/commands.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 |     return png;
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 26 -     return png;
[INFO] [stdout] 26 +     png
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/commands.rs:70:5
[INFO] [stdout]    |
[INFO] [stdout] 70 |     return Ok(());
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 70 -     return Ok(());
[INFO] [stdout] 70 +     Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used
[INFO] [stdout]   --> src/commands.rs:52:22
[INFO] [stdout]    |
[INFO] [stdout] 52 |     let chunk_data = Vec::try_from(message).unwrap();
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: converting `String` to `Vec<u8>` cannot fail
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
[INFO] [stdout] help: use
[INFO] [stdout]    |
[INFO] [stdout] 52 -     let chunk_data = Vec::try_from(message).unwrap();
[INFO] [stdout] 52 +     let chunk_data = Vec::from(message);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/png.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::u32;
[INFO] [stdout]   |     ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `u32::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/png.rs:66:9
[INFO] [stdout]    |
[INFO] [stdout] 66 | /         return Png {
[INFO] [stdout] 67 | |             header: Png::STANDARD_HEADER,
[INFO] [stdout] 68 | |             chunks,
[INFO] [stdout] 69 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 66 ~         Png {
[INFO] [stdout] 67 +             header: Png::STANDARD_HEADER,
[INFO] [stdout] 68 +             chunks,
[INFO] [stdout] 69 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/png.rs:86:9
[INFO] [stdout]    |
[INFO] [stdout] 86 |         return Ok(());
[INFO] [stdout]    |         ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -         return Ok(());
[INFO] [stdout] 86 +         Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/png.rs:80:29
[INFO] [stdout]    |
[INFO] [stdout] 80 |             .retain(|chunk| !(str::from_utf8(&chunk.chunk_type().bytes()).unwrap() == chunk_type));
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(str::from_utf8(&chunk.chunk_type().bytes()).unwrap() != chunk_type)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/png.rs:100:9
[INFO] [stdout]     |
[INFO] [stdout] 100 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 100 -         return None;
[INFO] [stdout] 100 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Iterator::find`
[INFO] [stdout]    --> src/png.rs:94:9
[INFO] [stdout]     |
[INFO] [stdout]  94 | /         for chunk in self.chunks.iter() {
[INFO] [stdout]  95 | |             if str::from_utf8(&chunk.chunk_type().bytes()).unwrap() == chunk_type {
[INFO] [stdout]  96 | |                 return Some(chunk);
[INFO] [stdout] ...   |
[INFO] [stdout] 100 | |         return None;
[INFO] [stdout]     | |____________________^ help: replace with an iterator: `self.chunks.iter().find(|&chunk| str::from_utf8(&chunk.chunk_type().bytes()).unwrap() == chunk_type).map(|v| v as _)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find
[INFO] [stdout]     = note: `#[warn(clippy::manual_find)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/png.rs:110:9
[INFO] [stdout]     |
[INFO] [stdout] 110 |         return bytes;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 110 -         return bytes;
[INFO] [stdout] 110 +         bytes
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     return cli::CLI::run();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 10 -     return cli::CLI::run();
[INFO] [stdout] 10 +     cli::CLI::run()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/chunk.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | use std::u32;
[INFO] [stdout]   |     ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `u32::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk.rs:71:9
[INFO] [stdout]    |
[INFO] [stdout] 71 | /         return Ok(Chunk {
[INFO] [stdout] 72 | |             length,
[INFO] [stdout] 73 | |             chunk_type: chunk_type.unwrap(),
[INFO] [stdout] 74 | |             chunk_data,
[INFO] [stdout] 75 | |             crc,
[INFO] [stdout] 76 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 ~         Ok(Chunk {
[INFO] [stdout] 72 +             length,
[INFO] [stdout] 73 +             chunk_type: chunk_type.unwrap(),
[INFO] [stdout] 74 +             chunk_data,
[INFO] [stdout] 75 +             crc,
[INFO] [stdout] 76 ~         })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk.rs:86:9
[INFO] [stdout]    |
[INFO] [stdout] 86 | /         return Chunk {
[INFO] [stdout] 87 | |             length,
[INFO] [stdout] 88 | |             chunk_type,
[INFO] [stdout] 89 | |             chunk_data,
[INFO] [stdout] 90 | |             crc,
[INFO] [stdout] 91 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 ~         Chunk {
[INFO] [stdout] 87 +             length,
[INFO] [stdout] 88 +             chunk_type,
[INFO] [stdout] 89 +             chunk_data,
[INFO] [stdout] 90 +             crc,
[INFO] [stdout] 91 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk.rs:94:9
[INFO] [stdout]    |
[INFO] [stdout] 94 |         return self.length;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 94 -         return self.length;
[INFO] [stdout] 94 +         self.length
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk.rs:98:9
[INFO] [stdout]    |
[INFO] [stdout] 98 |         return &self.chunk_type;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 98 -         return &self.chunk_type;
[INFO] [stdout] 98 +         &self.chunk_type
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/chunk.rs:102:9
[INFO] [stdout]     |
[INFO] [stdout] 102 |         return &self.chunk_data;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 102 -         return &self.chunk_data;
[INFO] [stdout] 102 +         &self.chunk_data
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/chunk.rs:106:9
[INFO] [stdout]     |
[INFO] [stdout] 106 |         return String::from_utf8(self.chunk_data.clone());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 106 -         return String::from_utf8(self.chunk_data.clone());
[INFO] [stdout] 106 +         String::from_utf8(self.chunk_data.clone())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/chunk.rs:110:9
[INFO] [stdout]     |
[INFO] [stdout] 110 |         return self.crc;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 110 -         return self.crc;
[INFO] [stdout] 110 +         self.crc
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/chunk.rs:132:9
[INFO] [stdout]     |
[INFO] [stdout] 132 |         return bytes;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 132 -         return bytes;
[INFO] [stdout] 132 +         bytes
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:22:9
[INFO] [stdout]    |
[INFO] [stdout] 22 |         return Ok(ChunkType { data: value });
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 22 -         return Ok(ChunkType { data: value });
[INFO] [stdout] 22 +         Ok(ChunkType { data: value })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:43:9
[INFO] [stdout]    |
[INFO] [stdout] 43 |         return Ok(ChunkType { data: byte_array });
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 43 -         return Ok(ChunkType { data: byte_array });
[INFO] [stdout] 43 +         Ok(ChunkType { data: byte_array })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stdout]   --> src/chunk_type.rs:34:55
[INFO] [stdout]    |
[INFO] [stdout] 34 |         let string_is_alpha: bool = s.chars().all(|c| (c as char).is_ascii_alphabetic());
[INFO] [stdout]    |                                                       ^^^^^^^^^^^ help: try: `c`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         return self.data;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 55 -         return self.data;
[INFO] [stdout] 55 +         self.data
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         return (self.data[2] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 59 -         return (self.data[2] as char).is_ascii_uppercase();
[INFO] [stdout] 59 +         (self.data[2] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:63:9
[INFO] [stdout]    |
[INFO] [stdout] 63 |         return (self.data[0] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 63 -         return (self.data[0] as char).is_ascii_uppercase();
[INFO] [stdout] 63 +         (self.data[0] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:67:9
[INFO] [stdout]    |
[INFO] [stdout] 67 |         return (self.data[1] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 67 -         return (self.data[1] as char).is_ascii_uppercase();
[INFO] [stdout] 67 +         (self.data[1] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:71:9
[INFO] [stdout]    |
[INFO] [stdout] 71 |         return (self.data[2] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -         return (self.data[2] as char).is_ascii_uppercase();
[INFO] [stdout] 71 +         (self.data[2] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/chunk_type.rs:75:9
[INFO] [stdout]    |
[INFO] [stdout] 75 |         return !(self.data[3] as char).is_ascii_uppercase();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 75 -         return !(self.data[3] as char).is_ascii_uppercase();
[INFO] [stdout] 75 +         !(self.data[3] as char).is_ascii_uppercase()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `CLI` contains a capitalized acronym
[INFO] [stdout]  --> src/cli.rs:9:10
[INFO] [stdout]   |
[INFO] [stdout] 9 | pub enum CLI {
[INFO] [stdout]   |          ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]   = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/commands.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 |     return png;
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 26 -     return png;
[INFO] [stdout] 26 +     png
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/commands.rs:70:5
[INFO] [stdout]    |
[INFO] [stdout] 70 |     return Ok(());
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 70 -     return Ok(());
[INFO] [stdout] 70 +     Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used
[INFO] [stdout]   --> src/commands.rs:52:22
[INFO] [stdout]    |
[INFO] [stdout] 52 |     let chunk_data = Vec::try_from(message).unwrap();
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: converting `String` to `Vec<u8>` cannot fail
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
[INFO] [stdout] help: use
[INFO] [stdout]    |
[INFO] [stdout] 52 -     let chunk_data = Vec::try_from(message).unwrap();
[INFO] [stdout] 52 +     let chunk_data = Vec::from(message);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/png.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::u32;
[INFO] [stdout]   |     ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `u32::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/png.rs:66:9
[INFO] [stdout]    |
[INFO] [stdout] 66 | /         return Png {
[INFO] [stdout] 67 | |             header: Png::STANDARD_HEADER,
[INFO] [stdout] 68 | |             chunks,
[INFO] [stdout] 69 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 66 ~         Png {
[INFO] [stdout] 67 +             header: Png::STANDARD_HEADER,
[INFO] [stdout] 68 +             chunks,
[INFO] [stdout] 69 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/png.rs:86:9
[INFO] [stdout]    |
[INFO] [stdout] 86 |         return Ok(());
[INFO] [stdout]    |         ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -         return Ok(());
[INFO] [stdout] 86 +         Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/png.rs:80:29
[INFO] [stdout]    |
[INFO] [stdout] 80 |             .retain(|chunk| !(str::from_utf8(&chunk.chunk_type().bytes()).unwrap() == chunk_type));
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(str::from_utf8(&chunk.chunk_type().bytes()).unwrap() != chunk_type)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/png.rs:100:9
[INFO] [stdout]     |
[INFO] [stdout] 100 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 100 -         return None;
[INFO] [stdout] 100 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Iterator::find`
[INFO] [stdout]    --> src/png.rs:94:9
[INFO] [stdout]     |
[INFO] [stdout]  94 | /         for chunk in self.chunks.iter() {
[INFO] [stdout]  95 | |             if str::from_utf8(&chunk.chunk_type().bytes()).unwrap() == chunk_type {
[INFO] [stdout]  96 | |                 return Some(chunk);
[INFO] [stdout] ...   |
[INFO] [stdout] 100 | |         return None;
[INFO] [stdout]     | |____________________^ help: replace with an iterator: `self.chunks.iter().find(|&chunk| str::from_utf8(&chunk.chunk_type().bytes()).unwrap() == chunk_type).map(|v| v as _)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find
[INFO] [stdout]     = note: `#[warn(clippy::manual_find)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/png.rs:110:9
[INFO] [stdout]     |
[INFO] [stdout] 110 |         return bytes;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 110 -         return bytes;
[INFO] [stdout] 110 +         bytes
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]    --> src/png.rs:123:9
[INFO] [stdout]     |
[INFO] [stdout] 123 | /         let mut chunks = Vec::new();
[INFO] [stdout] 124 | |
[INFO] [stdout] 125 | |         chunks.push(chunk_from_strings("FrSt", "I am the first chunk").unwrap());
[INFO] [stdout] 126 | |         chunks.push(chunk_from_strings("miDl", "I am another chunk").unwrap());
[INFO] [stdout] 127 | |         chunks.push(chunk_from_strings("LASt", "I am the last chunk").unwrap());
[INFO] [stdout]     | |________________________________________________________________________________^ help: consider using the `vec![]` macro: `let chunks = vec![..];`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout]     = note: `#[warn(clippy::vec_init_then_push)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stdout]    --> src/png.rs:253:41
[INFO] [stdout]     |
[INFO] [stdout] 253 |         let expected: Vec<u8> = PNG_FILE.iter().copied().collect();
[INFO] [stdout]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stdout]     = note: `#[warn(clippy::iter_cloned_collect)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     return cli::CLI::run();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 10 -     return cli::CLI::run();
[INFO] [stdout] 10 +     cli::CLI::run()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.13s
[INFO] running `Command { std: "docker" "inspect" "d963d5d35c788424f95c2a1091aed358e8b4e323e07c369f71b37d4bdb2c4627", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d963d5d35c788424f95c2a1091aed358e8b4e323e07c369f71b37d4bdb2c4627", kill_on_drop: false }`
[INFO] [stdout] d963d5d35c788424f95c2a1091aed358e8b4e323e07c369f71b37d4bdb2c4627