[INFO] cloning repository https://github.com/hashcowuwu/todo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hashcowuwu/todo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhashcowuwu%2Ftodo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhashcowuwu%2Ftodo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 56505fb39b9bcf125f8d0d8d27c8fbf174bddfbc [INFO] linting hashcowuwu/todo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhashcowuwu%2Ftodo" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hashcowuwu/todo [INFO] finished tweaking git repo https://github.com/hashcowuwu/todo [INFO] tweaked toml for git repo https://github.com/hashcowuwu/todo written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hashcowuwu/todo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hashcowuwu/todo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.7 [INFO] [stderr] Downloaded clap_derive v4.5.5 [INFO] [stderr] Downloaded clap_builder v4.5.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d59b169b0792df703e55ff460f743ae15ac06d27d63a9b5ed6b20cf1f1939df7 [INFO] running `Command { std: "docker" "start" "-a" "d59b169b0792df703e55ff460f743ae15ac06d27d63a9b5ed6b20cf1f1939df7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d59b169b0792df703e55ff460f743ae15ac06d27d63a9b5ed6b20cf1f1939df7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d59b169b0792df703e55ff460f743ae15ac06d27d63a9b5ed6b20cf1f1939df7", kill_on_drop: false }` [INFO] [stdout] d59b169b0792df703e55ff460f743ae15ac06d27d63a9b5ed6b20cf1f1939df7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7fdd3f8b5005a632b58316705d5321f7d52f3c896d721197ca1383faa48ddbc [INFO] running `Command { std: "docker" "start" "-a" "d7fdd3f8b5005a632b58316705d5321f7d52f3c896d721197ca1383faa48ddbc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking todo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:120:8 [INFO] [stdout] | [INFO] [stdout] 120 | if !args.todo.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `args.todo.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 128 | if !args.del.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `args.del.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.todo` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 120 | if !args.todo.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 121 | let task = args.todo.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.del` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:129:19 [INFO] [stdout] | [INFO] [stdout] 128 | if !args.del.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 129 | let idx = args.del.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx` is used as a loop counter [INFO] [stdout] --> src/main.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | for i in &loaded_data.words { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx, i) in loaded_data.words.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:120:8 [INFO] [stdout] | [INFO] [stdout] 120 | if !args.todo.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `args.todo.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 128 | if !args.del.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `args.del.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.todo` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 120 | if !args.todo.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 121 | let task = args.todo.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.del` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:129:19 [INFO] [stdout] | [INFO] [stdout] 128 | if !args.del.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 129 | let idx = args.del.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx` is used as a loop counter [INFO] [stdout] --> src/main.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | for i in &loaded_data.words { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx, i) in loaded_data.words.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.65s [INFO] running `Command { std: "docker" "inspect" "d7fdd3f8b5005a632b58316705d5321f7d52f3c896d721197ca1383faa48ddbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7fdd3f8b5005a632b58316705d5321f7d52f3c896d721197ca1383faa48ddbc", kill_on_drop: false }` [INFO] [stdout] d7fdd3f8b5005a632b58316705d5321f7d52f3c896d721197ca1383faa48ddbc