[INFO] cloning repository https://github.com/harshRn/snippetbox-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/harshRn/snippetbox-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FharshRn%2Fsnippetbox-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FharshRn%2Fsnippetbox-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d1ab314b01802867098d2d078d78462172fa7346 [INFO] linting harshRn/snippetbox-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FharshRn%2Fsnippetbox-rs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/harshRn/snippetbox-rs [INFO] finished tweaking git repo https://github.com/harshRn/snippetbox-rs [INFO] tweaked toml for git repo https://github.com/harshRn/snippetbox-rs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/harshRn/snippetbox-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/harshRn/snippetbox-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded validator_derive v0.20.0 [INFO] [stderr] Downloaded normalize-path v0.2.1 [INFO] [stderr] Downloaded validator v0.20.0 [INFO] [stderr] Downloaded env_logger v0.11.7 [INFO] [stderr] Downloaded bcrypt v0.17.0 [INFO] [stderr] Downloaded fs-err v3.1.0 [INFO] [stderr] Downloaded askama v0.13.0 [INFO] [stderr] Downloaded askama_parser v0.13.0 [INFO] [stderr] Downloaded askama_derive v0.13.0 [INFO] [stderr] Downloaded sqlx-mysql v0.8.3 [INFO] [stderr] Downloaded jiff-static v0.2.5 [INFO] [stderr] Downloaded async-compression v0.4.22 [INFO] [stderr] Downloaded console-subscriber v0.4.1 [INFO] [stderr] Downloaded axum v0.8.3 [INFO] [stderr] Downloaded sqlx-sqlite v0.8.3 [INFO] [stderr] Downloaded aws-lc-rs v1.13.0 [INFO] [stderr] Downloaded axum-extra v0.10.1 [INFO] [stderr] Downloaded axum-server v0.7.2 [INFO] [stderr] Downloaded console-api v0.8.1 [INFO] [stderr] Downloaded jiff v0.2.5 [INFO] [stderr] Downloaded aws-lc-sys v0.28.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c32b192054b55dc3d734ffa05c71d608e3ee5753bb04faa364990950f78f0149 [INFO] running `Command { std: "docker" "start" "-a" "c32b192054b55dc3d734ffa05c71d608e3ee5753bb04faa364990950f78f0149", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c32b192054b55dc3d734ffa05c71d608e3ee5753bb04faa364990950f78f0149", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c32b192054b55dc3d734ffa05c71d608e3ee5753bb04faa364990950f78f0149", kill_on_drop: false }` [INFO] [stdout] c32b192054b55dc3d734ffa05c71d608e3ee5753bb04faa364990950f78f0149 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf67600cde2215b503aa91f590702ebdd384743665c1cf7ec3fcab568494cabe [INFO] running `Command { std: "docker" "start" "-a" "bf67600cde2215b503aa91f590702ebdd384743665c1cf7ec3fcab568494cabe", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling zerocopy v0.8.24 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling litemap v0.7.5 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling writeable v0.5.5 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.1 [INFO] [stderr] Compiling icu_properties_data v1.5.1 [INFO] [stderr] Compiling zeroize v1.8.1 [INFO] [stderr] Compiling base64ct v1.7.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling icu_normalizer_data v1.5.1 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Compiling write16 v1.0.0 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling utf16_iter v1.0.5 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Compiling der v0.7.9 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling socket2 v0.5.9 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling mio v1.0.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling cc v1.2.16 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling deranged v0.4.0 [INFO] [stderr] Compiling tinyvec v1.9.0 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling tracing-core v0.1.33 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling tokio v1.44.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling spki v0.7.3 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling rustix v1.0.5 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Compiling aws-lc-rs v1.13.0 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling pkcs8 v0.10.2 [INFO] [stderr] Compiling num-iter v0.1.45 [INFO] [stderr] Compiling iana-time-zone v0.1.63 [INFO] [stderr] Compiling time v0.3.41 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling event-listener v5.4.0 [INFO] [stderr] Compiling crc v3.2.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling chrono v0.4.40 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling pkcs1 v0.7.5 [INFO] [stderr] Compiling signature v2.2.0 [INFO] [stderr] Compiling unicode-normalization v0.1.24 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling unicode-bidi v0.3.18 [INFO] [stderr] Compiling unicode-properties v0.1.3 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling linux-raw-sys v0.9.3 [INFO] [stderr] Checking miniz_oxide v0.8.5 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling sha1 v0.10.6 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling whoami v1.6.0 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking rustls-pki-types v1.11.0 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Checking flate2 v1.1.0 [INFO] [stderr] Compiling aws-lc-sys v0.28.2 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling rsa v0.9.8 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Compiling rustls v0.23.26 [INFO] [stderr] Checking brotli-decompressor v4.0.2 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling fs-err v3.1.0 [INFO] [stderr] Compiling winnow v0.7.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling rustc-hash v2.1.1 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking uuid v1.16.0 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking clap_builder v4.5.35 [INFO] [stderr] Checking jiff v0.2.5 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking bcrypt v0.17.0 [INFO] [stderr] Checking normalize-path v0.2.1 [INFO] [stderr] Checking brotli v7.0.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking hdrhistogram v7.5.4 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Compiling axum-macros v0.5.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling zerovec v0.10.4 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking env_logger v0.11.7 [INFO] [stderr] Checking axum-core v0.5.2 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling tinystr v0.7.6 [INFO] [stderr] Compiling icu_collections v1.5.0 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling icu_locid v1.5.0 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling validator_derive v0.20.0 [INFO] [stderr] Compiling icu_provider v1.5.0 [INFO] [stderr] Checking clap v4.5.35 [INFO] [stderr] Compiling icu_locid_transform v1.5.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling icu_properties v1.5.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Compiling icu_normalizer v1.5.0 [INFO] [stderr] Compiling basic-toml v0.1.10 [INFO] [stderr] Compiling askama_parser v0.13.0 [INFO] [stderr] Compiling itertools v0.14.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking validator v0.20.0 [INFO] [stderr] Compiling sqlx-core v0.8.3 [INFO] [stderr] Compiling tempfile v3.19.1 [INFO] [stderr] Compiling prost-derive v0.13.5 [INFO] [stderr] Checking tower-cookies v0.11.0 [INFO] [stderr] Checking prost v0.13.5 [INFO] [stderr] Checking prost-types v0.13.5 [INFO] [stderr] Compiling askama_derive v0.13.0 [INFO] [stderr] Compiling sqlx-mysql v0.8.3 [INFO] [stderr] Checking tokio-util v0.7.14 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tower-sessions-core v0.14.0 [INFO] [stderr] Checking async-compression v0.4.22 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking rustls-webpki v0.103.1 [INFO] [stderr] Checking tower-sessions-memory-store v0.14.0 [INFO] [stderr] Checking h2 v0.4.9 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tower-http v0.6.2 [INFO] [stderr] Checking tower-sessions v0.14.0 [INFO] [stderr] Checking askama v0.13.0 [INFO] [stderr] Compiling sqlx-macros-core v0.8.3 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Compiling sqlx-macros v0.8.3 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking sqlx v0.8.3 [INFO] [stderr] Checking tower-sessions-sqlx-store v0.15.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking axum v0.8.3 [INFO] [stderr] Checking axum-server v0.7.2 [INFO] [stderr] Checking tonic v0.12.3 [INFO] [stderr] Checking console-api v0.8.1 [INFO] [stderr] Checking console-subscriber v0.4.1 [INFO] [stderr] Checking axum-extra v0.10.1 [INFO] [stderr] Checking snippetbox-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `error::DatabaseError` [INFO] [stdout] --> src/handlers.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | use sqlx::{error::DatabaseError, mysql::MySqlDatabaseError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handlers.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | is_authenticated: is_authenticated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_authenticated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handlers.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | is_authenticated: is_authenticated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_authenticated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error::DatabaseError` [INFO] [stdout] --> src/handlers.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | use sqlx::{error::DatabaseError, mysql::MySqlDatabaseError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handlers.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | is_authenticated: is_authenticated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_authenticated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handlers.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | is_authenticated: is_authenticated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_authenticated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `f64::consts::E` [INFO] [stdout] --> src/models/users.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | use std::{error::Error, f64::consts::E}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `f64::consts::E` [INFO] [stdout] --> src/models/users.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | use std::{error::Error, f64::consts::E}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `askama::Template` [INFO] [stdout] --> src/middleware.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use askama::Template; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/middleware.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | middleware::{self, Next}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tower_http::auth` [INFO] [stdout] --> src/middleware.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use tower_http::auth; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `utils::login_form_validation::LoginTemplate` [INFO] [stdout] --> src/middleware.rs:14:38 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::{AppState, Authenticated, utils::login_form_validation::LoginTemplate}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::middleware::from_fn` [INFO] [stdout] --> src/routes.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use axum::middleware::from_fn; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `askama::Template` [INFO] [stdout] --> src/middleware.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use askama::Template; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/middleware.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | middleware::{self, Next}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tower_http::auth` [INFO] [stdout] --> src/middleware.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use tower_http::auth; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `utils::login_form_validation::LoginTemplate` [INFO] [stdout] --> src/middleware.rs:14:38 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::{AppState, Authenticated, utils::login_form_validation::LoginTemplate}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::middleware::from_fn` [INFO] [stdout] --> src/routes.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use axum::middleware::from_fn; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `User` is never constructed [INFO] [stdout] --> src/models/users.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct User { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Nav` is never constructed [INFO] [stdout] --> src/templates/mod.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Nav { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `password` is never read [INFO] [stdout] --> src/utils/login_form_validation.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct LoginTemplate { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 24 | email: String, [INFO] [stdout] 25 | password: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `password` is never read [INFO] [stdout] --> src/utils/signup_form_validation.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct SignupTemplate { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 26 | pub password: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SignupTemplate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handlers.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !snippets.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `snippets.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `snippets` after checking its variant with `is_err` [INFO] [stdout] --> src/handlers.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 34 | if !snippets.is_err() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 35 | let view_snippets = snippets [INFO] [stdout] | _____________________________^ [INFO] [stdout] 36 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/handlers.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / if let Some(flash) = flash_present { [INFO] [stdout] 43 | | if flash.len() > 0 { [INFO] [stdout] 44 | | f = flash; [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 42 ~ if let Some(flash) = flash_present [INFO] [stdout] 43 ~ && flash.len() > 0 { [INFO] [stdout] 44 | f = flash; [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handlers.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | if flash.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!flash.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handlers.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 68 | if !result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/handlers.rs:69:23 [INFO] [stdout] | [INFO] [stdout] 68 | if !result.is_err() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 69 | let snippet = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/handlers.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | / if let Some(flash) = flash_present { [INFO] [stdout] 81 | | if flash.len() > 0 { [INFO] [stdout] 82 | | template.set_flash(flash); [INFO] [stdout] 83 | | } [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 80 ~ if let Some(flash) = flash_present [INFO] [stdout] 81 ~ && flash.len() > 0 { [INFO] [stdout] 82 | template.set_flash(flash); [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handlers.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | if flash.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!flash.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/handlers.rs:201:27 [INFO] [stdout] | [INFO] [stdout] 201 | redirection_uri = format!("/user/login") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/user/login".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/handlers.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | / if let Some(flash) = flash_present { [INFO] [stdout] 214 | | if flash.len() > 0 { [INFO] [stdout] 215 | | login_template.flash = flash; [INFO] [stdout] 216 | | } [INFO] [stdout] 217 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 213 ~ if let Some(flash) = flash_present [INFO] [stdout] 214 ~ && flash.len() > 0 { [INFO] [stdout] 215 | login_template.flash = flash; [INFO] [stdout] 216 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handlers.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 214 | if flash.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!flash.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `User` is never constructed [INFO] [stdout] --> src/models/users.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct User { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Nav` is never constructed [INFO] [stdout] --> src/templates/mod.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Nav { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `password` is never read [INFO] [stdout] --> src/utils/login_form_validation.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct LoginTemplate { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 24 | email: String, [INFO] [stdout] 25 | password: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `password` is never read [INFO] [stdout] --> src/utils/signup_form_validation.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct SignupTemplate { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 26 | pub password: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SignupTemplate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handlers.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !snippets.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `snippets.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `snippets` after checking its variant with `is_err` [INFO] [stdout] --> src/handlers.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 34 | if !snippets.is_err() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 35 | let view_snippets = snippets [INFO] [stdout] | _____________________________^ [INFO] [stdout] 36 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/handlers.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / if let Some(flash) = flash_present { [INFO] [stdout] 43 | | if flash.len() > 0 { [INFO] [stdout] 44 | | f = flash; [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 42 ~ if let Some(flash) = flash_present [INFO] [stdout] 43 ~ && flash.len() > 0 { [INFO] [stdout] 44 | f = flash; [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handlers.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | if flash.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!flash.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handlers.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 68 | if !result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/handlers.rs:69:23 [INFO] [stdout] | [INFO] [stdout] 68 | if !result.is_err() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 69 | let snippet = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/handlers.rs:244:34 [INFO] [stdout] | [INFO] [stdout] 244 | Redirect::to(&redirection_uri).into_response() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `redirection_uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/handlers.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | / if let Some(flash) = flash_present { [INFO] [stdout] 81 | | if flash.len() > 0 { [INFO] [stdout] 82 | | template.set_flash(flash); [INFO] [stdout] 83 | | } [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 80 ~ if let Some(flash) = flash_present [INFO] [stdout] 81 ~ && flash.len() > 0 { [INFO] [stdout] 82 | template.set_flash(flash); [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handlers.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | if flash.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!flash.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/handlers.rs:201:27 [INFO] [stdout] | [INFO] [stdout] 201 | redirection_uri = format!("/user/login") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/user/login".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/handlers.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | / if let Some(flash) = flash_present { [INFO] [stdout] 214 | | if flash.len() > 0 { [INFO] [stdout] 215 | | login_template.flash = flash; [INFO] [stdout] 216 | | } [INFO] [stdout] 217 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 213 ~ if let Some(flash) = flash_present [INFO] [stdout] 214 ~ && flash.len() > 0 { [INFO] [stdout] 215 | login_template.flash = flash; [INFO] [stdout] 216 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handlers.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 214 | if flash.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!flash.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/handlers.rs:244:34 [INFO] [stdout] | [INFO] [stdout] 244 | Redirect::to(&redirection_uri).into_response() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `redirection_uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/snippet.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(e); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Err(e); [INFO] [stdout] 44 + Err(e) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/snippet.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(e); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Err(e); [INFO] [stdout] 44 + Err(e) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/users.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 95 | ... return Ok(res.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Ok(res.id); [INFO] [stdout] 95 + Ok(res.id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/users.rs:112:25 [INFO] [stdout] | [INFO] [stdout] 112 | return Err(Box::new(e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Err(Box::new(e)); [INFO] [stdout] 112 + Err(Box::new(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/users.rs:116:23 [INFO] [stdout] | [INFO] [stdout] 116 | Err(e) => return Err(Box::new(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - Err(e) => return Err(Box::new(e)), [INFO] [stdout] 116 + Err(e) => Err(Box::new(e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/users.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 95 | ... return Ok(res.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Ok(res.id); [INFO] [stdout] 95 + Ok(res.id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/users.rs:112:25 [INFO] [stdout] | [INFO] [stdout] 112 | return Err(Box::new(e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Err(Box::new(e)); [INFO] [stdout] 112 + Err(Box::new(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/users.rs:116:23 [INFO] [stdout] | [INFO] [stdout] 116 | Err(e) => return Err(Box::new(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - Err(e) => return Err(Box::new(e)), [INFO] [stdout] 116 + Err(e) => Err(Box::new(e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/middleware.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / if let Some(rid) = id_opt { [INFO] [stdout] 84 | | id = rid; [INFO] [stdout] 85 | | tracing::info!("id found in session : {}", id); [INFO] [stdout] 86 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 90 | | return next.run(request).await; [INFO] [stdout] 91 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/middleware.rs:82:15 [INFO] [stdout] | [INFO] [stdout] 82 | if let Ok(id_opt) = auth_res { [INFO] [stdout] | ^^^^^^ replace this binding [INFO] [stdout] 83 | if let Some(rid) = id_opt { [INFO] [stdout] | ^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/middleware.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / if let Some(rid) = id_opt { [INFO] [stdout] 84 | | id = rid; [INFO] [stdout] 85 | | tracing::info!("id found in session : {}", id); [INFO] [stdout] 86 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 90 | | return next.run(request).await; [INFO] [stdout] 91 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/middleware.rs:82:15 [INFO] [stdout] | [INFO] [stdout] 82 | if let Ok(id_opt) = auth_res { [INFO] [stdout] | ^^^^^^ replace this binding [INFO] [stdout] 83 | if let Some(rid) = id_opt { [INFO] [stdout] | ^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/utils/form_validation.rs:114:27 [INFO] [stdout] | [INFO] [stdout] 114 | e.into_iter().for_each(|err| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/form_validation.rs:115:45 [INFO] [stdout] | [INFO] [stdout] 115 | ... error_string += &err.message.as_ref().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `err.message.as_ref().unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils/login_form_validation.rs:60:26 [INFO] [stdout] | [INFO] [stdout] 60 | fn validate_email(email: &String) -> Result<(), ValidationError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 - fn validate_email(email: &String) -> Result<(), ValidationError> { [INFO] [stdout] 60 + fn validate_email(email: &str) -> Result<(), ValidationError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/utils/login_form_validation.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 63 | if let None = caps { [INFO] [stdout] | -------^^^^------- help: try: `if caps.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/utils/form_validation.rs:114:27 [INFO] [stdout] | [INFO] [stdout] 114 | e.into_iter().for_each(|err| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/utils/login_form_validation.rs:115:27 [INFO] [stdout] | [INFO] [stdout] 115 | e.into_iter().for_each(|err| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/form_validation.rs:115:45 [INFO] [stdout] | [INFO] [stdout] 115 | ... error_string += &err.message.as_ref().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `err.message.as_ref().unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/login_form_validation.rs:116:45 [INFO] [stdout] | [INFO] [stdout] 116 | ... error_string += &err.message.as_ref().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `err.message.as_ref().unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils/login_form_validation.rs:60:26 [INFO] [stdout] | [INFO] [stdout] 60 | fn validate_email(email: &String) -> Result<(), ValidationError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 - fn validate_email(email: &String) -> Result<(), ValidationError> { [INFO] [stdout] 60 + fn validate_email(email: &str) -> Result<(), ValidationError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/utils/login_form_validation.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 63 | if let None = caps { [INFO] [stdout] | -------^^^^------- help: try: `if caps.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/utils/login_form_validation.rs:115:27 [INFO] [stdout] | [INFO] [stdout] 115 | e.into_iter().for_each(|err| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/login_form_validation.rs:116:45 [INFO] [stdout] | [INFO] [stdout] 116 | ... error_string += &err.message.as_ref().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `err.message.as_ref().unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils/signup_form_validation.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | fn validate_email(email: &String) -> Result<(), ValidationError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - fn validate_email(email: &String) -> Result<(), ValidationError> { [INFO] [stdout] 51 + fn validate_email(email: &str) -> Result<(), ValidationError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/utils/signup_form_validation.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | if let None = caps { [INFO] [stdout] | -------^^^^------- help: try: `if caps.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/utils/signup_form_validation.rs:112:27 [INFO] [stdout] | [INFO] [stdout] 112 | e.into_iter().for_each(|err| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/signup_form_validation.rs:113:45 [INFO] [stdout] | [INFO] [stdout] 113 | ... error_string += &err.message.as_ref().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `err.message.as_ref().unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/main.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | if auth { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils/signup_form_validation.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | fn validate_email(email: &String) -> Result<(), ValidationError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - fn validate_email(email: &String) -> Result<(), ValidationError> { [INFO] [stdout] 51 + fn validate_email(email: &str) -> Result<(), ValidationError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/utils/signup_form_validation.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | if let None = caps { [INFO] [stdout] | -------^^^^------- help: try: `if caps.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/utils/signup_form_validation.rs:112:27 [INFO] [stdout] | [INFO] [stdout] 112 | e.into_iter().for_each(|err| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/signup_form_validation.rs:113:45 [INFO] [stdout] | [INFO] [stdout] 113 | ... error_string += &err.message.as_ref().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `err.message.as_ref().unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:311:5 [INFO] [stdout] | [INFO] [stdout] 304 | / let pool = match MySqlPool::connect_with(dsn).await { [INFO] [stdout] 305 | | Ok(p) => p, [INFO] [stdout] 306 | | Err(e) => { [INFO] [stdout] 307 | | println!("{}", e); [INFO] [stdout] ... | [INFO] [stdout] 310 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 311 | pool [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 304 ~ [INFO] [stdout] 305 ~ match MySqlPool::connect_with(dsn).await { [INFO] [stdout] 306 + Ok(p) => p, [INFO] [stdout] 307 + Err(e) => { [INFO] [stdout] 308 + println!("{}", e); [INFO] [stdout] 309 + panic!(""); [INFO] [stdout] 310 + } [INFO] [stdout] 311 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/main.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | if auth { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:311:5 [INFO] [stdout] | [INFO] [stdout] 304 | / let pool = match MySqlPool::connect_with(dsn).await { [INFO] [stdout] 305 | | Ok(p) => p, [INFO] [stdout] 306 | | Err(e) => { [INFO] [stdout] 307 | | println!("{}", e); [INFO] [stdout] ... | [INFO] [stdout] 310 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 311 | pool [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 304 ~ [INFO] [stdout] 305 ~ match MySqlPool::connect_with(dsn).await { [INFO] [stdout] 306 + Ok(p) => p, [INFO] [stdout] 307 + Err(e) => { [INFO] [stdout] 308 + println!("{}", e); [INFO] [stdout] 309 + panic!(""); [INFO] [stdout] 310 + } [INFO] [stdout] 311 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 18s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 7` [INFO] running `Command { std: "docker" "inspect" "bf67600cde2215b503aa91f590702ebdd384743665c1cf7ec3fcab568494cabe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf67600cde2215b503aa91f590702ebdd384743665c1cf7ec3fcab568494cabe", kill_on_drop: false }` [INFO] [stdout] bf67600cde2215b503aa91f590702ebdd384743665c1cf7ec3fcab568494cabe