[INFO] cloning repository https://github.com/haric95/minigrep [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/haric95/minigrep" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fharic95%2Fminigrep", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fharic95%2Fminigrep'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ee3db8fd1fa3afc5d03a1b03575ca919aabcba81 [INFO] linting haric95/minigrep against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fharic95%2Fminigrep" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/haric95/minigrep [INFO] finished tweaking git repo https://github.com/haric95/minigrep [INFO] tweaked toml for git repo https://github.com/haric95/minigrep written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/haric95/minigrep on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/haric95/minigrep already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 829d8d99a1520e109f9f46947cf255388903995561e193becbcb427f9a64d5a3 [INFO] running `Command { std: "docker" "start" "-a" "829d8d99a1520e109f9f46947cf255388903995561e193becbcb427f9a64d5a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "829d8d99a1520e109f9f46947cf255388903995561e193becbcb427f9a64d5a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "829d8d99a1520e109f9f46947cf255388903995561e193becbcb427f9a64d5a3", kill_on_drop: false }` [INFO] [stdout] 829d8d99a1520e109f9f46947cf255388903995561e193becbcb427f9a64d5a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5047df91c152b9413c74198fd5fb4070109048f54b44ab64087fe2555def3ce3 [INFO] running `Command { std: "docker" "start" "-a" "5047df91c152b9413c74198fd5fb4070109048f54b44ab64087fe2555def3ce3", kill_on_drop: false }` [INFO] [stderr] Checking minigrep v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 35 | case_insensitive: !env::var("CASE_INSENSITIVE").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CASE_INSENSITIVE").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return Ok(Config { [INFO] [stdout] 25 | | query, [INFO] [stdout] 26 | | filename, [INFO] [stdout] ... | [INFO] [stdout] 29 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ Ok(Config { [INFO] [stdout] 25 + query, [INFO] [stdout] 26 + filename, [INFO] [stdout] 27 + // Alternatively find a nicer way of parsing the string to bool. [INFO] [stdout] 28 + case_insensitive: case_insensitive == "true", [INFO] [stdout] 29 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return Ok(Config { [INFO] [stdout] 33 | | query, [INFO] [stdout] 34 | | filename, [INFO] [stdout] 35 | | case_insensitive: !env::var("CASE_INSENSITIVE").is_err(), [INFO] [stdout] 36 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Ok(Config { [INFO] [stdout] 33 + query, [INFO] [stdout] 34 + filename, [INFO] [stdout] 35 + case_insensitive: !env::var("CASE_INSENSITIVE").is_err(), [INFO] [stdout] 36 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 35 | case_insensitive: !env::var("CASE_INSENSITIVE").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CASE_INSENSITIVE").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return Ok(Config { [INFO] [stdout] 25 | | query, [INFO] [stdout] 26 | | filename, [INFO] [stdout] ... | [INFO] [stdout] 29 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ Ok(Config { [INFO] [stdout] 25 + query, [INFO] [stdout] 26 + filename, [INFO] [stdout] 27 + // Alternatively find a nicer way of parsing the string to bool. [INFO] [stdout] 28 + case_insensitive: case_insensitive == "true", [INFO] [stdout] 29 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return Ok(Config { [INFO] [stdout] 33 | | query, [INFO] [stdout] 34 | | filename, [INFO] [stdout] 35 | | case_insensitive: !env::var("CASE_INSENSITIVE").is_err(), [INFO] [stdout] 36 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Ok(Config { [INFO] [stdout] 33 + query, [INFO] [stdout] 34 + filename, [INFO] [stdout] 35 + case_insensitive: !env::var("CASE_INSENSITIVE").is_err(), [INFO] [stdout] 36 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s [INFO] running `Command { std: "docker" "inspect" "5047df91c152b9413c74198fd5fb4070109048f54b44ab64087fe2555def3ce3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5047df91c152b9413c74198fd5fb4070109048f54b44ab64087fe2555def3ce3", kill_on_drop: false }` [INFO] [stdout] 5047df91c152b9413c74198fd5fb4070109048f54b44ab64087fe2555def3ce3