[INFO] cloning repository https://github.com/hannes-dev/aoc2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/hannes-dev/aoc2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhannes-dev%2Faoc2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhannes-dev%2Faoc2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c834acf01068407fdc3d007cd61fe6462d1317cc [INFO] linting hannes-dev/aoc2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fhannes-dev%2Faoc2023" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/hannes-dev/aoc2023 [INFO] finished tweaking git repo https://github.com/hannes-dev/aoc2023 [INFO] tweaked toml for git repo https://github.com/hannes-dev/aoc2023 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/hannes-dev/aoc2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/hannes-dev/aoc2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c45e13b4f887d14e3afa0ad80f9ed4f6b750c0957be14ce6f338a72cb5380b2 [INFO] running `Command { std: "docker" "start" "-a" "0c45e13b4f887d14e3afa0ad80f9ed4f6b750c0957be14ce6f338a72cb5380b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c45e13b4f887d14e3afa0ad80f9ed4f6b750c0957be14ce6f338a72cb5380b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c45e13b4f887d14e3afa0ad80f9ed4f6b750c0957be14ce6f338a72cb5380b2", kill_on_drop: false }` [INFO] [stdout] 0c45e13b4f887d14e3afa0ad80f9ed4f6b750c0957be14ce6f338a72cb5380b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4348c0dbe87c0166c2536733f2f1127283866773a3cb9b78ff115d96da9c2da8 [INFO] running `Command { std: "docker" "start" "-a" "4348c0dbe87c0166c2536733f2f1127283866773a3cb9b78ff115d96da9c2da8", kill_on_drop: false }` [INFO] [stderr] Checking aoc2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/days/day01.rs:19:30 [INFO] [stdout] | [INFO] [stdout] 19 | fn find_number_or_text(line: &String) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn find_number_or_text(line: &String) -> u32 { [INFO] [stdout] 19 + fn find_number_or_text(line: &str) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/days/day01.rs:54:25 [INFO] [stdout] | [INFO] [stdout] 54 | fn find_number_p1(line: &String) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - fn find_number_p1(line: &String) -> u32 { [INFO] [stdout] 54 + fn find_number_p1(line: &str) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/day01.rs:55:39 [INFO] [stdout] | [INFO] [stdout] 55 | let first = line.chars().find(|x| x.is_digit(10)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/day01.rs:56:44 [INFO] [stdout] | [INFO] [stdout] 56 | let last = line.chars().rev().find(|x| x.is_digit(10)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/days/day03.rs:76:33 [INFO] [stdout] | [INFO] [stdout] 76 | fn parse(lines: Vec) -> (HashMap<(isize, isize), char>, Vec<(isize, Vec, u32)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day03.rs:95:16 [INFO] [stdout] | [INFO] [stdout] 95 | if !(letter == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(letter != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/day03.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | if letter.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `letter.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/days/day05.rs:140:23 [INFO] [stdout] | [INFO] [stdout] 140 | fn line_to_nums(line: &String) -> MapRange { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 140 - fn line_to_nums(line: &String) -> MapRange { [INFO] [stdout] 140 + fn line_to_nums(line: &str) -> MapRange { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/days/day08.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | fn count_steps(instructions: &String, nodes: &HashMap, node: String, end_condition: F) -> u32 [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - fn count_steps(instructions: &String, nodes: &HashMap, node: String, end_condition: F) -> u32 [INFO] [stdout] 26 + fn count_steps(instructions: &str, nodes: &HashMap, node: String, end_condition: F) -> u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/days/day09.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | prev_last = history[i].last().unwrap() + prev_last; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_last += history[i].last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | lines(&Path::new(&args[3])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(&args[3])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | lines(&Path::new(&format!("./input/{day}_test.txt"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(&format!("./input/{day}_test.txt"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/days/day01.rs:19:30 [INFO] [stdout] | [INFO] [stdout] 19 | fn find_number_or_text(line: &String) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn find_number_or_text(line: &String) -> u32 { [INFO] [stdout] 19 + fn find_number_or_text(line: &str) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/days/day01.rs:54:25 [INFO] [stdout] | [INFO] [stdout] 54 | fn find_number_p1(line: &String) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - fn find_number_p1(line: &String) -> u32 { [INFO] [stdout] 54 + fn find_number_p1(line: &str) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/day01.rs:55:39 [INFO] [stdout] | [INFO] [stdout] 55 | let first = line.chars().find(|x| x.is_digit(10)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/day01.rs:56:44 [INFO] [stdout] | [INFO] [stdout] 56 | let last = line.chars().rev().find(|x| x.is_digit(10)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `x.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/days/day03.rs:76:33 [INFO] [stdout] | [INFO] [stdout] 76 | fn parse(lines: Vec) -> (HashMap<(isize, isize), char>, Vec<(isize, Vec, u32)>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day03.rs:95:16 [INFO] [stdout] | [INFO] [stdout] 95 | if !(letter == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(letter != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/days/day03.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | if letter.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `letter.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/days/day05.rs:140:23 [INFO] [stdout] | [INFO] [stdout] 140 | fn line_to_nums(line: &String) -> MapRange { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 140 - fn line_to_nums(line: &String) -> MapRange { [INFO] [stdout] 140 + fn line_to_nums(line: &str) -> MapRange { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/days/day08.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | fn count_steps(instructions: &String, nodes: &HashMap, node: String, end_condition: F) -> u32 [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - fn count_steps(instructions: &String, nodes: &HashMap, node: String, end_condition: F) -> u32 [INFO] [stdout] 26 + fn count_steps(instructions: &str, nodes: &HashMap, node: String, end_condition: F) -> u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/days/day09.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | prev_last = history[i].last().unwrap() + prev_last; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_last += history[i].last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | lines(&Path::new(&args[3])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(&args[3])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | lines(&Path::new(&format!("./input/{day}_test.txt"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(&format!("./input/{day}_test.txt"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `Command { std: "docker" "inspect" "4348c0dbe87c0166c2536733f2f1127283866773a3cb9b78ff115d96da9c2da8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4348c0dbe87c0166c2536733f2f1127283866773a3cb9b78ff115d96da9c2da8", kill_on_drop: false }` [INFO] [stdout] 4348c0dbe87c0166c2536733f2f1127283866773a3cb9b78ff115d96da9c2da8